Re: [PATCH v2 1/2] virtio: VIRTIO_F_IOMMU_PLATFORM -> VIRTIO_F_ACCESS_PLATFORM

2020-06-24 Thread David Hildenbrand
On 25.06.20 01:21, Michael S. Tsirkin wrote: > Rename the bit to match latest virtio spec. > Add a compat macro to avoid breaking existing userspace. > > Signed-off-by: Michael S. Tsirkin > --- > arch/um/drivers/virtio_uml.c | 2 +- > drivers/vdpa/ifcvf/ifcvf_base.h| 2 +- > drivers/

Re: [bpf PATCH] bpf, sockmap: RCU splat with TLS redirect and strparser

2020-06-24 Thread Martin KaFai Lau
On Wed, Jun 24, 2020 at 02:09:23PM -0700, John Fastabend wrote: > Redirect on non-TLS sockmap side has RCU lock held from sockmap code > path but when called from TLS this is no longer true. The RCU section > is needed because we use rcu dereference to fetch the psock of the > socket we are redirec

Re: [ethtool v2 3/6] json_writer: Import the iproute2 helper code for JSON output

2020-06-24 Thread Stephen Hemminger
On Thu, 25 Jun 2020 02:12:41 +0200 Andrew Lunn wrote: > In general, Linux network tools use JSON for machine readable output. > See for example -json for iproute2 and devlink. In order to support > JSON output from ethtool, import the iproute2 helper code. > > Maybe some time in the future it wo

Re: [ethtool v2 4/6] Add --json command line argument parsing

2020-06-24 Thread Stephen Hemminger
On Thu, 25 Jun 2020 02:12:42 +0200 Andrew Lunn wrote: > diff --git a/internal.h b/internal.h > index edb07bd..7135140 100644 > --- a/internal.h > +++ b/internal.h > @@ -23,6 +23,8 @@ > #include > #include > > +#include "json_writer.h" > + > #define maybe_unused __attribute__((__unused__))

Re: [ethtool v2 3/6] json_writer: Import the iproute2 helper code for JSON output

2020-06-24 Thread Stephen Hemminger
On Thu, 25 Jun 2020 02:12:41 +0200 Andrew Lunn wrote: > In general, Linux network tools use JSON for machine readable output. > See for example -json for iproute2 and devlink. In order to support > JSON output from ethtool, import the iproute2 helper code. > > Maybe some time in the future it wo

Re: [PATCH bpf-next 3/3] selftests/bpf: add bpf_iter test with bpf_get_task_stack_trace()

2020-06-24 Thread Yonghong Song
On 6/24/20 1:37 PM, Song Liu wrote: On Jun 23, 2020, at 3:27 PM, Yonghong Song wrote: On 6/23/20 3:07 PM, Song Liu wrote: On Jun 23, 2020, at 11:57 AM, Yonghong Song wrote: On 6/23/20 12:08 AM, Song Liu wrote: The new test is similar to other bpf_iter tests. Signed-off-by: Song Li

RE: [PATCH net-next 3/5] dpaa2-eth: fix condition for number of buffer acquire retries

2020-06-24 Thread Ioana Ciornei
> Subject: Re: [PATCH net-next 3/5] dpaa2-eth: fix condition for number of > buffer > acquire retries > > On Wed, 24 Jun 2020 14:34:19 +0300 Ioana Ciornei wrote: > > We should keep retrying to acquire buffers through the software > > portals as long as the function returns -EBUSY and the number o

Re: [v2,net-next 4/4] net: enetc add tc flower offload flow metering policing action

2020-06-24 Thread David Miller
From: Po Liu Date: Wed, 24 Jun 2020 17:36:31 +0800 > From: Po Liu > > Flow metering entries in IEEE 802.1Qci is an optional function for a > flow filtering module. Flow metering is two rates two buckets and three > color marker to policing the frames. This patch only enable one rate one > bucke

Re: [v2,net-next 2/4] net: enetc: add support max frame size for tc flower offload

2020-06-24 Thread David Miller
From: Po Liu Date: Wed, 24 Jun 2020 17:36:29 +0800 > From: Po Liu > > Base on the tc flower offload police action add max frame size by the > parameter 'mtu'. Tc flower device driver working by the IEEE 802.1Qci > stream filter can implement the max frame size filtering. Add it to the > current

Re: [v2,net-next 3/4] net: qos: police action add index for tc flower offloading

2020-06-24 Thread David Miller
From: Po Liu Date: Wed, 24 Jun 2020 17:36:30 +0800 > From: Po Liu > > Hardware device may include more than one police entry. Specifying the > action's index make it possible for several tc filters to share the same > police action when installing the filters. > > Propagate this index to devic

Re: [v2,net-next 1/4] net: qos: add tc police offloading action with max frame size limit

2020-06-24 Thread David Miller
From: Po Liu Date: Wed, 24 Jun 2020 17:36:28 +0800 > From: Po Liu > > Current police offloading support the 'burst'' and 'rate_bytes_ps'. Some > hardware own the capability to limit the frame size. If the frame size > larger than the setting, the frame would be dropped. For the police > action

Re: [pull request][net-next V3 0/9] mlx5 updates 2020-06-23

2020-06-24 Thread David Miller
From: Saeed Mahameed Date: Tue, 23 Jun 2020 21:46:06 -0700 > Hi Dave, Jakub > > This series adds misc updates and one small feature, Relaxed ordering, > to mlx5 driver. > > v1->v2: > - Removed unnecessary Fixes Tags > > v2->v3: > - Drop "macro undefine" patch, it has no value > > For more

[Question]many kernel error "neighbour: ndisc_cache: neighbor table overflow!"

2020-06-24 Thread Jack Wang
Hi Folks, In one of our big cluster, due to capacity increase, more servers are added to the cluster, and we saw from many pserver reporting error message below: "neighbour: ndisc_cache: neighbor table overflow!" We've tested increasing the gc_thresh values in sysctl.conf, after reboot, the erro

Re: [PATCH net 0/3] net: bcmgenet: use hardware padding of runt frames

2020-06-24 Thread David Miller
From: Doug Berger Date: Wed, 24 Jun 2020 18:14:52 -0700 > Now that scatter-gather and tx-checksumming are enabled by default > it revealed a packet corruption issue that can occur for very short > fragmented packets. > > When padding these frames to the minimum length it is possible for > the no

[net-next PATCH v1] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver

2020-06-24 Thread Calvin Johnson
Modify dpaa2_mac_connect() to support ACPI along with DT. Modify dpaa2_mac_get_node() to get the dpmac fwnode from either DT or ACPI. Replace of_get_phy_mode() with fwnode_get_phy_mode() to get phy-mode for a dpmac_node. Define and use helper function dpaa2_find_phy_device() to find phy_dev that is

Re: KASAN: null-ptr-deref Write in blk_mq_map_swqueue

2020-06-24 Thread Bart Van Assche
On 2020-06-24 20:01, syzbot wrote: > This bug is marked as fixed by commit: > blk-mq: Fix a recently introduced regression in > But I can't find it in any tested tree for more than 90 days. > Is it a correct commit? Please update it by replying: > #syz fix: exact-commit-title > Until then the bug i

Re: [PATCH v3 0/2] net: phy: call phy_disable_interrupts() in phy_init_hw()

2020-06-24 Thread Florian Fainelli
On 6/24/2020 4:34 PM, David Miller wrote: > From: Florian Fainelli > Date: Wed, 24 Jun 2020 15:10:51 -0700 > >> Did you mean that you applied v4? It does not look like you pushed your >> local changes to net-next yet, so I cannot tell for sure. > > I ended up applying v4, yes. > OK, just ma

Re: KASAN: null-ptr-deref Write in blk_mq_map_swqueue

2020-06-24 Thread syzbot
This bug is marked as fixed by commit: blk-mq: Fix a recently introduced regression in But I can't find it in any tested tree for more than 90 days. Is it a correct commit? Please update it by replying: #syz fix: exact-commit-title Until then the bug is still considered open and new crashes with th

Re: [PATCH net-next 5/5] ipv6: ioam: Documentation for new IOAM sysctls

2020-06-24 Thread Tom Herbert
On Wed, Jun 24, 2020 at 12:33 PM Justin Iurman wrote: > > Add documentation for new IOAM sysctls: > - ioam6_id: a namespace sysctl > - ioam6_enabled and ioam6_id: two per-interface sysctls > Are you planning add a more detailed description of the feature and how to use it (would be nice I think

[PATCH] [net/ipv6] Remove redundant null check in rt_mt6

2020-06-24 Thread Gaurav Singh
rh cannot be NULL here since its already checked above assignment and is being dereferenced before. Remove the redundant null check. Signed-off-by: Gaurav Singh --- net/ipv6/netfilter/ip6t_rt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/ipv6/netfilter/ip6t_rt.c b/n

[PATCH] [net/ipv6] Remove redundant null check in hbh_mt6

2020-06-24 Thread Gaurav Singh
oh cannot be NULL since its already checked above after assignment and is being dereferenced before. Remove the redundant null check. Signed-off-by: Gaurav Singh --- net/ipv6/netfilter/ip6t_hbh.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/ipv6/netfilter/ip6t_hbh.c

Re: [PATCH net-next 3/5] ipv6: ioam: Data plane support for Pre-allocated Trace

2020-06-24 Thread Tom Herbert
On Wed, Jun 24, 2020 at 12:33 PM Justin Iurman wrote: > > Implement support for processing the IOAM Pre-allocated Trace with IPv6, > see [1] and [2]. Introduce a new IPv6 Hop-by-Hop TLV option > IPV6_TLV_IOAM_HOPOPTS, see IANA [3]. > > A per-interface sysctl ioam6_enabled is provided to accept/dro

[PATCH] [net/ipv6] remove redundant null check in frag_mt6

2020-06-24 Thread Gaurav Singh
fh cannot be NULL since its already checked above after assignment and is being dereferenced before. Remove the redundant null check. Signed-off-by: Gaurav Singh --- net/ipv6/netfilter/ip6t_frag.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/ipv6/netfilter/ip6t_frag.

[PATCH] [net/ipv6] Remove redundant null check in ah_mt6

2020-06-24 Thread Gaurav Singh
ah cannot be NULL since its already checked above after assignment and is being dereferenced before in pr(). Remove the redundant null check. Signed-off-by: Gaurav Singh --- net/ipv6/netfilter/ip6t_ah.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/ipv6/netfilter/ip6t

Re: [PATCH 1/5] Huawei BMA: Adding Huawei BMA driver: host_edma_drv

2020-06-24 Thread kernel test robot
Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on sparc-next/master] [also build test ERROR on linux/master linus/master ipvs/master v5.8-rc2] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use as do

Re: [PATCH net-next 2/5] ipv6: IOAM tunnel decapsulation

2020-06-24 Thread Tom Herbert
On Wed, Jun 24, 2020 at 12:33 PM Justin Iurman wrote: > > Implement the IOAM egress behavior. > > According to RFC 8200: > "Extension headers (except for the Hop-by-Hop Options header) are not > processed, inserted, or deleted by any node along a packet's delivery > path, until the packet reache

Re: [PATCH v3 1/1] eventfd: implementation of EFD_MASK flag

2020-06-24 Thread Laurent Pinchart
Hi Damian, On Tue, Jun 23, 2020 at 06:21:28PM +0900, Damian Hobson-Garcia wrote: > On 2020-06-19 7:16 p.m., Paul Elder wrote: > > Hello Damian, Martin, and all, > > > > I came across this (quite old by now) patch to extend eventfd's polling > > functionality. I was wondering what happened to it (

Re: [PATCH net 1/3] net: bcmgenet: re-remove bcmgenet_hfb_add_filter

2020-06-24 Thread Florian Fainelli
On 6/24/2020 6:14 PM, Doug Berger wrote: > This function was originally removed by Baoyou Xie in > commit e2072600a241 ("net: bcmgenet: remove unused function in > bcmgenet.c") to prevent a build warning. > > Some of the functions removed by Baoyou Xie are now used for > WAKE_FILTER support so

Re: [PATCH net 2/3] net: bcmgenet: use __be16 for htons(ETH_P_IP)

2020-06-24 Thread Florian Fainelli
On 6/24/2020 6:14 PM, Doug Berger wrote: > The 16-bit value that holds a short in network byte order should > be declared as a restricted big endian type to allow type checks > to succeed during assignment. > > Fixes: 3e370952287c ("net: bcmgenet: add support for ethtool rxnfc flows") > Reporte

Re: [PATCH net 3/3] net: bcmgenet: use hardware padding of runt frames

2020-06-24 Thread Florian Fainelli
On 6/24/2020 6:14 PM, Doug Berger wrote: > When commit 474ea9cafc45 ("net: bcmgenet: correctly pad short > packets") added the call to skb_padto() it should have been > located before the nr_frags parameter was read since that value > could be changed when padding packets with lengths between 55

Re: [PATCH bpf-next v5 00/15] implement bpf iterator for tcp and udp sockets

2020-06-24 Thread Alexei Starovoitov
On Tue, Jun 23, 2020 at 4:08 PM Yonghong Song wrote: > > bpf iterator implments traversal of kernel data structures and these > data structures are passed to a bpf program for processing. > This gives great flexibility for users to examine kernel data > structure without using e.g. /proc/net which

[PATCH net 1/3] net: bcmgenet: re-remove bcmgenet_hfb_add_filter

2020-06-24 Thread Doug Berger
This function was originally removed by Baoyou Xie in commit e2072600a241 ("net: bcmgenet: remove unused function in bcmgenet.c") to prevent a build warning. Some of the functions removed by Baoyou Xie are now used for WAKE_FILTER support so his commit was reverted, but this function is still unus

[PATCH net 3/3] net: bcmgenet: use hardware padding of runt frames

2020-06-24 Thread Doug Berger
When commit 474ea9cafc45 ("net: bcmgenet: correctly pad short packets") added the call to skb_padto() it should have been located before the nr_frags parameter was read since that value could be changed when padding packets with lengths between 55 and 59 bytes (inclusive). The use of a stale nr_fr

[PATCH net 2/3] net: bcmgenet: use __be16 for htons(ETH_P_IP)

2020-06-24 Thread Doug Berger
The 16-bit value that holds a short in network byte order should be declared as a restricted big endian type to allow type checks to succeed during assignment. Fixes: 3e370952287c ("net: bcmgenet: add support for ethtool rxnfc flows") Reported-by: kbuild test robot Signed-off-by: Doug Berger ---

[PATCH net 0/3] net: bcmgenet: use hardware padding of runt frames

2020-06-24 Thread Doug Berger
Now that scatter-gather and tx-checksumming are enabled by default it revealed a packet corruption issue that can occur for very short fragmented packets. When padding these frames to the minimum length it is possible for the non-linear (fragment) data to be added to the end of the linear header i

Re: Generic Netlink multipart messages

2020-06-24 Thread Jakub Kicinski
On Wed, 24 Jun 2020 11:59:00 -0300 Matheus Rodrigues wrote: > I'm trying to send a relatively "big" string (+/- 60Kb) through > generic netlink, for this, I know that I've to use the multipart > mechanism offered by the API, using the flags NLM_F_MULTI and > NLMSG_DONE, but I don't know how to impl

Re: [PATCH net-next 3/5] dpaa2-eth: fix condition for number of buffer acquire retries

2020-06-24 Thread Jakub Kicinski
On Wed, 24 Jun 2020 14:34:19 +0300 Ioana Ciornei wrote: > We should keep retrying to acquire buffers through the software portals > as long as the function returns -EBUSY and the number of retries is > __below__ DPAA2_ETH_SWP_BUSY_RETRIES. > > Fixes: ef17bd7cc0c8 ("dpaa2-eth: Avoid unbounded while

Re: [GIT PULL] virtio: fixes, tests

2020-06-24 Thread pr-tracker-bot
The pull request you sent on Wed, 24 Jun 2020 05:08:01 -0400: > https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/fc10807db5ced090d83cec167e87c95a47452d24 Thank you! -- Deet-doot-dot, I am a b

Re: [PATCH net-next v3 5/7] net: phy: enable qoriq backplane support

2020-06-24 Thread kernel test robot
Hi Florinel, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Florinel-Iordache/doc-net-add-backplane-documentation/20200622-223623 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/n

RE:Re: [v1,net-next 3/4] net: qos: police action add index for tc flower offloading

2020-06-24 Thread Po Liu
> -Original Message- > From: Jamal Hadi Salim > Sent: 2020年6月24日 20:45 > To: Po Liu ; da...@davemloft.net; linux- > ker...@vger.kernel.org; netdev@vger.kernel.org; ido...@idosch.org > Cc: j...@resnulli.us; vinicius.go...@intel.com; v...@buslov.dev; Claudiu > Manoil ; Vladimir Oltean > ;

[ethtool v2 5/6] ethtool.8.in: Document the cable test commands

2020-06-24 Thread Andrew Lunn
Extend the man page with --cable-test and --cable-test-tdr commands. Signed-off-by: Andrew Lunn --- v2: Fixup some grammar/English errors. --- ethtool.8.in | 45 + 1 file changed, 45 insertions(+) diff --git a/ethtool.8.in b/ethtool.8.in index 9c5f45c

[ethtool v2 2/6] Add cable test TDR support

2020-06-24 Thread Andrew Lunn
Add support for accessing the cable test time domain reflectromatry data. Add a new command --cable-test-tdr, and support for dumping the data which is returned. signed-off-by: Andrew Lunn --- ethtool.c| 8 ++ netlink/cable_test.c | 289 +++

[ethtool v2 3/6] json_writer: Import the iproute2 helper code for JSON output

2020-06-24 Thread Andrew Lunn
In general, Linux network tools use JSON for machine readable output. See for example -json for iproute2 and devlink. In order to support JSON output from ethtool, import the iproute2 helper code. Maybe some time in the future it would make sense to either have a shared library, or to merge ethtoo

[ethtool v2 1/6] Add cable test support

2020-06-24 Thread Andrew Lunn
Add support for starting a cable test, and report the results. This code does not follow the usual patterns because of the way the kernel reports the results of the cable test. It can take a number of seconds for cable testing to occur. So the action request messages is immediately acknowledges, a

[ethtool v2 6/6] ethtool.8.in: Add --json option

2020-06-24 Thread Andrew Lunn
Document the --json option, which the --cable-test and --cable-test-tdr options support. Signed-off-by: Andrew Lunn --- ethtool.8.in | 8 1 file changed, 8 insertions(+) diff --git a/ethtool.8.in b/ethtool.8.in index 8b78b17..b2bdd43 100644 --- a/ethtool.8.in +++ b/ethtool.8.in @@ -137

[ethtool v2 4/6] Add --json command line argument parsing

2020-06-24 Thread Andrew Lunn
Allow --json to be passed as an option to select JSON output. The option is handled in the same way as --debug, setting a variable in the command context, which can then later be used per option to select JSON outputters. Signed-off-by: Andrew Lunn --- ethtool.c| 33 ++--- inter

[ethtool v2 0/6] ethtool(1) cable test support

2020-06-24 Thread Andrew Lunn
Add the user space side of the ethtool cable test. The TDR output is most useful when fed to some other tool which can visualize the data. So add JSON support, by borrowing code from iproute2. v2: man page fixes. Andrew Lunn (6): Add cable test support Add cable test TDR support json_write

Re: [PATCH v3 0/2] net: phy: call phy_disable_interrupts() in phy_init_hw()

2020-06-24 Thread David Miller
From: Florian Fainelli Date: Wed, 24 Jun 2020 15:10:51 -0700 > Did you mean that you applied v4? It does not look like you pushed your > local changes to net-next yet, so I cannot tell for sure. I ended up applying v4, yes.

[PATCH v2 1/2] virtio: VIRTIO_F_IOMMU_PLATFORM -> VIRTIO_F_ACCESS_PLATFORM

2020-06-24 Thread Michael S. Tsirkin
Rename the bit to match latest virtio spec. Add a compat macro to avoid breaking existing userspace. Signed-off-by: Michael S. Tsirkin --- arch/um/drivers/virtio_uml.c | 2 +- drivers/vdpa/ifcvf/ifcvf_base.h| 2 +- drivers/vdpa/vdpa_sim/vdpa_sim.c | 4 ++-- drivers/vhost/net.c

Re: [PATCH net-next 3/5] ipv6: ioam: Data plane support for Pre-allocated Trace

2020-06-24 Thread kernel test robot
/kernel/git/davem/net-next.git 0558c396040734bc1d361919566a581fd41aa539 config: i386-randconfig-s002-20200624 (attached as .config) compiler: gcc-9 (Debian 9.3.0-13) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.2-dirty # save the attached .config to linux

[RFC PATCH] ipv6: ioam: ioam6_fill_trace_data_node() can be static

2020-06-24 Thread kernel test robot
Signed-off-by: kernel test robot --- ioam6.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv6/ioam6.c b/net/ipv6/ioam6.c index 406aa78eb504c..4a4e72bb54cc5 100644 --- a/net/ipv6/ioam6.c +++ b/net/ipv6/ioam6.c @@ -78,8 +78,8 @@ struct ioam6_namespace *ioam6_nam

[PATCH] virtio: VIRTIO_F_IOMMU_PLATFORM -> VIRTIO_F_ACCESS_PLATFORM

2020-06-24 Thread Michael S. Tsirkin
Rename the bit to match latest virtio spec. Add a compat macro to avoid breaking existing userspace. Signed-off-by: Michael S. Tsirkin --- arch/um/drivers/virtio_uml.c | 2 +- drivers/vdpa/ifcvf/ifcvf_base.h| 2 +- drivers/vdpa/vdpa_sim/vdpa_sim.c | 4 ++-- drivers/vhost/net.c

Re: [bpf PATCH] bpf: do not allow btf_ctx_access with __int128 types

2020-06-24 Thread John Fastabend
Andrii Nakryiko wrote: > On Tue, Jun 23, 2020 at 10:14 AM John Fastabend > wrote: > > > > To ensure btf_ctx_access() is safe the verifier checks that the BTF > > arg type is an int, enum, or pointer. When the function does the > > BTF arg lookup it uses the calculation 'arg = off / 8' using the >

[bpf PATCH] bpf: Do not allow btf_ctx_access with __int128 types

2020-06-24 Thread John Fastabend
To ensure btf_ctx_access() is safe the verifier checks that the BTF arg type is an int, enum, or pointer. When the function does the BTF arg lookup it uses the calculation 'arg = off / 8' using the fact that registers are 8B. This requires that the first arg is in the first reg, the second in the

Re: [PATCH net-next] net: phylink: add phylink_speed_(up|down) interface

2020-06-24 Thread Daniel González Cabanelas
Hi Russell. I've tested my WoL patch reworked with the phylink_speed_(up|down) functions on a LS421DE device and it works quite fine. I'll sent another patch when this one got merged. Thank you. Daniel El mié., 24 jun. 2020 a las 12:06, Russell King () escribió: > > Add an interface for the phy_

Re: [PATCH v1 1/4] ide: use generic power management

2020-06-24 Thread kernel test robot
://github.com/0day-ci/linux/commits/Vaibhav-Gupta/drivers-ide-use-generic-power-management/20200625-013242 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/ide.git master config: x86_64-randconfig-a004-20200624 (attached as .config) compiler: gcc-9 (Debian 9.3.0-13) 9.3.0 reproduce (this

Re: [PATCH v3 0/2] net: phy: call phy_disable_interrupts() in phy_init_hw()

2020-06-24 Thread Florian Fainelli
On 6/24/20 2:43 PM, David Miller wrote: > From: Jisheng Zhang > Date: Wed, 24 Jun 2020 11:25:16 +0800 > >> We face an issue with rtl8211f, a pin is shared between INTB and PMEB, >> and the PHY Register Accessible Interrupt is enabled by default, so >> the INTB/PMEB pin is always active in polling

[PATCH net] ethtool: fix error handling in linkstate_prepare_data()

2020-06-24 Thread Michal Kubecek
When getting SQI or maximum SQI value fails in linkstate_prepare_data(), we must not return without calling ethnl_ops_complete(dev) as that could result in imbalance between ethtool_ops ->begin() and ->complete() calls. Fixes: 806602191592 ("ethtool: provide UAPI for PHY Signal Quality Index (SQI)

Re: [PATCH net-next] net: dsa/ar9331: convert to mac_link_up()

2020-06-24 Thread Florian Fainelli
On 6/24/20 3:21 AM, Russell King wrote: > Convert the ar9331 DSA driver to use the finalised link parameters in > mac_link_up() rather than the parameters in mac_config(). > > Tested-by: Oleksij Rempel > Signed-off-by: Russell King Reviewed-by: Florian Fainelli -- Florian

[PATCH net 4/4] wil6210: account for napi_gro_receive never returning GRO_DROP

2020-06-24 Thread Jason A. Donenfeld
The napi_gro_receive function no longer returns GRO_DROP ever, making handling GRO_DROP dead code. This commit removes that dead code. Further, it's not even clear that device drivers have any business in taking action after passing off received packets; that's arguably out of their hands. In this

Re: [PATCH net-next] net: phylink: only restart AN if the link mode is using in-band AN

2020-06-24 Thread Florian Fainelli
On 6/24/20 4:30 AM, Russell King wrote: > If we are not using in-band autonegotiation, there is no point passing > the request to restart autonegotiation on to the driver. > > Signed-off-by: Russell King Reviewed-by: Florian Fainelli -- Florian

[PATCH net 2/4] socionext: account for napi_gro_receive never returning GRO_DROP

2020-06-24 Thread Jason A. Donenfeld
The napi_gro_receive function no longer returns GRO_DROP ever, making handling GRO_DROP dead code. This commit removes that dead code. Further, it's not even clear that device drivers have any business in taking action after passing off received packets; that's arguably out of their hands. Fixes:

[PATCH net 3/4] hns: do not cast return value of napi_gro_receive to null

2020-06-24 Thread Jason A. Donenfeld
Basically no drivers care about the return value here, and there's no __must_check that would make casting to void sensible, so remove it. Signed-off-by: Jason A. Donenfeld --- drivers/net/ethernet/hisilicon/hns/hns_enet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drive

[PATCH net 1/4] wireguard: receive: account for napi_gro_receive never returning GRO_DROP

2020-06-24 Thread Jason A. Donenfeld
The napi_gro_receive function no longer returns GRO_DROP ever, making handling GRO_DROP dead code. This commit removes that dead code. Further, it's not even clear that device drivers have any business in taking action after passing off received packets; that's arguably out of their hands. Fixes:

[PATCH net 0/4] napi_gro_receive caller return value cleanups

2020-06-24 Thread Jason A. Donenfeld
In 6570bc79c0df ("net: core: use listified Rx for GRO_NORMAL in napi_gro_receive()"), the GRO_NORMAL case stopped calling netif_receive_skb_internal, checking its return value, and returning GRO_DROP in case it failed. Instead, it calls into netif_receive_skb_list_internal (after a bit of indirecti

Re: [PATCH] qed: add missing error test for DBG_STATUS_NO_MATCHING_FRAMING_MODE

2020-06-24 Thread David Miller
From: Colin King Date: Wed, 24 Jun 2020 11:13:02 +0100 > From: Colin Ian King > > The error DBG_STATUS_NO_MATCHING_FRAMING_MODE was added to the enum > enum dbg_status however there is a missing corresponding entry for > this in the array s_status_str. This causes an out-of-bounds read when > i

Re: [PATCH net-next] lan743x: Remove duplicated include from lan743x_main.c

2020-06-24 Thread David Miller
From: YueHaibing Date: Wed, 24 Jun 2020 07:18:21 + > Remove duplicated include. > > Signed-off-by: YueHaibing Applied.

Re: [PATCH 2/2] net: ethernet: mvneta: Add back interface mode validation

2020-06-24 Thread David Miller
From: Sascha Hauer Date: Wed, 24 Jun 2020 09:00:45 +0200 > When writing the serdes configuration register was moved to > mvneta_config_interface() the whole code block was removed from > mvneta_port_power_up() in the assumption that its only purpose was to > write the serdes configuration registe

Re: [PATCH 1/2] net: ethernet: mvneta: Do not error out in non serdes modes

2020-06-24 Thread David Miller
From: Sascha Hauer Date: Wed, 24 Jun 2020 09:00:44 +0200 > In mvneta_config_interface() the RGMII modes are catched by the default > case which is an error return. The RGMII modes are valid modes for the > driver, so instead of returning an error add a break statement to return > successfully. >

Re: [PATCH net-next 3/5] ipv6: ioam: Data plane support for Pre-allocated Trace

2020-06-24 Thread kernel test robot
Hi Justin, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Justin-Iurman/Data-plane-support-for-IOAM-Pre-allocated-Trace-with-IPv6/20200625-033536 base: https://git.kernel.org/pub/scm/linux/ke

Re: [PATCH v3 0/2] net: phy: call phy_disable_interrupts() in phy_init_hw()

2020-06-24 Thread David Miller
From: Jisheng Zhang Date: Wed, 24 Jun 2020 11:25:16 +0800 > We face an issue with rtl8211f, a pin is shared between INTB and PMEB, > and the PHY Register Accessible Interrupt is enabled by default, so > the INTB/PMEB pin is always active in polling mode case. > > As Heiner pointed out "I was thi

Re: [PATCH v2] dsa: Allow forwarding of redirected IGMP traffic

2020-06-24 Thread David Miller
From: Daniel Mack Date: Sat, 20 Jun 2020 21:39:25 +0200 > The driver for Marvell switches puts all ports in IGMP snooping mode > which results in all IGMP/MLD frames that ingress on the ports to be > forwarded to the CPU only. > > The bridge code in the kernel can then interpret these frames and

Re: [PATCH net-next 05/10] ethtool: Add link extended state

2020-06-24 Thread Michal Kubecek
On Wed, Jun 24, 2020 at 11:19:18AM +0300, Ido Schimmel wrote: > From: Amit Cohen > > Currently, drivers can only tell whether the link is up/down using > LINKSTATE_GET, but no additional information is given. > > Add attributes to LINKSTATE_GET command in order to allow drivers > to expose the u

Re: [PATCH net-next 0/4] net: bridge: fdb activity tracking

2020-06-24 Thread David Miller
From: Nikolay Aleksandrov Date: Tue, 23 Jun 2020 23:47:14 +0300 > This set adds extensions needed for EVPN multi-homing proper and > efficient mac sync. User-space (e.g. FRR) needs to be able to track > non-dynamic entry activity on per-fdb basis depending if a tracked fdb is > currently peer act

Re: [PATCH v2 net] openvswitch: take into account de-fragmentation/gso_size in execute_check_pkt_len

2020-06-24 Thread David Miller
From: Lorenzo Bianconi Date: Tue, 23 Jun 2020 18:33:15 +0200 > ovs connection tracking module performs de-fragmentation on incoming > fragmented traffic. Take info account if traffic has been de-fragmented > in execute_check_pkt_len action otherwise we will perform the wrong > nested action consi

Re: [PATCH net-next v4 0/8] net: phy: mscc: PHC and timestamping support

2020-06-24 Thread David Miller
From: Antoine Tenart Date: Tue, 23 Jun 2020 16:30:06 +0200 > This series aims at adding support for PHC and timestamping operations > in the MSCC PHY driver, for the VSC858x and VSC8575. Those PHYs are > capable of timestamping in 1-step and 2-step for both L2 and L4 traffic. ... Series applied

Re: [PATCH v2 net-next] net: core: use listified Rx for GRO_NORMAL in napi_gro_receive()

2020-06-24 Thread Jason A. Donenfeld
On Wed, Jun 24, 2020 at 03:06:10PM -0600, Jason A. Donenfeld wrote: > Hi Alexander, > > This patch introduced a behavior change around GRO_DROP: > > napi_skb_finish used to sometimes return GRO_DROP: > > > -static gro_result_t napi_skb_finish(gro_result_t ret, struct sk_buff *skb) > > +static gr

[bpf PATCH] bpf, sockmap: RCU splat with TLS redirect and strparser

2020-06-24 Thread John Fastabend
Redirect on non-TLS sockmap side has RCU lock held from sockmap code path but when called from TLS this is no longer true. The RCU section is needed because we use rcu dereference to fetch the psock of the socket we are redirecting to. To fix the below splat wrap the redirect usage in rcu_read_loc

Re: [PATCH v2 net-next] net: core: use listified Rx for GRO_NORMAL in napi_gro_receive()

2020-06-24 Thread Jason A. Donenfeld
Hi Alexander, This patch introduced a behavior change around GRO_DROP: napi_skb_finish used to sometimes return GRO_DROP: > -static gro_result_t napi_skb_finish(gro_result_t ret, struct sk_buff *skb) > +static gro_result_t napi_skb_finish(struct napi_struct *napi, > +

[PATCH net] vxlan: fix last fdb index during dump of fdb with nhid

2020-06-24 Thread Roopa Prabhu
From: Roopa Prabhu This patch fixes last saved fdb index in fdb dump handler when handling fdb's with nhid. Fixes: 1274e1cc4226 ("vxlan: ecmp support for mac fdb entries") Signed-off-by: Roopa Prabhu --- drivers/net/vxlan.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/vx

Re: [PATCH net] sctp: Don't advertise IPv4 addresses if ipv6only is set on the socket

2020-06-24 Thread Corey Minyard
On Wed, Jun 24, 2020 at 05:34:18PM -0300, Marcelo Ricardo Leitner wrote: > If a socket is set ipv6only, it will still send IPv4 addresses in the > INIT and INIT_ACK packets. This potentially misleads the peer into using > them, which then would cause association termination. > > The fix is to not

Re: [PATCH bpf-next 3/3] selftests/bpf: add bpf_iter test with bpf_get_task_stack_trace()

2020-06-24 Thread Song Liu
> On Jun 23, 2020, at 3:27 PM, Yonghong Song wrote: > > > > On 6/23/20 3:07 PM, Song Liu wrote: >>> On Jun 23, 2020, at 11:57 AM, Yonghong Song wrote: >>> >>> >>> >>> On 6/23/20 12:08 AM, Song Liu wrote: The new test is similar to other bpf_iter tests. Signed-off-by: Song Liu

[PATCH net] sctp: Don't advertise IPv4 addresses if ipv6only is set on the socket

2020-06-24 Thread Marcelo Ricardo Leitner
If a socket is set ipv6only, it will still send IPv4 addresses in the INIT and INIT_ACK packets. This potentially misleads the peer into using them, which then would cause association termination. The fix is to not add IPv4 addresses to ipv6only sockets. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") R

Re: [PATCH net-next 1/5] ipv6: eh: Introduce removable TLVs

2020-06-24 Thread Tom Herbert
On Wed, Jun 24, 2020 at 12:33 PM Justin Iurman wrote: > > Add the possibility to remove one or more consecutive TLVs without > messing up the alignment of others. For now, only IOAM requires this > behavior. > Hi Justin, Can you explain the motivation for this? Per RFC8200, extension headers in f

Re: [PATCH net-next 04/10] Documentation: networking: ethtool-netlink: Add link extended state

2020-06-24 Thread Michal Kubecek
On Wed, Jun 24, 2020 at 11:19:17AM +0300, Ido Schimmel wrote: > From: Amit Cohen > > Add link extended state attributes. > > Signed-off-by: Amit Cohen > Reviewed-by: Petr Machata > Reviewed-by: Jiri Pirko > Signed-off-by: Ido Schimmel > --- > Documentation/networking/ethtool-netlink.rst | 1

Re: ADQ - comparison to aRFS, clarifications on NAPI ID, binding with busy-polling

2020-06-24 Thread Samudrala, Sridhar
On 6/17/2020 6:15 AM, Maxim Mikityanskiy wrote: Hi, I discovered Intel ADQ feature [1] that allows to boost performance by picking dedicated queues for application traffic. We did some research, and I got some level of understanding how it works, but I have some questions, and I hope you c

Re: [net-next 10/10] net/mlx5e: Add support for PCI relaxed ordering

2020-06-24 Thread Saeed Mahameed
On Wed, 2020-06-24 at 10:22 -0700, Jakub Kicinski wrote: > On Wed, 24 Jun 2020 10:34:40 +0300 Aya Levin wrote: > > > > I think Michal will rightly complain that this does not belong > > > > in > > > > private flags any more. As (/if?) ARM deployments take a > > > > foothold > > > > in DC this will

Re: [PATCH] Bluetooth: Don't restart scanning if paused

2020-06-24 Thread Marcel Holtmann
Hi Abhishek, > When restarting LE scanning, check if it's currently paused before > enabling passive scanning. > > Signed-off-by: Abhishek Pandit-Subedi > --- > When running suspend stress tests on Chromebooks, we discovered > instances where the Chromebook didn't enter the deepest idle states >

[PATCH net-next 2/5] ipv6: IOAM tunnel decapsulation

2020-06-24 Thread Justin Iurman
Implement the IOAM egress behavior. According to RFC 8200: "Extension headers (except for the Hop-by-Hop Options header) are not processed, inserted, or deleted by any node along a packet's delivery path, until the packet reaches the node (or each of the set of nodes, in the case of multicast)

[PATCH net-next 3/5] ipv6: ioam: Data plane support for Pre-allocated Trace

2020-06-24 Thread Justin Iurman
Implement support for processing the IOAM Pre-allocated Trace with IPv6, see [1] and [2]. Introduce a new IPv6 Hop-by-Hop TLV option IPV6_TLV_IOAM_HOPOPTS, see IANA [3]. A per-interface sysctl ioam6_enabled is provided to accept/drop IOAM packets. Default is drop. Another per-interface sysctl ioa

[PATCH net] tc-testing: avoid action cookies with odd length.

2020-06-24 Thread Briana Oursler
Update odd length cookie hexstrings in csum.json, tunnel_key.json and bpf.json to be even length to comply with check enforced in commit 0149dabf2a1b ("tc: m_actions: check cookie hexstring len") in iproute2. Signed-off-by: Briana Oursler Reviewed-by: Stefano Brivio Reviewed-by: Davide Caratti

[PATCH net-next 5/5] ipv6: ioam: Documentation for new IOAM sysctls

2020-06-24 Thread Justin Iurman
Add documentation for new IOAM sysctls: - ioam6_id: a namespace sysctl - ioam6_enabled and ioam6_id: two per-interface sysctls Signed-off-by: Justin Iurman --- Documentation/networking/ioam6-sysctl.rst | 20 Documentation/networking/ip-sysctl.rst| 5 + 2 files cha

[PATCH net-next 1/5] ipv6: eh: Introduce removable TLVs

2020-06-24 Thread Justin Iurman
Add the possibility to remove one or more consecutive TLVs without messing up the alignment of others. For now, only IOAM requires this behavior. By default, an 8-octet boundary is automatically assumed. This is the price to pay (at most a useless 4-octet padding) to make sure everything is still

[PATCH net-next 4/5] ipv6: ioam: Generic Netlink to configure IOAM

2020-06-24 Thread Justin Iurman
Add Generic Netlink commands to allow userspace to configure IOAM namespaces and schemas. The target is iproute2 and the patch is ready. It will be posted as soon as this patchset is merged. Here is a taste: $ sudo ip ioam Usage: ip ioam { namespace | schema } { show | del ID } sche

[PATCH net-next 0/5] Data plane support for IOAM Pre-allocated Trace with IPv6

2020-06-24 Thread Justin Iurman
In-situ Operations, Administration, and Maintenance (IOAM) records operational and telemetry information in a packet while it traverses a path between two points in an IOAM domain. It is defined in draft-ietf-ippm-ioam-data-09 [1]. IOAM data fields can be encapsulated into a variety of protocols. T

[PATCH v2] fs/epoll: Enable non-blocking busypoll when epoll timeout is 0

2020-06-24 Thread Sridhar Samudrala
This patch triggers non-blocking busy poll when busy_poll is enabled, epoll is called with a timeout of 0 and is associated with a napi_id. This enables an app thread to go through napi poll routine once by calling epoll with a 0 timeout. poll/select with a 0 timeout behave in a similar manner. S

Re: [PATCH net-next 04/10] Documentation: networking: ethtool-netlink: Add link extended state

2020-06-24 Thread Jacob Keller
On 6/24/2020 1:19 AM, Ido Schimmel wrote: > From: Amit Cohen > > Add link extended state attributes. > > Signed-off-by: Amit Cohen > Reviewed-by: Petr Machata > Reviewed-by: Jiri Pirko > Signed-off-by: Ido Schimmel I really like this concept. Reviewed-by: Jacob Keller > --- > Documen

Re: [PATCH] net: phy: mscc: avoid skcipher API for single block AES encryption

2020-06-24 Thread Ard Biesheuvel
On Wed, 24 Jun 2020 at 18:32, Eric Biggers wrote: > > On Wed, Jun 24, 2020 at 03:34:27PM +0200, Ard Biesheuvel wrote: > > The skcipher API dynamically instantiates the transformation object on > > request that implements the requested algorithm optimally on the given > > platform. This notion of o

Re: [PATCH 09/15] net: phy: delay PHY driver probe until PHY registration

2020-06-24 Thread Robin Murphy
On 2020-06-24 17:50, Russell King - ARM Linux admin wrote: On Wed, Jun 24, 2020 at 09:06:28AM -0700, Florian Fainelli wrote: On 6/24/2020 6:48 AM, Bartosz Golaszewski wrote: I didn't expect to open such a can of worms... This has evolved into several new concepts being proposed vs my use-case

[PATCH v2] IPv4: Tunnel: Fix effective path mtu calculation

2020-06-24 Thread Oliver Herms
The calculation of the effective tunnel mtu, that is used to create mtu exceptions if necessary, is currently not done correctly. This leads to unnecessary entires in the IPv6 route cache for any packet send through the tunnel. The root cause is, that "dev->hard_header_len" is subtracted from the

  1   2   3   >