Re: INFO: task hung in corrupted (2)

2020-06-10 Thread Jiri Kosina
On Thu, 11 Jun 2020, Peter Hutterer wrote: > based on the line numbers it's the while loop in there which is also the one > that could be unbounded if the hid collection isn't set up correctly or if > we have some other corruption happening. Given the fact this is syzkaller-induced, it's almost c

Re: [PATCH v3 6/7] venus: Make debug infrastructure more flexible

2020-06-10 Thread Joe Perches
On Thu, 2020-06-11 at 08:26 +0200, Greg Kroah-Hartman wrote: > On Wed, Jun 10, 2020 at 01:23:56PM -0700, Joe Perches wrote: > > On Wed, 2020-06-10 at 12:49 -0700, Joe Perches wrote: > > > On Wed, 2020-06-10 at 15:37 +0200, Greg Kroah-Hartman wrote: > > > > Please work with the infrastructure we hav

Re: [PATCH net-next 2/2] Crypto/chcr: Checking cra_refcnt before unregistering the algorithms

2020-06-10 Thread Herbert Xu
On Thu, Jun 11, 2020 at 11:38:39AM +0530, Ayush Sawal wrote: > > Sorry for this hack, Our problem was when ipsec is under use and device is > dettached, then chcr_unregister_alg() > is called which unregisters the algorithms, but as ipsec is established the > cra_refcnt is not 1 and it gives a kern

Re: [PATCH v3 6/7] venus: Make debug infrastructure more flexible

2020-06-10 Thread Greg Kroah-Hartman
On Wed, Jun 10, 2020 at 01:23:56PM -0700, Joe Perches wrote: > On Wed, 2020-06-10 at 12:49 -0700, Joe Perches wrote: > > On Wed, 2020-06-10 at 15:37 +0200, Greg Kroah-Hartman wrote: > > > Please work with the infrastructure we have, we have spent a lot of time > > > and effort to make it uniform to

Re: [PATCH net-next 2/2] Crypto/chcr: Checking cra_refcnt before unregistering the algorithms

2020-06-10 Thread Ayush Sawal
Hi Herbert, On 6/11/2020 9:18 AM, Herbert Xu wrote: On Wed, Jun 10, 2020 at 02:54:32AM +0530, Ayush Sawal wrote: This patch puts a check for algorithm unregister, to avoid removal of driver if the algorithm is under use. Signed-off-by: Ayush Sawal --- drivers/crypto/chelsio/chcr_algo.c | 18

Re: [PATCH RFC v2 6/9] net: phy: add support for probing MMDs >= 8 for devices-in-package

2020-06-10 Thread Calvin Johnson
On Wed, Jun 10, 2020 at 05:34:17PM +0100, Russell King - ARM Linux admin wrote: > On Wed, Jun 10, 2020 at 09:46:33PM +0530, Calvin Johnson wrote: > > Hi Russell, > > > > On Wed, May 27, 2020 at 11:34:11AM +0100, Russell King wrote: > > > Add support for probing MMDs above 7 for a valid devices-in-

[PATCH] xdp: fix xsk_generic_xmit errno

2020-06-10 Thread Li RongQing
propagate sock_alloc_send_skb error code, not set it to EAGAIN unconditionally, when fail to allocate skb, which maybe causes that user space unnecessary loops Fixes: 35fcde7f8deb "(xsk: support for Tx)" Signed-off-by: Li RongQing --- net/xdp/xsk.c | 1 - 1 file changed, 1 deletion(-) diff --gi

Re: INFO: task hung in corrupted (2)

2020-06-10 Thread Peter Hutterer
On Thu, Jun 04, 2020 at 01:41:07PM +0200, Jiri Kosina wrote: > On Tue, 2 Jun 2020, Andrey Konovalov wrote: > > > > Hello, > > > > > > syzbot found the following crash on: > > > > > > HEAD commit:b0c3ba31 Merge tag 'fsnotify_for_v5.7-rc8' of > > > git://git.ke.. > > > git tree: upstream

Re: [Patch net v2] genetlink: fix memory leaks in genl_family_rcv_msg_dumpit()

2020-06-10 Thread Cong Wang
On Wed, Jun 10, 2020 at 7:27 AM Ido Schimmel wrote: > > @@ -548,7 +591,7 @@ static int genl_lock_done(struct netlink_callback *cb) > > rc = ops->done(cb); > > genl_unlock(); > > } > > - genl_family_rcv_msg_attrs_free(info->family, info->attrs, true); > > +

[PATCH net] ionic: remove support for mgmt device

2020-06-10 Thread Shannon Nelson
We no longer support the mgmt device in the ionic driver, so remove the device id and related code. Fixes: b3f064e9746d ("ionic: add support for device id 0x1004") Signed-off-by: Shannon Nelson --- drivers/net/ethernet/pensando/ionic/ionic.h | 2 -- drivers/net/ethernet/pensando/ionic/i

Re: [PATCH net-next 0/2] Fixing issues in dma mapping and driver removal

2020-06-10 Thread Herbert Xu
On Wed, Jun 10, 2020 at 05:05:43PM -0700, David Miller wrote: > > Maybe we can start handling these changes via the crypto tree at some > point? Yes that's good point Dave. How about we push changes for chcr_algo via the crypto tree and the rest via netdev? Thanks, -- Email: Herbert Xu Home Pa

Re: [PATCH net-next 2/2] Crypto/chcr: Checking cra_refcnt before unregistering the algorithms

2020-06-10 Thread Herbert Xu
On Wed, Jun 10, 2020 at 02:54:32AM +0530, Ayush Sawal wrote: > This patch puts a check for algorithm unregister, to avoid removal of > driver if the algorithm is under use. > > Signed-off-by: Ayush Sawal > --- > drivers/crypto/chelsio/chcr_algo.c | 18 ++ > 1 file changed, 14 ins

Re: [PATCH 2/2] net: dsa: qca8k: Improve SGMII interface handling

2020-06-10 Thread Florian Fainelli
On 6/10/2020 12:15 PM, Jonathan McDowell wrote: > This patch improves the handling of the SGMII interface on the QCA8K > devices. Previously the driver did no configuration of the port, even if > it was selected. We now configure it up in the appropriate > PHY/MAC/Base-X mode depending on what p

[PATCH net 1/2] flow_offload: fix incorrect cb_priv check for flow_block_cb

2020-06-10 Thread wenxu
From: wenxu The cb_priv in the flow_indr_dev_unregister get from the driver is the same as cb_priv of flow_indr_dev. But it always isn't the same as cb_priv of flow_block_cb which leads miss cleanup operation. For mlx5e example the cb_priv of flow_indr_dev is the mlx5e_rep_priv which related to

[PATCH net 2/2] flow_offload: fix miss cleanup flow_block_cb of indr_setup_ft_cb type

2020-06-10 Thread wenxu
From: wenxu Currently indr setup supoort both indr_setup_ft_cb and indr_setup_tc_cb. But the __flow_block_indr_cleanup only check the indr_setup_tc_cb in mlx5e driver. It is better to just check the indr_release_cb, all the setup_cb type share the same release_cb. Fixes: 1fac52da5942 ("net: flow

Re: [PATCH 1/2] net: dsa: qca8k: Switch to PHYLINK instead of PHYLIB

2020-06-10 Thread Florian Fainelli
On 6/10/2020 12:14 PM, Jonathan McDowell wrote: > Update the driver to use the new PHYLINK callbacks, removing the > legacy adjust_link callback. > > Signed-off-by: Jonathan McDowell This looks reasonable to me, Russell would be the person you want to get an Acked-by/Reviewed-by tag from. --

Re: [PATCH RFC v6 02/11] vhost: use batched get_vq_desc version

2020-06-10 Thread Jason Wang
On 2020/6/10 下午7:05, Michael S. Tsirkin wrote: +EXPORT_SYMBOL_GPL(vhost_get_vq_desc); /* Reverse the effect of vhost_get_vq_desc. Useful for error handling. */ void vhost_discard_vq_desc(struct vhost_virtqueue *vq, int n) { + unfetch_descs(vq); vq->last_avail_idx -= n; S

[PATCH] drivers: dpaa2: Use devm_kcalloc() in setup_dpni()

2020-06-10 Thread Xu Wang
A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "devm_kcalloc". Signed-off-by: Xu Wang --- drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 5 +++-- 1 file changed, 3 insertions(+

[PATCH] Fix null pointer dereference in vector_user_bpf

2020-06-10 Thread Gaurav Singh
The bpf_prog is being checked for !NULL after uml_kmalloc but later its used directly for example: bpf_prog->filter = bpf and is also later returned upon success. Fix this, do a NULL check and return right away. Signed-off-by: Gaurav Singh --- arch/um/drivers/vector_user.c | 8 +--- 1 file c

[PATCH] 9p/trans_fd: Fix concurrency del of req_list in p9_fd_cancelled/p9_read_work

2020-06-10 Thread Wang Hai
p9_read_work and p9_fd_cancelled may be called concurrently. Before list_del(&m->rreq->req_list) in p9_read_work is called, the req->req_list may have been deleted in p9_fd_cancelled. We can fix it by setting req->status to REQ_STATUS_FLSHD after list_del(&req->req_list) in p9_fd_cancelled. Before

Re: [PATCH v2] net: atm: Remove the error message according to the atomic context

2020-06-10 Thread David Miller
From: Yi Wang Date: Thu, 11 Jun 2020 08:38:50 +0800 > @@ -1537,7 +1537,6 @@ static struct lec_arp_table *make_entry(struct lec_priv > *priv, > > to_return = kzalloc(sizeof(struct lec_arp_table), GFP_ATOMIC); > if (!to_return) { > - pr_info("LEC: Arp entry kmalloc failed

[PATCH v2] net: atm: Remove the error message according to the atomic context

2020-06-10 Thread Yi Wang
From: Liao Pingfang Looking into the context (atomic!) and the error message should be dropped. Signed-off-by: Liao Pingfang --- Changes in v2: drop the error message instead of changing it. net/atm/lec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/atm/lec.c b/net/atm/lec.c index c

[PATCH iproute2 net-next v2 0/2] support for fdb nexthop groups

2020-06-10 Thread Roopa Prabhu
From: Roopa Prabhu This series adds iproute2 support for recently added kernel fdb nexthop groups example: /* create fdb nexthop group */ $ip nexthop add id 12 via 172.16.1.2 fdb $ip nexthop add id 13 via 172.16.1.3 fdb $ip nexthop add id 102 group 12/13 fdb /* assign nexthop group to fdb en

[PATCH iproute2 net-next v2 1/2] ipnexthop: support for fdb nexthops

2020-06-10 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds support to add and delete ecmp nexthops of type fdb. Such nexthops can be linked to vxlan fdb entries. $ip nexthop add id 12 via 172.16.1.2 fdb $ip nexthop add id 13 via 172.16.1.3 fdb $ip nexthop add id 102 group 12/13 fdb $bridge fdb add 02:02:00:00:00:13 de

[PATCH iproute2 net-next v2 2/2] bridge: support for nexthop id in fdb entries

2020-06-10 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds support to assign a nexthop group id to an fdb entry. $bridge fdb add 02:02:00:00:00:13 dev vx10 nhid 102 self Signed-off-by: Roopa Prabhu --- bridge/fdb.c | 22 +++--- man/man8/bridge.8 | 13 ++--- 2 files changed, 29 insertions

Re: [PATCH net] docs: networkng: convert sja1105's devlink info to RTS

2020-06-10 Thread Jakub Kicinski
On Wed, 10 Jun 2020 17:08:26 -0700 (PDT) David Miller wrote: > From: Jakub Kicinski > Date: Wed, 10 Jun 2020 16:59:11 -0700 > > > A new file snuck into the tree after all existing documentation > > was converted to RST. Convert sja1105's devlink info and move > > it where the rest of the drivers

Re: [PATCH net] docs: networkng: convert sja1105's devlink info to RTS

2020-06-10 Thread David Miller
From: Jakub Kicinski Date: Wed, 10 Jun 2020 16:59:11 -0700 > A new file snuck into the tree after all existing documentation > was converted to RST. Convert sja1105's devlink info and move > it where the rest of the drivers are documented. > > Signed-off-by: Jakub Kicinski Applied with Vlad's

Re: [PATCH net-next 0/2] Fixing issues in dma mapping and driver removal

2020-06-10 Thread David Miller
From: Ayush Sawal Date: Wed, 10 Jun 2020 02:54:30 +0530 > Patch 1: This fixes the kernel panic which occurs due to the accessing > of a zero length sg. > > Patch 2: Avoiding unregistering the algorithm if cra_refcnt is not 1. > > Ayush Sawal (2): > Crypto/chcr: Calculate src and dst sg length

Re: [PATCH v2 2/2] net: phy: mscc: handle the clkout control on some phy variants

2020-06-10 Thread David Miller
From: Heiko Stuebner Date: Tue, 9 Jun 2020 15:31:40 +0200 > From: Heiko Stuebner > > At least VSC8530/8531/8540/8541 contain a clock output that can emit > a predefined rate of 25, 50 or 125MHz. > > This may then feed back into the network interface as source clock. > So follow the example th

Re: [PATCH net] docs: networkng: convert sja1105's devlink info to RTS

2020-06-10 Thread Jakub Kicinski
On Thu, 11 Jun 2020 02:51:51 +0300 Vladimir Oltean wrote: > On Thu, 11 Jun 2020 at 02:40, Jakub Kicinski wrote: > > A new file snuck into the tree after all existing documentation > > was converted to RST. Convert sja1105's devlink info and move > > it where the rest of the drivers are documented.

[PATCH net] docs: networkng: convert sja1105's devlink info to RTS

2020-06-10 Thread Jakub Kicinski
A new file snuck into the tree after all existing documentation was converted to RST. Convert sja1105's devlink info and move it where the rest of the drivers are documented. Signed-off-by: Jakub Kicinski --- .../networking/devlink-params-sja1105.txt | 27 -- Documentation/networking

Re: [PATCH net] docs: networkng: convert sja1105's devlink info to RTS

2020-06-10 Thread Vladimir Oltean
On Thu, 11 Jun 2020 at 02:40, Jakub Kicinski wrote: > > A new file snuck into the tree after all existing documentation > was converted to RST. Convert sja1105's devlink info and move > it where the rest of the drivers are documented. > > Signed-off-by: Jakub Kicinski > --- Acked-by: Vladimir Ol

Re: [PATCH net] docs: networkng: fix lists and table in sja1105

2020-06-10 Thread David Miller
From: Jakub Kicinski Date: Wed, 10 Jun 2020 16:09:06 -0700 > We need an empty line before list stats, otherwise first point > will be smooshed into the paragraph. Inside tables text must > start at the same offset in the cell, otherwise sphinx thinks > it's a new indented block. > > Documentatio

Re: [PATCH net] docs: networking: fix extra spaces in ethtool-netlink

2020-06-10 Thread David Miller
From: Jakub Kicinski Date: Wed, 10 Jun 2020 15:36:48 -0700 > Sphinx appears to get upset at extra spaces at the end of a literal: > > Documentation/networking/ethtool-netlink.rst:1032: WARNING: Inline literal > start-string without end-string. > Documentation/networking/ethtool-netlink.rst:1034

[PATCH net] docs: networkng: convert sja1105's devlink info to RTS

2020-06-10 Thread Jakub Kicinski
A new file snuck into the tree after all existing documentation was converted to RST. Convert sja1105's devlink info and move it where the rest of the drivers are documented. Signed-off-by: Jakub Kicinski --- .../networking/devlink-params-sja1105.txt | 27 -- Documentation/networking

Re: [PATCH net 5/5] net: ipa: warn if gsi_trans structure is too big

2020-06-10 Thread David Miller
From: Alex Elder Date: Wed, 10 Jun 2020 14:53:32 -0500 > When the DEBUG_SPINLOCK and DEBUG_LOCK_ALLOC config options are > enabled, sizeof(raw_spinlock_t) grows considerably (from 4 bytes > to 56 bytes currently). As a consequence the size of the gsi_trans > structure exceeds 128 bytes, and this

Re: [RFC PATCH v3 0/2] net: dsa: qca8k: Improve SGMII interface handling

2020-06-10 Thread David Miller
Please, when you post an RFC patch set, put "RFC" into the Subject lines of the patches as well as the introductory posting. This helps me categorize changes properly in patchwork. Thank you.

Re: [PATCH 1/1] net: stmmac: gmac3: add auxiliary snapshot support

2020-06-10 Thread David Miller
net-next is currently CLOSED, please resubmit this when it opens back up. Thank you.

Re: [PATCH] net: cadence: macb: disable NAPI on error

2020-06-10 Thread David Miller
From: Corentin Labbe Date: Wed, 10 Jun 2020 09:53:44 + > When the PHY is not working, the macb driver crash on a second try to > setup it. > [ 78.545994] macb e000b000.ethernet eth0: Could not attach PHY (-19) ... > This is due to NAPI left enabled if macb_phylink_connect() fail. > > Fixe

Re: [Patch net] net: change addr_list_lock back to static key

2020-06-10 Thread Cong Wang
On Wed, Jun 10, 2020 at 7:48 AM Taehee Yoo wrote: > > On Tue, 9 Jun 2020 at 06:53, Cong Wang wrote: > > > > Hi Cong, > Thank you for this work! > > > The dynamic key update for addr_list_lock still causes troubles, > > for example the following race condition still exists: > > > > CPU 0:

Re: [PATCH net] docs: networkng: fix lists and table in sja1105

2020-06-10 Thread Vladimir Oltean
On Thu, 11 Jun 2020 at 02:10, Jakub Kicinski wrote: > > We need an empty line before list stats, otherwise first point > will be smooshed into the paragraph. Inside tables text must > start at the same offset in the cell, otherwise sphinx thinks > it's a new indented block. > > Documentation/netwo

Re: [PATCH net] mptcp: don't leak msk in token container

2020-06-10 Thread David Miller
From: Paolo Abeni Date: Wed, 10 Jun 2020 10:49:00 +0200 > If a listening MPTCP socket has unaccepted sockets at close > time, the related msks are freed via mptcp_sock_destruct(), > which in turn does not invoke the proto->destroy() method > nor the mptcp_token_destroy() function. > > Due to the

[PATCH net] docs: networkng: fix lists and table in sja1105

2020-06-10 Thread Jakub Kicinski
We need an empty line before list stats, otherwise first point will be smooshed into the paragraph. Inside tables text must start at the same offset in the cell, otherwise sphinx thinks it's a new indented block. Documentation/networking/dsa/sja1105.rst:108: WARNING: Block quote ends without a bl

Re: [PATCH net] mptcp: fix races between shutdown and recvmsg

2020-06-10 Thread David Miller
From: Paolo Abeni Date: Wed, 10 Jun 2020 10:47:41 +0200 > The msk sk_shutdown flag is set by a workqueue, possibly > introducing some delay in user-space notification. If the last > subflow carries some data with the fin packet, the user space > can wake-up before RCV_SHUTDOWN is set. If it execu

[PATCH net] docs: networking: fix extra spaces in ethtool-netlink

2020-06-10 Thread Jakub Kicinski
Sphinx appears to get upset at extra spaces at the end of a literal: Documentation/networking/ethtool-netlink.rst:1032: WARNING: Inline literal start-string without end-string. Documentation/networking/ethtool-netlink.rst:1034: WARNING: Inline literal start-string without end-string. Documentati

Re: [PATCH v2 net-next 03/10] net: mscc: ocelot: allocated rules to different hardware VCAP TCAMs by chain index

2020-06-10 Thread Allan W. Nielsen
On 09.06.2020 15:55, Vladimir Oltean wrote: EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe Hi Allan, On Mon, 8 Jun 2020 at 16:56, Allan W. Nielsen wrote: On 03.06.2020 13:04, Vladimir Oltean wrote: >On Tue, 2 Jun 2020 at 11:38, Allan W. Nielsen >

Re: [GIT PULL] virtio: features, fixes

2020-06-10 Thread pr-tracker-bot
The pull request you sent on Wed, 10 Jun 2020 00:44:55 -0400: > https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/09102704c67457c6cdea6c0394c34843484a852c Thank you! -- Deet-doot-dot, I am a b

[PATCH net 2/2] net/sched: act_gate: fix configuration of the periodic timer

2020-06-10 Thread Davide Caratti
assigning a dummy value of 'clock_id' to avoid cancellation of the cycle timer before its initialization was a temporary solution, and we still need to handle the case where act_gate timer parameters are changed by commands like the following one: # tc action replace action gate the fix consist

[PATCH net 0/2] two fixes for 'act_gate' control plane

2020-06-10 Thread Davide Caratti
- patch 1/2 attempts to fix the error path of tcf_gate_init() when users try to configure 'act_gate' rules with wrong parameters. - patch 2/2 is a follow-up of a recent fix for NULL dereference in the error path of tcf_gate_init() further work will introduce a tdc test for 'act_gate'. Davide

[PATCH net 1/2] net/sched: act_gate: fix NULL dereference in tcf_gate_init()

2020-06-10 Thread Davide Caratti
it is possible to see a KASAN use-after-free, immediately followed by a NULL dereference crash, with the following command: # tc action add action gate index 3 cycle-time 1ns \ > cycle-time-ext 1ns clockid CLOCK_TAI BUG: KASAN: use-after-free in tcf_action_init_1+0x8eb/0x960 W

Re: [(RFC) PATCH ] be2net: Allow a VF to use physical link state.

2020-06-10 Thread Jakub Kicinski
On Wed, 10 Jun 2020 10:22:22 -0700 dwilder wrote: > On 2020-06-09 14:58, Jakub Kicinski wrote: > > On Mon, 8 Jun 2020 17:00:59 -0700 David Wilder wrote: > >> Hyper-visors owning a PF are allowed by Emulex specification to > >> provide > >> a VF with separate physical and/or logical link states.

[PATCH] netfiler: ipset: fix unaligned atomic access

2020-06-10 Thread Russell King
When using ip_set with counters and comment, traffic causes the kernel to panic on 32-bit ARM: Alignment trap: not handling instruction e1b82f9f at [] Unhandled fault: alignment exception (0x221) at 0xea08133c PC is at ip_set_match_extensions+0xe0/0x224 [ip_set] The problem occurs when we try to

Re: [GIT PULL] virtio: features, fixes

2020-06-10 Thread Linus Torvalds
On Tue, Jun 9, 2020 at 9:45 PM Michael S. Tsirkin wrote: > > I also upgraded the machine I used to sign > the tag (didn't change the key) - hope the signature is still ok. If not > pls let me know! All looks normal as far as I can tell, Linus

Re: correct use of PHY_INTERFACE_MODE_RGMII{,_TXID,_RXID,_ID}

2020-06-10 Thread Florian Fainelli
On 6/10/2020 1:12 PM, Andrew Lunn wrote: > On Wed, Jun 10, 2020 at 10:12:37AM +0200, Helmut Grohne wrote: >> Hi, >> >> I've been trying to write a dt for a board and got quite confused about >> the RGMII delays. That's why I looked into it and got even more confused >> by what I found. Different

Re: [PATCH v2 net] nexthop: Fix fdb labeling for groups

2020-06-10 Thread Roopa Prabhu
On Mon, Jun 8, 2020 at 7:54 PM David Ahern wrote: > > fdb nexthops are marked with a flag. For standalone nexthops, a flag was > added to the nh_info struct. For groups that flag was added to struct > nexthop when it should have been added to the group information. Fix > by removing the flag from

Re: [PATCH v3 6/7] venus: Make debug infrastructure more flexible

2020-06-10 Thread Joe Perches
On Wed, 2020-06-10 at 12:49 -0700, Joe Perches wrote: > On Wed, 2020-06-10 at 15:37 +0200, Greg Kroah-Hartman wrote: > > Please work with the infrastructure we have, we have spent a lot of time > > and effort to make it uniform to make it easier for users and > > developers. > > Not quite. > > Th

Re: [PATCH net] vxlan: Remove access to nexthop group struct

2020-06-10 Thread David Miller
From: David Ahern Date: Tue, 9 Jun 2020 17:27:28 -0600 > vxlan driver should be using helpers to access nexthop struct > internals. Remove open check if whether nexthop is multipath in > favor of the existing nexthop_is_multipath helper. Add a new > helper, nexthop_has_v4, to cover the need to c

Re: [PATCH v2 net] nexthop: Fix fdb labeling for groups

2020-06-10 Thread David Miller
From: David Ahern Date: Mon, 8 Jun 2020 20:54:43 -0600 > fdb nexthops are marked with a flag. For standalone nexthops, a flag was > added to the nh_info struct. For groups that flag was added to struct > nexthop when it should have been added to the group information. Fix > by removing the flag

Re: correct use of PHY_INTERFACE_MODE_RGMII{,_TXID,_RXID,_ID}

2020-06-10 Thread Andrew Lunn
On Wed, Jun 10, 2020 at 10:12:37AM +0200, Helmut Grohne wrote: > Hi, > > I've been trying to write a dt for a board and got quite confused about > the RGMII delays. That's why I looked into it and got even more confused > by what I found. Different drivers handle this quite differently. Let me > s

Re: [PATCH v4 0/3] Add support for SQI and master-slave

2020-06-10 Thread Michal Kubecek
On Wed, Jun 10, 2020 at 10:37:41AM +0200, Oleksij Rempel wrote: > This patch set is extending ethtool to make it more usable on automotive > PHYs like NXP TJA11XX. > > They make use of new KAPI (currently in net-next, will go probably to the > kernel 5.8-rc1): > - PHY master-slave role configurati

Re: ethtool 5.7: netlink ENOENT error when setting WOL

2020-06-10 Thread Andrew Lunn
> Not sure it makes sense to build ETHTOOL_NETLINK as a module, but at > least ensuring that ETHTOOL_NETLINK is built into the kernel if PHYLIB=y > or PHYLIB=m would make sense, or, better we find a way to decouple the > two by using function pointers from the phy_driver directly that way > there i

[PATCH net 0/5] net: ipa: endpoint configuration fixes

2020-06-10 Thread Alex Elder
This series fixes four bugs in the configuration of IPA endpoints. See the description of each for more information. The last patch changes a BUILD_BUG_ON() call into a runtime warning, because violating the checked condition does not consitute a real bug.

[PATCH net 4/5] net: ipa: header pad field only valid for AP->modem endpoint

2020-06-10 Thread Alex Elder
Only QMAP endpoints should be configured to find a pad size field within packet headers. They are found in the first byte of the QMAP header (and the hardware fills only the 6 bits in that byte that constitute the pad_len field). The RMNet driver assumes the pad_len field is valid for received pa

[PATCH net 1/5] net: ipa: program metadata mask differently

2020-06-10 Thread Alex Elder
The way the mask value is programmed for QMAP RX endpoints was based on some wrong assumptions about the way metadata containing the QMAP mux_id value is formatted. The metadata value supplied by the modem is *not* in QMAP format, and in fact contains the mux_id we want in its (big endian) low-ord

[PATCH net 2/5] net: ipa: fix modem LAN RX endpoint id

2020-06-10 Thread Alex Elder
The endpoint id assigned to the modem LAN RX endpoint for the SC7180 SoC is incorrect. The erroneous value might have been copied from SDM845 and never updated. The correct endpoint id to use for this SoC is 11. Signed-off-by: Alex Elder --- drivers/net/ipa/ipa_data-sc7180.c | 2 +- 1 file cha

[PATCH net 3/5] net: ipa: program upper nibbles of sequencer type

2020-06-10 Thread Alex Elder
The upper two nibbles of the sequencer type were not used for SDM845, and were assumed to be 0. But for SC7180 they are used, and so they must be programmed by ipa_endpoint_init_seq(). Fix this bug. IPA_SEQ_PKT_PROCESS_NO_DEC_NO_UCP_DMAP doesn't have a descriptive comment, so add one. Signed-of

[PATCH net 5/5] net: ipa: warn if gsi_trans structure is too big

2020-06-10 Thread Alex Elder
When the DEBUG_SPINLOCK and DEBUG_LOCK_ALLOC config options are enabled, sizeof(raw_spinlock_t) grows considerably (from 4 bytes to 56 bytes currently). As a consequence the size of the gsi_trans structure exceeds 128 bytes, and this triggers a BUILD_BUG_ON() error. These are useful configuration

Re: [PATCH v3 6/7] venus: Make debug infrastructure more flexible

2020-06-10 Thread Joe Perches
On Wed, 2020-06-10 at 15:37 +0200, Greg Kroah-Hartman wrote: > Please work with the infrastructure we have, we have spent a lot of time > and effort to make it uniform to make it easier for users and > developers. Not quite. This lack of debug grouping by type has been a _long_ standing issue wit

Re: [PATCH 0/2] Use __scm_install_fd() more widely

2020-06-10 Thread Kees Cook
On Wed, Jun 10, 2020 at 11:38:00AM -0700, Jakub Kicinski wrote: > On Wed, 10 Jun 2020 10:03:03 -0700 Kees Cook wrote: > > If 0-day doesn't kick anything back on this tree, I'll resend the > > series... > > Well, 0-day may find more, but I can already tell you that patch 1 has > a checkpatch error:

[PATCH 2/2] net: dsa: qca8k: Improve SGMII interface handling

2020-06-10 Thread Jonathan McDowell
This patch improves the handling of the SGMII interface on the QCA8K devices. Previously the driver did no configuration of the port, even if it was selected. We now configure it up in the appropriate PHY/MAC/Base-X mode depending on what phylink tells us we are connected to and ensure it is enable

[PATCH 1/2] net: dsa: qca8k: Switch to PHYLINK instead of PHYLIB

2020-06-10 Thread Jonathan McDowell
Update the driver to use the new PHYLINK callbacks, removing the legacy adjust_link callback. Signed-off-by: Jonathan McDowell --- drivers/net/dsa/qca8k.c | 309 +++- 1 file changed, 212 insertions(+), 97 deletions(-) diff --git a/drivers/net/dsa/qca8k.c b/dr

[RFC PATCH v3 0/2] net: dsa: qca8k: Improve SGMII interface handling

2020-06-10 Thread Jonathan McDowell
Ok, take 3. This splits out the PHYLINK change to a separate patch which should have no effect on functionality, and then adds the SGMII clean-ups (i.e. the missing initialisation) on top of that as a second patch. As before, tested with a device where the CPU connection is RGMII (i.e. the common

[PATCH net-next v2 1/4] xfrm: bail early on slave pass over skb

2020-06-10 Thread Jarod Wilson
This is prep work for initial support of bonding hardware encryption pass-through support. The bonding driver will fill in the slave_dev pointer, and we use that to know not to skb_push() again on a given skb that was already processed on the bond device. CC: Jay Vosburgh CC: Veaceslav Falico CC

[PATCH net-next v2 2/4] ixgbe_ipsec: become aware of when running as a bonding slave

2020-06-10 Thread Jarod Wilson
Slave devices in a bond doing hardware encryption also need to be aware that they're slaves, so we operate on the slave instead of the bonding master to do the actual hardware encryption offload bits. CC: Jay Vosburgh CC: Veaceslav Falico CC: Andy Gospodarek CC: "David S. Miller" CC: Jeff Kirs

[PATCH net-next v2 4/4] bonding: support hardware encryption offload to slaves

2020-06-10 Thread Jarod Wilson
Currently, this support is limited to active-backup mode, as I'm not sure about the feasilibity of mapping an xfrm_state's offload handle to multiple hardware devices simultaneously, and we rely on being able to pass some hints to both the xfrm and NIC driver about whether or not they're operating

[PATCH net-next v2 3/4] mlx5: become aware of when running as a bonding slave

2020-06-10 Thread Jarod Wilson
I've been unable to get my hands on suitable supported hardware to date, but I believe this ought to be all that is needed to enable the mlx5 driver to also work with bonding active-backup crypto offload passthru. CC: Boris Pismenny CC: Saeed Mahameed CC: Leon Romanovsky CC: Jay Vosburgh CC: V

Re: [PATCH 0/2] Use __scm_install_fd() more widely

2020-06-10 Thread Jakub Kicinski
On Wed, 10 Jun 2020 10:03:03 -0700 Kees Cook wrote: > If 0-day doesn't kick anything back on this tree, I'll resend the > series... Well, 0-day may find more, but I can already tell you that patch 1 has a checkpatch error: ERROR: "(foo*)" should be "(foo *)" #149: FILE: net/core/scm.c:323: +

Re: [PATCH v2 1/7] Bluetooth: Add definitions for advertisement monitor features

2020-06-10 Thread Marcel Holtmann
Hi Miao-chen, > This adds support for Advertisement Monitor API. Here are the commands > and events added. > - Read Advertisement Monitor Feature command > - Add Advertisement Pattern Monitor command > - Remove Advertisement Monitor command > - Advertisement Monitor Added event > - Advertisement M

RE: [(RFC) PATCH ] be2net: Allow a VF to use physical link state.

2020-06-10 Thread dwilder
On 2020-06-09 14:58, Jakub Kicinski wrote: On Mon, 8 Jun 2020 17:00:59 -0700 David Wilder wrote: Hyper-visors owning a PF are allowed by Emulex specification to provide a VF with separate physical and/or logical link states. However, on linux, a VF driver must chose one or the other. My scena

Re: [PATCH 0/2] Use __scm_install_fd() more widely

2020-06-10 Thread Kees Cook
On Wed, Jun 10, 2020 at 11:47:35AM +0200, Christian Brauner wrote: > On Tue, Jun 09, 2020 at 09:52:12PM -0700, Kees Cook wrote: > > Hi, > > > > This extends the recent work hch did for scm_detach_fds(), and updates > > the compat path as well, fixing bugs in the process. Additionally, > > an effec

Re: [PATCH RFC v2 6/9] net: phy: add support for probing MMDs >= 8 for devices-in-package

2020-06-10 Thread Russell King - ARM Linux admin
On Wed, Jun 10, 2020 at 09:46:33PM +0530, Calvin Johnson wrote: > Hi Russell, > > On Wed, May 27, 2020 at 11:34:11AM +0100, Russell King wrote: > > Add support for probing MMDs above 7 for a valid devices-in-package > > specifier, but only probe the vendor MMDs for this if they also report > > tha

Re: [PATCH 2/2] pidfd: Replace open-coded partial __scm_install_fd()

2020-06-10 Thread Sargun Dhillon
On Tue, Jun 09, 2020 at 09:52:14PM -0700, Kees Cook wrote: > The sock counting (sock_update_netprioidx() and sock_update_classid()) > was missing from this implementation of fd installation, compared to > SCM_RIGHTS. Use the new scm helper to get the work done, after adjusting > it to return the in

Re: [PATCHv2 ipsec] xfrm: fix a warning in xfrm_policy_insert_list

2020-06-10 Thread Xin Long
On Tue, Jun 9, 2020 at 10:18 PM Tobias Brunner wrote: > > Hi Xin, > > >> I guess we could workaround this issue in strongSwan by installing > >> policies that share the same mark and selector with the same priority, > >> so only one instance is ever installed in the kernel. But the inability > >>

Re: [PATCH RFC v7 03/14] vhost: use batched get_vq_desc version

2020-06-10 Thread Eugenio Perez Martin
On Wed, Jun 10, 2020 at 5:13 PM Michael S. Tsirkin wrote: > > On Wed, Jun 10, 2020 at 02:37:50PM +0200, Eugenio Perez Martin wrote: > > > +/* This function returns a value > 0 if a descriptor was found, or 0 if > > > none were found. > > > + * A negative code is returned on error. */ > > > +stati

Re: [Intel-wired-lan] [PATCH] e1000e: Squash an unused function warning

2020-06-10 Thread Neftin, Sasha
On 6/10/2020 04:49, Palmer Dabbelt wrote: From: Palmer Dabbelt e1000e_check_me is only used under CONFIG_PM_SLEEP but exists unconditionally, which triggers a warning. Signed-off-by: Palmer Dabbelt --- drivers/net/ethernet/intel/e1000e/netdev.c | 2 ++ 1 file changed, 2 insertions(+) diff

Re: [PATCH RFC v2 6/9] net: phy: add support for probing MMDs >= 8 for devices-in-package

2020-06-10 Thread Calvin Johnson
Hi Russell, On Wed, May 27, 2020 at 11:34:11AM +0100, Russell King wrote: > Add support for probing MMDs above 7 for a valid devices-in-package > specifier, but only probe the vendor MMDs for this if they also report > that there the device is present in status register 2. This avoids > issues wh

[PATCH net v4 3/3] esp, ah: modernize the crypto algorithm selections

2020-06-10 Thread Eric Biggers
From: Eric Biggers The crypto algorithms selected by the ESP and AH kconfig options are out-of-date with the guidance of RFC 8221, which lists the legacy algorithms MD5 and DES as "MUST NOT" be implemented, and some more modern algorithms like AES-GCM and HMAC-SHA256 as "MUST" be implemented. But

[PATCH net v4 1/3] esp, ah: consolidate the crypto algorithm selections

2020-06-10 Thread Eric Biggers
From: Eric Biggers Instead of duplicating the algorithm selections between INET_AH and INET6_AH and between INET_ESP and INET6_ESP, create new tristates XFRM_AH and XFRM_ESP that do the algorithm selections, and make these be selected by the corresponding INET* options. Suggested-by: Herbert Xu

[PATCH net v4 2/3] esp: select CRYPTO_SEQIV

2020-06-10 Thread Eric Biggers
From: Eric Biggers Commit f23efcbcc523 ("crypto: ctr - no longer needs CRYPTO_SEQIV") made CRYPTO_CTR stop selecting CRYPTO_SEQIV. This breaks IPsec for most users since GCM and several other encryption algorithms require "seqiv" -- and RFC 8221 lists AES-GCM as "MUST" be implemented. Just make

[PATCH net v4 0/3] esp, ah: improve crypto algorithm selections

2020-06-10 Thread Eric Biggers
This series consolidates and modernizes the lists of crypto algorithms that are selected by the IPsec kconfig options, and adds CRYPTO_SEQIV since it no longer gets selected automatically by other things. See previous discussion at https://lkml.kernel.org/netdev/20200604192322.22142-1-ebigg...@ker

Re: [PATCH iproute2 net-next 1/2] ipnexthop: support for fdb nexthops

2020-06-10 Thread David Ahern
On 6/8/20 9:46 PM, Roopa Prabhu wrote: > @@ -70,6 +71,12 @@ static int nh_dump_filter(struct nlmsghdr *nlh, int reqlen) > return err; > } > > + if (filter.fdb) { > + addattr_l(nlh, reqlen, NHA_FDB, NULL, 0); missing 'err = ' > + if (err) >

Re: [PATCH net v3 3/3] esp, ah: modernize the crypto algorithm selections

2020-06-10 Thread Eric Biggers
On Wed, Jun 10, 2020 at 11:03:55AM +0200, Tobias Brunner wrote: > Hi Eric, > > > + Note that RFC 8221 considers AH itself to be "NOT RECOMMENDED". It is > > + better to use ESP only, using an AEAD cipher such as AES-GCM. > > What's NOT RECOMMENDED according to the RFC is the combination

Re: ethtool 5.7: netlink ENOENT error when setting WOL

2020-06-10 Thread Florian Fainelli
On 6/10/2020 3:50 AM, Heiner Kallweit wrote: > On 10.06.2020 11:13, Michal Kubecek wrote: >> On Wed, Jun 10, 2020 at 10:52:26AM +0200, Heiner Kallweit wrote: >>> On 10.06.2020 10:26, Heiner Kallweit wrote: Since ethtool 5.7 following happens (kernel is latest linux-next): ethtool

Re: [PATCH] net: mvneta: Fix Serdes configuration for 2.5Gbps modes

2020-06-10 Thread Florian Fainelli
On 6/9/2020 11:26 PM, Sascha Hauer wrote: > Hi Andrew, > > +Cc Maxime Chevallier > > On Tue, Jun 09, 2020 at 03:28:48PM +0200, Andrew Lunn wrote: >> On Tue, Jun 09, 2020 at 03:11:52PM +0200, Sascha Hauer wrote: >>> The Marvell MVNETA Ethernet controller supports a 2.5Gbps SGMII mode >>> called

Fw: [Bug 208121] New: IPsec AH ICV Padding for IPv4

2020-06-10 Thread Stephen Hemminger
Begin forwarded message: Date: Wed, 10 Jun 2020 09:32:26 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 208121] New: IPsec AH ICV Padding for IPv4 https://bugzilla.kernel.org/show_bug.cgi?id=208121 Bug ID: 208121 Summary: I

Re: [PATCH RFC v7 03/14] vhost: use batched get_vq_desc version

2020-06-10 Thread Michael S. Tsirkin
On Wed, Jun 10, 2020 at 02:37:50PM +0200, Eugenio Perez Martin wrote: > > +/* This function returns a value > 0 if a descriptor was found, or 0 if > > none were found. > > + * A negative code is returned on error. */ > > +static int fetch_descs(struct vhost_virtqueue *vq) > > +{ > > + int re

Re: [PATCH RFC v7 04/14] vhost/net: pass net specific struct pointer

2020-06-10 Thread Eugenio Pérez
On Wed, 2020-06-10 at 07:36 -0400, Michael S. Tsirkin wrote: > In preparation for further cleanup, pass net specific pointer > to ubuf callbacks so we can move net specific fields > out to net structures. > > Signed-off-by: Michael S. Tsirkin > --- > drivers/vhost/net.c | 14 +++--- > 1

Re: [PATCH RFC v7 03/14] vhost: use batched get_vq_desc version

2020-06-10 Thread Eugenio Perez Martin
On Wed, Jun 10, 2020 at 5:08 PM Michael S. Tsirkin wrote: > > On Wed, Jun 10, 2020 at 04:29:29PM +0200, Eugenio Pérez wrote: > > On Wed, 2020-06-10 at 07:36 -0400, Michael S. Tsirkin wrote: > > > As testing shows no performance change, switch to that now. > > > > > > Signed-off-by: Michael S. Tsi

Re: [PATCH RFC v7 03/14] vhost: use batched get_vq_desc version

2020-06-10 Thread Michael S. Tsirkin
On Wed, Jun 10, 2020 at 04:29:29PM +0200, Eugenio Pérez wrote: > On Wed, 2020-06-10 at 07:36 -0400, Michael S. Tsirkin wrote: > > As testing shows no performance change, switch to that now. > > > > Signed-off-by: Michael S. Tsirkin > > Signed-off-by: Eugenio Pérez > > Link: https://lore.kernel.o

Re: [PATCH 0/2] Use __scm_install_fd() more widely

2020-06-10 Thread Kees Cook
On Wed, Jun 10, 2020 at 11:47:35AM +0200, Christian Brauner wrote: > On Tue, Jun 09, 2020 at 09:52:12PM -0700, Kees Cook wrote: > > Hi, > > > > This extends the recent work hch did for scm_detach_fds(), and updates > > the compat path as well, fixing bugs in the process. Additionally, > > an effec

  1   2   >