Re: [net-next v4 10/12] ASoC: SOF: Introduce descriptors for SOF client

2020-05-23 Thread Greg KH
On Sat, May 23, 2020 at 02:41:51PM -0500, Pierre-Louis Bossart wrote: > > > On 5/23/20 1:23 AM, Greg KH wrote: > > On Fri, May 22, 2020 at 09:29:57AM -0500, Pierre-Louis Bossart wrote: > > > This is not an hypothetical case, we've had this recurring problem when a > > > PCI device creates an audi

Re: [PATCH v2 net-next 1/4] devlink: Add new "allow_fw_live_reset" generic device parameter.

2020-05-23 Thread Vasundhara Volam
On Sun, May 24, 2020 at 10:23 AM Jiri Pirko wrote: > > Sat, May 23, 2020 at 08:08:22AM CEST, vasundhara-v.vo...@broadcom.com wrote: > >Add a new "allow_fw_live_reset" generic device bool parameter. When > >parameter is set, user is allowed to reset the firmware in real time. > > > >This parameter

Re: [PATCH v2 net-next 1/4] devlink: Add new "allow_fw_live_reset" generic device parameter.

2020-05-23 Thread Jiri Pirko
Sat, May 23, 2020 at 08:08:22AM CEST, vasundhara-v.vo...@broadcom.com wrote: >Add a new "allow_fw_live_reset" generic device bool parameter. When >parameter is set, user is allowed to reset the firmware in real time. > >This parameter is employed to communicate user consent or dissent for >the live

Re: [RFC PATCH v12 10/11] arm64: add mechanism to let user choose which counter to return

2020-05-23 Thread Richard Cochran
On Fri, May 22, 2020 at 04:37:23PM +0800, Jianyong Wu wrote: > In general, vm inside will use virtual counter compered with host use > phyical counter. But in some special scenarios, like nested > virtualization, phyical counter maybe used by vm. A interface added in > ptp_kvm driver to offer a mec

Re: [RFC PATCH v12 10/11] arm64: add mechanism to let user choose which counter to return

2020-05-23 Thread Richard Cochran
On Fri, May 22, 2020 at 04:37:23PM +0800, Jianyong Wu wrote: > To use this feature, you should call PTP_EXTTS_REQUEST(2) ioctl with flag > set bit PTP_KVM_ARM_PHY_COUNTER in its argument then call > PTP_SYS_OFFSET_PRECISE(2) ioctl to get the cross timestamp and phyical > counter will return. If th

Re: [RFC PATCH v12 09/11] ptp: extend input argument for getcrosstimestamp API

2020-05-23 Thread Richard Cochran
On Fri, May 22, 2020 at 04:37:22PM +0800, Jianyong Wu wrote: > sometimes we may need tell getcrosstimestamp call back how to perform > itself. Extending input arguments for getcrosstimestamp API to offer more > exquisite control for the operation. This text does not offer any justification for the

Re: [GIT] Networking

2020-05-23 Thread pr-tracker-bot
The pull request you sent on Sat, 23 May 2020 17:06:54 -0700 (PDT): > git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git refs/heads/master has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/caffb99b6929f41a69edbb5aef3a359bf45f3315 Thank you! -- Deet-doot-dot,

[GIT] Networking

2020-05-23 Thread David Miller
path' Merge git://git.kernel.org/.../bpf/bpf Merge tag 'rxrpc-fixes-20200520' of git://git.kernel.org/.../dhowells/linux-fs Merge branch 'netdevsim-Two-small-fixes' Merge branch 'mlxsw-Various-fixes' Merge tag 'rxrpc-fixes-20200523-v2'

Re: [PATCH net-next] ethtool: propagate get_coalesce return value

2020-05-23 Thread David Miller
From: Heiner Kallweit Date: Sat, 23 May 2020 17:40:25 +0200 > get_coalesce returns 0 or ERRNO, but the return value isn't checked. > The returned coalesce data may be invalid if an ERRNO is set, > therefore better check and propagate the return value. > > Signed-off-by: Heiner Kallweit Applied

Re: [PATCH v2 0/5] net: provide a devres variant of register_netdev()

2020-05-23 Thread David Miller
From: Bartosz Golaszewski Date: Sat, 23 May 2020 15:27:06 +0200 > From: Bartosz Golaszewski > > Using devres helpers allows to shrink the probing code, avoid memory leaks in > error paths make sure the order in which resources are freed is the exact > opposite of their allocation. This series p

Re: [PATCH net-next 0/3] r8169: remove mask argument from few ERI/OCP functions

2020-05-23 Thread David Miller
From: Heiner Kallweit Date: Sat, 23 May 2020 13:20:33 +0200 > Few ERI/OCP functions have a mask argument that isn't needed. > Remove it to simplify the functions. Series applied, thanks Heiner.

Re: [PATCH] net: smsc911x: Fix runtime PM imbalance on error

2020-05-23 Thread David Miller
From: Dinghao Liu Date: Sat, 23 May 2020 16:08:20 +0800 > Remove runtime PM usage counter decrement when the > increment function has not been called to keep the > counter balanced. > > Signed-off-by: Dinghao Liu Applied, thank you.

Re: [net-next 00/16][pull request] 100GbE Intel Wired LAN Driver Updates 2020-05-22

2020-05-23 Thread David Miller
From: Jeff Kirsher Date: Fri, 22 May 2020 23:48:31 -0700 > This series contains updates to virtchnl and the ice driver. Also pulled, thanks Jeff.

Re: [net-next 00/17][pull request] 1GbE Intel Wired LAN Driver Updates 2020-05-22

2020-05-23 Thread David Miller
From: Jeff Kirsher Date: Fri, 22 May 2020 19:50:52 -0700 > This series contains updates to e1000e, igc and igb. Pulled, thanks Jeff.

Re: [pull request][net 00/13] mlx5 fixes 2020-05-22

2020-05-23 Thread David Miller
From: Saeed Mahameed Date: Fri, 22 May 2020 17:40:36 -0700 > This series introduces some fixes to mlx5 driver. > > Please pull and let me know if there is any problem. Pulled. > For -stable v4.13 >('net/mlx5: Add command entry handling completion') > > For -stable v5.2 >('net/mlx5: Fi

Re: [pull request][net-next 00/10] mlx5 updates 2020-05-22

2020-05-23 Thread David Miller
From: Saeed Mahameed Date: Fri, 22 May 2020 16:51:38 -0700 > This series adds misc updates to mlx5 driver. > For more information please see tag log below. > > Please pull and let me know if there is any problem. Pulled, thank you.

Re: [PATCH net-next v2] net: psample: fix build error when CONFIG_INET is not enabled

2020-05-23 Thread David Miller
From: Randy Dunlap Date: Fri, 22 May 2020 13:05:26 -0700 > From: Randy Dunlap > > Fix psample build error when CONFIG_INET is not set/enabled by > bracketing the tunnel code in #ifdef CONFIG_NET / #endif. > > ../net/psample/psample.c: In function ‘__psample_ip_tun_to_nlattr’: > ../net/psample/

Re: [PATCH v2] net/mlx4_core: fix a memory leak bug.

2020-05-23 Thread David Miller
From: wu000...@umn.edu Date: Fri, 22 May 2020 14:07:15 -0500 > From: Qiushi Wu > > In function mlx4_opreq_action(), pointer "mailbox" is not released, > when mlx4_cmd_box() return and error, causing a memory leak bug. > Fix this issue by going to "out" label, mlx4_free_cmd_mailbox() can > free t

Re: [PATCH] net: ethernet: ti: cpsw: fix ASSERT_RTNL() warning during suspend

2020-05-23 Thread David Miller
From: Grygorii Strashko Date: Fri, 22 May 2020 19:39:31 +0300 > vlan_for_each() are required to be called with rtnl_lock taken, otherwise > ASSERT_RTNL() warning will be triggered - which happens now during System > resume from suspend: > cpsw_suspend() > |- cpsw_ndo_stop() > |- __hw_addr

Re: [PATCH net v2] net: phy: mscc: fix initialization of the MACsec protocol mode

2020-05-23 Thread David Miller
From: Antoine Tenart Date: Fri, 22 May 2020 17:55:45 +0200 > At the very end of the MACsec block initialization in the MSCC PHY > driver, the MACsec "protocol mode" is set. This setting should be set > based on the PHY id within the package, as the bank used to access the > register used depends

Re: [PATCH] net: stmmac: don't attach interface until resume finishes

2020-05-23 Thread David Miller
From: Leon Yu Date: Fri, 22 May 2020 23:29:43 +0800 > Commit 14b41a2959fb ("net: stmmac: Delete txtimer in suspend") was the > first attempt to fix a race between mod_timer() and setup_timer() > during stmmac_resume(). However the issue still exists as the commit > only addressed half of the issu

Re: [PATCH] net: Fix return value about devm_platform_ioremap_resource()

2020-05-23 Thread David Miller
From: Tiezhu Yang Date: Fri, 22 May 2020 19:03:21 +0800 > When call function devm_platform_ioremap_resource(), we should use IS_ERR() > to check the return value and return PTR_ERR() if failed. > > Signed-off-by: Tiezhu Yang Applied, thanks.

Re: [PATCH net-next] net: phy: at803x: fix PHY ID masks

2020-05-23 Thread David Miller
From: Michael Walle Date: Fri, 22 May 2020 11:53:31 +0200 > Ever since its first commit 0ca7111a38f05 ("phy: add AT803x driver") the > PHY ID mask was set to 0xffef. It is unclear to me why this mask was > chosen in the first place. Both the AR8031/AR8033 and the AR8035 > datasheets mention i

Re: [PATCH v2 0/7] Share events between metrics

2020-05-23 Thread Jiri Olsa
On Fri, May 22, 2020 at 10:56:59AM -0700, Ian Rogers wrote: SNIP > >> > #11 0x004b6911 in cmd_test (argc=1, argv=0x7fffd7f0) > >> > at tests/builtin-test.c:772 > >> > #12 0x004e977b in run_builtin (p=0xa7eee8 , > >> > argc=3, argv=0x7fffd7f0) at perf.c:312 >

Re: [PATCH net-next v2 4/4] net: dp83869: Add RGMII internal delay configuration

2020-05-23 Thread Andrew Lunn
> > Any why is your PHY special, in that is does care about out of range > > delays, when others using new the new core helper don't? > > We are not rounding to nearest here.  Basically the helper works to find the > best match > > If the delay passed in is less than or equal to the smallest dela

Re: [PATCH net-next v2 4/4] net: dp83869: Add RGMII internal delay configuration

2020-05-23 Thread Dan Murphy
Andrew On 5/23/20 10:09 AM, Andrew Lunn wrote: + dp83869->tx_id_delay = DP83869_RGMII_CLK_DELAY_INV; + ret = of_property_read_u32(of_node, "tx-internal-delay-ps", + &dp83869->tx_id_delay); + if (!ret && dp83869->tx_id_delay > dp83869_internal_de

Re: [RFC v3 1/2] thermal: core: Let thermal zone device's mode be stored in its struct

2020-05-23 Thread Daniel Lezcano
Hi Andrzej, On 17/04/2020 18:20, Andrzej Pietrasiewicz wrote: > Thermal zone devices' mode is stored in individual drivers. This patch > changes it so that mode is stored in struct thermal_zone_device instead. > > As a result all driver-specific variables storing the mode are not needed > and are

Re: [RFC 03/11] net: phy: refactor c45 phy identification sequence

2020-05-23 Thread Russell King - ARM Linux admin
On Sat, May 23, 2020 at 09:51:31PM +0200, Andrew Lunn wrote: > > > static int get_phy_c45_ids(struct mii_bus *bus, int addr, u32 *phy_id, > > > struct phy_c45_device_ids *c45_ids) { > > > - int phy_reg; > > > - int i, reg_addr; > > > + int ret; > > > + int i; > > > const int

Re: [PATCH] Fix various coding-style issues and improve printk() usage

2020-05-23 Thread Stephen Hemminger
On Sat, 23 May 2020 18:06:44 +0200 Armin Wolf wrote: > /* These identify the driver base version and may not be removed. */ > static const char version[] = > - KERN_INFO DRV_NAME ".c:v" DRV_VERSION " " DRV_RELDATE > - " D. Becker/P. Gortmaker\n"; > + "Version " DRV_VERSION " " DRV_R

Re: [PATCH] Fix various coding-style issues and improve printk() usage

2020-05-23 Thread Stephen Hemminger
On Sat, 23 May 2020 18:06:44 +0200 Armin Wolf wrote: > + * > + * Authors and other copyright holders: > + * 1992-2000 by Donald Becker, NE2000 core and various modifications. > + * 1995-1998 by Paul Gortmaker, core modifications and PCI support. > + * Copyright 1993 assigned to the United States

Re: [RFC 03/11] net: phy: refactor c45 phy identification sequence

2020-05-23 Thread Andrew Lunn
> > static int get_phy_c45_ids(struct mii_bus *bus, int addr, u32 *phy_id, > >struct phy_c45_device_ids *c45_ids) { > > - int phy_reg; > > - int i, reg_addr; > > + int ret; > > + int i; > > const int num_ids = ARRAY_SIZE(c45_ids->device_ids); > > u32 *devs =

Re: [net-next v4 10/12] ASoC: SOF: Introduce descriptors for SOF client

2020-05-23 Thread Pierre-Louis Bossart
On 5/23/20 1:23 AM, Greg KH wrote: On Fri, May 22, 2020 at 09:29:57AM -0500, Pierre-Louis Bossart wrote: This is not an hypothetical case, we've had this recurring problem when a PCI device creates an audio card represented as a platform device. When the card registration fails, typically due

Re: [RFC 03/11] net: phy: refactor c45 phy identification sequence

2020-05-23 Thread Russell King - ARM Linux admin
On Sat, May 23, 2020 at 12:32:59PM -0500, Jeremy Linton wrote: > Hi, > > On 5/23/20 10:28 AM, Andrew Lunn wrote: > > On Fri, May 22, 2020 at 04:30:51PM -0500, Jeremy Linton wrote: > > > Lets factor out the phy id logic, and make it generic > > > so that it can be used for c22 and c45. > > > > > >

Re: [RFC 10/11] net: example acpize xgmac_mdio

2020-05-23 Thread Russell King - ARM Linux admin
On Fri, May 22, 2020 at 04:30:58PM -0500, Jeremy Linton wrote: > Signed-off-by: Jeremy Linton > --- > drivers/net/ethernet/freescale/xgmac_mdio.c | 27 + > 1 file changed, 17 insertions(+), 10 deletions(-) > > diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c > b/driv

Re: [RFC 07/11] net: phy: reset invalid phy reads of 0 back to 0xffffffff

2020-05-23 Thread Russell King - ARM Linux admin
On Fri, May 22, 2020 at 04:30:55PM -0500, Jeremy Linton wrote: > MMD's in the device list sometimes return 0 for their id. > When that happens lets reset the id back to 0xfff so > that we don't get a stub device created for it. > > This is a questionable commit, but i'm tossing it out > there

Re: [RFC 04/11] net: phy: Handle c22 regs presence better

2020-05-23 Thread Russell King - ARM Linux admin
On Fri, May 22, 2020 at 04:30:52PM -0500, Jeremy Linton wrote: > Until this point, we have been sanitizing the c22 > regs presence bit out of all the MMD device lists. > This is incorrect as it causes the 0x checks > to incorrectly fail. Further, it turns out that we > want to utilize this

Re: [RFC 02/11] net: phy: Simplify MMD device list termination

2020-05-23 Thread Russell King - ARM Linux admin
On Fri, May 22, 2020 at 04:30:50PM -0500, Jeremy Linton wrote: > Since we are already checking for *devs == 0 after > the loop terminates, we can add a mostly F's check > as well. With that change we can simplify the return/break > sequence inside the loop. > > Add a valid_phy_id() macro for this,

Re: [RFC 03/11] net: phy: refactor c45 phy identification sequence

2020-05-23 Thread Russell King - ARM Linux admin
On Fri, May 22, 2020 at 04:30:51PM -0500, Jeremy Linton wrote: > Lets factor out the phy id logic, and make it generic > so that it can be used for c22 and c45. > > Signed-off-by: Jeremy Linton > --- > drivers/net/phy/phy_device.c | 65 +++- > 1 file changed, 35 i

Re: [RFC 01/11] net: phy: Don't report success if devices weren't found

2020-05-23 Thread Russell King - ARM Linux admin
On Fri, May 22, 2020 at 04:30:49PM -0500, Jeremy Linton wrote: > C45 devices are to return 0 for registers they haven't > implemented. This means in theory we can terminate the > device search loop without finding any MMDs. In that > case we want to immediately return indicating that > nothing was

[PATCH net-next] ipv4: potential underflow in compat_ip_setsockopt()

2020-05-23 Thread Dan Carpenter
The value of "n" is capped at 0x1ff but it checked for negative values. I don't think this causes a problem but I'm not certain and it's harmless to prevent it. Fixes: 2e04172875c9 ("ipv4: do compat setsockopt for MCAST_MSFILTER directly") Signed-off-by: Dan Carpenter --- net/ipv4/ip_sockg

Re: [RFC 03/11] net: phy: refactor c45 phy identification sequence

2020-05-23 Thread Jeremy Linton
Hi, On 5/23/20 10:28 AM, Andrew Lunn wrote: On Fri, May 22, 2020 at 04:30:51PM -0500, Jeremy Linton wrote: Lets factor out the phy id logic, and make it generic so that it can be used for c22 and c45. Signed-off-by: Jeremy Linton --- drivers/net/phy/phy_device.c | 65 +++

Re: [RFC 03/11] net: phy: refactor c45 phy identification sequence

2020-05-23 Thread Jeremy Linton
Hi, Thanks for taking a look at this! On 5/23/20 10:28 AM, Andrew Lunn wrote: On Fri, May 22, 2020 at 04:30:51PM -0500, Jeremy Linton wrote: Lets factor out the phy id logic, and make it generic so that it can be used for c22 and c45. Signed-off-by: Jeremy Linton --- drivers/net/phy/phy_de

Re: [PATCH net-next v2 0/2] flow_dissector, cls_flower: Add support for multiple MPLS Label Stack Entries

2020-05-23 Thread Guillaume Nault
[ Dropping the @netronome.com addresses that bounce. ] On Thu, May 21, 2020 at 07:47:12PM +0200, Guillaume Nault wrote: > Currently, the flow dissector and the Flower classifier can only handle > the first entry of an MPLS label stack. This patch series generalises > the code to allow parsing and

Re: [bpf-next PATCH v4 2/5] bpf: extend bpf_base_func_proto helpers with probe_* and *current_task*

2020-05-23 Thread John Fastabend
Daniel Borkmann wrote: > On 5/22/20 6:24 AM, John Fastabend wrote: > > Often it is useful when applying policy to know something about the > > task. If the administrator has CAP_SYS_ADMIN rights then they can > > use kprobe + networking hook and link the two programs together to > > accomplish this

[PATCH] Fix various coding-style issues and improve printk() usage

2020-05-23 Thread Armin Wolf
Fixed a ton of minor checkpatch errors/warnings and replace printk() with pr_info() to pass the corresponding log level. Also modifying the RTL8029 PCI string to include the compatible RTL8029AS nic. The only mayor issue remaining is the missing SPDX tag, but since the exact version of the GPL is n

[PATCH net-next] ethtool: propagate get_coalesce return value

2020-05-23 Thread Heiner Kallweit
get_coalesce returns 0 or ERRNO, but the return value isn't checked. The returned coalesce data may be invalid if an ERRNO is set, therefore better check and propagate the return value. Signed-off-by: Heiner Kallweit --- net/ethtool/ioctl.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(

Re: [RFC 03/11] net: phy: refactor c45 phy identification sequence

2020-05-23 Thread Andrew Lunn
On Fri, May 22, 2020 at 04:30:51PM -0500, Jeremy Linton wrote: > Lets factor out the phy id logic, and make it generic > so that it can be used for c22 and c45. > > Signed-off-by: Jeremy Linton > --- > drivers/net/phy/phy_device.c | 65 +++- > 1 file changed, 35 i

Re: [PATCH net-next v2 1/4] dt-bindings: net: Add tx and rx internal delays

2020-05-23 Thread Andrew Lunn
On Fri, May 22, 2020 at 07:25:31AM -0500, Dan Murphy wrote: > tx-internal-delays and rx-internal-delays are a common setting for RGMII > capable devices. > > These properties are used when the phy-mode or phy-controller is set to > rgmii-id, rgmii-rxid or rgmii-txid. These modes indicate to the >

Re: [PATCH net-next v2 4/4] net: dp83869: Add RGMII internal delay configuration

2020-05-23 Thread Andrew Lunn
> > > + dp83869->tx_id_delay = DP83869_RGMII_CLK_DELAY_INV; > > > + ret = of_property_read_u32(of_node, "tx-internal-delay-ps", > > > +&dp83869->tx_id_delay); > > > + if (!ret && dp83869->tx_id_delay > dp83869_internal_delay[delay_size]) { > > > + phydev_err(phyd

Re: [RFC PATCH net-next 4/4] net: dp83869: Add RGMII internal delay configuration

2020-05-23 Thread Andrew Lunn
On Thu, May 21, 2020 at 12:48:34PM -0500, Dan Murphy wrote: > Add RGMII internal delay configuration for Rx and Tx. > > Signed-off-by: Dan Murphy > --- > drivers/net/phy/dp83869.c | 101 ++ > 1 file changed, 101 insertions(+) > > diff --git a/drivers/net/phy/

Re: [PATCH v2 4/5] net: devres: provide devm_register_netdev()

2020-05-23 Thread Markus Elfring
… > +++ b/net/devres.c > @@ -38,3 +38,58 @@ struct net_device *devm_alloc_etherdev_mqs(struct device > *dev, int sizeof_priv, … > + * This is a devres variant of register_netdev() for which the unregister > + * function will be call automatically when the managing device is Is the following w

[PATCH v2 2/5] net: move devres helpers into a separate source file

2020-05-23 Thread Bartosz Golaszewski
From: Bartosz Golaszewski There's currently only a single devres helper in net/ - devm variant of alloc_etherdev. Let's move it to net/devres.c with the intention of assing a second one: devm_register_netdev(). This new routine will need to know the address of the release function of devm_alloc_e

[PATCH v2 0/5] net: provide a devres variant of register_netdev()

2020-05-23 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Using devres helpers allows to shrink the probing code, avoid memory leaks in error paths make sure the order in which resources are freed is the exact opposite of their allocation. This series proposes to add a devres variant of register_netdev() that will only work wit

[PATCH v2 5/5] net: ethernet: mtk_star_emac: use devm_register_netdev()

2020-05-23 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Use the new devres variant of register_netdev() in the mtk-star-emac driver and shrink the code by a couple lines. Signed-off-by: Bartosz Golaszewski --- drivers/net/ethernet/mediatek/mtk_star_emac.c | 17 + 1 file changed, 1 insertion(+), 16 deletions

[PATCH v2 3/5] net: devres: define a separate devres structure for devm_alloc_etherdev()

2020-05-23 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Not using a proxy structure to store struct net_device doesn't save anything in terms of compiled code size or memory usage but significantly decreases the readability of the code with all the pointer casting. Define struct net_device_devres and use it in devm_alloc_eth

[PATCH v2 4/5] net: devres: provide devm_register_netdev()

2020-05-23 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Provide devm_register_netdev() - a device resource managed variant of register_netdev(). This new helper will only work for net_device structs that are also already managed by devres. Signed-off-by: Bartosz Golaszewski --- .../driver-api/driver-model/devres.rst

[PATCH v2 1/5] Documentation: devres: add a missing section for networking helpers

2020-05-23 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Add a new section for networking devres helpers to devres.rst and list the two existing devm functions. Signed-off-by: Bartosz Golaszewski --- Documentation/driver-api/driver-model/devres.rst | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/driver

[PATCH rdma-next v1 0/9] Driver part of the ECE

2020-05-23 Thread Leon Romanovsky
From: Leon Romanovsky Changelog: v1: * Fixed compatibility issue of "old" kernel vs. "new" rdma-core. This is handled in extra patch. * Improved comments and commit messages after feedback from Yishai. * Added Mark Z. ROB tags v0: https://lore.kernel.org/linux-rdma/20200520082919.440939-1-l

[PATCH mlx5-next v1 1/9] net/mlx5: Add ability to read and write ECE options

2020-05-23 Thread Leon Romanovsky
From: Leon Romanovsky The end result of RDMA-CM ECE handshake is ECE options, which is needed to be used while configuring data QPs. Such options can come in any QP state, so add in/out fields to set and query ECE options. OUT fields: * create_qp()/create_dct() - default ECE options for that typ

Re: [PATCH v5 00/11] mediatek: add support for MediaTek Ethernet MAC

2020-05-23 Thread Matthias Brugger
On 5/22/20 11:36 PM, David Miller wrote: > From: Matthias Brugger > Date: Fri, 22 May 2020 23:31:50 +0200 > >> >> >> On 22/05/2020 23:20, David Miller wrote: >>> From: Bartosz Golaszewski >>> Date: Fri, 22 May 2020 14:06:49 +0200 >>> This series adds support for the STAR Ethernet Control

Re: [PATCH 0/5] net: provide a devres variant of register_netdev()

2020-05-23 Thread Bartosz Golaszewski
sob., 23 maj 2020 o 00:36 David Miller napisał(a): > > From: Bartosz Golaszewski > Date: Wed, 20 May 2020 13:44:10 +0200 > > > net: ethernet: mtk_eth_mac: use devm_register_netdev() > > This patch doesn't apply to net-next. > > Neither the source file drivers/net/ethernet/mediatek/mtk_eth_mac.c

[PATCH] e1000: Fix typo in the comment

2020-05-23 Thread Hari
Continuous Double "the" in a comment. Changed it to single "the" Signed-off-by: Hari --- drivers/net/ethernet/intel/e1000/e1000_hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/e1000/e1000_hw.c b/drivers/net/ethernet/intel/e1000/e1000_hw.c inde

Re: [PATCH 06/12] xen-blkfront: add callbacks for PM suspend and hibernation

2020-05-23 Thread kbuild test robot
Hi Anchal, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.7-rc6] [cannot apply to xen-tip/linux-next tip/irq/core tip/auto-latest next-20200519] [if your patch is applied to the wrong git tree, please drop us a note

Re: general protection fault in selinux_socket_recvmsg

2020-05-23 Thread Ondrej Mosnacek
On Sat, May 23, 2020 at 9:14 AM syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:051143e1 Merge tag 'apparmor-pr-2020-05-21' of git://git.k.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=1313f01610 > kernel config: h

Re: [PATCH] sctp: check assoc before SCTP_ADDR_{MADE_PRIM,ADDED} event

2020-05-23 Thread Jonas Falkevik
On Tue, May 19, 2020 at 10:42 PM Marcelo Ricardo Leitner wrote: > > On Fri, May 15, 2020 at 10:30:29AM +0200, Jonas Falkevik wrote: > > On Wed, May 13, 2020 at 11:32 PM Marcelo Ricardo Leitner > > wrote: > > > > > > On Wed, May 13, 2020 at 10:11:05PM +0200, Jonas Falkevik wrote: > > > > On Wed, M

[PATCH net-next 2/3] r8169: remove mask argument from r8168dp_ocp_read

2020-05-23 Thread Heiner Kallweit
All callers read the full 32bit value, therefore the mask argument can be removed. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169_main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/eth

[PATCH net-next 1/3] r8169: remove mask argument from rtl_w0w1_eri

2020-05-23 Thread Heiner Kallweit
rtl_eri_read() returns the full 32bit value, therefore there's no benefit in writing back parts of it only. handle it like the vendor driver and write the full 32 bit always. Omitting the mask argument avoids some overhead and makes the code better readable. Signed-off-by: Heiner Kallweit --- dr

[PATCH net-next 3/3] r8169: remove mask argument from r8168ep_ocp_read

2020-05-23 Thread Heiner Kallweit
Remove the mask argument as it's not used by r8168ep_ocp_read(). Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169_main.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek

[PATCH net-next 0/3] r8169: remove mask argument from few ERI/OCP functions

2020-05-23 Thread Heiner Kallweit
Few ERI/OCP functions have a mask argument that isn't needed. Remove it to simplify the functions. Heiner Kallweit (3): r8169: remove mask argument from rtl_w0w1_eri r8169: remove mask argument from r8168dp_ocp_read r8169: remove mask argument from r8168ep_ocp_read drivers/net/ethernet/rea

Re: [PATCH net-next v2 0/4] Implement classifier-action terse dump mode

2020-05-23 Thread Jamal Hadi Salim
On 2020-05-22 12:16 p.m., Vlad Buslov wrote: On Thu 21 May 2020 at 20:02, Jakub Kicinski wrote: On Thu, 21 May 2020 17:36:12 +0300 Vlad Buslov wrote: Hi Edward, Cong, Do you really need to dump classifiers? If you care about stats the actions could be sufficient if the offload code was fix

Re: [PATCH iproute2 v3 0/2] bpf: memory access fixes

2020-05-23 Thread Jamal Hadi Salim
On 2020-05-22 9:33 p.m., Daniel Borkmann wrote: On 5/18/20 3:00 PM, Jamal Hadi Salim wrote: ping? Note: these are trivial bug fixes. Looking at c0325b06382c ("bpf: replace snprintf with asprintf when dealing with long buffers"), I wonder whether it's best to just revert and redo cleanly from

Re: [PATCH net 2/4] dt-bindings: fec: update the gpr property

2020-05-23 Thread Fuzzey, Martin
> - gpr: phandle of SoC general purpose register mode. Required for wake on LAN > - on some SoCs > + on some SoCs. Register bits of stop mode control, the format is > + <&gpr req_gpr req_bit>. > +gpr is the phandle to general purpose register node. > +req_gpr is the gpr reg

[PATCH 1/1] MVNETA_SKB_HEADROOM set last 3 bits to zero

2020-05-23 Thread Sven Auhagen
For XDP the MVNETA_SKB_HEADROOM is used as an offset for the received data. The MVNETA manual states that the last 3 bits assumed to be 0. This is currently the case but lets make it explicit in the definition to prevent future problems. Signed-off-by: Sven Auhagen --- drivers/net/ethernet/mar

Re: [PATCH net-next v2 1/2] flow_dissector: Parse multiple MPLS Label Stack Entries

2020-05-23 Thread Guillaume Nault
[Cc: John Hurley for NFP driver review, as Pieter Jansen van Vuuren and Benjamin LaHaise emails bounce] On Thu, May 21, 2020 at 07:47:17PM +0200, Guillaume Nault wrote: > The current MPLS dissector only parses the first MPLS Label Stack > Entry (second LSE can be parsed too, but only to set a ke

Re: [PATCH net 1/4] net: ethernet: fec: move GPR register offset and bit into DT

2020-05-23 Thread Fuzzey, Martin
Hi Andy, > Fixes: da722186f654(net: fec: set GPR bit on suspend by DT configuration) Just a nitpick maybe but I don't really think this need as Fixes: tag. That commit didn't actually *break* anything AFAIK. It added WoL support for *some* SoCs that didn't have any in mainline and didn't hurt the

Re: [PATCH 2/2] e1000e: Make WOL info in ethtool consistent with device wake up ability

2020-05-23 Thread Chen Yu
Hi Michal, Thanks for reviewing, and sorry for late reply. On Thu, May 21, 2020 at 09:23:42PM +0200, Michal Kubecek wrote: > On Fri, May 22, 2020 at 01:59:13AM +0800, Chen Yu wrote: > > Currently the ethtool shows that WOL(Wake On Lan) is enabled > > even if the device wakeup ability has been disab

Re: [PATCH v2] xfrm: policy: Fix xfrm policy match

2020-05-23 Thread Xin Long
On Fri, May 22, 2020 at 8:39 PM Yuehaibing wrote: > > On 2020/5/22 13:49, Xin Long wrote: > > On Fri, May 22, 2020 at 9:45 AM Yuehaibing wrote: > >> > >> On 2020/5/21 14:49, Xin Long wrote: > >>> On Tue, May 19, 2020 at 4:53 PM Steffen Klassert > >>> wrote: > > On Fri, May 15, 2020 at

[PATCH] net: smsc911x: Fix runtime PM imbalance on error

2020-05-23 Thread Dinghao Liu
Remove runtime PM usage counter decrement when the increment function has not been called to keep the counter balanced. Signed-off-by: Dinghao Liu --- drivers/net/ethernet/smsc/smsc911x.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/smsc/smsc9

Re: [PATCH] mt76: mt7915: Use proper enum type in __mt7915_mcu_msg_send

2020-05-23 Thread Ryder Lee
On Fri, 2020-05-22 at 21:19 -0700, Nathan Chancellor wrote: > Clang warns: > > drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:232:9: warning: implicit > conversion from enumeration type 'enum mt76_txq_id' to different > enumeration type 'enum mt7915_txq_id' [-Wenum-conversion] > t

WARNING: proc registration bug in clusterip_tg_check (2)

2020-05-23 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:d2f8825a Merge tag 'for_linus' of git://git.kernel.org/pub.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=10eed27210 kernel config: https://syzkaller.appspot.com/x/.config?x=c33c7f7c5471fd39 das

Re: remove kernel_setsockopt and kernel_getsockopt v2

2020-05-23 Thread Christoph Hellwig
On Wed, May 20, 2020 at 09:54:36PM +0200, Christoph Hellwig wrote: > Hi Dave, > > this series removes the kernel_setsockopt and kernel_getsockopt > functions, and instead switches their users to small functions that > implement setting (or in one case getting) a sockopt directly using > a normal k

Re: do a single memdup_user in sctp_setsockopt

2020-05-23 Thread 'Christoph Hellwig'
On Fri, May 22, 2020 at 11:36:23AM -0300, Marcelo Ricardo Leitner wrote: > It's subjective, yes, but we hardly have patches over 5k lines. > In the case here, as changing the functions also requires changing > their call later on the file, it helps to be able to check that is was > properly updated

general protection fault in selinux_socket_recvmsg

2020-05-23 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:051143e1 Merge tag 'apparmor-pr-2020-05-21' of git://git.k.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1313f01610 kernel config: https://syzkaller.appspot.com/x/.config?x=b3368ce0cc5f5ace das

RE: [Intel-wired-lan] [PATCH] Fix typo in the comment

2020-05-23 Thread Kirsher, Jeffrey T
> -Original Message- > From: Intel-wired-lan On Behalf Of Hari > Sent: Friday, May 22, 2020 03:30 > To: da...@davemloft.net; k...@kernel.org > Cc: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org; linux- > ker...@vger.kernel.org; Hari > Subject: [Intel-wired-lan] [PATCH] Fix typo

[net-next 04/16] ice: Support IPv4 Flow Director filters

2020-05-23 Thread Jeff Kirsher
From: Henry Tieman Support the addition and deletion of IPv4 filters. Supported fields are: src-ip, dst-ip, src-port, and dst-port Supported flow-types are: tcp4, udp4, sctp4, ip4 Example usage: ethtool -N eth0 flow-type tcp4 src-ip 192.168.0.55 dst-ip 172.16.0.55 \ src-port 16 dst-port 12 act