[PATCH] bnxt_en: use new module_firmware_crashed()

2020-05-15 Thread Vasundhara Volam
This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to an

Re: [PATCH v2 04/15] bnxt: use new module_firmware_crashed()

2020-05-15 Thread Vasundhara Volam
On Sat, May 16, 2020 at 3:00 AM Luis Chamberlain wrote: > > This makes use of the new module_firmware_crashed() to help > annotate when firmware for device drivers crash. When firmware > crashes devices can sometimes become unresponsive, and recovery > sometimes requires a driver unload / reload a

Re: [PATCH v2 15/15] mwl8k: use new module_firmware_crashed()

2020-05-15 Thread Rafael Aquini
On Fri, May 15, 2020 at 09:28:46PM +, Luis Chamberlain wrote: > This makes use of the new module_firmware_crashed() to help > annotate when firmware for device drivers crash. When firmware > crashes devices can sometimes become unresponsive, and recovery > sometimes requires a driver unload / r

Re: [PATCH v2 14/15] brcm80211: use new module_firmware_crashed()

2020-05-15 Thread Rafael Aquini
On Fri, May 15, 2020 at 09:28:45PM +, Luis Chamberlain wrote: > This makes use of the new module_firmware_crashed() to help > annotate when firmware for device drivers crash. When firmware > crashes devices can sometimes become unresponsive, and recovery > sometimes requires a driver unload / r

Re: [PATCH v2 13/15] ath6kl: use new module_firmware_crashed()

2020-05-15 Thread Rafael Aquini
On Fri, May 15, 2020 at 09:28:44PM +, Luis Chamberlain wrote: > This makes use of the new module_firmware_crashed() to help > annotate when firmware for device drivers crash. When firmware > crashes devices can sometimes become unresponsive, and recovery > sometimes requires a driver unload / r

Re: [PATCH v2 12/15] ath10k: use new module_firmware_crashed()

2020-05-15 Thread Rafael Aquini
On Fri, May 15, 2020 at 09:28:43PM +, Luis Chamberlain wrote: > This makes use of the new module_firmware_crashed() to help > annotate when firmware for device drivers crash. When firmware > crashes devices can sometimes become unresponsive, and recovery > sometimes requires a driver unload / r

Re: [PATCH v2 11/15] wimax/i2400m: use new module_firmware_crashed()

2020-05-15 Thread Rafael Aquini
On Fri, May 15, 2020 at 09:28:42PM +, Luis Chamberlain wrote: > This makes use of the new module_firmware_crashed() to help > annotate when firmware for device drivers crash. When firmware > crashes devices can sometimes become unresponsive, and recovery > sometimes requires a driver unload / r

Re: [PATCH v2 10/15] soc: qcom: ipa: use new module_firmware_crashed()

2020-05-15 Thread Rafael Aquini
On Fri, May 15, 2020 at 09:28:41PM +, Luis Chamberlain wrote: > This makes use of the new module_firmware_crashed() to help > annotate when firmware for device drivers crash. When firmware > crashes devices can sometimes become unresponsive, and recovery > sometimes requires a driver unload / r

Re: [PATCH v2 09/15] qed: use new module_firmware_crashed()

2020-05-15 Thread Rafael Aquini
On Fri, May 15, 2020 at 09:28:40PM +, Luis Chamberlain wrote: > This makes use of the new module_firmware_crashed() to help > annotate when firmware for device drivers crash. When firmware > crashes devices can sometimes become unresponsive, and recovery > sometimes requires a driver unload / r

Re: [PATCH v2 07/15] cxgb4: use new module_firmware_crashed()

2020-05-15 Thread Rafael Aquini
On Fri, May 15, 2020 at 09:28:38PM +, Luis Chamberlain wrote: > This makes use of the new module_firmware_crashed() to help > annotate when firmware for device drivers crash. When firmware > crashes devices can sometimes become unresponsive, and recovery > sometimes requires a driver unload / r

Re: [PATCH v2 08/15] ehea: use new module_firmware_crashed()

2020-05-15 Thread Rafael Aquini
On Fri, May 15, 2020 at 09:28:39PM +, Luis Chamberlain wrote: > This makes use of the new module_firmware_crashed() to help > annotate when firmware for device drivers crash. When firmware > crashes devices can sometimes become unresponsive, and recovery > sometimes requires a driver unload / r

Re: [PATCH v2 06/15] liquidio: use new module_firmware_crashed()

2020-05-15 Thread Rafael Aquini
On Fri, May 15, 2020 at 09:28:37PM +, Luis Chamberlain wrote: > This makes use of the new module_firmware_crashed() to help > annotate when firmware for device drivers crash. When firmware > crashes devices can sometimes become unresponsive, and recovery > sometimes requires a driver unload / r

Re: [PATCH v2 05/15] bna: use new module_firmware_crashed()

2020-05-15 Thread Rafael Aquini
On Fri, May 15, 2020 at 09:28:36PM +, Luis Chamberlain wrote: > This makes use of the new module_firmware_crashed() to help > annotate when firmware for device drivers crash. When firmware > crashes devices can sometimes become unresponsive, and recovery > sometimes requires a driver unload / r

[PATCH bpf-next v2 3/5] samples: bpf: refactor tail call user progs with libbpf

2020-05-15 Thread Daniel T. Lee
BPF tail call uses the BPF_MAP_TYPE_PROG_ARRAY type map for calling into other BPF programs and this PROG_ARRAY should be filled prior to use. Currently, samples with the PROG_ARRAY type MAP fill this program array with bpf_load. For bpf_load to fill this map, kernel BPF program must specify the se

Re: [PATCH v2 04/15] bnxt: use new module_firmware_crashed()

2020-05-15 Thread Rafael Aquini
On Fri, May 15, 2020 at 09:28:35PM +, Luis Chamberlain wrote: > This makes use of the new module_firmware_crashed() to help > annotate when firmware for device drivers crash. When firmware > crashes devices can sometimes become unresponsive, and recovery > sometimes requires a driver unload / r

[PATCH bpf-next v2 4/5] samples: bpf: add tracex7 test file to .gitignore

2020-05-15 Thread Daniel T. Lee
This commit adds tracex7 test file (testfile.img) to .gitignore which comes from test_override_return.sh. Signed-off-by: Daniel T. Lee --- samples/bpf/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/samples/bpf/.gitignore b/samples/bpf/.gitignore index 23837f2ed458..034800c4d1e6 1

[PATCH bpf-next v2 5/5] samples: bpf: refactor kprobe, tail call kern progs map definition

2020-05-15 Thread Daniel T. Lee
Because the previous two commit replaced the bpf_load implementation of the user program with libbpf, the corresponding kernel program's MAP definition can be replaced with new BTF-defined map syntax. This commit only updates the samples which uses libbpf API for loading bpf program not with bpf_l

[PATCH bpf-next v2 2/5] samples: bpf: refactor kprobe tracing user progs with libbpf

2020-05-15 Thread Daniel T. Lee
Currently, the kprobe BPF program attachment method for bpf_load is quite old. The implementation of bpf_load "directly" controls and manages(create, delete) the kprobe events of DEBUGFS. On the other hand, using using the libbpf automatically manages the kprobe event. (under bpf_link interface) B

[PATCH bpf-next v2 1/5] samples: bpf: refactor pointer error check with libbpf

2020-05-15 Thread Daniel T. Lee
Current method of checking pointer error is not user friendly. Especially the __must_check define makes this less intuitive. Since, libbpf has an API libbpf_get_error() which checks pointer error, this commit refactors existing pointer error check logic with libbpf. Signed-off-by: Daniel T. Lee

Re: [PATCH v2 03/15] bnx2x: use new module_firmware_crashed()

2020-05-15 Thread Rafael Aquini
On Fri, May 15, 2020 at 09:28:34PM +, Luis Chamberlain wrote: > This makes use of the new module_firmware_crashed() to help > annotate when firmware for device drivers crash. When firmware > crashes devices can sometimes become unresponsive, and recovery > sometimes requires a driver unload / r

[PATCH bpf-next v2 0/5] samples: bpf: refactor kprobe tracing progs with libbpf

2020-05-15 Thread Daniel T. Lee
Currently, the kprobe BPF program attachment method for bpf_load is pretty outdated. The implementation of bpf_load "directly" controls and manages(create, delete) the kprobe events of DEBUGFS. On the other hand, using using the libbpf automatically manages the kprobe event. (under bpf_link interfa

Re: [PATCH v2 01/15] taint: add module firmware crash taint support

2020-05-15 Thread Rafael Aquini
On Fri, May 15, 2020 at 09:28:32PM +, Luis Chamberlain wrote: > Device driver firmware can crash, and sometimes, this can leave your > system in a state which makes the device or subsystem completely > useless. Detecting this by inspecting /proc/sys/kernel/tainted instead > of scraping some mag

Re: [PATCH v2 02/15] ethernet/839: use new module_firmware_crashed()

2020-05-15 Thread Rafael Aquini
On Fri, May 15, 2020 at 09:28:33PM +, Luis Chamberlain wrote: > This makes use of the new module_firmware_crashed() to help > annotate when firmware for device drivers crash. When firmware > crashes devices can sometimes become unresponsive, and recovery > sometimes requires a driver unload / r

Re: [PATCH V2] dynamic_debug: Add an option to enable dynamic debug for modules only

2020-05-15 Thread Orson Zhai
On Fri, May 15, 2020 at 5:55 PM Petr Mladek wrote: > > On Thu 2020-04-23 00:02:48, Orson Zhai wrote: > > On Wed, Apr 22, 2020 at 10:25 PM Leon Romanovsky wrote: > > > > > > On Wed, Apr 22, 2020 at 09:06:08PM +0800, Orson Zhai wrote: > > > > On Tue, Apr 21, 2020 at 3:10 AM Leon Romanovsky wrote:

[PATCH v2] net: revert "net: get rid of an signed integer overflow in ip_idents_reserve()"

2020-05-15 Thread Shaokun Zhang
From: Yuqi Jin Commit adb03115f459 ("net: get rid of an signed integer overflow in ip_idents_reserve()") used atomic_cmpxchg to replace "atomic_add_return" inside the function "ip_idents_reserve". The reason was to avoid UBSAN warning. However, this change has caused performance degrade and in G

Re: [PATCH 14/18] maccess: allow architectures to provide kernel probing directly

2020-05-15 Thread Masami Hiramatsu
Hi Christoph, On Wed, 13 May 2020 18:00:34 +0200 Christoph Hellwig wrote: > Provide alternative versions of probe_kernel_read, probe_kernel_write > and strncpy_from_kernel_unsafe that don't need set_fs magic, but instead > use arch hooks that are modelled after unsafe_{get,put}_user to access >

[PATCH net-next v1] hinic: add set_channels ethtool_ops support

2020-05-15 Thread Luo bin
add support to change TX/RX queue number with ethtool -L Signed-off-by: Luo bin --- .../net/ethernet/huawei/hinic/hinic_ethtool.c | 46 +++ .../net/ethernet/huawei/hinic/hinic_main.c| 2 +- drivers/net/ethernet/huawei/hinic/hinic_tx.c | 5 ++ 3 files changed, 44 insertions

Re: [PATCH net-next] hinic: add set_channels ethtool_ops support

2020-05-15 Thread luobin (L)
On 2020/5/16 2:13, Michal Kubecek wrote: On Fri, May 15, 2020 at 12:35:47AM +, Luo bin wrote: add support to change TX/RX queue number with ethtool -L Signed-off-by: Luo bin --- .../net/ethernet/huawei/hinic/hinic_ethtool.c | 67 +-- .../net/ethernet/huawei/hinic/hinic

Re: [PATCH net-next] net: phy: broadcom: fix checkpatch complains about tabs

2020-05-15 Thread Florian Fainelli
On 5/15/2020 7:09 PM, Kevin Lo wrote: > This patch makes checkpatch happy for tabs > > Signed-off-by: Kevin Lo Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next] net: phy: broadcom: add support for BCM54811 PHY

2020-05-15 Thread Kevin Lo
On Fri, May 15, 2020 at 02:31:42PM -0700, Jakub Kicinski wrote: > > On Sat, 16 May 2020 01:24:47 +0800 Kevin Lo wrote: > > The BCM54811 PHY shares many similarities with the already supported > > BCM54810 > > PHY but additionally requires some semi-unique configuration. > > > > Signed-off-by: Ke

[PATCH net-next] net: phy: broadcom: fix checkpatch complains about tabs

2020-05-15 Thread Kevin Lo
This patch makes checkpatch happy for tabs Signed-off-by: Kevin Lo --- diff --git a/drivers/net/phy/broadcom.c b/drivers/net/phy/broadcom.c index 8cd8d188542a..cd271de9609b 100644 --- a/drivers/net/phy/broadcom.c +++ b/drivers/net/phy/broadcom.c @@ -356,7 +356,7 @@ static int bcm54811_config_init

[ethtool RFC 1/3] uapi: Update headers from the kernel [DO NOT APPLY]

2020-05-15 Thread Vinicius Costa Gomes
Only helps for testing while the kernel side patches are not applied. Signed-off-by: Vinicius Costa Gomes --- uapi/linux/ethtool.h | 49 ++- uapi/linux/ethtool_netlink.h | 267 +++ 2 files changed, 315 insertions(+), 1 deletion(-) diff --git a/uapi/l

[ethtool RFC 3/3] ethtool: Add support for configuring frame preemption via netlink

2020-05-15 Thread Vinicius Costa Gomes
Adds the same functionality of the ETHTOOL_{G,S}FP commands, now via the ETHTOOL_MSG_PREEMPT_{GET,SET} netlink messages. Signed-off-by: Vinicius Costa Gomes --- Makefile.am| 2 +- ethtool.c | 2 + netlink/desc-ethtool.c | 13 netlink/extapi.h | 4 ++ ne

[ethtool RFC 2/3] ethtool: Add support for configuring frame preemption

2020-05-15 Thread Vinicius Costa Gomes
The configuration knobs that can be set are: - enabling/disabling frame preemption per-device; - setting the mask of preemptible queues; - configuring the minimum fragment size; The values that can be retrieved from the hardware are: - if frame preemption is supported; - if frame preempt

[ethtool RFC 0/3] ethtool: Add support for frame preemption

2020-05-15 Thread Vinicius Costa Gomes
Hi, This is the userspace side of the series proposing an interface via ethtool for configuring frame preemption, defined in IEEE 802.1Q-2018 (previously IEEE 802.1Qbu) and 802.3br. Patch 1 of this RFC is only to help testing, and should not be considered. Patch 2, adds support for the ETHTOOL_G

[next-queue RFC 2/4] ethtool: Add support for configuring frame preemption via netlink

2020-05-15 Thread Vinicius Costa Gomes
ethtool is gaining support for using netlink as transport for its messages, being an alternative to ioctl() calls. Frame preemption, being new, makes a good target for being added to the list of features that are also supported via the netlink transport. Signed-off-by: Vinicius Costa Gomes ---

[next-queue RFC 0/4] ethtool: Add support for frame preemption

2020-05-15 Thread Vinicius Costa Gomes
Hi, This series adds support for configuring frame preemption, as defined by IEEE 802.1Q-2018 (previously IEEE 802.1Qbu) and IEEE 802.3br. Frame preemption allows a packet from a higher priority queue marked as "express" to preempt a packet from lower priority queue marked as "preemptible". The i

[next-queue RFC 4/4] igc: Add support for exposing frame preemption stats registers

2020-05-15 Thread Vinicius Costa Gomes
[WIP] Signed-off-by: Vinicius Costa Gomes --- drivers/net/ethernet/intel/igc/igc_ethtool.c | 9 + drivers/net/ethernet/intel/igc/igc_regs.h| 10 ++ 2 files changed, 19 insertions(+) diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/

[next-queue RFC 1/4] ethtool: Add support for configuring frame preemption

2020-05-15 Thread Vinicius Costa Gomes
Frame preemption (described in IEEE 802.3br-2016) defines the concept of preemptible and express queues. It allows traffic from express queues to "interrupt" traffic from preemptible queues, which are "resumed" after the express traffic has finished transmitting. Frame preemption can only be used

[next-queue RFC 3/4] igc: Add support for configuring frame preemption

2020-05-15 Thread Vinicius Costa Gomes
WIP Signed-off-by: Vinicius Costa Gomes --- drivers/net/ethernet/intel/igc/igc.h | 3 + drivers/net/ethernet/intel/igc/igc_defines.h | 6 ++ drivers/net/ethernet/intel/igc/igc_ethtool.c | 68 drivers/net/ethernet/intel/igc/igc_tsn.c | 46 +++-- 4 files

Re: [bpf-next PATCH v2 00/12] bpf: selftests, test_sockmap improvements

2020-05-15 Thread Daniel Borkmann
On 5/13/20 9:12 PM, John Fastabend wrote: Note: requires fixes listed below to be merged into bpf-next before applied. Update test_sockmap to add ktls tests and in the process make output easier to understand and reduce overall runtime significantly. Before this series test_sockmap did a

[PATCH bpf-next] tools: bpftool: make capability check account for new BPF caps

2020-05-15 Thread Quentin Monnet
Following the introduction of CAP_BPF, and the switch from CAP_SYS_ADMIN to other capabilities for various BPF features, update the capability checks (and potentially, drops) in bpftool for feature probes. Because bpftool and/or the system might not know of CAP_BPF yet, some caution is necessary:

[PATCH 5.4 2/2] selftest/bpf: fix backported test_select_reuseport selftest changes

2020-05-15 Thread Andrii Nakryiko
Fix up RET_IF as CHECK macro to make selftests compile again. Fixes: b911c5e8686a ("selftests: bpf: Reset global state between reuseport test runs") Signed-off-by: Andrii Nakryiko --- tools/testing/selftests/bpf/test_select_reuseport.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH 5.4 1/2] libbpf: Extract and generalize CPU mask parsing logic

2020-05-15 Thread Andrii Nakryiko
commit 6803ee25f0ead1e836808acb14396bb9a9849113 upstream This logic is re-used for parsing a set of online CPUs. Having it as an isolated piece of code working with input string makes it conveninent to test this logic as well. While refactoring, also improve the robustness of original implementati

Re: [pull request][net-next 00/11] Mellanox, mlx5 misc updates 2020-05-15

2020-05-15 Thread David Miller
From: Saeed Mahameed Date: Fri, 15 May 2020 15:48:43 -0700 > This series provides misc updates to mlx5. > > For more information please see tag log below. > > Please pull and let me know if there is any problem. This all looks relatively straightforward, pulled.

Re: [PATCH] ethernet: ti: am65-cpts: Add missing inline qualifier to stub functions

2020-05-15 Thread David Miller
From: Nathan Chancellor Date: Fri, 15 May 2020 15:33:18 -0700 > When building with Clang: > > In file included from drivers/net/ethernet/ti/am65-cpsw-ethtool.c:15: > drivers/net/ethernet/ti/am65-cpts.h:58:12: warning: unused function > 'am65_cpts_ns_gettime' [-Wunused-function] > static s64 am65

Re: [PATCH v2 net-next 0/7] dpaa2-eth: add support for Rx traffic classes

2020-05-15 Thread David Miller
From: Jakub Kicinski Date: Fri, 15 May 2020 15:25:00 -0700 > With the Rx QoS features users won't even be able to tell via standard > Linux interfaces what the config was. +1

Re: [PATCH 0/3] Patch series for a PTP Grandmaster use case using stmmac/gmac3 ptp clock

2020-05-15 Thread Richard Cochran
On Fri, May 15, 2020 at 03:26:47PM +0200, Julien Beraud wrote: > So the question is what interface could we use to configure a timestamping > clock that has more than one functioning mode and which mode can be changed at > runtime, but not while timestamping is running ? Thanks for your detailed r

Re: [PATCH] security: fix the default value of secid_to_secctx hook

2020-05-15 Thread Alexei Starovoitov
On Thu, May 14, 2020 at 12:47 PM Alexei Starovoitov wrote: > > On Thu, May 14, 2020 at 12:43 PM James Morris > wrote: > > > > On Wed, 13 May 2020, Alexei Starovoitov wrote: > > > > > James, > > > > > > since you took the previous similar patch are you going to pick this > > > one up as well? > >

Re: [PATCH bpf-next 1/2] selftests/bpf: fix test_align

2020-05-15 Thread Daniel Borkmann
On 5/15/20 9:49 PM, Stanislav Fomichev wrote: Commit 294f2fc6da27 ("bpf: Verifer, adjust_scalar_min_max_vals to always call update_reg_bounds()") changed the way verifier logs some of its state, adjust the test_align accordingly. Where possible, I tried to not copy-paste the entire log line and r

Re: [PATCH v5 bpf-next 00/11] net: Add support for XDP in egress path

2020-05-15 Thread David Ahern
On 5/15/20 4:54 PM, John Fastabend wrote: > Hi David, > > Another way to set up egress programs that I had been thinking about is to > build a prog_array map with a slot per interface then after doing the > redirect (or I guess the tail call program can do the redirect) do the > tail call into the

Re: [PATCH v2 0/7] Copy hashmap to tools/perf/util, use in perf expr

2020-05-15 Thread Daniel Borkmann
On 5/15/20 11:18 PM, arnaldo.m...@gmail.com wrote: [...] Andrii/Alexei/Daniel, what do you think about me merging these fixes in my perf-tools-next branch? I'm ok with the idea, but it's up to maintainers to coordinate this :) Good to know, do I'll take all patches except the ones touching

Re: [PATCH v2 net-next 3/7] dpaa2-eth: Distribute ingress frames based on VLAN prio

2020-05-15 Thread kbuild test robot
Hi Ioana, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] [also build test WARNING on sparc-next/master linus/master v5.7-rc5 next-20200515] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we

[PATCH v2] net/mlx5e: Use IS_ERR() to check and simplify code

2020-05-15 Thread Tang Bin
Use IS_ERR() and PTR_ERR() instead of PTR_ERR_OR_ZERO() to simplify code, avoid redundant judgements. Signed-off-by: Zhang Shengju Signed-off-by: Tang Bin Reviewed-by: Leon Romanovsky --- Changes from v1 - fix the commit message for typo. --- drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.

Re: [PATCH v5 bpf-next 00/11] net: Add support for XDP in egress path

2020-05-15 Thread John Fastabend
David Ahern wrote: > On 5/13/20 4:43 AM, Toke Høiland-Jørgensen wrote: > > I don't like this. I makes the egress hook asymmetrical with the ingress > > hook (ingress hook sees all traffic, egress only some of it). If the > > performance hit of disabling GSO is the concern, maybe it's better to > >

Re: [PATCH] net/mlx5e: Use IS_ERR() to check and simplify code

2020-05-15 Thread Tang Bin
Hi Saeed: On 2020/5/16 6:28, Saeed Mahameed wrote: On Wed, 2020-05-13 at 17:48 +0800, Tang Bin wrote: Hi David: On 2020/5/8 4:18, David Miller wrote: From: Tang Bin Date: Thu, 7 May 2020 19:50:10 +0800 Use IS_ERR() and PTR_ERR() instead of PTR_ZRR_OR_ZERO()

[net-next 02/11] net/mlx5: Fix a bug of releasing wrong chunks on > 4K page size systems

2020-05-15 Thread Saeed Mahameed
From: Eran Ben Elisha On systems with page size larger than 4K, a fwp object has few 4K chunks. Fix a bug in fwp free flow where the chunk address was dropped and fwp->addr was used instead (first chunk address). This caused a wrong update of fwp->bitmask which later can cause errors in re-alloc

[net-next 10/11] net/mlx5e: Calculate SQ stop room in a robust way

2020-05-15 Thread Saeed Mahameed
From: Maxim Mikityanskiy Currently, different formulas are used to estimate the space that may be taken by WQEs in the SQ during a single packet transmit. This space is called stop room, and it's checked in the end of packet transmit to find out if the next packet could overflow the SQ. If it cou

[net-next 05/11] net/mlx5: Wait for inactive autogroups

2020-05-15 Thread Saeed Mahameed
From: Paul Blakey Currently, if one thread tries to add an entry to an autogrouped table with no free matching group, while another thread is in the process of creating a new matching autogroup, it doesn't wait for the new group creation, and creates an unnecessary new autogroup. Instead of skip

[net-next 04/11] net/mlx5: Drain wq first during PCI device removal

2020-05-15 Thread Saeed Mahameed
From: Parav Pandit mlx5_unload_one() is done with cleanup = true only once. So instead of doing health wq drain inside the if(), directly do during PCI device removal. Signed-off-by: Parav Pandit Reviewed-by: Moshe Shemesh Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5

[net-next 07/11] net/mlx5e: CT: Fix offload with CT action after CT NAT action

2020-05-15 Thread Saeed Mahameed
From: Roi Dayan It could be a chain of rules will do action CT again after CT NAT Before this fix matching will break as we get into the CT table after NAT changes and not CT NAT. Fix this by adding pre ct and pre ct nat tables to skip ct/ct_nat tables and go straight to post_ct table if ct/nat w

[net-next 09/11] net/mlx5e: IPoIB, Drop multicast packets that this interface sent

2020-05-15 Thread Saeed Mahameed
From: Erez Shitrit After enabled loopback packets for IPoIB, we need to drop these packets that this HCA has replicated and came back to the same interface that sent them. Fixes: 4c6c615e3f30 ("net/mlx5e: IPoIB, Add PKEY child interface nic profile") Signed-off-by: Erez Shitrit Reviewed-by: Ale

[net-next 08/11] net/mlx5e: IPoIB, Enable loopback packets for IPoIB interfaces

2020-05-15 Thread Saeed Mahameed
From: Erez Shitrit Enable loopback of unicast and multicast traffic for IPoIB enhanced mode. This will allow interfaces with the same pkey to communicate between them e.g cloned interfaces that located in different namespaces. Signed-off-by: Erez Shitrit Reviewed-by: Alex Vesker Signed-off-by:

[net-next 11/11] net/mlx5e: Take DCBNL-related definitions into dedicated files

2020-05-15 Thread Saeed Mahameed
From: Tariq Toukan Take DCBNL-related definitions out of the common en.h header, Use a dedicated header file for exposing them. Some need not to be exposed, use them locally in the .c file. Use stubs to eliminate use of CONFIG_MLX5_CORE_EN_DCB in the generic control flows. Signed-off-by: Tariq T

[net-next 06/11] net/mlx5: Move internal timer read function to clock library

2020-05-15 Thread Saeed Mahameed
From: Eran Ben Elisha Move mlx5_read_internal_timer() into lib/clock.c file as it is being used there. As such, make this function a static one. In addition, rearrange headers include to support function move. Signed-off-by: Eran Ben Elisha Reviewed-by: Aya Levin Signed-off-by: Saeed Mahameed

[net-next 03/11] net/mlx5: Have single error unwinding path

2020-05-15 Thread Saeed Mahameed
From: Parav Pandit Having multiple error unwinding path are error prone. Lets have just one error unwinding path. Signed-off-by: Parav Pandit Reviewed-by: Moshe Shemesh Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/main.c | 7 +++ 1 file changed, 3 insertions(

[net-next 01/11] net/mlx5: Dedicate fw page to the requesting function

2020-05-15 Thread Saeed Mahameed
From: Eran Ben Elisha The cited patch assumes that all chuncks in a fw page belong to the same function, thus the driver must dedicate fw page to the requesting function, which is actually what was intedned in the original fw pages allocator design, hence the fwp->func_id ! Up until the cited pa

[pull request][net-next 00/11] Mellanox, mlx5 misc updates 2020-05-15

2020-05-15 Thread Saeed Mahameed
Hi Dave, This series provides misc updates to mlx5. For more information please see tag log below. Please pull and let me know if there is any problem. Thanks, Saeed. --- The following changes since commit da07f52d3caf6c24c6dbffb5500f379d819e04bd: Merge git://git.kernel.org/pub/scm/linux/ke

Re: [PATCH v2 7/7] perf expr: Migrate expr ids table to a hashmap

2020-05-15 Thread Jiri Olsa
On Fri, May 15, 2020 at 02:35:43PM -0700, Ian Rogers wrote: > On Fri, May 15, 2020 at 12:41 PM Jiri Olsa wrote: > > > > On Fri, May 15, 2020 at 09:50:07AM -0700, Ian Rogers wrote: > > > > SNIP > > > > > diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c > > > index b071df37

Re: [PATCH v2 7/7] perf expr: Migrate expr ids table to a hashmap

2020-05-15 Thread Jiri Olsa
On Fri, May 15, 2020 at 09:50:07AM -0700, Ian Rogers wrote: SNIP > diff --git a/tools/perf/util/expr.c b/tools/perf/util/expr.c > index 8b4ce704a68d..f64ab91c432b 100644 > --- a/tools/perf/util/expr.c > +++ b/tools/perf/util/expr.c > @@ -4,25 +4,76 @@ > #include "expr.h" > #include "expr-bison.

[PATCH] ethernet: ti: am65-cpts: Add missing inline qualifier to stub functions

2020-05-15 Thread Nathan Chancellor
When building with Clang: In file included from drivers/net/ethernet/ti/am65-cpsw-ethtool.c:15: drivers/net/ethernet/ti/am65-cpts.h:58:12: warning: unused function 'am65_cpts_ns_gettime' [-Wunused-function] static s64 am65_cpts_ns_gettime(struct am65_cpts *cpts) ^ drivers/net/ethernet/t

Re: [PATCH] net/mlx5e: Use IS_ERR() to check and simplify code

2020-05-15 Thread Saeed Mahameed
On Wed, 2020-05-13 at 17:48 +0800, Tang Bin wrote: > Hi David: > > On 2020/5/8 4:18, David Miller wrote: > > From: Tang Bin > > Date: Thu, 7 May 2020 19:50:10 +0800 > > > > > Use IS_ERR() and PTR_ERR() instead of PTR_ZRR_OR_ZERO() ^^^ typo > > > t

Re: [PATCH net-next 1/3] ethtool: check if there is at least one channel for TX/RX in the core

2020-05-15 Thread Jakub Kicinski
On Fri, 15 May 2020 22:56:56 +0200 Michal Kubecek wrote: > On Fri, May 15, 2020 at 12:49:00PM -0700, Jakub Kicinski wrote: > > Having a channel config with no ability to RX or TX traffic is > > clearly wrong. Check for this in the core so the drivers don't > > have to. > > > > Signed-off-by: Jakub

Re: [PATCH v2 net-next 0/7] dpaa2-eth: add support for Rx traffic classes

2020-05-15 Thread Jakub Kicinski
On Fri, 15 May 2020 20:48:27 + Ioana Ciornei wrote: > > > There is no input taken from the user at the moment. The traffic class > > > id is statically selected based on the VLAN PCP field. The > > > configuration for this is added in patch 3/7. > > > > Having some defaults for RX queue per

[PATCH mlx5-next 1/3] net/mlx5: Cleanup mlx5_ifc_fte_match_set_misc2_bits

2020-05-15 Thread Saeed Mahameed
From: Raed Salem Remove the "metadata_reg_b" field and all uses of this field in code to match the device specification. As this field is not in use in SW steering it is safe to remove it. Signed-off-by: Raed Salem Reviewed-by: Alex Vesker Signed-off-by: Saeed Mahameed --- drivers/net/ethern

[PATCH mlx5-next 0/3] Mellanox, updates for mlx5 next 15-05-2020

2020-05-15 Thread Saeed Mahameed
Hi, This patchset is for mlx5-next branch with misc updates to mlx5 core driver. 1) Header modify support for RDMA TX Flow table 2) Two small cleanups. Thanks, Saeed. --- Michael Guralnik (1): net/mlx5: Add support for RDMA TX FT headers modifying Parav Pandit (1): net/mlx5: Move iseg acc

[PATCH mlx5-next 3/3] net/mlx5: Add support for RDMA TX FT headers modifying

2020-05-15 Thread Saeed Mahameed
From: Michael Guralnik Support adding header modifying actions to the RDMA TX flow table. Signed-off-by: Michael Guralnik Reviewed-by: Mark Bloch Reviewed-by: Maor Gottlieb Signed-off-by: Saeed Mahameed --- drivers/infiniband/hw/mlx5/flow.c| 5 - drivers/net/ethernet/mel

[PATCH mlx5-next 2/3] net/mlx5: Move iseg access helper routines close to mlx5_core driver

2020-05-15 Thread Saeed Mahameed
From: Parav Pandit Only mlx5_core driver handles fw initialization check and command interface revision check. Hence move them inside the mlx5_core driver where it is used. This avoid exposing these helpers to all mlx5 drivers. Signed-off-by: Parav Pandit Signed-off-by: Saeed Mahameed --- dri

[bpf-next PATCH v2 5/5] bpf: selftests, test probe_* helpers from SCHED_CLS

2020-05-15 Thread John Fastabend
Lets test using probe* in SCHED_CLS network programs as well just to be sure these keep working. Its cheap to add the extra test and provides a second context to test outside of sk_msg after we generalized probe* helpers to all networking types. Signed-off-by: John Fastabend --- .../testing/self

[bpf-next PATCH v2 1/5] bpf: sk_msg add some generic helpers that may be useful from sk_msg

2020-05-15 Thread John Fastabend
Add these generic helpers that may be useful to use from sk_msg programs. The helpers do not depend on ctx so we can simply add them here, BPF_FUNC_perf_event_output BPF_FUNC_get_current_uid_gid BPF_FUNC_get_current_pid_tgid BPF_FUNC_get_current_comm BPF_FUNC_get_current_cgroup_id BPF_FUNC_g

[bpf-next PATCH v2 2/5] bpf: extend bpf_base_func_proto helpers with probe_* and *current_task*

2020-05-15 Thread John Fastabend
Often it is useful when applying policy to know something about the task. If the administrator has CAP_SYS_ADMIN rights then they can use kprobe + networking hook and link the two programs together to accomplish this. However, this is a bit clunky and also means we have to call both the network pro

[bpf-next PATCH v2 3/5] bpf: sk_msg add get socket storage helpers

2020-05-15 Thread John Fastabend
Add helpers to use local socket storage. Signed-off-by: John Fastabend --- include/uapi/linux/bpf.h |2 ++ net/core/filter.c| 15 +++ 2 files changed, 17 insertions(+) diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h index b9b8a0f..d394b09 100644 --- a/

[bpf-next PATCH v2 4/5] bpf: selftests, add sk_msg helpers load and attach test

2020-05-15 Thread John Fastabend
The test itself is not particularly useful but it encodes a common pattern we have. Namely do a sk storage lookup then depending on data here decide if we need to do more work or alternatively allow packet to PASS. Then if we need to do more work consult task_struct for more information about the

[bpf-next PATCH v2 0/5] bpf: Add sk_msg and networking helpers

2020-05-15 Thread John Fastabend
This series adds helpers for sk_msg program type and based on feedback from v1 adds *_task_* helpers and probe_* helpers to all networking programs with perfmon_capable() capabilities. The list of helpers breaks down as follows, Networking with perfmon_capable() guard (patch2): BPF_FUNC_get_cur

Re: [RFC v2] current devlink extension plan for NICs

2020-05-15 Thread Jacob Keller
On 5/15/2020 2:30 AM, Jiri Pirko wrote: > Fri, May 15, 2020 at 01:52:54AM CEST, jacob.e.kel...@intel.com wrote: >>> $ devlink port add pci/.06.00.0/100 flavour pcisf pfnum 1 sfnum 10 >>> >> >> Can you clarify what sfnum means here? and why is it different from the >> index? I get that the in

Re: [PATCH net-next] net: phy: broadcom: add support for BCM54811 PHY

2020-05-15 Thread Jakub Kicinski
On Sat, 16 May 2020 01:24:47 +0800 Kevin Lo wrote: > The BCM54811 PHY shares many similarities with the already supported BCM54810 > PHY but additionally requires some semi-unique configuration. > > Signed-off-by: Kevin Lo > Reviewed-by: Florian Fainelli Checkpatch complains about using spaces

[PATCH v2 02/15] ethernet/839: use new module_firmware_crashed()

2020-05-15 Thread Luis Chamberlain
This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to an

[PATCH v2 01/15] taint: add module firmware crash taint support

2020-05-15 Thread Luis Chamberlain
Device driver firmware can crash, and sometimes, this can leave your system in a state which makes the device or subsystem completely useless. Detecting this by inspecting /proc/sys/kernel/tainted instead of scraping some magical words from the kernel log, which is driver specific, is much easier.

[PATCH v2 14/15] brcm80211: use new module_firmware_crashed()

2020-05-15 Thread Luis Chamberlain
This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to an

[PATCH v2 03/15] bnx2x: use new module_firmware_crashed()

2020-05-15 Thread Luis Chamberlain
This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to an

[PATCH v2 09/15] qed: use new module_firmware_crashed()

2020-05-15 Thread Luis Chamberlain
This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to an

[PATCH v2 12/15] ath10k: use new module_firmware_crashed()

2020-05-15 Thread Luis Chamberlain
This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to an

[PATCH v2 05/15] bna: use new module_firmware_crashed()

2020-05-15 Thread Luis Chamberlain
This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to an

[PATCH v2 04/15] bnxt: use new module_firmware_crashed()

2020-05-15 Thread Luis Chamberlain
This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to an

[PATCH v2 07/15] cxgb4: use new module_firmware_crashed()

2020-05-15 Thread Luis Chamberlain
This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to an

[PATCH v2 11/15] wimax/i2400m: use new module_firmware_crashed()

2020-05-15 Thread Luis Chamberlain
This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to an

[PATCH v2 08/15] ehea: use new module_firmware_crashed()

2020-05-15 Thread Luis Chamberlain
This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to an

[PATCH v2 10/15] soc: qcom: ipa: use new module_firmware_crashed()

2020-05-15 Thread Luis Chamberlain
This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to an

[PATCH v2 13/15] ath6kl: use new module_firmware_crashed()

2020-05-15 Thread Luis Chamberlain
This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to an

[PATCH v2 15/15] mwl8k: use new module_firmware_crashed()

2020-05-15 Thread Luis Chamberlain
This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to an

  1   2   3   4   >