Re: [PATCH v2 10/15] soc: qcom: ipa: use new module_firmware_crashed()

[Rafael Aquini]

On Fri, May 15, 2020 at 09:28:41PM +0000, Luis Chamberlain wrote:
> This makes use of the new module_firmware_crashed() to help
> annotate when firmware for device drivers crash. When firmware
> crashes devices can sometimes become unresponsive, and recovery
> sometimes requires a driver unload / reload and in the worst cases
> a reboot.
> 
> Using a taint flag allows us to annotate when this happens clearly.
> 
> Cc: Alex Elder <el...@kernel.org>
> Signed-off-by: Luis Chamberlain <mcg...@kernel.org>
> ---
>  drivers/net/ipa/ipa_modem.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ipa/ipa_modem.c b/drivers/net/ipa/ipa_modem.c
> index ed10818dd99f..1790b87446ed 100644
> --- a/drivers/net/ipa/ipa_modem.c
> +++ b/drivers/net/ipa/ipa_modem.c
> @@ -285,6 +285,7 @@ static void ipa_modem_crashed(struct ipa *ipa)
>       struct device *dev = &ipa->pdev->dev;
>       int ret;
>  
> +     module_firmware_crashed();
>       ipa_endpoint_modem_pause_all(ipa, true);
>  
>       ipa_endpoint_modem_hol_block_clear_all(ipa);
> -- 
> 2.26.2
> 
Acked-by: Rafael Aquini <aqu...@redhat.com>