On 5/8/2020 2:11 PM, Jesper Dangaard Brouer wrote:
The mlx5 driver have multiple memory models, which are also changed
according to whether a XDP bpf_prog is attached.
The 'rx_striding_rq' setting is adjusted via ethtool priv-flags e.g.:
# ethtool --set-priv-flags mlx5p2 rx_striding_rq off
Hi Michael,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net-next/master]
[also build test ERROR on next-20200508]
[cannot apply to net/master linus/master ipvs/master v5.7-rc4]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve
> Is there a way to add a Fixes tag that would not invoke the -stable
> process? And was that what you had in mind?
Christophe Jaillet proposed to complete the exception handling also for this
function implementation.
I find that such a software correction is qualified for this tag.
https://git.ke
On 5/9/20 5:50 PM, Alexei Starovoitov wrote:
On Sat, May 09, 2020 at 10:59:12AM -0700, Yonghong Song wrote:
diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c
index a2cfba89a8e1..c490fbde22d4 100644
--- a/kernel/bpf/btf.c
+++ b/kernel/bpf/btf.c
@@ -3790,7 +3790,10 @@ bool btf_ctx_access(int off
> Ido's response gave introductory commands which can also be found here:
> https://www.kernel.org/doc/Documentation/networking/vrf.txt
>
> This should answer most questions about more advanced topics:
> http://schd.ws/hosted_files/ossna2017/fe/vrf-tutorial-oss.pdf
>
> Lately, I am putting
On 5/9/20 5:41 PM, Alexei Starovoitov wrote:
On Sat, May 09, 2020 at 10:59:00AM -0700, Yonghong Song wrote:
diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
index 70ad009577f8..d725ff7d11db 100644
--- a/kernel/bpf/verifier.c
+++ b/kernel/bpf/verifier.c
@@ -7101,6 +7101,10 @@ static
On 5/9/20 5:35 PM, Alexei Starovoitov wrote:
On Sat, May 09, 2020 at 10:59:17AM -0700, Yonghong Song wrote:
@@ -6891,6 +6897,7 @@ static int bpf_object__collect_st_ops_relos(struct
bpf_object *obj,
#define BTF_TRACE_PREFIX "btf_trace_"
#define BTF_LSM_PREFIX "bpf_lsm_"
+#define BTF_I
On 5/9/20 5:34 PM, Alexei Starovoitov wrote:
On Sat, May 09, 2020 at 10:59:23AM -0700, Yonghong Song wrote:
+static volatile const __u32 ret1;
+
+SEC("iter/bpf_map")
+int dump_bpf_map(struct bpf_iter__bpf_map *ctx)
+{
+ struct seq_file *seq = ctx->meta->seq;
+ struct bpf_map *map
On 5/9/20 5:30 PM, Alexei Starovoitov wrote:
On Sat, May 09, 2020 at 10:59:04AM -0700, Yonghong Song wrote:
+
+ err = seq->op->show(seq, p);
+ if (err > 0) {
+ seq->count = offs;
as far as I can see this condition can never happen.
I underst
On 5/9/20 5:27 PM, Alexei Starovoitov wrote:
On Sat, May 09, 2020 at 10:58:59AM -0700, Yonghong Song wrote:
Changelog:
v3 -> v4:
- in bpf_seq_read(), if start() failed with an error, return that
error to user space (Andrii)
- in bpf_seq_printf(), if reading kernel memory
--
Dear Friend
Can you assist to handle this transaction? More details will sent to
you as soon as i receive your response.1. Full name:.
2. Current Address:..
3. Telephone N°:..
4. Occupation:..
5. Age:.
6. Country:
Bes
On Sat, 9 May 2020 18:43:10 +0800 Kevin Hao wrote:
> In the current codes, the octeontx2 uses its own method to allocate
> the pool buffers, but there are some issues in this implementation.
> 1. We have to run the otx2_get_page() for each allocation cycle and
>this is pretty error prone. As I
On Fri, 8 May 2020 22:58:29 -0700 Jakub Kicinski wrote:
> On Sat, 9 May 2020 11:32:10 +0800 Zefan Li wrote:
> > If systemd is configured to use hybrid mode which enables the use of
> > both cgroup v1 and v2, systemd will create new cgroup on both the default
> > root (v2) and netprio_cgroup hierarc
On Sat, 9 May 2020 23:43:08 + Saeed Mahameed wrote:
> > Saeed, I'm expecting you to take this and the mlx4 patch via your
> > trees.
>
> Yes for the mlx5 patch, but usually Dave takes mlx4 patches directly.
Ack, it said IB on it, but looks like the patch can as well be applied
to net-next,
On Thu, 7 May 2020 13:59:21 -0500 Gustavo A. R. Silva wrote:
> The current codebase makes use of the zero-length array language
> extension to the C90 standard, but the preferred mechanism to declare
> variable-length types such as these ones is a flexible array member[1][2],
> introduced in C99:
>
On Thu, 2020-05-07 at 13:59 -0500, Gustavo A. R. Silva wrote:
> The current codebase makes use of the zero-length array language
> extension to the C90 standard, but the preferred mechanism to declare
> variable-length types such as these ones is a flexible array
> member[1][2],
> introduced in C99
Hi Michael,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net-next/master]
[also build test ERROR on next-20200508]
[cannot apply to net/master linus/master ipvs/master v5.7-rc4]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve
On Sat, 9 May 2020 21:05:48 +0200, Stephen Kitt wrote:
> On Sat, 9 May 2020 10:59:14 -0700, Jakub Kicinski wrote:
> > What if we went back to your original proposal of an empty struct but
> > added in an extern in front? That way we should get linker error on
> > pointer references.
>
> That s
On 5/9/20 9:46 AM, Luis Chamberlain wrote:
> On Sat, May 09, 2020 at 11:18:29AM -0400, Rafael Aquini wrote:
>> We are still missing the documentation bits for this
>> new flag, though.
>
> Ah yeah sorry about that.
>
>> How about having a blurb similar to:
>>
>> diff --git a/Documentation/admin-g
On 5/9/20 6:58 PM, Andrew Lunn wrote:
On Sat, May 09, 2020 at 06:01:51PM -0700, Shannon Nelson wrote:
On 5/8/20 9:35 PM, Luis Chamberlain wrote:
Device driver firmware can crash, and sometimes, this can leave your
system in a state which makes the device or subsystem completely
useless. Detecti
On Sat, May 09, 2020 at 06:01:51PM -0700, Shannon Nelson wrote:
> On 5/8/20 9:35 PM, Luis Chamberlain wrote:
> > Device driver firmware can crash, and sometimes, this can leave your
> > system in a state which makes the device or subsystem completely
> > useless. Detecting this by inspecting /proc/
On 5/9/20 3:35 PM, Maciej Żenczykowski wrote:
> Do we have some sort of beginner's introduction to Linux VRF somewhere?
> What they are? How to use them?
Ido's response gave introductory commands which can also be found here:
https://www.kernel.org/doc/Documentation/networking/vrf.txt
This sh
On Sat, May 9, 2020 at 12:40 AM Masahiro Yamada wrote:
>
> On Fedora, linking static libraries requires the glibc-static RPM
> package, which is not part of the glibc-devel package.
>
> CONFIG_CC_CAN_LINK does not check the capability of static linking,
> so you can enable CONFIG_BPFILTER_UMH, the
On Mon, May 4, 2020 at 10:45 AM Song Liu wrote:
>
>
>
> > On May 2, 2020, at 1:00 PM, Alexei Starovoitov
> > wrote:
> >
> > On Thu, Apr 30, 2020 at 12:15 AM Song Liu wrote:
> >>
> >> bpf_enable_stats() is added to enable given stats.
> >>
> >> Signed-off-by: Song Liu
> > ...
> >> diff --git a/
On 5/8/20 9:35 PM, Luis Chamberlain wrote:
Device driver firmware can crash, and sometimes, this can leave your
system in a state which makes the device or subsystem completely
useless. Detecting this by inspecting /proc/sys/kernel/tainted instead
of scraping some magical words from the kernel lo
On Sat, May 09, 2020 at 10:59:12AM -0700, Yonghong Song wrote:
> diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c
> index a2cfba89a8e1..c490fbde22d4 100644
> --- a/kernel/bpf/btf.c
> +++ b/kernel/bpf/btf.c
> @@ -3790,7 +3790,10 @@ bool btf_ctx_access(int off, int size, enum
> bpf_access_type type,
On Sat, May 09, 2020 at 10:59:00AM -0700, Yonghong Song wrote:
> diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
> index 70ad009577f8..d725ff7d11db 100644
> --- a/kernel/bpf/verifier.c
> +++ b/kernel/bpf/verifier.c
> @@ -7101,6 +7101,10 @@ static int check_return_code(struct bpf_verifier
On Sat, May 09, 2020 at 10:59:17AM -0700, Yonghong Song wrote:
> @@ -6891,6 +6897,7 @@ static int bpf_object__collect_st_ops_relos(struct
> bpf_object *obj,
>
> #define BTF_TRACE_PREFIX "btf_trace_"
> #define BTF_LSM_PREFIX "bpf_lsm_"
> +#define BTF_ITER_PREFIX "__bpf_iter__"
> #define BTF_MA
On Sat, May 09, 2020 at 10:59:23AM -0700, Yonghong Song wrote:
> +static volatile const __u32 ret1;
> +
> +SEC("iter/bpf_map")
> +int dump_bpf_map(struct bpf_iter__bpf_map *ctx)
> +{
> + struct seq_file *seq = ctx->meta->seq;
> + struct bpf_map *map = ctx->map;
> + __u64 seq_num;
> +
On Sat, May 09, 2020 at 10:59:04AM -0700, Yonghong Song wrote:
> +
> + err = seq->op->show(seq, p);
> + if (err > 0) {
> + seq->count = offs;
as far as I can see this condition can never happen.
I understand that seq_read() has this logic, but four itera
On Sat, May 09, 2020 at 10:58:59AM -0700, Yonghong Song wrote:
>
> Changelog:
> v3 -> v4:
> - in bpf_seq_read(), if start() failed with an error, return that
> error to user space (Andrii)
> - in bpf_seq_printf(), if reading kernel memory failed for
> %s and %p{i,I}{4,6}, set
On 5/9/2020 3:37 PM, Michael Walle wrote:
> Most modern broadcom PHYs support ECD (enhanced cable diagnostics). Add
> support for it in the bcm-phy-lib so they can easily be used in the PHY
> driver.
>
> There are two access methods for ECD: legacy by expansion registers and
> via the new RDB r
On 5/9/2020 3:37 PM, Michael Walle wrote:
> Use the generic cable tester functions from bcm-phy-lib to add cable
> tester support.
>
> 100m cable, A/B/C/D open:
> Cable test started for device eth0.
> Cable test completed for device eth0.
> Pair: Pair A, result: Open Circuit
> Pair: Pai
Hi Michael,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net-next/master]
[also build test ERROR on next-20200508]
[cannot apply to net/master linus/master v5.7-rc4]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system.
On Sat, 9 May 2020 10:59:14 -0700, Jakub Kicinski wrote:
> On Sat, 9 May 2020 10:13:22 +0200 Stephen Kitt wrote:
> > On Fri, 8 May 2020 20:50:25 -0700, Jakub Kicinski
> > wrote:
> > > On Fri, 8 May 2020 14:04:57 +0200 Stephen Kitt wrote:
> > > > Commit c7228317441f ("net: Use a more standa
On Fri, 8 May 2020, Jakub Kicinski wrote:
> On Fri, 8 May 2020 19:25:57 +0200 Christophe JAILLET wrote:
> > @@ -527,8 +531,9 @@ static int mac_sonic_platform_remove(struct
> > platform_device *pdev)
> > struct sonic_local* lp = netdev_priv(dev);
> >
> > unregister_netdev(dev);
> > -
On 5/9/2020 3:37 PM, Michael Walle wrote:
> Add the convenience function to do a read-modify-write. This has the
> additional benefit of saving one write to the selection register.
>
> Signed-off-by: Michael Walle
Reviewed-by: Florian Fainelli
--
Florian
On 5/9/2020 3:37 PM, Michael Walle wrote:
> Add helper to read and write expansion registers without taking the mdio
> lock.
>
> Please note, that this changes the semantics of the read and write.
> Before there was no lock between selecting the expansion register and
> the actual read/write. T
There is a soft dependency against dsa_loop_bdinfo.ko which sets up the
MDIO device registration, since there are no symbols referenced by
dsa_loop.ko, there is no automatic loading of dsa_loop_bdinfo.ko which
is needed.
Fixes: 98cd1552ea27 ("net: dsa: Mock-up driver")
Signed-off-by: Florian Faine
On Sat, 9 May 2020, Markus Elfring wrote:
> > While at it, rename a label in order to be slightly more informative and
> > split some too long lines.
>
> Would you like to add the tag 'Fixes' to the change description?
>
Sorry but I don't follow your reasoning here. Are you saying that this
ne
On Fri, 2020-05-08 at 16:36 -0700, Jakub Kicinski wrote:
> On Thu, 7 May 2020 13:59:35 -0500 Gustavo A. R. Silva wrote:
> > The current codebase makes use of the zero-length array language
> > extension to the C90 standard, but the preferred mechanism to
> > declare
> > variable-length types such a
On Sat, 2020-05-09 at 16:32 -0700, David Miller wrote:
> From: Joe Perches
> Date: Sat, 09 May 2020 15:42:36 -0700
>
> > David, maybe I missed some notification about Jakub's role.
> >
> > What is Jakub's role in relation to the networking tree?
>
> He is the co-maintainer of the networking tre
From: Joe Perches
Date: Sat, 09 May 2020 15:42:36 -0700
> David, maybe I missed some notification about Jakub's role.
>
> What is Jakub's role in relation to the networking tree?
He is the co-maintainer of the networking tree and you should respect
his actions and feedback as if it were coming
On Sat, May 09, 2020 at 11:32:10AM +0800, Zefan Li wrote:
> If systemd is configured to use hybrid mode which enables the use of
> both cgroup v1 and v2, systemd will create new cgroup on both the default
> root (v2) and netprio_cgroup hierarchy (v1) for a new session and attach
> task to the two c
On Sat, 9 May 2020 23:06:01 +0300 Ido Schimmel wrote:
> From: Ido Schimmel
>
> Jiri says:
>
> There are some limitations for TC matchall classifier offload that are
> given by the mlxsw HW dataplane. It is not possible to do sampling on
> egress and also the mirror/sample vs. ACL (flower) order
On Sat, 9 May 2020 15:04:04 -0700 Florian Fainelli wrote:
> On 5/9/2020 2:48 PM, Arnd Bergmann wrote:
> > On Sat, May 9, 2020 at 10:24 PM Jakub Kicinski wrote:
> >>
> >> On Sat, 9 May 2020 14:04:52 +0200 Arnd Bergmann wrote:
> >>> I ran into a randconfig build failure with CONFIG_FIXED_PHY=m
On Sat, 2020-05-09 at 11:13 -0700, Jakub Kicinski wrote:
> On Sat, 9 May 2020 18:47:08 +0200 Christophe JAILLET wrote:
> > Le 09/05/2020 à 03:54, Jakub Kicinski a écrit :
> > > On Fri, 8 May 2020 19:25:57 +0200 Christophe JAILLET wrote:
> > > > @@ -527,8 +531,9 @@ static int mac_sonic_platform_r
On Sat, 9 May 2020 22:49:28 +0200 Stephen Kitt wrote:
> On Sat, 9 May 2020 21:05:48 +0200, Stephen Kitt wrote:
> > On Sat, 9 May 2020 10:59:14 -0700, Jakub Kicinski wrote:
> > > What if we went back to your original proposal of an empty struct but
> > > added in an extern in front? That way we
Add the convenience function to do a read-modify-write. This has the
additional benefit of saving one write to the selection register.
Signed-off-by: Michael Walle
---
drivers/net/phy/bcm-phy-lib.c | 32
drivers/net/phy/bcm-phy-lib.h | 2 ++
2 files changed, 34
Most modern broadcom PHYs support ECD (enhanced cable diagnostics). Add
support for it in the bcm-phy-lib so they can easily be used in the PHY
driver.
There are two access methods for ECD: legacy by expansion registers and
via the new RDB registers which are exclusive. Provide functions in two
va
Add cable tester support for the Broadcom PHYs. Support for it was
developed on a BCM54140 Quad PHY which RDB register access.
If there is a link partner the results are not as good as with an open
cable. I guess we could retry if the measurement until all pairs had at
least one valid result.
Ple
On Fri, 8 May 2020 20:19:33 + Luo bin wrote:
> if some function in ndo_stop interface returns failure because of
> hardware fault, must go on excuting rest steps rather than return
> failure directly, otherwise will cause memory leak.And bump the
> timeout for SET_FUNC_STATE to ensure that cmd
Add helper to read and write expansion registers without taking the mdio
lock.
Please note, that this changes the semantics of the read and write.
Before there was no lock between selecting the expansion register and
the actual read/write. This may lead to access failures if there are
parallel acc
Use the generic cable tester functions from bcm-phy-lib to add cable
tester support.
100m cable, A/B/C/D open:
Cable test started for device eth0.
Cable test completed for device eth0.
Pair: Pair A, result: Open Circuit
Pair: Pair B, result: Open Circuit
Pair: Pair C, result: Open Circui
On Fri, 8 May 2020 20:18:50 + Luo bin wrote:
> adds ndo_set_vf_rate/ndo_set_vf_spoofchk/ndo_set_vf_link_state
> to configure netdev of virtual function
>
> Signed-off-by: Luo bin
Applied, thank you. Please make sure you fix the time on your system,
this patch arrived with a date set few hour
On Sat, 9 May 2020 21:49:28 +0300 Johan Hedberg wrote:
> Hi Dave,
>
> Here's another set of Bluetooth patches for the 5.8 kernel:
>
> - Add support for Intel Typhoon Peak device (8087:0032)
> - Add device tree bindings for Realtek RTL8723BS device
> - Add device tree bindings for Qualcomm QCA9
The AR8031/AR8033 and the AR8035 support cable diagnostics. Adding
driver support is straightforward, so lets add it.
The PHY just do one pair at a time, so we have to start the test four
times. The cable_test_get_status() can block and therefore we can just
busy poll the test completion and conti
On Sat, 9 May 2020 01:28:43 -0700 Saeed Mahameed wrote:
> Hi Dave,
>
> This series includes updates to mlx5 driver and a merge commit to the
> earlier bonding series which was submitted by Maor to mlx5-next branch.
>
> For more information please see tag log below.
>
> Please pull and let me kn
On 5/9/2020 2:48 PM, Arnd Bergmann wrote:
> On Sat, May 9, 2020 at 10:24 PM Jakub Kicinski wrote:
>>
>> On Sat, 9 May 2020 14:04:52 +0200 Arnd Bergmann wrote:
>>> I ran into a randconfig build failure with CONFIG_FIXED_PHY=m
>>> and CONFIG_GIANFAR=y:
>>>
>>> x86_64-linux-ld: drivers/net/ethern
From: Colin Ian King
The variable status is being initializeed with a value that is never read
and it is being updated later with a new value. The initialization
is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King
---
drivers/net/usb/qmi_wwan.c |
On Sat, 9 May 2020 21:23:55 +0100 Russell King - ARM Linux admin wrote:
> I seem to have discovered the cause of the problem in the old thread,
> so I suggest we wait and see whether anyone offers up a proper
> solution to this regression before we rush to completely disable
> this feature.
>
> I
From: Colin Ian King
The variable status is being initializeed with a value that is never read
and it is being updated later with a new value. The initialization
is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King
---
drivers/net/usb/qmi_wwan.c |
On Sat, May 9, 2020 at 10:24 PM Jakub Kicinski wrote:
>
> On Sat, 9 May 2020 14:04:52 +0200 Arnd Bergmann wrote:
> > I ran into a randconfig build failure with CONFIG_FIXED_PHY=m
> > and CONFIG_GIANFAR=y:
> >
> > x86_64-linux-ld: drivers/net/ethernet/freescale/gianfar.o:(.rodata+0x418):
> > unde
From: Colin Ian King
The variable ret is being initializeed with a value that is never read
and it is being updated later with a new value. The initialization
is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King
---
drivers/net/usb/huawei_cdc_ncm.
From: Colin Ian King
The variable ret is being initializeed with a value that is never read
and it is being updated later with a new value. The initialization
is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King
---
drivers/net/usb/ax88179_178a.c
Do we have some sort of beginner's introduction to Linux VRF somewhere?
What they are? How to use them?
Currently the concept simply doesn't fit into my mental model of networking...
We've actually talked about maybe possibly using VRF's in Android (for
our multi network support)...
but no-one on
Also maybe the example should be:
instead of just:
-A INPUT ... -j REJECT
do:
-A INPUT ... -m conntrack --ctstate INVALID -j DROP
-A INPUT ... -j REJECT
I *think* that your talk of 3 packets is not needed, ie. the initial
delayed packet doesn't have to be a retransmission.
It can be the first copy of that segment that gets massively delayed
and arrives late and causes problems,
by virtue of arriving after the retransmission already caused the
conne
On 5/9/20 1:15 PM, Ido Schimmel wrote:
>
> This will unfortunately cause regressions with VRFs because they don't
> work correctly with ping sockets. Simple example:
Thanks for catching this, Ido.
>
> diff --git a/net/ipv4/ping.c b/net/ipv4/ping.c
> index 535427292194..8463b0e9e811 100644
> ---
On Sat, 9 May 2020 12:52:44 +0530 Amol Grover wrote:
> ipmr_for_each_table() uses list_for_each_entry_rcu() for
> traversing outside of an RCU read-side critical section but
> under the protection of pernet_ops_rwsem. Hence add the
> corresponding lockdep expression to silence the following
> fals
Signed-off-by: Jan Engelhardt
---
Maciej's explanation on how INVALID+REJECT can lead to problems looks
convincing. I hereby present new manpage wording in the form of "if A, then B"
to better build the argument of avoiding REJECT. So the issue is not caused by
an _incoming_ TCP RST as the initia
On 5/9/20 1:32 PM, Ido Schimmel wrote:
> On Sat, May 09, 2020 at 12:17:47PM -0700, Maciej Żenczykowski wrote:
>> Argh. I've never understood the faintest thing about VRF's.
>
> :)
>
> There are many resources that David created over the years. For example:
>
> https://www.kernel.org/doc/Documen
On Sat, 9 May 2020 17:27:39 +0800 Huazhong Tan wrote:
> This patch provides a new interface for the client to query
> whether CMDQ is ready to work.
>
> Signed-off-by: Huazhong Tan
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hnae3.h
> b/drivers/net/ethernet/hisilicon/hns3/hnae3.h
> index
Le 09/05/2020 à 20:13, Jakub Kicinski a écrit :
On Sat, 9 May 2020 18:47:08 +0200 Christophe JAILLET wrote:
Le 09/05/2020 à 03:54, Jakub Kicinski a écrit :
On Fri, 8 May 2020 19:25:57 +0200 Christophe JAILLET wrote:
@@ -527,8 +531,9 @@ static int mac_sonic_platform_remove(struct platform_devi
On Sat, 9 May 2020 14:04:52 +0200 Arnd Bergmann wrote:
> I ran into a randconfig build failure with CONFIG_FIXED_PHY=m
> and CONFIG_GIANFAR=y:
>
> x86_64-linux-ld: drivers/net/ethernet/freescale/gianfar.o:(.rodata+0x418):
> undefined reference to `fixed_phy_change_carrier'
>
> It seems the same
On Sat, May 09, 2020 at 04:15:46PM +0200, Matteo Croce wrote:
> Currently rxhash only works on the first port of the CP (Communication
> Processor). Enabling it on other ports completely blocks packet reception.
> This patch only adds rxhash as supported feature to the first port,
> so rxhash can't
On Sat, May 09, 2020 at 08:52:46PM +0100, Russell King - ARM Linux admin wrote:
> On Sat, May 09, 2020 at 03:14:05PM +0200, Matteo Croce wrote:
> > Hi,
> >
> > When git bisect pointed to 895586d5dc32 ("net: mvpp2: cls: Use RSS
> > contexts to handle RSS tables"), which was merged
> > almost an yea
From: Jiri Pirko
HW supports packet sampling on ingress only. Check and fail if user
is adding sample on egress.
Signed-off-by: Jiri Pirko
Signed-off-by: Ido Schimmel
---
drivers/net/ethernet/mellanox/mlxsw/spectrum_matchall.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/n
From: Jiri Pirko
Make sure that the drive restricts incorrect order of inserted matchall
vs. flower rules.
Signed-off-by: Jiri Pirko
Signed-off-by: Ido Schimmel
---
.../drivers/net/mlxsw/tc_restrictions.sh | 107 ++
1 file changed, 107 insertions(+)
diff --git a/tools/te
From: Ido Schimmel
Jiri says:
There are some limitations for TC matchall classifier offload that are
given by the mlxsw HW dataplane. It is not possible to do sampling on
egress and also the mirror/sample vs. ACL (flower) ordering is fixed. So
check this and forbid to offload incorrect setup.
J
From: Jiri Pirko
The file is about to contain matchall restrictions too, so change the
name to make it more generic.
Signed-off-by: Jiri Pirko
Signed-off-by: Ido Schimmel
---
.../net/mlxsw/{tc_flower_restrictions.sh => tc_restrictions.sh} | 0
1 file changed, 0 insertions(+), 0 deletions(-)
From: Jiri Pirko
On ingress, the matchall rules doing mirroring and sampling are offloaded
into hardware blocks that are processed before any flower rules.
On egress, the matchall mirroring rules are offloaded into hardware
block that is processed after all flower rules.
Therefore check the prio
From: Jiri Pirko
On ingress, the matchall rules doing mirroring and sampling are offloaded
into hardware blocks that are processed before any flower rules.
On egress, the matchall mirroring rules are offloaded into hardware
block that is processed after all flower rules.
Therefore check the prio
From: Jiri Pirko
Check that matchall rules with sample actions are not possible to be
inserted to egress.
Signed-off-by: Jiri Pirko
Signed-off-by: Ido Schimmel
---
.../drivers/net/mlxsw/tc_restrictions.sh | 25 +++
1 file changed, 25 insertions(+)
diff --git a/tools/test
From: Jiri Pirko
Introduce an infrastructure that allows to get minimum and maximum
rule priority for specified chain. This is going to be used by
a subsequent patch to enforce ordering between flower and
matchall filters.
Signed-off-by: Jiri Pirko
Signed-off-by: Ido Schimmel
---
.../net/ethe
From: Jiri Pirko
Introduce an infrastructure that allows to get minimum and maximum
rule priority for specified chain. This is going to be used by
a subsequent patch to enforce ordering between flower and
matchall filters.
Signed-off-by: Jiri Pirko
Signed-off-by: Ido Schimmel
---
.../net/ethe
From: Jiri Pirko
As there are going to be other matchall specific fields in flow
structure, put the existing list field into matchall substruct.
Signed-off-by: Jiri Pirko
Signed-off-by: Ido Schimmel
---
drivers/net/ethernet/mellanox/mlxsw/spectrum.h | 4 +++-
drivers/net/ethernet/mel
On Sat, May 09, 2020 at 03:14:05PM +0200, Matteo Croce wrote:
> Hi,
>
> When git bisect pointed to 895586d5dc32 ("net: mvpp2: cls: Use RSS
> contexts to handle RSS tables"), which was merged
> almost an year after d33ec4525007 ("net: mvpp2: add an RSS
> classification step for each flow"), so I as
On Sat, May 09, 2020 at 12:17:47PM -0700, Maciej Żenczykowski wrote:
> Argh. I've never understood the faintest thing about VRF's.
:)
There are many resources that David created over the years. For example:
https://www.kernel.org/doc/Documentation/networking/vrf.txt
https://netdevconf.info/1.1/
I don't think it's ever been broken per say since Android has it's own
copy of everything,
and there are local changes to iptables (that I'm trying to
cleanup/drop/upstream),
so we've carried this patch for years.
On Tue, Apr 28, 2020 at 3:30 PM Pablo Neira Ayuso wrote:
>
> On Mon, Apr 27, 2020 a
> > - mdiobb_cmd(ctrl, MDIO_WRITE, phy, reg);
> > + mdiobb_cmd(ctrl, ctrl->op_c22_write, phy, reg);
>
> There are other users of the mdio-bitbang.c file which I believe you are
> going to break here because they will not initialize op_c22_write or
> op_c22_read, and thus they w
From: Maciej Żenczykowski
This is present in bionic header files regardless of compiler
being used (likely clang)
Test: builds
Signed-off-by: Maciej Żenczykowski
---
libiptc/libip4tc.c | 2 +-
libiptc/libip6tc.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/libiptc/lib
Argh. I've never understood the faintest thing about VRF's.
On 5/7/20 11:50 AM, Gustavo A. R. Silva wrote:
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:
struct foo {
On Fri, May 08, 2020 at 04:42:23PM -0700, Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski
>
> This makes 'ping' 'ping6' and icmp based traceroute no longer
> require any suid or file capabilities.
>
> These sockets have baked long enough that the restriction
> to make them unusable by def
On Sat, 9 May 2020 09:46:53 +0300 Igor Russkikh wrote:
> From: Mark Starovoytov
>
> This patch series contains several minor cleanups for the previously
> submitted series.
>
> We also add Marvell copyrights on newly touched files.
>
> v2:
> * accommodated review comments related to the last p
Hi Dave,
Here's another set of Bluetooth patches for the 5.8 kernel:
- Add support for Intel Typhoon Peak device (8087:0032)
- Add device tree bindings for Realtek RTL8723BS device
- Add device tree bindings for Qualcomm QCA9377 device
- Add support for experimental features configuration thr
On Sat, 9 May 2020 04:35:37 + Luis Chamberlain wrote:
> Device driver firmware can crash, and sometimes, this can leave your
> system in a state which makes the device or subsystem completely
> useless. Detecting this by inspecting /proc/sys/kernel/tainted instead
> of scraping some magical wo
On Sat, 9 May 2020 18:47:08 +0200 Christophe JAILLET wrote:
> Le 09/05/2020 à 03:54, Jakub Kicinski a écrit :
> > On Fri, 8 May 2020 19:25:57 +0200 Christophe JAILLET wrote:
> >> @@ -527,8 +531,9 @@ static int mac_sonic_platform_remove(struct
> >> platform_device *pdev)
> >>struct sonic_loc
Side note, it doesn't have to be nearly as aggressive as the above.
With just:
tc qdisc replace dev ifb0 root netem reorder 99.9% 0% delay 1s
I still see 169.58M @ 7.02MB/s in 26s:
[24263:180667450] -A INPUT -m state --state RELATED,ESTABLISHED -j ACCEPT
[27:174654] -A INPUT -m state --state
1 - 100 of 208 matches
Mail list logo
