Re: Net: [DSA]: dsa-loop kernel panic

2020-04-30 Thread Allen
you have missed an important detail here which is the master device that was used for DSA. The current code defaults to whatever "eth0" is, what does this map to for your configuration? It maps to "eth0". Please let me know if you need further details. - Allen

Re: [Potential Spoof] [PATCH bpf-next] bpf: fix use-after-free of bpf_link when priming half-fails

2020-04-30 Thread Andrii Nakryiko
On Thu, Apr 30, 2020 at 11:25 PM Martin KaFai Lau wrote: > > On Thu, Apr 30, 2020 at 12:46:08PM -0700, Andrii Nakryiko wrote: > > If bpf_link_prime() succeeds to allocate new anon file, but then fails to > > allocate ID for it, link priming is considered to be failed and user is > > supposed ot be

Re: [Potential Spoof] [PATCH bpf-next] bpf: fix use-after-free of bpf_link when priming half-fails

2020-04-30 Thread Martin KaFai Lau
On Thu, Apr 30, 2020 at 12:46:08PM -0700, Andrii Nakryiko wrote: > If bpf_link_prime() succeeds to allocate new anon file, but then fails to > allocate ID for it, link priming is considered to be failed and user is > supposed ot be able to directly kfree() bpf_link, because it was never exposed > t

Re: [RFC next-next v2 2/5] net: marvell: prestera: Add PCI interface support

2020-04-30 Thread Vadym Kochan
Hi Andrew, On Fri, May 01, 2020 at 02:00:15AM +0200, Andrew Lunn wrote: > On Fri, May 01, 2020 at 02:20:49AM +0300, Vadym Kochan wrote: > > Add PCI interface driver for Prestera Switch ASICs family devices, which > > provides: > > > > - Firmware loading mechanism > > - Requests & events h

Re: [Patch net-next 1/2] net: partially revert dynamic lockdep key changes

2020-04-30 Thread Cong Wang
On Thu, Apr 30, 2020 at 12:40 AM Taehee Yoo wrote: > > +static void vlan_dev_set_lockdep_one(struct net_device *dev, > > +struct netdev_queue *txq, > > +void *_subclass) > > +{ > > + lockdep_set_class_and_subclass(&txq->

Re: [PATCH bpf-next v3] bpf: bpf_{g,s}etsockopt for struct bpf_sock_addr

2020-04-30 Thread Martin KaFai Lau
On Thu, Apr 30, 2020 at 04:31:52PM -0700, Stanislav Fomichev wrote: > Currently, bpf_getsockopt and bpf_setsockopt helpers operate on the > 'struct bpf_sock_ops' context in BPF_PROG_TYPE_SOCK_OPS program. > Let's generalize them and make them available for 'struct bpf_sock_addr'. > That way, in the

Re: [PATCH net-next 0/2] inet_diag: add cgroup attribute and filter

2020-04-30 Thread Konstantin Khlebnikov
On 30/04/2020 22.55, David Miller wrote: From: Dmitry Yakunin Date: Thu, 30 Apr 2020 18:51:13 +0300 This patch series extends inet diag with cgroup v2 ID attribute and filter. Which allows investigate sockets on per cgroup basis. Patch for ss is already sent to iproute2-next mailing list. Ok

Re: Two bugs report

2020-04-30 Thread Cong Wang
On Mon, Apr 27, 2020 at 6:16 AM Gengming Liu wrote: > > We found two security bugs in the linux kernel and here's the > description of the bugs. > > 0.Build a testing environment > a. Set up Ubuntu 19.04 in Vmware workstation. > b. sudo apt install linux-image-5.0.0-21-generic. > c. Change t

Re: Don't initialise ports with no PHY

2020-04-30 Thread Christian Zigotzky
> On 30. Apr 2020, at 23:36, Darren Stevens wrote: > > Hello Christian > >> On 29/04/2020, Christian Zigotzky wrote: >> >> On 29. Apr 2020, at 17:22, Andrew Lunn wrote: >>> >>> ?On Wed, Apr 29, 2020 at 03:55:28PM +0200, Christian Zigotzky wrote: Hi Andrew, You can fin

Re: BPFilter: bit size mismatch between bpfiter_umh and vmliux

2020-04-30 Thread Alexei Starovoitov
On Thu, Apr 30, 2020 at 9:06 PM Masahiro Yamada wrote: > > Hi Alexei, > > On Wed, Apr 29, 2020 at 1:14 AM Alexei Starovoitov > wrote: > > > > > > At least, the build was successful, > > > but does this work at runtime? > > > > > > If this is a bug, I can fix it cleanly. > > > > > > I think the bi

[PATCH v2] vhost: vsock: kick send_pkt worker once device is started

2020-04-30 Thread Jia He
Ning Bo reported an abnormal 2-second gap when booting Kata container [1]. The unconditional timeout was caused by VSOCK_DEFAULT_CONNECT_TIMEOUT of connecting from the client side. The vhost vsock client tries to connect an initializing virtio vsock server. The abnormal flow looks like: host-users

Re: linux-next: manual merge of the mlx5-next tree with the kspp-gustavo tree

2020-04-30 Thread Gustavo A. R. Silva
Stephen, On 4/30/20 22:30, Gustavo A. R. Silva wrote: >> This is now a conflict between the net-next and kspp-gustavo trees. >> > > Thanks for reporting this. I think the best solution, for now, is to remove > the > changes from my tree. I'll do it right away. > I just updated my -next tree.

Re: BPFilter: bit size mismatch between bpfiter_umh and vmliux

2020-04-30 Thread Masahiro Yamada
Hi Alexei, On Wed, Apr 29, 2020 at 1:14 AM Alexei Starovoitov wrote: > > > > At least, the build was successful, > > but does this work at runtime? > > > > If this is a bug, I can fix it cleanly. > > > > I think the bit size of the user mode helper > > should match to the kernel bit size. Is this

Re: [PATCH net] cxgb4: fix EOTID leak when disabling TC-MQPRIO offload

2020-04-30 Thread David Miller
From: Rahul Lakkireddy Date: Thu, 30 Apr 2020 00:22:19 +0530 > Under heavy load, the EOTID termination FLOWC request fails to get > enqueued to the end of the Tx ring due to lack of credits. This > results in EOTID leak. > > When disabling TC-MQPRIO offload, the link is already brought down > to

Re: [PATCH net] ipv6: Use global sernum for dst validation with nexthop objects

2020-04-30 Thread David Miller
From: David Ahern Date: Wed, 29 Apr 2020 12:45:42 -0600 > --- a/net/ipv6/route.c > +++ b/net/ipv6/route.c ... > +static inline bool rt6_is_valid(const struct rt6_info *rt6) Please don't use inline in foo.c files. Thanks.

Re: [PATCH v1] stmmac: intel: Fix kernel crash due to wrong error path

2020-04-30 Thread David Miller
From: Andy Shevchenko Date: Wed, 29 Apr 2020 18:09:32 +0300 > Unfortunately sometimes ->probe() may fail. The commit b9663b7ca6ff > ("net: stmmac: Enable SERDES power up/down sequence") > messed up with error handling and thus: > > [ 12.811311] [ cut here ] > [ 12.811

Re: linux-next: manual merge of the akpm-current tree with the bpf-next tree

2020-04-30 Thread Al Viro
On Wed, Apr 29, 2020 at 06:24:06PM +1000, Stephen Rothwell wrote: > Hi Christoph, > > On Wed, 29 Apr 2020 08:54:04 +0200 Christoph Hellwig wrote: > > > > On Tue, Apr 28, 2020 at 11:49:34PM -0700, Alexei Starovoitov wrote: > > > On Tue, Apr 28, 2020 at 11:47 PM Christoph Hellwig wrote: > > > >

Re: [PATCH -next] hinic: Use kmemdup instead of kzalloc and memcpy

2020-04-30 Thread David Miller
From: Zou Wei Date: Wed, 29 Apr 2020 11:35:28 +0800 > Fixes coccicheck warnings: > > drivers/net/ethernet/huawei/hinic/hinic_hw_mbox.c:452:17-24: WARNING > opportunity for kmemdup > drivers/net/ethernet/huawei/hinic/hinic_hw_mbox.c:458:23-30: WARNING > opportunity for kmemdup > > Reported-b

Re: [PATCH -next] hinic: make symbol 'dump_mox_reg' static

2020-04-30 Thread David Miller
From: Zheng Bin Date: Wed, 29 Apr 2020 09:58:24 +0800 > Fix sparse warnings: > > drivers/net/ethernet/huawei/hinic/hinic_hw_mbox.c:601:6: warning: symbol > 'dump_mox_reg' was not declared. Should it be static? > > Reported-by: Hulk Robot > Signed-off-by: Zheng Bin Applied to net-next.

Re: [PATCH net-next v2 4/4] net: phy: bcm54140: add second PHY ID

2020-04-30 Thread David Miller
From: Michael Walle Date: Wed, 29 Apr 2020 01:06:59 +0200 > This PHY has two PHY IDs depending on its mode. Adjust the mask so that > it includes both IDs. > > Signed-off-by: Michael Walle Applied.

Re: [PATCH -next] hinic: remove set but not used variable 'func_id'

2020-04-30 Thread David Miller
From: Zheng Bin Date: Wed, 29 Apr 2020 09:23:57 +0800 > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/ethernet/huawei/hinic/hinic_sriov.c:792:6: warning: variable > ‘func_id’ set but not used [-Wunused-but-set-variable] > > It is introduced by commit 7dd29ee12865 ("hinic: > ad

Re: [PATCH net-next v2 3/4] net: phy: bcm54140: apply the workaround on b0 chips

2020-04-30 Thread David Miller
From: Michael Walle Date: Wed, 29 Apr 2020 01:06:58 +0200 > The lower three bits of the phy_id specifies the chip stepping. The > workaround is specifically for the B0 stepping. Apply it only on these > chips. > > Signed-off-by: Michael Walle > Reviewed-by: Andrew Lunn > Reviewed-by: Florian F

Re: [PATCH net-next v2 1/4] net: phy: bcm54140: use genphy_soft_reset()

2020-04-30 Thread David Miller
From: Michael Walle Date: Wed, 29 Apr 2020 01:06:56 +0200 > Set the .soft_reset() op to be sure there will be a reset even if there > is no hardware reset line registered. > > Signed-off-by: Michael Walle > Reviewed-by: Florian Fainelli Applied.

Re: [PATCH net-next 3/3] ptp: ptp_clockmatrix: Add adjphase() to support PHC write phase mode.

2020-04-30 Thread Richard Cochran
On Wed, Apr 29, 2020 at 08:28:25PM -0400, vincent.cheng...@renesas.com wrote: > @@ -871,6 +880,69 @@ static int idtcm_set_pll_mode(struct idtcm_channel > *channel, > > /* PTP Hardware Clock interface */ > > +/** > + * @brief Maximum absolute value for write phase offset in picoseconds > + * >

Re: [PATCH net-next v2 2/4] net: phy: bcm54140: fix phy_id_mask

2020-04-30 Thread David Miller
From: Michael Walle Date: Wed, 29 Apr 2020 01:06:57 +0200 > Broadcom defines the bits for this PHY as follows: > { oui[24:3], model[6:0], revision[2:0] } > > Thus we have to mask the lower three bits only. > > Fixes: 6937602ed3f9 ("net: phy: add Broadcom BCM54140 support") > Signed-off-by: Mi

Re: [PATCH net-next] net: phy: at803x: add downshift support

2020-04-30 Thread David Miller
From: Michael Walle Date: Tue, 28 Apr 2020 23:15:02 +0200 > The AR8031 and AR8035 support the link speed downshift. Add driver > support for it. One peculiarity of these PHYs is that it needs a > software reset after changing the setting, thus add the .soft_reset() > op and do a phy_init_hw() if

Re: [PATCH v2 net-next] ipv6: Implement draft-ietf-6man-rfc4941bis

2020-04-30 Thread Fernando Gont
On 1/5/20 00:23, David Miller wrote: From: Fernando Gont Date: Sun, 26 Apr 2020 12:41:40 -0300 Implement the upcoming rev of RFC4941 (IPv6 temporary addresses): https://tools.ietf.org/html/draft-ietf-6man-rfc4941bis-09 * Reduces the default Valid Lifetime to 2 days The number of extra addr

[Patch net v2] net_sched: fix tcm_parent in tc filter dump

2020-04-30 Thread Cong Wang
When we tell kernel to dump filters from root (:), those filters on ingress (:) are matched, but their true parents must be dumped as they are. However, kernel dumps just whatever we tell it, that is either : or :: $ nl-cls-list --dev=dummy0 --parent=root cls basi

Re: [PATCH net-next] r8169: configure PME_SIGNAL for RTL8125 too

2020-04-30 Thread David Miller
From: Heiner Kallweit Date: Tue, 28 Apr 2020 22:55:59 +0200 > RTL8125 supports the same PME_SIGNAL handling as all later RTL8168 > chip variants. > > Signed-off-by: Heiner Kallweit Applied.

Re: [PATCH net-next] r8169: improve max jumbo packet size definition

2020-04-30 Thread David Miller
From: Heiner Kallweit Date: Tue, 28 Apr 2020 22:54:12 +0200 > Sync definition of max jumbo packet size with vendor driver and reserve > 22 bytes for VLAN ethernet header plus checksum. > > Signed-off-by: Heiner Kallweit Applied.

[PATCH v3 net-next] ipv6: Implement draft-ietf-6man-rfc4941bis

2020-04-30 Thread Fernando Gont
Implement the upcoming rev of RFC4941 (IPv6 temporary addresses): https://tools.ietf.org/html/draft-ietf-6man-rfc4941bis-09 * Reduces the default Valid Lifetime to 2 days The number of extra addresses employed when Valid Lifetime was 7 days exacerbated the stress caused on network elements/d

Re: [PATCH net] mlxsw: spectrum_acl_tcam: Position vchunk in a vregion list properly

2020-04-30 Thread David Miller
From: Ido Schimmel Date: Mon, 27 Apr 2020 18:05:47 +0300 > From: Jiri Pirko > > Vregion helpers to get min and max priority depend on the correct > ordering of vchunks in the vregion list. However, the current code > always adds new chunk to the end of the list, no matter what the > priority is

Re: [PATCH net-next] dpaa2-eth: fix error return code in setup_dpni()

2020-04-30 Thread David Miller
From: Wei Yongjun Date: Mon, 27 Apr 2020 10:43:22 + > Fix to return negative error code -ENOMEM from the error handling > case instead of 0, as done elsewhere in this function. > > Signed-off-by: Wei Yongjun Applied, thanks.

Re: [PATCH net-next] net: ll_temac: Fix return value check in temac_probe()

2020-04-30 Thread David Miller
From: Wei Yongjun Date: Mon, 27 Apr 2020 09:40:52 + > In case of error, the function devm_ioremap() returns NULL pointer > not ERR_PTR(). The IS_ERR() test in the return value check should > be replaced with NULL test. > > Signed-off-by: Wei Yongjun Applied, thank you.

Re: [PATCH net-next 2/3] ptp: Add adjust_phase to ptp_clock_caps capability.

2020-04-30 Thread Richard Cochran
On Wed, Apr 29, 2020 at 08:28:24PM -0400, vincent.cheng...@renesas.com wrote: > From: Vincent Cheng > > Add adjust_phase to ptp_clock_caps capability to allow > user to query if a PHC driver supports adjust phase with > ioctl PTP_CLOCK_GETCAPS command. > > Signed-off-by: Vincent Cheng Reviewed

Re: [PATCH net-next 1/3] ptp: Add adjphase function to support phase offset control.

2020-04-30 Thread Richard Cochran
On Wed, Apr 29, 2020 at 08:28:23PM -0400, vincent.cheng...@renesas.com wrote: > diff --git a/drivers/ptp/ptp_clock.c b/drivers/ptp/ptp_clock.c > index acabbe7..c46ff98 100644 > --- a/drivers/ptp/ptp_clock.c > +++ b/drivers/ptp/ptp_clock.c > @@ -146,6 +146,8 @@ static int ptp_clock_adjtime(struct po

Re: [PATCH v5 net-next 2/2] xen networking: add XDP offset adjustment to xen-netback

2020-04-30 Thread David Miller
From: Denis Kirjanov Date: Mon, 27 Apr 2020 18:00:32 +0300 > the patch basically adds the offset adjustment and netfront > state reading to make XDP work on netfront side. Missing a Signed-off-by: tag for this patch, and the entire patch series needs a proper header posting.

Re: [PATCH net] tunnel: Propagate ECT(1) when decapsulating as recommended by RFC6040

2020-04-30 Thread David Miller
From: Toke Høiland-Jørgensen Date: Mon, 27 Apr 2020 16:11:05 +0200 > RFC 6040 recommends propagating an ECT(1) mark from an outer tunnel header > to the inner header if that inner header is already marked as ECT(0). When > RFC 6040 decapsulation was implemented, this case of propagation was not >

Re: [RESENT PATCH net--stat 1/1] net: ethernet: fec: Revert "net: ethernet: fec: Replace interrupt driven MDIO with polled IO"

2020-04-30 Thread David Miller
From: Fugang Duan Date: Mon, 27 Apr 2020 22:08:04 +0800 > This reverts commit 29ae6bd1b0d8a57d7c00ab12cbb949fc41986eef. > > The commit breaks ethernet function on i.MX6SX, i.MX7D, i.MX8MM, > i.MX8MQ, and i.MX8QXP platforms. Boot yocto system by NFS mounting > rootfs will be failed with the commi

Re: [PATCH net-next] net: lpc-enet: fix error return code in lpc_mii_init()

2020-04-30 Thread David Miller
From: Wei Yongjun Date: Mon, 27 Apr 2020 12:15:07 + > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: b7370112f519 ("lpc32xx: Added ethernet driver") > Signed-off-by: Wei Yongjun Applied.

Re: [PATCH net-next] ice: Fix error return code in ice_add_prof()

2020-04-30 Thread David Miller
From: Wei Yongjun Date: Mon, 27 Apr 2020 12:12:28 + > Fix to return a error code from the error handling case > instead of 0, as done elsewhere in this function. > > Fixes: 31ad4e4ee1e4 ("ice: Allocate flow profile") > Signed-off-by: Wei Yongjun Applied, thanks.

Re: [PATCH net-next] octeontx2-pf: Fix error return code in otx2_probe()

2020-04-30 Thread David Miller
From: Wei Yongjun Date: Mon, 27 Apr 2020 12:11:10 + > Fix to return negative error code -ENOMEM from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: 5a6d7c9daef3 ("octeontx2-pf: Mailbox communication with AF") > Signed-off-by: Wei Yongjun Applied, tha

Re: [PATCH v1] net: macb: Fix runtime PM refcounting

2020-04-30 Thread David Miller
From: Andy Shevchenko Date: Mon, 27 Apr 2020 13:51:20 +0300 > The commit e6a41c23df0d, while trying to fix an issue, > > ("net: macb: ensure interface is not suspended on at91rm9200") > > introduced a refcounting regression, because in error case refcounter > must be balanced. Fix it by cal

Re: [PATCH] dpaa_eth: Fix comparing pointer to 0

2020-04-30 Thread David Miller
From: Aishwarya Ramakrishnan Date: Mon, 27 Apr 2020 16:02:30 +0530 > Fixes coccicheck warning: > ./drivers/net/ethernet/freescale/dpaa/dpaa_eth.c:2110:30-31: > WARNING comparing pointer to 0 > > Avoid pointer type value compared to 0. > > Signed-off-by: Aishwarya Ramakrishnan Applied, thanks.

Re: linux-next: manual merge of the mlx5-next tree with the kspp-gustavo tree

2020-04-30 Thread Gustavo A. R. Silva
Hi Stephen, On 4/30/20 22:12, Stephen Rothwell wrote: > Hi all, > > On Wed, 29 Apr 2020 12:06:25 +1000 Stephen Rothwell > wrote: >> >> Today's linux-next merge of the mlx5-next tree got a conflict in: >> >> include/linux/mlx5/mlx5_ifc.h >> >> between commit: >> >> 3ba225b506a2 ("treewide: R

Re: [PATCH] ptp_qoriq: output PPS signal on FIPER2 in default

2020-04-30 Thread David Miller
From: Yangbo Lu Date: Mon, 27 Apr 2020 11:39:03 +0800 > Output PPS signal on FIPER2 (Fixed Period Interval Pulse) in default > which is more desired by user. > > Signed-off-by: Yangbo Lu Applied to net-next, thanks.

Re: [PATCH] net: moxa: Fix a potential double 'free_irq()'

2020-04-30 Thread David Miller
From: Christophe JAILLET Date: Sun, 26 Apr 2020 22:59:21 +0200 > Should an irq requested with 'devm_request_irq' be released explicitly, > it should be done by 'devm_free_irq()', not 'free_irq()'. > > Fixes: 6c821bd9edc9 ("net: Add MOXA ART SoCs ethernet driver") > Signed-off-by: Christophe JAIL

Re: [PATCH v2 net-next] ipv6: Implement draft-ietf-6man-rfc4941bis

2020-04-30 Thread David Miller
From: Fernando Gont Date: Sun, 26 Apr 2020 12:41:40 -0300 > Implement the upcoming rev of RFC4941 (IPv6 temporary addresses): > https://tools.ietf.org/html/draft-ietf-6man-rfc4941bis-09 > > * Reduces the default Valid Lifetime to 2 days > The number of extra addresses employed when Valid Lifet

Re: linux-next: manual merge of the mlx5-next tree with the kspp-gustavo tree

2020-04-30 Thread Stephen Rothwell
Hi all, On Wed, 29 Apr 2020 12:06:25 +1000 Stephen Rothwell wrote: > > Today's linux-next merge of the mlx5-next tree got a conflict in: > > include/linux/mlx5/mlx5_ifc.h > > between commit: > > 3ba225b506a2 ("treewide: Replace zero-length array with flexible-array > member") > > from t

linux-next: manual merge of the net-next tree with the kspp-gustavo tree

2020-04-30 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/ethernet/mellanox/mlxsw/spectrum_span.c between commit: 3ba225b506a2 ("treewide: Replace zero-length array with flexible-array member") from the kspp-gustavo tree and commit: 4780dbdbd957 ("mlxsw: spec

linux-next: manual merge of the net-next tree with the net tree

2020-04-30 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c between commit: 8075411d93b6 ("net/mlx5: DR, On creation set CQ's arm_db member to right value") from the net tree and commit: 73a75b96fc9a ("net/mlx5: Re

Re: [RFC PATCH bpf-next 0/3] bpf: add tracing for XDP programs using the BPF_PROG_TEST_RUN API

2020-04-30 Thread Masami Hiramatsu
On Tue, 28 Apr 2020 09:19:47 -0300 Arnaldo Carvalho de Melo wrote: > Em Tue, Apr 28, 2020 at 12:47:53PM +0200, Eelco Chaudron escreveu: > > On 28 Apr 2020, at 6:04, Alexei Starovoitov wrote: > > > On Fri, Apr 24, 2020 at 02:29:56PM +0200, Eelco Chaudron wrote: > > > > > > But in reality I think

linux-next: manual merge of the net-next tree with the net tree

2020-04-30 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: include/net/mptcp.h between commit: cfde141ea3fa ("mptcp: move option parsing into mptcp_incoming_options()") from the net tree and commit: 071c8ed6e88d ("tcp: mptcp: use mptcp receive buffer space to select rcv w

[PATCH bpf 0/2] bpf, arm: Small JIT optimizations

2020-04-30 Thread Luke Nelson
As Daniel suggested to us, we ran our formal verification tool, Serval, over the arm JIT. The bugs we found have been patched and applied to the bpf tree [1, 2]. This patch series introduces two small optimizations that simplify the JIT and use fewer instructions. [1] https://lore.kernel.org/bpf/2

[PATCH bpf-next 2/2] bpf, arm: Optimize ALU ARSH K using asr immediate instruction

2020-04-30 Thread Luke Nelson
This patch adds an optimization that uses the asr immediate instruction for BPF_ALU BPF_ARSH BPF_K, rather than loading the immediate to a temporary register. This is similar to existing code for handling BPF_ALU BPF_{LSH,RSH} BPF_K. This optimization saves two instructions and is more consistent w

[PATCH bpf-next 1/2] bpf, arm: Optimize ALU64 ARSH X using orrpl conditional instruction

2020-04-30 Thread Luke Nelson
This patch optimizes the code generated by emit_a32_arsh_r64, which handles the BPF_ALU64 BPF_ARSH BPF_X instruction. The original code uses a conditional B followed by an unconditional ORR. The optimization saves one instruction by removing the B instruction and using a conditional ORR (with an i

Re: [PATCH net-next] net: bcmgenet: Move wake-up event out of side band ISR

2020-04-30 Thread Florian Fainelli
On 4/30/2020 4:26 PM, Doug Berger wrote: > The side band interrupt service routine is not available on chips > like 7211, or rather, it does not permit the signaling of wake-up > events due to the complex interrupt hierarchy. > > Move the wake-up event accounting into a .resume_noirq function,

[v5,net-next 3/4] net: enetc: add hw tc hw offload features for PSPF capability

2020-04-30 Thread Po Liu
This patch is to let ethtool enable/disable the tc flower offload features. Hardware ENETC has the feature of PSFP which is for per-stream policing. When enable the tc hw offloading feature, driver would enable the IEEE 802.1Qci feature. It is only set the register enable bit for this feature not e

[v5,net-next 1/4] net: qos: introduce a gate control flow action

2020-04-30 Thread Po Liu
Introduce a ingress frame gate control flow action. Tc gate action does the work like this: Assume there is a gate allow specified ingress frames can be passed at specific time slot, and be dropped at specific time slot. Tc filter chooses the ingress frames, and tc gate action would specify what sl

[v5,net-next 4/4] net: enetc: add tc flower psfp offload driver

2020-04-30 Thread Po Liu
This patch is to add tc flower offload for the enetc IEEE 802.1Qci(PSFP) function. There are four main feature parts to implement the flow policing and filtering for ingress flow with IEEE 802.1Qci features. They are stream identify(this is defined in the P802.1cb exactly but needed for 802.1Qci),

[v5,net-next 0/4] Introduce a flow gate control action and apply IEEE

2020-04-30 Thread Po Liu
Changes from V4: 0001: Fix and modify according to Vlid Buslov suggestions: - Change spin_lock_bh() to spin_lock() since tcf_gate_act() already in software irq. - Remove spin lock protect in the ops->cleanup function. - Enable the CONFIG_DEBUG_ATOMIC_SLEEP and CONFIG_PROVE_LOCKING

[v5,net-next 2/4] net: schedule: add action gate offloading

2020-04-30 Thread Po Liu
Add the gate action to the flow action entry. Add the gate parameters to the tc_setup_flow_action() queueing to the entries of flow_action_entry array provide to the driver. Signed-off-by: Po Liu --- include/net/flow_offload.h | 10 include/net/tc_act/tc_gate.h | 99 ++

Re: [Patch net] net_sched: fix tcm_parent in tc filter dump

2020-04-30 Thread Cong Wang
On Thu, Apr 30, 2020 at 6:02 PM Cong Wang wrote: > diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c > index 55bd1429678f..80e93c96d2b2 100644 > --- a/net/sched/cls_api.c > +++ b/net/sched/cls_api.c > @@ -2612,12 +2612,10 @@ static int tc_dump_tfilter(struct sk_buff *skb, > struct netlink_ca

Re: [PATCH net-next] erspan: Add type I version 0 support.

2020-04-30 Thread David Miller
From: William Tu Date: Sun, 26 Apr 2020 08:05:11 -0700 > index 029b24eeafba..b5c5fb329f31 100644 > --- a/net/ipv4/ip_gre.c > +++ b/net/ipv4/ip_gre.c > @@ -248,6 +248,15 @@ static void gre_err(struct sk_buff *skb, u32 info) > ipgre_err(skb, info, &tpi); > } > > +static inline bool is_ersp

Re: [PATCH 0/2] Netfilter fixes for net

2020-04-30 Thread David Miller
From: Pablo Neira Ayuso Date: Wed, 29 Apr 2020 23:48:09 +0200 > The following patchset contains Netfilter fixes for net: > > 1) Do not update the UDP checksum when it's zero, from Guillaume Nault. > > 2) Fix return of local variable in nf_osf, from Arnd Bergmann. > > You can pull these changes

Re: [PATCH net 0/3] net: ipa: three bug fixes

2020-04-30 Thread David Miller
From: Alex Elder Date: Thu, 30 Apr 2020 16:35:09 -0500 > This series fixes three bugs in the Qualcomm IPA code. The third > adds a missing error code initialization step. Series applied, thanks.

Re: [PATCH v2 net 0/3] ionic: fw upgrade bug fixes

2020-04-30 Thread David Miller
From: Shannon Nelson Date: Thu, 30 Apr 2020 14:33:40 -0700 > These patches address issues found in additional internal > fw-upgrade testing. > > Shannon Nelson (3): > ionic: no link check until after probe > ionic: refresh devinfo after fw-upgrade > ionic: add device reset to fw upgrade do

[Patch net] net_sched: fix tcm_parent in tc filter dump

2020-04-30 Thread Cong Wang
When we tell kernel to dump filters from root (:), those filters on ingress (:) are matched, but their true parents must be dumped as they are. However, kernel dumps just whatever we tell it, that is either : or :: $ nl-cls-list --dev=dummy0 --parent=root cls basi

Re: [PATCH v2 0/8] netlink validation improvements/refactoring

2020-04-30 Thread David Miller
From: Johannes Berg Date: Thu, 30 Apr 2020 22:13:04 +0200 > Alright, this is the resend now, really just changing > > - the WARN_ON_ONCE() as spotted by Jakub; > - mark the export patch no longer RFC. >I wasn't actually sure if you meant this one too, and I really >should dig out and p

Re: [PATCH] dp83640: reverse arguments to list_add_tail

2020-04-30 Thread David Miller
From: Julia Lawall Date: Thu, 30 Apr 2020 21:51:32 +0200 > In this code, it appears that phyter_clocks is a list head, based on > the previous list_for_each, and that clock->list is intended to be a > list element, given that it has just been initialized in > dp83640_clock_init. Accordingly, swi

Re: [PATCH net] net: bridge: vlan: Add a schedule point during VLAN processing

2020-04-30 Thread David Miller
From: Ido Schimmel Date: Thu, 30 Apr 2020 22:38:45 +0300 > From: Ido Schimmel > > User space can request to delete a range of VLANs from a bridge slave in > one netlink request. For each deleted VLAN the FDB needs to be traversed > in order to flush all the affected entries. > > If a large ran

Re: [PATCH net-next 0/4] net: dsa: b53: ARL improvements

2020-04-30 Thread David Miller
From: Florian Fainelli Date: Thu, 30 Apr 2020 11:49:07 -0700 > This patch series improves the b53 driver ARL search code by > renaming the ARL entries to be reflective of what they are: bins, and > then introduce the number of buckets so we can properly bound check ARL > searches. > > The final

Re: [PATCH net-next 0/7] r8169: refactor and improve interrupt coalescing

2020-04-30 Thread David Miller
From: Jakub Kicinski Date: Thu, 30 Apr 2020 14:51:10 -0700 > On Thu, 30 Apr 2020 21:54:43 +0200 Heiner Kallweit wrote: >> Refactor and improve interrupt coalescing. > > Looks like a nice clean up! > > Reviewed-by: Jakub Kicinski Series applied, thanks everyone.

Re: [PATCH net-next 1/1] qedr: Avoid DB recover entry deletion when device is not active.

2020-04-30 Thread kbuild test robot
Hi Sudarsana, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Sudarsana-Reddy-Kalluru/qedr-Avoid-DB-recover-entry-deletion-when-device-is-not-active/20200501-033426 base: https://git.kernel.org/pub/

Re: [RFC next-next v2 5/5] dt-bindings: marvell,prestera: Add address mapping for Prestera Switchdev PCIe driver

2020-04-30 Thread Andrew Lunn
On Fri, May 01, 2020 at 02:20:52AM +0300, Vadym Kochan wrote: > Document requirement for the PCI port which is connected to the ASIC, to > allow access to the firmware related registers. > > Signed-off-by: Vadym Kochan > --- > .../devicetree/bindings/net/marvell,prestera.txt| 13

Re: [RFC next-next v2 2/5] net: marvell: prestera: Add PCI interface support

2020-04-30 Thread Andrew Lunn
On Fri, May 01, 2020 at 02:20:49AM +0300, Vadym Kochan wrote: > Add PCI interface driver for Prestera Switch ASICs family devices, which > provides: > > - Firmware loading mechanism > - Requests & events handling to/from the firmware > - Access to the firmware on the bus level > > The

[PATCH net-next 2/2] net/mlx5: Added support for 100Gbps per lane link modes

2020-04-30 Thread Saeed Mahameed
From: Meir Lichtinger This patch exposes new link modes using 100Gbps per lane, including 100G, 200G and 400G modes. Signed-off-by: Meir Lichtinger Reviewed-by: Aya Levin Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/en/port.c | 3 +++ .../ethernet/mellanox/mlx5/core

[PATCH net-next 1/2] ethtool: Add support for 100Gbps per lane link modes

2020-04-30 Thread Saeed Mahameed
From: Meir Lichtinger Define 100G, 200G and 400G link modes using 100Gbps per lane Signed-off-by: Meir Lichtinger CC: Andrew Lunn Reviewed-by: Aya Levin Signed-off-by: Saeed Mahameed --- drivers/net/phy/phy-core.c | 17 - include/uapi/linux/ethtool.h | 15 +++

[PATCH net-next 0/2] ethtool: Add support for 100Gbps per lane link modes

2020-04-30 Thread Saeed Mahameed
Hi, This small series adds new ethtool link modes bits to Define 100G, 200G and 400G link modes using 100Gbps per lane. Thanks, Saeed. Meir Lichtinger (2): ethtool: Add support for 100Gbps per lane link modes net/mlx5: Added support for 100Gbps per lane link modes .../net/ethernet/mellano

[PATCH net-next] net: bcmgenet: Move wake-up event out of side band ISR

2020-04-30 Thread Doug Berger
The side band interrupt service routine is not available on chips like 7211, or rather, it does not permit the signaling of wake-up events due to the complex interrupt hierarchy. Move the wake-up event accounting into a .resume_noirq function, account for possible wake-up events and clear the MPD/

[RFC next-next v2 4/5] net: marvell: prestera: Add Switchdev driver implementation

2020-04-30 Thread Vadym Kochan
The following features are supported: - VLAN-aware bridge offloading - VLAN-unaware bridge offloading - FDB offloading (learning, ageing) - Switchport configuration Currently there are some limitations like: - Only 1 VLAN-aware bridge instance supported - No STP supported

[RFC next-next v2 5/5] dt-bindings: marvell,prestera: Add address mapping for Prestera Switchdev PCIe driver

2020-04-30 Thread Vadym Kochan
Document requirement for the PCI port which is connected to the ASIC, to allow access to the firmware related registers. Signed-off-by: Vadym Kochan --- .../devicetree/bindings/net/marvell,prestera.txt| 13 + 1 file changed, 13 insertions(+) diff --git a/Documentation/devicetree

[RFC next-next v2 0/5] net: marvell: prestera: Add Switchdev driver for Prestera family ASIC device 98DX326x (AC3x)

2020-04-30 Thread Vadym Kochan
Marvell Prestera 98DX326x integrates up to 24 ports of 1GbE with 8 ports of 10GbE uplinks or 2 ports of 40Gbps stacking for a largely wireless SMB deployment. Prestera Switchdev is a firmware based driver which operates via PCI bus. The current implementation supports only boards designed for the

[RFC next-next v2 3/5] net: marvell: prestera: Add ethtool interface support

2020-04-30 Thread Vadym Kochan
The ethtool API provides support for the configuration of the following features: speed and duplex, auto-negotiation, MDI-x, forward error correction, port media type. The API also provides information about the port status, hardware and software statistic. The following limitation exists: -

[RFC next-next v2 1/5] net: marvell: prestera: Add driver for Prestera family ASIC devices

2020-04-30 Thread Vadym Kochan
Marvell Prestera 98DX326x integrates up to 24 ports of 1GbE with 8 ports of 10GbE uplinks or 2 ports of 40Gbps stacking for a largely wireless SMB deployment. The current implementation supports only boards designed for the Marvell Switchdev solution and requires special firmware. The core Preste

[RFC next-next v2 2/5] net: marvell: prestera: Add PCI interface support

2020-04-30 Thread Vadym Kochan
Add PCI interface driver for Prestera Switch ASICs family devices, which provides: - Firmware loading mechanism - Requests & events handling to/from the firmware - Access to the firmware on the bus level The firmware has to be loaded each time device is reset. The driver is loading it

Re: [PATCH 1/1] net/mlx5: Call pci_disable_sriov() on remove

2020-04-30 Thread Niklas Schnelle
On 4/30/20 9:47 PM, Niklas Schnelle wrote: > > > On 4/30/20 5:58 PM, Saeed Mahameed wrote: >> On Thu, 2020-04-30 at 14:03 +0200, Niklas Schnelle wrote: >>> as described in Documentation/PCI/pci-iov-howto.rst a driver with SR- >>> IOV >>> support should call pci_disable_sriov() in the remove ha

Re: [PATCH v2 net-next 08/17] net: atlantic: A2 driver-firmware interface

2020-04-30 Thread Jakub Kicinski
On Thu, 30 Apr 2020 11:04:36 +0300 Igor Russkikh wrote: > + struct __attribute__ ((__packed__)) { nit: checkpatch should warn that the kernel style prefers __packed > + u8 arp_responder:1; > + u8 echo_responder:1; > + u8 igmp_client:1; > + u8 ec

[PATCH net-next 1/2] net: ipa: pass channel pointer to gsi_channel_state()

2020-04-30 Thread Alex Elder
Pass a channel pointer rather than a GSI pointer and channel ID to gsi_channel_state(). Signed-off-by: Alex Elder --- drivers/net/ipa/gsi.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/net/ipa/gsi.c b/drivers/net/ipa/gsi.c index 845478a19a4f..6946c39b66

[PATCH net-next 2/2] net: ipa: do not cache channel state

2020-04-30 Thread Alex Elder
It is possible for a GSI channel's state to be changed as a result of an action by a different execution environment. Specifically, the modem is able to issue a GSI generic command that causes a state change on a GSI channel associated with the AP. A channel's state only needs to be known when a

[PATCH net-next 0/2] net: ipa: don't cache channel state

2020-04-30 Thread Alex Elder
This series removes a field that holds a copy of a channel's state at the time it was last fetched. In principle the state can change at any time, so it's better to just fetch it whenever needed. The first patch is just preparatory, simplifying the arguments to gsi_channel_state().

Re: [PATCH 04/15] ath10k: fix gcc-10 zero-length-bounds warnings

2020-04-30 Thread Gustavo A. R. Silva
Hi Arnd, On 4/30/20 16:30, Arnd Bergmann wrote: > gcc-10 started warning about out-of-bounds access for zero-length > arrays: > > In file included from drivers/net/wireless/ath/ath10k/core.h:18, > from drivers/net/wireless/ath/ath10k/htt_rx.c:8: > drivers/net/wireless/ath/ath10k/

Re: [PATCH net-next 0/7] r8169: refactor and improve interrupt coalescing

2020-04-30 Thread Jakub Kicinski
On Thu, 30 Apr 2020 21:54:43 +0200 Heiner Kallweit wrote: > Refactor and improve interrupt coalescing. Looks like a nice clean up! Reviewed-by: Jakub Kicinski

Re: [PATCH 04/15] ath10k: fix gcc-10 zero-length-bounds warnings

2020-04-30 Thread Arnd Bergmann
On Thu, Apr 30, 2020 at 11:41 PM Gustavo A. R. Silva wrote: > On 4/30/20 16:30, Arnd Bergmann wrote: > > gcc-10 started warning about out-of-bounds access for zero-length > > arrays: > The treewide patch is an experimental change and, as this change only applies > to my -next tree, I will carry th

[PATCH net 2/3] net: ipa: fix an error message in gsi_channel_init_one()

2020-04-30 Thread Alex Elder
An error message about limiting the number of TREs used prints the wrong value. Fix this bug. Signed-off-by: Alex Elder --- drivers/net/ipa/gsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ipa/gsi.c b/drivers/net/ipa/gsi.c index 845478a19a4f..b4206fda0b2

[PATCH net 0/3] net: ipa: three bug fixes

2020-04-30 Thread Alex Elder
This series fixes three bugs in the Qualcomm IPA code. The third adds a missing error code initialization step. -Alex Alex Elder (3): net: ipa: fix a bug in ipa_endpoint_stop() net: ipa: fix an error message in gsi_channel_init_one() net: ipa: zero r

[PATCH net 1/3] net: ipa: fix a bug in ipa_endpoint_stop()

2020-04-30 Thread Alex Elder
In ipa_endpoint_stop(), for TX endpoints we set the number of retries to 0. When we break out of the loop, retries being 0 means we return EIO rather than the value of ret (which should be 0). Fix this by using a non-zero retry count for both RX and TX channels, and just break out of the loop aft

[PATCH net 3/3] net: ipa: zero return code before issuing generic EE command

2020-04-30 Thread Alex Elder
Zero the result code stored in a field of the scratch 0 register before issuing a generic EE command. This just guarantees that the value we read later was actually written as a result of the command. Also add the definitions of two more possible result codes that can be returned when issuing flo

[PATCH v2 net 3/3] ionic: add device reset to fw upgrade down

2020-04-30 Thread Shannon Nelson
Doing a device reset addresses an obscure FW timing issue in the FW upgrade process. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/pensando/ionic/ionic_lif.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c b/drivers/net/ethernet/pensa

[PATCH v2 net 0/3] ionic: fw upgrade bug fixes

2020-04-30 Thread Shannon Nelson
These patches address issues found in additional internal fw-upgrade testing. Shannon Nelson (3): ionic: no link check until after probe ionic: refresh devinfo after fw-upgrade ionic: add device reset to fw upgrade down v2: - replaced extra state flag with postponing first link check - ad

  1   2   3   4   5   6   >