Re: [PATCH v2 net-next 08/17] net: atlantic: A2 driver-firmware interface

[Jakub Kicinski]

On Thu, 30 Apr 2020 11:04:36 +0300 Igor Russkikh wrote:
> +     struct __attribute__ ((__packed__)) {

nit: checkpatch should warn that the kernel style prefers __packed

> +             u8 arp_responder:1;
> +             u8 echo_responder:1;
> +             u8 igmp_client:1;
> +             u8 echo_truncate:1;
> +             u8 address_guard:1;
> +             u8 ignore_fragmented:1;
> +             u8 rsvd:2;
> +
> +             u16 echo_max_len;
> +             u8 rsvd2;
> +     } ipv4_offload;