Re: [PATCH v3 net-next 06/12] net: aquantia: implement data PTP datapath

2019-10-23 Thread kbuild test robot
Hi Igor, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Igor-Russkikh/net-aquantia-PTP-support-for-AQC-devices/20191023-194531 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net

[PATCH net-next] r8169: improve rtl8169_rx_fill

2019-10-23 Thread Heiner Kallweit
We have only one user of the error path, so we can inline it. In addition the call to rtl8169_make_unusable_by_asic() can be removed because rtl8169_alloc_rx_data() didn't call rtl8169_mark_to_asic() yet for the respective index if returning NULL. Signed-off-by: Heiner Kallweit --- drivers/net/e

[PATCH net-nex V2 3/3] net/mlx5e: Rx, Update page pool numa node when changed

2019-10-23 Thread Saeed Mahameed
Once every napi poll cycle, check if numa node is different than the page pool's numa id, and update it using page_pool_update_nid(). Alternatively, we could have registered an irq affinity change handler, but page_pool_update_nid() must be called from napi context anyways, so the handler won't ac

[PATCH net-nex V2 1/3] page_pool: Add API to update numa node

2019-10-23 Thread Saeed Mahameed
Add page_pool_update_nid() to be called by page pool consumers when they detect numa node changes. It will update the page pool nid value to start allocating from the new effective numa node. This is to mitigate page pool allocating pages from a wrong numa node, where the pool was originally allo

[PATCH net-nex V2 2/3] page_pool: Don't recycle non-reusable pages

2019-10-23 Thread Saeed Mahameed
A page is NOT reusable when at least one of the following is true: 1) allocated when system was under some pressure. (page_is_pfmemalloc) 2) belongs to a different NUMA node than pool->p.nid. To update pool->p.nid users should call page_pool_update_nid(). Holding on to such pages in the pool will

[PATCH net-nex V2 0/3] page_pool: API for numa node change handling

2019-10-23 Thread Saeed Mahameed
Hi Dave & Jesper, This series extends page pool API to allow page pool consumers to update page pool numa node on the fly. This is required since on some systems, rx rings irqs can migrate between numa nodes, due to irq balancer or user defined scripts, current page pool has no way to know of such

Re: [PATCH net-next 0/9] devlink vdev

2019-10-23 Thread Jiri Pirko
Wed, Oct 23, 2019 at 09:00:46PM CEST, jakub.kicin...@netronome.com wrote: >On Tue, 22 Oct 2019 20:43:01 +0300, Yuval Avnery wrote: >> This patchset introduces devlink vdev. >> >> Currently, legacy tools do not provide a comprehensive solution that can >> be used in both SmartNic and non-SmartNic m

Re: [PATCH net-next 0/4] page_pool: API for numa node change handling

2019-10-23 Thread Saeed Mahameed
On Wed, 2019-10-23 at 18:20 +0300, Or Gerlitz wrote: > On Tue, Oct 22, 2019 at 8:04 AM Saeed Mahameed > wrote: > > > CPU: Intel(R) Xeon(R) CPU E5-2603 v4 @ 1.70GHz > > NIC: Mellanox Technologies MT27700 Family [ConnectX-4] (100G) > > > > XDP Drop/TX single core: > > NUMA | XDP | Before| Af

Re: [PATCH net-next 3/4] page_pool: Restructure __page_pool_put_page()

2019-10-23 Thread Saeed Mahameed
On Wed, 2019-10-23 at 20:31 +0200, Jesper Dangaard Brouer wrote: > On Wed, 23 Oct 2019 11:45:15 +0300 > Ilias Apalodimas wrote: > > > On Tue, Oct 22, 2019 at 04:44:24AM +, Saeed Mahameed wrote: > > > From: Jonathan Lemon > > > > > > 1) Rename functions to reflect what they are actually doin

[PATCH net-next] r8169: align fix_features callback with vendor driver

2019-10-23 Thread Heiner Kallweit
This patch aligns the fix_features callback with the vendor driver and also disables IPv6 HW checksumming and TSO if jumbo packets are used on RTL8101/RTL8168/RTL8125. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

Re: [PATCH net-next 2/4] page_pool: Don't recycle non-reusable pages

2019-10-23 Thread Saeed Mahameed
On Wed, 2019-10-23 at 20:38 +0200, Jesper Dangaard Brouer wrote: > On Tue, 22 Oct 2019 04:44:21 + > Saeed Mahameed wrote: > > > A page is NOT reusable when at least one of the following is true: > > 1) allocated when system was under some pressure. > > (page_is_pfmemalloc) > > 2) belongs to a

Re: [PATCH net-next 0/9] devlink vdev

2019-10-23 Thread Jakub Kicinski
On Tue, 22 Oct 2019 20:43:01 +0300, Yuval Avnery wrote: > This patchset introduces devlink vdev. > > Currently, legacy tools do not provide a comprehensive solution that can > be used in both SmartNic and non-SmartNic mode. > Vdev represents a device that exists on the ASIC but is not necessarily

Re: [Patch net-next 3/3] tcp: decouple TLP timer from RTO timer

2019-10-23 Thread Eric Dumazet
On Wed, Oct 23, 2019 at 11:30 AM Cong Wang wrote: > > On Wed, Oct 23, 2019 at 11:14 AM Eric Dumazet wrote: > > > In case you misunderstand, the CPU profiling I used is captured > > > during 256 parallel TCP_STREAM. > > > > When I asked you the workload, you gave me TCP_RR output, not TCP_STREAM :

Re: [PATCH net-next] xsk: Enable AF_XDP by default.

2019-10-23 Thread Jesper Dangaard Brouer
On Tue, 22 Oct 2019 16:58:31 -0700 William Tu wrote: > The patch enables XDP_SOCKETS and XDP_SOCKETS_DIAG used by AF_XDP, > and its dependency on BPF_SYSCALL. > > Signed-off-by: William Tu Acked-by: Jesper Dangaard Brouer -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel

Re: [PATCH net-next 2/4] page_pool: Don't recycle non-reusable pages

2019-10-23 Thread Jesper Dangaard Brouer
On Tue, 22 Oct 2019 04:44:21 + Saeed Mahameed wrote: > A page is NOT reusable when at least one of the following is true: > 1) allocated when system was under some pressure. (page_is_pfmemalloc) > 2) belongs to a different NUMA node than pool->p.nid. > > To update pool->p.nid users should ca

Re: [PATCH net-next 3/4] page_pool: Restructure __page_pool_put_page()

2019-10-23 Thread Jesper Dangaard Brouer
On Wed, 23 Oct 2019 11:45:15 +0300 Ilias Apalodimas wrote: > On Tue, Oct 22, 2019 at 04:44:24AM +, Saeed Mahameed wrote: > > From: Jonathan Lemon > > > > 1) Rename functions to reflect what they are actually doing. > > > > 2) Unify the condition to keep a page. > > > > 3) When page can't

Re: [Patch net-next 3/3] tcp: decouple TLP timer from RTO timer

2019-10-23 Thread Cong Wang
On Wed, Oct 23, 2019 at 11:14 AM Eric Dumazet wrote: > > In case you misunderstand, the CPU profiling I used is captured > > during 256 parallel TCP_STREAM. > > When I asked you the workload, you gave me TCP_RR output, not TCP_STREAM :/ > > "A single netperf TCP_RR could _also_ confirm the improve

[net-next 11/11] i40e: prevent memory leak in i40e_setup_macvlans

2019-10-23 Thread Jeff Kirsher
From: Navid Emamdoost In i40e_setup_macvlans if i40e_setup_channel fails the allocated memory for ch should be released. Signed-off-by: Navid Emamdoost Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_main.c | 1 + 1 file changed, 1 insertion(+)

[net-next 07/11] i40e: initialize ITRN registers with correct values

2019-10-23 Thread Jeff Kirsher
From: Nicholas Nunley Since commit 92418fb14750 ("i40e/i40evf: Use usec value instead of reg value for ITR defines") the driver tracks the interrupt throttling intervals in single usec units, although the actual ITRN/ITR0 registers are programmed in 2 usec units. Most register programming flows i

[net-next 02/11] i40e: Add ability to display VF stats along with PF core stats

2019-10-23 Thread Jeff Kirsher
From: Arkadiusz Grubba This change introduces the ability to display extended (enhanced) statistics for PF interfaces. The patch introduces new arrays defined for these extra stats (in i40e_ethtool.c file) and enhances/extends ethtool ops functions intended for dealing with PF stats (i.e.: i40e_

[net-next 00/11][pull request] 40GbE Intel Wired LAN Driver Updates 2019-10-23

2019-10-23 Thread Jeff Kirsher
This series contains updates to i40e only. Several are fixes that could go to 'net', but were intended for 'net-next'. Sylwia changes how the driver function to read the NVM module data, so that it is able to read the LLDP agent configuration to allow for persistent LLDP. Arkadiusz provides exte

[net-next 08/11] i40e: allow ethtool to report SW and FW versions in recovery mode

2019-10-23 Thread Jeff Kirsher
From: Piotr Kwapulinski Let ethtool print driver and firmware versions when NIC is in recovery mode. Assign i40e_get_drvinfo() operation to ethtool recovery mode operations. Previously ethtool did not report driver and firmware versions when NIC was in recovery mode. Signed-off-by: Piotr Kwapu

[net-next 05/11] i40e: Extend PHY access with page change flag

2019-10-23 Thread Jeff Kirsher
From: Piotr Azarewicz Currently FW use MDIO I/F number corresponded with current PF for PHY access. This code allow to specify used MDIO I/F number. Add new field - command flags with only one flag for now. Added flag tells FW that it shouldn't change page while accessing QSFP module, as it was

[net-next 06/11] i40e: remove the macro with it's argument reuse

2019-10-23 Thread Jeff Kirsher
From: Aleksandr Loktionov Remove macro and call i40e_update_vfid_in_stats() function directly to avoid checkpatch.pl complains about macro argument reuse and possible side effects. Signed-off-by: Aleksandr Loktionov Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- .../net/ethernet/in

[net-next 01/11] i40e: Fix for persistent lldp support

2019-10-23 Thread Jeff Kirsher
From: Sylwia Wnuczko This patch fixes function to read NVM module data and uses it to read current LLDP agent configuration from NVM API version 1.8. Signed-off-by: Sylwia Wnuczko Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_dcb.c| 4 +-

[net-next 04/11] i40e: Extract detection of HW flags into a function

2019-10-23 Thread Jeff Kirsher
From: Piotr Azarewicz Move code detecting HW flags based on device type and FW API version into a single function. Signed-off-by: Piotr Azarewicz Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_adminq.c | 71 +++ drivers/net/ether

[net-next 03/11] i40e: Wrong 'Advertised FEC modes' after set FEC to AUTO

2019-10-23 Thread Jeff Kirsher
From: Jaroslaw Gawin Fix display of parameters "Configured FEC encodings:" and "Advertised FEC modes:" in ethtool. Implemented by setting proper FEC bits in “advertising” bitmask of link_modes struct and “fec” bitmask in ethtool_fecparam struct. Without this patch wrong FEC settings can be shown

[net-next 10/11] i40e: Refactoring VF MAC filters counting to make more reliable

2019-10-23 Thread Jeff Kirsher
From: Aleksandr Loktionov This patch prepares ground for the next VF MAC address change fix. It lets untrusted VF to delete any VF mac filter, but it still doesn't let untrusted VF to add mac filter not setup by PF. It removes information duplication in num_mac mac filters counter. And improves e

[net-next 09/11] i40e: Fix LED blinking flow for X710T*L devices.

2019-10-23 Thread Jeff Kirsher
From: Damian Milosek Add X710T*L device specific operations (in port LED detection and handling of GLGEN_GPIO_CTL.PIN_FUNC field) to enable LED blinking. Signed-off-by: Damian Milosek Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_common.c | 29

Re: [PATCH v3 net-next 04/12] net: aquantia: add PTP rings infrastructure

2019-10-23 Thread kbuild test robot
Hi Igor, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Igor-Russkikh/net-aquantia-PTP-support-for-AQC-devices/20191023-194531 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net

Re: [Patch net-next 3/3] tcp: decouple TLP timer from RTO timer

2019-10-23 Thread Eric Dumazet
On Wed, Oct 23, 2019 at 10:40 AM Cong Wang wrote: > > On Tue, Oct 22, 2019 at 7:15 PM Eric Dumazet wrote: > > > > On Tue, Oct 22, 2019 at 6:10 PM Cong Wang wrote: > > > > > > On Tue, Oct 22, 2019 at 4:24 PM Eric Dumazet wrote: > > > > > > > > On Tue, Oct 22, 2019 at 4:11 PM Cong Wang > > > >

Re: [RFC 01/20] ice: Initialize and register multi-function device to provide RDMA

2019-10-23 Thread Jason Gunthorpe
On Wed, Oct 23, 2019 at 05:55:38PM +, Ertman, David M wrote: > > Did any resolution happen here? Dave, do you know what to do to get Greg's > > approval? > > > > Jason > > This was the last communication that I saw on this topic. I was taking > Greg's silence as > "Oh ok, that works" :) I

RE: [RFC 01/20] ice: Initialize and register multi-function device to provide RDMA

2019-10-23 Thread Ertman, David M
> -Original Message- > From: Jason Gunthorpe [mailto:j...@ziepe.ca] > Sent: Wednesday, October 23, 2019 10:45 AM > To: Ertman, David M > Cc: gre...@linuxfoundation.org; Nguyen, Anthony L > ; Kirsher, Jeffrey T > ; netdev@vger.kernel.org; linux- > r...@vger.kernel.org; dledf...@redhat.com >

Re: [RFC 01/20] ice: Initialize and register multi-function device to provide RDMA

2019-10-23 Thread Jason Gunthorpe
On Fri, Sep 27, 2019 at 06:03:51PM +, Ertman, David M wrote: > > From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > > Sent: Thursday, September 26, 2019 10:13 PM > > To: Nguyen, Anthony L > > Cc: Kirsher, Jeffrey T ; j...@mellanox.com; > > netdev@vger.kernel.org; linux-r...

Re: [Intel-wired-lan] FW: [PATCH bpf-next 2/4] xsk: allow AF_XDP sockets to receive packets directly from a queue

2019-10-23 Thread Alexei Starovoitov
On Tue, Oct 22, 2019 at 12:06 PM Samudrala, Sridhar wrote: > > OK. Here is another data point that shows the perf report with the same test > but CPU mitigations > turned OFF. Here bpf_prog overhead goes down from almost (10.18 + 4.51)% to > (3.23 + 1.44%). > >21.40% ksoftirqd/28 [i40e]

Re: [Patch net-next 3/3] tcp: decouple TLP timer from RTO timer

2019-10-23 Thread Cong Wang
On Tue, Oct 22, 2019 at 7:15 PM Eric Dumazet wrote: > > On Tue, Oct 22, 2019 at 6:10 PM Cong Wang wrote: > > > > On Tue, Oct 22, 2019 at 4:24 PM Eric Dumazet wrote: > > > > > > On Tue, Oct 22, 2019 at 4:11 PM Cong Wang > > > wrote: > > > > > > > > Currently RTO, TLP and PROBE0 all share a same

[PATCH net] cxgb4: request the TX CIDX updates to status page

2019-10-23 Thread Raju Rangoju
For adapters which support the SGE Doorbell Queue Timer facility, we configured the Ethernet TX Queues to send CIDX Updates to the Associated Ethernet RX Response Queue with CPL_SGE_EGR_UPDATE messages to allow us to respond more quickly to the CIDX Updates. But, this was adding load to PCIe Link R

Re: [PATCH bpf-next] selftests/bpf: fix LDLIBS order

2019-10-23 Thread Alexei Starovoitov
On 10/23/19 8:31 AM, Andrii Nakryiko wrote: > Order of $(LDLIBS) matters to linker, so put it after all the .o and .a > files. > > Fixes: 74b5a5968fe8 ("selftests/bpf: Replace test_progs and test_maps w/ > general rule") > Reported-by: Daniel Borkmann > Signed-off-by: Andrii Nakryiko Applied. Th

Re: [PATCH bpf-next] selftests/bpf: move test_section_names into test_progs and fix it

2019-10-23 Thread Alexei Starovoitov
On Tue, Oct 22, 2019 at 11:18 PM Andrii Nakryiko wrote: > > Make test_section_names into test_progs test. Also fix ESRCH expected > results. Add uprobe/uretprobe and tp/raw_tp test cases. > > Fixes: dd4436bb8383 ("libbpf: Teach bpf_object__open to guess program types") > Reported-by: kernel test r

Re: [PATCH bpf-next v3] libbpf: use implicit XSKMAP lookup from AF_XDP XDP program

2019-10-23 Thread Alexei Starovoitov
On Tue, Oct 22, 2019 at 12:35 AM Toke Høiland-Jørgensen wrote: > > Björn Töpel writes: > > > From: Björn Töpel > > > > In commit 43e74c0267a3 ("bpf_xdp_redirect_map: Perform map lookup in > > eBPF helper") the bpf_redirect_map() helper learned to do map lookup, > > which means that the explicit

[PATCH net] ipvs: move old_secure_tcp into struct netns_ipvs

2019-10-23 Thread Eric Dumazet
syzbot reported the following issue : BUG: KCSAN: data-race in update_defense_level / update_defense_level read to 0x861a6260 of 4 bytes by task 3006 on cpu 1: update_defense_level+0x621/0xb30 net/netfilter/ipvs/ip_vs_ctl.c:177 defense_work_handler+0x3d/0xd0 net/netfilter/ipvs/ip_vs_ctl

pull request: bluetooth-next 2019-10-23

2019-10-23 Thread Johan Hedberg
Hi Dave, Here's the main bluetooth-next pull request for the 5.5 kernel: - Multiple fixes to hci_qca driver - Fix for HCI_USER_CHANNEL initialization - btwlink: drop superseded driver - Add support for Intel FW download error recovery - Various other smaller fixes & improvements Please let

Re: [PATCH net] netns: fix GFP flags in rtnl_net_notifyid()

2019-10-23 Thread Nicolas Dichtel
Le 23/10/2019 à 18:39, Guillaume Nault a écrit : > In rtnl_net_notifyid(), we certainly can't pass a null GFP flag to > rtnl_notify(). A GFP_KERNEL flag would be fine in most circumstances, > but there are a few paths calling rtnl_net_notifyid() from atomic > context or from RCU critical sections.

[PATCH net] netns: fix GFP flags in rtnl_net_notifyid()

2019-10-23 Thread Guillaume Nault
In rtnl_net_notifyid(), we certainly can't pass a null GFP flag to rtnl_notify(). A GFP_KERNEL flag would be fine in most circumstances, but there are a few paths calling rtnl_net_notifyid() from atomic context or from RCU critical sections. The later also precludes the use of gfp_any() as it would

IPv6 test fail

2019-10-23 Thread Levente
Dear list, We are testing IPv6 again against the test specification of ipv6forum. https://www.ipv6ready.org/?page=documents&tag=ipv6-core-protocols The test house state that some certain packages doesn't arrive to the device under test. We fail test cases V6LC.1.2.2: No Next Header After Exten

Re: [PATCH iproute2] ipnetns: do not check netns NAME when -all is specified

2019-10-23 Thread Stephen Hemminger
On Tue, 22 Oct 2019 22:09:23 +0200 Michał Łyszczek wrote: > When `-all' argument is specified netns runs cmd on all namespaces > and NAME is not used, but netns nevertheless checks if argv[1] is a > valid namespace name ignoring the fact that argv[1] contains cmd > and not NAME. This results in b

[PATCH iproute2 0/3] remove old examples

2019-10-23 Thread Stephen Hemminger
Take the old stuff away. Stephen Hemminger (3): examples: remove out of date cbq stuff examples: remove gaiconf examples: remove diffserv examples/README.cbq | 122 - examples/SYN-DoS.rate.limit | 49 --- examples/cbqinit.eth1|

[PATCH iproute2 2/3] examples: remove gaiconf

2019-10-23 Thread Stephen Hemminger
The gaiconf script is a workaround for something now handled in distros as part of libc. Signed-off-by: Stephen Hemminger --- examples/gaiconf | 134 --- 1 file changed, 134 deletions(-) delete mode 100644 examples/gaiconf diff --git a/examples/gaico

[PATCH iproute2 3/3] examples: remove diffserv

2019-10-23 Thread Stephen Hemminger
The diffserv examples here are out of date and incomplete. Remove them rather than try and fix them. Signed-off-by: Stephen Hemminger --- examples/diffserv/Edge1 | 68 - examples/diffserv/Edge2 | 87 examples/diffserv/Edge31-ca-u32 | 170

[PATCH iproute2 1/3] examples: remove out of date cbq stuff

2019-10-23 Thread Stephen Hemminger
The examples around cbq are out of date and never updated. There are better ways to achieve same kind of thing with more modern qdisc. Signed-off-by: Stephen Hemminger --- examples/README.cbq | 122 examples/SYN-DoS.rate.limit | 49 --- e

Re: [patch iproute2-next v4 1/3] lib/ll_map: cache alternative names

2019-10-23 Thread Jiri Pirko
Wed, Oct 23, 2019 at 05:11:38PM CEST, dsah...@gmail.com wrote: >On 10/19/19 11:37 AM, Jiri Pirko wrote: >> +static void ll_altname_entries_destroy(struct ll_cache *parent_im) >> +{ >> +struct ll_cache *im; >> + >> +list_for_each_entry(im, &parent_im->altnames_list, altnames_list) >> +

Re: [PATCH net-next] phylink: add ASSERT_RTNL() on phylink connect functions

2019-10-23 Thread Ioana Ciornei
On 10/23/19 4:10 PM, Russell King - ARM Linux admin wrote: > On Wed, Oct 23, 2019 at 03:32:20PM +0300, Ioana Ciornei wrote: >> The appropriate assert on the rtnl lock is not present in phylink's >> connect functions which makes unusual calls to them not to be catched. >> Add the appropriate ASSERT_

Re: [PATCH net-next 0/9] devlink vdev

2019-10-23 Thread Or Gerlitz
On Tue, Oct 22, 2019 at 8:46 PM Yuval Avnery wrote: > This patchset introduces devlink vdev. > Currently, legacy tools do not provide a comprehensive solution that can > be used in both SmartNic and non-SmartNic mode. > Vdev represents a device that exists on the ASIC but is not necessarily > vis

Re: [PATCH] net: phy: smsc: LAN8740: add PHY_RST_AFTER_CLK_EN flag

2019-10-23 Thread Andrew Lunn
On Wed, Oct 23, 2019 at 11:44:24AM +0200, Martin Fuzzey wrote: > The LAN8740, like the 8720, also requires a reset after enabling clock. > The datasheet [1] 3.8.5.1 says: > "During a Hardware reset, an external clock must be supplied > to the XTAL1/CLKIN signal." > > I have observed th

[PATCH bpf-next] selftests/bpf: fix LDLIBS order

2019-10-23 Thread Andrii Nakryiko
Order of $(LDLIBS) matters to linker, so put it after all the .o and .a files. Fixes: 74b5a5968fe8 ("selftests/bpf: Replace test_progs and test_maps w/ general rule") Reported-by: Daniel Borkmann Signed-off-by: Andrii Nakryiko --- tools/testing/selftests/bpf/Makefile | 8 1 file chang

Re: [PATCH net-next 0/4] page_pool: API for numa node change handling

2019-10-23 Thread Or Gerlitz
On Tue, Oct 22, 2019 at 8:04 AM Saeed Mahameed wrote: > CPU: Intel(R) Xeon(R) CPU E5-2603 v4 @ 1.70GHz > NIC: Mellanox Technologies MT27700 Family [ConnectX-4] (100G) > > XDP Drop/TX single core: > NUMA | XDP | Before| After > --- > Close | Drop | 11 Mp

Re: [PATCH v15 4/5] tools/testing/selftests/bpf: Add self-tests for new helper.

2019-10-23 Thread Yonghong Song
On 10/23/19 7:42 AM, Carlos Antonio Neira Bustos wrote: > On Wed, Oct 23, 2019 at 03:02:51AM +, Yonghong Song wrote: >> >> >> On 10/22/19 12:17 PM, Carlos Neira wrote: >>> Self tests added for new helper >> >> Please mention the name of the new helper in the commit message. >> >>> >>> Signed-

[net-next v2] tcp: add TCP_INFO status for failed client TFO

2019-10-23 Thread Jason Baron
The TCPI_OPT_SYN_DATA bit as part of tcpi_options currently reports whether or not data-in-SYN was ack'd on both the client and server side. We'd like to gather more information on the client-side in the failure case in order to indicate the reason for the failure. This can be useful for not only d

Re: [patch iproute2-next v4 1/3] lib/ll_map: cache alternative names

2019-10-23 Thread David Ahern
On 10/19/19 11:37 AM, Jiri Pirko wrote: > +static void ll_altname_entries_destroy(struct ll_cache *parent_im) > +{ > + struct ll_cache *im; > + > + list_for_each_entry(im, &parent_im->altnames_list, altnames_list) > + ll_entry_destroy(im, false); you are walking a list and remo

Re: [PATCH net-next 00/13] Control action percpu counters allocation by netlink flag

2019-10-23 Thread Vlad Buslov
On Wed 23 Oct 2019 at 17:21, Jamal Hadi Salim wrote: > On 2019-10-23 9:04 a.m., Vlad Buslov wrote: >> >> On Wed 23 Oct 2019 at 15:49, Jamal Hadi Salim wrote: >>> Hi Vlad, >>> > >>> I understand your use case being different since it is for h/w >>> offload. If you have time can you test with bat

Re: [PATCH v15 4/5] tools/testing/selftests/bpf: Add self-tests for new helper.

2019-10-23 Thread Carlos Antonio Neira Bustos
On Wed, Oct 23, 2019 at 03:02:51AM +, Yonghong Song wrote: > > > On 10/22/19 12:17 PM, Carlos Neira wrote: > > Self tests added for new helper > > Please mention the name of the new helper in the commit message. > > > > > Signed-off-by: Carlos Neira > > LGTM Ack with a few nits below. >

Re: [PATCH net-next 00/13] Control action percpu counters allocation by netlink flag

2019-10-23 Thread Jamal Hadi Salim
On 2019-10-23 9:04 a.m., Vlad Buslov wrote: On Wed 23 Oct 2019 at 15:49, Jamal Hadi Salim wrote: Hi Vlad, I understand your use case being different since it is for h/w offload. If you have time can you test with batching many actions and seeing the before/after improvement? Will do. T

Re: [RFC PATCH v2 bpf-next 00/15] xdp_flow: Flow offload to XDP

2019-10-23 Thread Jamal Hadi Salim
Sorry - didnt read every detail of this thread so i may be missing something. On 2019-10-22 12:54 p.m., John Fastabend wrote: Toshiaki Makita wrote: On 2019/10/19 0:22, John Fastabend wrote: Toshiaki Makita wrote: This is a PoC for an idea to offload flow, i.e. TC flower and nftables, to XD

[PATCH net 1/2] net/smc: fix closing of fallback SMC sockets

2019-10-23 Thread Karsten Graul
From: Ursula Braun For SMC sockets forced to fallback to TCP, the file is propagated from the outer SMC to the internal TCP socket. When closing the SMC socket, the internal TCP socket file pointer must be restored to the original NULL value, otherwise memory leaks may show up (found with CONFIG_

[PATCH net 2/2] net/smc: keep vlan_id for SMC-R in smc_listen_work()

2019-10-23 Thread Karsten Graul
From: Ursula Braun Creating of an SMC-R connection with vlan-id fails, because smc_listen_work() determines the vlan_id of the connection, saves it in struct smc_init_info ini, but clears the ini area again if SMC-D is not applicable. This patch just resets the ISM device before investigating SMC

[PATCH net 0/2] net/smc: fixes for -net

2019-10-23 Thread Karsten Graul
Fixes for the net tree, covering a memleak when closing SMC fallback sockets and fix SMC-R connection establishment when vlan-ids are used. Ursula Braun (2): net/smc: fix closing of fallback SMC sockets net/smc: keep vlan_id for SMC-R in smc_listen_work() net/smc/af_smc.c | 9 - 1 fi

[PATCH v5] net: sch_generic: Use pfifo_fast as fallback scheduler for CAN hardware

2019-10-23 Thread Vincent Prince
There is networking hardware that isn't based on Ethernet for layers 1 and 2. For example CAN. CAN is a multi-master serial bus standard for connecting Electronic Control Units [ECUs] also known as nodes. A frame on the CAN bus carries up to 8 bytes of payload. Frame corruption is detected by a C

Re: [PATCH net-next v2 4/5] dpaa2-eth: add MAC/PHY support through phylink

2019-10-23 Thread Ioana Ciornei
On 10/23/19 3:47 PM, Ioana Ciornei wrote: > The dpaa2-eth driver now has support for connecting to its associated > PHY device found through standard OF bindings. > > This happens when the DPNI object (that the driver probes on) gets > connected to a DPMAC. When that happens, the device tree is lo

Mrs. Lisa Charity Donation

2019-10-23 Thread Mrs. Lisa
-- I am Lisa Robinson, you have a donation of $1,200,000.00 USD. Contact me now for more information.

Re: [PATCH net-next] phylink: add ASSERT_RTNL() on phylink connect functions

2019-10-23 Thread Russell King - ARM Linux admin
On Wed, Oct 23, 2019 at 03:32:20PM +0300, Ioana Ciornei wrote: > The appropriate assert on the rtnl lock is not present in phylink's > connect functions which makes unusual calls to them not to be catched. > Add the appropriate ASSERT_RTNL(). As I previously replied, this is not necessary. It is

Re: [PATCH net-next 00/13] Control action percpu counters allocation by netlink flag

2019-10-23 Thread Vlad Buslov
On Wed 23 Oct 2019 at 16:02, Jamal Hadi Salim wrote: > I shouldve read the thread backward. My earlier email was asking > similar question to Roman. > > On 2019-10-23 2:38 a.m., Vlad Buslov wrote: >> >> On Tue 22 Oct 2019 at 21:17, Roman Mashak wrote: > >> Hi Roman, >> >> I considered it, but d

Re: [PATCH net-next 00/13] Control action percpu counters allocation by netlink flag

2019-10-23 Thread Jamal Hadi Salim
I shouldve read the thread backward. My earlier email was asking similar question to Roman. On 2019-10-23 2:38 a.m., Vlad Buslov wrote: On Tue 22 Oct 2019 at 21:17, Roman Mashak wrote: Hi Roman, I considered it, but didn't find good way to implement my change with TCA_ROOT_FLAGS. I neede

Re: [PATCH net-next 00/13] Control action percpu counters allocation by netlink flag

2019-10-23 Thread Vlad Buslov
On Wed 23 Oct 2019 at 15:49, Jamal Hadi Salim wrote: > Hi Vlad, > > On 2019-10-22 10:17 a.m., Vlad Buslov wrote: >> Currently, significant fraction of CPU time during TC filter allocation >> is spent in percpu allocator. Moreover, percpu allocator is protected >> with single global mutex which n

Re: [PATCH bpf-next 2/3] libbpf: Support configurable pinning of maps from BTF annotations

2019-10-23 Thread Toke Høiland-Jørgensen
> You are worried about the case where an application should be able to > unpin the map before loading a new one so it doesn't get reused? No, I'm worried about the opposite: Someone running (the equivalent of) 'ip link set dev eth0 xdp off', and then wondering why all resources aren't freed. I d

[PATCH net-next v2 2/5] bus: fsl-mc: add the fsl_mc_get_endpoint function

2019-10-23 Thread Ioana Ciornei
Using the newly added fsl_mc_get_endpoint function a fsl-mc driver can find its associated endpoint (another object at the other link of a MC firmware link). The API will be used in the following patch in order to discover the connected DPMAC object of a DPNI. Also, the fsl_mc_device_lookup funct

Re: [PATCH net-next 00/13] Control action percpu counters allocation by netlink flag

2019-10-23 Thread Jamal Hadi Salim
Hi Vlad, On 2019-10-22 10:17 a.m., Vlad Buslov wrote: Currently, significant fraction of CPU time during TC filter allocation is spent in percpu allocator. Moreover, percpu allocator is protected with single global mutex which negates any potential to improve its performance by means of recent

[PATCH net-next v2 3/5] dpaa2-eth: update the TX frame queues on DPNI_IRQ_EVENT_ENDPOINT_CHANGED

2019-10-23 Thread Ioana Ciornei
Currently the function is called at every link up event, although the FQID values will only change when the DPNI is disconnected from the current object and reconnected to a different one. The patch also avoids the forward declaration of update_tx_fqids. Signed-off-by: Ioana Ciornei --- Changes

[PATCH net-next v2 5/5] net: documentation: add docs for MAC/PHY support in DPAA2

2019-10-23 Thread Ioana Ciornei
Add documentation file for the MAC/PHY support in the DPAA2 architecture. This describes the architecture and implementation of the interface between phylink and a DPAA2 network driver. Signed-off-by: Ioana Ciornei --- Changes in v2: - none .../device_drivers/freescale/dpaa2/index.rst |

[PATCH net-next v2 0/5] dpaa2-eth: add MAC/PHY support through phylink

2019-10-23 Thread Ioana Ciornei
The dpaa2-eth driver now has support for connecting to its associated PHY device found through standard OF bindings. The PHY interraction is handled by PHYLINK and even though, at the moment, only RGMII_* phy modes are supported by the driver, this is just the first step into adding the necessary c

[PATCH net-next v2 1/5] bus: fsl-mc: export device types present on the bus

2019-10-23 Thread Ioana Ciornei
Export all device types present on the fsl-mc bus in order to be able to actually use the is_fsl_mc_bus_*() functions from drivers on the bus. Signed-off-by: Ioana Ciornei --- Changes in v2: - patch added drivers/bus/fsl-mc/fsl-mc-bus.c | 10 ++ 1 file changed, 10 insertions(+) diff -

[PATCH net-next v2 4/5] dpaa2-eth: add MAC/PHY support through phylink

2019-10-23 Thread Ioana Ciornei
The dpaa2-eth driver now has support for connecting to its associated PHY device found through standard OF bindings. This happens when the DPNI object (that the driver probes on) gets connected to a DPMAC. When that happens, the device tree is looked up by the DPMAC ID, and the associated PHY bind

Re: [PATCH firmware] rtl_nic: add firmware files for RTL8153

2019-10-23 Thread Josh Boyer
On Tue, Oct 22, 2019 at 11:40 PM Hayes Wang wrote: > > This adds the firmware for Realtek RTL8153 Based USB Ethernet Adapters. > > 1. Fix compatible issue for Asmedia hub. > 2. Fix compatible issue for Compal platform. > 3. Fix sometimes the device is lost after rebooting. > 4. Improve the compati

[PATCH net-next] phylink: add ASSERT_RTNL() on phylink connect functions

2019-10-23 Thread Ioana Ciornei
The appropriate assert on the rtnl lock is not present in phylink's connect functions which makes unusual calls to them not to be catched. Add the appropriate ASSERT_RTNL(). Signed-off-by: Ioana Ciornei --- drivers/net/phy/phylink.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers

Re: [PATCH bpf-next 2/3] libbpf: Support configurable pinning of maps from BTF annotations

2019-10-23 Thread Daniel Borkmann
On 10/23/19 10:53 AM, Toke Høiland-Jørgensen wrote: Andrii Nakryiko writes: 4. Once pinned, map knows its pinned path, just use that, I don't see any reasonable use case where you'd want to override path just for unpinning. Well, unpinning may need to re-construct the pin path. E.g., applica

Re: [PATCHv2 1/1] net: forcedeth: add xmit_more support

2019-10-23 Thread Rain River
On Tue, Oct 22, 2019 at 5:38 PM Zhu Yanjun wrote: > > This change adds support for xmit_more based on the igb commit 6f19e12f6230 > ("igb: flush when in xmit_more mode and under descriptor pressure") and > commit 6b16f9ee89b8 ("net: move skb->xmit_more hint to softnet data") that > were made to ig

Re: [PATCH v4] net: sch_generic: Use pfifo_fast as fallback scheduler for CAN hardware

2019-10-23 Thread Dave Taht
On Wed, Oct 23, 2019 at 3:52 AM Vincent Prince wrote: > > There is networking hardware that isn't based on Ethernet for layers 1 and 2. > > For example CAN. > > CAN is a multi-master serial bus standard for connecting Electronic Control > Units [ECUs] also known as nodes. A frame on the CAN bus ca

Re: [PATCH net-next] netfilter: nf_conntrack: introduce conntrack limit per-zone

2019-10-23 Thread Florian Westphal
Tonghao Zhang wrote: > > openvswitch supports per zone limits already, using nf_conncount > > infrastructure. > This path limits the UNREPLIED conntrack entries. If we SYN flood one > zone, the zone will consume all entries in table, which state > SYN_SENT. > The openvswitch limits only the +est c

Re: [PATCH net-next] netfilter: nf_conntrack: introduce conntrack limit per-zone

2019-10-23 Thread Tonghao Zhang
On Wed, Oct 23, 2019 at 6:31 PM Florian Westphal wrote: > > xiangxia.m@gmail.com wrote: > > nf_conntrack_max is used to limit the maximum number of > > conntrack entries in the conntrack table for every network > > namespace. For the containers that reside in the same namespace, > > they shar

[PATCH v4] net: sch_generic: Use pfifo_fast as fallback scheduler for CAN hardware

2019-10-23 Thread Vincent Prince
There is networking hardware that isn't based on Ethernet for layers 1 and 2. For example CAN. CAN is a multi-master serial bus standard for connecting Electronic Control Units [ECUs] also known as nodes. A frame on the CAN bus carries up to 8 bytes of payload. Frame corruption is detected by a C

[PATCH iproute2-next 0/2] Add MR counters statistics

2019-10-23 Thread Leon Romanovsky
From: Leon Romanovsky Hi, This is supplementary part of "ODP information and statistics" kernel series. https://lore.kernel.org/linux-rdma/20191016062308.11886-1-l...@kernel.org Thanks Erez Alfasi (2): rdma: Add "stat show mr" support rdma: Document MR statistics man/man8/rdma-statistic.

[PATCH iproute2-next 2/2] rdma: Document MR statistics

2019-10-23 Thread Leon Romanovsky
From: Erez Alfasi Add document of accessing the MR counters into the rdma-statistic man pages. Signed-off-by: Erez Alfasi Signed-off-by: Leon Romanovsky --- man/man8/rdma-statistic.8 | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/man/man8/rdma-s

[PATCH iproute2-next 1/2] rdma: Add "stat show mr" support

2019-10-23 Thread Leon Romanovsky
From: Erez Alfasi Show MR counters statistics. Filters are also enabled. Examples: ~$: rdma stat show mr dev mlx5_0 mrn 8 page_faults 1221 page_invalidations 0 dev mlx5_0 mrn 9 page_faults 1221 page_invalidations 0 ~$: rdma stat show mr mrn 8 dev mlx5_0 mrn 8 page_faults 1221 page_invalidations

Re: [PATCH net-next] netfilter: nf_conntrack: introduce conntrack limit per-zone

2019-10-23 Thread Florian Westphal
xiangxia.m@gmail.com wrote: > nf_conntrack_max is used to limit the maximum number of > conntrack entries in the conntrack table for every network > namespace. For the containers that reside in the same namespace, > they share the same conntrack table, and the total # of conntrack > entries fo

Re: [PATCH v2] rtlwifi: Fix potential overflow on P2P code

2019-10-23 Thread Kalle Valo
Laura Abbott wrote: > Nicolas Waisman noticed that even though noa_len is checked for > a compatible length it's still possible to overrun the buffers > of p2pinfo since there's no check on the upper bound of noa_num. > Bound noa_num against P2P_MAX_NOA_NUM. > > Reported-by: Nicolas Waisman > S

[PATCH] net: phy: smsc: LAN8740: add PHY_RST_AFTER_CLK_EN flag

2019-10-23 Thread Martin Fuzzey
The LAN8740, like the 8720, also requires a reset after enabling clock. The datasheet [1] 3.8.5.1 says: "During a Hardware reset, an external clock must be supplied to the XTAL1/CLKIN signal." I have observed this issue on a custom i.MX6 based board with the LAN8740A. [1] http://w

Re: [PATCH net-next] r8152: support request_firmware for RTL8153

2019-10-23 Thread Marek Szyprowski
Hi Hayes, On 16.10.2019 05:02, Hayes Wang wrote: > This patch supports loading additional firmware file through > request_firmware(). > > A firmware file may include a header followed by several blocks > which have different types of firmware. Currently, the supported > types are RTL_FW_END, RTL_F

[PATCH net-next v3 3/7] dpaa_eth: remove redundant code

2019-10-23 Thread Madalin Bucur
Condition was previously checked, removing duplicate code. Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c index

[PATCH net-next v3 4/7] fsl/fman: add API to get the device behind a fman port

2019-10-23 Thread Madalin Bucur
From: Laurentiu Tudor Add an API that retrieves the 'struct device' that the specified FMan port probed against. The new API will be used in a subsequent patch that corrects the DMA devices used by the dpaa_eth driver. Signed-off-by: Laurentiu Tudor Signed-off-by: Madalin Bucur --- drivers/ne

[PATCH net-next v3 2/7] dpaa_eth: defer probing after qbman

2019-10-23 Thread Madalin Bucur
From: Laurentiu Tudor If the DPAA 1 Ethernet driver gets probed before the QBMan driver it will cause a boot crash. Add predictability in the probing order by deferring the Ethernet driver probe after QBMan and portals by using the recently introduced QBMan APIs. Signed-off-by: Laurentiu Tudor

[PATCH net-next v3 7/7] dpaa_eth: add newline in dev_err() msg

2019-10-23 Thread Madalin Bucur
Newline was missing at the end of the error message. Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.

  1   2   >