On 10/19/19 11:37 AM, Jiri Pirko wrote: > +static void ll_altname_entries_destroy(struct ll_cache *parent_im) > +{ > + struct ll_cache *im; > + > + list_for_each_entry(im, &parent_im->altnames_list, altnames_list) > + ll_entry_destroy(im, false);
you are walking a list and removing elements from it, so that should be list_for_each_entry_safe, no?