Re: [PATCH 2/2] net: dsa: microchip: Add shared regmap mutex

2019-10-12 Thread David Miller
From: David Miller Date: Sat, 12 Oct 2019 17:20:55 -0700 (PDT) > From: Marek Vasut > Date: Thu, 10 Oct 2019 20:25:08 +0200 > >> The KSZ driver uses one regmap per register width (8/16/32), each with >> it's own lock, but accessing the same set of registers. In theory, it >> is possible to creat

Re: [PATCH 1/2] net: dsa: microchip: Do not reinit mutexes on KSZ87xx

2019-10-12 Thread David Miller
From: Marek Vasut Date: Thu, 10 Oct 2019 20:25:07 +0200 > The KSZ87xx driver calls mutex_init() on mutexes already inited in > ksz_common.c ksz_switch_register(). Do not do it twice, drop the > reinitialization. > > Signed-off-by: Marek Vasut Applied.

Re: [PATCH 2/2] net: dsa: microchip: Add shared regmap mutex

2019-10-12 Thread David Miller
From: Marek Vasut Date: Thu, 10 Oct 2019 20:25:08 +0200 > The KSZ driver uses one regmap per register width (8/16/32), each with > it's own lock, but accessing the same set of registers. In theory, it > is possible to create a race condition between these regmaps, although > the underlying bus (S

Re: [net-next v3 3/7] mv88e6xxx: reject unsupported external timestamp flags

2019-10-12 Thread Richard Cochran
On Sat, Oct 12, 2019 at 07:36:31PM +, Keller, Jacob E wrote: > Right, so in practice, unless it supports both edges, it should reject > setting both RISING and FALLING together. Enforcing that now *could* break existing user space, but I wonder whether any programs would actually be affected.

Re: [Potential Spoof] [PATCH v2 bpf-next 0/2] selftests/bpf Makefile cleanup and fixes

2019-10-12 Thread Alexei Starovoitov
On Sat, Oct 12, 2019 at 12:25 AM Martin Lau wrote: > > On Fri, Oct 11, 2019 at 03:01:44PM -0700, Andrii Nakryiko wrote: > > Patch #1 enforces libbpf build to have bpf_helper_defs.h ready before test > > BPF > > programs are built. > > Patch #2 drops obsolete BTF/pahole detection logic from Makefi

Re: [PATCH net 2/2] dpaa2-eth: Fix TX FQID values

2019-10-12 Thread David Miller
From: Ioana Ciornei Date: Thu, 10 Oct 2019 19:19:47 +0300 > @@ -2533,6 +2536,45 @@ static int set_pause(struct dpaa2_eth_priv *priv) > return 0; > } > > +static void update_tx_fqids(struct dpaa2_eth_priv *priv) > +{ > + struct dpaa2_eth_fq *fq; > + struct dpni_queue queue; > +

Re: [PATCH net] r8169: fix jumbo packet handling on resume from suspend

2019-10-12 Thread Jakub Kicinski
On Fri, 11 Oct 2019 08:03:24 +0200, Heiner Kallweit wrote: > On 11.10.2019 01:36, Jakub Kicinski wrote: > > On Wed, 9 Oct 2019 20:55:48 +0200, Heiner Kallweit wrote: > >> Mariusz reported that invalid packets are sent after resume from > >> suspend if jumbo packets are active. It turned out that

Re: [PATCH V2 1/2] net: phy: micrel: Discern KSZ8051 and KSZ8795 PHYs

2019-10-12 Thread Heiner Kallweit
On 12.10.2019 22:58, Heiner Kallweit wrote: > On 10.10.2019 21:46, Marek Vasut wrote: >> The KSZ8051 PHY and the KSZ8794/KSZ8795/KSZ8765 switch share exactly the >> same PHY ID. Since KSZ8051 is higher in the ksphy_driver[] list of PHYs >> in the micrel PHY driver, it is used even with the KSZ87xx

Re: [PATCH V2 1/2] net: phy: micrel: Discern KSZ8051 and KSZ8795 PHYs

2019-10-12 Thread Heiner Kallweit
On 10.10.2019 21:46, Marek Vasut wrote: > The KSZ8051 PHY and the KSZ8794/KSZ8795/KSZ8765 switch share exactly the > same PHY ID. Since KSZ8051 is higher in the ksphy_driver[] list of PHYs > in the micrel PHY driver, it is used even with the KSZ87xx switch. This > is wrong, since the KSZ8051 config

Re: [PATCH net-next 2/3] vhost_net: user tap recvmsg api to access ptr ring

2019-10-12 Thread Michael S. Tsirkin
On Sat, Oct 12, 2019 at 10:53:56AM +0900, prashantbhole.li...@gmail.com wrote: > From: Prashant Bhole > > Currently vhost_net directly accesses ptr ring of tap driver to > fetch Rx packet pointers. In order to avoid it this patch modifies > tap driver's recvmsg api to do additional task of fetchi

Re: [PATCH net-next 0/3] vhost_net: access ptr ring using tap recvmsg

2019-10-12 Thread Michael S. Tsirkin
On Sat, Oct 12, 2019 at 03:57:21PM +0800, Jason Wang wrote: > > On 2019/10/12 上午9:53, prashantbhole.li...@gmail.com wrote: > > From: Prashant Bhole > > > > vhost_net needs to peek tun packet sizes to allocate virtio buffers. > > Currently it directly accesses tap ptr ring to do it. Jason Wang >

Re: [PATCH net-next] Change in Openvswitch to support MPLS label depth of 3 in ingress direction

2019-10-12 Thread Pravin Shelar
On Thu, Oct 10, 2019 at 8:34 PM Martin Varghese wrote: > > On Wed, Oct 09, 2019 at 08:29:51AM -0700, Pravin Shelar wrote: > > On Mon, Oct 7, 2019 at 9:41 PM Martin Varghese > > wrote: > > > > > > From: Martin Varghese > > > > > > The openvswitch was supporting a MPLS label depth of 1 in the ingr

Re: [PATCH net-next] Change in Openvswitch to support MPLS label depth of 3 in ingress direction

2019-10-12 Thread Pravin Shelar
On Wed, Oct 9, 2019 at 9:31 PM Martin Varghese wrote: > > On Wed, Oct 09, 2019 at 08:29:51AM -0700, Pravin Shelar wrote: > > On Mon, Oct 7, 2019 at 9:41 PM Martin Varghese > > wrote: > > > > > > From: Martin Varghese > > > > > > The openvswitch was supporting a MPLS label depth of 1 in the ingre

RE: [net-next v3 3/7] mv88e6xxx: reject unsupported external timestamp flags

2019-10-12 Thread Keller, Jacob E
> -Original Message- > From: Richard Cochran > Sent: Saturday, October 12, 2019 11:24 AM > To: Keller, Jacob E > Cc: netdev@vger.kernel.org; Intel Wired LAN > ; > Kirsher, Jeffrey T ; Brandon Streiff > > Subject: Re: [net-next v3 3/7] mv88e6xxx: reject unsupported external > timestamp f

Re: [PATCH v2 net-next 11/12] net: aquantia: add support for PIN funcs

2019-10-12 Thread Richard Cochran
On Tue, Oct 08, 2019 at 10:56:59AM +, Igor Russkikh wrote: > From: Dmitry Bezrukov > > Depending on FW configuration we can manage from 0 to 3 PINs for periodic > output > and from 0 to 1 ext ts PIN for getting TS for external event. > > Ext TS PIN functionality is implemented via periodic

Re: [PATCH net-next 0/4] PTP driver refactoring for SJA1105 DSA

2019-10-12 Thread Richard Cochran
On Sat, Oct 12, 2019 at 02:18:12AM +0300, Vladimir Oltean wrote: > This series creates a better separation between the driver core and the > PTP portion. Therefore, users who are not interested in PTP can get a > simpler and smaller driver by compiling it out. > > This is in preparation for furthe

Re: [PATCH net-next] net: sched: Avoid using yield() in a busy waiting loop

2019-10-12 Thread Sergei Shtylyov
Hello! On 10/11/2019 08:15 PM, Sebastian Andrzej Siewior wrote: > From: Marc Kleine-Budde > > With threaded interrupts enabled, the interrupt thread runs as SCHED_RR > with priority 50. If a user application with a higher priority preempts > the interrupt thread and tries to shutdown the networ

Re: [PATCH v2 net-next 09/12] net: aquantia: implement get_ts_info ethtool

2019-10-12 Thread Richard Cochran
On Tue, Oct 08, 2019 at 10:56:54AM +, Igor Russkikh wrote: > +static int aq_ethtool_get_ts_info(struct net_device *ndev, > + struct ethtool_ts_info *info) > +{ > + struct aq_nic_s *aq_nic = netdev_priv(ndev); > + > + ethtool_op_get_ts_info(ndev, info); > +

Re: [PATCH v2 net-next 03/12] net: aquantia: add basic ptp_clock callbacks

2019-10-12 Thread Richard Cochran
On Tue, Oct 08, 2019 at 10:56:40AM +, Igor Russkikh wrote: > diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_ptp.c > b/drivers/net/ethernet/aquantia/atlantic/aq_ptp.c > index d5a28904f708..ba1597bb6eab 100644 > --- a/drivers/net/ethernet/aquantia/atlantic/aq_ptp.c > +++ b/drivers/net/e

Re: [PATCH v2 net-next 01/12] net: aquantia: PTP skeleton declarations and callbacks

2019-10-12 Thread Richard Cochran
On Tue, Oct 08, 2019 at 10:56:36AM +, Igor Russkikh wrote: > +static struct ptp_clock_info aq_ptp_clock = { > + .owner = THIS_MODULE, > + .name = "atlantic ptp", > + .n_ext_ts = 0, > + .pps= 0, > + .n_per_out = 0, > + .n_pins

Re: [PATCH v2 net-next 01/12] net: aquantia: PTP skeleton declarations and callbacks

2019-10-12 Thread Richard Cochran
On Tue, Oct 08, 2019 at 10:56:36AM +, Igor Russkikh wrote: > diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_ptp.c > b/drivers/net/ethernet/aquantia/atlantic/aq_ptp.c > new file mode 100644 > index ..d5a28904f708 > --- /dev/null > +++ b/drivers/net/ethernet/aquantia/atlanti

Re: [net-next v3 7/7] renesas: reject unsupported external timestamp flags

2019-10-12 Thread Richard Cochran
On Thu, Sep 26, 2019 at 11:11:09AM -0700, Jacob Keller wrote: > Fix the renesas PTP support to explicitly reject any future flags that > get added to the external timestamp request ioctl. > > In order to maintain currently functioning code, this patch accepts all > three current flags. This is bec

Re: [net-next v3 6/7] mlx5: reject unsupported external timestamp flags

2019-10-12 Thread Richard Cochran
On Thu, Sep 26, 2019 at 11:11:08AM -0700, Jacob Keller wrote: > Fix the mlx5 core PTP support to explicitly reject any future flags that > get added to the external timestamp request ioctl. > > In order to maintain currently functioning code, this patch accepts all > three current flags. This is b

Re: [net-next v3 5/7] igb: reject unsupported external timestamp flags

2019-10-12 Thread Richard Cochran
On Thu, Sep 26, 2019 at 11:11:07AM -0700, Jacob Keller wrote: > Fix the igb PTP support to explicitly reject any future flags that > get added to the external timestamp request ioctl. > > In order to maintain currently functioning code, this patch accepts all > three current flags. This is because

Re: [net-next v3 4/7] dp83640: reject unsupported external timestamp flags

2019-10-12 Thread Richard Cochran
On Thu, Sep 26, 2019 at 11:11:06AM -0700, Jacob Keller wrote: > Fix the dp83640 PTP support to explicitly reject any future flags that > get added to the external timestamp request ioctl. > > In order to maintain currently functioning code, this patch accepts all > three current flags. This is bec

Re: [net-next v3 3/7] mv88e6xxx: reject unsupported external timestamp flags

2019-10-12 Thread Richard Cochran
On Thu, Sep 26, 2019 at 11:11:05AM -0700, Jacob Keller wrote: > Fix the mv88e6xxx PTP support to explicitly reject any future flags that > get added to the external timestamp request ioctl. > > In order to maintain currently functioning code, this patch accepts all > three current flags. This is b

Re: pull-request: bpf 2019-10-12

2019-10-12 Thread David Miller
From: Alexei Starovoitov Date: Sat, 12 Oct 2019 10:45:34 -0700 > The following pull-request contains BPF updates for your *net* tree. > > The main changes are: > > 1) a bunch of small fixes. Nothing critical. > > Please consider pulling these changes from: > > git://git.kernel.org/pub/scm/l

Re: [net-next v3 2/7] net: reject PTP periodic output requests with unsupported flags

2019-10-12 Thread Richard Cochran
On Thu, Sep 26, 2019 at 11:11:04AM -0700, Jacob Keller wrote: > Commit 823eb2a3c4c7 ("PTP: add support for one-shot output") introduced > a new flag for the PTP periodic output request ioctl. This flag is not > currently supported by any driver. > > Fix all drivers which implement the periodic out

pull-request: bpf 2019-10-12

2019-10-12 Thread Alexei Starovoitov
Hi David, The following pull-request contains BPF updates for your *net* tree. The main changes are: 1) a bunch of small fixes. Nothing critical. Please consider pulling these changes from: git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git Thanks a lot!

Re: [PATCH bpf] bpf: lwtunnel: fix reroute supplying invalid dst

2019-10-12 Thread Alexei Starovoitov
On Wed, Oct 9, 2019 at 1:31 AM Jiri Benc wrote: > > The dst in bpf_input() has lwtstate field set. As it is of the > LWTUNNEL_ENCAP_BPF type, lwtstate->data is struct bpf_lwt. When the bpf > program returns BPF_LWT_REROUTE, ip_route_input_noref is directly called on > this skb. This causes invalid

Re: [PATCH bpf] libbpf: fix compatibility for kernels without need_wakeup

2019-10-12 Thread Alexei Starovoitov
On Fri, Oct 11, 2019 at 1:58 PM John Fastabend wrote: > > Magnus Karlsson wrote: > > On Tue, Oct 8, 2019 at 9:29 PM John Fastabend > > wrote: > > > > > > Magnus Karlsson wrote: > > > > When the need_wakeup flag was added to AF_XDP, the format of the > > > > XDP_MMAP_OFFSETS getsockopt was extend

[patch net-next v2 2/2] mlxsw: spectrum: Add support for 400Gbps (50Gbps per lane) link modes

2019-10-12 Thread Jiri Pirko
From: Jiri Pirko Extend speed support with 400Gbps Signed-off-by: Jiri Pirko Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/reg.h | 1 + .../net/ethernet/mellanox/mlxsw/spectrum.c| 52 +++ 2 files changed, 43 insertions(+), 10 deletions(-) diff -

[patch net-next v2 0/2] mlxsw: Add support for 400Gbps (50Gbps per lane) link modes

2019-10-12 Thread Jiri Pirko
From: Jiri Pirko Add 400Gbps bits to ethtool and introduce support in mlxsw. These modes are supported by the Spectrum-2 switch ASIC. Jiri Pirko (2): ethtool: Add support for 400Gbps (50Gbps per lane) link modes mlxsw: spectrum: Add support for 400Gbps (50Gbps per lane) link modes drivers/

[patch net-next v2 1/2] ethtool: Add support for 400Gbps (50Gbps per lane) link modes

2019-10-12 Thread Jiri Pirko
From: Jiri Pirko Add support for 400Gbps speed, link modes of 50Gbps per lane Signed-off-by: Jiri Pirko Signed-off-by: Ido Schimmel --- v1->v2: - added patch description --- drivers/net/phy/phy-core.c | 10 +- include/uapi/linux/ethtool.h | 6 ++ 2 files changed, 15 insertions(

Re: [PATCH iproute2] testsuite: don't clobber /tmp

2019-10-12 Thread Matteo Croce
On Tue, Jun 25, 2019 at 4:39 PM Matteo Croce wrote: > > On Thu, Jun 13, 2019 at 7:15 PM Matteo Croce wrote: > > > > On Wed, Jun 12, 2019 at 8:20 PM Stephen Hemminger > > wrote: > > > > To me any path could work, both /tmp or in the current dir, I have no > > preference. > > The important thing i

Re: [PATCH net v2 0/2] net/sched: fix wrong behavior of MPLS push/pop action

2019-10-12 Thread Simon Horman
On Sat, Oct 12, 2019 at 01:55:05PM +0200, Davide Caratti wrote: > this series contains two fixes for TC 'act_mpls', that try to address > two problems that can be observed configuring simple 'push' / 'pop' > operations: > - patch 1/2 avoids dropping non-MPLS packets that pass through the MPLS > '

[PATCH net v2 2/2] net/sched: fix corrupted L2 header with MPLS 'push' and 'pop' actions

2019-10-12 Thread Davide Caratti
the following script: # tc qdisc add dev eth0 clsact # tc filter add dev eth0 egress protocol ip matchall \ > action mpls push protocol mpls_uc label 0x355aa bos 1 causes corruption of all IP packets transmitted by eth0. On TC egress, we can't rely on the value of skb->mac_len, because it's 0

[PATCH net v2 0/2] net/sched: fix wrong behavior of MPLS push/pop action

2019-10-12 Thread Davide Caratti
this series contains two fixes for TC 'act_mpls', that try to address two problems that can be observed configuring simple 'push' / 'pop' operations: - patch 1/2 avoids dropping non-MPLS packets that pass through the MPLS 'pop' action. - patch 2/2 fixes corruption of the L2 header that occurs whe

[PATCH net v2 1/2] net: avoid errors when trying to pop MLPS header on non-MPLS packets

2019-10-12 Thread Davide Caratti
the following script: # tc qdisc add dev eth0 clsact # tc filter add dev eth0 egress matchall action mpls pop implicitly makes the kernel drop all packets transmitted by eth0, if they don't have a MPLS header. This behavior is uncommon: other encapsulations (like VLAN) just let the packet pass

Re: [PATCH net-next 0/3] vhost_net: access ptr ring using tap recvmsg

2019-10-12 Thread Jason Wang
On 2019/10/12 上午9:53, prashantbhole.li...@gmail.com wrote: From: Prashant Bhole vhost_net needs to peek tun packet sizes to allocate virtio buffers. Currently it directly accesses tap ptr ring to do it. Jason Wang suggested to achieve this using msghdr->msg_control and modifying the behavior

Re: [PATCH net-next 2/3] vhost_net: user tap recvmsg api to access ptr ring

2019-10-12 Thread Jason Wang
On 2019/10/12 上午9:53, prashantbhole.li...@gmail.com wrote: From: Prashant Bhole Currently vhost_net directly accesses ptr ring of tap driver to fetch Rx packet pointers. In order to avoid it this patch modifies tap driver's recvmsg api to do additional task of fetching Rx packet pointers. A

Re: [PATCH net-next 1/3] tuntap: reorganize tun_msg_ctl usage

2019-10-12 Thread Jason Wang
On 2019/10/12 上午9:53, prashantbhole.li...@gmail.com wrote: From: Prashant Bhole In order to extend the usage of tun_msg_ctl structure, this patch changes the member name from type to cmd. Also following definitions are changed: TUN_MSG_PTR : TUN_CMD_BATCH TUN_MSG_UBUF: TUN_CMD_PACKET Not a

Re: [Potential Spoof] [PATCH v2 bpf-next 0/2] selftests/bpf Makefile cleanup and fixes

2019-10-12 Thread Martin Lau
On Fri, Oct 11, 2019 at 03:01:44PM -0700, Andrii Nakryiko wrote: > Patch #1 enforces libbpf build to have bpf_helper_defs.h ready before test BPF > programs are built. > Patch #2 drops obsolete BTF/pahole detection logic from Makefile. Acked-by: Martin KaFai Lau