On Thu, Sep 26, 2019 at 11:11:08AM -0700, Jacob Keller wrote: > Fix the mlx5 core PTP support to explicitly reject any future flags that > get added to the external timestamp request ioctl. > > In order to maintain currently functioning code, this patch accepts all > three current flags. This is because the PTP_RISING_EDGE and > PTP_FALLING_EDGE flags have unclear semantics and each driver seems to > have interpreted them slightly differently.
I'm not 100% sure what this driver does, but if I'm not wrong it follows the dp83640: flags Meaning ---------------------------------------------------- -------------------------- PTP_ENABLE_FEATURE Time stamp rising edge PTP_ENABLE_FEATURE|PTP_RISING_EDGE Time stamp rising edge PTP_ENABLE_FEATURE|PTP_FALLING_EDGE Time stamp falling edge PTP_ENABLE_FEATURE|PTP_RISING_EDGE|PTP_FALLING_EDGE Time stamp falling edge > Cc: Feras Daoud <fera...@mellanox.com> > Cc: Eugenia Emantayev <euge...@mellanox.com> > Signed-off-by: Jacob Keller <jacob.e.kel...@intel.com> Reviewed-by: Richard Cochran <richardcoch...@gmail.com>
