Re: samples/bpf not working?

2019-10-05 Thread Andrii Nakryiko
On Sat, Oct 5, 2019 at 12:24 PM Eric Sage wrote: > > 394053f4a4b3 ("kbuild: make single targets work more correctly") > changed the way single target builds work. For example, > 'make samples/bpf/' in the previous commit matched: > > Makefile:1787 > %/: prepare FORCE > $(Q)$(MAKE) KBUILD_MODULES

Re: [PATCH bpf-next 03/10] bpf: process in-kernel BTF

2019-10-05 Thread Andrii Nakryiko
On Fri, Oct 4, 2019 at 10:08 PM Alexei Starovoitov wrote: > > If in-kernel BTF exists parse it and prepare 'struct btf *btf_vmlinux' > for further use by the verifier. > In-kernel BTF is trusted just like kallsyms and other build artifacts > embedded into vmlinux. > Yet run this BTF image through

[PATCH net-next 4/5] mlxsw: core: Push minor/subminor fw version check into helper

2019-10-05 Thread Ido Schimmel
From: Vadim Pasternak Add new API for FW "minor" and "subminor" version validation for sharing it between "spectrum" and "minimal" drivers. Use it in "spectrum" driver. Signed-off-by: Vadim Pasternak Acked-by: Jiri Pirko Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/cor

[PATCH net-next 1/5] mlxsw: reg: Extend MGPIR register with new field exposing the number of QSFP modules

2019-10-05 Thread Ido Schimmel
From: Vadim Pasternak Extend MGPIR - Management General Peripheral Information Register with new field "num_of_modules" exposing the number of modules supported by specific system. Signed-off-by: Vadim Pasternak Acked-by: Jiri Pirko Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellan

[PATCH net-next 3/5] mlxsw: thermal: Provide optimization for QSFP modules number detection

2019-10-05 Thread Ido Schimmel
From: Vadim Pasternak Use new field "num_of_modules" of MGPIR register for "thermal" interface in order to get the number of modules supported by system directly from the system configuration, instead of getting it from port to module mapping info. Signed-off-by: Vadim Pasternak Acked-by: Jiri

[PATCH net-next 2/5] mlxsw: hwmon: Provide optimization for QSFP modules number detection

2019-10-05 Thread Ido Schimmel
From: Vadim Pasternak Use new field "num_of_modules" of MGPIR register for "hwmon" interface in order to get the number of modules supported by system directly from the system configuration, instead of getting it from port to module mapping info. Reading this info through MGPIR register is faste

[PATCH net-next 0/5] mlxsw: Query number of modules from firmware

2019-10-05 Thread Ido Schimmel
From: Ido Schimmel Vadim says: The patchset adds support for a new field "num_of_modules" of Management General Peripheral Information Register (MGPIR), providing the maximum number of QSFP modules, which can be supported by the system. It allows to obtain the number of QSFP modules directly fr

[PATCH net-next 5/5] mlxsw: minimal: Add validation for FW version

2019-10-05 Thread Ido Schimmel
From: Vadim Pasternak Add validation for FW version in order to prevent driver initialization in case FW version is older than expected. FW version validation is necessary, because use of a new field 'num_of_modules' in MGPIR register is not backward compatible. FW 'minor' and 'subminor' versions

[patch net-next 0/2] netdevsim: allow to test reload failures

2019-10-05 Thread Jiri Pirko
From: Jiri Pirko Allow user to test devlink reload failures: Fail to reload and fail during reload. Jiri Pirko (2): netdevsim: add couple of debugfs bools to debug devlink reload selftests: test netdevsim reload forbid and fail drivers/net/netdevsim/dev.c | 20 +++

[patch net-next 2/2] selftests: test netdevsim reload forbid and fail

2019-10-05 Thread Jiri Pirko
From: Jiri Pirko Extend netdevsim reload test by simulation of failures. Signed-off-by: Jiri Pirko --- .../drivers/net/netdevsim/devlink.sh | 24 +++ 1 file changed, 24 insertions(+) diff --git a/tools/testing/selftests/drivers/net/netdevsim/devlink.sh b/tools/testin

[patch net-next 1/2] netdevsim: add couple of debugfs bools to debug devlink reload

2019-10-05 Thread Jiri Pirko
From: Jiri Pirko Add flag to disallow reload and another one that causes reload to always fail. Signed-off-by: Jiri Pirko --- drivers/net/netdevsim/dev.c | 20 drivers/net/netdevsim/netdevsim.h | 2 ++ 2 files changed, 22 insertions(+) diff --git a/drivers/net/netd

[PATCH v3 bpf-next 2/3] scripts/bpf: teach bpf_helpers_doc.py to dump BPF helper definitions

2019-10-05 Thread Andrii Nakryiko
Enhance scripts/bpf_helpers_doc.py to emit C header with BPF helper definitions (to be included from libbpf's bpf_helpers.h). Signed-off-by: Andrii Nakryiko --- scripts/bpf_helpers_doc.py | 155 - 1 file changed, 154 insertions(+), 1 deletion(-) diff --git a/

[PATCH v3 bpf-next 0/3] Auto-generate list of BPF helpers

2019-10-05 Thread Andrii Nakryiko
This patch set adds ability to auto-generate list of BPF helper definitions. It relies on existing scripts/bpf_helpers_doc.py and include/uapi/linux/bpf.h having a well-defined set of comments. bpf_helper_defs.h contains all BPF helper signatures which stay in sync with latest bpf.h UAPI. This auto

[PATCH v3 bpf-next 3/3] libbpf: auto-generate list of BPF helper definitions

2019-10-05 Thread Andrii Nakryiko
Get rid of list of BPF helpers in bpf_helpers.h (irony...) and auto-generate it into bpf_helpers_defs.h, which is now included from bpf_helpers.h. Suggested-by: Alexei Starovoitov Signed-off-by: Andrii Nakryiko --- tools/lib/bpf/.gitignore| 1 + tools/lib/bpf/Makefile | 10 +- tools

[PATCH v3 bpf-next 1/3] uapi/bpf: fix helper docs

2019-10-05 Thread Andrii Nakryiko
Various small fixes to BPF helper documentation comments, enabling automatic header generation with a list of BPF helpers. Signed-off-by: Andrii Nakryiko --- include/uapi/linux/bpf.h | 32 tools/include/uapi/linux/bpf.h | 32

Re: [PATCH v2 bpf-next 2/3] scripts/bpf: teach bpf_helpers_doc.py to dump BPF helper definitions

2019-10-05 Thread Andrii Nakryiko
On Sat, Oct 5, 2019 at 9:21 PM Alexei Starovoitov wrote: > > On 10/5/19 8:20 PM, Andrii Nakryiko wrote: > > Enhance scripts/bpf_helpers_doc.py to emit C header with BPF helper > > definitions (to be included from libbpf's bpf_helpers.h). > > > > Signed-off-by: Andrii Nakryiko > > --- > > scripts

Re: [PATCH v2 bpf-next 2/3] scripts/bpf: teach bpf_helpers_doc.py to dump BPF helper definitions

2019-10-05 Thread Alexei Starovoitov
On 10/5/19 8:20 PM, Andrii Nakryiko wrote: > Enhance scripts/bpf_helpers_doc.py to emit C header with BPF helper > definitions (to be included from libbpf's bpf_helpers.h). > > Signed-off-by: Andrii Nakryiko > --- > scripts/bpf_helpers_doc.py | 155 +- > tools/lib/bpf/bpf_helper_defs.h |

RE: [PATCH bpf-next 02/10] bpf: add typecast to bpf helpers to help BTF generation

2019-10-05 Thread John Fastabend
Alexei Starovoitov wrote: > When pahole converts dwarf to btf it emits only used types. > Wrap existing bpf helper functions into typedef and use it in > typecast to make gcc emits this type into dwarf. > Then pahole will convert it to btf. > The "btf_#name_of_helper" types will be used to figure o

RE: [PATCH bpf-next 01/10] bpf: add typecast to raw_tracepoints to help BTF generation

2019-10-05 Thread John Fastabend
Alexei Starovoitov wrote: > When pahole converts dwarf to btf it emits only used types. > Wrap existing __bpf_trace_##template() function into > btf_trace_##template typedef and use it in type cast to > make gcc emits this type into dwarf. Then pahole will convert it to btf. > The "btf_trace_" pref

Re: [PATCH bpf-next v2 1/5] bpf: Support injecting chain calls into BPF programs on load

2019-10-05 Thread Jakub Kicinski
On Sat, 05 Oct 2019 12:29:14 +0200, Toke Høiland-Jørgensen wrote: > >> +static int bpf_inject_chain_calls(struct bpf_verifier_env *env) > >> +{ > >> + struct bpf_prog *prog = env->prog; > >> + struct bpf_insn *insn = prog->insnsi; > >> + int i, cnt, delta = 0, ret = -ENOMEM; > >> + const int in

[PATCH v2 bpf-next 0/3] Auto-generate list of BPF helpers

2019-10-05 Thread Andrii Nakryiko
This patch set adds ability to auto-generate list of BPF helper definitions. It relies on existing scripts/bpf_helpers_doc.py and include/uapi/linux/bpf.h having a well-defined set of comments. bpf_helper_defs.h contains all BPF helper signatures which stay in sync with latest bpf.h UAPI. This auto

[PATCH v2 bpf-next 3/3] libbpf: auto-generate list of BPF helper definitions

2019-10-05 Thread Andrii Nakryiko
Get rid of list of BPF helpers in bpf_helpers.h (irony...) and auto-generate it into bpf_helpers_defs.h, which is now included from bpf_helpers.h. Suggested-by: Alexei Starovoitov Signed-off-by: Andrii Nakryiko --- tools/lib/bpf/.gitignore|1 + tools/lib/bpf/Makefile | 10

[PATCH v2 bpf-next 2/3] scripts/bpf: teach bpf_helpers_doc.py to dump BPF helper definitions

2019-10-05 Thread Andrii Nakryiko
Enhance scripts/bpf_helpers_doc.py to emit C header with BPF helper definitions (to be included from libbpf's bpf_helpers.h). Signed-off-by: Andrii Nakryiko --- scripts/bpf_helpers_doc.py | 155 +- tools/lib/bpf/bpf_helper_defs.h | 2677 +++ 2 files changed, 283

[PATCH v2 bpf-next 1/3] uapi/bpf: fix helper docs

2019-10-05 Thread Andrii Nakryiko
Various small fixes to BPF helper documentation comments, enabling automatic header generation with a list of BPF helpers. Signed-off-by: Andrii Nakryiko --- include/uapi/linux/bpf.h | 32 tools/include/uapi/linux/bpf.h | 32

[ipsec-next:testing 7/8] include/net/espintcp.h:36:20: sparse: sparse: incorrect type in return expression (different address spaces)

2019-10-05 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next.git testing head: 5374d99ba41893b4bb1ddbe35a88b1f08e860903 commit: 735de2631f8680ac714df1ecc8e052785e9f9f8e [7/8] xfrm: add espintcp (RFC 8229) reproduce: # apt-get install sparse # sparse version: v0.6.

Re: [PATCH v3 bpf-next 2/4] libbpf: add bpf_object__open_{file,mem} w/ extensible opts

2019-10-05 Thread Andrii Nakryiko
On Sat, Oct 5, 2019 at 6:24 PM Alexei Starovoitov wrote: > > On Fri, Oct 04, 2019 at 03:40:35PM -0700, Andrii Nakryiko wrote: > > Add new set of bpf_object__open APIs using new approach to optional > > parameters extensibility allowing simpler ABI compatibility approach. > > > > This patch demonst

Re: [PATCH bpf-next 3/3] libbpf: auto-generate list of BPF helper definitions

2019-10-05 Thread Andrii Nakryiko
On Sat, Oct 5, 2019 at 6:01 PM Alexei Starovoitov wrote: > > On 10/5/19 11:24 AM, Andrii Nakryiko wrote: > > On Sat, Oct 5, 2019 at 10:10 AM Alexei Starovoitov wrote: > >> > >> On 10/5/19 12:59 AM, Andrii Nakryiko wrote: > >>> Get rid of list of BPF helpers in bpf_helpers.h (irony...) and > >>> a

Re: [PATCH bpf-next v2] libbpf: Add cscope and tags targets to Makefile

2019-10-05 Thread Alexei Starovoitov
On Fri, Oct 4, 2019 at 8:36 AM Toke Høiland-Jørgensen wrote: > > Using cscope and/or TAGS files for navigating the source code is useful. > Add simple targets to the Makefile to generate the index files for both > tools. > > Acked-by: Andrii Nakryiko > Tested-by: Andrii Nakryiko > Signed-off-by:

Re: [PATCH v3 bpf-next 2/4] libbpf: add bpf_object__open_{file,mem} w/ extensible opts

2019-10-05 Thread Alexei Starovoitov
On Fri, Oct 04, 2019 at 03:40:35PM -0700, Andrii Nakryiko wrote: > Add new set of bpf_object__open APIs using new approach to optional > parameters extensibility allowing simpler ABI compatibility approach. > > This patch demonstrates an approach to implementing libbpf APIs that > makes it easy to

Re: [PATCH bpf-next] libbpf: fix BTF-defined map's __type macro handling of arrays

2019-10-05 Thread Alexei Starovoitov
On Fri, Oct 4, 2019 at 1:10 AM Andrii Nakryiko wrote: > > Due to a quirky C syntax of declaring pointers to array or function > prototype, existing __type() macro doesn't work with map key/value types > that are array or function prototype. One has to create a typedef first > and use it to specify

Re: [PATCH bpf-next 3/3] libbpf: auto-generate list of BPF helper definitions

2019-10-05 Thread Alexei Starovoitov
On 10/5/19 11:24 AM, Andrii Nakryiko wrote: > On Sat, Oct 5, 2019 at 10:10 AM Alexei Starovoitov wrote: >> >> On 10/5/19 12:59 AM, Andrii Nakryiko wrote: >>> Get rid of list of BPF helpers in bpf_helpers.h (irony...) and >>> auto-generate it into bpf_helpers_defs.h, which is now included from >>>

Re: [patch net-next 0/3] create netdevsim instances in namespace

2019-10-05 Thread David Miller
From: Jiri Pirko Date: Sat, 5 Oct 2019 08:10:30 +0200 > From: Jiri Pirko > > Allow user to create netdevsim devlink and netdevice instances in a > network namespace according to the namespace where the user resides in. > Add a selftest to test this. Series applied.

Re: [PATCH net-next 0/6] net/tls: add ctrl path tracing and statistics

2019-10-05 Thread David Miller
From: Jakub Kicinski Date: Fri, 4 Oct 2019 16:19:21 -0700 > This set adds trace events related to TLS offload and basic MIB stats > for TLS. Series applied, thanks Jakub.

Re: [RFC 04/20] RDMA/irdma: Add driver framework definitions

2019-10-05 Thread Jason Gunthorpe
On Fri, Oct 04, 2019 at 05:46:15PM -0700, Jeff Kirsher wrote: > On Fri, 2019-10-04 at 23:45 +, Jason Gunthorpe wrote: > > On Fri, Oct 04, 2019 at 01:12:22PM -0700, Jeff Kirsher wrote: > > > > > > > + if (ldev->version.major != I40E_CLIENT_VERSION_MAJOR || > > > > > + ldev->version.

Re: [PATCH 2/7] net: mvneta: introduce page pool API for sw buffer manager

2019-10-05 Thread Ilias Apalodimas
Hi Lorenzo, On Sat, Oct 05, 2019 at 10:44:35PM +0200, Lorenzo Bianconi wrote: > Use the page_pool api for allocations and DMA handling instead of > __dev_alloc_page()/dma_map_page() and free_page()/dma_unmap_page(). > Pages are unmapped using page_pool_release_page before packets > go into the ne

Re: [PATCH 0/7] add XDP support to mvneta driver

2019-10-05 Thread Lorenzo Bianconi
> > Add XDP support to mvneta driver for devices that rely on software > buffer management. Supported verdicts are: > - XDP_DROP > - XDP_PASS > - XDP_REDIRECT > - XDP_TX > Moreover set ndo_xdp_xmit net_device_ops function pointer in order to support > redirecting from other device (e.g. virtio-net)

[PATCH 6/7] net: mvneta: make tx buffer array agnostic

2019-10-05 Thread Lorenzo Bianconi
Allow tx buffer array to contain both skb and xdp buffers in order to enable xdp frame recycling adding XDP_TX verdict support Signed-off-by: Lorenzo Bianconi --- drivers/net/ethernet/marvell/mvneta.c | 66 +-- 1 file changed, 43 insertions(+), 23 deletions(-) diff --git

[PATCH 3/7] net: mvneta: rely on build_skb in mvneta_rx_swbm poll routine

2019-10-05 Thread Lorenzo Bianconi
Refactor mvneta_rx_swbm code introducing mvneta_swbm_rx_frame and mvneta_swbm_add_rx_fragment routines. Rely on build_skb in order to allocate skb since the previous patch introduced buffer recycling using the page_pool API Tested-by: Ilias Apalodimas Signed-off-by: Ilias Apalodimas Signed-off-b

[PATCH 7/7] net: mvneta: add XDP_TX support

2019-10-05 Thread Lorenzo Bianconi
Implement XDP_TX verdict and ndo_xdp_xmit net_device_ops function pointer Signed-off-by: Lorenzo Bianconi --- drivers/net/ethernet/marvell/mvneta.c | 126 -- 1 file changed, 119 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/n

[PATCH 5/7] net: mvneta: move header prefetch in mvneta_swbm_rx_frame

2019-10-05 Thread Lorenzo Bianconi
Move data buffer prefetch in mvneta_swbm_rx_frame after dma_sync_single_range_for_cpu Tested-by: Ilias Apalodimas Signed-off-by: Ilias Apalodimas Signed-off-by: Jesper Dangaard Brouer Signed-off-by: Lorenzo Bianconi --- drivers/net/ethernet/marvell/mvneta.c | 16 1 file chang

[PATCH 1/7] net: mvneta: introduce mvneta_update_stats routine

2019-10-05 Thread Lorenzo Bianconi
Introduce mvneta_update_stats routine to collect {rx/tx} statistics (packets and bytes). This is a preliminary patch to add XDP support to mvneta driver Signed-off-by: Lorenzo Bianconi --- drivers/net/ethernet/marvell/mvneta.c | 41 +-- 1 file changed, 20 insertions(+), 2

[PATCH 2/7] net: mvneta: introduce page pool API for sw buffer manager

2019-10-05 Thread Lorenzo Bianconi
Use the page_pool api for allocations and DMA handling instead of __dev_alloc_page()/dma_map_page() and free_page()/dma_unmap_page(). Pages are unmapped using page_pool_release_page before packets go into the network stack. The page_pool API offers buffer recycling capabilities for XDP but allocat

[PATCH 4/7] net: mvneta: add basic XDP support

2019-10-05 Thread Lorenzo Bianconi
Add basic XDP support to mvneta driver for devices that rely on software buffer management. Currently supported verdicts are: - XDP_DROP - XDP_PASS - XDP_REDIRECT - XDP_ABORTED Tested-by: Ilias Apalodimas Signed-off-by: Lorenzo Bianconi --- drivers/net/ethernet/marvell/mvneta.c | 146 ++

[PATCH 0/7] add XDP support to mvneta driver

2019-10-05 Thread Lorenzo Bianconi
Add XDP support to mvneta driver for devices that rely on software buffer management. Supported verdicts are: - XDP_DROP - XDP_PASS - XDP_REDIRECT - XDP_TX Moreover set ndo_xdp_xmit net_device_ops function pointer in order to support redirecting from other device (e.g. virtio-net). Convert mvneta d

Re: samples/bpf not working?

2019-10-05 Thread Eric Sage
394053f4a4b3 ("kbuild: make single targets work more correctly") changed the way single target builds work. For example, 'make samples/bpf/' in the previous commit matched: Makefile:1787 %/: prepare FORCE $(Q)$(MAKE) KBUILD_MODULES=1 $(build)=$(build-dir) need-modorder=1 So that 'samples/bpf/Ma

Re: [PATCH bpf-next 02/10] bpf: add typecast to bpf helpers to help BTF generation

2019-10-05 Thread Andrii Nakryiko
On Fri, Oct 4, 2019 at 10:05 PM Alexei Starovoitov wrote: > > When pahole converts dwarf to btf it emits only used types. > Wrap existing bpf helper functions into typedef and use it in > typecast to make gcc emits this type into dwarf. > Then pahole will convert it to btf. > The "btf_#name_of_hel

Re: [PATCH bpf-next 01/10] bpf: add typecast to raw_tracepoints to help BTF generation

2019-10-05 Thread Andrii Nakryiko
On Fri, Oct 4, 2019 at 10:05 PM Alexei Starovoitov wrote: > > When pahole converts dwarf to btf it emits only used types. > Wrap existing __bpf_trace_##template() function into > btf_trace_##template typedef and use it in type cast to > make gcc emits this type into dwarf. Then pahole will convert

Re: [PATCH bpf-next v2 1/2] bpf/flow_dissector: add mode to enforce global BPF flow dissector

2019-10-05 Thread Andrii Nakryiko
On Fri, Oct 4, 2019 at 8:58 AM Stanislav Fomichev wrote: > > Always use init_net flow dissector BPF program if it's attached and fall > back to the per-net namespace one. Also, deny installing new programs if > there is already one attached to the root namespace. > Users can still detach their BPF

Re: samples/bpf not working?

2019-10-05 Thread Andrii Nakryiko
On Fri, Oct 4, 2019 at 3:28 PM Daniel T. Lee wrote: > > Currently, building the bpf samples isn't working. > Running make from the directory 'samples/bpf' will just shows following > result without compiling any samples. > > $ make > make -C ../../ /git/linux/samples/bpf/ BPF_SAMPLES_PATH=/git/lin

Re: [PATCH bpf-next 3/3] libbpf: auto-generate list of BPF helper definitions

2019-10-05 Thread Andrii Nakryiko
On Sat, Oct 5, 2019 at 10:10 AM Alexei Starovoitov wrote: > > On 10/5/19 12:59 AM, Andrii Nakryiko wrote: > > Get rid of list of BPF helpers in bpf_helpers.h (irony...) and > > auto-generate it into bpf_helpers_defs.h, which is now included from > > bpf_helpers.h. > > > > Suggested-by: Alexei Star

[patch net-next 10/10] devlink: have genetlink code to parse the attrs during dumpit

2019-10-05 Thread Jiri Pirko
From: Jiri Pirko Benefit from the fact that the generic netlink code can parse the attrs for dumpit op and avoid need to parse it in the op callback. Signed-off-by: Jiri Pirko --- net/core/devlink.c | 38 ++ 1 file changed, 6 insertions(+), 32 deletions(-)

[patch net-next 09/10] net: genetlink: remove unused genl_family_attrbuf()

2019-10-05 Thread Jiri Pirko
From: Jiri Pirko genl_family_attrbuf() function is no longer used by anyone, so remove it. Signed-off-by: Jiri Pirko --- include/net/genetlink.h | 2 -- net/netlink/genetlink.c | 19 --- 2 files changed, 21 deletions(-) diff --git a/include/net/genetlink.h b/include/net/genet

[patch net-next 06/10] net: nfc: have genetlink code to parse the attrs during dumpit

2019-10-05 Thread Jiri Pirko
From: Jiri Pirko Benefit from the fact that the generic netlink code can parse the attrs for dumpit op and avoid need to parse it in the op callback. Signed-off-by: Jiri Pirko --- net/nfc/netlink.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/net/nfc/n

[patch net-next 07/10] net: tipc: have genetlink code to parse the attrs during dumpit

2019-10-05 Thread Jiri Pirko
From: Jiri Pirko Benefit from the fact that the generic netlink code can parse the attrs for dumpit op and avoid need to parse it in the op callback. Signed-off-by: Jiri Pirko --- net/tipc/netlink.c | 9 ++--- net/tipc/node.c | 6 +- net/tipc/socket.c| 6 +- net/tipc/udp

[patch net-next 05/10] net: ieee802154: have genetlink code to parse the attrs during dumpit

2019-10-05 Thread Jiri Pirko
From: Jiri Pirko Benefit from the fact that the generic netlink code can parse the attrs for dumpit op and avoid need to parse it in the op callback. Signed-off-by: Jiri Pirko --- net/ieee802154/nl802154.c | 39 ++- 1 file changed, 14 insertions(+), 25 delet

[patch net-next 08/10] net: tipc: allocate attrs locally instead of using genl_family_attrbuf in compat_dumpit()

2019-10-05 Thread Jiri Pirko
From: Jiri Pirko As this is the last user of genl_family_attrbuf, convert to allocate attrs locally and do it in a similar way this is done in compat_doit(). Signed-off-by: Jiri Pirko --- net/tipc/netlink.c| 12 net/tipc/netlink.h| 1 - net/tipc/netlink_compat.c |

[patch net-next 03/10] net: genetlink: push attrbuf allocation and parsing to a separate function

2019-10-05 Thread Jiri Pirko
From: Jiri Pirko To be re-usable by dumpit as well, push the code that is taking care of attrbuf allocation and parting from doit into separate function. Introduce a helper to free the buffer too. Check family->maxattr too before calling kfree() to be symmetrical with the allocation check. Sign

[patch net-next 00/10] net: genetlink: parse attrs for dumpit() callback

2019-10-05 Thread Jiri Pirko
From: Jiri Pirko In generic netlink, parsing attributes for doit() callback is already implemented. They are available in info->attrs. For dumpit() however, each user which is interested in attributes have to parse it manually. Even though the attributes may be (depending on flag) already valida

[patch net-next 02/10] net: genetlink: introduce dump info struct to be available during dumpit op

2019-10-05 Thread Jiri Pirko
From: Jiri Pirko Currently the cb->data is taken by ops during non-parallel dumping. Introduce a new structure genl_dumpit_info and store the ops there. Distribute the info to both non-parallel and parallel dumping. Also add a helper genl_dumpit_info() to easily get the info structure in the dump

[patch net-next 04/10] net: genetlink: parse attrs and store in contect info struct during dumpit

2019-10-05 Thread Jiri Pirko
From: Jiri Pirko Extend the dumpit info struct for attrs. Instead of existing attribute validation do parse them and save in the info struct. Caller can benefit from this and does not have to do parse itself. In order to properly free attrs, genl_family pointer needs to be added to dumpit info st

[patch net-next 01/10] net: genetlink: push doit/dumpit code from genl_family_rcv_msg

2019-10-05 Thread Jiri Pirko
From: Jiri Pirko Currently the function genl_family_rcv_msg() is quite big. Since it is quite convenient, push code that is related to doit and dumpit ops into separate functions. Do small changes on the way, like rc/err unification, NULL check etc. Signed-off-by: Jiri Pirko --- net/netlink/g

Happy to inform you, CONTACT WALMART TRANSFER To pick up $8000.00 sent to you this morning.

2019-10-05 Thread DR.Mike Benz
Attn Dear Beneficiary. Happy to inform you, CONTACT WALMART TRANSFER To pick up $8000.00 sent to you this morning. I have deposited your payment funds $2.500,000MillionUS Dollars With Walmart international money transfers. Receive the Money with Walmart | MoneyGram service. Walmart partners with M

Re: [PATCH bpf-next 3/3] libbpf: auto-generate list of BPF helper definitions

2019-10-05 Thread Alexei Starovoitov
On 10/5/19 12:59 AM, Andrii Nakryiko wrote: > Get rid of list of BPF helpers in bpf_helpers.h (irony...) and > auto-generate it into bpf_helpers_defs.h, which is now included from > bpf_helpers.h. > > Suggested-by: Alexei Starovoitov > Signed-off-by: Andrii Nakryiko > --- > tools/lib/bpf/Makefil

Re: [patch net-next 0/3] create netdevsim instances in namespace

2019-10-05 Thread Jakub Kicinski
On Sat, 5 Oct 2019 08:10:30 +0200, Jiri Pirko wrote: > From: Jiri Pirko > > Allow user to create netdevsim devlink and netdevice instances in a > network namespace according to the namespace where the user resides in. > Add a selftest to test this. Acked-by: Jakub Kicinski

Re: [PATCH net-next 0/6] net/tls: add ctrl path tracing and statistics

2019-10-05 Thread Simon Horman
On Fri, Oct 04, 2019 at 04:19:21PM -0700, Jakub Kicinski wrote: > Hi! > > This set adds trace events related to TLS offload and basic MIB stats > for TLS. > > First patch contains the TLS offload related trace points. Those are > helpful in troubleshooting offload issues, especially around the >

RTL8723de support

2019-10-05 Thread François Valenduc
Hello everybody, I am thinking of buying a new laptop which has a Realtek 8723DE wifi adapter. I found this driver which is apparently now included in the main kernel: https://github.com/lwfinger/rtlwifi_new The instruction there says to load the rtl8723de driver, which seems not to exist anymore.

Re: [PATCH bpf-next v2 1/5] bpf: Support injecting chain calls into BPF programs on load

2019-10-05 Thread Toke Høiland-Jørgensen
Jakub Kicinski writes: >> diff --git a/include/linux/bpf.h b/include/linux/bpf.h >> index 5b9d22338606..753abfb78c13 100644 >> --- a/include/linux/bpf.h >> +++ b/include/linux/bpf.h >> @@ -383,6 +383,7 @@ struct bpf_prog_aux { >> struct list_head ksym_lnode; >> const struct bpf_prog_ops

Re: [PATCH bpf-next v2 2/5] bpf: Add support for setting chain call sequence for programs

2019-10-05 Thread Toke Høiland-Jørgensen
Jakub Kicinski writes: > On Fri, 04 Oct 2019 19:22:42 +0200, Toke Høiland-Jørgensen wrote: >> From: Alan Maguire >> >> This adds support for setting and deleting bpf chain call programs through >> a couple of new commands in the bpf() syscall. The CHAIN_ADD and CHAIN_DEL >> commands take two eB

Re: [PATCH bpf-next v2 1/5] bpf: Support injecting chain calls into BPF programs on load

2019-10-05 Thread Toke Høiland-Jørgensen
Jakub Kicinski writes: > On Fri, 04 Oct 2019 19:22:41 +0200, Toke Høiland-Jørgensen wrote: >> From: Toke Høiland-Jørgensen >> >> This adds support for injecting chain call logic into eBPF programs before >> they return. The code injection is controlled by a flag at program load >> time; if the

[PATCH net-next v5 2/4] samples: pktgen: fix proc_cmd command result check logic

2019-10-05 Thread Daniel T. Lee
Currently, proc_cmd is used to dispatch command to 'pg_ctrl', 'pg_thread', 'pg_set'. proc_cmd is designed to check command result with grep the "Result:", but this might fail since this string is only shown in 'pg_thread' and 'pg_set'. This commit fixes this logic by grep-ing the "Result:" strin

[PATCH net-next v5 1/4] samples: pktgen: make variable consistent with option

2019-10-05 Thread Daniel T. Lee
This commit changes variable names that can cause confusion. For example, variable DST_MIN is quite confusing since the keyword 'udp_dst_min' and keyword 'dst_min' is used with pg_ctrl. On the following commit, 'dst_min' will be used to set destination IP, and the existing variable name DST_MIN s

[PATCH net-next v5 3/4] samples: pktgen: add helper functions for IP(v4/v6) CIDR parsing

2019-10-05 Thread Daniel T. Lee
This commit adds CIDR parsing and IP validate helper function to parse single IP or range of IP with CIDR. (e.g. 198.18.0.0/15) Validating the address should be preceded prior to the parsing. Helpers will be used in prior to set target address in samples/pktgen. Signed-off-by: Daniel T. Lee ---

[PATCH net-next v5 4/4] samples: pktgen: allow to specify destination IP range (CIDR)

2019-10-05 Thread Daniel T. Lee
Currently, kernel pktgen has the feature to specify destination address range for sending packet. (e.g. pgset "dst_min/dst_max") But on samples, each pktgen script doesn't have any option to achieve this. This commit adds the feature to specify the destination address range with CIDR. -d : (

[PATCH net-next v5 0/4] samples: pktgen: allow to specify destination IP range

2019-10-05 Thread Daniel T. Lee
Currently, pktgen script supports specify destination port range. To further extend the capabilities, this commit allows to specify destination IP range with CIDR when running pktgen script. Specifying destination IP range will be useful on various situation such as testing RSS/RPS with randomiz

[PATCH bpf-next 0/3] Auto-generate list of BPF helpers

2019-10-05 Thread Andrii Nakryiko
This patch set adds ability to auto-generate list of BPF helper definitions. It relies on existing scripts/bpf_helpers_doc.py and include/uapi/linux/bpf.h having a well-defined set of comments. All this is integrated with libbpf's Makefile to ensure that bpf_helpers_defs.h stays in sync with lates

[PATCH bpf-next 3/3] libbpf: auto-generate list of BPF helper definitions

2019-10-05 Thread Andrii Nakryiko
Get rid of list of BPF helpers in bpf_helpers.h (irony...) and auto-generate it into bpf_helpers_defs.h, which is now included from bpf_helpers.h. Suggested-by: Alexei Starovoitov Signed-off-by: Andrii Nakryiko --- tools/lib/bpf/Makefile |8 +- tools/lib/bpf/bpf_helpers.h |

[PATCH bpf-next 1/3] uapi/bpf: fix helper docs

2019-10-05 Thread Andrii Nakryiko
Various small fixes to BPF helper documentation comments, enabling automatic header generation with a list of BPF helpers. Signed-off-by: Andrii Nakryiko --- include/uapi/linux/bpf.h | 32 tools/include/uapi/linux/bpf.h | 32

[PATCH bpf-next 2/3] scripts/bpf: teach bpf_helpers_doc.py to dump BPF helper definitions

2019-10-05 Thread Andrii Nakryiko
Enhance scripts/bpf_helpers_doc.py to emit C header with BPF helper definitions (to be included from libbpf's bpf_helpers.h). Signed-off-by: Andrii Nakryiko --- scripts/bpf_helpers_doc.py | 156 - 1 file changed, 155 insertions(+), 1 deletion(-) diff --git a/

Re: [RFC 04/20] RDMA/irdma: Add driver framework definitions

2019-10-05 Thread gre...@linuxfoundation.org
On Sat, Oct 05, 2019 at 09:28:05AM +0300, Leon Romanovsky wrote: > On Fri, Oct 04, 2019 at 05:46:15PM -0700, Jeff Kirsher wrote: > > On Fri, 2019-10-04 at 23:45 +, Jason Gunthorpe wrote: > > > On Fri, Oct 04, 2019 at 01:12:22PM -0700, Jeff Kirsher wrote: > > > > > > > > > + if (ldev->version.