On 10/5/19 12:59 AM, Andrii Nakryiko wrote: > Get rid of list of BPF helpers in bpf_helpers.h (irony...) and > auto-generate it into bpf_helpers_defs.h, which is now included from > bpf_helpers.h. > > Suggested-by: Alexei Starovoitov<a...@fb.com> > Signed-off-by: Andrii Nakryiko<andr...@fb.com> > --- > tools/lib/bpf/Makefile | 8 +- > tools/lib/bpf/bpf_helpers.h | 264 +-- > tools/lib/bpf/bpf_helpers_defs.h | 2677 ++++++++++++++++++++++++++++++ > 3 files changed, 2685 insertions(+), 264 deletions(-) > create mode 100644 tools/lib/bpf/bpf_helpers_defs.h
Approach looks good to me. imo that's better than messing with macros. Using bpf_helpers_doc.py as part of build will help man pages too. I think we were sloppy documenting helpers, since only Quentin was running that script regularly. Only question is what is the reason to commit generated .h into git?
