Re: [RFC 01/20] ice: Initialize and register multi-function device to provide RDMA

2019-09-26 Thread gre...@linuxfoundation.org
On Thu, Sep 26, 2019 at 11:39:22PM +, Nguyen, Anthony L wrote: > On Thu, 2019-09-26 at 20:05 +0200, Greg KH wrote: > > On Thu, Sep 26, 2019 at 09:45:00AM -0700, Jeff Kirsher wrote: > > > From: Tony Nguyen > > > > > > The RDMA block does not advertise on the PCI bus or any other bus. > > > >

Re: [PATCH net] devlink: Fix error handling in param and info_get dumpit cb

2019-09-26 Thread Vasundhara Volam
On Thu, Sep 26, 2019 at 5:57 PM Andrew Lunn wrote: > > On Thu, Sep 26, 2019 at 03:05:54PM +0530, Vasundhara Volam wrote: > > If any of the param or info_get op returns error, dumpit cb is > > skipping to dump remaining params or info_get ops for all the > > drivers. > > > > Instead skip only for t

Re: [RFC 12/20] RDMA/irdma: Implement device supported verb APIs

2019-09-26 Thread Leon Romanovsky
On Thu, Sep 26, 2019 at 07:49:52PM +, Saleem, Shiraz wrote: > > Subject: Re: [RFC 12/20] RDMA/irdma: Implement device supported verb APIs > > > > On Thu, Sep 26, 2019 at 09:45:11AM -0700, Jeff Kirsher wrote: > > > From: Mustafa Ismail > > > > > > Implement device supported verb APIs. The suppo

Re: [RFC 15/20] RDMA/irdma: Add miscellaneous utility definitions

2019-09-26 Thread Leon Romanovsky
On Thu, Sep 26, 2019 at 07:49:33PM +, Saleem, Shiraz wrote: > > Subject: Re: [RFC 15/20] RDMA/irdma: Add miscellaneous utility definitions > > > > On Thu, Sep 26, 2019 at 09:45:14AM -0700, Jeff Kirsher wrote: > > > From: Mustafa Ismail > > > > > > Add miscellaneous utility functions and header

[PATCH net] sch_cbq: validate TCA_CBQ_WRROPT to avoid crash

2019-09-26 Thread Eric Dumazet
syzbot reported a crash in cbq_normalize_quanta() caused by an out of range cl->priority. iproute2 enforces this check, but malicious users do not. kasan: CONFIG_KASAN_INLINE enabled kasan: GPF could be caused by NULL-ptr deref or user memory access general protection fault: [#1] SMP KASAN P

Re: [RFC 01/20] ice: Initialize and register multi-function device to provide RDMA

2019-09-26 Thread Nguyen, Anthony L
On Thu, 2019-09-26 at 20:05 +0200, Greg KH wrote: > On Thu, Sep 26, 2019 at 09:45:00AM -0700, Jeff Kirsher wrote: > > From: Tony Nguyen > > > > The RDMA block does not advertise on the PCI bus or any other bus. > > Huh? How do you "know" where it is then? Isn't is usually assigned > to > a PCI

[PATCH bpf] libbpf: add macro __BUILD_STATIC_LIBBPF__ to guard .symver

2019-09-26 Thread Yonghong Song
bcc uses libbpf repo as a submodule. It brings in libbpf source code and builds everything together to produce shared libraries. With latest libbpf, I got the following errors: /bin/ld: libbcc_bpf.so.0.10.0: version node not found for symbol xsk_umem__create@LIBBPF_0.0.2 /bin/ld: failed to set

Re: [PATCH] net: use unlikely for dql_avail case

2019-09-26 Thread Eric Dumazet
On 9/25/19 5:25 AM, Daniel Borkmann wrote: > On Wed, Sep 25, 2019 at 10:40:43AM +0800, xiaolinkui wrote: >> This is an unlikely case, use unlikely() on it seems logical. >> >> Signed-off-by: xiaolinkui > > It's already here [0], but should probably rather get reverted instead > due to lack of

[PATCH net] tcp: better handle TCP_USER_TIMEOUT in SYN_SENT state

2019-09-26 Thread Eric Dumazet
Yuchung Cheng and Marek Majkowski independently reported a weird behavior of TCP_USER_TIMEOUT option when used at connect() time. When the TCP_USER_TIMEOUT is reached, tcp_write_timeout() believes the flow should live, and the following condition in tcp_clamp_rto_to_user_timeout() programs one jif

Re: Fwd: [PATCH] bonding/802.3ad: fix slave initialization states race

2019-09-26 Thread Jay Vosburgh
Aleksei Zakharov wrote: >чт, 26 сент. 2019 г. в 07:38, Jay Vosburgh : >> >> Aleksei Zakharov wrote: >> >> >ср, 25 сент. 2019 г. в 03:31, Jay Vosburgh : >> >> >> >> Алексей Захаров wrote: >> >> [...] >> >> >Right after reboot one of the slaves hangs with actor port state 71 >> >> >and partner por

Re: [RFC 20/20] RDMA/i40iw: Mark i40iw as deprecated

2019-09-26 Thread gre...@linuxfoundation.org
On Thu, Sep 26, 2019 at 07:49:44PM +, Saleem, Shiraz wrote: > > Subject: Re: [RFC 20/20] RDMA/i40iw: Mark i40iw as deprecated > > > > On Thu, Sep 26, 2019 at 09:45:19AM -0700, Jeff Kirsher wrote: > > > From: Shiraz Saleem > > > > > > Mark i40iw as deprecated/obsolete. > > > > > > irdma is the

RE: [RFC 04/20] RDMA/irdma: Add driver framework definitions

2019-09-26 Thread Saleem, Shiraz
> Subject: Re: [RFC 04/20] RDMA/irdma: Add driver framework definitions > <...> > > +/** > > + * i40iw_l2param_change - handle qs handles for QoS and MSS change > > + * @ldev: LAN device information > > + * @client: client for parameter change > > + * @params: new parameters from L2

RE: [RFC 12/20] RDMA/irdma: Implement device supported verb APIs

2019-09-26 Thread Saleem, Shiraz
> Subject: Re: [RFC 12/20] RDMA/irdma: Implement device supported verb APIs > > On Thu, Sep 26, 2019 at 08:37:10PM +0300, Leon Romanovsky wrote: > > On Thu, Sep 26, 2019 at 09:45:11AM -0700, Jeff Kirsher wrote: > > > From: Mustafa Ismail > > > > > > Implement device supported verb APIs. The suppo

RE: [RFC 15/20] RDMA/irdma: Add miscellaneous utility definitions

2019-09-26 Thread Saleem, Shiraz
> Subject: Re: [RFC 15/20] RDMA/irdma: Add miscellaneous utility definitions > > On Thu, Sep 26, 2019 at 09:45:14AM -0700, Jeff Kirsher wrote: > > From: Mustafa Ismail > > > > Add miscellaneous utility functions and headers. > > > > Signed-off-by: Mustafa Ismail > > Signed-off-by: Shiraz Saleem

RE: [RFC 12/20] RDMA/irdma: Implement device supported verb APIs

2019-09-26 Thread Saleem, Shiraz
> Subject: Re: [RFC 12/20] RDMA/irdma: Implement device supported verb APIs > > On Thu, Sep 26, 2019 at 09:45:11AM -0700, Jeff Kirsher wrote: > > From: Mustafa Ismail > > > > Implement device supported verb APIs. The supported APIs vary based on > > the underlying transport the ibdev is registere

RE: [RFC 20/20] RDMA/i40iw: Mark i40iw as deprecated

2019-09-26 Thread Saleem, Shiraz
> Subject: Re: [RFC 20/20] RDMA/i40iw: Mark i40iw as deprecated > > On Thu, Sep 26, 2019 at 09:45:19AM -0700, Jeff Kirsher wrote: > > From: Shiraz Saleem > > > > Mark i40iw as deprecated/obsolete. > > > > irdma is the replacement driver that supports X722. > > Can you simply delete old one and a

Re: [PATCH v2 net] sk_buff: drop all skb extensions on free and skb scrubbing

2019-09-26 Thread Eric Dumazet
On 9/26/19 12:09 PM, Florian Westphal wrote: > Eric Dumazet wrote: >>> - secpath_reset(skb); >>> + skb_ext_reset(skb); >>> nf_reset(skb); >>> nf_reset_trace(skb); >> >> >> It is unfortunate nf_reset(skb) will call skb_ext_del(skb, >> SKB_EXT_BRIDGE_NF), >> which is useless after sk

Introducing Transperf

2019-09-26 Thread Soheil Hassas Yeganeh
We'd like to announce the availability of transperf: a network protocol performance testing tool. transperf enables users to test TCP performance over a variety of emulated network scenarios (using netem), including RTT, bottleneck bandwidth, and policed rate that can change over time. The tool su

Re: [PATCH v2 net] sk_buff: drop all skb extensions on free and skb scrubbing

2019-09-26 Thread Florian Westphal
Eric Dumazet wrote: > > - secpath_reset(skb); > > + skb_ext_reset(skb); > > nf_reset(skb); > > nf_reset_trace(skb); > > > It is unfortunate nf_reset(skb) will call skb_ext_del(skb, SKB_EXT_BRIDGE_NF), > which is useless after skb_ext_reset(skb) > > Maybe time for a nf_ct_reset() he

Re: [PATCH v2 net] sk_buff: drop all skb extensions on free and skb scrubbing

2019-09-26 Thread Eric Dumazet
On 9/26/19 11:37 AM, Florian Westphal wrote: > Now that we have a 3rd extension, add a new helper that drops the > extension space and use it when we need to scrub an sk_buff. > > } > diff --git a/net/core/skbuff.c b/net/core/skbuff.c > index f12e8a050edb..01d65206f4fb 100644 > --- a/net/core

Re: Question on LACP Bypass feature

2019-09-26 Thread Jay Vosburgh
Madhavi Joshi wrote: >  We have a question regarding LACP Bypass feature . It appears that by >default, this feature is enabled in the kernel (we are on 4.1.1274 version >kernel). >Having said that, we do not see any sysctl or directory on the lines of >/sys/class/net//bonding/lacp_bypass. > 

[PATCH v2 net] sk_buff: drop all skb extensions on free and skb scrubbing

2019-09-26 Thread Florian Westphal
Now that we have a 3rd extension, add a new helper that drops the extension space and use it when we need to scrub an sk_buff. At this time, scrubbing clears secpath and bridge netfilter data, but retains the tc skb extension, after this patch all three get cleared. NAPI reuse/free assumes we can

Re: [PATCH iproute2(-next) v2 1/1] ip: fix ip route show json output for multipath nexthops

2019-09-26 Thread Julien Fortin
On Thu, Sep 26, 2019 at 6:07 PM Stephen Hemminger wrote: > > On Thu, 26 Sep 2019 17:29:34 +0200 > Julien Fortin wrote: > > > + print_string(PRINT_ANY, "dev", > > + "%s", ll_index_to_name(nh->rtnh_ifindex)) > > you might want to use interface co

Re: [PATCH net] sk_buff: drop all skb extensions on free and skb scrubbing

2019-09-26 Thread Eric Dumazet
On 9/26/19 11:06 AM, Florian Westphal wrote: > Eric Dumazet wrote: >>> +static inline void skb_ext_reset(struct sk_buff *skb) >>> +{ >>> + if (skb->active_extensions) { >> >> This deserves an unlikely(skb->active_extensions) hint here ? > > unlikely() isn't used in the other helpers (e.g. sk

Re: Are BPF tail calls only supposed to work with pinned maps?

2019-09-26 Thread Daniel Borkmann
On Thu, Sep 26, 2019 at 03:12:30PM +0200, Toke Høiland-Jørgensen wrote: > Daniel Borkmann writes: > > On Thu, Sep 26, 2019 at 01:23:38PM +0200, Toke Høiland-Jørgensen wrote: > > [...] > >> While working on a prototype of the XDP chain call feature, I ran into > >> some strange behaviour with tail

[net-next v3 4/7] dp83640: reject unsupported external timestamp flags

2019-09-26 Thread Jacob Keller
Fix the dp83640 PTP support to explicitly reject any future flags that get added to the external timestamp request ioctl. In order to maintain currently functioning code, this patch accepts all three current flags. This is because the PTP_RISING_EDGE and PTP_FALLING_EDGE flags have unclear semanti

[net-next v3 5/7] igb: reject unsupported external timestamp flags

2019-09-26 Thread Jacob Keller
Fix the igb PTP support to explicitly reject any future flags that get added to the external timestamp request ioctl. In order to maintain currently functioning code, this patch accepts all three current flags. This is because the PTP_RISING_EDGE and PTP_FALLING_EDGE flags have unclear semantics a

[net-next v3 7/7] renesas: reject unsupported external timestamp flags

2019-09-26 Thread Jacob Keller
Fix the renesas PTP support to explicitly reject any future flags that get added to the external timestamp request ioctl. In order to maintain currently functioning code, this patch accepts all three current flags. This is because the PTP_RISING_EDGE and PTP_FALLING_EDGE flags have unclear semanti

[net-next v3 1/7] ptp: correctly disable flags on old ioctls

2019-09-26 Thread Jacob Keller
Commit 415606588c61 ("PTP: introduce new versions of IOCTLs", 2019-09-13) introduced new versions of the PTP ioctls which actually validate that the flags are acceptable values. As part of this, it cleared the flags value using a bitwise and+negation, in an attempt to prevent the old ioctl from ac

[net-next v3 6/7] mlx5: reject unsupported external timestamp flags

2019-09-26 Thread Jacob Keller
Fix the mlx5 core PTP support to explicitly reject any future flags that get added to the external timestamp request ioctl. In order to maintain currently functioning code, this patch accepts all three current flags. This is because the PTP_RISING_EDGE and PTP_FALLING_EDGE flags have unclear seman

[net-next v3 3/7] mv88e6xxx: reject unsupported external timestamp flags

2019-09-26 Thread Jacob Keller
Fix the mv88e6xxx PTP support to explicitly reject any future flags that get added to the external timestamp request ioctl. In order to maintain currently functioning code, this patch accepts all three current flags. This is because the PTP_RISING_EDGE and PTP_FALLING_EDGE flags have unclear seman

[net-next v3 0/7] new PTP ioctl fixes

2019-09-26 Thread Jacob Keller
This series contains patches to fix the various drivers which implemented external pin input/output support. The drivers did not explicitly reject unknown/unsupported flags. Changes since v2: * Split the external timestamp changes to separate patches per-driver * Change the check for external time

[net-next v3 2/7] net: reject PTP periodic output requests with unsupported flags

2019-09-26 Thread Jacob Keller
Commit 823eb2a3c4c7 ("PTP: add support for one-shot output") introduced a new flag for the PTP periodic output request ioctl. This flag is not currently supported by any driver. Fix all drivers which implement the periodic output request ioctl to explicitly reject any request with flags they do no

RE: [RFC 04/20] RDMA/irdma: Add driver framework definitions

2019-09-26 Thread Saleem, Shiraz
> Subject: Re: [RFC 04/20] RDMA/irdma: Add driver framework definitions > > On Thu, Sep 26, 2019 at 08:02:15PM +0200, gre...@linuxfoundation.org wrote: > > On Thu, Sep 26, 2019 at 04:55:12PM +, Jason Gunthorpe wrote: > > > On Thu, Sep 26, 2019 at 09:45:03AM -0700, Jeff Kirsher wrote: > > > > +

Re: [PATCH net] sk_buff: drop all skb extensions on free and skb scrubbing

2019-09-26 Thread Florian Westphal
Eric Dumazet wrote: > > +static inline void skb_ext_reset(struct sk_buff *skb) > > +{ > > + if (skb->active_extensions) { > > This deserves an unlikely(skb->active_extensions) hint here ? unlikely() isn't used in the other helpers (e.g. skb_ext_{put,del,copy} either, should I add it there too?

Re: [RFC 01/20] ice: Initialize and register multi-function device to provide RDMA

2019-09-26 Thread Greg KH
On Thu, Sep 26, 2019 at 09:45:00AM -0700, Jeff Kirsher wrote: > From: Tony Nguyen > > The RDMA block does not advertise on the PCI bus or any other bus. Huh? How do you "know" where it is then? Isn't is usually assigned to a PCI device? > Thus the ice driver needs to provide access to the RDM

Re: [RFC 04/20] RDMA/irdma: Add driver framework definitions

2019-09-26 Thread Jason Gunthorpe
On Thu, Sep 26, 2019 at 08:02:15PM +0200, gre...@linuxfoundation.org wrote: > On Thu, Sep 26, 2019 at 04:55:12PM +, Jason Gunthorpe wrote: > > On Thu, Sep 26, 2019 at 09:45:03AM -0700, Jeff Kirsher wrote: > > > +int i40iw_probe(struct platform_device *pdev) > > > +{ > > > + struct i40e_peer_dev

Re: TCP_USER_TIMEOUT, SYN-SENT and tcp_syn_retries

2019-09-26 Thread Eric Dumazet
On 9/26/19 9:57 AM, Eric Dumazet wrote: > > > On 9/26/19 9:46 AM, Eric Dumazet wrote: >> >> >> On 9/26/19 8:05 AM, Eric Dumazet wrote: >>> >>> >>> On 9/25/19 1:46 AM, Marek Majkowski wrote: Hello my favorite mailing list! Recently I've been looking into TCP_USER_TIMEOUT and noti

Re: [RFC 04/20] RDMA/irdma: Add driver framework definitions

2019-09-26 Thread gre...@linuxfoundation.org
On Thu, Sep 26, 2019 at 04:55:12PM +, Jason Gunthorpe wrote: > On Thu, Sep 26, 2019 at 09:45:03AM -0700, Jeff Kirsher wrote: > > +int i40iw_probe(struct platform_device *pdev) > > +{ > > + struct i40e_peer_dev_platform_data *pdata = > > + dev_get_platdata(&pdev->dev); > > + struct

Re: [PATCH net] net: stmmac: dwmac-meson8b: Fix signedness bug in probe

2019-09-26 Thread Martin Blumenstingl
+Cc linux-amlogic mailing list On Wed, Sep 25, 2019 at 12:59 PM Dan Carpenter wrote: > > The "dwmac->phy_mode" is an enum and in this context GCC treats it as > an unsigned int so the error handling is never triggered. > > Fixes: 566e82516253 ("net: stmmac: add a glue driver for the Amlogic Meson

Re: [RFC 15/20] RDMA/irdma: Add miscellaneous utility definitions

2019-09-26 Thread Leon Romanovsky
On Thu, Sep 26, 2019 at 09:45:14AM -0700, Jeff Kirsher wrote: > From: Mustafa Ismail > > Add miscellaneous utility functions and headers. > > Signed-off-by: Mustafa Ismail > Signed-off-by: Shiraz Saleem > --- > drivers/infiniband/hw/irdma/osdep.h | 108 ++ > drivers/infiniband/hw/irdma/protos

RE: [net-next v2 2/2] net: reject ptp requests with unsupported flags

2019-09-26 Thread Keller, Jacob E
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On > Behalf Of Richard Cochran > Sent: Wednesday, September 25, 2019 9:02 PM > To: Keller, Jacob E > Cc: netdev@vger.kernel.org; Intel Wired LAN > ; > Kirsher, Jeffrey T ; Felipe Balbi > ; D

RE: [net-next v2 2/2] net: reject ptp requests with unsupported flags

2019-09-26 Thread Keller, Jacob E
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On > Behalf Of Richard Cochran > Sent: Wednesday, September 25, 2019 9:02 PM > To: Keller, Jacob E > Cc: netdev@vger.kernel.org; Intel Wired LAN > ; > Kirsher, Jeffrey T ; Felipe Balbi > ; D

Re: [RFC 20/20] RDMA/i40iw: Mark i40iw as deprecated

2019-09-26 Thread Leon Romanovsky
On Thu, Sep 26, 2019 at 09:45:19AM -0700, Jeff Kirsher wrote: > From: Shiraz Saleem > > Mark i40iw as deprecated/obsolete. > > irdma is the replacement driver that supports X722. Can you simply delete old one and add MODULE_ALIAS() in new driver? Thanks

Re: [RFC 12/20] RDMA/irdma: Implement device supported verb APIs

2019-09-26 Thread Jason Gunthorpe
On Thu, Sep 26, 2019 at 08:37:10PM +0300, Leon Romanovsky wrote: > On Thu, Sep 26, 2019 at 09:45:11AM -0700, Jeff Kirsher wrote: > > From: Mustafa Ismail > > > > Implement device supported verb APIs. The supported APIs > > vary based on the underlying transport the ibdev is > > registered as (i.e.

Re: [RFC 12/20] RDMA/irdma: Implement device supported verb APIs

2019-09-26 Thread Leon Romanovsky
On Thu, Sep 26, 2019 at 09:45:11AM -0700, Jeff Kirsher wrote: > From: Mustafa Ismail > > Implement device supported verb APIs. The supported APIs > vary based on the underlying transport the ibdev is > registered as (i.e. iWARP or RoCEv2). > > Signed-off-by: Mustafa Ismail > Signed-off-by: Shiraz

Re: Question on LACP Bypass feature

2019-09-26 Thread Madhavi Joshi
Hello,     We have a question regarding LACP Bypass feature . It appears that by default, this feature is enabled in the kernel (we are on 4.1.1274 version kernel). Having said that, we do not see any sysctl or directory on the lines of /sys/class/net//bonding/lacp_bypass.   Really appreciate y

Re: [RFC 04/20] RDMA/irdma: Add driver framework definitions

2019-09-26 Thread Leon Romanovsky
On Thu, Sep 26, 2019 at 09:45:03AM -0700, Jeff Kirsher wrote: > From: Mustafa Ismail > > Register irdma as a platform driver capable of supporting platform > devices from multi-generation RDMA capable Intel HW. Establish the > interface with all supported netdev peer devices and initialize HW. > >

Re: [PATCH net] sk_buff: drop all skb extensions on free and skb scrubbing

2019-09-26 Thread Eric Dumazet
On 9/26/19 7:18 AM, Florian Westphal wrote: > Now that we have a 3rd extension, add a new helper that drops the > extension space and use it when we need to scrub an sk_buff. > > At this time, scrubbing clears secpath and bridge netfilter data, but > retains the tc skb extension, after this pat

Re: CONFIG_NET_TC_SKB_EXT

2019-09-26 Thread Edward Cree
On 26/09/2019 16:14, Paul Blakey wrote: > On 9/26/2019 5:26 PM, Edward Cree wrote: >> On 26/09/2019 14:56, Paul Blakey wrote: > In nat scenarios the packet will be modified, and then there can be a > miss: > >   -trk CT(zone X, Restore NAT),goto chain 1 > >

Re: [PATCH V11 0/4] BPF: New helper to obtain namespace data from current task

2019-09-26 Thread Yonghong Song
On 9/26/19 9:16 AM, John Fastabend wrote: > Eric W. Biederman wrote: >> Carlos Neira writes: >> >>> Currently bpf_get_current_pid_tgid(), is used to do pid filtering in bcc's >>> scripts but this helper returns the pid as seen by the root namespace which >>> is >>> fine when a bcc script is not

Re: TCP_USER_TIMEOUT, SYN-SENT and tcp_syn_retries

2019-09-26 Thread Eric Dumazet
On 9/26/19 9:46 AM, Eric Dumazet wrote: > > > On 9/26/19 8:05 AM, Eric Dumazet wrote: >> >> >> On 9/25/19 1:46 AM, Marek Majkowski wrote: >>> Hello my favorite mailing list! >>> >>> Recently I've been looking into TCP_USER_TIMEOUT and noticed some >>> strange behaviour on fresh sockets in SYN-

Re: [RFC 04/20] RDMA/irdma: Add driver framework definitions

2019-09-26 Thread Jason Gunthorpe
On Thu, Sep 26, 2019 at 09:45:03AM -0700, Jeff Kirsher wrote: > +int i40iw_probe(struct platform_device *pdev) > +{ > + struct i40e_peer_dev_platform_data *pdata = > + dev_get_platdata(&pdev->dev); > + struct i40e_info *ldev; I thought Greg already said not to use platform_devi

[RFC 20/20] RDMA/i40iw: Mark i40iw as deprecated

2019-09-26 Thread Jeff Kirsher
From: Shiraz Saleem Mark i40iw as deprecated/obsolete. irdma is the replacement driver that supports X722. Signed-off-by: Shiraz Saleem --- drivers/infiniband/hw/i40iw/Kconfig | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/i40iw/Kconfig b/drivers

[RFC 05/20] RDMA/irdma: Implement device initialization definitions

2019-09-26 Thread Jeff Kirsher
From: Mustafa Ismail Implement device initialization routines, interrupt set-up, and allocate object bit-map tracking structures. Also, add device specific attributes and register definitions. Signed-off-by: Mustafa Ismail Signed-off-by: Shiraz Saleem --- drivers/infiniband/hw/irdma/hw.c

[RFC 15/20] RDMA/irdma: Add miscellaneous utility definitions

2019-09-26 Thread Jeff Kirsher
From: Mustafa Ismail Add miscellaneous utility functions and headers. Signed-off-by: Mustafa Ismail Signed-off-by: Shiraz Saleem --- drivers/infiniband/hw/irdma/osdep.h | 108 ++ drivers/infiniband/hw/irdma/protos.h | 96 ++ drivers/infiniband/hw/irdma/status.h | 70 + drivers/infiniban

Re: TCP_USER_TIMEOUT, SYN-SENT and tcp_syn_retries

2019-09-26 Thread Eric Dumazet
On 9/26/19 8:05 AM, Eric Dumazet wrote: > > > On 9/25/19 1:46 AM, Marek Majkowski wrote: >> Hello my favorite mailing list! >> >> Recently I've been looking into TCP_USER_TIMEOUT and noticed some >> strange behaviour on fresh sockets in SYN-SENT state. Full writeup: >> https://blog.cloudflare.

[RFC 08/20] RDMA/irdma: Add privileged UDA queue implementation

2019-09-26 Thread Jeff Kirsher
From: Mustafa Ismail Implement privileged UDA queues to handle iWARP connection packets and receive exceptions. Signed-off-by: Mustafa Ismail Signed-off-by: Shiraz Saleem --- drivers/infiniband/hw/irdma/puda.c | 1693 drivers/infiniband/hw/irdma/puda.h | 187 +++

[RFC 02/20] ice: Implement peer communications

2019-09-26 Thread Jeff Kirsher
From: Tony Nguyen Set and implement operations for the peer device and peer driver to communicate with each other, via ice_ops and ice_peer_ops, to request resources and manage event notification. Signed-off-by: Dave Ertman Signed-off-by: Tony Nguyen Signed-off-by: Jeff Kirsher --- drivers/n

[RFC 14/20] RDMA/irdma: Add user/kernel shared libraries

2019-09-26 Thread Jeff Kirsher
From: Mustafa Ismail Building the WQE descriptors for different verb operations are similar in kernel and user-space. Add these shared libraries. Signed-off-by: Mustafa Ismail Signed-off-by: Shiraz Saleem --- drivers/infiniband/hw/irdma/uk.c | 1739 drivers/infi

[RFC 13/20] RDMA/irdma: Add RoCEv2 UD OP support

2019-09-26 Thread Jeff Kirsher
From: Mustafa Ismail Add the header, data structures and functions to populate the WQE descriptors and issue the Control QP commands that support RoCEv2 UD operations. Signed-off-by: Mustafa Ismail Signed-off-by: Shiraz Saleem --- drivers/infiniband/hw/irdma/uda.c | 391

[RFC 18/20] RDMA/irdma: Update MAINTAINERS file

2019-09-26 Thread Jeff Kirsher
From: Shiraz Saleem Add maintainer entry for irdma driver. Signed-off-by: Mustafa Ismail Signed-off-by: Shiraz Saleem --- MAINTAINERS | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 07c374fa1975..dec22ea4ccbc 100644 --- a/MAINTAINE

[RFC 10/20] RDMA/irdma: Add connection manager

2019-09-26 Thread Jeff Kirsher
From: Mustafa Ismail Add connection management (CM) implementation for iWARP including accept, reject, connect, create_listen, destroy_listen and CM utility functions Signed-off-by: Mustafa Ismail Signed-off-by: Shiraz Saleem --- drivers/infiniband/hw/irdma/cm.c | 4511 +++

[RFC 19/20] RDMA/irdma: Add Kconfig and Makefile

2019-09-26 Thread Jeff Kirsher
From: Shiraz Saleem Add Kconfig and Makefile to build irdma driver Signed-off-by: Shiraz Saleem --- drivers/infiniband/Kconfig | 1 + drivers/infiniband/hw/Makefile | 1 + drivers/infiniband/hw/irdma/Kconfig | 11 +++ drivers/infiniband/hw/irdma/Makefile | 28 +++

[RFC 16/20] RDMA/irdma: Add dynamic tracing for CM

2019-09-26 Thread Jeff Kirsher
From: "Michael J. Ruhl" Add dynamic tracing functionality to debug connection management issues. Signed-off-by: "Michael J. Ruhl" Signed-off-by: Shiraz Saleem --- drivers/infiniband/hw/irdma/trace.c| 113 ++ drivers/infiniband/hw/irdma/trace.h| 4 + drivers/infiniband/hw/irdma/t

[RFC 01/20] ice: Initialize and register multi-function device to provide RDMA

2019-09-26 Thread Jeff Kirsher
From: Tony Nguyen The RDMA block does not advertise on the PCI bus or any other bus. Thus the ice driver needs to provide access to the RDMA hardware block via a virtual bus; utilize a multi-function device to provide this access. This patch initializes the driver to support RDMA as well as crea

[RFC 09/20] RDMA/irdma: Add QoS definitions

2019-09-26 Thread Jeff Kirsher
From: Mustafa Ismail Add definitions for managing the RDMA HW work scheduler (WS) tree. A WS node is created via a control QP operation with the bandwidth allocation, arbitration scheme, and traffic class of the QP specified. The Qset handle returned associates the QoS parameters for the QP. The

[RFC 17/20] RDMA/irdma: Add ABI definitions

2019-09-26 Thread Jeff Kirsher
From: Mustafa Ismail Add ABI definitions for irdma. Signed-off-by: Mustafa Ismail Signed-off-by: Shiraz Saleem Signed-off-by: Jeff Kirsher --- include/uapi/rdma/irdma-abi.h | 159 ++ 1 file changed, 159 insertions(+) create mode 100644 include/uapi/rdma/irdma

[RFC 12/20] RDMA/irdma: Implement device supported verb APIs

2019-09-26 Thread Jeff Kirsher
From: Mustafa Ismail Implement device supported verb APIs. The supported APIs vary based on the underlying transport the ibdev is registered as (i.e. iWARP or RoCEv2). Signed-off-by: Mustafa Ismail Signed-off-by: Shiraz Saleem --- drivers/infiniband/hw/irdma/verbs.c | 4346 ++

[RFC 00/20] Intel RDMA/IDC Driver series

2019-09-26 Thread Jeff Kirsher
This series is sent out as an RFC to verify that our implementation of the MFD subsystem is correct to facilitate inner driver communication (IDC) between the new "irdma" driver to support Intel's ice and i40e drivers. The changes contain the modified ice and i40e driver changes using the MFD subs

[RFC 03/20] i40e: Register multi-function device to provide RDMA

2019-09-26 Thread Jeff Kirsher
From: Mustafa Ismail Register multi-function devices (MFD) for the RDMA platform function (irdma) driver to bind to. It realizes a single RDMA driver capable of working with multiple LAN drivers over multi-generation Intel HW supporting RDMA. There is also no load ordering dependencies between i4

[RFC 07/20] RDMA/irdma: Add HMC backing store setup functions

2019-09-26 Thread Jeff Kirsher
From: Mustafa Ismail HW uses host memory as a backing store for a number of protocol context objects and queue state tracking. The Host Memory Cache (HMC) is a component responsible for managing these objects stored in host memory. Add the functions and data structures to manage the allocation o

[RFC 04/20] RDMA/irdma: Add driver framework definitions

2019-09-26 Thread Jeff Kirsher
From: Mustafa Ismail Register irdma as a platform driver capable of supporting platform devices from multi-generation RDMA capable Intel HW. Establish the interface with all supported netdev peer devices and initialize HW. Signed-off-by: Mustafa Ismail Signed-off-by: Shiraz Saleem Signed-off-b

[RFC 11/20] RDMA/irdma: Add PBLE resource manager

2019-09-26 Thread Jeff Kirsher
From: Mustafa Ismail Implement a Physical Buffer List Entry (PBLE) resource manager to manage a pool of PBLE HMC resource objects. Signed-off-by: Mustafa Ismail Signed-off-by: Shiraz Saleem --- drivers/infiniband/hw/irdma/pble.c | 511 + drivers/infiniband/hw/irdma

Re: [PATCH V11 0/4] BPF: New helper to obtain namespace data from current task

2019-09-26 Thread John Fastabend
Eric W. Biederman wrote: > Carlos Neira writes: > > > Currently bpf_get_current_pid_tgid(), is used to do pid filtering in bcc's > > scripts but this helper returns the pid as seen by the root namespace which > > is > > fine when a bcc script is not executed inside a container. > > When the proc

Re: [PATCH iproute2(-next) v2 1/1] ip: fix ip route show json output for multipath nexthops

2019-09-26 Thread Stephen Hemminger
On Thu, 26 Sep 2019 17:29:34 +0200 Julien Fortin wrote: > + print_string(PRINT_ANY, "dev", > + "%s", ll_index_to_name(nh->rtnh_ifindex)) you might want to use interface color for this?

Re: [PATCH V11 0/4] BPF: New helper to obtain namespace data from current task

2019-09-26 Thread Yonghong Song
On 9/25/19 5:59 PM, Eric W. Biederman wrote: > Carlos Neira writes: > >> Currently bpf_get_current_pid_tgid(), is used to do pid filtering in bcc's >> scripts but this helper returns the pid as seen by the root namespace which >> is >> fine when a bcc script is not executed inside a container.

[PATCH iproute2(-next) v2 1/1] ip: fix ip route show json output for multipath nexthops

2019-09-26 Thread Julien Fortin
From: Julien Fortin print_rta_multipath doesn't support JSON output: { "dst":"27.0.0.13", "protocol":"bgp", "metric":20, "flags":[], "gateway":"169.254.0.1"dev uplink-1 weight 1 , "flags":["onlink"], "gateway":"169.254.0.1"dev uplink-2 weight 1 , "flags":["onlink"

Re: CONFIG_NET_TC_SKB_EXT

2019-09-26 Thread Paul Blakey
On 9/26/2019 5:26 PM, Edward Cree wrote: > On 26/09/2019 14:56, Paul Blakey wrote: In nat scenarios the packet will be modified, and then there can be a miss:    -trk CT(zone X, Restore NAT),goto chain 1    +trk+est, match on ipv4, CT(zone Y), go

Re: TCP_USER_TIMEOUT, SYN-SENT and tcp_syn_retries

2019-09-26 Thread Eric Dumazet
On 9/25/19 1:46 AM, Marek Majkowski wrote: > Hello my favorite mailing list! > > Recently I've been looking into TCP_USER_TIMEOUT and noticed some > strange behaviour on fresh sockets in SYN-SENT state. Full writeup: > https://blog.cloudflare.com/when-tcp-sockets-refuse-to-die/ > > Here's a re

Re: [PATCH iproute2(-next) 1/1] ip: fix ip route show json output for multipath nexthops

2019-09-26 Thread David Ahern
On 9/24/19 4:32 PM, Julien Fortin wrote: > diff --git a/ip/iproute.c b/ip/iproute.c > index a4533851..5d5f1551 100644 > --- a/ip/iproute.c > +++ b/ip/iproute.c > @@ -649,23 +649,27 @@ static void print_rta_multipath(FILE *fp, const struct > rtmsg *r, > int len = RTA_PAYLOAD(rta); > int

[PATCH net] tcp_bbr: fix quantization code to not raise cwnd if not probing bandwidth

2019-09-26 Thread Kevin(Yudong) Yang
There was a bug in the previous logic that attempted to ensure gain cycling gets inflight above BDP even for small BDPs. This code correctly raised and lowered target inflight values during the gain cycle. And this code correctly ensured that cwnd was raised when probing bandwidth. However, it did

Re: CONFIG_NET_TC_SKB_EXT

2019-09-26 Thread Edward Cree
On 26/09/2019 14:56, Paul Blakey wrote: >>> In nat scenarios the packet will be modified, and then there can be a miss: >>> >>>    -trk CT(zone X, Restore NAT),goto chain 1 >>> >>>    +trk+est, match on ipv4, CT(zone Y), goto chain 2 >>> >>>    +trk+est, output..

Re: Fwd: [PATCH] bonding/802.3ad: fix slave initialization states race

2019-09-26 Thread Aleksei Zakharov
чт, 26 сент. 2019 г. в 07:38, Jay Vosburgh : > > Aleksei Zakharov wrote: > > >ср, 25 сент. 2019 г. в 03:31, Jay Vosburgh : > >> > >> Алексей Захаров wrote: > >> [...] > >> >Right after reboot one of the slaves hangs with actor port state 71 > >> >and partner port state 1. > >> >It doesn't send lac

[PATCH net] sk_buff: drop all skb extensions on free and skb scrubbing

2019-09-26 Thread Florian Westphal
Now that we have a 3rd extension, add a new helper that drops the extension space and use it when we need to scrub an sk_buff. At this time, scrubbing clears secpath and bridge netfilter data, but retains the tc skb extension, after this patch all three get cleared. NAPI reuse/free assumes we can

Re: CONFIG_NET_TC_SKB_EXT

2019-09-26 Thread Paul Blakey
On 9/26/2019 4:09 PM, Edward Cree wrote: > On 26/09/2019 08:30, Paul Blakey wrote: >> Ok, I thought you meant merging the rules because we do want to support >> those modifications use-cases. > I think the point is that your use-case is sufficiently weird and >  obscure that code in the core to s

Re: [PATCH V2] net: dsa: microchip: Always set regmap stride to 1

2019-09-26 Thread George McCollister
On Wed, Sep 25, 2019 at 5:08 PM Marek Vasut wrote: > > The regmap stride is set to 1 for regmap describing 8bit registers already. > However, for 16/32/64bit registers, the stride is 2/4/8 respectively. This > is not correct, as the switch protocol supports unaligned register reads > and writes an

Re: DSA driver kernel extension for dsa mv88e6190 switch

2019-09-26 Thread Andrew Lunn
On Thu, Sep 26, 2019 at 03:23:48PM +0200, Zoran Stojsavljevic wrote: > Hello Andrew, > > I would like to thank you for the reply. > > I do not know if this is the right place to post such the questions, > but my best guess is: yes. > > Since till now I did not make any success to make (using DSA

Re: [PATCH net] net: axienet: fix a signedness bug in probe

2019-09-26 Thread Andrew Lunn
> The get_phy_mode() function seem like they lend themselves to creating > these bugs. The ->phy_mode variables tend to be declared in the driver > so it would require quite a few patches to make them all int and I'm not > sure that's more beautiful. Andrew Lunn's idea to update the API would > p

Re: DSA driver kernel extension for dsa mv88e6190 switch

2019-09-26 Thread Zoran Stojsavljevic
Hello Andrew, I would like to thank you for the reply. I do not know if this is the right place to post such the questions, but my best guess is: yes. Since till now I did not make any success to make (using DSA driver) make mv88e6190 single switch to work with any kernel.org. :-( I did ugly wo

Re: [PATCH net] net: axienet: fix a signedness bug in probe

2019-09-26 Thread Dan Carpenter
On Wed, Sep 25, 2019 at 01:05:43PM +0200, Alvaro G. M wrote: > Hi, Dan > > On Wed, Sep 25, 2019 at 01:59:11PM +0300, Dan Carpenter wrote: > > The "lp->phy_mode" is an enum but in this context GCC treats it as an > > unsigned int so the error handling is never triggered. > > > > lp->ph

Re: Are BPF tail calls only supposed to work with pinned maps?

2019-09-26 Thread Toke Høiland-Jørgensen
Daniel Borkmann writes: > Hi Toke, > > On Thu, Sep 26, 2019 at 01:23:38PM +0200, Toke Høiland-Jørgensen wrote: > [...] >> While working on a prototype of the XDP chain call feature, I ran into >> some strange behaviour with tail calls: If I create a userspace program >> that loads two XDP program

Re: CONFIG_NET_TC_SKB_EXT

2019-09-26 Thread Edward Cree
On 26/09/2019 08:30, Paul Blakey wrote: > Ok, I thought you meant merging the rules because we do want to support > those modifications use-cases. I think the point is that your use-case is sufficiently weird and  obscure that code in the core to support it needs to be unintrusive;  and this clear

Re: Are BPF tail calls only supposed to work with pinned maps?

2019-09-26 Thread Daniel Borkmann
Hi Toke, On Thu, Sep 26, 2019 at 01:23:38PM +0200, Toke Høiland-Jørgensen wrote: [...] > While working on a prototype of the XDP chain call feature, I ran into > some strange behaviour with tail calls: If I create a userspace program > that loads two XDP programs, one of which tail calls the other

Re: [PATCH bpf] libbpf: teach btf_dumper to emit stand-alone anonymous enum definitions

2019-09-26 Thread Daniel Borkmann
On Wed, Sep 25, 2019 at 01:37:45PM -0700, Andrii Nakryiko wrote: > BTF-to-C converter previously skipped anonymous enums in an assumption > that those are embedded in struct's field definitions. This is not > always the case and a lot of kernel constants are defined as part of > anonymous enums. Th

Re: [PATCH net] devlink: Fix error handling in param and info_get dumpit cb

2019-09-26 Thread Andrew Lunn
On Thu, Sep 26, 2019 at 03:05:54PM +0530, Vasundhara Volam wrote: > If any of the param or info_get op returns error, dumpit cb is > skipping to dump remaining params or info_get ops for all the > drivers. > > Instead skip only for the param/info_get op which returned error > and continue to dump

[PATCH net 0/3] mlxsw: Various fixes

2019-09-26 Thread Ido Schimmel
From: Ido Schimmel This patchset includes two small fixes for the mlxsw driver and one patch which clarifies recently introduced devlink-trap documentation. Patch #1 clears the port's VLAN filters during port initialization. This ensures that the drop reason reported to the user is consistent. T

[PATCH net 1/3] mlxsw: spectrum: Clear VLAN filters during port initialization

2019-09-26 Thread Ido Schimmel
From: Ido Schimmel When a port is created, its VLAN filters are not cleared by the firmware. This causes tagged packets to be later dropped by the ingress STP filters, which default to DISCARD state. The above did not matter much until commit b5ce611fd96e ("mlxsw: spectrum: Add devlink-trap supp

[PATCH net 2/3] Documentation: Clarify trap's description

2019-09-26 Thread Ido Schimmel
From: Ido Schimmel Alex noted that the below description might not be obvious to all users. Clarify it by adding an example. Fixes: f3047ca01f12 ("Documentation: Add devlink-trap documentation") Reported-by: Alex Kushnarov Reviewed-by: Alex Kushnarov Acked-by: Jiri Pirko Signed-off-by: Ido Sc

[PATCH net 3/3] mlxsw: spectrum_flower: Fail in case user specifies multiple mirror actions

2019-09-26 Thread Ido Schimmel
From: Danielle Ratson The ASIC can only mirror a packet to one port, but when user is trying to set more than one mirror action, it doesn't fail. Add a check if more than one mirror action was specified per rule and if so, fail for not being supported. Fixes: d0d13c1858a11 ("mlxsw: spectrum_acl

  1   2   >