Re: [PATCH net] sk_buff: drop all skb extensions on free and skb scrubbing

[Eric Dumazet]

On 9/26/19 11:06 AM, Florian Westphal wrote:
> Eric Dumazet <eric.duma...@gmail.com> wrote:
>>> +static inline void skb_ext_reset(struct sk_buff *skb)
>>> +{
>>> +   if (skb->active_extensions) {
>>
>> This deserves an unlikely(skb->active_extensions) hint here ?
> 
> unlikely() isn't used in the other helpers (e.g. skb_ext_{put,del,copy}
> either, should I add it there too?
> 

At least in GRO paths unlikely() makes sense.

For other paths it might not be the case.