[PATCH v2 1/2][ethtool] ethtool: sync ethtool-copy.h: adds support for EDPD

2019-09-19 Thread Alexandru Ardelean
This change syncs the `ethtool-copy.h` file with Linux net-next to add support for Energy Detect Powerdown control via phy tunable. net-next commit: commit 1bab8d4c488be22d57f9dd09968c90a0ddc413bf Merge: 990925fad5c2 00b368502d18 Author: David S. Miller Date: Tue Sep 17 23:51:10 2019 +0200

[PATCH v2 2/2][ethtool] ethtool: implement support for Energy Detect Power Down

2019-09-19 Thread Alexandru Ardelean
This change adds control for enabling/disabling Energy Detect Power Down mode, as well as configuring wake-up intervals for TX pulses, via the new ETHTOOL_PHY_EDPD control added in PHY tunable, in the kernel. Signed-off-by: Alexandru Ardelean --- Changelog v1 -> v2: * reworked the parse_named_ui

Re: [PATCH 2/2][ethtool] ethtool: implement support for Energy Detect Power Down

2019-09-19 Thread Ardelean, Alexandru
On Thu, 2019-09-19 at 16:00 +0200, Andrew Lunn wrote: > [External] > > > -static int parse_named_u8(struct cmd_context *ctx, const char *name, > > u8 *val) > > +static int parse_named_uint(struct cmd_context *ctx, const char *name, > > + void *val, enum tunable_type_id type_i

Re: [PATCH net v2 1/3] net: sched: sch_htb: don't call qdisc_put() while holding tree lock

2019-09-19 Thread Vlad Buslov
On Fri 20 Sep 2019 at 01:49, Eric Dumazet wrote: > On 9/19/19 1:14 PM, Vlad Buslov wrote: >> Recent changes that removed rtnl dependency from rules update path of tc >> also made tcf_block_put() function sleeping. This function is called from >> ops->destroy() of several Qdisc implementations, w

Re: [PATCH net v2 1/3] net: sched: sch_htb: don't call qdisc_put() while holding tree lock

2019-09-19 Thread Vlad Buslov
On Fri 20 Sep 2019 at 04:05, Cong Wang wrote: > On Thu, Sep 19, 2019 at 1:14 PM Vlad Buslov wrote: >> Notes: >> Changes V1 -> V2: >> >> - Extend sch API with new qdisc_put_empty() function that has same >> implementation as regular qdisc_put() but skips parts that reset qdisc >>

[PATCH RFC 1/5] UDP: enable GRO by default.

2019-09-19 Thread Steffen Klassert
This patch enables UDP GRO regardless if a GRO capable socket is present. With this GRO is done by default for the local input and forwarding path. Signed-off-by: Steffen Klassert --- include/net/udp.h | 2 +- net/ipv4/udp_offload.c | 38 -- net/ipv6/udp

[PATCH RFC 4/5] net: Support GRO/GSO fraglist chaining.

2019-09-19 Thread Steffen Klassert
This patch adds the core functions to chain/unchain GSO skbs at the frag_list pointer. This also adds a new GSO type SKB_GSO_FRAGLIST and a is_flist flag to napi_gro_cb which indicates that this flow will be GROed by fraglist chaining. Signed-off-by: Steffen Klassert --- include/linux/netdevice.

[PATCH RFC 0/5] Support fraglist GRO/GSO

2019-09-19 Thread Steffen Klassert
This patchset adds support to do GRO/GSO by chaining packets of the same flow at the SKB frag_list pointer. This avoids the overhead to merge payloads into one big packet, and on the other end, if GSO is needed it avoids the overhead of splitting the big packet back to the native form. Patch 1 Ena

[PATCH RFC 2/5] net: Add fraglist GRO/GSO feature flags

2019-09-19 Thread Steffen Klassert
This adds new Fraglist GRO/GSO feature flags. They will be used to configure fraglist GRO/GSO what will be implemented with some followup paches. Signed-off-by: Steffen Klassert --- include/linux/netdev_features.h | 6 +- include/linux/netdevice.h | 1 + include/linux/skbuff.h

[PATCH RFC 5/5] udp: Support UDP fraglist GRO/GSO.

2019-09-19 Thread Steffen Klassert
This patch extends UDP GRO to support fraglist GRO/GSO by using the previously introduced infrastructure. All UDP packets that are not targeted to a GRO capable UDP sockets are going to fraglist GRO now (local input and forward). Signed-off-by: Steffen Klassert --- net/ipv4/udp_offload.c | 56 ++

[PATCH RFC 3/5] net: Add a netdev software feature set that defaults to off.

2019-09-19 Thread Steffen Klassert
The previous patch added the NETIF_F_GRO_FRAGLIST feature. This is a software feature that should default to off. Current software features default to on, so add a new feature set that defaults to off. Signed-off-by: Steffen Klassert --- include/linux/netdev_features.h | 3 +++ net/core/dev.c

Re: [v3 2/3] samples: pktgen: add helper functions for IP(v4/v6) CIDR parsing

2019-09-19 Thread Daniel T. Lee
Thanks for the feedback! How about just capturing with "Result: OK" except for 'pgctrl'? (more details are in the diff below) ~/git/linux/net$ ag -Q 'Result:' core/pktgen.c 702:seq_printf(seq, "Result: %s\n", pkt_dev->result); 704:seq_puts(seq, "Result: Idl

[PATCHv2 iproute2 master] bpf: Fix race condition with map pinning

2019-09-19 Thread Joe Stringer
If two processes attempt to invoke bpf_map_attach() at the same time, then they will both create maps, then the first will successfully pin the map to the filesystem and the second will not pin the map, but will continue operating with a reference to its own copy of the map. As a result, the sharin

Re: [PATCH iproute2 master] bpf: Fix race condition with map pinning

2019-09-19 Thread Joe Stringer
On Thu, Sep 19, 2019 at 3:07 PM Joe Stringer wrote: > > If two processes attempt to invoke bpf_map_attach() at the same time, > then they will both create maps, then the first will successfully pin > the map to the filesystem and the second will not pin the map, but will > continue operating with

Re: [PATCH] selftests: Add test cases for `ip nexthop flush proto XX`

2019-09-19 Thread Jakub Kicinski
On Mon, 16 Sep 2019 08:26:50 -0400, Donald Sharp wrote: > Add some test cases to allow the fib_nexthops.sh test code > to test the flushing of nexthops based upon the proto passed > in upon creation of the nexthop group. > > Signed-off-by: Donald Sharp Applied, thank you!

[PATCH] ath10k: fix memory leak

2019-09-19 Thread Navid Emamdoost
In ath10k_usb_hif_tx_sg the allocated urb should be released if usb_submit_urb fails. Signed-off-by: Navid Emamdoost --- drivers/net/wireless/ath/ath10k/usb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ath/ath10k/usb.c b/drivers/net/wireless/ath/ath10k/usb.c index

Re: [PATCH] dt-bindings: net: Correct the documentation of KSZ9021 skew values

2019-09-19 Thread Jakub Kicinski
On Mon, 16 Sep 2019 17:40:35 +, James Byrne wrote: > On 16/09/2019 15:14, David Miller wrote: > > From: James Byrne > > Date: Fri, 13 Sep 2019 16:46:35 + > > > >> The documentation of skew values for the KSZ9021 PHY was misleading > >> because the driver implementation followed the erro

Re: [PATCH net v2 1/3] net: sched: sch_htb: don't call qdisc_put() while holding tree lock

2019-09-19 Thread Cong Wang
On Thu, Sep 19, 2019 at 1:14 PM Vlad Buslov wrote: > Notes: > Changes V1 -> V2: > > - Extend sch API with new qdisc_put_empty() function that has same > implementation as regular qdisc_put() but skips parts that reset qdisc > and free all packet buffers from gso_skb and skb_bad

Re: ionic build issues?

2019-09-19 Thread Jakub Kicinski
On Thu, 19 Sep 2019 17:29:28 -0700, Randy Dunlap wrote: > On 9/19/19 5:27 PM, Jakub Kicinski wrote: > > Hi Shannon! > > > > I've enabled ionic to do some build testing before pushing patches > > today, and with my tree which I build with W=1 C=1 I run into this: > > > > ../drivers/net/ethernet/pe

Re: [PATCH net] ibmvnic: Warn unknown speed message only when carrier is present

2019-09-19 Thread Jakub Kicinski
On Mon, 16 Sep 2019 11:50:37 -0300, Murilo Fossa Vicentini wrote: > With commit 0655f9943df2 ("net/ibmvnic: Update carrier state after link > state change") we are now able to detect when the carrier is properly > present in the device, so only report an unexpected unknown speed when it > is proper

Re: ionic build issues?

2019-09-19 Thread Randy Dunlap
On 9/19/19 5:27 PM, Jakub Kicinski wrote: > Hi Shannon! > > I've enabled ionic to do some build testing before pushing patches > today, and with my tree which I build with W=1 C=1 I run into this: > > ../drivers/net/ethernet/pensando/ionic/ionic_main.c: In function > ‘ionic_adminq_cb’: > ../driv

ionic build issues?

2019-09-19 Thread Jakub Kicinski
Hi Shannon! I've enabled ionic to do some build testing before pushing patches today, and with my tree which I build with W=1 C=1 I run into this: ../drivers/net/ethernet/pensando/ionic/ionic_main.c: In function ‘ionic_adminq_cb’: ../drivers/net/ethernet/pensando/ionic/ionic_main.c:229:2: error:

Re: [PATCH iproute2 master] bpf: Fix race condition with map pinning

2019-09-19 Thread Daniel Borkmann
On Thu, Sep 19, 2019 at 03:07:33PM -0700, Joe Stringer wrote: > If two processes attempt to invoke bpf_map_attach() at the same time, > then they will both create maps, then the first will successfully pin > the map to the filesystem and the second will not pin the map, but will > continue operatin

Re: [PATCH net v2 1/3] net: sched: sch_htb: don't call qdisc_put() while holding tree lock

2019-09-19 Thread Eric Dumazet
On 9/19/19 1:14 PM, Vlad Buslov wrote: > Recent changes that removed rtnl dependency from rules update path of tc > also made tcf_block_put() function sleeping. This function is called from > ops->destroy() of several Qdisc implementations, which in turn is called by > qdisc_put(). Some Qdiscs c

Re: [PATCH net-next] net: dsa: mv88e6xxx: Add support for port mirroring

2019-09-19 Thread Florian Fainelli
On 9/19/19 2:30 PM, Jason Cobham wrote: > Hi Iwan, > >> Hi Andrew, >> >> I only own a simple 5 ports switch (88E6176) which has no problem of >> mirroring the other ports to a single port. Except for a bandwith shortage >> ofcourse. While I thought I checked adding and removing ports, I seemed t

[PATCH iproute2 master] bpf: Fix race condition with map pinning

2019-09-19 Thread Joe Stringer
If two processes attempt to invoke bpf_map_attach() at the same time, then they will both create maps, then the first will successfully pin the map to the filesystem and the second will not pin the map, but will continue operating with a reference to its own copy of the map. As a result, the sharin

[PATCH RFC] thermal: Fix broken registration if a sensor OF node is missing

2019-09-19 Thread Peter Mamonov
When devm_thermal_zone_of_sensor_register() is called from hwmon_thermal_add_sensor() it is possible that the relevant sensor is missing an OF node. In this case thermal_zone_of_sensor_register() returns -EINVAL which causes hwmon_thermal_add_sensor() to fail as well. This patch changes relevant re

Re: [PATCH net-next] net: dsa: mv88e6xxx: Add support for port mirroring

2019-09-19 Thread Jason Cobham
Hi Iwan, >Hi Andrew, > >I only own a simple 5 ports switch (88E6176) which has no problem of mirroring >the other ports to a single port. Except for a bandwith shortage ofcourse. >While I thought I checked adding and removing ports, I seemed to forgot to >check removing ingress traffic as it wi

Re: Bug report (with fix) for DEC Tulip driver (de2104x.c)

2019-09-19 Thread Sven Schnelle
Hi, On Wed, Sep 18, 2019 at 07:56:16AM +0200, Helge Deller wrote: > On 18.09.19 00:51, John David Anglin wrote: > > On 2019-09-17 5:36 p.m., Arlie Davis wrote: > >> Likewise, I'm at a loss for testing with real hardware. It's hard to > >> find such things, now. > > How does de2104x compare to ds21

Re: [PATCH v4.14-stable 0/2] Fixes to commit fdfc5c8594c2 (tcp: remove empty skb from write queue in error cases)

2019-09-19 Thread Christoph Paasch
On Thu, Sep 19, 2019 at 1:07 PM Greg Kroah-Hartman wrote: > > On Thu, Sep 19, 2019 at 08:21:43AM -0700, Christoph Paasch wrote: > > Hello Greg & Sasha, > > > > On Sat, Sep 14, 2019 at 12:20 AM Christoph Paasch wrote: > > > > > > > > > The above referenced commit has problems on older non-rbTree k

[PATCH net v2 3/3] net: sched: sch_sfb: don't call qdisc_put() while holding tree lock

2019-09-19 Thread Vlad Buslov
Recent changes that removed rtnl dependency from rules update path of tc also made tcf_block_put() function sleeping. This function is called from ops->destroy() of several Qdisc implementations, which in turn is called by qdisc_put(). Some Qdiscs call qdisc_put() while holding sch tree spinlock, w

[PATCH net v2 1/3] net: sched: sch_htb: don't call qdisc_put() while holding tree lock

2019-09-19 Thread Vlad Buslov
Recent changes that removed rtnl dependency from rules update path of tc also made tcf_block_put() function sleeping. This function is called from ops->destroy() of several Qdisc implementations, which in turn is called by qdisc_put(). Some Qdiscs call qdisc_put() while holding sch tree spinlock, w

[PATCH net v2 2/3] net: sched: multiq: don't call qdisc_put() while holding tree lock

2019-09-19 Thread Vlad Buslov
Recent changes that removed rtnl dependency from rules update path of tc also made tcf_block_put() function sleeping. This function is called from ops->destroy() of several Qdisc implementations, which in turn is called by qdisc_put(). Some Qdiscs call qdisc_put() while holding sch tree spinlock, w

[PATCH net v2 0/3] Fix Qdisc destroy issues caused by adding fine-grained locking to filter API

2019-09-19 Thread Vlad Buslov
TC filter API unlocking introduced several new fine-grained locks. The change caused sleeping-while-atomic BUGs in several Qdiscs that call cls APIs which need to obtain new mutex while holding sch tree spinlock. This series fixes affected Qdiscs by ensuring that cls API that became sleeping is onl

Re: [PATCH v4.14-stable 0/2] Fixes to commit fdfc5c8594c2 (tcp: remove empty skb from write queue in error cases)

2019-09-19 Thread Greg Kroah-Hartman
On Thu, Sep 19, 2019 at 08:21:43AM -0700, Christoph Paasch wrote: > Hello Greg & Sasha, > > On Sat, Sep 14, 2019 at 12:20 AM Christoph Paasch wrote: > > > > > > The above referenced commit has problems on older non-rbTree kernels. > > > > AFAICS, the commit has only been backported to 4.14 up to

Re: [PATCH net 0/3] Fix Qdisc destroy issues caused by adding fine-grained locking to filter API

2019-09-19 Thread Cong Wang
On Thu, Sep 19, 2019 at 1:53 AM Vlad Buslov wrote: > > > On Thu 19 Sep 2019 at 01:50, Cong Wang wrote: > > On Wed, Sep 18, 2019 at 12:32 AM Vlad Buslov wrote: > >> > >> TC filter API unlocking introduced several new fine-grained locks. The > >> change caused sleeping-while-atomic BUGs in several

INVESTMENT PROPOSAL.

2019-09-19 Thread Hadel Issa
It’s my pleasure to contact you through this media because I need an investment assistance in your country. However I have a profitable investment proposal with good interest to share with you, amounted the sum of (Twenty Eight Million Four Hundred Thousand United State Dollar ($28.400.000.00). If

Re: [bpf-next,v3] samples: bpf: add max_pckt_size option at xdp_adjust_tail

2019-09-19 Thread Andrii Nakryiko
On Thu, Sep 19, 2019 at 2:16 AM Daniel T. Lee wrote: > > On Thu, Sep 19, 2019 at 3:00 AM Andrii Nakryiko > wrote: > > > > On Wed, Sep 18, 2019 at 10:37 AM Daniel T. Lee > > wrote: > > > > > > On Tue, Sep 17, 2019 at 1:04 PM Andrii Nakryiko > > > wrote: > > > > > > > > On Wed, Sep 11, 2019 at 2

[PATCH net] ipv6: fix a typo in fib6_rule_lookup()

2019-09-19 Thread Eric Dumazet
Yi Ren reported an issue discovered by syzkaller, and bisected to the cited commit. Many thanks to Yi, this trivial patch does not reflect the patient work that has been done. Fixes: d64a1f574a29 ("ipv6: honor RT6_LOOKUP_F_DST_NOREF in rule lookup logic") Signed-off-by: Eric Dumazet Acked-by: We

Re: dsa traffic priorization

2019-09-19 Thread Florian Fainelli
On 9/19/19 1:44 AM, Sascha Hauer wrote: > Hi Florian, > > On Wed, Sep 18, 2019 at 10:41:58AM -0700, Florian Fainelli wrote: >> On 9/18/19 7:36 AM, Vladimir Oltean wrote: >>> Hi Sascha, >>> >>> On Wed, 18 Sep 2019 at 17:03, Sascha Hauer wrote: Hi All, We have a customer using a

Re: ELOed stable kernels

2019-09-19 Thread Greg Kroah-Hartman
On Thu, Sep 19, 2019 at 05:00:09PM +0200, Matthias May wrote: > On 19/09/2019 16:44, Greg Kroah-Hartman wrote: > > On Thu, Sep 19, 2019 at 04:39:28PM +0200, Matthias May wrote: > >> On 19/09/2019 16:05, Or Gerlitz wrote: > >>> Hi Greg, > >>> > >>> If this is RTFM could you please point me to the Em

[PATCH iproute2-next] ip vrf: Add json support for show command

2019-09-19 Thread David Ahern
From: David Ahern Add json support to 'ip vrf sh': $ ip -j -p vrf ls [ { "name": "mgmt", "table": 1001 } ] Signed-off-by: David Ahern --- ip/ipvrf.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/ip/ipvrf.c b/ip/ipvrf.c index 4336

Segregating L2 forwarding domains with ocelot

2019-09-19 Thread Vladimir Oltean
Hi Alex, Joergen, Allan, Currently the ocelot driver rejects enslaving switch ports to more than one bridge: static int ocelot_port_bridge_join(struct ocelot_port *ocelot_port, struct net_device *bridge) { struct ocelot *ocelot = ocelot_port->ocelot; if (!ocelot->bridg

Re: Fwd: [PATCH] bonding/802.3ad: fix slave initialization states race

2019-09-19 Thread Jay Vosburgh
Алексей Захаров wrote: >чт, 19 сент. 2019 г. в 11:00, Jay Vosburgh : >> >> Алексей Захаров wrote: >> >> >> >Once a while, one of 802.3ad slaves fails to initialize and hangs in >> >> >BOND_LINK_FAIL state. Commit 334031219a84 ("bonding/802.3ad: fix slave >> >> >link initialization transition state

Re: [PATCH v4.14-stable 0/2] Fixes to commit fdfc5c8594c2 (tcp: remove empty skb from write queue in error cases)

2019-09-19 Thread Christoph Paasch
Hello Greg & Sasha, On Sat, Sep 14, 2019 at 12:20 AM Christoph Paasch wrote: > > > The above referenced commit has problems on older non-rbTree kernels. > > AFAICS, the commit has only been backported to 4.14 up to now, but the > commit that fdfc5c8594c2 is fixing (namely ce5ec440994b ("tcp: ensu

Re: CONFIG_NET_TC_SKB_EXT

2019-09-19 Thread Vlad Buslov
On Thu 19 Sep 2019 at 14:21, David Miller wrote: > As Linus pointed out, the Kconfig logic for CONFIG_NET_TC_SKB_EXT > is really not acceptable. > > It should not be enabled by default at all. > > Instead the actual users should turn it on or depend upon it, which in > this case seems to be OVS.

Re: ELOed stable kernels

2019-09-19 Thread Matthias May
On 19/09/2019 16:44, Greg Kroah-Hartman wrote: > On Thu, Sep 19, 2019 at 04:39:28PM +0200, Matthias May wrote: >> On 19/09/2019 16:05, Or Gerlitz wrote: >>> Hi Greg, >>> >>> If this is RTFM could you please point me to the Emm >>> >>> AFAIR if a stable kernel is not listed at kernel.org than it is

Re: [patch iproute2-next v2] devlink: add reload failed indication

2019-09-19 Thread David Ahern
On 9/18/19 2:23 PM, Jiri Pirko wrote: > Wed, Sep 18, 2019 at 10:01:31PM CEST, dsah...@gmail.com wrote: >> On 9/18/19 1:37 AM, Jiri Pirko wrote: >>> Wed, Sep 18, 2019 at 01:46:13AM CEST, dsah...@gmail.com wrote: On 9/17/19 12:36 PM, Jiri Pirko wrote: > Tue, Sep 17, 2019 at 06:46:31PM CEST,

Re: ELOed stable kernels

2019-09-19 Thread Matthias May
On 19/09/2019 16:05, Or Gerlitz wrote: > Hi Greg, > > If this is RTFM could you please point me to the Emm > > AFAIR if a stable kernel is not listed at kernel.org than it is EOL by now. > > Is this correct? > > thanks, > > Or. > You can also look at the wikipedia page at https://en.wikipedi

Re: [PATCH iproute2-next v2] bpf: replace snprintf with asprintf when dealing with long buffers

2019-09-19 Thread David Ahern
On 9/16/19 7:00 AM, Andrea Claudi wrote: > This reduces stack usage, as asprintf allocates memory on the heap. > > This indirectly fixes a snprintf truncation warning (from gcc v9.2.1): > > bpf.c: In function ‘bpf_get_work_dir’: > bpf.c:784:49: warning: ‘snprintf’ output may be truncated before t

Re: dsa traffic priorization

2019-09-19 Thread Jan Lübbe
Hi Andrew, thanks for your detail explanation! On Thu, 2019-09-19 at 15:34 +0200, Andrew Lunn wrote: > On Thu, Sep 19, 2019 at 10:00:51AM +0200, Sascha Hauer wrote: > > Hi Vladimir, > > > > On Wed, Sep 18, 2019 at 05:36:08PM +0300, Vladimir Oltean wrote: > > > Hi Sascha, > > > > > > On Wed, 18

Re: ELOed stable kernels

2019-09-19 Thread Greg Kroah-Hartman
On Thu, Sep 19, 2019 at 04:39:28PM +0200, Matthias May wrote: > On 19/09/2019 16:05, Or Gerlitz wrote: > > Hi Greg, > > > > If this is RTFM could you please point me to the Emm > > > > AFAIR if a stable kernel is not listed at kernel.org than it is EOL by now. > > > > Is this correct? > > > > t

Re: [PATCH V2 net-next 0/5] Introduce ethtool's set_channels

2019-09-19 Thread David Miller
net-next is closed

Re: [PATCH net-next] tcp: force a PSH flag on TSO packets

2019-09-19 Thread Eric Dumazet
On Thu, Sep 19, 2019 at 7:01 AM Or Gerlitz wrote: > > On Thu, Sep 19, 2019 at 4:46 PM Eric Dumazet wrote: > > On 9/19/19 5:17 AM, Or Gerlitz wrote: > > > On Wed, Sep 11, 2019 at 12:54 AM Eric Dumazet wrote: > > >> When tcp sends a TSO packet, adding a PSH flag on it > > >> reduces the sojourn ti

Re: ELOed stable kernels

2019-09-19 Thread Greg Kroah-Hartman
On Thu, Sep 19, 2019 at 05:05:45PM +0300, Or Gerlitz wrote: > Hi Greg, > > If this is RTFM could you please point me to the Emm https://www.kernel.org/category/releases.html > AFAIR if a stable kernel is not listed at kernel.org than it is EOL by now. > > Is this correct? Yes. thanks, greg k

ELOed stable kernels

2019-09-19 Thread Or Gerlitz
Hi Greg, If this is RTFM could you please point me to the Emm AFAIR if a stable kernel is not listed at kernel.org than it is EOL by now. Is this correct? thanks, Or.

RE: [PATCH V1 net-next 2/5] net: ena: multiple queue creation related cleanups

2019-09-19 Thread Jubran, Samih
> -Original Message- > From: David Miller > Sent: Monday, September 16, 2019 10:45 PM > To: Jubran, Samih > Cc: netdev@vger.kernel.org; Woodhouse, David ; > Machulsky, Zorik ; Matushevsky, Alexander > ; Bshara, Saeed ; Wilson, > Matt ; Liguori, Anthony ; > Bshara, Nafea ; Tzalik, Guy ;

[PATCH V2 net-next 2/5] net: ena: multiple queue creation related cleanups

2019-09-19 Thread sameehj
From: Sameeh Jubran - Rename ena_calc_queue_size() to ena_calc_io_queue_size() for clarity and consistency - Remove redundant number of io queues parameter in functions ena_enable_msix() and ena_enable_msix_and_set_admin_interrupts(), which already get adapter parameter, so use adapter->num

[PATCH V2 net-next 4/5] net: ena: remove redundant print of number of queues

2019-09-19 Thread sameehj
From: Sameeh Jubran The number of queues can be derived using ethtool, no need to print it in ena_probe() Signed-off-by: Sameeh Jubran --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/amazon/ena/ena_ne

[PATCH V2 net-next 5/5] net: ena: ethtool: support set_channels callback

2019-09-19 Thread sameehj
From: Sameeh Jubran Set channels callback enables the user to change the count of queues used by the driver using ethtool. We decided to currently support only equal number of rx and tx queues, this might change in the future. Also rename dev_up to dev_was_up in ena_update_queue_count() to make

[PATCH V2 net-next 0/5] Introduce ethtool's set_channels

2019-09-19 Thread sameehj
From: Sameeh Jubran Difference from v1: * Dropped the print from patch 0002 - "net: ena: multiple queue creation related cleanups" as requested by David Miller Sameeh Jubran (5): net: ena: change num_queues to num_io_queues for clarity and consistency net: ena: multiple queue creation

[PATCH V2 net-next 3/5] net: ena: make ethtool -l show correct max number of queues

2019-09-19 Thread sameehj
From: Sameeh Jubran - Update ena_ethtool:ena_get_channels() to return adapter->max_io_queues so that ethtool -l returns the correct maximum queue number. - Change the name of ena_calc_io_queue_num() to ena_calc_max_io_queue_num() as it returns the maximum number of io queues and actual num

[PATCH V2 net-next 1/5] net: ena: change num_queues to num_io_queues for clarity and consistency

2019-09-19 Thread sameehj
From: Sameeh Jubran Most places in the code refer to the IO queues as io_queues and not simply queues. Examples - max_io_queues_per_vf, ENA_MAX_NUM_IO_QUEUES, ena_destroy_all_io_queues() etc.. We are also adding the new max_num_io_queues field to struct ena_adapter in the following commit. The

Re: [PATCH net-next] tcp: force a PSH flag on TSO packets

2019-09-19 Thread Or Gerlitz
On Thu, Sep 19, 2019 at 4:46 PM Eric Dumazet wrote: > On 9/19/19 5:17 AM, Or Gerlitz wrote: > > On Wed, Sep 11, 2019 at 12:54 AM Eric Dumazet wrote: > >> When tcp sends a TSO packet, adding a PSH flag on it > >> reduces the sojourn time of GRO packet in GRO receivers. > >> > >> This is particular

Re: [PATCH 2/2][ethtool] ethtool: implement support for Energy Detect Power Down

2019-09-19 Thread Andrew Lunn
> -static int parse_named_u8(struct cmd_context *ctx, const char *name, u8 *val) > +static int parse_named_uint(struct cmd_context *ctx, const char *name, > + void *val, enum tunable_type_id type_id) > { > if (ctx->argc < 2) > return 0; > @@ -5026,7 +505

[PATCH v2 03/20] staging: wfx: add I/O API

2019-09-19 Thread Jerome Pouiller
From: Jérôme Pouiller hwio.c provides an abstraction to access different types of register of the chip. Note that only data register (aka FRAME_OUT) and control register are used normal communication. Other registers are only used during chip start up. Signed-off-by: Jérôme Pouiller --- drive

[PATCH v2 13/20] staging: wfx: introduce "secure link"

2019-09-19 Thread Jerome Pouiller
From: Jérôme Pouiller Chip support encryption of the link between host and chip. This feature is called "secure link". Driver code on github[1] support it. However, it relies on mbedtls for cryptographic functions. So, I decided to not import this feature in current patch. However, in order to ke

[PATCH v2 06/20] staging: wfx: import HIF API headers

2019-09-19 Thread Jerome Pouiller
From: Jérôme Pouiller These files are shared with firmware sources. Only a subset of these definitions are used by driver but, for now, it is easier to import all. API defines 3 kinds of messages: - Requests (req) are sent from host to chip - Confirmations (cnf) are sent by chip and are al

Re: [PATCH RFC] net/phy: fix Marvell PHYs probe failure when HWMON and THERMAL_OF are enabled

2019-09-19 Thread Andrew Lunn
On Thu, Sep 19, 2019 at 11:10:56AM +0300, Peter Mamonov wrote: > Hi, Andrew, > > On Thu, Sep 19, 2019 at 04:50:16AM +0200, Andrew Lunn wrote: > > On Thu, Sep 19, 2019 at 12:38:37AM +0300, Peter Mamonov wrote: > > > Hello, > > > > > > Some time ago I've discovered that probe functions of certain M

Re: [PATCH RFC v3 0/5] Support fraglist GRO/GSO

2019-09-19 Thread Paolo Abeni
On Thu, 2019-09-19 at 15:37 +0300, Or Gerlitz wrote: > On Wed, Sep 18, 2019 at 2:48 PM Steffen Klassert > wrote: > > This patchset adds support to do GRO/GSO by chaining packets > > of the same flow at the SKB frag_list pointer. This avoids > > the overhead to merge payloads into one big packet, a

Re: [PATCH net-next] tcp: force a PSH flag on TSO packets

2019-09-19 Thread Eric Dumazet
On 9/19/19 5:17 AM, Or Gerlitz wrote: > On Wed, Sep 11, 2019 at 12:54 AM Eric Dumazet wrote: >> When tcp sends a TSO packet, adding a PSH flag on it >> reduces the sojourn time of GRO packet in GRO receivers. >> >> This is particularly the case under pressure, since RX queues >> receive packets

Re: dsa traffic priorization

2019-09-19 Thread Jan Lübbe
On Wed, 2019-09-18 at 10:41 -0700, Florian Fainelli wrote: > > > The other part of the problem seems to be that the CPU port has no > > > network device > > > representation in Linux, so there's no interface to configure the egress > > > limits via tc. > > > This has been discussed before, but it

Re: dsa traffic priorization

2019-09-19 Thread Andrew Lunn
On Thu, Sep 19, 2019 at 10:00:51AM +0200, Sascha Hauer wrote: > Hi Vladimir, > > On Wed, Sep 18, 2019 at 05:36:08PM +0300, Vladimir Oltean wrote: > > Hi Sascha, > > > > On Wed, 18 Sep 2019 at 17:03, Sascha Hauer wrote: > > > > > > Hi All, > > > > > > We have a customer using a Marvell 88e6240 sw

Re: dsa traffic priorization

2019-09-19 Thread Vladimir Oltean
Hi Jan, On Thu, 19 Sep 2019 at 16:21, Jan Lübbe wrote: > > Hi, > > On Wed, 2019-09-18 at 10:41 -0700, Florian Fainelli wrote: > > > Technically, configuring a match-all rxnfc rule with ethtool would > > > count as 'default priority' - I have proposed that before. Now I'm not > > > entirely sure h

Re: [PATCH RFC v3 0/5] Support fraglist GRO/GSO

2019-09-19 Thread Willem de Bruijn
On Thu, Sep 19, 2019 at 9:07 AM Marcelo Ricardo Leitner wrote: > > On Thu, Sep 19, 2019 at 08:55:22AM -0400, Willem de Bruijn wrote: > > On Wed, Sep 18, 2019 at 12:58 PM Marcelo Ricardo Leitner > > wrote: > > > > > > On Wed, Sep 18, 2019 at 12:17:08PM -0400, Willem de Bruijn wrote: > > > > On Wed

Re: dsa traffic priorization

2019-09-19 Thread Jan Lübbe
Hi, On Wed, 2019-09-18 at 10:41 -0700, Florian Fainelli wrote: > > Technically, configuring a match-all rxnfc rule with ethtool would > > count as 'default priority' - I have proposed that before. Now I'm not > > entirely sure how intuitive it is, but I'm also interested in being > > able to confi

Re: [PATCH RFC v3 0/5] Support fraglist GRO/GSO

2019-09-19 Thread Marcelo Ricardo Leitner
On Thu, Sep 19, 2019 at 11:41:06AM +0200, Steffen Klassert wrote: > On Wed, Sep 18, 2019 at 12:17:08PM -0400, Willem de Bruijn wrote: > > On Wed, Sep 18, 2019 at 3:25 AM Steffen Klassert > > wrote: > > > > > > This patchset adds support to do GRO/GSO by chaining packets > > > of the same flow at t

Re: [PATCH RFC v3 0/5] Support fraglist GRO/GSO

2019-09-19 Thread Marcelo Ricardo Leitner
On Thu, Sep 19, 2019 at 08:55:22AM -0400, Willem de Bruijn wrote: > On Wed, Sep 18, 2019 at 12:58 PM Marcelo Ricardo Leitner > wrote: > > > > On Wed, Sep 18, 2019 at 12:17:08PM -0400, Willem de Bruijn wrote: > > > On Wed, Sep 18, 2019 at 3:25 AM Steffen Klassert > > > wrote: > > > > > > > > This

Re: [PATCH RFC v3 0/5] Support fraglist GRO/GSO

2019-09-19 Thread Willem de Bruijn
On Wed, Sep 18, 2019 at 12:58 PM Marcelo Ricardo Leitner wrote: > > On Wed, Sep 18, 2019 at 12:17:08PM -0400, Willem de Bruijn wrote: > > On Wed, Sep 18, 2019 at 3:25 AM Steffen Klassert > > wrote: > > > > > > This patchset adds support to do GRO/GSO by chaining packets > > > of the same flow at

Re: [PATCH net v3] net/sched: cls_api: Fix nooffloaddevcnt counter when indr block call success

2019-09-19 Thread Or Gerlitz
On Thu, Sep 19, 2019 at 11:39 AM wrote: > > From: wenxu > > A vxlan or gretap device offload through indr block methord. If the device nit: method --> method > successfully bind with a real hw through indr block call, It also add > nooffloadcnt counter. This counter will lead the rule add faile

Re: [PATCH RFC v3 0/5] Support fraglist GRO/GSO

2019-09-19 Thread Or Gerlitz
On Wed, Sep 18, 2019 at 2:48 PM Steffen Klassert wrote: > This patchset adds support to do GRO/GSO by chaining packets > of the same flow at the SKB frag_list pointer. This avoids > the overhead to merge payloads into one big packet, and > on the other end, if GSO is needed it avoids the overhead

Re: [PATCH bpf 0/2] bpf: BTF fixes

2019-09-19 Thread Daniel Borkmann
On Tue, Sep 17, 2019 at 10:45:36AM -0700, Alexei Starovoitov wrote: > Two trivial BTF fixes. > > Alexei Starovoitov (2): > bpf: fix BTF verification of enums > bpf: fix BTF limits > > include/uapi/linux/btf.h | 4 ++-- > kernel/bpf/btf.c | 5 ++--- > 2 files changed, 4 insertions(+),

Re: [PATCH bpf] xsk: relax UMEM headroom alignment

2019-09-19 Thread Daniel Borkmann
On Wed, Sep 18, 2019 at 09:57:39AM +0200, Björn Töpel wrote: > From: Björn Töpel > > This patch removes the 64B alignment of the UMEM headroom. There is > really no reason for it, and having a headroom less than 64B should be > valid. > > Fixes: c0c77d8fb787 ("xsk: add user memory registration s

Re: [PATCH net-next] tcp: force a PSH flag on TSO packets

2019-09-19 Thread David Miller
From: Or Gerlitz Date: Thu, 19 Sep 2019 15:17:54 +0300 > On Wed, Sep 11, 2019 at 12:54 AM Eric Dumazet wrote: >> When tcp sends a TSO packet, adding a PSH flag on it >> reduces the sojourn time of GRO packet in GRO receivers. >> >> This is particularly the case under pressure, since RX queues >>

Re: [PATCH bpf v2] libbpf: Remove getsockopt() check for XDP_OPTIONS

2019-09-19 Thread Daniel Borkmann
On Mon, Sep 16, 2019 at 02:33:42PM +0200, Toke Høiland-Jørgensen wrote: > The xsk_socket__create() function fails and returns an error if it cannot > get the XDP_OPTIONS through getsockopt(). However, support for XDP_OPTIONS > was not added until kernel 5.3, so this means that creating XSK sockets

Re: [PATCH net-next] tcp: force a PSH flag on TSO packets

2019-09-19 Thread Or Gerlitz
On Wed, Sep 11, 2019 at 12:54 AM Eric Dumazet wrote: > When tcp sends a TSO packet, adding a PSH flag on it > reduces the sojourn time of GRO packet in GRO receivers. > > This is particularly the case under pressure, since RX queues > receive packets for many concurrent flows. > > A sender can giv

Re: [PATCH RFC v3 0/5] Support fraglist GRO/GSO

2019-09-19 Thread Steffen Klassert
On Thu, Sep 19, 2019 at 01:18:16PM +0200, David Miller wrote: > From: Steffen Klassert > Date: Thu, 19 Sep 2019 13:01:25 +0200 > > > If the packet data of all the fraglist GRO skbs are backed by a > > page fragment then we could just do the same by iterating with > > skb_walk_frags(). I'm not a d

Re: [PATCH] usbnet: sanity checking of packet sizes and device mtu

2019-09-19 Thread David Miller
From: Oliver Neukum Date: Thu, 19 Sep 2019 10:23:08 +0200 > After a reset packet sizes and device mtu can change and need > to be reevaluated to calculate queue sizes. > Malicious devices can set this to zero and we divide by it. > Introduce sanity checking. > > Reported-and-tested-by: syzbot+6

CONFIG_NET_TC_SKB_EXT

2019-09-19 Thread David Miller
As Linus pointed out, the Kconfig logic for CONFIG_NET_TC_SKB_EXT is really not acceptable. It should not be enabled by default at all. Instead the actual users should turn it on or depend upon it, which in this case seems to be OVS. Please fix this, thank you.

Re: [PATCH RFC v3 0/5] Support fraglist GRO/GSO

2019-09-19 Thread David Miller
From: Steffen Klassert Date: Thu, 19 Sep 2019 13:01:25 +0200 > If the packet data of all the fraglist GRO skbs are backed by a > page fragment then we could just do the same by iterating with > skb_walk_frags(). I'm not a driver expert and might be misstaken, > but it looks like that could be don

Re: [PATCH RFC v3 0/5] Support fraglist GRO/GSO

2019-09-19 Thread Steffen Klassert
On Wed, Sep 18, 2019 at 01:58:17PM -0300, Marcelo Ricardo Leitner wrote: > On Wed, Sep 18, 2019 at 12:17:08PM -0400, Willem de Bruijn wrote: > > > > More specifically, whether we can remove that in favor of using your > > new skb_segment_list. That would actually be a big first step in > > simplif

[PATCH] net-icmp: remove ping_group_range sysctl

2019-09-19 Thread Maciej Żenczykowski
From: Maciej Żenczykowski It is high time to make icmp sockets available to all, and thus allow utilities like ping, ping6, traceroute and others to not require suid root nor file system (or otherwise gained) CAP_NET_RAW privs. While in the past there have been a number of exploits, extensive sy

Re: Fwd: [PATCH] bonding/802.3ad: fix slave initialization states race

2019-09-19 Thread Алексей Захаров
чт, 19 сент. 2019 г. в 11:00, Jay Vosburgh : > > Алексей Захаров wrote: > > >> >Once a while, one of 802.3ad slaves fails to initialize and hangs in > >> >BOND_LINK_FAIL state. Commit 334031219a84 ("bonding/802.3ad: fix slave > >> >link initialization transition states") checks slave->last_link_up.

Re: [PATCH RFC v3 0/5] Support fraglist GRO/GSO

2019-09-19 Thread Steffen Klassert
On Wed, Sep 18, 2019 at 12:17:08PM -0400, Willem de Bruijn wrote: > On Wed, Sep 18, 2019 at 3:25 AM Steffen Klassert > wrote: > > > > This patchset adds support to do GRO/GSO by chaining packets > > of the same flow at the SKB frag_list pointer. This avoids > > the overhead to merge payloads into

Re: [PATCH RFC v3 5/5] udp: Support UDP fraglist GRO/GSO.

2019-09-19 Thread Steffen Klassert
On Wed, Sep 18, 2019 at 12:13:26PM -0400, Willem de Bruijn wrote: > On Wed, Sep 18, 2019 at 3:25 AM Steffen Klassert > wrote: > > > > This patch extends UDP GRO to support fraglist GRO/GSO > > by using the previously introduced infrastructure. > > All UDP packets that are not targeted to a GRO cap

Re: [PATCH RFC v3 2/5] net: Add NETIF_F_GRO_LIST feature

2019-09-19 Thread Steffen Klassert
On Wed, Sep 18, 2019 at 08:04:18PM -0600, Subash Abhinov Kasiviswanathan wrote: > On 2019-09-18 10:10, Willem de Bruijn wrote: > > On Wed, Sep 18, 2019 at 3:25 AM Steffen Klassert > > wrote: > > > > > > This adds a new NETIF_F_GRO_LIST feature flag. I will be used > > > to configure listfyed GRO

Re: [PATCH RFC v3 2/5] net: Add NETIF_F_GRO_LIST feature

2019-09-19 Thread Steffen Klassert
On Wed, Sep 18, 2019 at 12:10:31PM -0400, Willem de Bruijn wrote: > On Wed, Sep 18, 2019 at 3:25 AM Steffen Klassert > wrote: > > > > This adds a new NETIF_F_GRO_LIST feature flag. I will be used > > to configure listfyed GRO what will be implemented with some > > followup paches. > > This should

Re: [bpf-next,v3] samples: bpf: add max_pckt_size option at xdp_adjust_tail

2019-09-19 Thread Daniel T. Lee
On Thu, Sep 19, 2019 at 3:00 AM Andrii Nakryiko wrote: > > On Wed, Sep 18, 2019 at 10:37 AM Daniel T. Lee wrote: > > > > On Tue, Sep 17, 2019 at 1:04 PM Andrii Nakryiko > > wrote: > > > > > > On Wed, Sep 11, 2019 at 2:33 PM Daniel T. Lee > > > wrote: > > > > > > > > Currently, at xdp_adjust_ta

Re: [PATCH] net: mdio-octeon: Fix build error and Kconfig warning

2019-09-19 Thread Geert Uytterhoeven
On Thu, Aug 1, 2019 at 1:52 AM Randy Dunlap wrote: > However, there are lots of type/cast warnings in both mdio-octeon and > mdio-cavium: > > ../drivers/net/phy/mdio-octeon.c: In function ‘octeon_mdiobus_probe’: > ../drivers/net/phy/mdio-octeon.c:48:3: warning: cast from pointer to integer > of

Re: [PATCH net 2/3] net: sched: multiq: don't call qdisc_put() while holding tree lock

2019-09-19 Thread Vlad Buslov
On Thu 19 Sep 2019 at 01:56, Cong Wang wrote: > On Wed, Sep 18, 2019 at 12:32 AM Vlad Buslov wrote: >> diff --git a/net/sched/sch_multiq.c b/net/sched/sch_multiq.c >> index e1087746f6a2..4cfa9a7bd29e 100644 >> --- a/net/sched/sch_multiq.c >> +++ b/net/sched/sch_multiq.c >> @@ -187,18 +187,21 @@

  1   2   >