> -----Original Message-----
> From: David Miller <da...@davemloft.net>
> Sent: Monday, September 16, 2019 10:45 PM
> To: Jubran, Samih <same...@amazon.com>
> Cc: netdev@vger.kernel.org; Woodhouse, David <d...@amazon.co.uk>;
> Machulsky, Zorik <zo...@amazon.com>; Matushevsky, Alexander
> <ma...@amazon.com>; Bshara, Saeed <sae...@amazon.com>; Wilson,
> Matt <m...@amazon.com>; Liguori, Anthony <aligu...@amazon.com>;
> Bshara, Nafea <na...@amazon.com>; Tzalik, Guy <gtza...@amazon.com>;
> Belgazal, Netanel <neta...@amazon.com>; Saidi, Ali
> <alisa...@amazon.com>; Herrenschmidt, Benjamin <b...@amazon.com>;
> Kiyanovski, Arthur <akiy...@amazon.com>
> Subject: Re: [PATCH V1 net-next 2/5] net: ena: multiple queue creation
> related cleanups
>
> From: <same...@amazon.com>
> Date: Sun, 15 Sep 2019 18:27:19 +0300
>
> > @@ -1885,6 +1885,13 @@ static int ena_up(struct ena_adapter *adapter)
> > if (rc)
> > goto err_req_irq;
> >
> > + netif_info(adapter, ifup, adapter->netdev, "creating %d io queues.
> rx queue size: %d tx queue size. %d LLQ is %s\n",
> > + adapter->num_io_queues,
> > + adapter->requested_rx_ring_size,
> > + adapter->requested_tx_ring_size,
> > + (adapter->ena_dev->tx_mem_queue_type ==
> ENA_ADMIN_PLACEMENT_POLICY_DEV) ?
> > + "ENABLED" : "DISABLED");
>
> Please don't clog up the kernel log with stuff like this.
>
> Maybe netif_debug() at best, but I'd rather you remove this entirely. It's so
> easy to make a device go up and down repeatedly multiple times in one
> second.
Dropped in v2.
