Fw: [Bug 204879] New: "invalid inflight", WARNING: CPU: 1 PID: 5103 at net/ipv4/tcp_output.c:2509 tcp_send_loss_probe.cold.42+0x20/0x2d

2019-09-16 Thread Stephen Hemminger
Begin forwarded message: Date: Mon, 16 Sep 2019 20:28:15 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 204879] New: "invalid inflight", WARNING: CPU: 1 PID: 5103 at net/ipv4/tcp_output.c:2509 tcp_send_loss_probe.cold.42+0x20/0x2d https://bugzill

Re: [PATCH] netfilter: bridge: drop a broken include

2019-09-16 Thread Pablo Neira Ayuso
Hi Jeremy, On Mon, Sep 16, 2019 at 02:08:12PM +0100, Jeremy Sowden wrote: > On 2019-09-16, at 02:05:16 +0200, Adam Borowski wrote: > > This caused a build failure if CONFIG_NF_CONNTRACK_BRIDGE is set but > > CONFIG_NF_TABLES=n -- and appears to be unused anyway. [...] > There are already changes i

Re: [PATCH bpf v2] libbpf: Remove getsockopt() check for XDP_OPTIONS

2019-09-16 Thread Andrii Nakryiko
On Mon, Sep 16, 2019 at 6:05 AM Toke Høiland-Jørgensen wrote: > > The xsk_socket__create() function fails and returns an error if it cannot > get the XDP_OPTIONS through getsockopt(). However, support for XDP_OPTIONS > was not added until kernel 5.3, so this means that creating XSK sockets > alway

Re: [bpf-next,v3] samples: bpf: add max_pckt_size option at xdp_adjust_tail

2019-09-16 Thread Andrii Nakryiko
On Wed, Sep 11, 2019 at 2:33 PM Daniel T. Lee wrote: > > Currently, at xdp_adjust_tail_kern.c, MAX_PCKT_SIZE is limited > to 600. To make this size flexible, a new map 'pcktsz' is added. > > By updating new packet size to this map from the userland, > xdp_adjust_tail_kern.o will use this value as

Re: [PATCH bpf] bpf: respect CAP_IPC_LOCK in RLIMIT_MEMLOCK check

2019-09-16 Thread Alexei Starovoitov
On Mon, Sep 16, 2019 at 07:09:06AM -0700, Christian Barcenas wrote: > > bpf() is currently the only exception to the above, ie. as far as I can tell > it is the only code that enforces RLIMIT_MEMLOCK but does not honor > CAP_IPC_LOCK. Yes. bpf is not honoring CAP_IPC_LOCK comparing to other place

Bug report (with fix) for DEC Tulip driver (de2104x.c)

2019-09-16 Thread Arlie Davis
Hello. I'm a developer on GCE, Google's virtual machine platform. As part of my work, we needed to emulate a DEC Tulip 2104x NIC, so I implemented a basic virtual device for it. While doing so, I believe I found a bug in the Linux driver for this device, in de2104x.c. I see in MAINTAINERS that thi

Re: [PATCH net-next v3 0/3] mlxsw: spectrum_buffers: Add the ability to query the CPU port's shared buffer

2019-09-16 Thread David Miller
From: Ido Schimmel Date: Mon, 16 Sep 2019 18:04:19 +0300 > From: Ido Schimmel > > Shalom says: > > While debugging packet loss towards the CPU, it is useful to be able to > query the CPU port's shared buffer quotas and occupancy. > > Patch #1 prevents changing the CPU port's threshold and bin

Re: [PATCH V2 net-next 00/11] net: ena: implement adaptive interrupt moderation using dim

2019-09-16 Thread David Miller
From: Date: Mon, 16 Sep 2019 14:31:25 +0300 > From: Arthur Kiyanovski > > In this patchset we replace our adaptive interrupt moderation > implementation with the dim library implementation. > The dim library showed great improvement in throughput, latency > and CPU usage in different scenarios

Re: [PATCH v4 net-next 0/6] tc-taprio offload for SJA1105 DSA

2019-09-16 Thread Vladimir Oltean
On Mon, 16 Sep 2019 at 22:36, David Miller wrote: > > From: Vladimir Oltean > Date: Sun, 15 Sep 2019 04:59:57 +0300 > > > This is the third attempt to submit the tc-taprio offload model for > > inclusion in the networking tree. The sja1105 switch driver will provide > > the first implementation o

Re: [PATCH net-next] s390/ctcm: Delete unnecessary checks before the macro call “dev_kfree_skb”

2019-09-16 Thread David Miller
From: Julian Wiedmann Date: Sun, 15 Sep 2019 19:21:05 +0200 > From: Markus Elfring > > The dev_kfree_skb() function performs also input parameter validation. > Thus the test around the shown calls is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by:

Re: [PATCH V1 net-next 2/5] net: ena: multiple queue creation related cleanups

2019-09-16 Thread David Miller
From: Date: Sun, 15 Sep 2019 18:27:19 +0300 > @@ -1885,6 +1885,13 @@ static int ena_up(struct ena_adapter *adapter) > if (rc) > goto err_req_irq; > > + netif_info(adapter, ifup, adapter->netdev, "creating %d io queues. rx > queue size: %d tx queue size. %d LLQ is %s\n",

Re: [PATCH net-next 0/2] drop_monitor: Better sanitize notified packets

2019-09-16 Thread David Miller
From: Ido Schimmel Date: Sun, 15 Sep 2019 09:46:34 +0300 > From: Ido Schimmel > > When working in 'packet' mode, drop monitor generates a notification > with a potentially truncated payload of the dropped packet. The payload > is copied from the MAC header, but I forgot to check that the MAC he

Re: [PATCH V1 net] net: ena: don't wake up tx queue when down

2019-09-16 Thread David Miller
From: Date: Sun, 15 Sep 2019 17:29:44 +0300 > From: Sameeh Jubran > > There is a race condition that can occur when calling ena_down(). > The ena_clean_tx_irq() - which is a part of the napi handler - > function might wake up the tx queue when the queue is supposed > to be down (during recovery

Re: [PATCH v4 net-next 0/6] tc-taprio offload for SJA1105 DSA

2019-09-16 Thread David Miller
From: Vladimir Oltean Date: Sun, 15 Sep 2019 04:59:57 +0300 > This is the third attempt to submit the tc-taprio offload model for > inclusion in the networking tree. The sja1105 switch driver will provide > the first implementation of the offload. Only the bare minimum is added: > > - The offloa

Re: net: phy: micrel KSZ9031 ifdown ifup issue

2019-09-16 Thread Paul Thomas
On Mon, Sep 16, 2019 at 11:13 AM Andrew Lunn wrote: > > > When it is in the good state I see that reg 0x01 is 0x796d where bit > > 1.2 reports 'Link is up' and bit 1.5 reports 'Auto-negotiation process > > complete'. However, once I get to the bad state (it may take several > > tries of ifdown, if

Re: [PATCH v5 1/2] tcp: Add TCP_INFO counter for packets received out-of-order

2019-09-16 Thread Thomas Higdon
On Sat, Sep 14, 2019 at 11:43:25AM -0400, Neal Cardwell wrote: > On Fri, Sep 13, 2019 at 7:23 PM Thomas Higdon wrote: > > > > For receive-heavy cases on the server-side, we want to track the > > connection quality for individual client IPs. This counter, similar to > > the existing system-wide TCP

Re: [PATCH] dt-bindings: net: Correct the documentation of KSZ9021 skew values

2019-09-16 Thread James Byrne
On 16/09/2019 15:14, David Miller wrote: From: James Byrne Date: Fri, 13 Sep 2019 16:46:35 + The documentation of skew values for the KSZ9021 PHY was misleading because the driver implementation followed the erroneous information given in the original KSZ9021 datasheet before it was correc

Re: [PATCH iproute2] link_xfrm: don't forcce to set phydev

2019-09-16 Thread Matt Ellison
Acked-by: Matt Ellison -- Please be advised that this email may contain confidential information. If you are not the intended recipient, please notify us by email by replying to the sender and delete this message. The sender disclaims that the content of this email constitutes an offer to

Re: [bpf-next,v4] samples: bpf: add max_pckt_size option at xdp_adjust_tail

2019-09-16 Thread Daniel T. Lee
On Tue, Sep 17, 2019 at 1:07 AM Yonghong Song wrote: > > > > On 9/15/19 1:47 PM, Daniel T. Lee wrote: > > Currently, at xdp_adjust_tail_kern.c, MAX_PCKT_SIZE is limited > > to 600. To make this size flexible, a new map 'pcktsz' is added. > > > > By updating new packet size to this map from the use

Re: [bpf-next,v4] samples: bpf: add max_pckt_size option at xdp_adjust_tail

2019-09-16 Thread Yonghong Song
On 9/15/19 1:47 PM, Daniel T. Lee wrote: > Currently, at xdp_adjust_tail_kern.c, MAX_PCKT_SIZE is limited > to 600. To make this size flexible, a new map 'pcktsz' is added. > > By updating new packet size to this map from the userland, > xdp_adjust_tail_kern.o will use this value as a new max_pc

Re: SFP support with RGMII MAC via RGMII to SERDES/SGMII PHY?

2019-09-16 Thread George McCollister
On Sat, Sep 14, 2019 at 3:49 AM Russell King - ARM Linux admin wrote: > > On Fri, Sep 13, 2019 at 08:31:18PM -0700, Florian Fainelli wrote: > > +Russell, Andrew, Heiner, > > > > On 9/13/2019 9:44 AM, George McCollister wrote: > > > Every example of phylink SFP support I've seen is using an Etherne

[PATCH iproute2] link_xfrm: don't forcce to set phydev

2019-09-16 Thread Nicolas Dichtel
Since linux commit 22d6552f827e ("xfrm interface: fix management of phydev"), phydev is not mandatory anymore. Note that it also could be useful before the above commit to not force the user to put a phydev (the kernel was checking it anyway). For example, it was useful to not set it in case of x-

Re: [PATCH net] ibmvnic: Warn unknown speed message only when carrier is present

2019-09-16 Thread Thomas Falcon
On 9/16/19 9:50 AM, Murilo Fossa Vicentini wrote: With commit 0655f9943df2 ("net/ibmvnic: Update carrier state after link state change") we are now able to detect when the carrier is properly present in the device, so only report an unexpected unknown speed when it is properly detected. Unknown s

Re: net: phy: micrel KSZ9031 ifdown ifup issue

2019-09-16 Thread Andrew Lunn
> When it is in the good state I see that reg 0x01 is 0x796d where bit > 1.2 reports 'Link is up' and bit 1.5 reports 'Auto-negotiation process > complete'. However, once I get to the bad state (it may take several > tries of ifdown, ifup to get there) then reg 0x01 is 0x7649 reporting > 'Link is d

[PATCH net-next v3 2/3] mlxsw: spectrum: Register CPU port with devlink

2019-09-16 Thread Ido Schimmel
From: Shalom Toledo Register CPU port with devlink. Signed-off-by: Shalom Toledo Acked-by: Jiri Pirko Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/core.c| 63 --- drivers/net/ethernet/mellanox/mlxsw/core.h| 5 ++ .../net/ethernet/mellanox/mlxsw

[PATCH net-next v3 1/3] mlxsw: spectrum_buffers: Prevent changing CPU port's configuration

2019-09-16 Thread Ido Schimmel
From: Shalom Toledo Next patch is going to register the CPU port with devlink, but only so that the CPU port's shared buffer configuration and occupancy could be queried. Prevent changing CPU port's shared buffer threshold and binding configuration. Signed-off-by: Shalom Toledo Acked-by: Jiri

[PATCH net-next v3 3/3] mlxsw: spectrum_buffers: Add the ability to query the CPU port's shared buffer

2019-09-16 Thread Ido Schimmel
From: Shalom Toledo While debugging packet loss towards the CPU, it is useful to be able to query the CPU port's shared buffer quotas and occupancy. Since the CPU port has no ingress buffers, all the shared buffers ingress information will be cleared. Signed-off-by: Shalom Toledo Acked-by: Jir

[PATCH net-next v3 0/3] mlxsw: spectrum_buffers: Add the ability to query the CPU port's shared buffer

2019-09-16 Thread Ido Schimmel
From: Ido Schimmel Shalom says: While debugging packet loss towards the CPU, it is useful to be able to query the CPU port's shared buffer quotas and occupancy. Patch #1 prevents changing the CPU port's threshold and binding. Patch #2 registers the CPU port with devlink. Patch #3 adds the abi

Re: [PATCH net v3 03/11] bonding: fix unexpected IFF_BONDING bit unset

2019-09-16 Thread Jay Vosburgh
Jiri Pirko wrote: >Mon, Sep 16, 2019 at 03:47:54PM CEST, ap420...@gmail.com wrote: >>The IFF_BONDING means bonding master or bonding slave device. >>->ndo_add_slave() sets IFF_BONDING flag and ->ndo_del_slave() unsets >>IFF_BONDING flag. >> >>bond0<--bond1 >> >>Both bond0 and bond1 are bonding de

Re: [bisected] UDP / xfrm: NAT-T packets with bad UDP checksum get dropped

2019-09-16 Thread Thomas Jarosch
> After a few hours of bisecting with a test VM, > this commit was identified to cause the packet drop: > > *** > commit 0a80966b1043c3e2dc684140f155a3fded308660 > Author: Tom Herbert > Date: Wed May 7 16:52:39 2014 -0700 > > net: Verify UDP checksum before handoff to encap

Re: [patch net-next 02/15] net: fib_notifier: make FIB notifier per-netns

2019-09-16 Thread David Ahern
On 9/15/19 11:38 PM, Jiri Pirko wrote: >> This is still more complicated than it needs to be. Why lump all >> fib_notifier_ops into 1 dump when they are separate databases with >> separate seq numbers? Just dump them 1 at a time and retry that 1 >> database as needed. > > Well I think that what yo

[PATCH net] ibmvnic: Warn unknown speed message only when carrier is present

2019-09-16 Thread Murilo Fossa Vicentini
With commit 0655f9943df2 ("net/ibmvnic: Update carrier state after link state change") we are now able to detect when the carrier is properly present in the device, so only report an unexpected unknown speed when it is properly detected. Unknown speed is expected to be seen by the device in case th

Re: [PATCH net v3 03/11] bonding: fix unexpected IFF_BONDING bit unset

2019-09-16 Thread Jiri Pirko
Mon, Sep 16, 2019 at 03:47:54PM CEST, ap420...@gmail.com wrote: >The IFF_BONDING means bonding master or bonding slave device. >->ndo_add_slave() sets IFF_BONDING flag and ->ndo_del_slave() unsets >IFF_BONDING flag. > >bond0<--bond1 > >Both bond0 and bond1 are bonding device and these should keep h

Re: [patch iproute2-next v4 0/2] devlink: couple forgotten flash patches

2019-09-16 Thread David Ahern
On 9/16/19 4:09 AM, Jiri Pirko wrote: > The fact that the file is expected to be in /lib/firmware is in the > devlink flash description right above: > > >devlink dev flash - write device's non-volatile memory. >DEV - specifies the devlink device to write to. > >file PATH - Pa

Re: [PATCH v5 1/2] tcp: Add TCP_INFO counter for packets received out-of-order

2019-09-16 Thread David Miller
From: Thomas Higdon Date: Fri, 13 Sep 2019 23:23:34 + > For receive-heavy cases on the server-side, we want to track the > connection quality for individual client IPs. This counter, similar to > the existing system-wide TCPOFOQueue counter in /proc/net/netstat, > tracks out-of-order packet r

Re: [PATCH v5 2/2] tcp: Add snd_wnd to TCP_INFO

2019-09-16 Thread David Miller
From: Thomas Higdon Date: Fri, 13 Sep 2019 23:23:35 + > Neal Cardwell mentioned that snd_wnd would be useful for diagnosing TCP > performance problems -- >> (1) Usually when we're diagnosing TCP performance problems, we do so >> from the sender, since the sender makes most of the >> performan

Re: [PATCH net v3 03/11] bonding: fix unexpected IFF_BONDING bit unset

2019-09-16 Thread Jay Vosburgh
Taehee Yoo wrote: >The IFF_BONDING means bonding master or bonding slave device. >->ndo_add_slave() sets IFF_BONDING flag and ->ndo_del_slave() unsets >IFF_BONDING flag. > >bond0<--bond1 > >Both bond0 and bond1 are bonding device and these should keep having >IFF_BONDING flag until they are remov

Re: [PATCH] dt-bindings: net: Correct the documentation of KSZ9021 skew values

2019-09-16 Thread David Miller
From: James Byrne Date: Fri, 13 Sep 2019 16:46:35 + > The documentation of skew values for the KSZ9021 PHY was misleading > because the driver implementation followed the erroneous information > given in the original KSZ9021 datasheet before it was corrected in > revision 1.2 (Feb 2014). It i

Re: [PATCH bpf] bpf: respect CAP_IPC_LOCK in RLIMIT_MEMLOCK check

2019-09-16 Thread Christian Barcenas
On 9/11/19 8:18 PM, Christian Barcenas wrote: A process can lock memory addresses into physical RAM explicitly (via mlock, mlockall, shmctl, etc.) or implicitly (via VFIO, perf ring-buffers, bpf maps, etc.), subject to RLIMIT_MEMLOCK limits. CAP_IPC_LOCK allows a process to exceed these limits,

Re: pull-request: bpf-next 2019-09-16

2019-09-16 Thread David Miller
From: Daniel Borkmann Date: Mon, 16 Sep 2019 12:26:30 +0200 > The following pull-request contains BPF updates for your *net-next* tree. Pulled and build testing (in Denmark!), thanks.

Re: [PATCH net-next v2 0/3] mlxsw: spectrum_buffers: Add the ability to query the CPU port's shared buffer

2019-09-16 Thread David Miller
From: Shalom Toledo Date: Mon, 16 Sep 2019 08:14:47 + > I have v3 with all the fixes Jiri commented. Can I send it? Or should I wait > until net-next will be open again? Just send it, thanks for asking.

Re: net: phy: micrel KSZ9031 ifdown ifup issue

2019-09-16 Thread Paul Thomas
Hi Andrew, I did some more investigation, and what seems to be happening is the device get's stuck in auto-negotiation. I looked at this using phytool: https://github.com/wkz/phytool When it is in the good state I see that reg 0x01 is 0x796d where bit 1.2 reports 'Link is up' and bit 1.5 reports

[PATCH net v2] net/sched: cls_api: Fix nooffloaddevcnt counter when indr block call success

2019-09-16 Thread wenxu
From: wenxu A vxlan or gretap device offload through indr block methord. If the device successfully bind with a real hw through indr block call, It also add nooffloadcnt counter. This counter will lead the rule add failed in fl_hw_replace_filter-->tc_setup_cb_call with skip_sw flags. In the tc_s

[PATCH net v3 11/11] net: remove unnecessary variables and callback

2019-09-16 Thread Taehee Yoo
This patch removes variables and callback these are related to the nested device structure. devices that can be nested have their own nest_level variable that represents the depth of nested devices. In the previous patch, new {lower/upper}_level variables are added and they replace old private nest

[PATCH net v3 10/11] vxlan: add adjacent link to limit depth level

2019-09-16 Thread Taehee Yoo
Current vxlan code doesn't limit the number of nested devices. Nested devices would be handled recursively and this routine needs huge stack memory. So, unlimited nested devices could make stack overflow. In order to fix this issue, this patch adds adjacent links. The adjacent link APIs internally

[PATCH net v3 07/11] macvlan: use dynamic lockdep key instead of subclass

2019-09-16 Thread Taehee Yoo
All macvlan device has same lockdep key and subclass is initialized with nest_level. But actual nest_level value can be changed when a lower device is attached. And at this moment, the subclass should be updated but it seems to be unsafe. So this patch makes macvlan use dynamic lockdep key instead

[PATCH net v3 09/11] net: core: add ignore flag to netdev_adjacent structure

2019-09-16 Thread Taehee Yoo
In order to link an adjacent node, netdev_upper_dev_link() is used and in order to unlink an adjacent node, netdev_upper_dev_unlink() is used. unlink operation does not fail, but link operation can fail. In order to exchange adjacent nodes, we should unlink an old adjacent node first. then, link a

[PATCH net v3 08/11] macsec: fix refcnt leak in module exit routine

2019-09-16 Thread Taehee Yoo
When a macsec interface is created, it increases a refcnt to a lower device(real device). when macsec interface is deleted, the refcnt is decreased in macsec_free_netdev(), which is ->priv_destructor() of macsec interface. The problem scenario is this. When nested macsec interfaces are exiting, th

[PATCH net v3 06/11] macsec: use dynamic lockdep key instead of subclass

2019-09-16 Thread Taehee Yoo
All macsec device has same lockdep key and subclass is initialized with nest_level. But actual nest_level value can be changed when a lower device is attached. And at this moment, the subclass should be updated but it seems to be unsafe. So this patch makes macsec use dynamic lockdep key instead of

[PATCH net v3 05/11] team: use dynamic lockdep key instead of static key

2019-09-16 Thread Taehee Yoo
In the current code, all team devices have same static lockdep key and team devices could be nested so that it makes unnecessary lockdep warning. Test commands: ip link add team0 type team for i in {1..7} do let A=$i-1 ip link add team$i type team ip

[PATCH net v3 04/11] bonding: use dynamic lockdep key instead of subclass

2019-09-16 Thread Taehee Yoo
All bonding device has same lockdep key and subclass is initialized with nest_level. But actual nest_level value can be changed when a lower device is attached. And at this moment, the subclass should be updated but it seems to be unsafe. So this patch makes bonding use dynamic lockdep key instead

[PATCH net v3 03/11] bonding: fix unexpected IFF_BONDING bit unset

2019-09-16 Thread Taehee Yoo
The IFF_BONDING means bonding master or bonding slave device. ->ndo_add_slave() sets IFF_BONDING flag and ->ndo_del_slave() unsets IFF_BONDING flag. bond0<--bond1 Both bond0 and bond1 are bonding device and these should keep having IFF_BONDING flag until they are removed. But bond1 would lose IFF

[PATCH net v3 02/11] vlan: use dynamic lockdep key instead of subclass

2019-09-16 Thread Taehee Yoo
All VLAN device has same lockdep key and subclass is initialized with nest_level. But actual nest_level value can be changed when a lower device is attached. And at this moment, the subclass should be updated but it seems to be unsafe. So this patch makes VLAN use dynamic lockdep key instead of the

[PATCH net v3 01/11] net: core: limit nested device depth

2019-09-16 Thread Taehee Yoo
Current code doesn't limit the number of nested devices. Nested devices would be handled recursively and this needs huge stack memory. So, unlimited nested devices could make stack overflow. This patch adds upper_level and lower_level, they are common variables and represent maximum lower/upper de

[PATCH net v3 00/11] net: fix nested device bugs

2019-09-16 Thread Taehee Yoo
This patchset fixes several bugs that are related to nesting device infrastructure. Current nesting infrastructure code doesn't limit the depth level of devices. nested devices could be handled recursively. at that moment, it needs huge memory and stack overflow could occur. Below devices type have

Re: [PATCH net] net/sched: cls_api: Fix nooffloaddevcnt counter in indr block call success

2019-09-16 Thread wenxu
在 2019/9/16 18:28, Jiri Pirko 写道: > Please use get_maintainers script to get list of ccs. > > Mon, Sep 16, 2019 at 12:15:34PM CEST, we...@ucloud.cn wrote: >> From: wenxu >> >> When a block bind with a dev which support indr block call(vxlan/gretap >> device). It can bind success but with noofflo

Re: [PATCH] libbpf: Don't error out if getsockopt() fails for XDP_OPTIONS

2019-09-16 Thread Toke Høiland-Jørgensen
Daniel Borkmann writes: > On 9/13/19 8:53 PM, Yonghong Song wrote: >> On 9/10/19 12:06 AM, Toke Høiland-Jørgensen wrote: >>> Yonghong Song writes: On 9/9/19 10:46 AM, Toke Høiland-Jørgensen wrote: > The xsk_socket__create() function fails and returns an error if it cannot > get the

Re: [PATCH] netfilter: bridge: drop a broken include

2019-09-16 Thread Jeremy Sowden
On 2019-09-16, at 02:05:16 +0200, Adam Borowski wrote: > This caused a build failure if CONFIG_NF_CONNTRACK_BRIDGE is set but > CONFIG_NF_TABLES=n -- and appears to be unused anyway. > > Signed-off-by: Adam Borowski > --- > net/bridge/netfilter/nf_conntrack_bridge.c | 1 - > 1 file changed, 1 del

[PATCH bpf v2] libbpf: Remove getsockopt() check for XDP_OPTIONS

2019-09-16 Thread Toke Høiland-Jørgensen
The xsk_socket__create() function fails and returns an error if it cannot get the XDP_OPTIONS through getsockopt(). However, support for XDP_OPTIONS was not added until kernel 5.3, so this means that creating XSK sockets always fails on older kernels. Since the option is just used to set the zero-

Re: [v3 2/3] samples: pktgen: add helper functions for IP(v4/v6) CIDR parsing

2019-09-16 Thread Toke Høiland-Jørgensen
Jesper Dangaard Brouer writes: > On Sun, 15 Sep 2019 00:13:52 +0900 > "Daniel T. Lee" wrote: > >> This commit adds CIDR parsing and IP validate helper function to parse >> single IP or range of IP with CIDR. (e.g. 198.18.0.0/15) >> >> Helpers will be used in prior to set target address in sampl

[PATCH iproute2-next v2] bpf: replace snprintf with asprintf when dealing with long buffers

2019-09-16 Thread Andrea Claudi
This reduces stack usage, as asprintf allocates memory on the heap. This indirectly fixes a snprintf truncation warning (from gcc v9.2.1): bpf.c: In function ‘bpf_get_work_dir’: bpf.c:784:49: warning: ‘snprintf’ output may be truncated before the last format character [-Wformat-truncation=] 78

[PATCH] selftests: Add test cases for `ip nexthop flush proto XX`

2019-09-16 Thread Donald Sharp
Add some test cases to allow the fib_nexthops.sh test code to test the flushing of nexthops based upon the proto passed in upon creation of the nexthop group. Signed-off-by: Donald Sharp --- tools/testing/selftests/net/fib_nexthops.sh | 14 ++ 1 file changed, 14 insertions(+) diff -

RE: [PATCH V1 net-next 01/11] net: ena: add intr_moder_rx_interval to struct ena_com_dev and use it

2019-09-16 Thread Kiyanovski, Arthur
> -Original Message- > From: David Miller > Sent: Sunday, September 15, 2019 9:33 PM > To: Kiyanovski, Arthur > Cc: netdev@vger.kernel.org; Woodhouse, David ; > Machulsky, Zorik ; Matushevsky, Alexander > ; Bshara, Saeed ; Wilson, Matt > ; Liguori, Anthony ; Bshara, > Nafea ; Tzalik, Guy

[PATCH V2 net-next 10/11] net: ena: fix retrieval of nonadaptive interrupt moderation intervals

2019-09-16 Thread akiyano
From: Arthur Kiyanovski Nonadaptive interrupt moderation intervals are assigned the value set by the user in ethtool -C divided by ena_dev->intr_delay_resolution. Therefore when the user tries to get the nonadaptive interrupt moderation intervals with ethtool -c the code needs to multiply the sa

[PATCH V2 net-next 00/11] net: ena: implement adaptive interrupt moderation using dim

2019-09-16 Thread akiyano
From: Arthur Kiyanovski In this patchset we replace our adaptive interrupt moderation implementation with the dim library implementation. The dim library showed great improvement in throughput, latency and CPU usage in different scenarios on ARM CPUs. This patchset also includes a few bug fixes t

[PATCH V2 net-next 11/11] net: ena: fix incorrect update of intr_delay_resolution

2019-09-16 Thread akiyano
From: Arthur Kiyanovski ena_dev->intr_moder_rx/tx_interval save the intervals received from the user after dividing them by ena_dev->intr_delay_resolution. Therefore when intr_delay_resolution changes, the code needs to first mutiply intr_moder_rx/tx_interval by the previous intr_delay_resolution

[PATCH V2 net-next 08/11] net: ena: remove all old adaptive rx interrupt moderation code from ena_com

2019-09-16 Thread akiyano
From: Arthur Kiyanovski Remove previous implementation of adaptive rx interrupt moderation from ena_com files. Signed-off-by: Arthur Kiyanovski --- drivers/net/ethernet/amazon/ena/ena_com.c | 110 - drivers/net/ethernet/amazon/ena/ena_com.h | 142 -- 2 files

[PATCH V2 net-next 05/11] net: ena: remove code duplication in ena_com_update_nonadaptive_moderation_interval _*()

2019-09-16 Thread akiyano
From: Arthur Kiyanovski Remove code duplication in: ena_com_update_nonadaptive_moderation_interval_tx() ena_com_update_nonadaptive_moderation_interval_rx() functions. Signed-off-by: Arthur Kiyanovski --- drivers/net/ethernet/amazon/ena/ena_com.c | 30 --- 1 file changed, 16

[PATCH V2 net-next 09/11] net: ena: fix update of interrupt moderation register

2019-09-16 Thread akiyano
From: Arthur Kiyanovski Current implementation always updates the interrupt register with the smoothed_interval of the rx_ring. However this should be done only in case of adaptive interrupt moderation. If non-adaptive interrupt moderation is used, the non-adaptive interrupt moderation interval s

[PATCH V2 net-next 06/11] net: ena: remove old adaptive interrupt moderation code from ena_netdev

2019-09-16 Thread akiyano
From: Arthur Kiyanovski 1. Out of the fields {per_napi_bytes, per_napi_packets} in struct ena_ring, only rx_ring->per_napi_packets are used to determine if napi did work for dim. This commit removes all other uses of these fields. 2. Remove ena_ring->moder_tbl_idx, which is not used by d

[PATCH V2 net-next 03/11] net: ena: reimplement set/get_coalesce()

2019-09-16 Thread akiyano
From: Arthur Kiyanovski 1. Remove old adaptive interrupt moderation code from set/get_coalesce() 2. Add ena_update_rx_rings_intr_moderation() function for updating nonadaptive interrupt moderation intervals similarly to ena_update_tx_rings_intr_moderation(). 3. Remove checks of multiple uns

[PATCH V2 net-next 07/11] net: ena: remove ena_restore_ethtool_params() and relevant fields

2019-09-16 Thread akiyano
From: Arthur Kiyanovski Deleted unused 4 fields from struct ena_adapter and their only user ena_restore_ethtool_params(). Signed-off-by: Arthur Kiyanovski --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 10 -- drivers/net/ethernet/amazon/ena/ena_netdev.h | 3 --- 2 files changed, 1

[PATCH V2 net-next 04/11] net: ena: enable the interrupt_moderation in driver_supported_features

2019-09-16 Thread akiyano
From: Arthur Kiyanovski Add driver_supported_features to host_host info which is a new API used to communicate to the device which features are supported by the driver. Add the interrupt_moderation bit to host_info->driver_supported_features and enable it to signal the device that this driver su

[PATCH V2 net-next 01/11] net: ena: add intr_moder_rx_interval to struct ena_com_dev and use it

2019-09-16 Thread akiyano
From: Arthur Kiyanovski Add intr_moder_rx_interval to struct ena_com_dev and use it as the location where the interrupt moderation rx interval is saved, instead of the interrupt moderation table. This is done as a first step before removing the old interrupt moderation code. Signed-off-by: Arth

pull-request: bpf-next 2019-09-16

2019-09-16 Thread Daniel Borkmann
Hi David, The following pull-request contains BPF updates for your *net-next* tree. The main changes are: 1) Now that initial BPF backend for gcc has been merged upstream, enable BPF kselftest suite for bpf-gcc. Also fix a BE issue with access to bpf_sysctl.file_pos, from Ilya. 2) Follow-

Re: [PATCH net] net/sched: cls_api: Fix nooffloaddevcnt counter in indr block call success

2019-09-16 Thread Jiri Pirko
Please use get_maintainers script to get list of ccs. Mon, Sep 16, 2019 at 12:15:34PM CEST, we...@ucloud.cn wrote: >From: wenxu > >When a block bind with a dev which support indr block call(vxlan/gretap >device). It can bind success but with nooffloaddevcnt++. It will fail >when replace the hw fi

Re: macb: inconsistent Rx descriptor chain after OOM

2019-09-16 Thread Claudiu.Beznea
On 16.09.2019 13:14, Andreas Schwab wrote: > External E-Mail > > > On Sep 16 2019, wrote: > >> I will have a look on it. It would be good if you could give me some >> details about the steps to reproduce it. > > You need to trigger OOM. Ok, thank you! > > Andreas. >

[PATCH net] net/sched: cls_api: Fix nooffloaddevcnt counter in indr block call success

2019-09-16 Thread wenxu
From: wenxu When a block bind with a dev which support indr block call(vxlan/gretap device). It can bind success but with nooffloaddevcnt++. It will fail when replace the hw filter in tc_setup_cb_call with skip_sw mode for checkout the nooffloaddevcnt and skip_sw. if (block->nooffloaddevcnt && e

Re: macb: inconsistent Rx descriptor chain after OOM

2019-09-16 Thread Andreas Schwab
On Sep 16 2019, wrote: > I will have a look on it. It would be good if you could give me some > details about the steps to reproduce it. You need to trigger OOM. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And

Re: [patch iproute2-next v4 0/2] devlink: couple forgotten flash patches

2019-09-16 Thread Jiri Pirko
Sun, Sep 15, 2019 at 07:58:33PM CEST, dsah...@gmail.com wrote: >On 9/14/19 12:00 AM, Jiri Pirko wrote: >> Fri, Sep 13, 2019 at 07:25:07PM CEST, dsah...@gmail.com wrote: >>> On 9/12/19 12:29 PM, Jiri Pirko wrote: From: Jiri Pirko I was under impression they are already merged, but ap

Re: macb: inconsistent Rx descriptor chain after OOM

2019-09-16 Thread Claudiu.Beznea
Hi Andreas, I will have a look on it. It would be good if you could give me some details about the steps to reproduce it. Thank you, Claudiu Beznea On 16.09.2019 10:41, Andreas Schwab wrote: > When there is an OOM situation, the macb driver cannot recover from it: > > [245622.872993] macb 10090

bpf-next is CLOSED

2019-09-16 Thread Daniel Borkmann
Only bug fixes from this point forward given the merge window is open. Thanks everyone, Daniel

Re: [PATCH v4 net-next 2/6] net: dsa: Pass ndo_setup_tc slave callback to drivers

2019-09-16 Thread Ilias Apalodimas
On Sun, Sep 15, 2019 at 04:59:59AM +0300, Vladimir Oltean wrote: > DSA currently handles shared block filters (for the classifier-action > qdisc) in the core due to what I believe are simply pragmatic reasons - > hiding the complexity from drivers and offerring a simple API for port > mirroring. >

Re: [PATCH v2 net-next 2/7] net: dsa: Pass ndo_setup_tc slave callback to drivers

2019-09-16 Thread Vladimir Oltean
Hi Ilias, On Mon, 16 Sep 2019 at 12:31, Ilias Apalodimas wrote: > > Hi Vladimir, > > Yes fixes my request on the initial RFC. Sorry for the delayed response. > > On Sat, Sep 14, 2019 at 04:17:57AM +0300, Vladimir Oltean wrote: > > DSA currently handles shared block filters (for the classifier-act

[patch iproute2-next v2] devlink: add reload failed indication

2019-09-16 Thread Jiri Pirko
From: Jiri Pirko Add indication about previous failed devlink reload. Example outputs: $ devlink dev netdevsim/netdevsim10: reload_failed true $ devlink dev -j -p { "dev": { "netdevsim/netdevsim10": { "reload_failed": true } } } Signed-off-by: Jiri Pirko --

Re: [PATCH v2 net-next 2/7] net: dsa: Pass ndo_setup_tc slave callback to drivers

2019-09-16 Thread Ilias Apalodimas
Hi Vladimir, Yes fixes my request on the initial RFC. Sorry for the delayed response. On Sat, Sep 14, 2019 at 04:17:57AM +0300, Vladimir Oltean wrote: > DSA currently handles shared block filters (for the classifier-action > qdisc) in the core due to what I believe are simply pragmatic reasons -

Re: [PATCH bpf] bpf: respect CAP_IPC_LOCK in RLIMIT_MEMLOCK check

2019-09-16 Thread Daniel Borkmann
On 9/11/19 8:18 PM, Christian Barcenas wrote: A process can lock memory addresses into physical RAM explicitly (via mlock, mlockall, shmctl, etc.) or implicitly (via VFIO, perf ring-buffers, bpf maps, etc.), subject to RLIMIT_MEMLOCK limits. CAP_IPC_LOCK allows a process to exceed these limits,

Re: [PATCH bpf-next v2 0/3] AF_XDP fixes for i40e, ixgbe and xdpsock

2019-09-16 Thread Daniel Borkmann
On 9/13/19 12:39 PM, Ciara Loftus wrote: This patch set contains some fixes for AF_XDP zero copy in the i40e and ixgbe drivers as well as a fix for the 'xdpsock' sample application when running in unaligned mode. Patches 1 and 2 fix a regression for the i40e and ixgbe drivers which caused the um

Re: [PATCH net-next v2 0/3] mlxsw: spectrum_buffers: Add the ability to query the CPU port's shared buffer

2019-09-16 Thread Shalom Toledo
Hi David, I have v3 with all the fixes Jiri commented. Can I send it? Or should I wait until net-next will be open again? Thanks, Shalom. On 16/09/2019 9:17, Ido Schimmel wrote: > From: Ido Schimmel > > Shalom says: > > While debugging packet loss towards the CPU, it is useful to be able to >

Re: [PATCH] libbpf: Don't error out if getsockopt() fails for XDP_OPTIONS

2019-09-16 Thread Daniel Borkmann
On 9/13/19 8:53 PM, Yonghong Song wrote: On 9/10/19 12:06 AM, Toke Høiland-Jørgensen wrote: Yonghong Song writes: On 9/9/19 10:46 AM, Toke Høiland-Jørgensen wrote: The xsk_socket__create() function fails and returns an error if it cannot get the XDP_OPTIONS through getsockopt(). However, supp

Re: [PATCH net-next v2 3/3] mlxsw: spectrum_buffers: Add the ability to query the CPU port's shared buffer

2019-09-16 Thread Jiri Pirko
Mon, Sep 16, 2019 at 08:17:50AM CEST, ido...@idosch.org wrote: >From: Shalom Toledo > >While debugging packet loss towards the CPU, it is useful to be able to >query the CPU port's shared buffer quotas and occupancy. > >Since the CPU port has no ingress buffers, all the shared buffers ingress >inf

macb: inconsistent Rx descriptor chain after OOM

2019-09-16 Thread Andreas Schwab
When there is an OOM situation, the macb driver cannot recover from it: [245622.872993] macb 1009.ethernet eth0: Unable to allocate sk_buff [245622.891438] macb 1009.ethernet eth0: inconsistent Rx descriptor chain After that, the interface is dead. Since this system is using NFS root, it

Re: [PATCH net-next 0/3] More fixes for unlocked cls hardware offload API refactoring

2019-09-16 Thread David Miller
From: Vlad Buslov Date: Fri, 13 Sep 2019 18:28:38 +0300 > Two fixes for my "Refactor cls hardware offload API to support > rtnl-independent drivers" series and refactoring patch that implements > infrastructure necessary for the fixes. Series applied, thanks.

Re: [PATCH net-next 0/6] net: add support for ip_tun_info options setting

2019-09-16 Thread David Miller
From: Xin Long Date: Mon, 16 Sep 2019 15:10:14 +0800 > With this patchset, users can configure options with LWTUNNEL_IP(6)_OPTS > by ip route encap for ersapn or vxlan lwtunnel. Note that in kernel part > it won't parse the option details but do some check and memcpy only, and > the options will

Re: [PATCH net-next 0/6] net: add support for ip_tun_info options setting

2019-09-16 Thread Xin Long
On Mon, Sep 16, 2019 at 3:10 PM Xin Long wrote: > > With this patchset, users can configure options with LWTUNNEL_IP(6)_OPTS > by ip route encap for ersapn or vxlan lwtunnel. Note that in kernel part > it won't parse the option details but do some check and memcpy only, and > the options will be p

Re: [PATCH] net/wan: dscc4: remove broken dscc4 driver

2019-09-16 Thread David Miller
From: Dan Carpenter Date: Fri, 13 Sep 2019 16:28:17 +0300 > Using static analysis, I discovered that the "dpriv->pci_priv->pdev" > pointer is always NULL. This pointer was supposed to be initialized > during probe and is essential for the driver to work. It would be easy > to add a "ppriv->pdev

Re: [PATCH net-next] MAINTAINERS: xen-netback: update my email address

2019-09-16 Thread David Miller
From: Paul Durrant Date: Fri, 13 Sep 2019 13:47:27 +0100 > My Citrix email address will expire shortly. > > Signed-off-by: Paul Durrant Applied.

[PATCH net-next 4/6] vxlan: check tun_info options_len properly

2019-09-16 Thread Xin Long
This patch is to improve the tun_info options_len by dropping the skb when TUNNEL_VXLAN_OPT is set but options_len is less than vxlan_metadata. This can void a potential out-of-bounds access on ip_tun_info. Signed-off-by: Xin Long --- drivers/net/vxlan.c | 6 -- 1 file changed, 4 insertions(

[PATCH net-next 2/6] lwtunnel: add LWTUNNEL_IP_OPTS support for lwtunnel_ip

2019-09-16 Thread Xin Long
This patch is to add LWTUNNEL_IP_OPTS into lwtunnel_ip_t, by which users will be able to set options for ip_tunnel_info by "ip route encap" for erspan and vxlan's private metadata. Like one way to go in iproute is: # ip route add 1.1.1.0/24 encap ip id 1 erspan ver 1 idx 123 \ dst 10.1.0.2

[PATCH net-next 6/6] erspan: make md work without TUNNEL_ERSPAN_OPT set

2019-09-16 Thread Xin Long
Now when a skb comes with ip_tun_info but with no TUNNEL_ERSPAN_OPT to a md erspan device, it will be dropped. This patch is to allow this skb to go through this erspan device, and the options (version, index, hwid, dir, etc.) will be filled with tunnel's params, which can be configured by users.

  1   2   >