[PATCH net-next 0/2] drop_monitor: Better sanitize notified packets

2019-09-14 Thread Ido Schimmel
From: Ido Schimmel When working in 'packet' mode, drop monitor generates a notification with a potentially truncated payload of the dropped packet. The payload is copied from the MAC header, but I forgot to check that the MAC header was set, so do it now. Patch #1 sets the offsets to the various

[PATCH net-next 2/2] drop_monitor: Better sanitize notified packets

2019-09-14 Thread Ido Schimmel
From: Ido Schimmel When working in 'packet' mode, drop monitor generates a notification with a potentially truncated payload of the dropped packet. The payload is copied from the MAC header, but I forgot to check that the MAC header was set, so do it now. Fixes: ca30707dee2b ("drop_monitor: Add

[PATCH net-next 1/2] netdevsim: Set offsets to various protocol layers

2019-09-14 Thread Ido Schimmel
From: Ido Schimmel The driver periodically generates "trapped" UDP packets that it then passes on to devlink. Set the offsets to the various protocol layers. This is a prerequisite to the next patch, where drop monitor is taught to check that the offset to the MAC header was set. Acked-by: Jiri

Re: [PATCH v4.14-stable 1/2] tcp: Reset send_head when removing skb from write-queue

2019-09-14 Thread kbuild test robot
/Christoph-Paasch/tcp-Reset-send_head-when-removing-skb-from-write-queue/20190914-144256 config: x86_64-randconfig-s0-201937 (attached as .config) compiler: gcc-4.9 (Debian 4.9.2-10+deb8u1) 4.9.2 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 If you fix

[PATCH v4 net-next 4/6] net: dsa: sja1105: Advertise the 8 TX queues

2019-09-14 Thread Vladimir Oltean
This is a preparation patch for the tc-taprio offload (and potentially for other future offloads such as tc-mqprio). Instead of looking directly at skb->priority during xmit, let's get the netdev queue and the queue-to-traffic-class mapping, and put the resulting traffic class into the dsa_8021q P

[PATCH v4 net-next 3/6] net: dsa: sja1105: Add static config tables for scheduling

2019-09-14 Thread Vladimir Oltean
In order to support tc-taprio offload, the TTEthernet egress scheduling core registers must be made visible through the static interface. Signed-off-by: Vladimir Oltean --- Changes since v2: - None. Changes since v1: - None. Changes since RFC: - None. .../net/dsa/sja1105/sja1105_dynamic_confi

[PATCH v4 net-next 5/6] net: dsa: sja1105: Configure the Time-Aware Scheduler via tc-taprio offload

2019-09-14 Thread Vladimir Oltean
This qdisc offload is the closest thing to what the SJA1105 supports in hardware for time-based egress shaping. The switch core really is built around SAE AS6802/TTEthernet (a TTTech standard) but can be made to operate similarly to IEEE 802.1Qbv with some constraints: - The gate control list is a

[PATCH v4 net-next 6/6] docs: net: dsa: sja1105: Add info about the Time-Aware Scheduler

2019-09-14 Thread Vladimir Oltean
While not an exhaustive usage tutorial, this describes the details needed to build more complex scenarios. Signed-off-by: Vladimir Oltean --- Changes since v2: - Specified that the HOSTPRIO switch setting is not configurable at the moment, since I dropped the patch for configuring it. Changes

[PATCH v4 net-next 1/6] taprio: Add support for hardware offloading

2019-09-14 Thread Vladimir Oltean
From: Vinicius Costa Gomes This allows taprio to offload the schedule enforcement to capable network cards, resulting in more precise windows and less CPU usage. The gate mask acts on traffic classes (groups of queues of same priority), as specified in IEEE 802.1Q-2018, and following the existin

[PATCH v4 net-next 2/6] net: dsa: Pass ndo_setup_tc slave callback to drivers

2019-09-14 Thread Vladimir Oltean
DSA currently handles shared block filters (for the classifier-action qdisc) in the core due to what I believe are simply pragmatic reasons - hiding the complexity from drivers and offerring a simple API for port mirroring. Extend the dsa_slave_setup_tc function by passing all other qdisc offloads

[PATCH v4 net-next 0/6] tc-taprio offload for SJA1105 DSA

2019-09-14 Thread Vladimir Oltean
This is the third attempt to submit the tc-taprio offload model for inclusion in the networking tree. The sja1105 switch driver will provide the first implementation of the offload. Only the bare minimum is added: - The offload model and a DSA pass-through - The hardware implementation - The inter

Re: [PATCH v3 net-next 0/7] tc-taprio offload for SJA1105 DSA

2019-09-14 Thread Vladimir Oltean
On Sun, 15 Sep 2019 at 04:53, Vladimir Oltean wrote: > > This is the second attempt to submit the tc-taprio offload model for > inclusion in the net tree. The sja1105 switch driver will provide the > first implementation of the offload. Only the bare minimum is added: > > - The offload model and a

[PATCH v3 net-next 4/7] net: dsa: sja1105: Advertise the 8 TX queues

2019-09-14 Thread Vladimir Oltean
This is a preparation patch for the tc-taprio offload (and potentially for other future offloads such as tc-mqprio). Instead of looking directly at skb->priority during xmit, let's get the netdev queue and the queue-to-traffic-class mapping, and put the resulting traffic class into the dsa_8021q P

[PATCH v3 net-next 5/7] net: dsa: sja1105: Make HOSTPRIO a kernel config

2019-09-14 Thread Vladimir Oltean
Unfortunately with this hardware, there is no way to transmit in-band QoS hints with management frames (i.e. VLAN PCP is ignored). The traffic class for these is fixed in the static config (which in turn requires a reset to change). With the new ability to add time gates for individual traffic cla

[PATCH v3 net-next 2/7] net: dsa: Pass ndo_setup_tc slave callback to drivers

2019-09-14 Thread Vladimir Oltean
DSA currently handles shared block filters (for the classifier-action qdisc) in the core due to what I believe are simply pragmatic reasons - hiding the complexity from drivers and offerring a simple API for port mirroring. Extend the dsa_slave_setup_tc function by passing all other qdisc offloads

[PATCH v3 net-next 1/7] taprio: Add support for hardware offloading

2019-09-14 Thread Vladimir Oltean
From: Vinicius Costa Gomes This allows taprio to offload the schedule enforcement to capable network cards, resulting in more precise windows and less CPU usage. The gate mask acts on traffic classes (groups of queues of same priority), as specified in IEEE 802.1Q-2018, and following the existin

[PATCH v3 net-next 0/7] tc-taprio offload for SJA1105 DSA

2019-09-14 Thread Vladimir Oltean
This is the second attempt to submit the tc-taprio offload model for inclusion in the net tree. The sja1105 switch driver will provide the first implementation of the offload. Only the bare minimum is added: - The offload model and a DSA pass-through - The hardware implementation - The interaction

[PATCH v3 net-next 3/7] net: dsa: sja1105: Add static config tables for scheduling

2019-09-14 Thread Vladimir Oltean
In order to support tc-taprio offload, the TTEthernet egress scheduling core registers must be made visible through the static interface. Signed-off-by: Vladimir Oltean --- .../net/dsa/sja1105/sja1105_dynamic_config.c | 8 + .../net/dsa/sja1105/sja1105_static_config.c | 167

[PATCH v3 net-next 7/7] docs: net: dsa: sja1105: Add info about the time-aware scheduler

2019-09-14 Thread Vladimir Oltean
While not an exhaustive usage tutorial, this describes the details needed to build more complex scenarios. Signed-off-by: Vladimir Oltean --- Documentation/networking/dsa/sja1105.rst | 90 1 file changed, 90 insertions(+) diff --git a/Documentation/networking/dsa/sja110

[PATCH v3 net-next 6/7] net: dsa: sja1105: Configure the Time-Aware Scheduler via tc-taprio offload

2019-09-14 Thread Vladimir Oltean
This qdisc offload is the closest thing to what the SJA1105 supports in hardware for time-based egress shaping. The switch core really is built around SAE AS6802/TTEthernet (a TTTech standard) but can be made to operate similarly to IEEE 802.1Qbv with some constraints: - The gate control list is a

Re: [PATCH v5 2/2] tcp: Add snd_wnd to TCP_INFO

2019-09-14 Thread Soheil Hassas Yeganeh
On Sat, Sep 14, 2019 at 11:45 AM Neal Cardwell wrote: > > On Fri, Sep 13, 2019 at 7:23 PM Thomas Higdon wrote: > > > > Neal Cardwell mentioned that snd_wnd would be useful for diagnosing TCP > > performance problems -- > > > (1) Usually when we're diagnosing TCP performance problems, we do so > >

Re: SFP support with RGMII MAC via RGMII to SERDES/SGMII PHY?

2019-09-14 Thread Russell King - ARM Linux admin
On Sat, Sep 14, 2019 at 10:15:26AM -0700, Florian Fainelli wrote: > > > On 9/14/2019 1:48 AM, Russell King - ARM Linux admin wrote: > > On Fri, Sep 13, 2019 at 08:31:18PM -0700, Florian Fainelli wrote: > >> +Russell, Andrew, Heiner, > >> > >> On 9/13/2019 9:44 AM, George McCollister wrote: > >>>

Re: SFP support with RGMII MAC via RGMII to SERDES/SGMII PHY?

2019-09-14 Thread Florian Fainelli
On 9/14/2019 1:48 AM, Russell King - ARM Linux admin wrote: > On Fri, Sep 13, 2019 at 08:31:18PM -0700, Florian Fainelli wrote: >> +Russell, Andrew, Heiner, >> >> On 9/13/2019 9:44 AM, George McCollister wrote: >>> Every example of phylink SFP support I've seen is using an Ethernet >>> MAC with

Re: [PATCH v5 2/2] tcp: Add snd_wnd to TCP_INFO

2019-09-14 Thread Neal Cardwell
On Fri, Sep 13, 2019 at 7:23 PM Thomas Higdon wrote: > > Neal Cardwell mentioned that snd_wnd would be useful for diagnosing TCP > performance problems -- > > (1) Usually when we're diagnosing TCP performance problems, we do so > > from the sender, since the sender makes most of the > > performanc

Re: [PATCH v5 1/2] tcp: Add TCP_INFO counter for packets received out-of-order

2019-09-14 Thread Neal Cardwell
On Fri, Sep 13, 2019 at 7:23 PM Thomas Higdon wrote: > > For receive-heavy cases on the server-side, we want to track the > connection quality for individual client IPs. This counter, similar to > the existing system-wide TCPOFOQueue counter in /proc/net/netstat, > tracks out-of-order packet recep

e1000e: workqueue problem

2019-09-14 Thread Randy Dunlap
This is 5.30-rc8 on x86_64. I would be happy to hear if this has already been addressed in some of your recent patches. Or: this could be a PCI-related or workqueue bug, but it only shows up when loading the e1000e driver. And not every time. [ 623.410732] calling e1000_init_module+0x0/0x1

[v3 3/3] samples: pktgen: allow to specify destination IP range (CIDR)

2019-09-14 Thread Daniel T. Lee
Currently, kernel pktgen has the feature to specify destination address range for sending packet. (e.g. pgset "dst_min/dst_max") But on samples, each of the scripts doesn't have any option to achieve this. This commit adds the feature to specify the destination address range with CIDR. -d :

[v3 2/3] samples: pktgen: add helper functions for IP(v4/v6) CIDR parsing

2019-09-14 Thread Daniel T. Lee
This commit adds CIDR parsing and IP validate helper function to parse single IP or range of IP with CIDR. (e.g. 198.18.0.0/15) Helpers will be used in prior to set target address in samples/pktgen. Signed-off-by: Daniel T. Lee --- Changes since v3: * Set errexit option to stop script execution

[v3 1/3] samples: pktgen: make variable consistent with option

2019-09-14 Thread Daniel T. Lee
This commit changes variable names that can cause confusion. For example, variable DST_MIN is quite confusing since the keyword 'udp_dst_min' and keyword 'dst_min' is used with pg_ctrl. On the following commit, 'dst_min' will be used to set destination IP, and the existing variable name DST_MIN s

Re: [PATCH net] ip6_gre: fix a dst leak in ip6erspan_tunnel_xmit

2019-09-14 Thread William Tu
On Fri, Sep 13, 2019 at 2:45 AM Xin Long wrote: > > In ip6erspan_tunnel_xmit(), if the skb will not be sent out, it has to > be freed on the tx_err path. Otherwise when deleting a netns, it would > cause dst/dev to leak, and dmesg shows: > > unregister_netdevice: waiting for lo to become free. U

Re: [v2 2/3] samples: pktgen: add helper functions for IP(v4/v6) CIDR parsing

2019-09-14 Thread Daniel T. Lee
On Fri, Sep 13, 2019 at 9:43 PM Jesper Dangaard Brouer wrote: > > On Thu, 12 Sep 2019 03:48:06 +0900 > "Daniel T. Lee" wrote: > > > This commit adds CIDR parsing and IP validate helper function to parse > > single IP or range of IP with CIDR. (e.g. 198.18.0.0/15) > > > > Helpers will be used in p

Re: net: phy: micrel KSZ9031 ifdown ifup issue

2019-09-14 Thread Andrew Lunn
On Fri, Sep 13, 2019 at 10:42:38AM -0400, Paul Thomas wrote: > Hello, > > I think I'm seeing an issue with the PHY hardware or PHY driver. What > happens is sometimes (but not always) when I do 'ip link set eth0 > down' followed by 'ip link set eth0 up' I don't ever see an > auto-negotiation again

Re: [v2 3/3] samples: pktgen: allow to specify destination IP range (CIDR)

2019-09-14 Thread Daniel T. Lee
On Fri, Sep 13, 2019 at 9:37 PM Toke Høiland-Jørgensen wrote: > > Jesper Dangaard Brouer writes: > > > On Thu, 12 Sep 2019 03:48:07 +0900 > > "Daniel T. Lee" wrote: > > > >> diff --git a/samples/pktgen/pktgen_sample01_simple.sh > >> b/samples/pktgen/pktgen_sample01_simple.sh > >> index 063ec099

Re: [PATCH v2 net-next 6/7] net: dsa: sja1105: Configure the Time-Aware Scheduler via tc-taprio offload

2019-09-14 Thread Vladimir Oltean
On 14/09/2019, kbuild test robot wrote: > Hi Vladimir, > > I love your patch! Yet something to improve: > > [auto build test ERROR on net-next/master] > > url: > https://github.com/0day-ci/linux/commits/Vladimir-Oltean/tc-taprio-offload-for-SJA1105-DSA/20190914-154650 &

Re: [PATCH v2 net-next 6/7] net: dsa: sja1105: Configure the Time-Aware Scheduler via tc-taprio offload

2019-09-14 Thread kbuild test robot
Hi Vladimir, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Vladimir-Oltean/tc-taprio-offload-for-SJA1105-DSA/20190914-154650 config: i386-randconfig-b001-201936 (attached as .config) compiler: gcc-7

Re: SFP support with RGMII MAC via RGMII to SERDES/SGMII PHY?

2019-09-14 Thread Russell King - ARM Linux admin
On Fri, Sep 13, 2019 at 08:31:18PM -0700, Florian Fainelli wrote: > +Russell, Andrew, Heiner, > > On 9/13/2019 9:44 AM, George McCollister wrote: > > Every example of phylink SFP support I've seen is using an Ethernet > > MAC with native SGMII. > > Can phylink facilitate support of Fiber and Coppe

Re: [PATCH 1/7] net/dsa: configure autoneg for CPU port

2019-09-14 Thread kbuild test robot
Hi Robert, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [cannot apply to v5.3-rc8 next-20190904] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commi