Re: Unable to create htb tc classes more than 64K

2019-08-19 Thread Akshat Kakkar
>> If your goal is merely having as many classes as you can, then yes. My goal is not just to make as many classes as possible, but also to use them to do rate limiting per ip per server. Say, I have a list of 1 IPs and more than 100 servers. So simply if I want few IPs to get speed of says 1M

Re: [PATCH net-next 4/6] net: dsa: Don't program the VLAN as pvid on the upstream port

2019-08-19 Thread Vivien Didelot
On Tue, 20 Aug 2019 03:00:00 +0300, Vladimir Oltean wrote: > Commit b2f81d304cee ("net: dsa: add CPU and DSA ports as VLAN members") > programs the VLAN from the bridge into the specified port as well as the > upstream port, with the same set of flags. > > Consider the typical case of installing

[PATCH][V2] net: fix __ip_mc_inc_group usage

2019-08-19 Thread Li RongQing
in ip_mc_inc_group, memory allocation flag, not mcast mode, is expected by __ip_mc_inc_group similar issue in __ip_mc_join_group, both mcase mode and gfp_t are needed here, so use ip_mc_inc_group(...) Fixes: 9fb20801dab4 ("net: Fix ip_mc_{dec,inc}_group allocation context") Signed-off-by: Li

Re: [PATCH net-next 3/6] net: dsa: Delete the VID from the upstream port as well

2019-08-19 Thread Vivien Didelot
Vladimir, On Tue, 20 Aug 2019 02:59:59 +0300, Vladimir Oltean wrote: > Commit b2f81d304cee ("net: dsa: add CPU and DSA ports as VLAN members") > is littering a lot. After deleting a VLAN added on a DSA port, it still > remains installed in the hardware filter of the upstream port. Fix this. Litt

Re: [PATCH net-next] net: openvswitch: Set OvS recirc_id from tc chain

2019-08-19 Thread Pravin Shelar
On Sun, Aug 18, 2019 at 9:01 AM Paul Blakey wrote: > > What do you guys say about the following diff on top of the last one? > Use static key, and also have OVS_DP_CMD_SET command probe/enable the feature. > > This will allow userspace to probe the feature, and selectivly enable it via > the > OV

Re: [PATCH net-next] net: openvswitch: Set OvS recirc_id from tc chain

2019-08-19 Thread Pravin Shelar
On Mon, Aug 19, 2019 at 10:42 AM Marcelo Ricardo Leitner wrote: > > On Sun, Aug 18, 2019 at 07:00:59PM +0300, Paul Blakey wrote: > > What do you guys say about the following diff on top of the last one? > > Use static key, and also have OVS_DP_CMD_SET command probe/enable the > > feature. > > > >

RE: [v2, 3/4] ocelot_ace: fix action of trap

2019-08-19 Thread Y.b. Lu
Hi, > -Original Message- > From: netdev-ow...@vger.kernel.org On > Behalf Of Allan W . Nielsen > Sent: Tuesday, August 13, 2019 2:30 PM > To: Y.b. Lu > Cc: netdev@vger.kernel.org; David S . Miller ; > Alexandre Belloni ; Microchip Linux Driver > Support > Subject: Re: [v2, 3/4] ocelot_a

[v3] ocelot_ace: fix action of trap

2019-08-19 Thread Yangbo Lu
The trap action should be copying the frame to CPU and dropping it for forwarding, but current setting was just copying frame to CPU. Signed-off-by: Yangbo Lu --- drivers/net/ethernet/mscc/ocelot_ace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mscc/

答复: [PATCH] net: Fix __ip_mc_inc_group argument 3 input

2019-08-19 Thread Li,Rongqing
> > > On 8/19/2019 7:25 PM, Li RongQing wrote: > > It expects gfp_t, but got unsigned int mode > > > > Fixes: 6e2059b53f98 ("ipv4/igmp: init group mode as INCLUDE when join > > source group") > > Signed-off-by: Li RongQing > > Signed-off-by: Zhang Yu > > You have identified a problem, but I do

Re: [PATCH] net: Fix __ip_mc_inc_group argument 3 input

2019-08-19 Thread Florian Fainelli
On 8/19/2019 7:25 PM, Li RongQing wrote: > It expects gfp_t, but got unsigned int mode > > Fixes: 6e2059b53f98 ("ipv4/igmp: init group mode as INCLUDE when join source > group") > Signed-off-by: Li RongQing > Signed-off-by: Zhang Yu You have identified a problem, but I don't think it came f

Re: [PATCH net-next 6/6] net: dsa: tag_8021q: Restore bridge pvid when enabling vlan_filtering

2019-08-19 Thread Florian Fainelli
On 8/19/2019 5:00 PM, Vladimir Oltean wrote: > The bridge core assumes that enabling/disabling vlan_filtering will > translate into the simple toggling of a flag for switchdev drivers. > > That is clearly not the case for sja1105, which alters the VLAN table > and the pvids in order to obtain p

Re: [PATCH net-next 5/6] net: dsa: Allow proper internal use of VLANs

2019-08-19 Thread Florian Fainelli
On 8/19/2019 5:00 PM, Vladimir Oltean wrote: > Below commit: > > commit 2ea7a679ca2abd251c1ec03f20508619707e1749 > Author: Andrew Lunn > Date: Tue Nov 7 00:04:24 2017 +0100 > > net: dsa: Don't add vlans when vlan filtering is disabled > > The software bridge can be build with vlan

Re: [PATCH net-next 1/6] net: dsa: tag_8021q: Future-proof the reserved fields in the custom VID

2019-08-19 Thread Florian Fainelli
On 8/19/2019 4:59 PM, Vladimir Oltean wrote: > After witnessing the discussion in https://lkml.org/lkml/2019/8/14/151 > w.r.t. ioctl extensibility, it became clear that such an issue might > prevent that the 3 RSV bits inside the DSA 802.1Q tag might also suffer > the same fate and be useless fo

Re: [PATCH net-next 4/6] net: dsa: Don't program the VLAN as pvid on the upstream port

2019-08-19 Thread Florian Fainelli
On 8/19/2019 5:00 PM, Vladimir Oltean wrote: > Commit b2f81d304cee ("net: dsa: add CPU and DSA ports as VLAN members") > programs the VLAN from the bridge into the specified port as well as the > upstream port, with the same set of flags. > > Consider the typical case of installing pvid 1 on us

[PATCH] net: fix icmp_socket_deliver argument 2 input

2019-08-19 Thread Li RongQing
it expects a unsigned int, but got a __be32 Signed-off-by: Li RongQing Signed-off-by: Zhang Yu --- net/ipv4/icmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/icmp.c b/net/ipv4/icmp.c index 1510e951f451..bf7b5d45de99 100644 --- a/net/ipv4/icmp.c +++ b/net/ipv4/i

Re: [PATCHv2 net] ipv6/addrconf: allow adding multicast addr if IFA_F_MCAUTOJOIN is set

2019-08-19 Thread David Ahern
On 8/19/19 10:19 PM, Hangbin Liu wrote: > But in ipv6_add_addr() it will check the address type and reject multicast > address directly. So this feature is never worked for IPv6. If true, that is really disappointing. We need to get a functional test script started for various address cases.

Re: [PATCH v3] tun: fix use-after-free when register netdev failed

2019-08-19 Thread Jason Wang
On 2019/8/20 上午9:25, David Miller wrote: From: Yang Yingliang Date: Mon, 19 Aug 2019 21:31:19 +0800 Call tun_attach() after register_netdevice() to make sure tfile->tun is not published until the netdevice is registered. So the read/write thread can not use the tun pointer that may freed by

[PATCH] net: Fix __ip_mc_inc_group argument 3 input

2019-08-19 Thread Li RongQing
It expects gfp_t, but got unsigned int mode Fixes: 6e2059b53f98 ("ipv4/igmp: init group mode as INCLUDE when join source group") Signed-off-by: Li RongQing Signed-off-by: Zhang Yu --- net/ipv4/igmp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv4/igmp.c b/net/

[PATCHv2 net] ipv6/addrconf: allow adding multicast addr if IFA_F_MCAUTOJOIN is set

2019-08-19 Thread Hangbin Liu
In commit 93a714d6b53d ("multicast: Extend ip address command to enable multicast group join/leave on") we added a new flag IFA_F_MCAUTOJOIN to make user able to add multicast address on ethernet interface. This works for IPv4, but not for IPv6. See the inet6_addr_add code. static int inet6_addr_

Re: [PATCH 1/2] bpf: fix 'struct pt_reg' typo in documentation

2019-08-19 Thread Alexei Starovoitov
On Mon, Aug 19, 2019 at 2:21 PM Peter Wu wrote: > > There is no 'struct pt_reg'. > > Signed-off-by: Peter Wu > --- > include/uapi/linux/bpf.h | 6 +++--- > tools/include/uapi/linux/bpf.h | 6 +++--- > 2 files changed, 6 insertions(+), 6 deletions(-) please split it into two patches. One f

[PATCH -next] bpf: Use PTR_ERR_OR_ZERO in xsk_map_inc()

2019-08-19 Thread YueHaibing
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Signed-off-by: YueHaibing --- kernel/bpf/xskmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/bpf/xskmap.c b/kernel/bpf/xskmap.c index 4cc28e226398..942c662e2eed 100644 --- a/kernel/bpf/xskmap.c +++ b/kernel

Re: [net-next v2 04/14] ice: fix set pause param autoneg check

2019-08-19 Thread David Miller
From: Jeff Kirsher Date: Mon, 19 Aug 2019 09:16:58 -0700 > + /* Get pause param reports configured and negotiated flow control pause > + * when ETHTOOL_GLINKSETTINGS is defined. Since ETHTOOL_GLINKSETTINGS is > + * defined get pause param pause->autoneg reports SW configured setting

Re: [PATCH net-next 0/8] sctp: support per endpoint auth and asconf flags

2019-08-19 Thread David Miller
From: Xin Long Date: Mon, 19 Aug 2019 22:02:42 +0800 > This patchset mostly does 3 things: > > 1. add per endpint asconf flag and use asconf flag properly > and add SCTP_ASCONF_SUPPORTED sockopt. > 2. use auth flag properly and add SCTP_AUTH_SUPPORTED sockopt. > 3. remove the 'global

Re: [PATCH v3] tun: fix use-after-free when register netdev failed

2019-08-19 Thread David Miller
From: Yang Yingliang Date: Mon, 19 Aug 2019 21:31:19 +0800 > Call tun_attach() after register_netdevice() to make sure tfile->tun > is not published until the netdevice is registered. So the read/write > thread can not use the tun pointer that may freed by free_netdev(). > (The tun and dev pointe

Re: [PATCH][net-next] net: remove empty inet_exit_net

2019-08-19 Thread David Miller
From: Li RongQing Date: Mon, 19 Aug 2019 20:05:15 +0800 > Pointer members of an object with static storage duration, if not > explicitly initialized, will be initialized to a NULL pointer. The > net namespace API checks if this pointer is not NULL before using it, > it are safe to remove the func

Re: [PATCH bpf-next 4/5] libbpf: add bpf_btf_get_next_id() to cycle through BTF objects

2019-08-19 Thread Alexei Starovoitov
On Thu, Aug 15, 2019 at 04:00:18PM +0100, Quentin Monnet wrote: > Add an API function taking a BTF object id and providing the id of the > next BTF object in the kernel. This can be used to list all BTF objects > loaded on the system. > > Signed-off-by: Quentin Monnet > Reviewed-by: Jakub Kicinsk

Re: [PATCH net-next 0/2] Fix problems with using ns plugin

2019-08-19 Thread David Miller
From: Vlad Buslov Date: Mon, 19 Aug 2019 10:52:06 +0300 > Recent changes to plugin architecture broke some of the tests when running tdc > without specifying a test group. Fix tests incompatible with ns plugin and > modify tests to not reuse interface name of ns veth interface for dummy > interfa

Re: [PATCH net] nfp: flower: verify that block cb is not busy before binding

2019-08-19 Thread David Miller
From: Vlad Buslov Date: Mon, 19 Aug 2019 10:33:04 +0300 > When processing FLOW_BLOCK_BIND command on indirect block, check that flow > block cb is not busy. > > Fixes: 0d4fd02e7199 ("net: flow_offload: add flow_block_cb_is_busy() and use > it") > Reported-by: Jakub Kicinski > Signed-off-by: Vl

[PATCH] ipvs: change type of delta and previous_delta in ip_vs_seq.

2019-08-19 Thread zhang kai
In NAT forwarding mode, Applications may decrease the size of packets, and TCP sequences will get smaller, so both of variables will be negetive values in this case. Signed-off-by: zhang kai --- include/net/ip_vs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/n

[PATCH 1/1] net: rds: add service level support in rds-info

2019-08-19 Thread Zhu Yanjun
>From IB specific 7.6.5 SERVICE LEVEL, Service Level (SL) is used to identify different flows within an IBA subnet. It is carried in the local route header of the packet. Before this commit, run "rds-info -I". The output is as below: " RDS IB Connections: LocalAddr RemoteAddr Tos SL LocalDev

Re: [PATCH net] ipv6/addrconf: allow adding multicast addr if IFA_F_MCAUTOJOIN is set

2019-08-19 Thread David Miller
From: Hangbin Liu Date: Tue, 13 Aug 2019 21:52:32 +0800 > The ip address autojoin is not working for IPv6 as ipv6_add_addr() > will return -EADDRNOTAVAIL when adding a multicast address. > > Reported-by: Jianlin Shi > Fixes: 93a714d6b53d ("multicast: Extend ip address command to enable > multi

Re: [PATCH net] ipv6: Fix return value of ipv6_mc_may_pull() for malformed packets

2019-08-19 Thread David Miller
From: Stefano Brivio Date: Mon, 19 Aug 2019 12:12:52 +0200 > I don't see this on net.git, but it's in your stable bundle on > Patchwork. Should I resend? Thanks. I applied it on my laptop while travelling and never pushed it out so it just rot there, sorry. Fixed, should be in 'net' now.

Re: [PATCH net-next 2/6] net: bridge: Populate the pvid flag in br_vlan_get_info

2019-08-19 Thread Nikolay Aleksandrov
On 8/20/19 2:59 AM, Vladimir Oltean wrote: > Currently this simplified code snippet fails: > > br_vlan_get_pvid(netdev, &pvid); > br_vlan_get_info(netdev, pvid, &vinfo); > ASSERT(!(vinfo.flags & BRIDGE_VLAN_INFO_PVID)); > > It is intuitive that the pvid of a netdevice should hav

[PATCH net-next 6/6] net: dsa: tag_8021q: Restore bridge pvid when enabling vlan_filtering

2019-08-19 Thread Vladimir Oltean
The bridge core assumes that enabling/disabling vlan_filtering will translate into the simple toggling of a flag for switchdev drivers. That is clearly not the case for sja1105, which alters the VLAN table and the pvids in order to obtain port separation in standalone mode. So, since the bridge w

[PATCH net-next 5/6] net: dsa: Allow proper internal use of VLANs

2019-08-19 Thread Vladimir Oltean
Below commit: commit 2ea7a679ca2abd251c1ec03f20508619707e1749 Author: Andrew Lunn Date: Tue Nov 7 00:04:24 2017 +0100 net: dsa: Don't add vlans when vlan filtering is disabled The software bridge can be build with vlan filtering support included. However, by default it is turned o

[PATCH net-next 3/6] net: dsa: Delete the VID from the upstream port as well

2019-08-19 Thread Vladimir Oltean
Commit b2f81d304cee ("net: dsa: add CPU and DSA ports as VLAN members") is littering a lot. After deleting a VLAN added on a DSA port, it still remains installed in the hardware filter of the upstream port. Fix this. Signed-off-by: Vladimir Oltean --- net/dsa/switch.c | 9 + 1 file chang

[PATCH net-next 4/6] net: dsa: Don't program the VLAN as pvid on the upstream port

2019-08-19 Thread Vladimir Oltean
Commit b2f81d304cee ("net: dsa: add CPU and DSA ports as VLAN members") programs the VLAN from the bridge into the specified port as well as the upstream port, with the same set of flags. Consider the typical case of installing pvid 1 on user port 1, pvid 2 on user port 2, etc. The upstream port w

[PATCH net-next 1/6] net: dsa: tag_8021q: Future-proof the reserved fields in the custom VID

2019-08-19 Thread Vladimir Oltean
After witnessing the discussion in https://lkml.org/lkml/2019/8/14/151 w.r.t. ioctl extensibility, it became clear that such an issue might prevent that the 3 RSV bits inside the DSA 802.1Q tag might also suffer the same fate and be useless for further extension. So clearly specify that the reserv

[PATCH net-next 0/6] Dynamic toggling of vlan_filtering for SJA1105 DSA

2019-08-19 Thread Vladimir Oltean
This patchset addresses a few limitations in DSA and the bridge core that made it impossible for this sequence of commands to work: ip link add name br0 type bridge ip link set dev swp2 master br0 echo 1 > /sys/class/net/br0/bridge/vlan_filtering Only this sequence was previously working:

Re: [net-next v2 04/14] ice: fix set pause param autoneg check

2019-08-19 Thread David Miller
From: Jakub Kicinski Date: Mon, 19 Aug 2019 16:11:42 -0700 > On Mon, 19 Aug 2019 09:16:58 -0700, Jeff Kirsher wrote: >> +pcaps = devm_kzalloc(&vsi->back->pdev->dev, sizeof(*pcaps), >> + GFP_KERNEL); >> +if (!pcaps) >> +return -ENOMEM; >> + >> +/* Ge

[PATCH net-next 2/6] net: bridge: Populate the pvid flag in br_vlan_get_info

2019-08-19 Thread Vladimir Oltean
Currently this simplified code snippet fails: br_vlan_get_pvid(netdev, &pvid); br_vlan_get_info(netdev, pvid, &vinfo); ASSERT(!(vinfo.flags & BRIDGE_VLAN_INFO_PVID)); It is intuitive that the pvid of a netdevice should have the BRIDGE_VLAN_INFO_PVID flag set. However I ca

Re: [net-next v2 00/14][pull request] 100GbE Intel Wired LAN Driver Updates 2019-08-19

2019-08-19 Thread Jakub Kicinski
On Mon, 19 Aug 2019 09:16:54 -0700, Jeff Kirsher wrote: > This series contains updates to ice driver only. FWIW from API perspective this set LGTM, however, the code doesn't always seem well thought out ;)

Re: What to do when a bridge port gets its pvid deleted?

2019-08-19 Thread Nikolay Aleksandrov
On 8/20/19 2:01 AM, Nikolay Aleksandrov wrote: > On 8/20/19 12:10 AM, Vladimir Oltean wrote: > [snip] >> It's good to know that it's there (like you said, it explains some >> things) but I can't exactly say that removing it helps in any way. >> In fact, removing it only overwrites the dsa_8021q VLA

Re: [net-next v2 04/14] ice: fix set pause param autoneg check

2019-08-19 Thread Jakub Kicinski
On Mon, 19 Aug 2019 09:16:58 -0700, Jeff Kirsher wrote: > + pcaps = devm_kzalloc(&vsi->back->pdev->dev, sizeof(*pcaps), > + GFP_KERNEL); > + if (!pcaps) > + return -ENOMEM; > + > + /* Get current PHY config */ > + status = ice_aq_get_phy_caps(pi,

Re: What to do when a bridge port gets its pvid deleted?

2019-08-19 Thread Nikolay Aleksandrov
On 8/20/19 12:10 AM, Vladimir Oltean wrote: [snip] > It's good to know that it's there (like you said, it explains some > things) but I can't exactly say that removing it helps in any way. > In fact, removing it only overwrites the dsa_8021q VLANs with 1 during > bridge_join, while not actually doi

Proposition!

2019-08-19 Thread Mme Mellie CARIUS
Bonjour, Je soussignée Mme Mellie CARIUS de nationalité française. Je vous envoie ce présent message afin de solliciter votre accord pour la réalisation d'un projet de donation. Ayant perdu mon époux et mon enfant de 8 ans au cours d'un accident tragique et mortel Il y a quelques années, je n'a

[PATCH 0/2] Small BPF documentation fixes

2019-08-19 Thread Peter Wu
Hi, Some fixes for doc issues I ran into while playing with BPF and uprobes. Kind regards, Peter Peter Wu (2): bpf: fix 'struct pt_reg' typo in documentation bpf: clarify description for CONFIG_BPF_EVENTS include/uapi/linux/bpf.h | 6 +++--- kernel/trace/Kconfig | 3 ++- to

[PATCH 1/2] bpf: fix 'struct pt_reg' typo in documentation

2019-08-19 Thread Peter Wu
There is no 'struct pt_reg'. Signed-off-by: Peter Wu --- include/uapi/linux/bpf.h | 6 +++--- tools/include/uapi/linux/bpf.h | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h index fa1c753dcdbc..9ca333c3ce91 10064

[PATCH 2/2] bpf: clarify description for CONFIG_BPF_EVENTS

2019-08-19 Thread Peter Wu
PERF_EVENT_IOC_SET_BPF supports uprobes since v4.3, and tracepoints since v4.7 via commit 04a22fae4cbc ("tracing, perf: Implement BPF programs attached to uprobes"), and commit 98b5c2c65c29 ("perf, bpf: allow bpf programs attach to tracepoints") respectively. Signed-off-by: Peter Wu --- kernel/t

Re: What to do when a bridge port gets its pvid deleted?

2019-08-19 Thread Vladimir Oltean
On Mon, 19 Aug 2019 at 23:15, Ido Schimmel wrote: > > On Mon, Aug 19, 2019 at 08:15:03PM +0300, Vladimir Oltean wrote: > > On 6/28/19 7:45 PM, Florian Fainelli wrote: > > > On 6/28/19 5:37 AM, Vladimir Oltean wrote: > > > > On Fri, 28 Jun 2019 at 15:30, Ido Schimmel wrote: > > > > > > > > > > On

Re: [PATCH net-next 2/3] tcp: ulp: add functions to dump ulp-specific information

2019-08-19 Thread Jakub Kicinski
On Mon, 19 Aug 2019 15:32:09 +0200, Davide Caratti wrote: > On Thu, 2019-08-15 at 14:38 -0700, Jakub Kicinski wrote: > > On Thu, 15 Aug 2019 20:46:01 +0200, Eric Dumazet wrote: > > > On 8/15/19 6:00 PM, Davide Caratti wrote: > > > > + if (net_admin) { > > > > + const struct tc

Re: [PATCH net] nfp: flower: verify that block cb is not busy before binding

2019-08-19 Thread Jakub Kicinski
On Mon, 19 Aug 2019 10:33:04 +0300, Vlad Buslov wrote: > When processing FLOW_BLOCK_BIND command on indirect block, check that flow > block cb is not busy. > > Fixes: 0d4fd02e7199 ("net: flow_offload: add flow_block_cb_is_busy() and use > it") > Reported-by: Jakub Kicinski > Signed-off-by: Vlad

Re: [PATCH net-next v7 5/6] flow_offload: support get multi-subsystem block

2019-08-19 Thread Jakub Kicinski
On Mon, 19 Aug 2019 07:26:07 +, Vlad Buslov wrote: > On Fri 16 Aug 2019 at 20:56, Jakub Kicinski > wrote: > > Hi Vlad! > > > > While looking into this, would you mind also add the missing > > flow_block_cb_is_busy() calls in the indirect handlers in the drivers? > > > > LMK if you're too busy

Re: [PATCH 0/5] Netfilter fixes for net

2019-08-19 Thread David Miller
From: Pablo Neira Ayuso Date: Mon, 19 Aug 2019 20:49:06 +0200 > The following patchset contains Netfilter fixes for net: > > 1) Remove IP MASQUERADING record in MAINTAINERS file, >from Denis Efremov. > > 2) Counter arguments are swapped in ebtables, from >Todd Seidelmann. > > 3) Missin

Re: What to do when a bridge port gets its pvid deleted?

2019-08-19 Thread Ido Schimmel
On Mon, Aug 19, 2019 at 08:15:03PM +0300, Vladimir Oltean wrote: > On 6/28/19 7:45 PM, Florian Fainelli wrote: > > On 6/28/19 5:37 AM, Vladimir Oltean wrote: > > > On Fri, 28 Jun 2019 at 15:30, Ido Schimmel wrote: > > > > > > > > On Tue, Jun 25, 2019 at 11:49:29PM +0300, Vladimir Oltean wrote: >

Re: [PATCH net-next 0/6] net: dsa: enable and disable all ports

2019-08-19 Thread David Miller
From: Vivien Didelot Date: Sun, 18 Aug 2019 13:35:42 -0400 > The DSA stack currently calls the .port_enable and .port_disable switch > callbacks for slave ports only. However, it is useful to call them for all > port types. For example this allows some drivers to delay the optimization > of power

Re: [PATCH net] tcp: make sure EPOLLOUT wont be missed

2019-08-19 Thread David Miller
From: Eric Dumazet Date: Fri, 16 Aug 2019 21:26:22 -0700 > As Jason Baron explained in commit 790ba4566c1a ("tcp: set SOCK_NOSPACE > under memory pressure"), it is crucial we properly set SOCK_NOSPACE > when needed. > > However, Jason patch had a bug, because the 'nonblocking' status > as far as

Re: [PATCH net-next 0/2] net: phy: realtek: support NBase-T MMD EEE registers on RTL8125

2019-08-19 Thread David Miller
From: Heiner Kallweit Date: Fri, 16 Aug 2019 21:55:40 +0200 > Add missing EEE-related constants, including the new MMD EEE registers > for NBase-T / 802.3bz. Based on that emulate the new 802.3bz MMD EEE > registers for 2.5Gbps EEE on RTL8125. Series applied.

Re: [PATCH net-next] net: flow_offload: convert block_ing_cb_list to regular list type

2019-08-19 Thread David Miller
From: Vlad Buslov Date: Fri, 16 Aug 2019 18:06:54 +0300 > RCU list block_ing_cb_list is protected by rcu read lock in > flow_block_ing_cmd() and with flow_indr_block_ing_cb_lock mutex in all > functions that use it. However, flow_block_ing_cmd() needs to call blocking > functions while iterating

[PATCH net-next v2 5/6] net: dsa: mv88e6xxx: enable SERDES after setup

2019-08-19 Thread Vivien Didelot
SERDES is powered on for CPU and DSA ports and powered down for unused ports at setup time. But now that DSA calls mv88e6xxx_port_enable and mv88e6xxx_port_disable for all ports, the SERDES power can now be handled after setup inconditionally for all ports. Using the port enable and disable callba

[PATCH net-next v2 6/6] net: dsa: mv88e6xxx: wrap SERDES IRQ in power function

2019-08-19 Thread Vivien Didelot
Now that mv88e6xxx_serdes_power is only called after driver setup, we can wrap the SERDES IRQ code directly within it for clarity. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c | 32 +++- 1 file changed, 19 insertions(+), 13 deletions(-) diff --g

[PATCH net-next v2 4/6] net: dsa: mv88e6xxx: do not change STP state on port disabling

2019-08-19 Thread Vivien Didelot
When disabling a port, that is not for the driver to decide what to do with the STP state. This is already handled by the DSA layer. Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/dsa/

[PATCH net-next v2 0/6] net: dsa: enable and disable all ports

2019-08-19 Thread Vivien Didelot
The DSA stack currently calls the .port_enable and .port_disable switch callbacks for slave ports only. However, it is useful to call them for all port types. For example this allows some drivers to delay the optimization of power consumption after the switch is setup. This can also help reducing t

[PATCH net-next v2 1/6] net: dsa: use a single switch statement for port setup

2019-08-19 Thread Vivien Didelot
It is currently difficult to read the different steps involved in the setup and teardown of ports in the DSA code. Keep it simple with a single switch statement for each port type: UNUSED, CPU, DSA, or USER. Also no need to call devlink_port_unregister from within dsa_port_setup as this step is in

[PATCH net-next v2 2/6] net: dsa: do not enable or disable non user ports

2019-08-19 Thread Vivien Didelot
The .port_enable and .port_disable operations are currently only called for user ports, hence assuming they have a slave device. In preparation for using these operations for other port types as well, simply guard all implementations against non user ports and return directly in such case. Note th

[PATCH net-next v2 3/6] net: dsa: enable and disable all ports

2019-08-19 Thread Vivien Didelot
Call the .port_enable and .port_disable functions for all ports, not only the user ports, so that drivers may optimize the power consumption of all ports after a successful setup. Unused ports are now disabled on setup. CPU and DSA ports are now enabled on setup and disabled on teardown. User port

[PATCH bpf-next v2 0/4] selftests/bpf: test_progs: misc fixes

2019-08-19 Thread Stanislav Fomichev
* add test__skip to indicate skipped tests * remove global success/error counts (use environment) * remove asserts from the tests * remove unused ret from send_signal test v2: * drop patch that changes output to keep consistent with test_verifier (Alexei Starovoitov) * QCHECK instead of test__fa

[PATCH bpf-next v2 3/4] selftests/bpf: test_progs: remove asserts from subtests

2019-08-19 Thread Stanislav Fomichev
Otherwise they can bring the whole process down. Cc: Andrii Nakryiko Signed-off-by: Stanislav Fomichev --- .../selftests/bpf/prog_tests/bpf_obj_id.c | 19 +++--- .../selftests/bpf/prog_tests/map_lock.c | 20 +++ .../selftests/bpf/prog_tests/spinlock.c

[PATCH bpf-next v2 1/4] selftests/bpf: test_progs: test__skip

2019-08-19 Thread Stanislav Fomichev
Export test__skip() to indicate skipped tests and use it in test_send_signal_nmi(). Cc: Andrii Nakryiko Signed-off-by: Stanislav Fomichev --- .../selftests/bpf/prog_tests/send_signal.c| 1 + tools/testing/selftests/bpf/test_progs.c | 20 +-- tools/testing/selftests/bpf

[PATCH bpf-next v2 2/4] selftests/bpf: test_progs: remove global fail/success counts

2019-08-19 Thread Stanislav Fomichev
Now that we have a global per-test/per-environment state, there is no longer need to have global fail/success counters (and there is no need to save/get the diff before/after the test). Introduce QCHECK macro (suggested by Andrii) and covert existing tests to it. QCHECK uses new test__fail() to re

[PATCH bpf-next v2 4/4] selftests/bpf: test_progs: remove unused ret

2019-08-19 Thread Stanislav Fomichev
send_signal test returns static codes from the subtests which nobody looks at, let's rely on the CHECK macros instead. Signed-off-by: Stanislav Fomichev --- .../selftests/bpf/prog_tests/send_signal.c| 42 +-- 1 file changed, 19 insertions(+), 23 deletions(-) diff --git a/too

[PATCH 5/5] netfilter: add include guard to nf_conntrack_h323_types.h

2019-08-19 Thread Pablo Neira Ayuso
From: Masahiro Yamada Add a header include guard just in case. Signed-off-by: Masahiro Yamada Signed-off-by: Pablo Neira Ayuso --- include/linux/netfilter/nf_conntrack_h323_types.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/linux/netfilter/nf_conntrack_h323_types.h b/in

[PATCH 3/5] netfilter: nft_flow_offload: missing netlink attribute policy

2019-08-19 Thread Pablo Neira Ayuso
The netlink attribute policy for NFTA_FLOW_TABLE_NAME is missing. Fixes: a3c90f7a2323 ("netfilter: nf_tables: flow offload expression") Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nft_flow_offload.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/net/netfilter/nft_flow_offload.c

[PATCH 4/5] netfilter: xt_nfacct: Fix alignment mismatch in xt_nfacct_match_info

2019-08-19 Thread Pablo Neira Ayuso
From: Juliana Rodrigueiro When running a 64-bit kernel with a 32-bit iptables binary, the size of the xt_nfacct_match_info struct diverges. kernel: sizeof(struct xt_nfacct_match_info) : 40 iptables: sizeof(struct xt_nfacct_match_info)) : 36 Trying to append nfacct related rules results

[PATCH 0/5] Netfilter fixes for net

2019-08-19 Thread Pablo Neira Ayuso
Hi, The following patchset contains Netfilter fixes for net: 1) Remove IP MASQUERADING record in MAINTAINERS file, from Denis Efremov. 2) Counter arguments are swapped in ebtables, from Todd Seidelmann. 3) Missing netlink attribute validation in flow_offload extension. 4) Incorrect al

[PATCH 1/5] MAINTAINERS: Remove IP MASQUERADING record

2019-08-19 Thread Pablo Neira Ayuso
From: Denis Efremov This entry is in MAINTAINERS for historical purpose. It doesn't match current sources since the commit adf82accc5f5 ("netfilter: x_tables: merge ip and ipv6 masquerade modules") moved the module. The net/netfilter/xt_MASQUERADE.c module is already under the netfilter section.

[PATCH 2/5] netfilter: ebtables: Fix argument order to ADD_COUNTER

2019-08-19 Thread Pablo Neira Ayuso
From: Todd Seidelmann The ordering of arguments to the x_tables ADD_COUNTER macro appears to be wrong in ebtables (cf. ip_tables.c, ip6_tables.c, and arp_tables.c). This causes data corruption in the ebtables userspace tools because they get incorrect packet & byte counts from the kernel. Fixes

Re: [PATCH net] tcp: make sure EPOLLOUT wont be missed

2019-08-19 Thread Jason Baron
On 8/17/19 12:26 PM, Eric Dumazet wrote: > > > On 8/17/19 4:19 PM, Jason Baron wrote: >> >> >> On 8/17/19 12:26 AM, Eric Dumazet wrote: >>> As Jason Baron explained in commit 790ba4566c1a ("tcp: set SOCK_NOSPACE >>> under memory pressure"), it is crucial we properly set SOCK_NOSPACE >>> when n

[net PATCH] net/smc: make sure EPOLLOUT is raised

2019-08-19 Thread Jason Baron
Currently, we are only explicitly setting SOCK_NOSPACE on a write timeout for non-blocking sockets. Epoll() edge-trigger mode relies on SOCK_NOSPACE being set when -EAGAIN is returned to ensure that EPOLLOUT is raised. Expand the setting of SOCK_NOSPACE to non-blocking sockets as well that can use

Re: [PATCH 00/16] treewide: prefer __section from compiler_attributes.h

2019-08-19 Thread Sedat Dilek
On Mon, Aug 12, 2019 at 11:53 PM Nick Desaulniers wrote: > > GCC unescapes escaped string section names while Clang does not. Because > __section uses the `#` stringification operator for the section name, it > doesn't need to be escaped. > > This fixes an Oops observed in distro's that use system

Re: [RFC PATCH bpf-next 00/14] xdp_flow: Flow offload to XDP

2019-08-19 Thread Jakub Kicinski
On Sat, 17 Aug 2019 23:01:59 +0900, Toshiaki Makita wrote: > On 19/08/17 (土) 3:52:24, Jakub Kicinski wrote: > > On Fri, 16 Aug 2019 10:28:10 +0900, Toshiaki Makita wrote: > >> On 2019/08/16 4:22, Jakub Kicinski wrote: > >>> There's a certain allure in bringing the in-kernel BPF translation > >>

Re: [PATCH net-next 3/6] net: dsa: enable and disable all ports

2019-08-19 Thread Vivien Didelot
Hi Marek, On Mon, 19 Aug 2019 19:32:46 +0200, Marek Behun wrote: > > Call the .port_enable and .port_disable functions for all ports, > > not only the user ports, so that drivers may optimize the power > > consumption of all ports after a successful setup. > > > > Unused ports are now disabled o

Re: [PATCH net-next 0/8] sctp: support per endpoint auth and asconf flags

2019-08-19 Thread Marcelo Ricardo Leitner
On Mon, Aug 19, 2019 at 10:02:42PM +0800, Xin Long wrote: > This patchset mostly does 3 things: > > 1. add per endpint asconf flag and use asconf flag properly > and add SCTP_ASCONF_SUPPORTED sockopt. > 2. use auth flag properly and add SCTP_AUTH_SUPPORTED sockopt. > 3. remove the 'glob

Re: [PATCH net-next] net: openvswitch: Set OvS recirc_id from tc chain

2019-08-19 Thread Marcelo Ricardo Leitner
On Sun, Aug 18, 2019 at 07:00:59PM +0300, Paul Blakey wrote: > What do you guys say about the following diff on top of the last one? > Use static key, and also have OVS_DP_CMD_SET command probe/enable the feature. > > This will allow userspace to probe the feature, and selectivly enable it via >

Re: [PATCH v2 bpf-next 1/4] bpf: unprivileged BPF access via /dev/bpf

2019-08-19 Thread Andy Lutomirski
> On Aug 19, 2019, at 10:27 AM, Alexei Starovoitov > wrote: > >> On Mon, Aug 19, 2019 at 11:15:11AM +0200, Thomas Gleixner wrote: >> Alexei, >> >>> On Sat, 17 Aug 2019, Alexei Starovoitov wrote: On Fri, Aug 16, 2019 at 10:28:29PM +0200, Thomas Gleixner wrote: On Fri, 16 Aug 2019, A

Re: Help needed - Kernel lockup while running ipsec

2019-08-19 Thread Florian Westphal
Vakul Garg wrote: > Hi > > With kernel 4.14.122, I am getting a kernel softlockup while running single > static ipsec tunnel. > The problem reproduces mostly after running 8-10 hours of ipsec encap test > (on my dual core arm board). > > I found that in function xfrm_policy_lookup_bytype(), th

Re: [PATCH net-next 3/6] net: dsa: enable and disable all ports

2019-08-19 Thread Marek Behun
On Sun, 18 Aug 2019 13:35:45 -0400 Vivien Didelot wrote: > Call the .port_enable and .port_disable functions for all ports, > not only the user ports, so that drivers may optimize the power > consumption of all ports after a successful setup. > > Unused ports are now disabled on setup. CPU and D

Re: [PATCH v2 bpf-next 1/4] bpf: unprivileged BPF access via /dev/bpf

2019-08-19 Thread Alexei Starovoitov
On Mon, Aug 19, 2019 at 11:15:11AM +0200, Thomas Gleixner wrote: > Alexei, > > On Sat, 17 Aug 2019, Alexei Starovoitov wrote: > > On Fri, Aug 16, 2019 at 10:28:29PM +0200, Thomas Gleixner wrote: > > > On Fri, 16 Aug 2019, Alexei Starovoitov wrote: > > > While real usecases are helpful to understan

Re: [PATCH bpf-next] libbpf: relicense bpf_helpers.h and bpf_endian.h

2019-08-19 Thread Naveen N. Rao
Andrii Nakryiko wrote: bpf_helpers.h and bpf_endian.h contain useful macros and BPF helper definitions essential to almost every BPF program. Which makes them useful not just for selftests. To be able to expose them as part of libbpf, though, we need them to be dual-licensed as LGPL-2.1 OR BSD-2-

Re: [PATCH net-next 1/6] net: dsa: use a single switch statement for port setup

2019-08-19 Thread Vivien Didelot
Hi Florian, On Mon, 19 Aug 2019 10:14:24 -0700, Florian Fainelli wrote: > On 8/18/19 10:35 AM, Vivien Didelot wrote: > > It is currently difficult to read the different steps involved in the > > setup and teardown of ports in the DSA code. Keep it simple with a > > single switch statement for ea

Re: [PATCH net-next 3/6] net: dsa: enable and disable all ports

2019-08-19 Thread Florian Fainelli
On 8/18/19 10:35 AM, Vivien Didelot wrote: > Call the .port_enable and .port_disable functions for all ports, > not only the user ports, so that drivers may optimize the power > consumption of all ports after a successful setup. > > Unused ports are now disabled on setup. CPU and DSA ports are now

Re: [PATCH net-next 2/6] net: dsa: do not enable or disable non user ports

2019-08-19 Thread Florian Fainelli
On 8/18/19 10:35 AM, Vivien Didelot wrote: > The .port_enable and .port_disable operations are currently only > called for user ports, hence assuming they have a slave device. In > preparation for using these operations for other port types as well, > simply guard all implementations against non us

Re: What to do when a bridge port gets its pvid deleted?

2019-08-19 Thread Vladimir Oltean
On 6/28/19 7:45 PM, Florian Fainelli wrote: On 6/28/19 5:37 AM, Vladimir Oltean wrote: On Fri, 28 Jun 2019 at 15:30, Ido Schimmel wrote: On Tue, Jun 25, 2019 at 11:49:29PM +0300, Vladimir Oltean wrote: A number of DSA drivers (BCM53XX, Microchip KSZ94XX, Mediatek MT7530 at the very least), a

Re: [PATCH net-next 1/6] net: dsa: use a single switch statement for port setup

2019-08-19 Thread Florian Fainelli
On 8/18/19 10:35 AM, Vivien Didelot wrote: > It is currently difficult to read the different steps involved in the > setup and teardown of ports in the DSA code. Keep it simple with a > single switch statement for each port type: UNUSED, CPU, DSA, or USER. > > Also no need to call devlink_port_unr

Re: [PATCH net-next 4/6] net: dsa: mv88e6xxx: do not change STP state on port disabling

2019-08-19 Thread Andrew Lunn
On Mon, Aug 19, 2019 at 12:27:37PM -0400, Vivien Didelot wrote: > On Mon, 19 Aug 2019 18:10:18 +0200, Andrew Lunn wrote: > > > On Mon, 19 Aug 2019 15:40:57 +0200, Andrew Lunn wrote: > > > > On Sun, Aug 18, 2019 at 01:35:46PM -0400, Vivien Didelot wrote: > > > > > When disabling a port, that is no

Re: [PATCH net-next 4/6] net: dsa: mv88e6xxx: do not change STP state on port disabling

2019-08-19 Thread Vivien Didelot
On Mon, 19 Aug 2019 18:10:18 +0200, Andrew Lunn wrote: > > On Mon, 19 Aug 2019 15:40:57 +0200, Andrew Lunn wrote: > > > On Sun, Aug 18, 2019 at 01:35:46PM -0400, Vivien Didelot wrote: > > > > When disabling a port, that is not for the driver to decide what to > > > > do with the STP state. This i

[net-next v2 12/14] ice: Move VF resources definition to SR-IOV specific file

2019-08-19 Thread Jeff Kirsher
From: Akeem G Abodunrin In order to use some of the VF resources definition in the SR-IOV specific virtchnl header file, this patch moves applicable code to ice_virtchnl_pf.h file accordingly... and they should have been defined in the destination file originally. Signed-off-by: Akeem G Abodunri

[net-next v2 06/14] ice: Fix kernel hang with DCB reset in CEE mode

2019-08-19 Thread Jeff Kirsher
From: Usha Ketineni This patch fixes the set local MIB AQ call failures in the DCB rebuild path by setting the defaults for the ETS recommended DCB configuration. Also, willing bits for the DCB configuration needs to be set correctly. Resets works fine in IEEE mode as the ETS recommended DCB conf

[net-next v2 01/14] ice: Use the software based tail when checking for hung Tx ring

2019-08-19 Thread Jeff Kirsher
From: Brett Creeley Currently in ice_get_tx_pending we try to read a Tx ring's tail. This is then compared with the software based head (next_to_clean) to determine if we have pending work. This will never work because reading of the Tx ring's tail is no longer supported. Fix this by using the so

[net-next v2 09/14] ice: update GLINT_DYN_CTL and GLINT_VECT2FUNC register access

2019-08-19 Thread Jeff Kirsher
From: Paul Greenwalt Register access for GLINT_DYN_CTL and GLINT_VECT2FUNC should be within the PF space and not the absolute device space. Signed-off-by: Paul Greenwalt Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- .../net/ethernet/intel/ice/ice_virtchnl_pf.c | 24 +++---

  1   2   >