How are you today
I'm Capt Kristen from github, please get back to me for more about me
On 8/14/19 7:37 PM, Stanislav Fomichev wrote:
Currently there is no way to propagate sk storage from the listener
socket to a newly accepted one. Consider the following use case:
fd = socket();
setsockopt(fd, SOL_IP, IP_TOS,...);
/* ^^^ setsockopt BPF program triggers
On 8/16/19 7:08 PM, Petar Penkov wrote:
From: Petar Penkov
There is a race in this test between receiving the ACK for the
single-byte packet sent in the test, and reading the values from the
map.
This patch fixes this by having the client wait until there are no more
unacknowledged packets.
B
On 8/16/19 7:45 AM, Andrii Nakryiko wrote:
bpf_helpers.h and bpf_endian.h contain useful macros and BPF helper
definitions essential to almost every BPF program. Which makes them
useful not just for selftests. To be able to expose them as part of
libbpf, though, we need them to be dual-licensed a
On 8/14/19 4:34 PM, Maxim Mikityanskiy wrote:
Don't uninstall an XDP program when none is installed, and don't install
an XDP program that has the same ID as the one already installed.
dev_change_xdp_fd doesn't perform any checks in case it uninstalls an
XDP program. It means that the driver's n
On 8/14/19 9:27 AM, Magnus Karlsson wrote:
This patch set adds support for a new flag called need_wakeup in the
AF_XDP Tx and fill rings. When this flag is set by the driver, it
means that the application has to explicitly wake up the kernel Rx
(for the bit in the fill ring) or kernel Tx (for bit
On 8/15/19 11:30 AM, Björn Töpel wrote:
This series (v5 and counting) add two improvements for the XSKMAP,
used by AF_XDP sockets.
1. Automatic cleanup when an AF_XDP socket goes out of scope/is
released. Instead of require that the user manually clears the
"released" state socket from t
During device shutdown, the VNIC clearing sequence needs to be modified
to free the VNIC first before freeing the RSS contexts. The current
code is doing the reverse and we can get mis-directed RX completions
to CP ring ID 0 when the RSS contexts are freed and zeroed. The clearing
of RSS contexts
2 Bug fixes related to 57500 shutdown sequence and doorbell sequence,
2 TC Flower bug fixes related to the setting of the flow direction,
1 NVRAM update bug fix, and a minor fix to suppress an unnecessary
error message. Please queue for -stable as well. Thanks.
v2: Fix compile warning reported b
From: Vasundhara Volam
If FW returns FRAG_ERR in response error code, driver is resending the
command only when HWRM command returns success. Fix the code to resend
NVM_INSTALL_UPDATE command with DEFRAG install flags, if FW returns
FRAG_ERR in its response error code.
Fixes: cb4d1d626145 ("bnxt
When both RX buffers and RX aggregation buffers have to be
replenished at the end of NAPI, post the RX aggregation buffers first
before RX buffers. Otherwise, we may run into a situation where
there are only RX buffers without RX aggregation buffers for a split
second. This will cause the hardwar
From: Somnath Kotur
FW expects the driver to provide unique flow reference handles
for Tx or Rx flows. When a Tx flow and an Rx flow end up sharing
a reference handle, flow offload does not seem to work.
This could happen in the case of 2 flows having their L2 fields
wildcarded but in different d
From: Venkat Duvvuru
Direction of the flow is determined using src_fid. For an RX flow,
src_fid is PF's fid and for TX flow, src_fid is VF's fid. Direction
of the flow must be specified, when getting statistics for that flow.
Currently, for DECAP flow, direction is determined incorrectly, i.e.,
d
From: Vasundhara Volam
For newly added NVM parameters, older firmware may not have the support.
Suppress the error message to avoid the unncessary error message which is
triggered when devlink calls the driver during initialization.
Fixes: 782a624d00fa ("bnxt_en: Add bnxt_en initial params table
Hi Marek,
On Sat, 17 Aug 2019 21:14:48 +0200, Marek Behún wrote:
> Hi,
>
> here is another proposal for supporting setting 2500base-x mode for
> CPU/DSA ports in device tree correctly.
>
> The changes from v1 are that instead of adding .port_setup() and
> .port_teardown() methods to the DSA ope
From: Saeed Mahameed
Date: Thu, 15 Aug 2019 19:10:07 +
> +static int mlx5e_rx_reporter_timeout_recover(void *ctx)
> +{
> + struct mlx5e_rq *rq = ctx;
> + struct mlx5e_icosq *icosq = &rq->channel->icosq;
> + struct mlx5_eq_comp *eq = rq->cq.mcq.eq;
> + int err;
In this and sev
From: Ido Schimmel
Date: Sat, 17 Aug 2019 16:28:09 +0300
> Users have several ways to debug the kernel and understand why a packet
> was dropped. For example, using drop monitor and perf. Both utilities
> trace kfree_skb(), which is the function called when a packet is freed
> as part of a failur
From: Johan Hedberg
Date: Sat, 17 Aug 2019 14:44:51 +0300
> Here's a set of Bluetooth fixes for the 5.3-rc series:
>
> - Multiple fixes for Qualcomm (btqca & hci_qca) drivers
> - Minimum encryption key size debugfs setting (this is required for
>Bluetooth Qualification)
> - Fix hidp_send_
From: Heiner Kallweit
Date: Sat, 17 Aug 2019 12:28:18 +0200
> Supported PHY features are either auto-detected or explicitly set.
> In both cases calling genphy_config_init isn't needed. All that
> genphy_config_init does is removing features that are set as
> supported but can't be auto-detected.
Hi Marek,
On Sat, 17 Aug 2019 20:15:52 +0200, Marek Behun wrote:
> On Sat, 17 Aug 2019 20:03:42 +0200
> Marek Behun wrote:
>
> > One way would be to rename the mv88e6xxx_setup_port function to
> > mv88e6xxx_setup_port_regs, or mv88e6xxx_port_pre_setup, or something
> > like that. Would the name
CPU/DSA ports are now enabled/disabled in the .port_enable() and
.port_disable() methods. We do not need to enable SERDESes for these
ports in mv88e6xxx_setup.
Signed-off-by: Marek Behún
Cc: Andrew Lunn
Cc: Florian Fainelli
Cc: Vladimir Oltean
Cc: Vivien Didelot
---
drivers/net/dsa/mv88e6xxx
The mv88e6390_serdes_irq_link_sgmii IRQ handler reads the SERDES PHY
status register to determine speed, among other things. If cmode of the
port is set to 2500base-x, though, the PHY still reports 1000 Mbps (the
PHY register itself does not differentiate between 1000 Mbps and 2500
Mbps - it thinks
The mv88e6xxx_port_disable method calls mv88e6xxx_port_set_state, which
should be called only for user ports.
Signed-off-by: Marek Behún
Cc: Andrew Lunn
Cc: Florian Fainelli
Cc: Vladimir Oltean
Cc: Vivien Didelot
---
drivers/net/dsa/mv88e6xxx/chip.c | 5 +++--
1 file changed, 3 insertions(+)
Call dsa_port_enable for CPU/DSA ports in dsa_port_setup, and
dsa_port_disable for CPU/DSA ports in dsa_port_teardown. This requires
changing all DSA drivers, since they expect the port_enable/port_disable
methods to be called only for user ports.
Signed-off-by: Marek Behún
Cc: Andrew Lunn
Cc: F
Hi,
here is another proposal for supporting setting 2500base-x mode for
CPU/DSA ports in device tree correctly.
The changes from v1 are that instead of adding .port_setup() and
.port_teardown() methods to the DSA operations struct we instead, for
CPU/DSA ports, call dsa_port_enable() from dsa_por
On Sat, Aug 17, 2019 at 11:54 PM Cong Wang wrote:
>
> On Sat, Aug 17, 2019 at 5:46 AM Akshat Kakkar wrote:
> >
> > I agree that it is because of 16bit of minor I'd of class which
> > restricts it to 64K.
> > Point is, can we use multilevel qdisc and classes to extend it to more
> > no. of classes
On Sat, Aug 17, 2019 at 5:46 AM Akshat Kakkar wrote:
>
> I agree that it is because of 16bit of minor I'd of class which
> restricts it to 64K.
> Point is, can we use multilevel qdisc and classes to extend it to more
> no. of classes i.e. to more than 64K classes
If your goal is merely having as
On Sat, 17 Aug 2019 20:03:42 +0200
Marek Behun wrote:
> One way would be to rename the mv88e6xxx_setup_port function to
> mv88e6xxx_setup_port_regs, or mv88e6xxx_port_pre_setup, or something
> like that. Would the names mv88e6xxx_port_setup and
> mv88e6xxx_setup_port_regs still be very confusing
Hi Vivien,
On Fri, 16 Aug 2019 19:05:37 -0400
Vivien Didelot wrote:
> I think the DSA switch port_setup/port_teardown operations are fine, but the
> idea would be that the drivers must no longer setup their ports directly
> in their .setup function. So for mv88e6xxx precisely, we should rename
>
On Sat, Aug 17, 2019 at 12:26 AM Eric Dumazet wrote:
>
> As Jason Baron explained in commit 790ba4566c1a ("tcp: set SOCK_NOSPACE
> under memory pressure"), it is crucial we properly set SOCK_NOSPACE
> when needed.
>
> However, Jason patch had a bug, because the 'nonblocking' status
> as far as sk_
On 8/17/19 4:19 PM, Jason Baron wrote:
>
>
> On 8/17/19 12:26 AM, Eric Dumazet wrote:
>> As Jason Baron explained in commit 790ba4566c1a ("tcp: set SOCK_NOSPACE
>> under memory pressure"), it is crucial we properly set SOCK_NOSPACE
>> when needed.
>>
>> However, Jason patch had a bug, because
> On Aug 17, 2019, at 8:02 AM, Alexei Starovoitov
> wrote:
>
> Can any of the mechanisms 1/2/3 address the concern in mds.rst?
>
seccomp() can. It’s straightforward to use seccomp to disable bpf() outright
for a process tree. In this regard, bpf() isn’t particularly unique — it’s a
syst
On August 17, 2019 5:36:54 PM GMT+02:00, Alexei Starovoitov
wrote:
>On Sat, Aug 17, 2019 at 05:16:53PM +0200, Christian Brauner wrote:
>> On August 17, 2019 5:08:45 PM GMT+02:00, Alexei Starovoitov
> wrote:
>> >On Sat, Aug 17, 2019 at 12:22:53AM +0200, Christian Brauner wrote:
>> >>
>> >> (The o
On Sat, Aug 17, 2019 at 05:16:53PM +0200, Christian Brauner wrote:
> On August 17, 2019 5:08:45 PM GMT+02:00, Alexei Starovoitov
> wrote:
> >On Sat, Aug 17, 2019 at 12:22:53AM +0200, Christian Brauner wrote:
> >>
> >> (The one usecase I'd care about is to extend seccomp to do
> >pointer-based
>
On August 17, 2019 5:08:45 PM GMT+02:00, Alexei Starovoitov
wrote:
>On Sat, Aug 17, 2019 at 12:22:53AM +0200, Christian Brauner wrote:
>>
>> (The one usecase I'd care about is to extend seccomp to do
>pointer-based
>> syscall filtering. Whether or not that'd require (unprivileged) ebpf
>is
>> up
On Sat, Aug 17, 2019 at 12:22:53AM +0200, Christian Brauner wrote:
>
> (The one usecase I'd care about is to extend seccomp to do pointer-based
> syscall filtering. Whether or not that'd require (unprivileged) ebpf is
> up for discussion at KSummit.)
Kees have been always against using ebpf in se
On Fri, Aug 16, 2019 at 10:28:29PM +0200, Thomas Gleixner wrote:
> Alexei,
>
> On Fri, 16 Aug 2019, Alexei Starovoitov wrote:
> > It's both of the above when 'systemd' is not taken literally.
> > To earlier Thomas's point: the use case is not only about systemd.
> > There are other containers mana
On 8/17/19 12:26 AM, Eric Dumazet wrote:
> As Jason Baron explained in commit 790ba4566c1a ("tcp: set SOCK_NOSPACE
> under memory pressure"), it is crucial we properly set SOCK_NOSPACE
> when needed.
>
> However, Jason patch had a bug, because the 'nonblocking' status
> as far as sk_stream_wait
On 19/08/17 (土) 0:35:50, Stanislav Fomichev wrote:
On 08/16, Toshiaki Makita wrote:
On 2019/08/16 0:21, Stanislav Fomichev wrote:
On 08/15, Toshiaki Makita wrote:
On 2019/08/15 2:07, Stanislav Fomichev wrote:
On 08/13, Toshiaki Makita wrote:
* Implementation
xdp_flow makes use of UMH to loa
On 19/08/17 (土) 3:52:24, Jakub Kicinski wrote:
On Fri, 16 Aug 2019 10:28:10 +0900, Toshiaki Makita wrote:
On 2019/08/16 4:22, Jakub Kicinski wrote:
There's a certain allure in bringing the in-kernel BPF translation
infrastructure forward. OTOH from system architecture perspective IMHO
it does s
From: Ido Schimmel
Add test cases for devlink-trap on top of the netdevsim implementation.
The tests focus on the devlink-trap core infrastructure and user space
API. They test both good and bad flows and also dismantle of the netdev
and devlink device used to report trapped packets.
This allow
From: Ido Schimmel
Signed-off-by: Ido Schimmel
Acked-by: Jiri Pirko
---
Documentation/networking/devlink-trap.rst | 10 ++
1 file changed, 10 insertions(+)
diff --git a/Documentation/networking/devlink-trap.rst
b/Documentation/networking/devlink-trap.rst
index fe4f6e149623..c20c7c483
From: Ido Schimmel
Users have several ways to debug the kernel and understand why a packet
was dropped. For example, using drop monitor and perf. Both utilities
trace kfree_skb(), which is the function called when a packet is freed
as part of a failure. The information provided by these tools is
From: Ido Schimmel
Add helpers to interact with devlink-trap, such as setting the action of
a trap and retrieving statistics.
Signed-off-by: Ido Schimmel
---
.../selftests/net/forwarding/devlink_lib.sh | 163 ++
1 file changed, 163 insertions(+)
diff --git a/tools/testing/se
From: Ido Schimmel
Signed-off-by: Ido Schimmel
Acked-by: Jiri Pirko
---
.../networking/devlink-trap-netdevsim.rst | 20 +++
Documentation/networking/devlink-trap.rst | 11 ++
Documentation/networking/index.rst| 1 +
drivers/net/netdevsim/dev.c
From: Ido Schimmel
In a similar fashion to software drops, extend drop monitor to send
netlink events when packets are dropped by the underlying hardware.
The main difference is that instead of encoding the program counter (PC)
from which kfree_skb() was called in the netlink message, we encode
From: Ido Schimmel
For tests that create their network interfaces dynamically or do not use
interfaces at all (as with netdevsim) it is useful to define their own
devlink device instead of deriving it from the first network interface.
Signed-off-by: Ido Schimmel
---
.../selftests/net/forwardin
From: Ido Schimmel
Currently drop monitor only reports software drops to user space, but
subsequent patches are going to add support for hardware drops.
Like software drops, the per-CPU data of hardware drops needs to be
initialized and de-initialized upon module initialization and exit. To
avoi
From: Ido Schimmel
The drop monitor configuration (e.g., alert mode) is global, but user
will be able to enable monitoring of only software or hardware drops.
Therefore, ensure that monitoring of both software and hardware drops are
disabled before allowing drop monitor configuration to take pla
From: Ido Schimmel
Like software drops, hardware drops also need the same type of per-CPU
data. Therefore, initialize it during module initialization and
de-initialize it during module exit.
Signed-off-by: Ido Schimmel
Acked-by: Jiri Pirko
---
net/core/drop_monitor.c | 25
From: Ido Schimmel
Export a function that can be invoked in order to report packets that
were dropped by the underlying hardware along with metadata.
Subsequent patches will add support for the different alert modes.
Signed-off-by: Ido Schimmel
Acked-by: Jiri Pirko
---
MAINTAINERS
From: Ido Schimmel
Drop monitor has start and stop commands, but so far these were only
used to start and stop monitoring of software drops.
Now that drop monitor can also monitor hardware drops, we should allow
the user to control these as well.
Do that by adding SW and HW flags to these comma
From: Ido Schimmel
Have netdevsim register its trap groups and traps with devlink during
initialization and periodically report trapped packets to devlink core.
Since netdevsim is not a real device, the trapped packets are emulated
using a workqueue that periodically reports a UDP packet with a
From: Ido Schimmel
In summary alert mode a notification is sent with a list of recent drop
reasons and a count of how many packets were dropped due to this reason.
To avoid expensive operations in the context in which packets are
dropped, each CPU holds an array whose number of entries is the ma
From: Ido Schimmel
Add the basic packet trap infrastructure that allows device drivers to
register their supported packet traps and trap groups with devlink.
Each driver is expected to provide basic information about each
supported trap, such as name and ID, but also the supported metadata
types
From: Ido Schimmel
Add initial documentation of the devlink-trap mechanism, explaining the
background, motivation and the semantics of the interface.
Signed-off-by: Ido Schimmel
Acked-by: Jiri Pirko
---
Documentation/networking/devlink-trap.rst | 187 ++
Documentation/netw
From: Ido Schimmel
Add generic packet traps and groups that can report dropped packets as
well as exceptions such as TTL error.
Signed-off-by: Ido Schimmel
Acked-by: Jiri Pirko
---
include/net/devlink.h | 40
net/core/devlink.c| 12
2
I agree that it is because of 16bit of minor I'd of class which
restricts it to 64K.
Point is, can we use multilevel qdisc and classes to extend it to more
no. of classes i.e. to more than 64K classes
One scheme can be like
100: root qdisc
On Sat, Aug 17, 2019 at 12:26 AM Eric Dumazet wrote:
>
> As Jason Baron explained in commit 790ba4566c1a ("tcp: set SOCK_NOSPACE
> under memory pressure"), it is crucial we properly set SOCK_NOSPACE
> when needed.
>
> However, Jason patch had a bug, because the 'nonblocking' status
> as far as sk_
Hi Dave,
Here's a set of Bluetooth fixes for the 5.3-rc series:
- Multiple fixes for Qualcomm (btqca & hci_qca) drivers
- Minimum encryption key size debugfs setting (this is required for
Bluetooth Qualification)
- Fix hidp_send_message() to have a meaningful return value
Please let me kno
On Fri, 16 Aug 2019 at 15:59, Mark Brown wrote:
>
> On Fri, Aug 16, 2019 at 03:37:46PM +0300, Vladimir Oltean wrote:
> > On Fri, 16 Aug 2019 at 15:21, Mark Brown wrote:
>
> > > This is difficult to review since there's a bunch of largely unrelated
> > > changes all munged into one patch. It'd be
Supported PHY features are either auto-detected or explicitly set.
In both cases calling genphy_config_init isn't needed. All that
genphy_config_init does is removing features that are set as
supported but can't be auto-detected. Basically it duplicates the
code in genphy_read_abilities. Therefore
Supported PHY features are either auto-detected or explicitly set.
In both cases calling genphy_config_init isn't needed.
Signed-off-by: Heiner Kallweit
---
net/dsa/port.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/net/dsa/port.c b/net/dsa/port.c
index f071acf28..f75301456 100644
--
Now that all users have been removed we can remove genphy_config_init.
Signed-off-by: Heiner Kallweit
---
drivers/net/phy/phy_device.c | 51
include/linux/phy.h | 1 -
2 files changed, 52 deletions(-)
diff --git a/drivers/net/phy/phy_device.c b/dri
On 16.08.2019 23:58, Florian Fainelli wrote:
> On 8/16/19 1:31 PM, Heiner Kallweit wrote:
>> Supported PHY features are either auto-detected or explicitly set.
>> In both cases calling genphy_config_init isn't needed. All that
>> genphy_config_init does is removing features that are set as
>> suppo
Supported PHY features are either auto-detected or explicitly set.
In both cases calling genphy_config_init isn't needed. All that
genphy_config_init does is removing features that are set as
supported but can't be auto-detected. Basically it duplicates the
code in genphy_read_abilities. Therefore
Hi Michael,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net/master]
url:
https://github.com/0day-ci/linux/commits/Michael-Chan/bnxt_en-Bug-fixes/20190817-155755
config: sparc64-allmodconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 7.4.0
67 matches
Mail list logo
