On 16.08.2019 23:58, Florian Fainelli wrote:
> On 8/16/19 1:31 PM, Heiner Kallweit wrote:
>> Supported PHY features are either auto-detected or explicitly set.
>> In both cases calling genphy_config_init isn't needed. All that
>> genphy_config_init does is removing features that are set as
>> supported but can't be auto-detected. Basically it duplicates the
>> code in genphy_read_abilities. Therefore remove such calls from
>> all PHY drivers.
>>
>> v2:
>> - remove call also from new adin PHY driver
>>
>> Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>
>
> Looks good, just one question below:
>
>> +static int dummy_config_init(struct phy_device *phydev)
>> +{
>> + return 0;
>> +}
>> +
>> static struct mdio_device_id __maybe_unused dp83848_tbl[] = {
>> { TI_DP83848C_PHY_ID, 0xfffffff0 },
>> { NS_DP83848C_PHY_ID, 0xfffffff0 },
>> @@ -113,13 +113,13 @@ MODULE_DEVICE_TABLE(mdio, dp83848_tbl);
>>
>> static struct phy_driver dp83848_driver[] = {
>> DP83848_PHY_DRIVER(TI_DP83848C_PHY_ID, "TI DP83848C 10/100 Mbps PHY",
>> - genphy_config_init),
>> + dummy_config_init),
>> DP83848_PHY_DRIVER(NS_DP83848C_PHY_ID, "NS DP83848C 10/100 Mbps PHY",
>> - genphy_config_init),
>> + dummy_config_init),
>> DP83848_PHY_DRIVER(TI_DP83620_PHY_ID, "TI DP83620 10/100 Mbps PHY",
>> dp83848_config_init),
>> DP83848_PHY_DRIVER(TLK10X_PHY_ID, "TI TLK10X 10/100 Mbps PHY",
>> - genphy_config_init),
>> + dummy_config_init),
>
> drv->config_init is an optional callback so you could just either pass
> NULL as an argument to the macro, or simply remove that parameter?
>
Yes, this can be simplified. Let's pass NULL. Thanks!
