Re: [PATCH v3 net-next 19/19] ionic: Add basic devlink interface

2019-07-08 Thread Jiri Pirko
Tue, Jul 09, 2019 at 12:58:00AM CEST, snel...@pensando.io wrote: >On 7/8/19 1:03 PM, Jiri Pirko wrote: >> Mon, Jul 08, 2019 at 09:58:09PM CEST, snel...@pensando.io wrote: >> > On 7/8/19 12:34 PM, Jiri Pirko wrote: >> > > Mon, Jul 08, 2019 at 09:25:32PM CEST, snel...@pensando.io wrote: >> > > > >>

Re: [PATCH net-next 11/16] qlge: Remove qlge_bq.len & size

2019-07-08 Thread Benjamin Poirier
On 2019/06/27 10:47, Manish Chopra wrote: > > > > - for (i = 0; i < qdev->rx_ring_count; i++) { > > + for (i = 0; i < qdev->rss_ring_count; i++) { > > struct rx_ring *rx_ring = &qdev->rx_ring[i]; > > > > - if (rx_ring->lbq.queue) > > - ql_free_lbq_buffe

Re: [PATCH net-next v2 0/4] bnxt_en: Add XDP_REDIRECT support.

2019-07-08 Thread Ilias Apalodimas
Hi David, On Mon, Jul 08, 2019 at 03:20:20PM -0700, David Miller wrote: > From: Michael Chan > Date: Mon, 8 Jul 2019 17:53:00 -0400 > > > This patch series adds XDP_REDIRECT support by Andy Gospodarek. > > Series applied, thanks everyone. We need a fix on this after merging Ivans patch commi

Re: [PATCH net-next v2 4/4] bnxt_en: add page_pool support

2019-07-08 Thread Ilias Apalodimas
Hi Andy, Michael, On Mon, Jul 08, 2019 at 05:53:04PM -0400, Michael Chan wrote: > From: Andy Gospodarek > > This removes contention over page allocation for XDP_REDIRECT actions by > adding page_pool support per queue for the driver. The performance for > XDP_REDIRECT actions scales linearly wi

RE: [PATCH net-next v6 0/5] devlink: Introduce PCI PF, VF ports and attributes

2019-07-08 Thread Parav Pandit
Hi Jakub, > -Original Message- > From: Jakub Kicinski > Sent: Tuesday, July 9, 2019 11:10 AM > To: Parav Pandit > Cc: netdev@vger.kernel.org; Jiri Pirko ; Saeed Mahameed > > Subject: Re: [PATCH net-next v6 0/5] devlink: Introduce PCI PF, VF ports and > attributes > > On Mon, 8 Jul 201

Re: [PATCH net-next,v3 11/11] netfilter: nf_tables: add hardware offload support

2019-07-08 Thread Jiri Pirko
Tue, Jul 09, 2019 at 03:44:37AM CEST, jakub.kicin...@netronome.com wrote: >On Mon, 8 Jul 2019 18:06:13 +0200, Pablo Neira Ayuso wrote: >> This patch adds hardware offload support for nftables through the >> existing netdev_ops->ndo_setup_tc() interface, the TC_SETUP_CLSFLOWER >> classifier and the

Re: [PATCH net-next v6 0/5] devlink: Introduce PCI PF, VF ports and attributes

2019-07-08 Thread Jiri Pirko
Tue, Jul 09, 2019 at 07:40:12AM CEST, jakub.kicin...@netronome.com wrote: >On Mon, 8 Jul 2019 23:17:34 -0500, Parav Pandit wrote: >> This patchset carry forwards the work initiated in [1] and discussion >> futher concluded at [2]. >> >> To improve visibility of representor netdevice, its associat

Re: [bpf PATCH v2 0/6] bpf: sockmap/tls fixes

2019-07-08 Thread Jakub Kicinski
On Mon, 08 Jul 2019 19:13:29 +, John Fastabend wrote: > Resolve a series of splats discovered by syzbot and an unhash > TLS issue noted by Eric Dumazet. > > The main issues revolved around interaction between TLS and > sockmap tear down. TLS and sockmap could both reset sk->prot > ops creating

Re: [PATCH net-next v6 0/5] devlink: Introduce PCI PF, VF ports and attributes

2019-07-08 Thread Jakub Kicinski
On Mon, 8 Jul 2019 23:17:34 -0500, Parav Pandit wrote: > This patchset carry forwards the work initiated in [1] and discussion > futher concluded at [2]. > > To improve visibility of representor netdevice, its association with > PF or VF, physical port, two new devlink port flavours are added as

Re: [PATCH v3 net-next 13/19] ionic: Add initial ethtool support

2019-07-08 Thread Michal Kubecek
On Mon, Jul 08, 2019 at 12:25:26PM -0700, Shannon Nelson wrote: > Add in the basic ethtool callbacks for device information > and control. > > Signed-off-by: Shannon Nelson > --- > drivers/net/ethernet/pensando/ionic/Makefile | 2 +- > .../net/ethernet/pensando/ionic/ionic_dev.h | 3 + >

Re: [PATCH v3 net-next 13/19] ionic: Add initial ethtool support

2019-07-08 Thread Michal Kubecek
On Tue, Jul 09, 2019 at 12:04:06AM +0200, Andrew Lunn wrote: > > +static int ionic_get_link_ksettings(struct net_device *netdev, > > + struct ethtool_link_ksettings *ks) > > +{ > > + struct lif *lif = netdev_priv(netdev); > > + struct ionic_dev *idev = &lif->ionic-

Re: [PATCH V5 net-next 4/6] dt-bindings: ptp: Introduce MII time stamping devices.

2019-07-08 Thread Richard Cochran
On Mon, Jul 08, 2019 at 03:38:37PM -0600, Rob Herring wrote: > > +Required properties of the control node: > > + > > +- compatible: "ines,ptp-ctrl" > > This is an IP block that gets integrated into SoCs? It is an IP block implemented in an FPGA (like the zync or the socfpga). > It's

Re: [PATCH bpf-next] libbpf: fix ptr to u64 conversion warning on 32-bit platforms

2019-07-08 Thread Yonghong Song
On 7/8/19 9:00 PM, Andrii Nakryiko wrote: > On 32-bit platforms compiler complains about conversion: > > libbpf.c: In function ‘perf_event_open_probe’: > libbpf.c:4112:17: error: cast from pointer to integer of different > size [-Werror=pointer-to-int-cast] >attr.config1 = (uint64_t)(void *)

[PATCH net-next v6 3/5] devlink: Introduce PCI PF port flavour and port attribute

2019-07-08 Thread Parav Pandit
In an eswitch, PCI PF may have port which is normally represented using a representor netdevice. To have better visibility of eswitch port, its association with PF and a representor netdevice, introduce a PCI PF port flavour and port attriute. When devlink port flavour is PCI PF, fill up PCI PF at

[PATCH net-next v6 0/5] devlink: Introduce PCI PF, VF ports and attributes

2019-07-08 Thread Parav Pandit
This patchset carry forwards the work initiated in [1] and discussion futher concluded at [2]. To improve visibility of representor netdevice, its association with PF or VF, physical port, two new devlink port flavours are added as PCI PF and PCI VF ports. A sample eswitch view can be seen below,

[PATCH net-next v6 5/5] net/mlx5e: Register devlink ports for physical link, PCI PF, VFs

2019-07-08 Thread Parav Pandit
Register devlink port of physical port, PCI PF and PCI VF flavour for each PF, VF when a given devlink instance is in switchdev mode. Implement ndo_get_devlink_port callback API to make use of registered devlink ports. This eliminates ndo_get_phys_port_name() and ndo_get_port_parent_id() callbacks

[PATCH net-next v6 4/5] devlink: Introduce PCI VF port flavour and port attribute

2019-07-08 Thread Parav Pandit
In an eswitch, PCI VF may have port which is normally represented using a representor netdevice. To have better visibility of eswitch port, its association with VF, and its representor netdevice, introduce a PCI VF port flavour. When devlink port flavour is PCI VF, fill up PCI VF attributes of the

[PATCH net-next v6 1/5] devlink: Refactor physical port attributes

2019-07-08 Thread Parav Pandit
To support additional devlink port flavours and to support few common and few different port attributes, move physical port attributes to a different structure. Acked-by: Jiri Pirko Signed-off-by: Parav Pandit --- Changelog: v5->v6: - Addressed comment from Jiri. - Changed 'physical' to 'phys'

[PATCH net-next v6 2/5] devlink: Return physical port fields only for applicable port flavours

2019-07-08 Thread Parav Pandit
Physical port number and split group fields are applicable only to physical port flavours such as PHYSICAL, CPU and DSA. Hence limit returning those values in netlink response to such port flavours. Acked-by: Jiri Pirko Signed-off-by: Parav Pandit --- net/core/devlink.c | 4 1 file changed

[PATCH bpf-next] libbpf: fix ptr to u64 conversion warning on 32-bit platforms

2019-07-08 Thread Andrii Nakryiko
On 32-bit platforms compiler complains about conversion: libbpf.c: In function ‘perf_event_open_probe’: libbpf.c:4112:17: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] attr.config1 = (uint64_t)(void *)name; /* kprobe_func or uprobe_path */ ^

Re: [PATCH net-next 00/11] nfp: tls: fixes for initial TLS support

2019-07-08 Thread David Miller
From: Jakub Kicinski Date: Mon, 8 Jul 2019 19:53:07 -0700 > This series brings various fixes to nfp tls offload recently added > to net-next. Series applied, thanks.

[PATCH v2 05/10] net: hisilicon: HI13X1_GMAX need dreq reset at first

2019-07-08 Thread Jiangfeng Xiao
HI13X1_GMAC delete request for soft reset at first, otherwise, the subsequent initialization will not take effect. Signed-off-by: Jiangfeng Xiao --- drivers/net/ethernet/hisilicon/hip04_eth.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/net/ethernet/hisil

[PATCH v2 00/10] net: hisilicon: Add support for HI13X1 to hip04_eth

2019-07-08 Thread Jiangfeng Xiao
The main purpose of this patch series is to extend the hip04_eth driver to support HI13X1_GMAC. The offset and bitmap of some registers of HI13X1_GMAC are different from hip04_eth common soc. In addition, the definition of send descriptor and parsing descriptor are different from hip04_eth common

[PATCH v2 08/10] net: hisilicon: Offset buf address to adapt HI13X1_GMAC

2019-07-08 Thread Jiangfeng Xiao
The buf unit size of HI13X1_GMAC is cache_line_size, which is 64, so the address we write to the buf register needs to be shifted right by 6 bits. The 31st bit of the PPE_CFG_CPU_ADD_ADDR register of HI13X1_GMAC indicates whether to release the buffer of the message, and the low indicates that it

[PATCH net-next] net: dsa: add support for BRIDGE_MROUTER attribute

2019-07-08 Thread Vivien Didelot
This patch adds support for enabling or disabling the flooding of unknown multicast traffic on the CPU ports, depending on the value of the switchdev SWITCHDEV_ATTR_ID_BRIDGE_MROUTER attribute. The current behavior is kept unchanged but a user can now prevent the CPU conduit to be flooded with a l

[PATCH v2 09/10] net: hisilicon: Add an rx_desc to adapt HI13X1_GMAC

2019-07-08 Thread Jiangfeng Xiao
HI13X1 changed the offsets and bitmaps for rx_desc registers in the same peripheral device on different models of the hip04_eth. Signed-off-by: Jiangfeng Xiao --- drivers/net/ethernet/hisilicon/hip04_eth.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/ethernet/hisilico

Re: [PATCH] phy: added a PHY_BUSY state into phy_state_machine

2019-07-08 Thread kwangdo yi
On Mon, Jul 8, 2019 at 11:22 PM Andrew Lunn wrote: > > On Mon, Jul 08, 2019 at 11:16:02PM -0400, kwangdo yi wrote: > > I simply fixed this issue by increasing the polling time from 20 msec to > > 60 msec in Xilinx EMAC driver. But the state machine would be in a > > better shape if it is capable o

[PATCH bpf-next] bpf: fix precision bit propagation for BPF_ST instructions

2019-07-08 Thread Andrii Nakryiko
When backtracking instructions to propagate precision bit for registers and stack slots, one class of instructions (BPF_ST) weren't handled causing extra stack slots to be propagated into parent state. Parent state might not have that much stack allocated, though, which causes warning on invalid st

[PATCH v2 04/10] net: hisilicon: HI13X1_GMAX skip write LOCAL_PAGE_REG

2019-07-08 Thread Jiangfeng Xiao
HI13X1_GMAC changed the offsets and bitmaps for GE_TX_LOCAL_PAGE_REG registers in the same peripheral device on different models of the hip04_eth. With the default configuration, HI13X1_GMAC can also work without any writes to the GE_TX_LOCAL_PAGE_REG register. Signed-off-by: Jiangfeng Xiao ---

[PATCH v2 06/10] net: hisilicon: dt-bindings: Add an field of port-handle

2019-07-08 Thread Jiangfeng Xiao
In general, group is the same as the port, but some boards specify a special group for better load balancing of each processing unit. Signed-off-by: Jiangfeng Xiao --- Documentation/devicetree/bindings/net/hisilicon-hip04-net.txt | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff

Re: [PATCH] phy: added a PHY_BUSY state into phy_state_machine

2019-07-08 Thread Andrew Lunn
On Mon, Jul 08, 2019 at 11:16:02PM -0400, kwangdo yi wrote: > I simply fixed this issue by increasing the polling time from 20 msec to > 60 msec in Xilinx EMAC driver. But the state machine would be in a > better shape if it is capable of handling sub system driver's fake failure. > PHY device driv

Re: [PATCH net-next] sctp: remove rcu_read_lock from sctp_bind_addr_state

2019-07-08 Thread David Miller
From: Xin Long Date: Tue, 9 Jul 2019 00:59:40 +0800 > sctp_bind_addr_state() is called either in packet rcv path or > by sctp_copy_local_addr_list(), which are under rcu_read_lock. > So there's no need to call it again in sctp_bind_addr_state(). > > Signed-off-by: Xin Long This is correct, pa

Re: [PATCH net-next 0/4] sctp: tidy up some ep and asoc feature flags

2019-07-08 Thread David Miller
From: Xin Long Date: Tue, 9 Jul 2019 00:57:03 +0800 > This patchset is to remove some unnecessary feature flags from > sctp_assocation and move some others to the right places. Since I'm trying to close up the net-next tree first thing tomorrow morning I've taken the liberty of reviewing this t

Re: [PATCH] phy: added a PHY_BUSY state into phy_state_machine

2019-07-08 Thread kwangdo yi
I simply fixed this issue by increasing the polling time from 20 msec to 60 msec in Xilinx EMAC driver. But the state machine would be in a better shape if it is capable of handling sub system driver's fake failure. PHY device driver could advertising the min/max timeouts for its subsystem, but sti

Re: [PATCH bpf-next v3] virtio_net: add XDP meta data support

2019-07-08 Thread Jason Wang
On 2019/7/9 上午6:38, Daniel Borkmann wrote: On 07/02/2019 04:11 PM, Yuya Kusakabe wrote: On 7/2/19 5:33 PM, Jason Wang wrote: On 2019/7/2 下午4:16, Yuya Kusakabe wrote: This adds XDP meta data support to both receive_small() and receive_mergeable(). Fixes: de8f3a83b0a0 ("bpf: add meta pointer

Re: [PATCH net-next v7 0/5] Add MPLS actions to TC

2019-07-08 Thread David Miller
From: John Hurley Date: Sun, 7 Jul 2019 15:01:53 +0100 > This patchset introduces a new TC action module that allows the > manipulation of the MPLS headers of packets. The code impliments > functionality including push, pop, and modify. > > Also included are tests for the new funtionality. Note

[PATCH net-next] net: dsa: vsc73xx: Fix Kconfig warning and build errors

2019-07-08 Thread YueHaibing
Fix Kconfig dependency warning and subsequent build errors caused by OF is not set: WARNING: unmet direct dependencies detected for NET_DSA_VITESSE_VSC73XX Depends on [n]: NETDEVICES [=y] && HAVE_NET_DSA [=y] && OF [=n] && NET_DSA [=m] Selected by [m]: - NET_DSA_VITESSE_VSC73XX_PLATFORM [=m

Re: [PATCH v3 net-next 00/19] Add ionic driver

2019-07-08 Thread Shannon Nelson
On 7/8/19 7:58 PM, David Miller wrote: From: Shannon Nelson Date: Mon, 8 Jul 2019 12:25:13 -0700 This is a patch series that adds the ionic driver, supporting the Pensando ethernet device. ... I think with the review comments and feedback still coming in you will have to wait until the next

Re: [PATCH v3 net-next 00/19] Add ionic driver

2019-07-08 Thread David Miller
From: Shannon Nelson Date: Mon, 8 Jul 2019 12:25:13 -0700 > This is a patch series that adds the ionic driver, supporting the Pensando > ethernet device. ... I think with the review comments and feedback still coming in you will have to wait until the next merge window, sorry.

Re: [PATCH nf-next 1/3] netfilter: nf_nat_proto: add nf_nat_bridge_ops support

2019-07-08 Thread wenxu
On 7/8/2019 10:17 PM, Florian Westphal wrote: > we...@ucloud.cn wrote: >> From: wenxu >> >> Add nf_nat_bridge_ops to do nat in the bridge family > Whats the use case for this? > > The reason I'm asking is that a bridge doesn't know about IP, > Bridge netfilter (the call-iptables thing) has a lo

[PATCH net-next 04/11] nfp: ccm: increase message limits

2019-07-08 Thread Jakub Kicinski
From: Dirk van der Merwe Increase the batch limit to consume small message bursts more effectively. Practically, the effect on the 'add' messages is not significant since the mailbox is sized such that the 'add' messages are still limited to the same order of magnitude that it was originally set

[PATCH net-next 03/11] nfp: tls: use unique connection ids instead of 4-tuple for TX

2019-07-08 Thread Jakub Kicinski
Connection 4 tuple reuse is slightly problematic - TLS socket and context do not get destroyed until all the associated skbs left the system and all references are released. This leads to stale connection entry in the device preventing addition of new one if the 4 tuple is reused quickly enough. I

[PATCH net-next 07/11] nfp: tls: don't leave key material in freed FW cmsg skbs

2019-07-08 Thread Jakub Kicinski
Make sure the contents of the skb which carried key material to the FW is cleared. Signed-off-by: Jakub Kicinski Reviewed-by: Dirk van der Merwe --- drivers/net/ethernet/netronome/nfp/crypto/tls.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/net/e

[PATCH net-next 06/11] net/tls: don't clear TX resync flag on error

2019-07-08 Thread Jakub Kicinski
From: Dirk van der Merwe Introduce a return code for the tls_dev_resync callback. When the driver TX resync fails, kernel can retry the resync again until it succeeds. This prevents drivers from attempting to offload TLS packets if the connection is known to be out of sync. We don't worry abou

[PATCH net-next 10/11] nfp: tls: undo TLS sequence tracking when dropping the frame

2019-07-08 Thread Jakub Kicinski
If driver has to drop the TLS frame it needs to undo the TCP sequence tracking changes, otherwise device will receive segments out of order and drop them. Signed-off-by: Jakub Kicinski Reviewed-by: Dirk van der Merwe --- .../ethernet/netronome/nfp/nfp_net_common.c | 23 +++ 1

[PATCH net-next 00/11] nfp: tls: fixes for initial TLS support

2019-07-08 Thread Jakub Kicinski
Hi! This series brings various fixes to nfp tls offload recently added to net-next. First 4 patches revolve around device mailbox communication, trying to make it more reliable. Next patch fixes statistical counter. Patch 6 improves the TX resync if device communication failed. Patch 7 makes sure

[PATCH net-next 01/11] nfp: tls: ignore queue limits for delete commands

2019-07-08 Thread Jakub Kicinski
We need to do our best not to drop delete commands, otherwise we will have stale entries in the connection table. Ignore the control message queue limits for delete commands. Signed-off-by: Jakub Kicinski Reviewed-by: Dirk van der Merwe --- drivers/net/ethernet/netronome/nfp/ccm.h | 4 ++

[PATCH net-next 08/11] net/tls: add missing prot info init

2019-07-08 Thread Jakub Kicinski
Turns out TLS_TX in HW offload mode does not initialize tls_prot_info. Since commit 9cd81988cce1 ("net/tls: use version from prot") we actually use this field on the datapath. Luckily we always compare it to TLS 1.3, and assume 1.2 otherwise. So since zero is not equal to 1.3, everything worked fi

[PATCH net-next 02/11] nfp: tls: move setting ipver_vlan to a helper

2019-07-08 Thread Jakub Kicinski
Long lines are ugly. No functional changes. Signed-off-by: Jakub Kicinski Reviewed-by: Dirk van der Merwe --- drivers/net/ethernet/netronome/nfp/crypto/tls.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/netronome/nfp/crypto/tls.c b

[PATCH net-next 11/11] net/tls: fix socket wmem accounting on fallback with netem

2019-07-08 Thread Jakub Kicinski
netem runs skb_orphan_partial() which "disconnects" the skb from normal TCP write memory accounting. We should not adjust sk->sk_wmem_alloc on the fallback path for such skbs. Fixes: e8f69799810c ("net/tls: Add generic NIC offload infrastructure") Signed-off-by: Jakub Kicinski Reviewed-by: Dirk

[PATCH net-next 09/11] nfp: tls: avoid one of the ifdefs for TLS

2019-07-08 Thread Jakub Kicinski
Move the #ifdef CONFIG_TLS_DEVICE a little so we can eliminate the other one. Signed-off-by: Jakub Kicinski Reviewed-by: Dirk van der Merwe --- drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/netr

[PATCH net-next 05/11] nfp: tls: count TSO segments separately for the TLS offload

2019-07-08 Thread Jakub Kicinski
Count the number of successfully submitted TLS segments, not skbs. This will make it easier to compare the TLS encryption count against other counters. Signed-off-by: Jakub Kicinski Reviewed-by: Dirk van der Merwe --- drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 5 - 1 file changed

Re: [PATCH 1/4] dt-bindings: allow up to four clocks for orion-mdio

2019-07-08 Thread Andrew Lunn
> > Optional properties: > > - interrupts: interrupt line number for the SMI error/done interrupt > > -- clocks: phandle for up to three required clocks for the MDIO instance > > +- clocks: phandle for up to four required clocks for the MDIO instance > > This needs to enumerate exactly what the

Re: [PATCH net-next v2] skbuff: increase verbosity when dumping skb data

2019-07-08 Thread David Miller
From: Willem de Bruijn Date: Sun, 7 Jul 2019 05:51:55 -0400 > From: Willem de Bruijn > > skb_warn_bad_offload and netdev_rx_csum_fault trigger on hard to debug > issues. Dump more state and the header. > > Optionally dump the entire packet and linear segment. This is required > to debug check

Re: [PATCH net-next] ipv6: elide flowlabel check if no exclusive leases exist

2019-07-08 Thread David Miller
From: Willem de Bruijn Date: Sun, 7 Jul 2019 05:34:45 -0400 > From: Willem de Bruijn > > Processes can request ipv6 flowlabels with cmsg IPV6_FLOWINFO. > If not set, by default an autogenerated flowlabel is selected. > > Explicit flowlabels require a control operation per label plus a > datap

RE: [PATCH net-next v5 3/5] devlink: Introduce PCI PF port flavour and port attribute

2019-07-08 Thread Parav Pandit
> -Original Message- > From: Jakub Kicinski > Sent: Tuesday, July 9, 2019 2:44 AM > To: Parav Pandit > Cc: netdev@vger.kernel.org; Jiri Pirko ; Saeed Mahameed > > Subject: Re: [PATCH net-next v5 3/5] devlink: Introduce PCI PF port flavour > and > port attribute > > On Sun, 7 Jul 20

Re: [PATCH v3 net-next 13/19] ionic: Add initial ethtool support

2019-07-08 Thread Andrew Lunn
> +static int ionic_nway_reset(struct net_device *netdev) > +{ > + struct lif *lif = netdev_priv(netdev); > + int err = 0; > + > + if (netif_running(netdev)) > + err = ionic_reset_queues(lif); What does ionic_reset_queues() do? It sounds nothing like restarting auto negotia

Re: [PATCH net] tcp: Reset bytes_acked and bytes_received when disconnecting

2019-07-08 Thread David Miller
From: Christoph Paasch Date: Sat, 06 Jul 2019 16:13:07 -0700 > If an app is playing tricks to reuse a socket via tcp_disconnect(), > bytes_acked/received needs to be reset to 0. Otherwise tcp_info will > report the sum of the current and the old connection.. > > Cc: Eric Dumazet > Fixes: 0df48c

Re: [net-next] bonding: fix value exported by Netlink for peer_notif_delay

2019-07-08 Thread David Miller
From: Vincent Bernat Date: Sat, 6 Jul 2019 23:01:08 +0200 > IFLA_BOND_PEER_NOTIF_DELAY was set to the value of downdelay instead > of peer_notif_delay. After this change, the correct value is exported. > > Fixes: 07a4ddec3ce9 ("bonding: add an option to specify a delay between peer > notificat

Re: [PATCH v3 net-next 13/19] ionic: Add initial ethtool support

2019-07-08 Thread Andrew Lunn
> +static int ionic_get_module_eeprom(struct net_device *netdev, > +struct ethtool_eeprom *ee, > +u8 *data) > +{ > + struct lif *lif = netdev_priv(netdev); > + struct ionic_dev *idev = &lif->ionic->idev; > + struct xcvr_sta

Re: [PATCH] sockfs: switch to ->free_inode()

2019-07-08 Thread David Miller
From: Al Viro Date: Fri, 5 Jul 2019 20:13:22 +0100 > we do have an RCU-delayed part there already (freeing the wq), > so it's not like the pipe situation; moreover, it might be > worth considering coallocating wq with the rest of struct sock_alloc. > ->sk_wq in struct sock would remain a pointer

Re: [PATCH] coallocate socket_wq with socket itself

2019-07-08 Thread David Miller
From: Al Viro Date: Fri, 5 Jul 2019 20:14:16 +0100 > socket->wq is assign-once, set when we are initializing both > struct socket it's in and struct socket_wq it points to. As the > matter of fact, the only reason for separate allocation was the > ability to RCU-delay freeing of socket_wq. RCU-

Re: pull-request: bpf-next 2019-07-09

2019-07-08 Thread David Miller
From: Daniel Borkmann Date: Tue, 9 Jul 2019 02:13:51 +0200 > The following pull-request contains BPF updates for your *net-next* tree. > > The main changes are: ... > Please consider pulling these changes from: > > git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git Pulled, than

Re: [PATCH v3 net-next 13/19] ionic: Add initial ethtool support

2019-07-08 Thread Andrew Lunn
> +static int ionic_set_pauseparam(struct net_device *netdev, > + struct ethtool_pauseparam *pause) > +{ > + struct lif *lif = netdev_priv(netdev); > + struct ionic *ionic = lif->ionic; > + struct ionic_dev *idev = &lif->ionic->idev; > + > + u32 requested

Re: [EXT] [PATCH net-next 07/16] qlge: Deduplicate rx buffer queue management

2019-07-08 Thread Benjamin Poirier
On 2019/06/27 10:02, Manish Chopra wrote: > > while (curr_idx != clean_idx) { > > - lbq_desc = &rx_ring->lbq[curr_idx]; > > + struct qlge_bq_desc *lbq_desc = &rx_ring- > > >lbq.queue[curr_idx]; > > > > if (lbq_desc->p.pg_chunk.offset == last_offset) > > -

RE: [EXT] Re: [PATCH net-next v2 4/4] qed*: Add devlink support for configuration attributes.

2019-07-08 Thread Sudarsana Reddy Kalluru
> -Original Message- > From: Jakub Kicinski > Sent: Tuesday, July 9, 2019 3:17 AM > To: Sudarsana Reddy Kalluru > Cc: da...@davemloft.net; netdev@vger.kernel.org; Michal Kalderon > ; Ariel Elior ; Jiri Pirko > > Subject: Re: [EXT] Re: [PATCH net-next v2 4/4] qed*: Add devlink support for

Re: [PATCH] phy: added a PHY_BUSY state into phy_state_machine

2019-07-08 Thread kbuild test robot
Hi "kwangdo.yi", Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.2] [cannot apply to next-20190708] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH net-next,v3 11/11] netfilter: nf_tables: add hardware offload support

2019-07-08 Thread Jakub Kicinski
On Mon, 8 Jul 2019 18:06:13 +0200, Pablo Neira Ayuso wrote: > This patch adds hardware offload support for nftables through the > existing netdev_ops->ndo_setup_tc() interface, the TC_SETUP_CLSFLOWER > classifier and the flow rule API. This hardware offload support is > available for the NFPROTO_N

Re: [PATCH net-next,v3 08/11] drivers: net: use flow block API

2019-07-08 Thread Jakub Kicinski
On Mon, 8 Jul 2019 18:06:10 +0200, Pablo Neira Ayuso wrote: > diff --git a/drivers/net/ethernet/netronome/nfp/bpf/main.c > b/drivers/net/ethernet/netronome/nfp/bpf/main.c > index 0c93c84a188a..7549547c4ef0 100644 > --- a/drivers/net/ethernet/netronome/nfp/bpf/main.c > +++ b/drivers/net/ethernet/n

[PATCH net-next 2/2] tc-testing: introduce scapyPlugin for basic traffic

2019-07-08 Thread Lucas Bates
The scapyPlugin allows for simple traffic generation in tdc to test various tc features. It was tested with scapy v2.4.2, but should work with any successive version. In order to use the plugin's functionality, scapy must be installed. This can be done with: pip3 install scapy or to install 2.

[PATCH net-next 1/2] tc-testing: Allow tdc plugins to see test case data

2019-07-08 Thread Lucas Bates
Instead of only passing the test case name and ID, pass the entire current test case down to the plugins. This change allows plugins to start accepting commands and directives from the test cases themselves, for greater flexibility in testing. Signed-off-by: Lucas Bates --- tools/testing/selftes

[PATCH net-next 0/2] tc-testing: Add plugin for simple traffic generation

2019-07-08 Thread Lucas Bates
This series supersedes the previous submission that included a patch for test case verification using JSON output. It adds a new tdc plugin, scapyPlugin, as a way to send traffic to test tc filters and actions. The first patch makes a change to the TdcPlugin module that will allow tdc plugins to

Re: [PATCH 1/4] dt-bindings: allow up to four clocks for orion-mdio

2019-07-08 Thread Rob Herring
On Sat, Jul 6, 2019 at 9:31 AM wrote: > > From: Josua Mayer > > Armada 8040 needs four clocks to be enabled for MDIO accesses to work. > Update the binding to allow the extra clock to be specified. > > Cc: sta...@vger.kernel.org > Fixes: 6d6a331f44a1 ("dt-bindings: allow up to three clocks for or

Re: [PATCH net-next,v3 01/11] net: flow_offload: add flow_block_cb_setup_simple()

2019-07-08 Thread Jakub Kicinski
On Mon, 8 Jul 2019 18:06:03 +0200, Pablo Neira Ayuso wrote: > Most drivers do the same thing to set up the flow block callbacks, this > patch adds a helper function to do this. > > This preparation patch reduces the number of changes to adapt the > existing drivers to use the flow block callback

Re: [PATCH v2 net-next 3/3] tc-testing: introduce scapyPlugin for basic traffic

2019-07-08 Thread Lucas Bates
Sorry Alex, I completely forgot about this email. On Thu, Jul 4, 2019 at 4:29 PM Alexander Aring wrote: > > Hi, > > On Wed, Jul 03, 2019 at 08:45:02PM -0400, Lucas Bates wrote: > > The scapyPlugin allows for simple traffic generation in tdc to > > test various tc features. It was tested with scapy

Re: [PATCH v3 net-next 19/19] ionic: Add basic devlink interface

2019-07-08 Thread Jakub Kicinski
On Mon, 8 Jul 2019 12:25:32 -0700, Shannon Nelson wrote: > Add a devlink interface for access to information that isn't > normally available through ethtool or the iplink interface. > > Example: > $ ./devlink -j -p dev info pci/:b6:00.0 > { > "info": { > "p

Re: [PATCH v2 net-next 1/3] tc-testing: Add JSON verification to tdc

2019-07-08 Thread Lucas Bates
On Mon, Jul 8, 2019 at 1:25 PM Alexander Aring wrote: > > Unless I'm off-base here? > > yes you need to know some python, complex code can be hidden by some > helper functionality I guess. > > I have no problem to let this patch in, it will not harm anything... I think I'm going to pull it for the

Re: [PATCH net v2] Validate required parameters in inet6_validate_link_af

2019-07-08 Thread Stefan Lippers-Hollmann
Hi On 2019-05-22, David Miller wrote: > From: Maxim Mikityanskiy > Date: Tue, 21 May 2019 06:40:04 + > > > inet6_set_link_af requires that at least one of IFLA_INET6_TOKEN or > > IFLA_INET6_ADDR_GET_MODE is passed. If none of them is passed, it > > returns -EINVAL, which may cause do_setlink(

pull-request: bpf-next 2019-07-09

2019-07-08 Thread Daniel Borkmann
Hi David, The following pull-request contains BPF updates for your *net-next* tree. The main changes are: 1) Lots of libbpf improvements: i) addition of new APIs to attach BPF programs to tracing entities such as {k,u}probes or tracepoints, ii) improve specification of BTF-defined maps by

Re: [PATCH bpf-next] selftests/bpf: fix test_reuseport_array on s390

2019-07-08 Thread Daniel Borkmann
On 07/03/2019 01:50 PM, Ilya Leoshkevich wrote: > Fix endianness issue: passing a pointer to 64-bit fd as a 32-bit key > does not work on big-endian architectures. So cast fd to 32-bits when > necessary. > > Signed-off-by: Ilya Leoshkevich Applied, thanks!

Re: [PATCH bpf-next v3 1/6] xsk: replace ndo_xsk_async_xmit with ndo_xsk_wakeup

2019-07-08 Thread Daniel Borkmann
On 07/04/2019 02:42 PM, Magnus Karlsson wrote: > This commit replaces ndo_xsk_async_xmit with ndo_xsk_wakeup. This new > ndo provides the same functionality as before but with the addition of > a new flags field that is used to specifiy if Rx, Tx or both should be > woken up. The previous ndo only

Re: [PATCH net-next v2 0/3] net: Multipath hashing on inner L3

2019-07-08 Thread David Miller
From: Stephen Suryaputra Date: Sat, 6 Jul 2019 10:55:16 -0400 > This series extends commit 363887a2cdfe ("ipv4: Support multipath > hashing on inner IP pkts for GRE tunnel") to include support when the > outer L3 is IPv6 and to consider the case where the inner L3 is > different version from the

Re: [RFC PATCH net-next 0/6] tc-taprio offload for SJA1105 DSA

2019-07-08 Thread Vinicius Costa Gomes
Hi Vladimir, Vladimir Oltean writes: > Using Vinicius Costa Gomes' configuration interface for 802.1Qbv (later > resent by Voon Weifeng for the stmmac driver), I am submitting for > review a draft implementation of this offload for a DSA switch. > > I don't want to insist too much on the hardwar

Re: [ovs-dev] [PATCH net-next] net: openvswitch: do not update max_headroom if new headroom is equal to old headroom

2019-07-08 Thread Gregory Rose
On 7/8/2019 4:18 PM, Gregory Rose wrote: On 7/8/2019 4:08 PM, David Miller wrote: From: Taehee Yoo Date: Sat,  6 Jul 2019 01:08:09 +0900 When a vport is deleted, the maximum headroom size would be changed. If the vport which has the largest headroom is deleted, the new max_headroom would b

Re: [ovs-dev] [PATCH net-next] net: openvswitch: do not update max_headroom if new headroom is equal to old headroom

2019-07-08 Thread Gregory Rose
On 7/8/2019 4:08 PM, David Miller wrote: From: Taehee Yoo Date: Sat, 6 Jul 2019 01:08:09 +0900 When a vport is deleted, the maximum headroom size would be changed. If the vport which has the largest headroom is deleted, the new max_headroom would be set. But, if the new headroom size is equal

Re: [net-next] net: fib_rules: do not flow dissect local packets

2019-07-08 Thread David Miller
From: Petar Penkov Date: Fri, 5 Jul 2019 11:46:43 -0700 > Rules matching on loopback iif do not need early flow dissection as the > packet originates from the host. Stop counting such rules in > fib_rule_requires_fldissect > > Signed-off-by: Petar Penkov Roopa, please review.

Re: [PATCH net-next] net: openvswitch: do not update max_headroom if new headroom is equal to old headroom

2019-07-08 Thread David Miller
From: Taehee Yoo Date: Sat, 6 Jul 2019 01:08:09 +0900 > When a vport is deleted, the maximum headroom size would be changed. > If the vport which has the largest headroom is deleted, > the new max_headroom would be set. > But, if the new headroom size is equal to the old headroom size, > updatin

Re: [PATCH v3 net-next 19/19] ionic: Add basic devlink interface

2019-07-08 Thread Shannon Nelson
On 7/8/19 1:03 PM, Jiri Pirko wrote: Mon, Jul 08, 2019 at 09:58:09PM CEST, snel...@pensando.io wrote: On 7/8/19 12:34 PM, Jiri Pirko wrote: Mon, Jul 08, 2019 at 09:25:32PM CEST, snel...@pensando.io wrote: + +static const struct devlink_ops ionic_dl_ops = { + .info_get = ionic_dl_i

Re: [PATCH net-next] net: openvswitch: use netif_ovs_is_port() instead of opencode

2019-07-08 Thread David Miller
From: Taehee Yoo Date: Sat, 6 Jul 2019 01:05:46 +0900 > Use netif_ovs_is_port() function instead of open code. > This patch doesn't change logic. > > Signed-off-by: Taehee Yoo Applied.

Re: [PATCH net-next 00/11] Add drop monitor for offloaded data paths

2019-07-08 Thread Jakub Kicinski
On Mon, 8 Jul 2019 16:19:08 +0300, Ido Schimmel wrote: > On Sun, Jul 07, 2019 at 12:45:41PM -0700, David Miller wrote: > > From: Ido Schimmel > > Date: Sun, 7 Jul 2019 10:58:17 +0300 > > > > > Users have several ways to debug the kernel and understand why a packet > > > was dropped. For exampl

Re: [PATCH net-next V2] MAINTAINERS: Add page_pool maintainer entry

2019-07-08 Thread David Miller
From: Jesper Dangaard Brouer Date: Fri, 05 Jul 2019 14:57:55 +0200 > In this release cycle the number of NIC drivers using page_pool > will likely reach 4 drivers. It is about time to add a maintainer > entry. Add myself and Ilias. > > Signed-off-by: Jesper Dangaard Brouer > --- > V2: Ilias a

Re: [PATCH] selftests: txring_overwrite: fix incorrect test of mmap() return value

2019-07-08 Thread David Miller
From: Frank de Brabander Date: Fri, 5 Jul 2019 13:43:14 +0200 > If mmap() fails it returns MAP_FAILED, which is defined as ((void *) -1). > The current if-statement incorrectly tests if *ring is NULL. > > Signed-off-by: Frank de Brabander Applied with fixes tag added and queued up for -stable

Re: [PATCH bpf-next v3] virtio_net: add XDP meta data support

2019-07-08 Thread Daniel Borkmann
On 07/02/2019 04:11 PM, Yuya Kusakabe wrote: > On 7/2/19 5:33 PM, Jason Wang wrote: >> On 2019/7/2 下午4:16, Yuya Kusakabe wrote: >>> This adds XDP meta data support to both receive_small() and >>> receive_mergeable(). >>> >>> Fixes: de8f3a83b0a0 ("bpf: add meta pointer for direct access") >>> Signed

Re: [PATCH v3 0/2] Document the configuration of b53

2019-07-08 Thread David Miller
From: Benedikt Spranger Date: Fri, 5 Jul 2019 11:57:17 +0200 > this is the third round to document the configuration of a b53 supported > switch. Series applied. There was some trailing whitespace which I took care of for you this time. Thanks.

Re: [PATCH 0/2] forcedeth: recv cache support

2019-07-08 Thread David Miller
From: Zhu Yanjun Date: Fri, 5 Jul 2019 02:19:26 -0400 > This recv cache is to make NIC work steadily when the system memory is > not enough. The system is supposed to hold onto enough atomic memory to absorb all reasonable situations like this. If anything a solution to this problem belongs ge

Re: [PATCH net-next v2 0/4] bnxt_en: Add XDP_REDIRECT support.

2019-07-08 Thread David Miller
From: Michael Chan Date: Mon, 8 Jul 2019 17:53:00 -0400 > This patch series adds XDP_REDIRECT support by Andy Gospodarek. Series applied, thanks everyone.

Re: [PATCH v3 net-next 13/19] ionic: Add initial ethtool support

2019-07-08 Thread Andrew Lunn
> +static int ionic_get_link_ksettings(struct net_device *netdev, > + struct ethtool_link_ksettings *ks) > +{ > + struct lif *lif = netdev_priv(netdev); > + struct ionic_dev *idev = &lif->ionic->idev; > + int copper_seen = 0; > + > + ethtool_link_kset

[PATCH net-next v2 4/4] bnxt_en: add page_pool support

2019-07-08 Thread Michael Chan
From: Andy Gospodarek This removes contention over page allocation for XDP_REDIRECT actions by adding page_pool support per queue for the driver. The performance for XDP_REDIRECT actions scales linearly with the number of cores performing redirect actions when using the page pools instead of the

[PATCH net-next v2 1/4] bnxt_en: rename some xdp functions

2019-07-08 Thread Michael Chan
From: Andy Gospodarek Renaming bnxt_xmit_xdp to __bnxt_xmit_xdp to get ready for XDP_REDIRECT support and reduce confusion/namespace collision. Signed-off-by: Andy Gospodarek Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 2 +- drivers/net/ethernet/broadco

[PATCH net-next v2 0/4] bnxt_en: Add XDP_REDIRECT support.

2019-07-08 Thread Michael Chan
This patch series adds XDP_REDIRECT support by Andy Gospodarek. Andy Gospodarek (3): bnxt_en: rename some xdp functions bnxt_en: optimized XDP_REDIRECT support bnxt_en: add page_pool support Michael Chan (1): bnxt_en: Refactor __bnxt_xmit_xdp(). drivers/net/ethernet/broadcom/Kconfig

  1   2   3   >