RE: [EXT] Re: [PATCH net-next 4/4] qed: Add devlink support for configuration attributes.

2019-07-03 Thread Sudarsana Reddy Kalluru
> -Original Message- > From: Jakub Kicinski > Sent: Wednesday, July 3, 2019 11:13 PM > To: Sudarsana Reddy Kalluru > Cc: Jiri Pirko ; da...@davemloft.net; > netdev@vger.kernel.org; Michal Kalderon ; Ariel > Elior > Subject: Re: [EXT] Re: [PATCH net-next 4/4] qed: Add devlink support for

Re: i.mx6ul with DSA in multi chip addressing mode - no MDIO access

2019-07-03 Thread Benjamin Beckmeyer
On 03.07.19 17:55, Andrew Lunn wrote: > On Wed, Jul 03, 2019 at 03:10:34PM +0200, Benjamin Beckmeyer wrote: >> Hey folks, >> >> I'm having a problem with a custom i.mx6ul board. When DSA is loaded I can't >> get access to the switch via MDIO, but the DSA is working properly. I set up >> a bridge

[PATCH v3 net-next] net: socionext: remove set but not used variable 'pkts'

2019-07-03 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/ethernet/socionext/netsec.c: In function 'netsec_clean_tx_dring': drivers/net/ethernet/socionext/netsec.c:637:15: warning: variable 'pkts' set but not used [-Wunused-but-set-variable] It is not used since commit ba2b232108d3 ("net: netse

[PATCH v2 net-next] net: socionext: remove set but not used variable 'pkts'

2019-07-03 Thread YueHaibing
Cc: netdev@vger.kernel.org, xdp-newb...@vger.kernel.org, b...@vger.kernel.org, kernel-janit...@vger.kernel.org Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/ethernet/socionext/netsec.c: In function 'netsec_clean_tx_dring': drivers/net/ethernet/socionext/netsec.c:637:15: w

[rdma 10/16] RDMA/irdma: Add RoCEv2 UD OP support

2019-07-03 Thread Jeff Kirsher
From: Mustafa Ismail Add the header, data structures and functions to populate the WQE descriptors and issue the Control QP commands that support RoCEv2 UD operations. Signed-off-by: Mustafa Ismail Signed-off-by: Shiraz Saleem --- drivers/infiniband/hw/irdma/uda.c | 391

[rdma 05/16] RDMA/irdma: Add privileged UDA queue implementation

2019-07-03 Thread Jeff Kirsher
From: Mustafa Ismail Implement privileged UDA queues to handle iWARP connection packets and receive exceptions. Signed-off-by: Mustafa Ismail Signed-off-by: Shiraz Saleem --- drivers/infiniband/hw/irdma/puda.c | 1693 drivers/infiniband/hw/irdma/puda.h | 187 +++

[rdma 09/16] RDMA/irdma: Implement device supported verb APIs

2019-07-03 Thread Jeff Kirsher
From: Mustafa Ismail Implement device supported verb APIs. The supported APIs vary based on the underlying transport the ibdev is registered as (i.e. iWARP or RoCEv2). Signed-off-by: Mustafa Ismail Signed-off-by: Shiraz Saleem --- drivers/infiniband/hw/irdma/verbs.c | 4347 ++

[rdma 14/16] RDMA/irdma: Add ABI definitions

2019-07-03 Thread Jeff Kirsher
From: Mustafa Ismail Add ABI definitions for irdma. Signed-off-by: Mustafa Ismail Signed-off-by: Shiraz Saleem --- include/uapi/rdma/irdma-abi.h | 130 ++ 1 file changed, 130 insertions(+) create mode 100644 include/uapi/rdma/irdma-abi.h diff --git a/include/

[rdma 06/16] RDMA/irdma: Add QoS definitions

2019-07-03 Thread Jeff Kirsher
From: Mustafa Ismail Add definitions for managing the RDMA HW work scheduler (WS) tree. A WS node is created via a control QP operation with the bandwidth allocation, arbitration scheme, and traffic class of the QP specified. The Qset handle returned associates the QoS parameters for the QP. The

[rdma 11/16] RDMA/irdma: Add user/kernel shared libraries

2019-07-03 Thread Jeff Kirsher
From: Mustafa Ismail Building the WQE descriptors for different verb operations are similar in kernel and user-space. Add these shared libraries. Signed-off-by: Mustafa Ismail Signed-off-by: Shiraz Saleem --- drivers/infiniband/hw/irdma/uk.c | 1739 drivers/infi

[rdma 08/16] RDMA/irdma: Add PBLE resource manager

2019-07-03 Thread Jeff Kirsher
From: Mustafa Ismail Implement a Physical Buffer List Entry (PBLE) resource manager to manage a pool of PBLE HMC resource objects. Signed-off-by: Mustafa Ismail Signed-off-by: Shiraz Saleem --- drivers/infiniband/hw/irdma/pble.c | 511 + drivers/infiniband/hw/irdma

[rdma 15/16] RDMA/irdma: Update MAINTAINERS file

2019-07-03 Thread Jeff Kirsher
From: Shiraz Saleem Add maintainer entry for irdma driver. Signed-off-by: Mustafa Ismail Signed-off-by: Shiraz Saleem --- MAINTAINERS | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 9ac03f3e3bd5..b552bf583c97 100644 --- a/MAINTAINE

[rdma 00/16] Intel RDMA Diver Updates 2019-07-03

2019-07-03 Thread Jeff Kirsher
This patchset adds a unified Intel Ethernet RDMA driver that supports a new network device E810 (iWARP and RoCEv2 capable) and the existing X722 iWARP device. The driver architecture provides the extensibility for future generations of Intel HW supporting RDMA. This driver obsoletes legacy X722 dr

[rdma 16/16] RDMA/irdma: Add Kconfig and Makefile

2019-07-03 Thread Jeff Kirsher
From: Shiraz Saleem Add Kconfig and Makefile to build irdma driver and mark i40iw deprecated/obsolete, since the irdma driver is replacing it and supports x722 devices. Signed-off-by: Shiraz Saleem --- drivers/infiniband/Kconfig | 1 + drivers/infiniband/hw/Makefile | 1 + dr

[rdma 04/16] RDMA/irdma: Add HMC backing store setup functions

2019-07-03 Thread Jeff Kirsher
From: Mustafa Ismail HW uses host memory as a backing store for a number of protocol context objects and queue state tracking. The Host Memory Cache (HMC) is a component responsible for managing these objects stored in host memory. Add the functions and data structures to manage the allocation o

[rdma 02/16] RDMA/irdma: Implement device initialization definitions

2019-07-03 Thread Jeff Kirsher
From: Mustafa Ismail Implement device initialization routines, interrupt set-up, and allocate object bit-map tracking structures. Also, add device specific attributes and register definitions. Signed-off-by: Mustafa Ismail Signed-off-by: Shiraz Saleem --- drivers/infiniband/hw/irdma/hw.c

[net-next 2/3] ice: Implement peer communications

2019-07-03 Thread Jeff Kirsher
From: Tony Nguyen Set and implement operations for the peer device and peer driver to communicate with each other, via ice_ops and ice_peer_ops, to request resources and manage event notification. Signed-off-by: Dave Ertman Signed-off-by: Tony Nguyen Tested-by: Andrew Bowers Signed-off-by: Je

[rdma 1/1] RDMA/irdma: Add Kconfig and Makefile

2019-07-03 Thread Jeff Kirsher
From: Shiraz Saleem Add Kconfig and Makefile to build irdma driver and mark i40iw deprecated/obsolete, since the irdma driver is replacing it and supports x722 devices. Signed-off-by: Shiraz Saleem --- drivers/infiniband/Kconfig | 1 + drivers/infiniband/hw/Makefile | 1 + dr

[rdma 12/16] RDMA/irdma: Add miscellaneous utility definitions

2019-07-03 Thread Jeff Kirsher
From: Mustafa Ismail Add miscellaneous utility functions and headers. Signed-off-by: Mustafa Ismail Signed-off-by: Shiraz Saleem --- drivers/infiniband/hw/irdma/osdep.h | 108 ++ drivers/infiniband/hw/irdma/protos.h | 96 ++ drivers/infiniband/hw/irdma/status.h | 70 + drivers/infiniban

[rdma 07/16] RDMA/irdma: Add connection manager

2019-07-03 Thread Jeff Kirsher
From: Mustafa Ismail Add connection management (CM) implementation for iWARP including accept, reject, connect, create_listen, destroy_listen and CM utility functions Signed-off-by: Mustafa Ismail Signed-off-by: Shiraz Saleem --- drivers/infiniband/hw/irdma/cm.c | 4514 +++

[rdma 13/16] RDMA/irdma: Add dynamic tracing for CM

2019-07-03 Thread Jeff Kirsher
From: "Michael J. Ruhl" Add dynamic tracing functionality to debug connection management issues. Signed-off-by: "Michael J. Ruhl" Signed-off-by: Shiraz Saleem --- drivers/infiniband/hw/irdma/trace.c| 113 ++ drivers/infiniband/hw/irdma/trace.h| 4 + drivers/infiniband/hw/irdma/t

[rdma 01/16] RDMA/irdma: Add driver framework definitions

2019-07-03 Thread Jeff Kirsher
From: Mustafa Ismail Register irdma as a platform driver capable of supporting platform devices from multi-generation RDMA capable Intel HW. Establish the interface with all supported netdev peer devices and initialize HW. Signed-off-by: Mustafa Ismail Signed-off-by: Shiraz Saleem --- drivers

[net-next 3/3] i40e: Register RDMA client devices to the virtual platform bus

2019-07-03 Thread Jeff Kirsher
From: Shiraz Saleem Register RDMA client devices to the virtual platform bus. The unified RDMA driver 'irdma' registers as a platform driver and will bind to these devices. This model is inspired by the discussion in [1]. It realizes a single RDMA driver capable of working with multiple LAN drive

[net-next 1/3] ice: Initialize and register platform device to provide RDMA

2019-07-03 Thread Jeff Kirsher
From: Tony Nguyen The RDMA block does not advertise on the PCI bus or any other bus. Thus the ice driver needs to provide access to the RDMA hardware block via a virtual bus; utilize the platform bus to provide this access. This patch initializes the driver to support RDMA as well as creates and

[net-next 0/3][pull request] Intel Wired LAN ver Updates 2019-07-03

2019-07-03 Thread Jeff Kirsher
This series contains updates to i40e an ice drivers only and is required for a series of changes being submitted to the RDMA maintainer/tree. Vice Versa, the Intel RDMA driver patches could not be applied to net-next due to dependencies to the changes currently in the for-next branch of the rdma gi

Re: [PATCH v5 bpf-next 4/9] libbpf: add kprobe/uprobe attach API

2019-07-03 Thread Andrii Nakryiko
On Wed, Jul 3, 2019 at 9:47 AM Andrii Nakryiko wrote: > > On Wed, Jul 3, 2019 at 5:39 AM Daniel Borkmann wrote: > > > > On 07/02/2019 01:58 AM, Andrii Nakryiko wrote: > > > Add ability to attach to kernel and user probes and retprobes. > > > Implementation depends on perf event support for kprobe

[PATCH v4 bpf-next 1/4] libbpf: capture value in BTF type info for BTF-defined map defs

2019-07-03 Thread Andrii Nakryiko
Change BTF-defined map definitions to capture compile-time integer values as part of BTF type definition, to avoid split of key/value type information and actual type/size/flags initialization for maps. Signed-off-by: Andrii Nakryiko Acked-by: Song Liu Acked-by: Yonghong Song --- tools/lib/bpf

[PATCH v4 bpf-next 4/4] selftests/bpf: convert legacy BPF maps to BTF-defined ones

2019-07-03 Thread Andrii Nakryiko
Convert selftests that were originally left out and new ones added recently to consistently use BTF-defined maps. Signed-off-by: Andrii Nakryiko Acked-by: Song Liu Acked-by: Yonghong Song --- .../selftests/bpf/progs/get_cgroup_id_kern.c | 26 ++--- tools/testing/selftests/bpf/progs/pyperf.h

[PATCH v4 bpf-next 3/4] selftests/bpf: convert selftests using BTF-defined maps to new syntax

2019-07-03 Thread Andrii Nakryiko
Convert all the existing selftests that are already using BTF-defined maps to use new syntax (with no static data initialization). Signed-off-by: Andrii Nakryiko Acked-by: Song Liu Acked-by: Yonghong Song --- tools/testing/selftests/bpf/progs/bpf_flow.c | 28 +++ .../testing/selftests/bpf

[PATCH v4 bpf-next 2/4] selftests/bpf: add __uint and __type macro for BTF-defined maps

2019-07-03 Thread Andrii Nakryiko
Add simple __uint and __type macro that hide details of how type and integer values are captured in BTF-defined maps. Signed-off-by: Andrii Nakryiko Acked-by: Song Liu Acked-by: Yonghong Song --- tools/testing/selftests/bpf/bpf_helpers.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/t

[PATCH v4 bpf-next 0/4] capture integers in BTF type info for map defs

2019-07-03 Thread Andrii Nakryiko
This patch set implements an update to how BTF-defined maps are specified. The change is in how integer attributes, e.g., type, max_entries, map_flags, are specified: now they are captured as part of map definition struct's BTF type information (using array dimension), eliminating the need for comp

[PATCH v2 net-next 1/3] tc-testing: Add JSON verification to tdc

2019-07-03 Thread Lucas Bates
This patch allows tdc to process JSON output to perform secondary verification of the command under test. If the verifyCmd generates JSON, one can provide the 'matchJSON' key to process it instead of a regex. matchJSON has two elements: 'path' and 'value'. The 'path' key is a list of integers and

[PATCH v2 net-next 0/3] tc-testing: Add JSON verification and simple traffic generation

2019-07-03 Thread Lucas Bates
This patchset introduces JSON as a verification method in tdc and adds a new plugin, scapyPlugin, as a way to send traffic to test tc filters and actions. This version includes the patch signoffs missing in the previous submission. The first patch adds the JSON verification to the core tdc script.

[PATCH v2 net-next 2/3] tc-testing: Allow tdc plugins to see test case data

2019-07-03 Thread Lucas Bates
Instead of only passing the test case name and ID, pass the entire current test case down to the plugins. This change allows plugins to start accepting commands and directives from the test cases themselves, for greater flexibility in testing. Signed-off-by: Lucas Bates --- tools/testing/selftes

[PATCH v2 net-next 3/3] tc-testing: introduce scapyPlugin for basic traffic

2019-07-03 Thread Lucas Bates
The scapyPlugin allows for simple traffic generation in tdc to test various tc features. It was tested with scapy v2.4.2, but should work with any successive version. In order to use the plugin's functionality, scapy must be installed. This can be done with: pip3 install scapy or to install 2.

[Patch net 1/3] hsr: fix a memory leak in hsr_del_port()

2019-07-03 Thread Cong Wang
hsr_del_port() should release all the resources allocated in hsr_add_port(). As a consequence of this change, hsr_for_each_port() is no longer safe to work with hsr_del_port(), switch to list_for_each_entry_safe() as we always hold RTNL lock. Cc: Arvid Brodin Signed-off-by: Cong Wang --- net/h

[Patch net 3/3] hsr: fix a NULL pointer deref in hsr_dev_xmit()

2019-07-03 Thread Cong Wang
hsr_port_get_hsr() could return NULL and kernel could crash: BUG: kernel NULL pointer dereference, address: 0010 #PF: supervisor read access in kernel mode #PF: error_code(0x) - not-present page PGD 800074b84067 P4D 800074b84067 PUD 7057d067 PMD 0 Oops: [#1] SMP P

[Patch net 0/3] hsr: a few bug fixes

2019-07-03 Thread Cong Wang
This patchset contains 3 bug fixes for hsr triggered by a syzbot reproducer, please check each patch for details. Cc: Arvid Brodin Signed-off-by: Cong Wang Cong Wang (3): hsr: fix a memory leak in hsr_del_port() hsr: implement dellink to clean up resources hsr: fix a NULL pointer deref in

[Patch net 2/3] hsr: implement dellink to clean up resources

2019-07-03 Thread Cong Wang
hsr_link_ops implements ->newlink() but not ->dellink(), which leads that resources not released after removing the device, particularly the entries in self_node_db and node_db. So add ->dellink() implementation to replace the priv_destructor. This also makes the code slightly easier to understand

Re: [PATCH net-next v5 0/5] Add MPLS actions to TC

2019-07-03 Thread Cong Wang
On Tue, Jul 2, 2019 at 5:25 PM John Hurley wrote: > > This patchset introduces a new TC action module that allows the > manipulation of the MPLS headers of packets. The code impliments > functionality including push, pop, and modify. > > Also included are tests for the new funtionality. Note that

Re: [PATCH bpf-next] selftests/bpf: make verifier loop tests arch independent

2019-07-03 Thread Y Song
On Wed, Jul 3, 2019 at 1:51 PM Stanislav Fomichev wrote: > > Take the first x bytes of pt_regs for scalability tests, there is > no real reason we need x86 specific rax. > > Signed-off-by: Stanislav Fomichev > --- > tools/testing/selftests/bpf/progs/loop1.c | 3 ++- > tools/testing/selftests/bpf

Re: [PATCH bpf-next] selftests/bpf: fix test_align liveliness expectations

2019-07-03 Thread Y Song
On Wed, Jul 3, 2019 at 2:31 PM Stanislav Fomichev wrote: > > Commit 2589726d12a1 ("bpf: introduce bounded loops") caused a change > in the way some registers liveliness is reported in the test_align. > Add missing "_w" to a couple of tests. Note, there are no offset > changes! > > Fixes: 2589726d1

Re: pull-request: bpf-next 2019-07-03

2019-07-03 Thread Daniel Borkmann
On 07/04/2019 01:11 AM, Saeed Mahameed wrote: > On Wed, Jul 3, 2019 at 3:47 PM Daniel Borkmann wrote: >> >> Hi David, >> >> The following pull-request contains BPF updates for your *net-next* tree. >> >> There is a minor merge conflict in mlx5 due to 8960b38932be ("linux/dim: >> Rename externally

Re: [PATCH bpf-next] selftests/bpf: fix "alu with different scalars 1" on s390

2019-07-03 Thread Y Song
On Wed, Jul 3, 2019 at 9:06 AM Ilya Leoshkevich wrote: > > BPF_LDX_MEM is used to load the least significant byte of the retrieved > test_val.index, however, on big-endian machines it ends up retrieving > the most significant byte. > > Use the correct least significant byte offset on big-endian ma

Re: pull-request: bpf-next 2019-07-03

2019-07-03 Thread Saeed Mahameed
On Wed, Jul 3, 2019 at 3:47 PM Daniel Borkmann wrote: > > Hi David, > > The following pull-request contains BPF updates for your *net-next* tree. > > There is a minor merge conflict in mlx5 due to 8960b38932be ("linux/dim: > Rename externally used net_dim members") which has been pulled into your

Re: [PATCH net-next 0/2] Mellanox, mlx5 devlink versions query

2019-07-03 Thread Saeed Mahameed
On Wed, Jul 3, 2019 at 1:49 PM David Miller wrote: > > From: David Miller > Date: Wed, 03 Jul 2019 13:47:00 -0700 (PDT) > > > From: Saeed Mahameed > > Date: Tue, 2 Jul 2019 23:55:07 + > > > >> This humble 2 patch series from Shay adds the support for devlink fw > >> versions query to mlx5 dr

[PATCH iproute2 1/2] tc: added mask parameter in skbedit action

2019-07-03 Thread Roman Mashak
Add 32-bit missing mask attribute in iproute2/tc, which has been long supported by the kernel side. Signed-off-by: Roman Mashak --- tc/m_skbedit.c | 30 ++ 1 file changed, 26 insertions(+), 4 deletions(-) diff --git a/tc/m_skbedit.c b/tc/m_skbedit.c index b6b839f8ef6

[PATCH iproute2 2/2] tc: document 'mask' parameter in skbedit man page

2019-07-03 Thread Roman Mashak
Signed-off-by: Roman Mashak --- man/man8/tc-skbedit.8 | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/man/man8/tc-skbedit.8 b/man/man8/tc-skbedit.8 index 2459198261e6..704f63bdb061 100644 --- a/man/man8/tc-skbedit.8 +++ b/man/man8/tc-skbedit.8 @@ -9,8 +9,7 @@ skbedit -

pull-request: bpf-next 2019-07-03

2019-07-03 Thread Daniel Borkmann
Hi David, The following pull-request contains BPF updates for your *net-next* tree. There is a minor merge conflict in mlx5 due to 8960b38932be ("linux/dim: Rename externally used net_dim members") which has been pulled into your tree in the meantime, but resolution seems not that bad ... getting

Re: [PATCH bpf-next] selftests/bpf: add test_tcp_rtt to .gitignore

2019-07-03 Thread Y Song
On Wed, Jul 3, 2019 at 1:10 PM Stanislav Fomichev wrote: > > Forgot to add it in the original patch. > > Fixes: b55873984dab ("selftests/bpf: test BPF_SOCK_OPS_RTT_CB") > Reported-by: Andrii Nakryiko > Signed-off-by: Stanislav Fomichev Acked-by: Yonghong Song > --- > tools/testing/selftests/

Re: [PATCH v3 bpf-next 0/4] capture integers in BTF type info for map defs

2019-07-03 Thread Yonghong Song
On 7/3/19 12:06 PM, Andrii Nakryiko wrote: > This patch set implements an update to how BTF-defined maps are specified. The > change is in how integer attributes, e.g., type, max_entries, map_flags, are > specified: now they are captured as part of map definition struct's BTF type > information (

Re: [PATCH v3 bpf-next 2/4] selftests/bpf: add __int and __type macro for BTF-defined maps

2019-07-03 Thread Yonghong Song
On 7/3/19 12:06 PM, Andrii Nakryiko wrote: > Add simple __int and __type macro that hide details of how type and The "__int" should be "__uint". The subject line should change from __int to __uint. > integer values are captured in BTF-defined maps. > > Signed-off-by: Andrii Nakryiko > --- >

[PATCH bpf-next] selftests/bpf: fix test_align liveliness expectations

2019-07-03 Thread Stanislav Fomichev
Commit 2589726d12a1 ("bpf: introduce bounded loops") caused a change in the way some registers liveliness is reported in the test_align. Add missing "_w" to a couple of tests. Note, there are no offset changes! Fixes: 2589726d12a1 ("bpf: introduce bounded loops") Signed-off-by: Stanislav Fomichev

Re: [PATCH net-next v2 0/5] net: use ICW for sk_proto->{send,recv}msg

2019-07-03 Thread David Miller
From: Willem de Bruijn Date: Wed, 3 Jul 2019 10:45:13 -0400 > On Wed, Jul 3, 2019 at 10:07 AM Paolo Abeni wrote: >> >> This series extends ICW usage to one of the few remaining spots in fast-path >> still hitting per packet retpoline overhead, namely the >> sk_proto->{send,recv}msg >> calls. >>

[PATCH bpf-next] selftests/bpf: make verifier loop tests arch independent

2019-07-03 Thread Stanislav Fomichev
Take the first x bytes of pt_regs for scalability tests, there is no real reason we need x86 specific rax. Signed-off-by: Stanislav Fomichev --- tools/testing/selftests/bpf/progs/loop1.c | 3 ++- tools/testing/selftests/bpf/progs/loop2.c | 3 ++- tools/testing/selftests/bpf/progs/loop3.c | 3 ++-

Re: [PATCH net-next 0/2] Mellanox, mlx5 devlink versions query

2019-07-03 Thread David Miller
From: David Miller Date: Wed, 03 Jul 2019 13:47:00 -0700 (PDT) > From: Saeed Mahameed > Date: Tue, 2 Jul 2019 23:55:07 + > >> This humble 2 patch series from Shay adds the support for devlink fw >> versions query to mlx5 driver. >> >> In the first patch we implement the needed fw commands

Re: [PATCH net-next 0/2] Mellanox, mlx5 devlink versions query

2019-07-03 Thread David Miller
From: Saeed Mahameed Date: Tue, 2 Jul 2019 23:55:07 + > This humble 2 patch series from Shay adds the support for devlink fw > versions query to mlx5 driver. > > In the first patch we implement the needed fw commands to support this > feature. > In the 2nd patch we implement the devlink call

Re: [PATCH net-next 0/3 v2] macsec: a few cleanups in the receive path

2019-07-03 Thread David Miller
From: Andreas Steinmetz Date: Tue, 02 Jul 2019 22:49:54 +0200 > This patchset removes some unnecessary code in the receive path of the > macsec driver, and re-indents the error handling after calling > macsec_decrypt to make the post-processing clearer. > > This is a combined effort of Sabrina D

Re: [Patch net] bonding: validate ip header before check IPPROTO_IGMP

2019-07-03 Thread David Miller
From: Cong Wang Date: Mon, 1 Jul 2019 20:40:24 -0700 > bond_xmit_roundrobin() checks for IGMP packets but it parses > the IP header even before checking skb->protocol. > > We should validate the IP header with pskb_may_pull() before > using iph->protocol. > > Reported-and-tested-by: syzbot+e5b

Re: [PATCH rdma-next v2 00/13] DEVX asynchronous events

2019-07-03 Thread Jason Gunthorpe
On Sun, Jun 30, 2019 at 07:23:21PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > Changelog: > v1 -> v2: > * Added Saeed's ack to net patches > * Patch #2: > * Fix to gather user asynchronous events on top of kernel events. > * Patch #7: > * Fix obj_id to be 32 bits. > * Patch

Re: [PATCH rdma-next v2 10/13] IB/mlx5: Enable subscription for device events over DEVX

2019-07-03 Thread Jason Gunthorpe
On Sun, Jun 30, 2019 at 07:23:31PM +0300, Leon Romanovsky wrote: > From: Yishai Hadas > > Enable subscription for device events over DEVX. > > Each subscription is added to the two level XA data structure according > to its event number and the DEVX object information in case was given > with th

Re: [PATCH bpf-next] selftests/bpf: add test_tcp_rtt to .gitignore

2019-07-03 Thread Andrii Nakryiko
On Wed, Jul 3, 2019 at 1:10 PM Stanislav Fomichev wrote: > > Forgot to add it in the original patch. > > Fixes: b55873984dab ("selftests/bpf: test BPF_SOCK_OPS_RTT_CB") > Reported-by: Andrii Nakryiko > Signed-off-by: Stanislav Fomichev > --- Thanks! Acked-by: Andrii Nakryiko > tools/testing

[PATCH bpf-next] selftests/bpf: add test_tcp_rtt to .gitignore

2019-07-03 Thread Stanislav Fomichev
Forgot to add it in the original patch. Fixes: b55873984dab ("selftests/bpf: test BPF_SOCK_OPS_RTT_CB") Reported-by: Andrii Nakryiko Signed-off-by: Stanislav Fomichev --- tools/testing/selftests/bpf/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/bpf/.giti

Re: [PATCH bpf-next v2 6/8] selftests/bpf: test BPF_SOCK_OPS_RTT_CB

2019-07-03 Thread Stanislav Fomichev
On 07/03, Andrii Nakryiko wrote: > On Tue, Jul 2, 2019 at 9:14 AM Stanislav Fomichev wrote: > > > > Make sure the callback is invoked for syn-ack and data packet. > > > > Cc: Eric Dumazet > > Cc: Priyaranjan Jha > > Cc: Yuchung Cheng > > Cc: Soheil Hassas Yeganeh > > Acked-by: Soheil Hassas Ye

Re: [PATCH v3 bpf-next 0/4] capture integers in BTF type info for map defs

2019-07-03 Thread Andrii Nakryiko
On Wed, Jul 3, 2019 at 12:06 PM Andrii Nakryiko wrote: > > This patch set implements an update to how BTF-defined maps are specified. The > change is in how integer attributes, e.g., type, max_entries, map_flags, are > specified: now they are captured as part of map definition struct's BTF type >

Re: pull-request: bpf 2019-07-03

2019-07-03 Thread David Miller
From: Daniel Borkmann Date: Wed, 3 Jul 2019 17:31:06 +0200 > The following pull-request contains BPF updates for your *net* tree. > > The main changes are: ... > Please consider pulling these changes from: > > git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git Pulled, thanks.

[PATCH v3 bpf-next 4/4] selftests/bpf: convert legacy BPF maps to BTF-defined ones

2019-07-03 Thread Andrii Nakryiko
Convert selftests that were originally left out and new ones added recently to consistently use BTF-defined maps. Signed-off-by: Andrii Nakryiko --- .../selftests/bpf/progs/get_cgroup_id_kern.c | 26 ++--- tools/testing/selftests/bpf/progs/pyperf.h| 90 +++--- .../selftests/bpf/pr

[PATCH v3 bpf-next 3/4] selftests/bpf: convert selftests using BTF-defined maps to new syntax

2019-07-03 Thread Andrii Nakryiko
Convert all the existing selftests that are already using BTF-defined maps to use new syntax (with no static data initialization). Signed-off-by: Andrii Nakryiko --- tools/testing/selftests/bpf/progs/bpf_flow.c | 28 +++ .../testing/selftests/bpf/progs/netcnt_prog.c | 20 ++--- .../selftest

[PATCH v3 bpf-next 2/4] selftests/bpf: add __int and __type macro for BTF-defined maps

2019-07-03 Thread Andrii Nakryiko
Add simple __int and __type macro that hide details of how type and integer values are captured in BTF-defined maps. Signed-off-by: Andrii Nakryiko --- tools/testing/selftests/bpf/bpf_helpers.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/testing/selftests/bpf/bpf_helpers.h b/to

[PATCH v3 bpf-next 1/4] libbpf: capture value in BTF type info for BTF-defined map defs

2019-07-03 Thread Andrii Nakryiko
Change BTF-defined map definitions to capture compile-time integer values as part of BTF type definition, to avoid split of key/value type information and actual type/size/flags initialization for maps. Signed-off-by: Andrii Nakryiko --- tools/lib/bpf/libbpf.c | 58 --

[PATCH v3 bpf-next 0/4] capture integers in BTF type info for map defs

2019-07-03 Thread Andrii Nakryiko
This patch set implements an update to how BTF-defined maps are specified. The change is in how integer attributes, e.g., type, max_entries, map_flags, are specified: now they are captured as part of map definition struct's BTF type information (using array dimension), eliminating the need for comp

Re: [PATCH bpf-next v2 6/8] selftests/bpf: test BPF_SOCK_OPS_RTT_CB

2019-07-03 Thread Andrii Nakryiko
On Tue, Jul 2, 2019 at 9:14 AM Stanislav Fomichev wrote: > > Make sure the callback is invoked for syn-ack and data packet. > > Cc: Eric Dumazet > Cc: Priyaranjan Jha > Cc: Yuchung Cheng > Cc: Soheil Hassas Yeganeh > Acked-by: Soheil Hassas Yeganeh > Acked-by: Yuchung Cheng > Signed-off-by:

Re: [for-next V2 10/10] RDMA/core: Provide RDMA DIM support for ULPs

2019-07-03 Thread Sagi Grimberg
Hi Sagi, I'm not sharing your worries about bad out-of-the-box experience for a number of reasons. First of all, this code is part of upstream kernel and will take time till users actually start to use it as is and not as part of some distro backports or MOFED packages. True, but I am still

Klientskie bazy. Email: proda...@armyspy.com Uznajte podrobnee!

2019-07-03 Thread GKIcka3ku
Klientskie bazy. Email: proda...@armyspy.com Uznajte podrobnee!

[PATCH net-next v2] net: ethernet: mediatek: Fix overlapping capability bits.

2019-07-03 Thread René van Dorst
Both MTK_TRGMII_MT7621_CLK and MTK_PATH_BIT are defined as bit 10. This can causes issues on non-MT7621 devices which has the MTK_PATH_BIT(MTK_ETH_PATH_GMAC1_RGMII) and MTK_TRGMII capability set. The wrong TRGMII setup code can be executed. The current wrongly executed code doesn’t do any harm on

Re: [PATCH net] sctp: count data bundling sack chunk for outctrlchunks

2019-07-03 Thread David Miller
From: Xin Long Date: Wed, 3 Jul 2019 18:20:20 +0800 > Now all ctrl chunks are counted for asoc stats.octrlchunks and net > SCTP_MIB_OUTCTRLCHUNKS either after queuing up or bundling, other > than the chunk maked and bundled in sctp_packet_bundle_sack, which > caused 'outctrlchunks' not consisten

Re: [PATCH net-next v2 1/1] qed: Add support for Timestamping the unicast PTP packets.

2019-07-03 Thread David Miller
From: Sudarsana Reddy Kalluru Date: Tue, 2 Jul 2019 23:01:59 -0700 > This patch adds driver changes to detect/timestamp the unicast PTP packets. > > Changes from previous version: > --- > v2: Defined a macro for unicast ptp param mask. > > Please consider applying th

Re: [PATCH net-next] net: socionext: remove set but not used variable 'pkts'

2019-07-03 Thread David Miller
From: YueHaibing Date: Wed, 3 Jul 2019 02:42:13 + > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/ethernet/socionext/netsec.c: In function 'netsec_clean_tx_dring': > drivers/net/ethernet/socionext/netsec.c:637:15: warning: > variable 'pkts' set but not used [-Wunused-but-se

Re: [PATCH] gve: Fix u64_stats_sync to initialize start

2019-07-03 Thread David Miller
From: Catherine Sullivan Date: Tue, 2 Jul 2019 15:46:57 -0700 > u64_stats_fetch_begin needs to initialize start. > > Signed-off-by: Catherine Sullivan > Reported-by: kbuild test robot Applied, but in the future please indicate the target GIT tree in your Subject line, in this case it would b

Re: [PATCH v2] net: don't warn in inet diag when IPV6 is disabled

2019-07-03 Thread David Miller
From: Stephen Hemminger Date: Tue, 2 Jul 2019 15:20:21 -0700 > If IPV6 was disabled, then ss command would cause a kernel warning > because the command was attempting to dump IPV6 socket information. > The fix is to just remove the warning. > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi

Re: [PATCH net-next 0/3] tc-testing: Add JSON verification and simple traffic generation

2019-07-03 Thread David Miller
This entire patch series lacks proper signoffs.

Re: [PATCH next] loopback: fix lockdep splat

2019-07-03 Thread David Miller
From: Mahesh Bandewar Date: Tue, 2 Jul 2019 23:16:31 -0700 > dev_init_scheduler() and dev_activate() expect the caller to > hold RTNL. Since we don't want blackhole device to be initialized > per ns, we are initializing at init. > > [3.855027] Call Trace: > [3.855034] dump_stack+0x67/0

Re: [PATCH rdma-next v2 00/13] DEVX asynchronous events

2019-07-03 Thread Leon Romanovsky
On Wed, Jul 03, 2019 at 12:29:03PM -0300, Jason Gunthorpe wrote: > On Sun, Jun 30, 2019 at 07:23:21PM +0300, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > Changelog: > > v1 -> v2: > > * Added Saeed's ack to net patches > > * Patch #2: > > * Fix to gather user asynchronous events on

Re: [EXT] Re: [PATCH net-next 4/4] qed: Add devlink support for configuration attributes.

2019-07-03 Thread Jakub Kicinski
On Wed, 3 Jul 2019 12:56:39 +, Sudarsana Reddy Kalluru wrote: > Apologies for bringing this topic again. From the driver(s) code > paths/'devlink man pages', I understood that devlink-port object is > an entity on top of the PCI bus device. Some drivers say NFP > represents vnics (on pci-dev) a

[PATCH][next] gve: fix -ENOMEM null check on a page allocation

2019-07-03 Thread Colin King
From: Colin Ian King Currently the check to see if a page is allocated is incorrect and is checking if the pointer page is null, not *page as intended. Fix this. Addresses-Coverity: ("Dereference before null check") Fixes: f5cedc84a30d ("gve: Add transmit and receive support") Signed-off-by: Co

Re: [PATCH bpf v2] xdp: fix race on generic receive path

2019-07-03 Thread William Tu
On Wed, Jul 3, 2019 at 6:20 AM Magnus Karlsson wrote: > > On Wed, Jul 3, 2019 at 2:09 PM Ilya Maximets wrote: > > > > Unlike driver mode, generic xdp receive could be triggered > > by different threads on different CPU cores at the same time > > leading to the fill and rx queue breakage. For exam

Re: [PATCH v5 bpf-next 4/9] libbpf: add kprobe/uprobe attach API

2019-07-03 Thread Andrii Nakryiko
On Wed, Jul 3, 2019 at 5:39 AM Daniel Borkmann wrote: > > On 07/02/2019 01:58 AM, Andrii Nakryiko wrote: > > Add ability to attach to kernel and user probes and retprobes. > > Implementation depends on perf event support for kprobes/uprobes. > > > > Signed-off-by: Andrii Nakryiko > > Reviewed-by:

[PATCH v2 17/35] net/wireless: Use kmemdup rather than duplicating its implementation

2019-07-03 Thread Fuqian Huang
kmemdup is introduced to duplicate a region of memory in a neat way. Rather than kmalloc/kzalloc + memcpy, which the programmer needs to write the size twice (sometimes lead to mistakes), kmemdup improves readability, leads to smaller code and also reduce the chances of mistakes. Suggestion to use

[PATCH v2 15/35] net/ethernet: Use kmemdup rather than duplicating its implementation

2019-07-03 Thread Fuqian Huang
kmemdup is introduced to duplicate a region of memory in a neat way. Rather than kmalloc/kzalloc + memcpy, which the programmer needs to write the size twice (sometimes lead to mistakes), kmemdup improves readability, leads to smaller code and also reduce the chances of mistakes. Suggestion to use

[PATCH v2 16/35] net/wimax: Use kmemdup rather than duplicating its implementation

2019-07-03 Thread Fuqian Huang
kmemdup is introduced to duplicate a region of memory in a neat way. Rather than kmalloc/kzalloc + memcpy, which the programmer needs to write the size twice (sometimes lead to mistakes), kmemdup improves readability, leads to smaller code and also reduce the chances of mistakes. Suggestion to use

Re: [PATCH v4 bpf-next 0/4] libbpf: add perf buffer abstraction and API

2019-07-03 Thread Andrii Nakryiko
On Wed, Jul 3, 2019 at 2:36 AM Daniel Borkmann wrote: > > On 06/30/2019 08:51 AM, Andrii Nakryiko wrote: > > This patchset adds a high-level API for setting up and polling perf buffers > > associated with BPF_MAP_TYPE_PERF_EVENT_ARRAY map. Details of APIs are > > described in corresponding commit.

Re: kernel panic: corrupted stack end in dput

2019-07-03 Thread John Fastabend
Eric Biggers wrote: > [+bpf and tls maintainers] > > On Wed, Jul 03, 2019 at 04:23:34PM +0100, Al Viro wrote: > > On Wed, Jul 03, 2019 at 03:40:00PM +0100, Al Viro wrote: > > > On Wed, Jul 03, 2019 at 02:43:07PM +0800, Hillf Danton wrote: > > > > > > > > This is very much *NOT* fine. > > > > >

RE: [PATCH net-next 1/3] devlink: Introduce PCI PF port flavour and port attribute

2019-07-03 Thread Parav Pandit
> -Original Message- > From: Jiri Pirko > Sent: Wednesday, July 3, 2019 8:05 PM > To: Andrew Lunn > Cc: Parav Pandit ; Jakub Kicinski > ; Jiri Pirko ; > netdev@vger.kernel.org; Saeed Mahameed ; > vivien.dide...@gmail.com; f.faine...@gmail.com > Subject: Re: [PATCH net-next 1/3] devlink

[PATCH bpf-next] selftests/bpf: fix "alu with different scalars 1" on s390

2019-07-03 Thread Ilya Leoshkevich
BPF_LDX_MEM is used to load the least significant byte of the retrieved test_val.index, however, on big-endian machines it ends up retrieving the most significant byte. Use the correct least significant byte offset on big-endian machines. Signed-off-by: Ilya Leoshkevich --- tools/testing/selfte

Re: bug: tpacket_snd can cause data corruption

2019-07-03 Thread Willem de Bruijn
On Wed, Jul 3, 2019 at 7:08 AM Frank de Brabander wrote: > > In commit 5cd8d46e a fix was applied for data corruption in > tpacket_snd. A selftest was added in commit 358be656 which > validates this fix. > > Unfortunately this bug still persists, although since this fix less > likely to trigger. T

Re: linux-next: Tree for Jul 3 (netfilter/ipvs/)

2019-07-03 Thread Randy Dunlap
On 7/3/19 4:49 AM, Stephen Rothwell wrote: > Hi all, > > Changes since 20190702: > on i386: CC net/netfilter/ipvs/ip_vs_core.o ../net/netfilter/ipvs/ip_vs_core.c: In function ‘ipvs_gre_decap’: ../net/netfilter/ipvs/ip_vs_core.c:1618:22: error: storage size of ‘_greh’ isn’t known struc

Re: [net/tls] Re: KMSAN: uninit-value in aesti_encrypt

2019-07-03 Thread Eric Biggers
On Thu, Jun 27, 2019 at 12:01:23PM -0700, Eric Biggers wrote: > On Thu, Jun 27, 2019 at 11:19:51AM -0700, John Fastabend wrote: > > Eric Biggers wrote: > > > [+TLS maintainers] > > > > > > Very likely a net/tls bug, not a crypto bug. > > > > > > Possibly a duplicate of other reports such as "KMSA

Re: i.mx6ul with DSA in multi chip addressing mode - no MDIO access

2019-07-03 Thread Andrew Lunn
On Wed, Jul 03, 2019 at 03:10:34PM +0200, Benjamin Beckmeyer wrote: > Hey folks, > > I'm having a problem with a custom i.mx6ul board. When DSA is loaded I can't > get access to the switch via MDIO, but the DSA is working properly. I set up > a bridge for testing and the switch is in forwarding m

Re: kernel panic: corrupted stack end in dput

2019-07-03 Thread Eric Biggers
[+bpf and tls maintainers] On Wed, Jul 03, 2019 at 04:23:34PM +0100, Al Viro wrote: > On Wed, Jul 03, 2019 at 03:40:00PM +0100, Al Viro wrote: > > On Wed, Jul 03, 2019 at 02:43:07PM +0800, Hillf Danton wrote: > > > > > > This is very much *NOT* fine. > > > > 1) trylock can fail from any n

pull-request: bpf 2019-07-03

2019-07-03 Thread Daniel Borkmann
Hi David, The following pull-request contains BPF updates for your *net* tree. The main changes are: 1) Fix the interpreter to properly handle BPF_ALU32 | BPF_ARSH on BE architectures, from Jiong. 2) Fix several bugs in the x32 BPF JIT for handling shifts by 0, from Luke and Xi. 3) Fix N

  1   2   >