On Wed, Jul 3, 2019 at 1:49 PM David Miller <da...@davemloft.net> wrote: > > From: David Miller <da...@davemloft.net> > Date: Wed, 03 Jul 2019 13:47:00 -0700 (PDT) > > > From: Saeed Mahameed <sae...@mellanox.com> > > Date: Tue, 2 Jul 2019 23:55:07 +0000 > > > >> This humble 2 patch series from Shay adds the support for devlink fw > >> versions query to mlx5 driver. > >> > >> In the first patch we implement the needed fw commands to support this > >> feature. > >> In the 2nd patch we implement the devlink callbacks themselves. > >> > >> I am not sending this as a pull request since i am not sure when my next > >> pull request is going to be ready, and these two patches are straight > >> forward net-next patches. > > > > Series applied to net-next, thanks. > > This doesn't build, there is some dependency... > > [davem@localhost net-next]$ make -s -j14 > In file included from ./include/linux/mlx5/driver.h:51, > from drivers/net/ethernet/mellanox/mlx5/core/fw.c:33: > drivers/net/ethernet/mellanox/mlx5/core/fw.c: In function > ‘mlx5_reg_mcqi_query’: > ./include/linux/mlx5/device.h:68:36: error: invalid application of ‘sizeof’ > to incomplete type ‘union mlx5_ifc_mcqi_reg_data_bits’ > #define MLX5_UN_SZ_DW(typ) (sizeof(union mlx5_ifc_##typ##_bits) / 32) > ^~~~~
Yep, My bad :(, I thought [1] was part of my last pull, but it wasn't One way to solve this is if you pull latest mlx5-next branch form: git://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux.git All patches there already passed review on net-next and rdma-next mailing lists. Or just wait for my next pull request. sorry for this! [1] https://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux.git/commit/?h=mlx5-next&id=a82e0b5bdac29d9719d3ca2df01494a7947351aa
