dev_init_scheduler() and dev_activate() expect the caller to
hold RTNL. Since we don't want blackhole device to be initialized
per ns, we are initializing at init.
[3.855027] Call Trace:
[3.855034] dump_stack+0x67/0x95
[3.855037] lockdep_rcu_suspicious+0xd5/0x110
[3.855044] dev_
This patch adds driver changes to detect/timestamp the unicast PTP packets.
Changes from previous version:
---
v2: Defined a macro for unicast ptp param mask.
Please consider applying this to "net-next".
Signed-off-by: Sudarsana Reddy Kalluru
Signed-off-by: Ariel Eli
On Wed, Jul 03, 2019 at 02:42:13AM +, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/ethernet/socionext/netsec.c: In function 'netsec_clean_tx_dring':
> drivers/net/ethernet/socionext/netsec.c:637:15: warning:
> variable 'pkts' set but not used [-Wunused-bu
> -Original Message-
> From: Jakub Kicinski
> Sent: Wednesday, July 3, 2019 7:46 AM
> To: Parav Pandit
> Cc: Jiri Pirko ; netdev@vger.kernel.org; Saeed
> Mahameed
> Subject: Re: [PATCH net-next 1/3] devlink: Introduce PCI PF port flavour and
> port attribute
>
> On Wed, 3 Jul 2019 02
On 2019/7/3 3:39, Willem de Bruijn wrote:
> From: Willem de Bruijn
>
> skb_warn_bad_offload and netdev_rx_csum_fault trigger on hard to debug
> issues. Dump more state and the header.
>
> Optionally dump the entire packet and linear segment. This is required
> to debug checksum bugs that may inc
Hello Eric,
We have applied that commit e358f4af19db ("tcp: tcp_fragment() should
apply sane memory limits")
as a hotpatch in production environment. We found that it will make
tcp long connection reset during sending out packet when applying
that commit.
On 7/2/19, 10:55 AM, "netdev-ow...@vger.kernel.org on behalf of Y Song"
wrote:
On Tue, Jul 2, 2019 at 9:14 AM Stanislav Fomichev wrote:
>
> Congestion control team would like to have a periodic callback to
> track some TCP statistics. Let's add a sock_ops callback that can be
> -Original Message-
> From: Parav Pandit
> Sent: Tuesday, July 2, 2019 10:49 PM
> To: Andrew Lunn
> Cc: Sudarsana Reddy Kalluru ;
> da...@davemloft.net; netdev@vger.kernel.org; Michal Kalderon
> ; Ariel Elior ;
> j...@resnulli.us
> Subject: [EXT] RE: [PATCH net-next 1/1] devlink: Add A
This patchset introduces JSON as a verification method in tdc and adds a new
plugin, scapyPlugin, as a way to send traffic to test tc filters and actions.
The first patch adds the JSON verification to the core tdc script.
The second patch makes a change to the TdcPlugin module that will allow tdc
The scapyPlugin allows for simple traffic generation in tdc to
test various tc features. It was tested with scapy v2.4.2, but
should work with any successive version.
In order to use the plugin's functionality, scapy must be
installed. This can be done with:
pip3 install scapy
or to install 2.
Instead of only passing the test case name and ID, pass the
entire current test case down to the plugins. This change
allows plugins to start accepting commands and directives
from the test cases themselves, for greater flexibility
in testing.
---
tools/testing/selftests/tc-testing/TdcPlugin.py |
This patch allows tdc to process JSON output to perform secondary
verification of the command under test. If the verifyCmd generates
JSON, one can provide the 'matchJSON' key to process it
instead of a regex.
matchJSON has two elements: 'path' and 'value'. The 'path' key is a
list of integers and
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/ethernet/socionext/netsec.c: In function 'netsec_clean_tx_dring':
drivers/net/ethernet/socionext/netsec.c:637:15: warning:
variable 'pkts' set but not used [-Wunused-but-set-variable]
It is not used since commit ba2b232108d3 ("net: netse
> -Original Message-
> From: David Miller
> Sent: Wednesday, July 3, 2019 12:53 AM
> To: Sudarsana Reddy Kalluru
> Cc: netdev@vger.kernel.org; Michal Kalderon ;
> Ariel Elior
> Subject: Re: [PATCH net-next 1/1] qed: Add support for Timestamping the
> unicast PTP packets.
>
> From: Sudar
From: Roland Hii
[ Upstream commit a1e5388b4d5fc78688e5e9ee6641f779721d6291 ]
When ADDSUB bit is set, the system time seconds field is calculated as
the complement of the seconds part of the update value.
For example, if 3.1 seconds need to be subtracted from the
system time, this field
From: Sergej Benilov
[ Upstream commit 8ac8a01092b2added0749ef937037bf1912e13e3 ]
Since commit 605ad7f184b60cfaacbc038aa6c55ee68dee3c89 "tcp: refine TSO
autosizing",
outbound throughput is dramatically reduced for some connections, as sis900
is doing TX completion within idle states only.
Make
From: Petr Oros
[ Upstream commit 2e5db6eb3c23e5dc8171eb8f6af7a97ef9fcf3a9 ]
Certain cards in conjunction with certain switches need a little more
time for link setup that results in ethtool link test failure after
offline test. Patch adds a loop that waits for a link setup finish.
Changes in v
On Wed, 3 Jul 2019 02:08:39 +, Parav Pandit wrote:
> > If you want to expose some device specific
> > eswitch port ID please add a new attribute for that.
> > The fact that that ID may match port_number for your device today is
> > coincidental. port_number, and split attributes should not be
From: Petr Oros
[ Upstream commit 2e5db6eb3c23e5dc8171eb8f6af7a97ef9fcf3a9 ]
Certain cards in conjunction with certain switches need a little more
time for link setup that results in ethtool link test failure after
offline test. Patch adds a loop that waits for a link setup finish.
Changes in v
On Tue, Jul 2, 2019 at 8:32 PM John Hurley wrote:
>
> This patchset introduces a new TC action module that allows the
> manipulation of the MPLS headers of packets. The code impliments
> functionality including push, pop, and modify.
>
> Also included are tests for the new funtionality. Note that
From: Takashi Iwai
[ Upstream commit aad1dcc4f011ea409850e040363dff1e59aa4175 ]
The arc4 crypto is mandatory at ppp_mppe probe time, so let's put a
softdep line, so that the corresponding module gets prepared
gracefully. Without this, a simple inclusion to initrd via dracut
failed due to the mi
> -Original Message-
> From: Jakub Kicinski
> Sent: Wednesday, July 3, 2019 5:13 AM
> To: Parav Pandit
> Cc: Jiri Pirko ; netdev@vger.kernel.org; Saeed
> Mahameed
> Subject: Re: [PATCH net-next 1/3] devlink: Introduce PCI PF port flavour and
> port attribute
>
> On Tue, 2 Jul 2019 18
On Sun, Jun 30, 2019 at 9:57 PM Willem de Bruijn
wrote:
>
> On Sun, Jun 30, 2019 at 4:48 PM Andreas Steinmetz wrote:
> >
> > Remove superfluous skb_share_check() and skb_unshare().
> > macsec_decrypt is only called by macsec_handle_frame which
> > already does a skb_unshare().
>
> There is a subt
On Tue, Jul 02, 2019 at 09:58:40PM +0300, Ivan Khoronzhuk wrote:
On Tue, Jul 02, 2019 at 08:29:07PM +0200, Jesper Dangaard Brouer wrote:
On Tue, 2 Jul 2019 18:21:13 +0300
Ivan Khoronzhuk wrote:
On Tue, Jul 02, 2019 at 05:10:29PM +0200, Jesper Dangaard Brouer wrote:
On Tue, 2 Jul 2019 17:56:1
On Tue, Jul 2, 2019 at 3:48 PM Andreas Steinmetz wrote:
>
> On Tue, 2019-07-02 at 10:35 -0400, Willem de Bruijn wrote:
> > On Tue, Jul 2, 2019 at 12:25 AM Andreas Steinmetz wrote:
> > > On Sun, 2019-06-30 at 21:47 -0400, Willem de Bruijn wrote:
> > > > On Sun, Jun 30, 2019 at 4:48 PM Andreas Stei
On Mon, Jul 01, 2019 at 06:59:13PM -0700, Andy Lutomirski wrote:
> I think I'm understanding your motivation. You're not trying to make
> bpf() generically usable without privilege -- you're trying to create
> a way to allow certain users to access dangerous bpf functionality
> within some limits.
On 02/07/2019 09.49, santosh.shilim...@oracle.com wrote:
> On 7/1/19 10:11 PM, Gerd Rausch wrote:
>> For the registration work-requests there is a benefit to wait a short
>> amount of time only (the trade-off described in patch #1 of this series).
>>
> Actually we should just switch this code to wh
Hi Harald,
On Wed, 3 Jul 2019 at 09:10, Harald Welte wrote:
>
> Hi Taehee,
>
> On Wed, Jul 03, 2019 at 12:20:34AM +0900, Taehee Yoo wrote:
> > This patch series fixes several bugs in the gtp module.
>
> thanks a lot for your patches, they are much appreciated.
>
> They look valid to me after a br
On 02/07/2019 14.18, santosh.shilim...@oracle.com wrote:
> On 7/2/19 2:05 PM, Gerd Rausch wrote:
>> What do you call "RDS_GET_MR" semantics?
>>
> Its a blocking socket call. Meaning after this call return to the
> user, the key must be valid. With async registration that can't be
> guaranteed.
>
Hello Yuiko Oshino,
On Fri, May 10, 2019 at 09:22:43AM +0200, Uwe Kleine-König wrote:
> On Thu, May 09, 2019 at 11:07:45PM +0200, Andrew Lunn wrote:
> > On Thu, May 09, 2019 at 10:55:29PM +0200, Heiner Kallweit wrote:
> > > On 09.05.2019 22:29, Uwe Kleine-König wrote:
> > > > I have a board here t
> On Jul 3, 2019, at 5:32 AM, Andy Lutomirski wrote:
>
> On Tue, Jul 2, 2019 at 2:04 PM Kees Cook wrote:
>>
>> On Mon, Jul 01, 2019 at 06:59:13PM -0700, Andy Lutomirski wrote:
>>> I think I'm understanding your motivation. You're not trying to make
>>> bpf() generically usable without privi
>-Original Message-
>From: Uwe Kleine-König
>Sent: Tuesday, July 2, 2019 4:32 PM
>To: Yuiko Oshino - C18177
>Cc: netdev@vger.kernel.org; Andrew Lunn ; Florian Fainelli
>; ker...@pengutronix.de; Heiner Kallweit
>
>Subject: Re: net: micrel: confusion about phyids used in driver
>
>Extern
If IPV6 was disabled, then ss command would cause a kernel warning
because the command was attempting to dump IPV6 socket information.
The fix is to just remove the warning.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=202249
Fixes: 432490f9d455 ("net: ip, diag -- Add diag interface for r
On Tue, Jul 2, 2019 at 2:04 PM Kees Cook wrote:
>
> On Mon, Jul 01, 2019 at 06:59:13PM -0700, Andy Lutomirski wrote:
> > I think I'm understanding your motivation. You're not trying to make
> > bpf() generically usable without privilege -- you're trying to create
> > a way to allow certain users
From: Heiner Kallweit
Date: Tue, 2 Jul 2019 20:46:09 +0200
> It was reported that the GPD MicroPC is broken in a way that no valid
> MAC address can be read from the network chip. The vendor driver deals
> with this by assigning a random MAC address as fallback. So let's do
> the same.
>
> Signe
On 07/02, Stanislav Fomichev wrote:
> On 05/29, Andrii Nakryiko wrote:
> > 0 is a valid FD, so it's better to initialize it to -1, as is done in
> > other places. Also, technically, BTF type ID 0 is valid (it's a VOID
> > type), so it's more reliable to check btf_fd, instead of
> > btf_key_type_id,
From: Heiner Kallweit
Date: Tue, 2 Jul 2019 07:59:17 +0200
> This reverts commit 759d095741721888b6ee51afa74e0a66ce65e974.
>
> The patch was based on a misunderstanding. As Al Viro pointed out [0]
> it's simply wrong on big endian. So let's revert it.
>
> [0] https://marc.info/?t=1562009756
From: Heiner Kallweit
Date: Tue, 2 Jul 2019 18:49:14 +0200
> On 02.07.2019 08:18, Heiner Kallweit wrote:
>>>From 1c8bacf724f1450e5256c68fbff407305faf9cbd Mon Sep 17 00:00:00 2001
>>
>>
>>
>
> Sorry, something went wrong when preparing the commit message. I'll resubmit.
It helps to speak clos
On Fri, Jun 28, 2019 at 08:49:34AM +0800, we...@ucloud.cn wrote:
> From: wenxu
>
> This patch provide a meta to get the bridge vlan proto
>
> nft add rule bridge firewall zones counter meta br_vlan_proto 0x8100
Applied, thanks.
On 7/2/19 3:09 PM, brakmo wrote:
> Adds support for fq's Earliest Departure Time to HBM (Host Bandwidth
> Manager). Includes a new BPF program supporting EDT, and also updates
> corresponding programs.
>
> It will drop packets with an EDT of more than 500us in the future
> unless the packet belo
From: Stephen Hemminger
Date: Mon, 1 Jul 2019 08:23:03 -0700
> @@ -19,9 +19,11 @@ raw_get_hashinfo(const struct inet_diag_req_v2 *r)
> {
> if (r->sdiag_family == AF_INET) {
> return &raw_v4_hashinfo;
> -#if IS_ENABLED(CONFIG_IPV6)
> } else if (r->sdiag_family == AF_INE
On Tue, 2 Jul 2019 23:55:07 +, Saeed Mahameed wrote:
> Hi Dave,
>
> This humble 2 patch series from Shay adds the support for devlink fw
> versions query to mlx5 driver.
>
> In the first patch we implement the needed fw commands to support this
> feature.
> In the 2nd patch we implement the d
From: Petr Machata
Date: Tue, 2 Jul 2019 19:06:47 +
> Before mlxsw_sp1_ptp_packet_finish() sends the packet back, it validates
> whether the corresponding port is still valid. However the condition is
> incorrect: when mlxsw_sp_port == NULL, the code dereferences the port to
> compare it to s
From: Andreas Steinmetz
Date: Sun, 30 Jun 2019 22:46:38 +0200
> This series fixes some bugs in the receive path of macsec. The first
> is a use after free when processing macsec frames with a SecTAG that
> has the TCI E bit set but the C bit clear. In the 2nd bug, the driver
> leaves an invalid c
On Tue, 02 Jul 2019 14:23:47 -0700 (PDT)
David Miller wrote:
> From: Stephen Hemminger
> Date: Mon, 1 Jul 2019 08:23:03 -0700
>
> > @@ -19,9 +19,11 @@ raw_get_hashinfo(const struct inet_diag_req_v2 *r)
> > {
> > if (r->sdiag_family == AF_INET) {
> > return &raw_v4_hashinfo;
>
Hi Taehee,
On Wed, Jul 03, 2019 at 12:20:34AM +0900, Taehee Yoo wrote:
> This patch series fixes several bugs in the gtp module.
thanks a lot for your patches, they are much appreciated.
They look valid to me after a brief initial review.
However, I'm currently on holidays and don't have the ab
From: Xin Long
Date: Tue, 2 Jul 2019 00:57:19 +0800
> Both tipc_udp_enable and tipc_udp_disable are called under rtnl_lock,
> ub->ubsock could never be NULL in tipc_udp_disable and cleanup_bearer,
> so remove the check.
>
> Also remove the one in tipc_udp_enable by adding "free" label.
>
> Sig
From: Eric Dumazet
Date: Mon, 1 Jul 2019 10:48:51 -0700
> A bonding master can be up while best_slave is NULL.
...
> Fixes: e2a7420df2e0 ("bonding/main: convert to using slave printk macros")
> Signed-off-by: Eric Dumazet
> Reported-by: John Sperbeck
Applied, thanks.
On 03/07/2019 00:19, Nikolay Aleksandrov wrote:
> On 02/07/2019 23:47, Andrew Lunn wrote:
>> Hi Nikolay
>>
>> The man page says that the bridge forward_delay is in units of
>> seconds, and should be between 2 and 30.
>>
>> I've tested on a couple of different kernel versions, and this appears
>> to
On 05/29, Andrii Nakryiko wrote:
> 0 is a valid FD, so it's better to initialize it to -1, as is done in
> other places. Also, technically, BTF type ID 0 is valid (it's a VOID
> type), so it's more reliable to check btf_fd, instead of
> btf_key_type_id, to determine if there is any BTF associated w
On Sun, 30 Jun 2019 21:29:33 +0200
Matteo Croce wrote:
> @@ -737,6 +746,14 @@ static int netns_add(int argc, char **argv, bool create)
> }
> close(fd);
>
> + fd = open(tmp_path, O_RDONLY|O_CREAT|O_EXCL, 0);
> + if (fd < 0) {
> + fprintf(stderr, "Cannot create nam
From: René van Dorst
Date: Sat, 29 Jun 2019 14:24:51 +0200
> No reason to error out on a MT7621 device with DDR2 memory when non
> TRGMII mode is selected.
> Only MT7621 DDR2 clock setup is not supported for TRGMII mode.
> But non TRGMII mode doesn't need any special clock setup.
>
> Signed-off-
From: Stefano Brivio
Date: Sat, 29 Jun 2019 19:55:08 +0200
> In commit ee28906fd7a1 ("ipv4: Dump route exceptions if requested") I
> added a counter of per-node dumped routes (including actual routes and
> exceptions), analogous to the existing counter for dumped nodes. Dumping
> exceptions means
From: Xin Long
Date: Tue, 2 Jul 2019 00:54:55 +0800
> For these places are protected by rcu_read_lock, we change from
> rcu_dereference_rtnl to rcu_dereference, as there is no need to
> check if rtnl lock is held.
>
> For these places are protected by rtnl_lock, we change from
> rcu_dereference
From: Neil Horman
Date: Fri, 28 Jun 2019 10:52:06 -0400
> Given that the socket transmit path is an exclusive path (locked via the
> pg_vec_lock mutex), we do not have the ability to increment this counter
> on multiple cpus in parallel. This implementation also seems to have
> the potential to
On Tue, 2 Jul 2019 18:50:31 +, Parav Pandit wrote:
> > > I didn't see any immediate need to report, at the same time didn't
> > > find any reason to treat such port flavours differently than existing
> > > one. It just gives a clear view of the device's eswitch. Might find it
> > > useful durin
On 7/2/19 3:12 PM, Gerd Rausch wrote:
On 02/07/2019 14.18, santosh.shilim...@oracle.com wrote:
On 7/2/19 2:05 PM, Gerd Rausch wrote:
What do you call "RDS_GET_MR" semantics?
Its a blocking socket call. Meaning after this call return to the
user, the key must be valid. With async registration
Open vSwitch provides code to pop an MPLS header to a packet. In
preparation for supporting this in TC, move the pop code to an skb helper
that can be reused.
Remove the, now unused, update_ethertype static function from OvS.
Signed-off-by: John Hurley
Reviewed-by: Jakub Kicinski
Reviewed-by: S
Open vSwitch provides code to push an MPLS header to a packet. In
preparation for supporting this in TC, move the push code to an skb helper
that can be reused.
Signed-off-by: John Hurley
Reviewed-by: Jakub Kicinski
Reviewed-by: Simon Horman
---
include/linux/skbuff.h| 1 +
net/core/skbuf
Open vSwitch allows the updating of an existing MPLS header on a packet.
In preparation for supporting similar functionality in TC, move this to a
common skb helper function.
Signed-off-by: John Hurley
Reviewed-by: Jakub Kicinski
Reviewed-by: Simon Horman
---
include/linux/skbuff.h| 1 +
Currently, TC offers the ability to match on the MPLS fields of a packet
through the use of the flow_dissector_key_mpls struct. However, as yet, TC
actions do not allow the modification or manipulation of such fields.
Add a new module that registers TC action ops to allow manipulation of
MPLS. Thi
This patchset introduces a new TC action module that allows the
manipulation of the MPLS headers of packets. The code impliments
functionality including push, pop, and modify.
Also included are tests for the new funtionality. Note that these will
require iproute2 changes to be submitted soon.
NOT
Add a new series of selftests to verify the functionality of act_mpls in
TC.
Signed-off-by: John Hurley
Reviewed-by: Simon Horman
Acked-by: Jakub Kicinski
---
.../tc-testing/tc-tests/actions/mpls.json | 812 +
1 file changed, 812 insertions(+)
create mode 100644
Adds support for fq's Earliest Departure Time to HBM (Host Bandwidth
Manager). Includes a new BPF program supporting EDT, and also updates
corresponding programs.
It will drop packets with an EDT of more than 500us in the future
unless the packet belongs to a flow with less than 2 packets in fligh
u64_stats_fetch_begin needs to initialize start.
Signed-off-by: Catherine Sullivan
Reported-by: kbuild test robot
---
drivers/net/ethernet/google/gve/gve_ethtool.c | 6 --
drivers/net/ethernet/google/gve/gve_main.c| 6 --
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git
At this point, skb could only be a valid pointer, so this patch does
not introduce any functional change.
Change:
The patch now only moves the IS_ERR(skb) case under the block where
macsec_decrypt() is called, but not the call to macsec_post_decrypt().
Signed-off-by: Andreas Steinmetz
--- a/dr
Remove superfluous skb_share_check() and skb_unshare().
macsec_decrypt is only called by macsec_handle_frame which
already does a skb_unshare().
Signed-off-by: Andreas Steinmetz
--- a/drivers/net/macsec.c 2019-06-30 22:02:54.906908179 +0200
+++ b/drivers/net/macsec.c 2019-06-30 22:03:0
Remove superfluous zeroing of skb pointer for the RX_HANDLER_CONSUMED
case, since in that case, __netif_receive_skb_core will simply ignore
the value.
Signed-off-by: Andreas Steinmetz
--- a/drivers/net/macsec.c 2019-06-30 22:04:10.003613880 +0200
+++ b/drivers/net/macsec.c 2019-06-30 2
This patchset removes some unnecessary code in the receive path of the
macsec driver, and re-indents the error handling after calling
macsec_decrypt to make the post-processing clearer.
This is a combined effort of Sabrina Dubroca and me.
Change in 3/3:
The patch now only moves the IS_ERR(skb)
Hi Dave,
This humble 2 patch series from Shay adds the support for devlink fw
versions query to mlx5 driver.
In the first patch we implement the needed fw commands to support this
feature.
In the 2nd patch we implement the devlink callbacks themselves.
I am not sending this as a pull request sin
From: Shay Agroskin
The callback is invoked using 'devlink dev info ' command and returns
the running and pending firmware version of the HCA and the name of the
kernel driver.
If there is a pending firmware version (a new version is burned but the
HCA still runs with the previous) it is returne
From: Shay Agroskin
Using the MCQI and MCQS registers, we query the running and pending
fw version of the HCA.
The MCQS is queried with sequentially increasing component index, until
a component of type BOOT_IMG is found. Querying this component's version
using the MCQI register yields the runnin
Adds support for fq's Earliest Departure Time to HBM (Host Bandwidth
Manager). Includes a new BPF program supporting EDT, and also updates
corresponding programs.
It will drop packets with an EDT of more than 500us in the future
unless the packet belongs to a flow with less than 2 packets in fligh
On 7/2/19 2:05 PM, Gerd Rausch wrote:
On 02/07/2019 09.49, santosh.shilim...@oracle.com wrote:
On 7/1/19 10:11 PM, Gerd Rausch wrote:
For the registration work-requests there is a benefit to wait a short
amount of time only (the trade-off described in patch #1 of this series).
Actually we sho
On Tue, 2019-07-02 at 10:35 -0400, Willem de Bruijn wrote:
> On Tue, Jul 2, 2019 at 12:25 AM Andreas Steinmetz wrote:
> > On Sun, 2019-06-30 at 21:47 -0400, Willem de Bruijn wrote:
> > > On Sun, Jun 30, 2019 at 4:48 PM Andreas Steinmetz
> > > wrote:
> > > > Fix checksumming after decryption.
> >
From: Willem de Bruijn
skb_warn_bad_offload and netdev_rx_csum_fault trigger on hard to debug
issues. Dump more state and the header.
Optionally dump the entire packet and linear segment. This is required
to debug checksum bugs that may include bytes past skb_tail_pointer().
Both call sites cal
Thank you for the detailed answer, I tried your solution and it works
as expected.
Ido Schimmel ezt írta (időpont: 2019. júl. 2., K, 21:21):
>
> On Tue, Jul 02, 2019 at 08:42:15PM +0200, Zoltán Elek wrote:
> > Hi!
> >
> > I have a simple scenario, with a veth pair, IP addresses assigned from
> >
On Tue, Jul 2, 2019 at 12:19 PM Y Song wrote:
>
> On Fri, Jun 28, 2019 at 8:26 AM Andrii Nakryiko wrote:
> >
> > Change BTF-defined map definitions to capture compile-time integer
> > values as part of BTF type definition, to avoid split of key/value type
> > information and actual type/size/flag
Yonhhong, thank you for the feedbac. Repies inlined. I will submit a new
revision later today.
On 7/1/19, 2:04 PM, "Yonghong Song" wrote:
On 6/28/19 12:41 PM, brakmo wrote:
> Adds support for fq's Earliest Departure Time to HBM (Host Bandwidth
> Manager). Includes a new BPF program
On Thu, Jun 27, 2019 at 1:20 PM Song Liu wrote:
>
> This patch introduce unprivileged BPF access. The access control is
> achieved via device /dev/bpf. Users with write access to /dev/bpf are able
> to call sys_bpf().
>
> Two ioctl command are added to /dev/bpf:
>
> The two commands enable/disable
From: Sudarsana Reddy Kalluru
Date: Tue, 2 Jul 2019 08:04:12 -0700
> The register definition in the header file captures more details on
> the individual bits.
Where is this register definition in the header file and why aren't
CPP defines from there being used instead of a mask constant mask?
On Tue, Jul 02, 2019 at 08:42:15PM +0200, Zoltán Elek wrote:
> Hi!
>
> I have a simple scenario, with a veth pair, IP addresses assigned from
> the same subnet. They can ping eachother. But when I put one of them
> into a VRF (in the example below, I put veth in-vrf into the test-vrf
> VRF) the pi
On Fri, Jun 28, 2019 at 8:26 AM Andrii Nakryiko wrote:
>
> Change BTF-defined map definitions to capture compile-time integer
> values as part of BTF type definition, to avoid split of key/value type
> information and actual type/size/flags initialization for maps.
>
> Signed-off-by: Andrii Nakryi
On Thu, Jun 20, 2019 at 09:49:12PM +0200, Pablo Neira Ayuso wrote:
...
> @@ -1173,8 +1191,10 @@ static int tcf_block_offload_cmd(struct tcf_block
> *block,
> struct tc_block_offload bo = {};
> int err;
>
> + bo.net = dev_net(dev);
> bo.command = command;
> bo.binder_t
On Thu, Jun 20, 2019 at 09:49:07PM +0200, Pablo Neira Ayuso wrote:
> Add a new helper function to allocate tcf_block_cb objects.
>
> Signed-off-by: Pablo Neira Ayuso
> ---
> include/net/pkt_cls.h | 8
> net/sched/cls_api.c | 23 +++
> 2 files changed, 27 insertion
Before mlxsw_sp1_ptp_packet_finish() sends the packet back, it validates
whether the corresponding port is still valid. However the condition is
incorrect: when mlxsw_sp_port == NULL, the code dereferences the port to
compare it to skb->dev.
The condition needs to check whether the port is present
> -Original Message-
> From: Jakub Kicinski
> Sent: Tuesday, July 2, 2019 11:17 PM
> To: Parav Pandit
> Cc: Jiri Pirko ; netdev@vger.kernel.org; Saeed
> Mahameed
> Subject: Re: [PATCH net-next 1/3] devlink: Introduce PCI PF port flavour and
> port attribute
>
> On Tue, 2 Jul 2019 04:2
It was reported that the GPD MicroPC is broken in a way that no valid
MAC address can be read from the network chip. The vendor driver deals
with this by assigning a random MAC address as fallback. So let's do
the same.
Signed-off-by: Heiner Kallweit
---
v2:
- fix broken commit message
---
drive
Hi!
I have a simple scenario, with a veth pair, IP addresses assigned from
the same subnet. They can ping eachother. But when I put one of them
into a VRF (in the example below, I put veth in-vrf into the test-vrf
VRF) the ping fails. My first question: that is the expected behavior?
And my second
The progs for bpf selftests use several different notations to force
function inlining. Standardize to what most of them use,
static __always_inline.
Suggested-by: Song Liu
Signed-off-by: Jiri Benc
---
tools/testing/selftests/bpf/progs/pyperf.h| 9 +++--
.../testing/selftests/bpf/progs/str
On Tue, Jul 2, 2019 at 10:41 AM Jiri Benc wrote:
>
> Selftests are reporting this failure in test_lwt_seg6local.sh:
>
> + ip netns exec ns2 ip -6 route add fb00::6 encap bpf in obj
> test_lwt_seg6local.o sec encap_srh dev veth2
> Error fetching program/map!
> Failed to parse eBPF program: Operati
On Tue, Jul 2, 2019 at 9:14 AM Stanislav Fomichev wrote:
>
> Congestion control team would like to have a periodic callback to
> track some TCP statistics. Let's add a sock_ops callback that can be
> selectively enabled on a socket by socket basis and is executed for
> every RTT. BPF program frequ
On Tue, Jul 2, 2019 at 8:40 AM Ilya Leoshkevich wrote:
>
> Use PT_REGS_RC(ctx) instead of ctx->rax, which is not present on s390.
>
> Pass -D__TARGET_ARCH_$(ARCH) to selftests in order to choose a proper
> PT_REGS_RC variant.
>
> Fix s930 -> s390 typo.
>
> On s390, provide the forward declaration
On Tue, Jul 2, 2019 at 9:58 AM Ilya Leoshkevich wrote:
>
> > Am 02.07.2019 um 18:42 schrieb Y Song :
> >
> > On Tue, Jul 2, 2019 at 8:40 AM Ilya Leoshkevich wrote:
> >>
> >> -#elif defined(__s390x__)
> >> - #define bpf_target_s930x
> >
> > I see in some other places (e.g., bcc) where
> > ma
On Tue, 2 Jul 2019 04:26:47 +, Parav Pandit wrote:
> > On Mon, 1 Jul 2019 07:27:32 -0500, Parav Pandit wrote:
> > > In an eswitch, PCI PF may have port which is normally represented
> > > using a representor netdevice.
> > > To have better visibility of eswitch port, its association with PF,
Currently, gratuitous ARP/ND packets are sent every `miimon'
milliseconds. This commit allows a user to specify a custom delay
through a new option, `peer_notif_delay'.
Like for `updelay' and `downdelay', this delay should be a multiple of
`miimon' to avoid managing an additional work queue. The c
Selftests are reporting this failure in test_lwt_seg6local.sh:
+ ip netns exec ns2 ip -6 route add fb00::6 encap bpf in obj
test_lwt_seg6local.o sec encap_srh dev veth2
Error fetching program/map!
Failed to parse eBPF program: Operation not permitted
The problem is __attribute__((always_inline))
On Tue, 2 Jul 2019 09:48:43 -0700, Takshak Chahande wrote:
> + cgroup_fd = open(cgroup_path, O_RDONLY);
> if (cgroup_fd < 0) {
> - p_err("can't open cgroup %s", argv[1]);
> + p_err("can't open cgroup %s", cgroup_path);
AFAICS the bpf tree has not been merged into
On Mon, 1 Jul 2019 11:39:27 -0700, Y Song wrote:
> By default, we have
> # define __always_inlineinline __attribute__((always_inline))
>
> So just use __always_inline should be less verbose in your patch.
I'll resubmit, converting everything to __always_inline, targeting
bpf-next.
> BTW,
> -Original Message-
> From: Andrew Lunn
> Sent: Tuesday, July 2, 2019 10:19 PM
> To: Parav Pandit
> Cc: Sudarsana Reddy Kalluru ; da...@davemloft.net;
> netdev@vger.kernel.org; mkalde...@marvell.com; ael...@marvell.com;
> j...@resnulli.us
> Subject: Re: [PATCH net-next 1/1] devlink: A
1 - 100 of 191 matches
Mail list logo
