> -----Original Message-----
> From: Parav Pandit <pa...@mellanox.com>
> Sent: Tuesday, July 2, 2019 10:49 PM
> To: Andrew Lunn <and...@lunn.ch>
> Cc: Sudarsana Reddy Kalluru <skall...@marvell.com>;
> da...@davemloft.net; netdev@vger.kernel.org; Michal Kalderon
> <mkalde...@marvell.com>; Ariel Elior <ael...@marvell.com>;
> j...@resnulli.us
> Subject: [EXT] RE: [PATCH net-next 1/1] devlink: Add APIs to
> publish/unpublish the port parameters.
>
> External Email
>
> ----------------------------------------------------------------------
>
>
> > -----Original Message-----
> > From: Andrew Lunn <and...@lunn.ch>
> > Sent: Tuesday, July 2, 2019 10:19 PM
> > To: Parav Pandit <pa...@mellanox.com>
> > Cc: Sudarsana Reddy Kalluru <skall...@marvell.com>;
> > da...@davemloft.net; netdev@vger.kernel.org;
> mkalde...@marvell.com;
> > ael...@marvell.com; j...@resnulli.us
> > Subject: Re: [PATCH net-next 1/1] devlink: Add APIs to
> > publish/unpublish the port parameters.
> >
> > > A vendor driver calling these APIs is needed at minimum.
> >
> > Not a vendor driver, but a mainline driver.
> >
> My apologies for terminology.
> I meant to say that a NIC/hw driver from the kernel tree that created the
> devlink port should call this API (as user) in the patch.
> You said it rightly below. Thanks.
>
> > But yes, a new API should not be added without at least one user.
> >
> > Andrew
Thanks a lot for your reviews.
Marvell NIC driver has a requirement to support the display/configuration of
device attributes. Sent the proposed changes with following 'subject line',
[PATCH net-next 4/4] qed: Add devlink support for configuration attributes.
Have received a comment (from community) suggesting to move some of the
attributes to devlink-port interface, which
requires the proposed APIs.
Will update the commit message and send it with the Marvel driver patch series
which use this functionality.
