Re: [PATCH 2/3 nf-next] netfilter:nf_flow_table: Support bridge type flow offload

2019-06-26 Thread wenxu
On 6/27/2019 3:19 AM, Florian Westphal wrote: > Florian Westphal wrote: >> we...@ucloud.cn wrote: >>> diff --git a/net/netfilter/nf_flow_table_ip.c >>> b/net/netfilter/nf_flow_table_ip.c >>> index 0016bb8..9af01ef 100644 >>> --- a/net/netfilter/nf_flow_table_ip.c >>> +++ b/net/netfilter/nf_flo

Re: [for-next V2 09/10] RDMA/nldev: Added configuration of RDMA dynamic interrupt moderation to netlink

2019-06-26 Thread Yamin Friedman
On 6/26/2019 12:15 AM, Sagi Grimberg wrote: > > > On 6/25/19 1:57 PM, Saeed Mahameed wrote: >> From: Yamin Friedman >> >> Added parameter in ib_device for enabling dynamic interrupt >> moderation so >> that it can be configured in userspace using rdma tool. >> >> In order to set dim for an ib de

Re: [for-next V2 10/10] RDMA/core: Provide RDMA DIM support for ULPs

2019-06-26 Thread Yamin Friedman
On 6/26/2019 12:14 AM, Sagi Grimberg wrote: > > >> +static int ib_poll_dim_handler(struct irq_poll *iop, int budget) >> +{ >> +    struct ib_cq *cq = container_of(iop, struct ib_cq, iop); >> +    struct dim *dim = cq->dim; >> +    int completed; >> + >> +    completed = __ib_process_cq(cq, budget,

Re: [for-next V2 08/10] linux/dim: Implement rdma_dim

2019-06-26 Thread Yamin Friedman
On 6/26/2019 1:02 AM, Sagi Grimberg wrote: > >> +void rdma_dim(struct dim *dim, u64 completions) >> +{ >> +    struct dim_sample *curr_sample = &dim->measuring_sample; >> +    struct dim_stats curr_stats; >> +    u32 nevents; >> + >> +    dim_update_sample_with_comps(curr_sample->event_ctr + 1, >>

Re: dm9601: incorrect datasheet URL

2019-06-26 Thread Corentin Labbe
On Wed, Jun 26, 2019 at 04:12:48PM +0200, Arkadiusz Drabczyk wrote: > http://ptm2.cc.utu.fi/ftp/network/cards/DM9601/From_NET/DM9601-DS-P01-930914.pdf > is gone. In fact, document titled `DM9601-DS-P01-930914.pdf' is > nowhere to be found online these days but there is > http://pdf.datasheet.live/7

[PATCH] net: dsa: mv88e6xxx: wait after reset deactivation

2019-06-26 Thread Baruch Siach
Add a 1ms delay after reset deactivation. Otherwise the chip returns bogus ID value. This is observed with 88E6390 (Peridot) chip. Signed-off-by: Baruch Siach --- drivers/net/dsa/mv88e6xxx/chip.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/d

Re: [PATCH net] sctp: not bind the socket in sctp_connect

2019-06-26 Thread Marcelo Ricardo Leitner
On Wed, Jun 26, 2019 at 04:31:39PM +0800, Xin Long wrote: > Now when sctp_connect() is called with a wrong sa_family, it binds > to a port but doesn't set bp->port, then sctp_get_af_specific will > return NULL and sctp_connect() returns -EINVAL. > > Then if sctp_bind() is called to bind to another

Re: [PATCH bpf-next] virtio_net: add XDP meta data support in receive_small()

2019-06-26 Thread Jason Wang
On 2019/6/27 上午10:33, Yuya Kusakabe wrote: This adds XDP meta data support to the code path receive_small(). mrg_rxbuf=off is required on qemu, because receive_mergeable() still doesn't support XDP meta data. What's the reason for this? Fixes: de8f3a83b0a0 ("bpf: add meta pointer for di

Re: [PATCH v4 net] af_packet: Block execution of tasks waiting for transmit to complete in AF_PACKET

2019-06-26 Thread David Miller
From: Neil Horman Date: Tue, 25 Jun 2019 17:57:49 -0400 > When an application is run that: > a) Sets its scheduler to be SCHED_FIFO > and > b) Opens a memory mapped AF_PACKET socket, and sends frames with the > MSG_DONTWAIT flag cleared, its possible for the application to hang > forever in the k

[PATCH bpf-next] virtio_net: add XDP meta data support in receive_small()

2019-06-26 Thread Yuya Kusakabe
This adds XDP meta data support to the code path receive_small(). mrg_rxbuf=off is required on qemu, because receive_mergeable() still doesn't support XDP meta data. Fixes: de8f3a83b0a0 ("bpf: add meta pointer for direct access") Signed-off-by: Yuya Kusakabe --- drivers/net/virtio_net.c | 10 ++

Re: [PATCH net] sctp: change to hold sk after auth shkey is created successfully

2019-06-26 Thread David Miller
From: Xin Long Date: Tue, 25 Jun 2019 00:21:45 +0800 > Now in sctp_endpoint_init(), it holds the sk then creates auth > shkey. But when the creation fails, it doesn't release the sk, > which causes a sk defcnf leak, > > Here to fix it by only holding the sk when auth shkey is created > successfu

[PATCH 1/2 nf-next] netfilter: nft_meta: add NFT_META_BRI_VLAN_PROTO support

2019-06-26 Thread wenxu
From: wenxu This patch provide a meta to get the bridge vlan proto nft add rule bridge firewall zones counter meta br_vlan_proto 0x8100 Signed-off-by: wenxu --- include/uapi/linux/netfilter/nf_tables.h | 2 ++ net/netfilter/nft_meta.c | 9 + 2 files changed, 11 inserti

[PATCH 2/2 nf-next] netfilter:nft_meta: add NFT_META_VLAN support

2019-06-26 Thread wenxu
From: wenxu This patch provide a meta vlan to set the vlan tag of the packet. for q-in-q vlan id 20: meta vlan set 0x88a8:20 set the default 0x8100 vlan type with vlan id 20 meta vlan set 20 Signed-off-by: wenxu --- include/uapi/linux/netfilter/nf_tables.h | 4 net/netfilter/nft_meta.c

Re: [PATCH bpf-next 1/4] bpf: unprivileged BPF access via /dev/bpf

2019-06-26 Thread Song Liu
> On Jun 26, 2019, at 5:08 PM, Greg KH wrote: > > On Wed, Jun 26, 2019 at 03:17:47PM +, Song Liu wrote: +static struct miscdevice bpf_dev = { + .minor = MISC_DYNAMIC_MINOR, + .name = "bpf", + .fops = &bpf_chardev_ops, + .mode

Re: [PATCH mlx5-next v1 02/12] net/mlx5: Use event mask based on device capabilities

2019-06-26 Thread Saeed Mahameed
On Tue, 2019-06-18 at 20:15 +0300, Leon Romanovsky wrote: > From: Yishai Hadas > > Use the reported device capabilities for the supported user events > (i.e. > affiliated and un-affiliated) to set the EQ mask. > > As the event mask can be up to 256 defined by 4 entries of u64 change > the applic

Re: [PATCH bpf-next 1/4] bpf: unprivileged BPF access via /dev/bpf

2019-06-26 Thread Greg KH
On Wed, Jun 26, 2019 at 03:17:47PM +, Song Liu wrote: > >> +static struct miscdevice bpf_dev = { > >> + .minor = MISC_DYNAMIC_MINOR, > >> + .name = "bpf", > >> + .fops = &bpf_chardev_ops, > >> + .mode = 0440, > >> + .nodename = "bpf", > > > > H

Re: [PATCH net-next] gso: enable udp gso for virtual devices

2019-06-26 Thread Willem de Bruijn
On Wed, Jun 26, 2019 at 3:17 PM Jason Baron wrote: > > > > On 6/14/19 4:53 PM, Jason Baron wrote: > > > > > > On 6/13/19 5:20 PM, Willem de Bruijn wrote: > > @@ -237,6 +237,7 @@ static inline int find_next_netdev_feature(u64 > > feature, unsigned long start) > >

Re: [PATCH net-next 0/2] net: ipv4: remove erroneous advancement of list pointer

2019-06-26 Thread Florian Westphal
Ran Rozenstein wrote: > The test dose stress on the interface by running this 2 commands in loop: > > command is: /sbin/ip -f inet addr add $IP/16 brd + dev ens8f1 > command is: ifconfig ens8f1 $IP netmask 255.255.0.0 > > when $IP change every iteration. > > It execute every second when we see

Re: [PATCH] bonding: Always enable vlan tx offload

2019-06-26 Thread Michał Mirosław
On Wed, Jun 26, 2019 at 06:48:53PM +0200, Jiri Pirko wrote: > Wed, Jun 26, 2019 at 06:13:38PM CEST, mirq-li...@rere.qmqm.pl wrote: > >On Wed, Jun 26, 2019 at 04:08:44PM +0800, YueHaibing wrote: [...] > >> This patch always enable bonding's vlan tx offload, pass the vlan > >> packets to the slave de

[PATCH bpf-next 1/3] libbpf: capture value in BTF type info for BTF-defined map defs

2019-06-26 Thread Andrii Nakryiko
Change BTF-defined map definitions to capture compile-time integer values as part of BTF type definition, to avoid split of key/value type information and actual type/size/flags initialization for maps. Signed-off-by: Andrii Nakryiko --- tools/lib/bpf/libbpf.c| 58 +++

[PATCH bpf-next 2/3] selftests/bpf: convert selftests using BTF-defined maps to new syntax

2019-06-26 Thread Andrii Nakryiko
Convert all the existing selftests that are already using BTF-defined maps to use new syntax (with no static data initialization). Signed-off-by: Andrii Nakryiko --- tools/testing/selftests/bpf/progs/bpf_flow.c | 28 +++ .../testing/selftests/bpf/progs/netcnt_prog.c | 20 ++--- .../selftest

[PATCH bpf-next 3/3] selftests/bpf: convert legacy BPF maps to BTF-defined ones

2019-06-26 Thread Andrii Nakryiko
Convert selftests that were originally left out and new ones added recently to consistently use BTF-defined maps. Signed-off-by: Andrii Nakryiko --- .../selftests/bpf/progs/get_cgroup_id_kern.c | 26 ++--- tools/testing/selftests/bpf/progs/pyperf.h| 90 +++--- .../selftests/bpf/pr

[PATCH bpf-next 0/3] capture integers in BTF type info for map defs

2019-06-26 Thread Andrii Nakryiko
This patch set implements an update to how BTF-defined maps are specified. The change is in how integer attributes, e.g., type, max_entries, map_flags, are specified: now they are captured as part of map definition struct's BTF type information (using array dimension), eliminating the need for comp

Re: [net-next 1/4] gve: Add basic driver framework for Compute Engine Virtual NIC

2019-06-26 Thread Jakub Kicinski
On Wed, 26 Jun 2019 11:52:48 -0700, Catherine Sullivan wrote: > Add a driver framework for the Compute Engine Virtual NIC that will be > available in the future. > > At this point the only functionality is loading the driver. > > Signed-off-by: Catherine Sullivan > Signed-off-by: Sagi Shahar >

Re: [PATCH v2 bpf-next 2/3] libbpf: auto-set PERF_EVENT_ARRAY size to number of CPUs

2019-06-26 Thread Andrii Nakryiko
On Wed, Jun 26, 2019 at 11:57 AM Song Liu wrote: > > > > > On Jun 25, 2019, at 11:12 PM, Andrii Nakryiko wrote: > > > > For BPF_MAP_TYPE_PERF_EVENT_ARRAY typically correct size is number of > > possible CPUs. This is impossible to specify at compilation time. This > > change adds automatic settin

Re: [PATCH v2 bpf-next 3/7] libbpf: add kprobe/uprobe attach API

2019-06-26 Thread Andrii Nakryiko
On Wed, Jun 26, 2019 at 7:25 AM Daniel Borkmann wrote: > > On 06/21/2019 06:55 AM, Andrii Nakryiko wrote: > > Add ability to attach to kernel and user probes and retprobes. > > Implementation depends on perf event support for kprobes/uprobes. > > > > Signed-off-by: Andrii Nakryiko > > --- > >

Re: [PATCH net] net/sched: flower: fix infinite loop in fl_walk()

2019-06-26 Thread Cong Wang
Hi, Davide On Tue, Jun 25, 2019 at 12:29 PM Cong Wang wrote: > It should handle this overflow case more gracefully, I hope. > Please try this attached one and let me know if it works. Hope I get it right this time. Thanks! idr_get_next_ul.patch Description: Binary data

Re: [PATCH v2 bpf-next 0/3] libbpf: add perf buffer abstraction and API

2019-06-26 Thread Toke Høiland-Jørgensen
Andrii Nakryiko writes: > On Wed, Jun 26, 2019 at 4:55 AM Toke Høiland-Jørgensen > wrote: >> >> Andrii Nakryiko writes: >> >> > This patchset adds a high-level API for setting up and polling perf buffers >> > associated with BPF_MAP_TYPE_PERF_EVENT_ARRAY map. Details of APIs are >> > described

Re: [PATCH net-next 0/2] net: ipv4: remove erroneous advancement of list pointer

2019-06-26 Thread Florian Westphal
Ran Rozenstein wrote: > The test dose stress on the interface by running this 2 commands in loop: > > command is: /sbin/ip -f inet addr add $IP/16 brd + dev ens8f1 > command is: ifconfig ens8f1 $IP netmask 255.255.0.0 > > when $IP change every iteration. > > It execute every second when we see

Re: [PATCH bpf-next V6 00/16] AF_XDP infrastructure improvements and mlx5e support

2019-06-26 Thread Daniel Borkmann
On 06/26/2019 04:35 PM, Tariq Toukan wrote: [...] > v6 changes: > > As Maxim is out of office, I rebased the series on behalf of him, > solved some conflicts, and re-spinned. Thanks for taking over the rebase, Tariq! > Series generated against bpf-next commit: > 572a6928f9e3 xdp: Make __mem_id_d

Re: [PATCH net v2 0/2] ipv6: fix neighbour resolution with raw socket

2019-06-26 Thread David Miller
From: Nicolas Dichtel Date: Mon, 24 Jun 2019 16:01:07 +0200 > The first patch prepares the fix, it constify rt6_nexthop(). > The detail of the bug is explained in the second patch. > > v1 -> v2: > - fix compilation warnings > - split the initial patch Series applied, thanks Nicolas.

Re: [EXT] [PATCH V2] bnx2x: Prevent ptp_task to be rescheduled indefinitely

2019-06-26 Thread Guilherme Piccoli
On Wed, Jun 26, 2019 at 5:25 AM Sudarsana Reddy Kalluru wrote: > > Sudarsana, let me ask you something: why does the register is reading value > > 0x0 always in the TX timestamp routine if the RX filter is set to None? > > This is > > the main cause of the thread reschedule thing. > > The registe

Re: [PATCH V2] net: dsa: microchip: Use gpiod_set_value_cansleep()

2019-06-26 Thread David Miller
From: Marek Vasut Date: Sun, 23 Jun 2019 17:12:57 +0200 > Replace gpiod_set_value() with gpiod_set_value_cansleep(), as the switch > reset GPIO can be connected to e.g. I2C GPIO expander and it is perfectly > fine for the kernel to sleep for a bit in ksz_switch_register(). > > Signed-off-by: Mar

Re: [PATCH net-next 1/1] Allow 0.0.0.0/8 as a valid address range

2019-06-26 Thread David Miller
From: Dave Taht Date: Sat, 22 Jun 2019 10:07:34 -0700 > The longstanding prohibition against using 0.0.0.0/8 dates back > to two issues with the early internet. > > There was an interoperability problem with BSD 4.2 in 1984, fixed in > BSD 4.3 in 1986. BSD 4.2 has long since been retired. > >

[PATCH V3] bnx2x: Prevent ptp_task to be rescheduled indefinitely

2019-06-26 Thread Guilherme G. Piccoli
Currently bnx2x ptp worker tries to read a register with timestamp information in case of TX packet timestamping and in case it fails, the routine reschedules itself indefinitely. This was reported as a kworker always at 100% of CPU usage, which was narrowed down to be bnx2x ptp_task. By following

Re: [PATCH net] net: aquantia: fix vlans not working over bridged network

2019-06-26 Thread David Miller
From: Igor Russkikh Date: Sat, 22 Jun 2019 08:46:37 + > From: Dmitry Bogdanov > > In configuration of vlan over bridge over aquantia device > it was found that vlan tagged traffic is dropped on chip. > > The reason is that bridge device enables promisc mode, > but in atlantic chip vlan fil

Re: [PATCH net-next] rtnetlink: skip metrics loop for dst_default_metrics

2019-06-26 Thread David Miller
From: David Ahern Date: Fri, 21 Jun 2019 16:27:16 -0700 > From: David Ahern > > dst_default_metrics has all of the metrics initialized to 0, so nothing > will be added to the skb in rtnetlink_put_metrics. Avoid the loop if > metrics is from dst_default_metrics. > > Signed-off-by: David Ahern

Re: [PATCH net-next v6 1/8] igb: clear out skb->tstamp after reading the txtime

2019-06-26 Thread Patel, Vedang
Hi Jeff, > On Jun 26, 2019, at 12:44 PM, Kirsher, Jeffrey T > wrote: > > On Tue, 2019-06-25 at 15:07 -0700, Vedang Patel wrote: >> If a packet which is utilizing the launchtime feature (via SO_TXTIME >> socket >> option) also requests the hardware transmit timestamp, the hardware >> timestamp i

Re: XDP multi-buffer incl. jumbo-frames (Was: [RFC V1 net-next 1/1] net: ena: implement XDP drop support)

2019-06-26 Thread Jesper Dangaard Brouer
On Wed, 26 Jun 2019 09:42:07 -0700 "Jonathan Lemon" wrote: > If all packets are collected together (like the bulk queue does), and > then passed to XDP, this could easily be made backwards compatible. > If the XDP program isn't 'multi-frag' aware, then each packet is just > passed in individu

Re: [net-next 2/4] gve: Add transmit and receive support

2019-06-26 Thread David Miller
From: Catherine Sullivan Date: Wed, 26 Jun 2019 11:52:49 -0700 > +#ifdef __LITTLE_ENDIAN > +#define GVE_SEQNO(x) __force u16)x) >> 8) & 0x7) > +#else > +#define GVE_SEQNO(x) ((__force u16)(x) & 0x7) > +#endif This can be simply "le16_to_cpu(x) & 0x7" or similar. No need to messy ifdefs

Re: [net-next 4/4] gve: Add ethtool support

2019-06-26 Thread Andrew Lunn
> +static int gve_get_sset_count(struct net_device *netdev, int sset) > +{ > + struct gve_priv *priv = netdev_priv(netdev); > + > + if (!netif_carrier_ok(netdev)) > + return 0; That is pretty unusual. What goes wrong if there is no carrier and statistics are returned? > +stati

Re: [PATCH net-next v6 1/8] igb: clear out skb->tstamp after reading the txtime

2019-06-26 Thread Jeff Kirsher
On Tue, 2019-06-25 at 15:07 -0700, Vedang Patel wrote: > If a packet which is utilizing the launchtime feature (via SO_TXTIME > socket > option) also requests the hardware transmit timestamp, the hardware > timestamp is not delivered to the userspace. This is because the > value in > skb->tstamp is

Re: [net-next 2/4] gve: Add transmit and receive support

2019-06-26 Thread Andrew Lunn
> +static int gve_change_mtu(struct net_device *dev, int new_mtu) > +{ > + dev->mtu = new_mtu; > + return 0; > +} The default implementation does this. Also, i think your mtu has a limit of PAGE size. So you should set the dev->max_mtu so the core will enforce this. Andrew

Re: [PATCH net v2] ipv4: reset rt_iif for recirculated mcast/bcast out pkts

2019-06-26 Thread David Miller
From: Stephen Suryaputra Date: Wed, 26 Jun 2019 02:21:16 -0400 > Multicast or broadcast egress packets have rt_iif set to the oif. These > packets might be recirculated back as input and lookup to the raw > sockets may fail because they are bound to the incoming interface > (skb_iif). If rt_iif i

Re: eBPF verifier slowness, more than 2 cpu seconds for about 600 instructions

2019-06-26 Thread Alexei Starovoitov
On Tue, Jun 18, 2019 at 2:40 PM Alexei Starovoitov wrote: > > On Mon, Jun 17, 2019 at 11:26:28AM -0700, Alexei Starovoitov wrote: > > On Sun, Jun 16, 2019 at 11:59 PM Alexei Starovoitov > > wrote: > > > > > > On Thu, Jun 6, 2019 at 6:31 PM Andreas Steinmetz wrote: > > > > > > > > Below is the so

Re: [net-next 1/4] gve: Add basic driver framework for Compute Engine Virtual NIC

2019-06-26 Thread Andrew Lunn
On Wed, Jun 26, 2019 at 11:52:48AM -0700, Catherine Sullivan wrote: > Add a driver framework for the Compute Engine Virtual NIC that will be > available in the future. > > +static int __init gvnic_init_module(void) > +{ > + return pci_register_driver(&gvnic_driver); > +} > + > +static void __e

[net-next 02/10] ixgbevf: fix possible divide by zero in ixgbevf_update_itr

2019-06-26 Thread Jeff Kirsher
From: Young Xiao <92siuy...@gmail.com> The next call to ixgbevf_update_itr will continue to dynamically update ITR. Copy from commit bdbeefe8ea8c ("ixgbe: fix possible divide by zero in ixgbe_update_itr") Signed-off-by: Young Xiao <92siuy...@gmail.com> Tested-by: Andrew Bowers Signed-off-by: Je

[net-next 05/10] i40e: fix incorrect function documentation comment

2019-06-26 Thread Jeff Kirsher
From: Jacob Keller Signed-off-by: Jacob Keller Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_ptp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_ptp.c b/drivers/net/ethernet/intel/i40

[net-next 08/10] i40e: Fix descriptor count manipulation

2019-06-26 Thread Jeff Kirsher
From: Maciej Fijalkowski Changing descriptor count via 'ethtool -G' is not persistent across resets. When PF reset occurs, we roll back to the default value of vsi->num_desc, which is used then in i40e_alloc_rings to set descriptor count. XDP does a PF reset so when user has changed the descripto

[net-next 00/10][pull request] Intel Wired LAN Driver Updates 2019-06-26

2019-06-26 Thread Jeff Kirsher
This series contains updates to ixgbe and i40e only. Mauro S. M. Rodrigues update the ixgbe driver to handle transceivers who comply with SFF-8472 but do not implement the Digital Diagnostic Monitoring (DOM) interface. Update the driver to check the necessary bits to see if DOM is implemented bef

[net-next 06/10] i40e: Add log entry while creating or deleting TC0

2019-06-26 Thread Jeff Kirsher
From: Piotr Kwapulinski Generate log entry when TC0 is created or deleted. Log entry is generated during main VSI setup. Before there was no log info about adding or deleting TC0. Signed-off-by: Piotr Kwapulinski Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/i

[net-next 09/10] i40e: update copyright string

2019-06-26 Thread Jeff Kirsher
From: Alice Michael It was found that the string that prints our copyright was not up to date. Updating to reflect our copyright. Signed-off-by: Alice Michael Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +- 1 file changed, 1 inser

[net-next 03/10] i40e: fix 'Unknown bps' in dmesg for 2.5Gb/5Gb speeds

2019-06-26 Thread Jeff Kirsher
From: Aleksandr Loktionov This patch fixes 'NIC Link is Up, Unknown bps' message in dmesg for 2.5Gb/5Gb speeds. This problem is fixed by adding constants for VIRTCHNL_LINK_SPEED_2_5GB and VIRTCHNL_LINK_SPEED_5GB cases in the i40e_virtchnl_link_speed() function. Signed-off-by: Aleksandr Loktionov

[net-next 10/10] i40e/i40e_virtchnl_pf: Use struct_size() in kzalloc()

2019-06-26 Thread Jeff Kirsher
From: "Gustavo A. R. Silva" One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example: struct virtchnl_iwarp_qvlist_info { ... s

[net-next 07/10] i40e: missing priorities for any QoS traffic

2019-06-26 Thread Jeff Kirsher
From: Aleksandr Loktionov This patch fixes reading f/w LLDP agent status at DCB init time. It's done by removing direct NVM reading in i40e_update_dcb_config() and checking whether f/w LLDP agent is disabled via I40E_FLAG_DISABLE_FW_LLDP flag in i40e_init_pf_dcb(). The function i40e_update_dcb_co

[net-next 04/10] i40e: Fix for missing "link modes" info in ethtool

2019-06-26 Thread Jeff Kirsher
From: Martyna Szapar Fix for missing "Supported link modes" and "Advertised link modes" info in ethtool after changed speed on X722 devices with BASE-T PHY with FW API version >= 1.7. The same FW API version on X710 and X722 does not mean the same feature set so the change was needed as mac type

[net-next 01/10] ixgbe: Check DDM existence in transceiver before access

2019-06-26 Thread Jeff Kirsher
From: "Mauro S. M. Rodrigues" Some transceivers may comply with SFF-8472 but not implement the Digital Diagnostic Monitoring (DDM) interface described in it. The existence of such area is specified by bit 6 of byte 92, set to 1 if implemented. Currently, due to not checking this bit ixgbe fails

Re: [PATCH bpf-next v8 1/9] bpf: implement getsockopt and setsockopt hooks

2019-06-26 Thread Alexei Starovoitov
On Wed, Jun 26, 2019 at 12:10:21PM -0700, Stanislav Fomichev wrote: > On 06/26, Alexei Starovoitov wrote: > > On Mon, Jun 24, 2019 at 09:24:21AM -0700, Stanislav Fomichev wrote: > > > Implement new BPF_PROG_TYPE_CGROUP_SOCKOPT program type and > > > BPF_CGROUP_{G,S}ETSOCKOPT cgroup hooks. > > > >

Re: [PATCH 2/3 nf-next] netfilter:nf_flow_table: Support bridge type flow offload

2019-06-26 Thread Florian Westphal
Florian Westphal wrote: > we...@ucloud.cn wrote: > > diff --git a/net/netfilter/nf_flow_table_ip.c > > b/net/netfilter/nf_flow_table_ip.c > > index 0016bb8..9af01ef 100644 > > --- a/net/netfilter/nf_flow_table_ip.c > > +++ b/net/netfilter/nf_flow_table_ip.c > > - neigh_xmit(NEIGH_ARP_TABLE, ou

Re: [PATCH net-next] gso: enable udp gso for virtual devices

2019-06-26 Thread Jason Baron
On 6/14/19 4:53 PM, Jason Baron wrote: > > > On 6/13/19 5:20 PM, Willem de Bruijn wrote: > @@ -237,6 +237,7 @@ static inline int find_next_netdev_feature(u64 > feature, unsigned long start) > NETIF_F_GSO_GRE_CSUM | \ >

Re: [PATCH bpf-next v8 1/9] bpf: implement getsockopt and setsockopt hooks

2019-06-26 Thread Stanislav Fomichev
On 06/26, Alexei Starovoitov wrote: > On Mon, Jun 24, 2019 at 09:24:21AM -0700, Stanislav Fomichev wrote: > > Implement new BPF_PROG_TYPE_CGROUP_SOCKOPT program type and > > BPF_CGROUP_{G,S}ETSOCKOPT cgroup hooks. > > > > BPF_CGROUP_SETSOCKOPT get a read-only view of the setsockopt arguments. > >

Re: [PATCH 1/1] mlx5: Fix build when CONFIG_MLX5_EN_RXNFC is disabled

2019-06-26 Thread Saeed Mahameed
On Tue, 2019-06-25 at 14:08 -0700, David Miller wrote: > From: Saeed Mahameed > Date: Tue, 25 Jun 2019 21:01:58 + > > > BTW is there a way to clear up "Awaiting Upstream" clutter [1] for > > mlx5 > > patches that are already pulled ? > > > > [1] > > https://patchwork.ozlabs.org/project/netd

Re: [PATCH V2 mlx5-next 00/13] Mellanox, mlx5 vport metadata matching

2019-06-26 Thread Saeed Mahameed
On Tue, 2019-06-25 at 17:47 +, Saeed Mahameed wrote: > This series includes mlx5 updates for both rdma and net-next trees. > In case of no objection it will be applied to mlx5-next branch and > later > on will be sent as pull request to rdma and net-next. > > From Jianbo, Vport meta data match

[RFC iproute2 1/1] ip: netns: add mounted state file for each netns

2019-06-26 Thread Alexander Aring
This patch adds a state file for each generated namespace to ensure the namespace is mounted. There exists no way to tell another programm that the namespace is mounted when iproute is creating one. An example application would be an inotify watcher to use the generated namespace when it's discover

[RFC iproute2 0/1] iproute2 netns mount race issue and solution?

2019-06-26 Thread Alexander Aring
Hi, We found an issue how we can react on namespaces created by iproute2. As state of the current Linux kernel there exists no way to get events on new mounts. Polling is not an option because you can miss mounts. It's an RFC to see that might people seeing the same issue here and would like to t

Re: [PATCH v2 bpf-next 1/3] libbpf: add perf buffer API

2019-06-26 Thread Song Liu
> On Jun 25, 2019, at 11:12 PM, Andrii Nakryiko wrote: > > BPF_MAP_TYPE_PERF_EVENT_ARRAY map is often used to send data from BPF program > to user space for additional processing. libbpf already has very low-level API > to read single CPU perf buffer, bpf_perf_event_read_simple(), but it's har

Re: [PATCH v2 bpf-next 2/3] libbpf: auto-set PERF_EVENT_ARRAY size to number of CPUs

2019-06-26 Thread Song Liu
> On Jun 25, 2019, at 11:12 PM, Andrii Nakryiko wrote: > > For BPF_MAP_TYPE_PERF_EVENT_ARRAY typically correct size is number of > possible CPUs. This is impossible to specify at compilation time. This > change adds automatic setting of PERF_EVENT_ARRAY size to number of > system CPUs, unless

Re: [PATCH bpf-next v8 1/9] bpf: implement getsockopt and setsockopt hooks

2019-06-26 Thread Alexei Starovoitov
On Mon, Jun 24, 2019 at 09:24:21AM -0700, Stanislav Fomichev wrote: > Implement new BPF_PROG_TYPE_CGROUP_SOCKOPT program type and > BPF_CGROUP_{G,S}ETSOCKOPT cgroup hooks. > > BPF_CGROUP_SETSOCKOPT get a read-only view of the setsockopt arguments. > BPF_CGROUP_GETSOCKOPT can modify the supplied bu

[net-next 2/4] gve: Add transmit and receive support

2019-06-26 Thread Catherine Sullivan
Add support for passing traffic. Signed-off-by: Catherine Sullivan Signed-off-by: Sagi Shahar Signed-off-by: Jon Olson Acked-by: Willem de Bruijn Reviewed-by: Luigi Rizzo --- .../networking/device_drivers/google/gve.rst | 30 + drivers/net/ethernet/google/gve/Makefile | 2 +- driver

[net-next 1/4] gve: Add basic driver framework for Compute Engine Virtual NIC

2019-06-26 Thread Catherine Sullivan
Add a driver framework for the Compute Engine Virtual NIC that will be available in the future. At this point the only functionality is loading the driver. Signed-off-by: Catherine Sullivan Signed-off-by: Sagi Shahar Signed-off-by: Jon Olson Acked-by: Willem de Bruijn Reviewed-by: Luigi Rizzo

[net-next 0/4] Add gve driver

2019-06-26 Thread Catherine Sullivan
This patch series adds the gve driver which will support the Compute Engine Virtual NIC that will be available in the future. Catherine Sullivan (4): gve: Add basic driver framework for Compute Engine Virtual NIC gve: Add transmit and receive support gve: Add workqueue and reset support gv

[net-next 4/4] gve: Add ethtool support

2019-06-26 Thread Catherine Sullivan
Add support for the following ethtool commands: ethtool -s|--change devname [msglvl N] [msglevel type on|off] ethtool -S|--statistics devname ethtool -i|--driver devname ethtool -l|--show-channels devname ethtool -L|--set-channels devname ethtool -g|--show-ring devname ethtool --reset devname Sig

[net-next 3/4] gve: Add workqueue and reset support

2019-06-26 Thread Catherine Sullivan
Add support for the workqueue to handle management interrupts and support for resets. Signed-off-by: Catherine Sullivan Signed-off-by: Sagi Shahar Signed-off-by: Jon Olson Acked-by: Willem de Bruijn Reviewed-by: Luigi Rizzo --- .../networking/device_drivers/google/gve.rst | 11 + drivers/n

Re: [PATCH v2 bpf-next 0/3] libbpf: add perf buffer abstraction and API

2019-06-26 Thread Andrii Nakryiko
On Wed, Jun 26, 2019 at 4:55 AM Toke Høiland-Jørgensen wrote: > > Andrii Nakryiko writes: > > > This patchset adds a high-level API for setting up and polling perf buffers > > associated with BPF_MAP_TYPE_PERF_EVENT_ARRAY map. Details of APIs are > > described in corresponding commit. > > > > Pat

Re: [PATCH 2/3 nf-next] netfilter:nf_flow_table: Support bridge type flow offload

2019-06-26 Thread Pablo Neira Ayuso
On Wed, Jun 26, 2019 at 06:32:27PM +0800, we...@ucloud.cn wrote: > From: wenxu > > With nf_conntrack_bridge function. The bridge family can do > conntrack it self. The flow offload function based on the > conntrack. So the flow in the bridge wih conntrack can be > offloaded. > > Signed-off-by: w

[PATCH net v2] net: make skb_dst_force return true when dst is refcounted

2019-06-26 Thread Florian Westphal
netfilter did not expect that skb_dst_force() can cause skb to lose its dst entry. I got a bug report with a skb->dst NULL dereference in netfilter output path. The backtrace contains nf_reinject(), so the dst might have been cleared when skb got queued to userspace. Other users were fixed via i

Re: [PATCH 2/3 nf-next] netfilter:nf_flow_table: Support bridge type flow offload

2019-06-26 Thread Florian Westphal
we...@ucloud.cn wrote: > diff --git a/net/netfilter/nf_flow_table_ip.c > b/net/netfilter/nf_flow_table_ip.c > index 0016bb8..9af01ef 100644 > --- a/net/netfilter/nf_flow_table_ip.c > +++ b/net/netfilter/nf_flow_table_ip.c > - neigh_xmit(NEIGH_ARP_TABLE, outdev, &nexthop, skb); > + if (fam

Re: [PATCH 1/3 nf-next] netfilter:nf_flow_table: Refactor flow_offload_tuple to support more offload method

2019-06-26 Thread Pablo Neira Ayuso
On Wed, Jun 26, 2019 at 06:32:26PM +0800, we...@ucloud.cn wrote: > From: wenxu Fix email subject, to: netfilter: nf_flow_table: Refactor flow_offload_tuple to destination > Add struct flow_offload_dst to support more offload method to replace > dst_cache which only work for route offload. > >

Re: [PATCH v2 bpf-next 04/11] libbpf: refactor map initialization

2019-06-26 Thread Andrii Nakryiko
On Wed, Jun 26, 2019 at 7:48 AM Matt Hart wrote: > > Hi all, > > I noticed perf fails to build for armv7 on linux next, due to this > compile error: > $ make -C tools/perf ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- > > CC libbpf_probes.o > In file included from libbpf.c:27: > libbpf.c: In

Re: [PATCH net v2] ipv4: reset rt_iif for recirculated mcast/bcast out pkts

2019-06-26 Thread David Ahern
On 6/26/19 12:21 AM, Stephen Suryaputra wrote: > Multicast or broadcast egress packets have rt_iif set to the oif. These > packets might be recirculated back as input and lookup to the raw > sockets may fail because they are bound to the incoming interface > (skb_iif). If rt_iif is not zero, during

Re: [PATCH v4 net] af_packet: Block execution of tasks waiting for transmit to complete in AF_PACKET

2019-06-26 Thread Neil Horman
On Wed, Jun 26, 2019 at 11:05:39AM -0400, Willem de Bruijn wrote: > On Wed, Jun 26, 2019 at 6:54 AM Neil Horman wrote: > > > > On Tue, Jun 25, 2019 at 06:30:08PM -0400, Willem de Bruijn wrote: > > > > diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c > > > > index a29d66da7394..a7ca6a00

Re: [PATCH net 0/2] net/smc: fixes 2019-06-26

2019-06-26 Thread David Miller
From: Ursula Braun Date: Wed, 26 Jun 2019 17:47:48 +0200 > here are 2 small smc fixes for the net tree. Looks good, series applied, thanks.

Re: [PATCH net-next 17/18] ionic: Add RSS support

2019-06-26 Thread Shannon Nelson
On 6/25/19 5:20 PM, Jakub Kicinski wrote: On Thu, 20 Jun 2019 13:24:23 -0700, Shannon Nelson wrote: +static int ionic_lif_rss_init(struct lif *lif) +{ + static const u8 toeplitz_symmetric_key[] = { + 0x6D, 0x5A, 0x6D, 0x5A, 0x6D, 0x5A, 0x6D, 0x5A, + 0x6D, 0x5A,

Re: [PATCH net-next v2 3/4] net: sched: em_ipt: keep the user-specified nfproto and use it

2019-06-26 Thread nikolay
On 26 June 2019 19:33:48 EEST, niko...@cumulusnetworks.com wrote: >On 26 June 2019 19:18:35 EEST, Eyal Birger >wrote: >>Hi Nik, >> >>On Wed, 26 Jun 2019 18:56:14 +0300 >>Nikolay Aleksandrov wrote: >> >>> For NFPROTO_UNSPEC xt_matches there's no way to restrict the >matching >>> to a specific fami

Re: [PATCH net-next 14/18] ionic: Add Tx and Rx handling

2019-06-26 Thread Shannon Nelson
On 6/25/19 5:08 PM, Jakub Kicinski wrote: On Thu, 20 Jun 2019 13:24:20 -0700, Shannon Nelson wrote: Add both the Tx and Rx queue setup and handling. The related stats display come later. Instead of using the generic napi routines used by the slow-path command, the Tx and Rx paths are simplifie

Re: [PATCH bpf-next V6 00/16] AF_XDP infrastructure improvements and mlx5e support

2019-06-26 Thread Jonathan Lemon
On 26 Jun 2019, at 7:35, Tariq Toukan wrote: This series contains improvements to the AF_XDP kernel infrastructure and AF_XDP support in mlx5e. The infrastructure improvements are required for mlx5e, but also some of them benefit to all drivers, and some can be useful for other drivers that w

Re: XDP multi-buffer incl. jumbo-frames (Was: [RFC V1 net-next 1/1] net: ena: implement XDP drop support)

2019-06-26 Thread Jonathan Lemon
On 26 Jun 2019, at 8:20, Willem de Bruijn wrote: On Wed, Jun 26, 2019 at 11:01 AM Toke Høiland-Jørgensen wrote: Jesper Dangaard Brouer writes: On Wed, 26 Jun 2019 13:52:16 +0200 Toke Høiland-Jørgensen wrote: Jesper Dangaard Brouer writes: On Tue, 25 Jun 2019 03:19:22 + "Machul

Re: [PATCH net-next 2/5] net: sched: em_ipt: set the family based on the protocol when matching

2019-06-26 Thread nikolay
On 26 June 2019 19:22:54 EEST, Eyal Birger wrote: >On Wed, 26 Jun 2019 16:45:28 +0300 >Nikolay Aleksandrov wrote: > >> On 26/06/2019 16:33, Eyal Birger wrote: >> > Hi Nikolay, >> > >> > On Wed, 26 Jun 2019 14:58:52 +0300 >> > Nikolay Aleksandrov wrote: >> > >> >> Set the family based on t

Re: XDP multi-buffer incl. jumbo-frames (Was: [RFC V1 net-next 1/1] net: ena: implement XDP drop support)

2019-06-26 Thread Jesper Dangaard Brouer
On Wed, 26 Jun 2019 17:14:32 +0200 Toke Høiland-Jørgensen wrote: > Jesper Dangaard Brouer writes: > > > On Wed, 26 Jun 2019 13:52:16 +0200 > > Toke Høiland-Jørgensen wrote: > > > >> Jesper Dangaard Brouer writes: > >> > >> > On Tue, 25 Jun 2019 03:19:22 + > >> > "Machulsky, Zorik" w

Re: [PATCH net-next v2 3/4] net: sched: em_ipt: keep the user-specified nfproto and use it

2019-06-26 Thread nikolay
On 26 June 2019 19:18:35 EEST, Eyal Birger wrote: >Hi Nik, > >On Wed, 26 Jun 2019 18:56:14 +0300 >Nikolay Aleksandrov wrote: > >> For NFPROTO_UNSPEC xt_matches there's no way to restrict the matching >> to a specific family, in order to do so we record the user-specified >> family and later enfor

Re: [PATCH bpf-next V6 00/16] AF_XDP infrastructure improvements and mlx5e support

2019-06-26 Thread Björn Töpel
On Wed, 26 Jun 2019 at 16:36, Tariq Toukan wrote: > > This series contains improvements to the AF_XDP kernel infrastructure > and AF_XDP support in mlx5e. The infrastructure improvements are > required for mlx5e, but also some of them benefit to all drivers, and > some can be useful for other driv

Re: [PATCH net-next v3 0/8] net: aquantia: implement vlan offloads

2019-06-26 Thread David Miller
From: Igor Russkikh Date: Wed, 26 Jun 2019 12:35:30 + > This patchset introduces hardware VLAN offload support and also does some > maintenance: we replace driver version with uts version string, add > documentation file for atlantic driver, and update maintainers > adding Igor as a maintaine

Re: [PATCH net-next 2/5] net: sched: em_ipt: set the family based on the protocol when matching

2019-06-26 Thread Eyal Birger
On Wed, 26 Jun 2019 16:45:28 +0300 Nikolay Aleksandrov wrote: > On 26/06/2019 16:33, Eyal Birger wrote: > > Hi Nikolay, > > > > On Wed, 26 Jun 2019 14:58:52 +0300 > > Nikolay Aleksandrov wrote: > > > >> Set the family based on the protocol otherwise protocol-neutral > >> matches will have

[PATCH iproute] devlink: replace print macros with functions

2019-06-26 Thread Stephen Hemminger
Using functions is safer than macros, and printing is not performance critical. Signed-off-by: Stephen Hemminger --- devlink/devlink.c | 62 --- 1 file changed, 42 insertions(+), 20 deletions(-) diff --git a/devlink/devlink.c b/devlink/devlink.c index

Re: [PATCH net-next v2 3/4] net: sched: em_ipt: keep the user-specified nfproto and use it

2019-06-26 Thread Eyal Birger
Hi Nik, On Wed, 26 Jun 2019 18:56:14 +0300 Nikolay Aleksandrov wrote: > For NFPROTO_UNSPEC xt_matches there's no way to restrict the matching > to a specific family, in order to do so we record the user-specified > family and later enforce it while doing the match. > > v2: adjust changes to mis

Re: [PATCH net-next 13/18] ionic: Add initial ethtool support

2019-06-26 Thread Jakub Kicinski
On Wed, 26 Jun 2019 09:07:29 -0700, Shannon Nelson wrote: > On 6/25/19 4:54 PM, Jakub Kicinski wrote: > > On Thu, 20 Jun 2019 13:24:19 -0700, Shannon Nelson wrote: > >> + running = test_bit(LIF_UP, lif->state); > >> + if (running) > >> + ionic_stop(netdev); > >> + > >> + lif->ntxq_des

Re: [PATCH bpf-next 1/4] bpf: unprivileged BPF access via /dev/bpf

2019-06-26 Thread Song Liu
> On Jun 26, 2019, at 8:26 AM, Lorenz Bauer wrote: > > On Wed, 26 Jun 2019 at 16:19, Song Liu wrote: >>> I know nothing about the scheduler, so pardon my ignorance. Does >>> TASK_BPF_FLAG_PERMITTED apply per user-space process, or per thread? >> >> It is per thread. clone() also clears the b

Re: [PATCH net] ipv6: fix suspicious RCU usage in rt6_dump_route()

2019-06-26 Thread David Miller
From: Eric Dumazet Date: Wed, 26 Jun 2019 03:05:28 -0700 > syzbot reminded us that rt6_nh_dump_exceptions() needs to be called > with rcu_read_lock() > > net/ipv6/route.c:1593 suspicious rcu_dereference_check() usage! > > other info that might help us debug this: ... > Fixes: 1e47b4837f3b ("ipv

Re: [PATCH net] ipv4: fix suspicious RCU usage in fib_dump_info_fnhe()

2019-06-26 Thread David Miller
From: Eric Dumazet Date: Wed, 26 Jun 2019 03:04:50 -0700 > sysbot reported that we lack appropriate rcu_read_lock() > protection in fib_dump_info_fnhe() > > net/ipv4/route.c:2875 suspicious rcu_dereference_check() usage! > > other info that might help us debug this: ... > Fixes: ee28906fd7a1 (

Re: [PATCH net-next 13/18] ionic: Add initial ethtool support

2019-06-26 Thread Shannon Nelson
On 6/25/19 4:54 PM, Jakub Kicinski wrote: On Thu, 20 Jun 2019 13:24:19 -0700, Shannon Nelson wrote: + running = test_bit(LIF_UP, lif->state); + if (running) + ionic_stop(netdev); + + lif->ntxq_descs = ring->tx_pending; + lif->nrxq_descs = ring->rx_pending; +

  1   2   3   >