Re: [PATCH net-next 17/18] ionic: Add RSS support

[Shannon Nelson]

On 6/25/19 5:20 PM, Jakub Kicinski wrote:

On Thu, 20 Jun 2019 13:24:23 -0700, Shannon Nelson wrote:

+static int ionic_lif_rss_init(struct lif *lif)
+{
+       static const u8 toeplitz_symmetric_key[] = {
+               0x6D, 0x5A, 0x6D, 0x5A, 0x6D, 0x5A, 0x6D, 0x5A,
+               0x6D, 0x5A, 0x6D, 0x5A, 0x6D, 0x5A, 0x6D, 0x5A,
+               0x6D, 0x5A, 0x6D, 0x5A, 0x6D, 0x5A, 0x6D, 0x5A,
+               0x6D, 0x5A, 0x6D, 0x5A, 0x6D, 0x5A, 0x6D, 0x5A,
+               0x6D, 0x5A, 0x6D, 0x5A, 0x6D, 0x5A, 0x6D, 0x5A,
+       };

netdev_rss_key_fill()

Sure.

+       unsigned int i, tbl_sz;
+
+       lif->rss_types = IONIC_RSS_TYPE_IPV4     |
+                        IONIC_RSS_TYPE_IPV4_TCP |
+                        IONIC_RSS_TYPE_IPV4_UDP |
+                        IONIC_RSS_TYPE_IPV6     |
+                        IONIC_RSS_TYPE_IPV6_TCP |
+                        IONIC_RSS_TYPE_IPV6_UDP;
+
+       /* Fill indirection table with 'default' values */
+       tbl_sz = le16_to_cpu(lif->ionic->ident.lif.eth.rss_ind_tbl_sz);
+       for (i = 0; i < tbl_sz; i++)
+               lif->rss_ind_tbl[i] = i % lif->nxqs;

ethtool_rxfh_indir_default()

Sure

+       return ionic_lif_rss_config(lif, lif->rss_types,
+                                   toeplitz_symmetric_key, NULL);
+}

Thanks for your time, I appreciate the review.

sln