On Fri, 7 Jun 2019 at 00:30, Jonathan Lemon wrote:
>
> Currently, the AF_XDP code uses a separate map in order to
> determine if an xsk is bound to a queue. Have the xskmap
> lookup return a XDP_SOCK pointer on the kernel side, which
> the verifier uses to extract relevant values.
>
Very nice! T
On 6/8/2019 6:03 AM, Vladimir Oltean wrote:
> The first fact that needs to be stated is that the per-MAC settings in
> SJA1105 called EGRESS and INGRESS do *not* disable egress and ingress on
> the MAC. They only prevent non-link-local traffic from being
> sent/received on this port.
>
> So ins
On 6/8/2019 6:03 AM, Vladimir Oltean wrote:
> This will be used to stop egress traffic in .phylink_mac_link_up.
>
> Signed-off-by: Vladimir Oltean
Reviewed-by: Florian Fainelli
--
Florian
On 6/8/2019 6:03 AM, Vladimir Oltean wrote:
> Since the driver is now using PHYLINK exclusively, it makes sense to
> remove all references to it and replace them with PHYLINK.
>
> Signed-off-by: Vladimir Oltean
Reviewed-by: Florian Fainelli
--
Florian
On 6/8/2019 6:03 AM, Vladimir Oltean wrote:
> This is a cosmetic patch that replaces the link speed numbers used in
> the driver with the corresponding ethtool macros.
>
> Signed-off-by: Vladimir Oltean
> Suggested-by: Andrew Lunn
Reviewed-by: Florian Fainelli
--
Florian
In case autoflowlabel is in action, skb_get_hash_flowi6()
derives a non zero skb->hash to the flowlabel.
If skb->hash is zero, a flow dissection is performed.
Since all TCP skbs sent from ESTABLISH state inherit their
skb->hash from sk->sk_txhash, we better keep a copy
of sk->sk_txhash into the T
From: John Hurley
Packets received at the NFP driver may be redirected to egress of another
netdev (e.g. in the case of OvS internal ports). On the egress path, some
processes, like TC egress hooks, may expect the network header offset
field in the skb to be correctly set. If this is not the case
Hello Daniel,
Thanks for your help!
On 6/8/19 6:51 AM, Daniel Golle wrote:
> Hi Daniel,
>
> On Sat, Jun 08, 2019 at 04:06:54AM -0500, Daniel Santos wrote:
>> Hello,
>>
>> I need to change auto-negotiate, speed and duplex for a port on my
>> mt7620a-based device, but I'm not quite certain that I u
From: David Ahern
Add a hook in fib6_info_uses_dev to handle nexthop struct in a fib6_info.
Signed-off-by: David Ahern
---
net/ipv6/route.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index d1139ef077cd..d56e1ff49e47 100644
--- a/
From: David Ahern
Add a hook in rt6_flush_exceptions, rt6_remove_exception_rt,
rt6_update_exception_stamp_rt, and rt6_age_exceptions to handle
nexthop struct in a fib6_info.
Signed-off-by: David Ahern
---
net/ipv6/route.c | 111 +--
1 file ch
From: David Ahern
Use nexthop_for_each_fib6_nh to walk all fib6_nh in a nexthop when
dropping 'from' reference in pcpu routes.
Signed-off-by: David Ahern
---
net/ipv6/ip6_fib.c | 31 +++
1 file changed, 27 insertions(+), 4 deletions(-)
diff --git a/net/ipv6/ip6_fib
From: David Ahern
Add support for RTA_NH_ID attribute to allow a user to specify a
nexthop id to use with a route. fc_nh_id is added to fib_config to
hold the value passed in the RTA_NH_ID attribute. If a nexthop id
is given, the gateway, device, encap and multipath attributes can
not be set.
Up
From: David Ahern
Add a hook in rt6_device_match to handle nexthop struct in a fib6_info.
The new rt6_nh_dev_match uses nexthop_for_each_fib6_nh to walk each
fib6_nh in a nexthop and call __rt6_device_match. On match,
rt6_nh_dev_match returns the fib6_nh and rt6_device_match uses it to
setup fib6
From: David Ahern
Move the route add commands to a new function called setup_routing_old.
The '_old' refers to the classic way of installing routes.
Signed-off-by: David Ahern
Reviewed-by: Stefano Brivio
---
tools/testing/selftests/net/pmtu.sh | 26 +++---
1 file changed,
From: David Ahern
Be optimistic about re-using a fib_info when nexthop id is given and
the route does not use metrics. Avoids a memory allocation which in
most cases is expected to be freed anyways.
Signed-off-by: David Ahern
---
net/ipv4/fib_semantics.c | 71 ++
From: David Ahern
Add support for atomically upating a nexthop config.
When updating a nexthop, walk the lists of associated fib entries and
verify the new config is valid. Replace is done by swapping nh_info
for single nexthops - new config is applied to old nexthop struct, and
old config is mo
From: David Ahern
Add a hook in rt6_nlmsg_size to handle nexthop struct in a fib6_info.
rt6_nh_nlmsg_size is used to sum the space needed for all nexthops in
the fib entry.
Signed-off-by: David Ahern
---
net/ipv6/route.c | 49 +
1 file changed, 3
From: David Ahern
Use nexthop_for_each_fib6_nh and fib6_nh_find_match to find the
fib6_nh in a nexthop that correlates to the device and gateway
in the rt6_info.
Signed-off-by: David Ahern
---
net/ipv6/route.c | 20 +++-
1 file changed, 19 insertions(+), 1 deletion(-)
diff --g
From: David Ahern
Add support for RTA_NH_ID attribute to allow a user to specify a
nexthop id to use with a route. fc_nh_id is added to fib6_config to
hold the value passed in the RTA_NH_ID attribute. If a nexthop id
is given, the gateway, device, encap and multipath attributes can
not be set.
U
From: David Ahern
Move the block of code that runs a test and prints the verdict to a
new function, run_test.
Signed-off-by: David Ahern
Reviewed-by: Stefano Brivio
---
tools/testing/selftests/net/pmtu.sh | 63 +
1 file changed, 36 insertions(+), 27 deletio
From: David Ahern
Add a version of router_multipath.sh that uses nexthop objects for
routes.
Ido requested a version that does not cause regressions with mlxsw
testing since it does not support nexthop objects yet.
Signed-off-by: David Ahern
---
.../selftests/net/forwarding/router_mpath_nh.sh
From: David Ahern
This is the final set of the initial nexthop object work. When I
started this idea almost 2 years ago, it took 18 seconds to inject
700k+ IPv4 routes with 1 hop and about 28 seconds for 4-paths. Some
of that time was due to inefficiencies in 'ip', but most of it was
kernel side
From: David Ahern
Add a hook in __find_rr_leaf to handle nexthop struct in a fib6_info.
nexthop_for_each_fib6_nh is used to walk each fib6_nh in a nexthop and
call find_match. On a match, use the fib6_nh saved in the callback arg
to setup fib6_result.
Signed-off-by: David Ahern
---
net/ipv6/ro
From: David Ahern
Use nexthop_for_each_fib6_nh to call fib6_nh_mtu_change for each
fib6_nh in a nexthop for rt6_mtu_change_route. For __ip6_rt_update_pmtu,
we need to find the nexthop that correlates to the device and gateway
in the rt6_info.
Signed-off-by: David Ahern
---
net/ipv6/route.c | 2
From: David Ahern
Add routing setup using nexthop objects and repeat tests with
old and new routing.
Signed-off-by: David Ahern
Reviewed-by: Stefano Brivio
---
tools/testing/selftests/net/pmtu.sh | 158
1 file changed, 126 insertions(+), 32 deletions(-)
d
From: David Ahern
Add a hook in __ip6_route_redirect to handle a nexthop struct in a
fib6_info. Use nexthop_for_each_fib6_nh and fib6_nh_redirect_match
to call ip6_redirect_nh_match for each fib6_nh looking for a match.
Signed-off-by: David Ahern
---
net/ipv6/route.c | 39 +
From: David Ahern
Add a second pass to icmp_redirect.sh to use nexthop objects for
routes.
Signed-off-by: David Ahern
---
tools/testing/selftests/net/icmp_redirect.sh | 49
1 file changed, 49 insertions(+)
diff --git a/tools/testing/selftests/net/icmp_redirect.sh
From: David Ahern
Add tests where multiple FIB entries use the same nexthop object. Generate
per-cpu cached routes for each by running ping on each cpu, and then
generate exceptions unique to each prefix (remote host) with different
mtus.
Signed-off-by: David Ahern
---
.../selftests/net/fib_ne
From: David Ahern
IPv6 has traditionally had a single fib6_nh per fib6_info. With
nexthops we can have multiple fib6_nh associated with a fib6_info.
Add a nexthop helper to invoke a callback for each fib6_nh in a
'struct nexthop'. If the callback returns non-0, the loop is
stopped and the return
If the leftmost parent node of the tree has does not have a child
on the left side, then trie_get_next_key (and bpftool map dump) will
not look at the child on the right. This leads to the traversal
missing elements.
Lookup is not affected.
Update selftest to handle this case.
Reproducer:
bpf
On Sat, Jun 08, 2019 at 04:06:54AM -0500, Daniel Santos wrote:
> Hello,
Hi Daniel
As Daniel Golle pointed out, swconfig is an openwrt only
thing. Mainline people on netdev are unlikely to help you much. If you
do however decide to work on the mainline DSA driver, people here will
offer help, answ
On Sat, Jun 08, 2019 at 04:03:44PM +0300, Vladimir Oltean wrote:
> The first fact that needs to be stated is that the per-MAC settings in
> SJA1105 called EGRESS and INGRESS do *not* disable egress and ingress on
> the MAC. They only prevent non-link-local traffic from being
> sent/received on this
On Sat, Jun 08, 2019 at 04:03:43PM +0300, Vladimir Oltean wrote:
> This will be used to stop egress traffic in .phylink_mac_link_up.
>
> Signed-off-by: Vladimir Oltean
Reviewed-by: Andrew Lunn
Andrew
On Sat, Jun 08, 2019 at 04:03:42PM +0300, Vladimir Oltean wrote:
> Since the driver is now using PHYLINK exclusively, it makes sense to
> remove all references to it and replace them with PHYLINK.
>
> Signed-off-by: Vladimir Oltean
Reviewed-by: Andrew Lunn
Andrew
On Sat, Jun 08, 2019 at 04:03:41PM +0300, Vladimir Oltean wrote:
> This is a cosmetic patch that replaces the link speed numbers used in
> the driver with the corresponding ethtool macros.
>
> Signed-off-by: Vladimir Oltean
> Suggested-by: Andrew Lunn
Reviewed-by: Andrew Lunn
Andrew
On Sat, Jun 08, 2019 at 10:50:51AM -0700, Linus Torvalds wrote:
> On Sat, Jun 8, 2019 at 10:42 AM Linus Torvalds
> wrote:
> >
> > There are no atomic rmw sequences that have reasonable performance for
> > the bitfield updates themselves.
>
> Note that this is purely about the writing side. Reads
On Sat, Jun 08, 2019 at 07:12:28PM +0300, Vladimir Oltean wrote:
> As per the DT phy-mode specification, RGMII delays are applied by the
> MAC when there is no PHY present on the link.
>
> Signed-off-by: Vladimir Oltean
Reviewed-by: Andrew Lunn
Andrew
The commands 'ip -6 route list cache' and 'ip -6 route flush cache'
don't work at all after route exceptions have been moved to a separate
hash table in commit 2b760fcf5cfb ("ipv6: hook up exception table to store
dst cache"). Fix that.
v3: Drop check on RTM_F_CLONED and rework logic of return val
When we perform an inexact match on FIB nodes via fib6_locate_1(), longer
prefixes will be preferred to shorter ones. However, it might happen that
a node, with higher fn_bit value than some other, has no valid routing
information.
In this case, we'll pick that node, but it will be discarded by th
Since commit 2b760fcf5cfb ("ipv6: hook up exception table to store dst
cache"), route exceptions reside in a separate hash table, and won't be
found by walking the FIB, so they won't be dumped to userspace on a
RTM_GETROUTE message.
This causes 'ip -6 route list cache' and 'ip -6 route flush cache
On 17/05/2019 04.39, Joakim Zhang wrote:
As reproted by Sean Nyekjaer bellow:
When suspending, when there is still can traffic on the
interfaces the flexcan immediately wakes the platform again.
As it should :-)
But it throws this error msg:
[ 3169.378661] PM: noirq suspend of devices failed
kind ping :-)
On 09/04/2019 10.39, Sean Nyekjaer wrote:
The flexcan controller can be forced as a wakeup source by
stating that explicitly in the device's .dts file using the
"wakeup-source" boolean property.
Signed-off-by: Sean Nyekjaer
---
drivers/net/can/flexcan.c | 3 +++
1 file changed
The pad_mii_tx registers point to the same memory region but were
unused. So convert to using these for RGMII I/O cell configuration, as
they bear a shorter name.
Signed-off-by: Vladimir Oltean
---
drivers/net/dsa/sja1105/sja1105.h | 2 +-
drivers/net/dsa/sja1105/sja1105_clocking.c | 2
As per the DT phy-mode specification, RGMII delays are applied by the
MAC when there is no PHY present on the link.
Signed-off-by: Vladimir Oltean
---
drivers/net/dsa/sja1105/sja1105.h | 1 +
drivers/net/dsa/sja1105/sja1105_clocking.c | 98 +-
drivers/net/dsa/sja110
This patchset configures the Tunable Delay Lines of the SJA1105 P/Q/R/S
switches. These add a programmable phase offset on the RGMII RX and TX
clock signals and get used by the driver for fixed-link interfaces that
use the rgmii-id, rgmii-txid or rgmii-rxid phy-modes.
Tested on a board where RGMII
On Sat, 8 Jun 2019 17:02:06 +0200
Stefano Brivio wrote:
> On Sat, 8 Jun 2019 07:19:23 +
> Martin Lau wrote:
>
> > On Sat, Jun 08, 2019 at 07:59:11AM +0200, Stefano Brivio wrote:
> > > I also agree it makes more sense to filter routes this way.
> > >
> > > But it wasn't like this before 2
On Sat, Jun 8, 2019 at 3:39 AM David Lebrun wrote:
>
> On 07/06/2019 19:55, Tom Herbert wrote:
> > This patch set includes fixes to bring the segment routing
> > implementation into conformance with the latest version of the
> > draft (draft-ietf-6man-segment-routing-header-19). Also, segment
> >
On 7 Jun 2019, at 19:44, Jonathan Lemon wrote:
> If the root of the tree has does not have any elements on the left
> branch, then trie_get_next_key (and bpftool map dump) will not look
> at the rightmost branch. This leads to the traversal missing elements.
I just realized this doesn't handle a
On Sat, Jun 8, 2019 at 2:50 AM David Lebrun wrote:
>
> On 07/06/2019 19:55, Tom Herbert wrote:
> > -#define SR6_TLV_PADDING 4
>
> From a uapi perspective, should we rather keep the definition and mark
> it as obsoleted as for the rest of the TLV types ?
>
Yes, that is an omission.
>
On Sat, 8 Jun 2019 07:19:23 +
Martin Lau wrote:
> On Sat, Jun 08, 2019 at 07:59:11AM +0200, Stefano Brivio wrote:
> > I also agree it makes more sense to filter routes this way.
> >
> > But it wasn't like this before 2b760fcf5cfb, so this smells like
> > breaking userspace expectations, even
Hello
COSTCO WHOLESALE UK LIMITED are looking to buy your products and partner
with your company, can you please send us your Catalog or your website
to learn more about your products or prices list by email and if we can
make some order with you and start a long-term partnership. Can your
This puts the quad PHY ports in power-down mode when the PHY transitions
to the PHY_HALTED state. It is likely that all the other PHYs support
the BMCR_PDOWN bit, but I only have the BCM5464R to test.
Signed-off-by: Vladimir Oltean
---
drivers/net/phy/broadcom.c | 2 ++
1 file changed, 2 insert
The first fact that needs to be stated is that the per-MAC settings in
SJA1105 called EGRESS and INGRESS do *not* disable egress and ingress on
the MAC. They only prevent non-link-local traffic from being
sent/received on this port.
So instead of having .phylink_mac_config essentially mess with th
This will be used to stop egress traffic in .phylink_mac_link_up.
Signed-off-by: Vladimir Oltean
---
drivers/net/dsa/sja1105/sja1105.h | 2 ++
drivers/net/dsa/sja1105/sja1105_spi.c | 14 --
2 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/net/dsa/sja1105/s
This is a cosmetic patch that replaces the link speed numbers used in
the driver with the corresponding ethtool macros.
Signed-off-by: Vladimir Oltean
Suggested-by: Andrew Lunn
---
drivers/net/dsa/sja1105/sja1105_main.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions
Since the driver is now using PHYLINK exclusively, it makes sense to
remove all references to it and replace them with PHYLINK.
Signed-off-by: Vladimir Oltean
---
drivers/net/dsa/sja1105/Kconfig| 2 +-
drivers/net/dsa/sja1105/sja1105_main.c | 6 ++
2 files changed, 3 insertions(+), 5
This patchset implements phylink_mac_link_up and phylink_mac_link_down,
while also removing the code that was modifying the EGRESS and INGRESS
MAC settings for STP and replacing them with the "inhibit TX"
functionality.
Vladimir Oltean (4):
net: dsa: sja1105: Use SPEED_{10,100,1000,UNKNOWN} macr
On 07/06/2019 19:55, Tom Herbert wrote:
...
@@ -387,8 +416,24 @@ static int ipv6_srh_rcv(struct sk_buff *skb)
return -1;
}
+ tlvoff = seg6_tlv_offset(hdr);
+ tlvlen = ipv6_optlen((struct ipv6_opt_hdr *)hdr) - tlvoff;
+
+ if (tlvlen) {
+
Hi Daniel,
On Sat, Jun 08, 2019 at 04:06:54AM -0500, Daniel Santos wrote:
> Hello,
>
> I need to change auto-negotiate, speed and duplex for a port on my
> mt7620a-based device, but I'm not quite certain that I understand the
> structure here. When using ethtool on eth0 I always get ENODEV,
> ap
On 6/7/2019 9:20 PM, Davide Caratti wrote:
> On Wed, 2019-06-05 at 18:42 -0700, Cong Wang wrote:
>> On Tue, Jun 4, 2019 at 11:19 AM Eli Britstein wrote:
> hello Cong and Eli,
>
> and thanks for all the thoughts.
>
>>> On 6/4/2019 8:55 PM, Cong Wang wrote:
On Sat, Jun 1, 2019 at 9:22 PM Eli B
On 6/7/19 2:15 PM, Vladimir Oltean wrote:
On Mon, 3 Jun 2019 at 15:25, Ido Schimmel wrote:
From: Shalom Toledo
Test the PTP Physical Hardware Clock functionality using the "phc_ctl" (a
part of "linuxptp").
The test contains three sub-tests:
* "settime" test
* "adjtime" test
* "adjf
On 07/06/2019 19:55, Tom Herbert wrote:
This patch set includes fixes to bring the segment routing
implementation into conformance with the latest version of the
draft (draft-ietf-6man-segment-routing-header-19). Also, segment
routing receive function calls ip6_parse to properly parse TLVs
in par
On 07/06/2019 19:55, Tom Herbert wrote:
+ .procname = "max_srh_tlvs_length",
Should this be "max_srh_opts_length" to be consistent with the rest of
the naming ?
On 07/06/2019 19:55, Tom Herbert wrote:
+ bool (*unknown_opt)(struct sk_buff *skb, int optoff,
+ bool disallow_unknowns))
What about changing this boolean argument to 'allow_unknowns' (here, in
ip6_tlvopt_unknown() and ip6_par
On 07/06/2019 19:55, Tom Herbert wrote:
+ int len = ((srh->hdrlen + 1) << 8) - off;
You want << 3 instead of << 8.
On 07/06/2019 19:55, Tom Herbert wrote:
-#define SR6_TLV_PADDING4
From a uapi perspective, should we rather keep the definition and mark
it as obsoleted as for the rest of the TLV types ?
Note that I'm fine with both.
Hello,
I need to change auto-negotiate, speed and duplex for a port on my
mt7620a-based device, but I'm not quite certain that I understand the
structure here. When using ethtool on eth0 I always get ENODEV,
apparently because priv->phy_dev is always NULL in fe_get_link_ksettings
of drivers/net/e
On Thu, Jun 06, 2019 at 01:56:36PM +0200, Petr Vorel wrote:
> Hi,
>
> > From: Maor Gottlieb
>
> > Add API to get the current Eswitch encap mode.
> > It will be used in downstream patches to check if
> > flow table can be created with encap support or not.
>
> > Signed-off-by: Maor Gottlieb
> > Si
On Thu, Jun 06, 2019 at 01:08:46PM +, Parav Pandit wrote:
>
>
> > -Original Message-
> > From: linux-rdma-ow...@vger.kernel.org > ow...@vger.kernel.org> On Behalf Of Leon Romanovsky
> > Sent: Thursday, June 6, 2019 4:36 PM
> > To: Doug Ledford ; Jason Gunthorpe
> >
> > Cc: Leon Romano
On Sat, Jun 08, 2019 at 07:59:11AM +0200, Stefano Brivio wrote:
> On Sat, 8 Jun 2019 05:40:06 +
> Martin Lau wrote:
>
> > On Thu, Jun 06, 2019 at 04:47:00PM -0600, David Ahern wrote:
> > > On 6/6/19 3:18 PM, Stefano Brivio wrote:
> > > > On Thu, 6 Jun 2019 14:57:33 -0600
> > > > David Ahern
On Fri, Jun 07, 2019 at 09:29:13AM -0700, Stanislav Fomichev wrote:
> Implement new BPF_PROG_TYPE_CGROUP_SOCKOPT program type and
> BPF_CGROUP_{G,S}ETSOCKOPT cgroup hooks.
>
> BPF_CGROUP_SETSOCKOPT get a read-only view of the setsockopt arguments.
> BPF_CGROUP_GETSOCKOPT can modify the supplied bu
On Fri, Jun 7, 2019 at 8:48 PM Marcelo Ricardo Leitner
wrote:
>
> On Fri, Jun 07, 2019 at 06:56:39AM -0400, Neil Horman wrote:
> > On Thu, Jun 06, 2019 at 12:47:55PM -0300, Marcelo Ricardo Leitner wrote:
> > > On Wed, Jun 05, 2019 at 07:20:10AM -0400, Neil Horman wrote:
> > > > On Wed, Jun 05, 201
72 matches
Mail list logo
