Having TIPC compiled in causes strange networking failures

2019-05-25 Thread bepvte
Hi! I build my own kernel, and I set TIPC as enabled long ago thinking it was something many applications depend on. After I upgraded to 5.1.5, I noticed lots of errors in my systemd log and that Firefox couldnt start any of its subprocesses: NET: Registered protocol family 30 Failed to register T

[PATCH bpf-next] bpftool: auto-complete BTF IDs for btf dump

2019-05-25 Thread Andrii Nakryiko
Auto-complete BTF IDs for `btf dump id` sub-command. List of possible BTF IDs is scavenged from loaded BPF programs that have associated BTFs, as there is currently no API in libbpf to fetch list of all BTFs in the system. Suggested-by: Quentin Monnet Signed-off-by: Andrii Nakryiko --- tools/bp

Re: [PATCH bpf-next] bpftool: auto-complete BTF IDs for btf dump

2019-05-25 Thread Andrii Nakryiko
On Sat, May 25, 2019 at 4:55 AM Quentin Monnet wrote: > > 2019-05-24 22:38 UTC-0700 ~ Andrii Nakryiko > > Auto-complete BTF IDs for `btf dump id` sub-command. List of possible BTF > > IDs is scavenged from loaded BPF programs that have associated BTFs, as > > there is currently no API in libbpf t

Re: [PATCH bpf-next] selftests/bpf: fail test_tunnel.sh if subtests fail

2019-05-25 Thread Y Song
On Fri, May 24, 2019 at 3:29 PM Stanislav Fomichev wrote: > > Right now test_tunnel.sh always exits with success even if some > of the subtests fail. Since the output is very verbose, it's > hard to spot the issues with subtests. Let's fail the script > if any subtest fails. > > Signed-off-by: Sta

[PATCH net-next] r8169: remove support for RTL_GIGA_MAC_VER_01

2019-05-25 Thread Heiner Kallweit
RTL_GIGA_MAC_VER_01 is RTL8169, the ancestor of the chip family. It didn't have an internal PHY and I've never seen it in the wild. What isn't there doesn't need to be maintained, so let's remove support for it. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 43 ++-

Re: [PATCH bpf-next v5 1/3] bpf: implement bpf_send_signal() helper

2019-05-25 Thread Yonghong Song
On 5/24/19 3:37 PM, Daniel Borkmann wrote: > On 05/25/2019 12:20 AM, Yonghong Song wrote: >> On 5/24/19 2:39 PM, Daniel Borkmann wrote: >>> On 05/23/2019 11:47 PM, Yonghong Song wrote: This patch tries to solve the following specific use case. Currently, bpf program can already col

[PATCH net-next] r8169: improve RTL8168d PHY initialization

2019-05-25 Thread Heiner Kallweit
Certain parts of the PHY initialization are the same for sub versions 1 and 2 of RTL8168d. So let's factor this out to simplify the code. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 153 +-- 1 file changed, 52 insertions(+), 101 deletions(-)

[PATCH bpf-next] bpf: check signal validity in nmi for bpf_send_signal() helper

2019-05-25 Thread Yonghong Song
Commit 8b401f9ed244 ("bpf: implement bpf_send_signal() helper") introduced bpf_send_signal() helper. If the context is nmi, the sending signal work needs to be deferred to irq_work. If the signal is invalid, the error will appear in irq_work and it won't be propagated to user. This patch did an ea

[PATCH net-next 1/3] r8169: remove rtl_hw_init_8168ep

2019-05-25 Thread Heiner Kallweit
rtl_hw_init_8168ep() can be removed, this simplifies the code. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c ind

[PATCH net-next 2/3] r8169: remove unneeded return statement in rtl_hw_init_8168g

2019-05-25 Thread Heiner Kallweit
Remove not needed return statement. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index c69694653..e861edca2 100644 --- a/d

[PATCH net-next 3/3] r8169: change type of member mac_version in rtl8169_private

2019-05-25 Thread Heiner Kallweit
Use the appropriate enum type for member mac_version. And don't assign a fixed value to RTL_GIGA_MAC_NONE, there's no benefit in it. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/eth

[PATCH net-next 0/3] r8169: small improvements

2019-05-25 Thread Heiner Kallweit
Series with small improvements. Heiner Kallweit (3): r8169: remove rtl_hw_init_8168ep r8169: remove unneeded return statement in rtl_hw_init_8168g r8169: change type of member mac_version in rtl8169_private drivers/net/ethernet/realtek/r8169.c | 23 ++- 1 file changed,

[PATCH net v2] af_key: fix leaks in key_pol_get_resp and dump_sp.

2019-05-25 Thread Jeremy Sowden
In both functions, if pfkey_xfrm_policy2msg failed we leaked the newly allocated sk_buff. Free it on error. Fixes: 55569ce256ce ("Fix conversion between IPSEC_MODE_xxx and XFRM_MODE_xxx.") Reported-by: syzbot+4f0529365f7f2208d...@syzkaller.appspotmail.com Signed-off-by: Jeremy Sowden --- Since v

[PATCH net] af_key: fix leaks in key_pol_get_resp and dump_sp.

2019-05-25 Thread Jeremy Sowden
In both functions, if pfkey_xfrm_policy2msg failed we leaked the newly allocated sk_buff. Free it on error. Fixes: 55569ce256ce ("Fix conversion between IPSEC_MODE_xxx and XFRM_MODE_xxx.") Reported-by: syzbot+4f0529365f7f2208d...@syzkaller.appspotmail.com Signed-off-by: Jeremy Sowden --- net/ke

Re: [PATCH net-next] udp: Avoid post-GRO UDP checksum recalculation

2019-05-25 Thread David Miller
From: Sean Tranchetti Date: Thu, 23 May 2019 13:36:17 -0600 > @@ -472,11 +472,15 @@ static inline struct sk_buff *udp_rcv_segment(struct > sock *sk, > struct sk_buff *skb, bool ipv4) > { > struct sk_buff *segs; > + netdev_features_t features

Re: [PATCH net-next] vrf: local route leaking

2019-05-25 Thread David Ahern
On 5/25/19 1:09 AM, George Wilkie wrote: > > That was my initial thought, although it needs a 2nd lookup. > The problem I hit though was I couldn't figure out how to make it work > when leaking from global into a VRF. I couldn't see how to indicate > a lookup in the global table. Is there a way t

Re: [PATCH bpf-next] bpftool: auto-complete BTF IDs for btf dump

2019-05-25 Thread Quentin Monnet
2019-05-24 22:38 UTC-0700 ~ Andrii Nakryiko > Auto-complete BTF IDs for `btf dump id` sub-command. List of possible BTF > IDs is scavenged from loaded BPF programs that have associated BTFs, as > there is currently no API in libbpf to fetch list of all BTFs in the > system. > > Suggested-by: Quen

[PATCH net 1/4] net: aquantia: tx clean budget logic error

2019-05-25 Thread Igor Russkikh
In case no other traffic happening on the ring, full tx cleanup may not be completed. That may cause socket buffer to overflow and tx traffic to stuck until next activity on the ring happens. This is due to logic error in budget variable decrementor. Variable is compared with zero, and then post d

[PATCH net 3/4] net: aquantia: fix LRO with FCS error

2019-05-25 Thread Igor Russkikh
From: Dmitry Bogdanov Driver stops producing skbs on ring if a packet with FCS error was coalesced into LRO session. Ring gets hang forever. Thats a logical error in driver processing descriptors: When rx_stat indicates MAC Error, next pointer and eop flags are not filled. This confuses driver s

[PATCH net 4/4] net: aquantia: tcp checksum 0xffff being handled incorrectly

2019-05-25 Thread Igor Russkikh
From: Nikita Danilov Thats a known quirk in windows tcp stack it can produce 0x checksum. Thats incorrect but it is. Atlantic HW with LRO enabled handles that incorrectly and changes csum to 0xfffe - but indicates that csum is invalid. This causes driver to pass packet to linux networking st

[PATCH net 2/4] net: aquantia: check rx csum for all packets in LRO session

2019-05-25 Thread Igor Russkikh
From: Dmitry Bogdanov Atlantic hardware does not aggregate nor breaks LRO sessions with bad csum packets. This means driver should take care of that. If in LRO session there is a non-first descriptor with invalid checksum (L2/L3/L4), the driver must account this information in csum application l

[PATCH net 0/4] net: aquantia: various fixes May, 2019

2019-05-25 Thread Igor Russkikh
Here is a set of various bug fixes found on recent verification stage. Dmitry Bogdanov (2): net: aquantia: check rx csum for all packets in LRO session net: aquantia: fix LRO with FCS error Igor Russkikh (1): net: aquantia: tx clean budget logic error Nikita Danilov (1): net: aquantia:

Re: [PATCH 4/8] ARM/net: ixp4xx: Pass ethernet physical base as resource

2019-05-25 Thread Sergei Shtylyov
Hello! On 24.05.2019 23:00, Andrew Lunn wrote: In order to probe this ethernet interface from the device tree all physical MMIO regions must be passed as resources. Begin this rewrite by first passing the port base address as a resource for all platforms using this driver, remap it in the drive

Re: [PATCH v9 bpf-next 00/17] bpf: eliminate zero extensions for sub-register writes

2019-05-25 Thread Jiong Wang
Alexei Starovoitov writes: > On Fri, May 24, 2019 at 11:25:11PM +0100, Jiong Wang wrote: >> v9: >> - Split patch 5 in v8. >> make bpf uapi header file sync a separate patch. (Alexei) > > 9th time's a charm? ;) Yup :), it's all good things and helped us reaching a solution that fits verifi

Re: [PATCH net-next] vrf: local route leaking

2019-05-25 Thread George Wilkie
On Fri, May 24, 2019 at 02:19:45PM -0600, David Ahern wrote: > I think this codifies the use case: > ip li add vrf-a up type vrf table 1 > ip route add vrf vrf-a unreachable default > ip li add vrf-b up type vrf table 2 > ip route add vrf vrf-b unreachable default > ip ru add pref 32765 f