Re: [PATCH bpf-next 3/3] veth: Support bulk XDP_TX

2019-05-23 Thread Toshiaki Makita
On 2019/05/24 12:54, Jason Wang wrote: > On 2019/5/24 上午11:28, Toshiaki Makita wrote: >> On 2019/05/24 12:13, Jason Wang wrote: >>> On 2019/5/23 下午9:51, Toshiaki Makita wrote: On 19/05/23 (木) 22:29:27, Jesper Dangaard Brouer wrote: > On Thu, 23 May 2019 20:35:50 +0900 > Toshiaki Makita

Re: [PATCH v3 2/2] net: core: support XDP generic on stacked devices.

2019-05-23 Thread Jason Wang
On 2019/5/24 上午3:19, Saeed Mahameed wrote: On Thu, 2019-05-23 at 10:54 -0700, Stephen Hemminger wrote: When a device is stacked like (team, bonding, failsafe or netvsc) the XDP generic program for the parent device was not called. Move the call to XDP generic inside __netif_receive_skb_core w

Re: [PATCH bpf-next 3/3] veth: Support bulk XDP_TX

2019-05-23 Thread Jason Wang
On 2019/5/24 上午11:28, Toshiaki Makita wrote: On 2019/05/24 12:13, Jason Wang wrote: On 2019/5/23 下午9:51, Toshiaki Makita wrote: On 19/05/23 (木) 22:29:27, Jesper Dangaard Brouer wrote: On Thu, 23 May 2019 20:35:50 +0900 Toshiaki Makita wrote: On 2019/05/23 20:25, Toke Høiland-Jørgensen wro

Re: [PATCH bpf-next 3/3] veth: Support bulk XDP_TX

2019-05-23 Thread Toshiaki Makita
On 2019/05/24 12:13, Jason Wang wrote: > On 2019/5/23 下午9:51, Toshiaki Makita wrote: >> On 19/05/23 (木) 22:29:27, Jesper Dangaard Brouer wrote: >>> On Thu, 23 May 2019 20:35:50 +0900 >>> Toshiaki Makita wrote: >>> On 2019/05/23 20:25, Toke Høiland-Jørgensen wrote: > Toshiaki Makita write

Re: [PATCH bpf-next 3/3] veth: Support bulk XDP_TX

2019-05-23 Thread Jason Wang
On 2019/5/23 下午9:51, Toshiaki Makita wrote: On 19/05/23 (木) 22:29:27, Jesper Dangaard Brouer wrote: On Thu, 23 May 2019 20:35:50 +0900 Toshiaki Makita wrote: On 2019/05/23 20:25, Toke Høiland-Jørgensen wrote: Toshiaki Makita writes: This improves XDP_TX performance by about 8%. Here are

Re: [RFC bpf-next 7/7] samples/bpf: add busy-poll support to xdpsock sample

2019-05-23 Thread Ye Xiaolong
Hi, Magnus On 05/02, Magnus Karlsson wrote: >This patch adds busy-poll support to the xdpsock sample >application. It is enabled by the "-b" or the "--busy-poll" command >line options. > >Signed-off-by: Magnus Karlsson >--- > samples/bpf/xdpsock_user.c | 203 --

Re: [PATCH bpf-next 2/3] xdp: Add tracepoint for bulk XDP_TX

2019-05-23 Thread Toshiaki Makita
On 2019/05/23 22:12, Jesper Dangaard Brouer wrote: > On Thu, 23 May 2019 19:56:47 +0900 > Toshiaki Makita wrote: > >> This is introduced for admins to check what is happening on XDP_TX when >> bulk XDP_TX is in use. >> >> Signed-off-by: Toshiaki Makita >> --- >> include/trace/events/xdp.h | 25

Re: [PATCH net] net: dsa: mv88e6xxx: Set correct interface mode for CPU/DSA ports

2019-05-23 Thread Greg Ungerer
Hi Andrew, I have a problem with a Marvell 6390 switch that I have bisected back to commit 7cbbee050c95, "[PATCH] net: dsa: mv88e6xxx: Set correct interface mode for CPU/DSA ports". I have a Marvell 380 SoC based platform with a Marvell 6390 10 port switch, everything works with kernel 5.0 and o

Re: Bug or mis configuration for mlx5e lag and multipath

2019-05-23 Thread wenxu
Hi, I can get the right log from demsg  mlx5_core :81:00.0: modify lag map port 1:1 port 2:2 I debug with the driver, I find the rule be add on mlx_pf0vf0 and the peer one pf1, So I think the esw0 and esw1 both have the rule. The test case is based on the master branch of the net git tre

Re: [net-next 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2019-05-23

2019-05-23 Thread David Miller
From: Jeff Kirsher Date: Thu, 23 May 2019 15:33:25 -0700 > This series contains updates to ice driver only. ... > The following are changes since commit > 16fa1cf1ed2a652a483cf8f1ea65c703693292e8: > Revert "dpaa2-eth: configure the cache stashing amount on a queue" > and are available in the

Re: [PATCH v2] samples: bpf: fix style in bpf_load

2019-05-23 Thread Y Song
On Thu, May 23, 2019 at 12:26 AM Daniel T. Lee wrote: > > This commit fixes style problem in samples/bpf/bpf_load.c > > Styles that have been changed are: > - Magic string use of 'DEBUGFS' > - Useless zero initialization of a global variable > - Minor style fix with whitespace > > Signed-off-by

Re: [PATCH bpf-next v2 1/3] bpf: implement bpf_send_signal() helper

2019-05-23 Thread Yonghong Song
On 5/23/19 4:08 PM, Daniel Borkmann wrote: > On 05/23/2019 11:30 PM, Yonghong Song wrote: >> On 5/23/19 2:07 PM, Yonghong Song wrote: >>> On 5/23/19 9:28 AM, Daniel Borkmann wrote: On 05/23/2019 05:58 PM, Yonghong Song wrote: > On 5/23/19 8:41 AM, Daniel Borkmann wrote: >> On 05/22/2

Re: [PATCH net-next 0/6] add TFO backup key

2019-05-23 Thread Yuchung Cheng
On Thu, May 23, 2019 at 12:14 PM David Miller wrote: > > From: Jason Baron > Date: Wed, 22 May 2019 16:39:32 -0400 > > > Christoph, Igor, and I have worked on an API that facilitates TFO key > > rotation. This is a follow up to the series that Christoph previously > > posted, with an API that mee

Re: [PATCH bpf-next v2 1/3] bpf: implement bpf_send_signal() helper

2019-05-23 Thread Daniel Borkmann
On 05/23/2019 11:30 PM, Yonghong Song wrote: > On 5/23/19 2:07 PM, Yonghong Song wrote: >> On 5/23/19 9:28 AM, Daniel Borkmann wrote: >>> On 05/23/2019 05:58 PM, Yonghong Song wrote: On 5/23/19 8:41 AM, Daniel Borkmann wrote: > On 05/22/2019 07:39 AM, Yonghong Song wrote: >> This patch

Re: [RESEND PATCH] intel-ethernet: warn when fatal read failure happens

2019-05-23 Thread Jeff Kirsher
On Thu, 2019-05-23 at 11:22 +0800, Feng Tang wrote: > Failed in reading the HW register is very serious for igb/igc driver, > as its hw_addr will be set to NULL and cause the adapter be seen as > "REMOVED". > > We saw the error only a few times in the MTBF test for > suspend/resume, > but can hard

Re: [RFC PATCH net-next 5/9] net: phylink: Add phylink_create_raw

2019-05-23 Thread Russell King - ARM Linux admin
On Fri, May 24, 2019 at 01:04:01AM +0300, Vladimir Oltean wrote: > On Fri, 24 May 2019 at 00:55, Russell King - ARM Linux admin > wrote: > > > > On Thu, May 23, 2019 at 01:20:40AM +, Ioana Ciornei wrote: > > > + if (pl->ops) { > > > + pl->ops->mac_link_up(ndev, pl->link_an_mode

[net-next 12/15] ice: Use bitfields when possible

2019-05-23 Thread Jeff Kirsher
From: Jesse Brandeburg We can use bit fields to store boolean values and when the bit fields are next to each other, the compiler will combine them (as long as the size holds enough). Signed-off-by: Jesse Brandeburg Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by:

[net-next 04/15] ice: Remove braces for single statement blocks

2019-05-23 Thread Jeff Kirsher
From: Anirudh Venkataramanan Fix checkpatch warning "WARNING:BRACES: braces {} are not necessary for single statement blocks" Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c | 3 +-- 1 file change

[net-next 10/15] ice: Format ethtool reported stats

2019-05-23 Thread Jeff Kirsher
From: Richard Rodriguez Fixes ethtool -S reported stats in ice driver to match format and nomenclature of the ixgbe driver. Signed-off-by: Richard Rodriguez Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/ice_etht

[net-next 15/15] ice: Silence semantic parser warnings

2019-05-23 Thread Jeff Kirsher
From: Bruce Allan Recent versions of sparse warn about casting pointers to/from restricted endian types in the Linux driver. Silence those with the compiler attribute __force macro from the Linux kernel to force casts to/from restricted endian types. Signed-off-by: Bruce Allan Signed-off-by: A

[net-next 09/15] ice: Gracefully handle reset failure in ice_alloc_vfs()

2019-05-23 Thread Jeff Kirsher
From: Brett Creeley Currently if ice_reset_all_vfs() fails in ice_alloc_vfs() we fail to free some resources, reset variables, and return an error value. Fix this by adding another unroll case to free the pf->vf array, set the pf->num_alloc_vfs to 0, and return an error code. Without this, if ic

[net-next 05/15] ice: Call out dev/func caps when printing

2019-05-23 Thread Jeff Kirsher
From: Anirudh Venkataramanan ice_parse_caps is used to parse both device and function capabilities. Currently, capabilities are printed with a cryptic "HW caps" prefix, which makes it difficult to distinguish whether the capabilities being printed are device or function capabilities. This patch

[net-next 03/15] ice: Cleanup an unnecessary variable initialization

2019-05-23 Thread Jeff Kirsher
From: Bruce Allan Commit 3463688e6ced ("ice: Add more validation in ice_vc_cfg_irq_map_msg") added an assignment of vsi making the assignment during declaration unnecessary. Also, cleanup the declaration and assignment of irqmap_info to not use two lines in the variable declaration section. Sig

[net-next 13/15] ice: Reorganize ice_vf struct

2019-05-23 Thread Jeff Kirsher
From: Jesse Brandeburg The ice_vf struct can be used hundreds of times in our driver so it pays to use less memory per struct. ice_vf prior to this commit: /* size: 112, cachelines: 2, members: 25 */ /* sum members: 101, holes: 4, sum holes: 8 */ /* bit holes: 2, sum bit holes: 11 bits */

[net-next 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2019-05-23

2019-05-23 Thread Jeff Kirsher
This series contains updates to ice driver only. Anirudh cleans up white space issues and other code formatting issues in the driver. Also implemented LLDP persistence across reboots and start/stop of the LLDP agent. Updated print statements for driver capabilities to include if it is a device o

[net-next 08/15] ice: Refactor the LLDP MIB change event handling

2019-05-23 Thread Jeff Kirsher
From: Usha Ketineni This patch fixes the LLDP MIB change event handling code by removing the workarounds in the current code. Added ice_dcb_need_recfg() to print the DCB configuration changes detected via MIB change event. Signed-off-by: Usha Ketineni Signed-off-by: Anirudh Venkataramanan Test

[net-next 06/15] ice: Fix hang when ethtool disables FW LLDP

2019-05-23 Thread Jeff Kirsher
From: Dave Ertman When disabling and enabling VSIs, there are a couple of flows that recursively acquire the RTNL lock which causes a deadlock. Fix that. Signed-off-by: Dave Ertman Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/eth

[net-next 02/15] ice: Implement LLDP persistence

2019-05-23 Thread Jeff Kirsher
From: Anirudh Venkataramanan Implement LLDP persistence across reboots, start and stop of LLDP agent. Add additional parameter to ice_aq_start_lldp and ice_aq_stop_lldp. Also change the ethtool private flag from "disable-fw-lldp" to "enable-fw-lldp". This change will flip the boolean logic of th

[net-next 01/15] ice: Fix double spacing

2019-05-23 Thread Jeff Kirsher
From: Anirudh Venkataramanan Fix double spacing in ice_napi_disable_all Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/ice_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/eth

[net-next 14/15] ice: Fix couple of issues in ice_vsi_release

2019-05-23 Thread Jeff Kirsher
From: Brett Creeley Currently the driver is calling ice_napi_del() and then unregister_netdev(). The call to unregister_netdev() will result in a call to ice_stop() and then ice_vsi_close(). This is where we call napi_disable() for all the MSI-X vectors. This flow is reversed so make the changes

[net-next 07/15] ice: Advertise supported link modes if none requested

2019-05-23 Thread Jeff Kirsher
From: Tony Nguyen User requested link modes affect what is returned as an advertised link mode. If no modes have been requested, we are not advertising any link modes. Advertise what we are capable of supporting if no link modes have been requested. Signed-off-by: Tony Nguyen Signed-off-by: A

[net-next 11/15] ice: Reorganize tx_buf and ring structs

2019-05-23 Thread Jeff Kirsher
From: Jesse Brandeburg Use more efficient structure ordering by using the pahole tool and a lot of code inspection to get hot cache lines to have packed data (no holes if possible) and adjacent warm data. ice_ring prior to this change: /* size: 192, cachelines: 3, members: 23 */ /* sum membe

Re: bonding-devel mail list?

2019-05-23 Thread Jay Vosburgh
Bill Carlson wrote: >On 5/23/19 11:46 AM, Jay Vosburgh wrote: >> As far as I'm aware, nesting bonds has no practical benefit; do >> you have a use case for doing so? >> >> >Use case is very specific, but needed in my situation until some switches >are stabilized. > >Switches A1..Ax provide LACP,

Re: [RFC PATCH net-next 2/9] net: phy: Guard against the presence of a netdev

2019-05-23 Thread Andrew Lunn
On Thu, May 23, 2019 at 01:20:38AM +, Ioana Ciornei wrote: > A prerequisite for PHYLIB to work in the absence of a struct net_device > is to not access pointers to it. > > Changes are needed in the following areas: > > - Printing: In some places netdev_err was replaced with phydev_err. > >

Re: [RFC PATCH net-next 5/9] net: phylink: Add phylink_create_raw

2019-05-23 Thread Vladimir Oltean
On Fri, 24 May 2019 at 00:55, Russell King - ARM Linux admin wrote: > > On Thu, May 23, 2019 at 01:20:40AM +, Ioana Ciornei wrote: > > + if (pl->ops) { > > + pl->ops->mac_link_up(ndev, pl->link_an_mode, > >pl->phy_state.interface, > >

Re: [RFC PATCH net-next 7/9] net: dsa: Move the phylink driver calls into port.c

2019-05-23 Thread Russell King - ARM Linux admin
On Thu, May 23, 2019 at 01:20:41AM +, Ioana Ciornei wrote: > diff --git a/net/dsa/port.c b/net/dsa/port.c > index ed8ba9daa3ba..d0f955e8b731 100644 > --- a/net/dsa/port.c > +++ b/net/dsa/port.c > @@ -422,6 +422,102 @@ static struct phy_device > *dsa_port_get_phy_device(struct dsa_port *dp) >

Re: [RFC PATCH net-next 5/9] net: phylink: Add phylink_create_raw

2019-05-23 Thread Russell King - ARM Linux admin
On Thu, May 23, 2019 at 01:20:40AM +, Ioana Ciornei wrote: > + if (pl->ops) { > + pl->ops->mac_link_up(ndev, pl->link_an_mode, >pl->phy_state.interface, >pl->phydev); > > + netif_carrier_on(ndev); > > +

[PATCH bpf-next v5 2/3] tools/bpf: sync bpf uapi header bpf.h to tools directory

2019-05-23 Thread Yonghong Song
The bpf uapi header include/uapi/linux/bpf.h is sync'ed to tools/include/uapi/linux/bpf.h. Acked-by: Andrii Nakryiko Signed-off-by: Yonghong Song --- tools/include/uapi/linux/bpf.h | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/tools/include/uapi/linux/bpf

[PATCH bpf-next v5 0/3] bpf: implement bpf_send_signal() helper

2019-05-23 Thread Yonghong Song
This patch tries to solve the following specific use case. Currently, bpf program can already collect stack traces through kernel function get_perf_callchain() when certain events happens (e.g., cache miss counter or cpu clock counter overflows). But such stack traces are not enough for jitted p

[PATCH bpf-next v5 1/3] bpf: implement bpf_send_signal() helper

2019-05-23 Thread Yonghong Song
This patch tries to solve the following specific use case. Currently, bpf program can already collect stack traces through kernel function get_perf_callchain() when certain events happens (e.g., cache miss counter or cpu clock counter overflows). But such stack traces are not enough for jitted pro

[PATCH bpf-next v5 3/3] tools/bpf: add selftest in test_progs for bpf_send_signal() helper

2019-05-23 Thread Yonghong Song
The test covered both nmi and tracepoint perf events. $ ./test_progs ... test_send_signal_tracepoint:PASS:tracepoint 0 nsec ... test_send_signal_common:PASS:tracepoint 0 nsec ... test_send_signal_common:PASS:perf_event 0 nsec ... test_send_signal:OK Acked-by: Andrii Nakryiko Sig

Re: [PATCH 00/11] Netfilter/IPVS fixes for net

2019-05-23 Thread David Miller
From: Pablo Neira Ayuso Date: Thu, 23 May 2019 23:35:36 +0200 > The following patchset contains Netfilter/IPVS fixes for your net tree: ... > You can pull these changes from: > > git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git Pulled, thanks.

Re: [RFC PATCH net-next 5/9] net: phylink: Add phylink_create_raw

2019-05-23 Thread Vladimir Oltean
On Fri, 24 May 2019 at 00:28, Russell King - ARM Linux admin wrote: > > On Thu, May 23, 2019 at 01:20:40AM +, Ioana Ciornei wrote: > > @@ -111,7 +114,16 @@ static const char *phylink_an_mode_str(unsigned int > > mode) > > static int phylink_validate(struct phylink *pl, unsigned long *support

[PATCH 01/11] netfilter: nf_tables: fix oops during rule dump

2019-05-23 Thread Pablo Neira Ayuso
From: Florian Westphal We can oops in nf_tables_fill_rule_info(). Its not possible to fetch previous element in rcu-protected lists when deletions are not prevented somehow: list_del_rcu poisons the ->prev pointer value. Before rcu-conversion this was safe as dump operations did hold nfnetlink

[PATCH 11/11] selftests: netfilter: add flowtable test script

2019-05-23 Thread Pablo Neira Ayuso
From: Florian Westphal Exercises 3 cases: 1. no pmtu discovery (need to frag) 2. no PMTUd + NAT (don't flag packets as invalid from conntrack) 3. PMTU + NAT (need to send icmp error) The first two cases make sure we handle fragments correctly, i.e. pass them to classic forwarding path. Third c

[PATCH 05/11] selftests: netfilter: missing error check when setting up veth interface

2019-05-23 Thread Pablo Neira Ayuso
From: Jeffrin Jose T A test for the basic NAT functionality uses ip command which needs veth device. There is a condition where the kernel support for veth is not compiled into the kernel and the test script breaks. This patch contains code for reasonable error display and correct code exit. Sig

[PATCH 04/11] ipvs: Fix use-after-free in ip_vs_in

2019-05-23 Thread Pablo Neira Ayuso
From: YueHaibing BUG: KASAN: use-after-free in ip_vs_in.part.29+0xe8/0xd20 [ip_vs] Read of size 4 at addr 8881e9b26e2c by task sshd/5603 CPU: 0 PID: 5603 Comm: sshd Not tainted 4.19.39+ #30 Hardware name: Red Hat KVM, BIOS 0.5.1 01/01/2011 Call Trace: dump_stack+0x71/0xab print_address_des

[PATCH 08/11] netfilter: nft_flow_offload: set liberal tracking mode for tcp

2019-05-23 Thread Pablo Neira Ayuso
From: Florian Westphal Without it, whenever a packet has to be pushed up the stack (e.g. because of mtu mismatch), then conntrack will flag packets as invalid, which in turn breaks NAT. Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nft_flow_offload.c | 8 +

[PATCH 07/11] netfilter: nf_flow_table: ignore DF bit setting

2019-05-23 Thread Pablo Neira Ayuso
From: Florian Westphal Its irrelevant if the DF bit is set or not, we must pass packet to stack in either case. If the DF bit is set, we must pass it to stack so the appropriate ICMP error can be generated. If the DF is not set, we must pass it to stack for fragmentation. Signed-off-by: Floria

[PATCH 03/11] netfilter: nft_fib: Fix existence check support

2019-05-23 Thread Pablo Neira Ayuso
From: Phil Sutter NFTA_FIB_F_PRESENT flag was not always honored since eval functions did not call nft_fib_store_result in all cases. Given that in all callsites there is a struct net_device pointer available which holds the interface data to be stored in destination register, simplify nft_fib_s

[PATCH 09/11] netfilter: nft_flow_offload: don't offload when sequence numbers need adjustment

2019-05-23 Thread Pablo Neira Ayuso
From: Florian Westphal We can't deal with tcp sequence number rewrite in flow_offload. While at it, simplify helper check, we only need to know if the extension is present, we don't need the helper data. Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nft_fl

[PATCH 02/11] netfilter: nf_queue: fix reinject verdict handling

2019-05-23 Thread Pablo Neira Ayuso
From: Jagdish Motwani This patch fixes netfilter hook traversal when there are more than 1 hooks returning NF_QUEUE verdict. When the first queue reinjects the packet, 'nf_reinject' starts traversing hooks with a proper hook_index. However, if it again receives a NF_QUEUE verdict (by some other n

[PATCH 06/11] netfilter: nat: fix udp checksum corruption

2019-05-23 Thread Pablo Neira Ayuso
From: Florian Westphal Due to copy&paste error nf_nat_mangle_udp_packet passes IPPROTO_TCP, resulting in incorrect udp checksum when payload had to be mangled. Fixes: dac3fe72596f9 ("netfilter: nat: remove csum_recalc hook") Reported-by: Marc Haber Tested-by: Marc Haber Signed-off-by: Florian

[PATCH 00/11] Netfilter/IPVS fixes for net

2019-05-23 Thread Pablo Neira Ayuso
Hi David, The following patchset contains Netfilter/IPVS fixes for your net tree: 1) Fix crash when dumping rules after conversion to RCU, from Florian Westphal. 2) Fix incorrect hook reinjection from nf_queue in case NF_REPEAT, from Jagdish Motwani. 3) Fix check for route existence in fi

[PATCH 10/11] netfilter: nft_flow_offload: IPCB is only valid for ipv4 family

2019-05-23 Thread Pablo Neira Ayuso
From: Florian Westphal Guard this with a check vs. ipv4, IPCB isn't valid in ipv6 case. Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nft_flow_offload.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/net/netfilter/nf

Re: [PATCH bpf-next v2 1/3] bpf: implement bpf_send_signal() helper

2019-05-23 Thread Yonghong Song
On 5/23/19 2:07 PM, Yonghong Song wrote: > > > On 5/23/19 9:28 AM, Daniel Borkmann wrote: >> On 05/23/2019 05:58 PM, Yonghong Song wrote: >>> On 5/23/19 8:41 AM, Daniel Borkmann wrote: On 05/22/2019 07:39 AM, Yonghong Song wrote: > This patch tries to solve the following specific use c

Re: [RFC PATCH net-next 5/9] net: phylink: Add phylink_create_raw

2019-05-23 Thread Florian Fainelli
On 5/23/19 1:32 PM, Vladimir Oltean wrote: > On 5/23/19 5:32 PM, Florian Fainelli wrote: >> >> On 5/23/2019 5:10 AM, Ioana Ciornei wrote: >>> Subject: Re: [RFC PATCH net-next 5/9] net: phylink: Add phylink_create_raw On 5/22/2019 7:25 PM, Florian Fainelli wrote: >

Re: [RFC PATCH net-next 5/9] net: phylink: Add phylink_create_raw

2019-05-23 Thread Russell King - ARM Linux admin
On Thu, May 23, 2019 at 01:20:40AM +, Ioana Ciornei wrote: > @@ -111,7 +114,16 @@ static const char *phylink_an_mode_str(unsigned int mode) > static int phylink_validate(struct phylink *pl, unsigned long *supported, > struct phylink_link_state *state) > { > - pl-

Re: [PATCH bpf-next v2 1/3] bpf: implement bpf_send_signal() helper

2019-05-23 Thread Yonghong Song
On 5/23/19 9:28 AM, Daniel Borkmann wrote: > On 05/23/2019 05:58 PM, Yonghong Song wrote: >> On 5/23/19 8:41 AM, Daniel Borkmann wrote: >>> On 05/22/2019 07:39 AM, Yonghong Song wrote: This patch tries to solve the following specific use case. Currently, bpf program can already col

Re: [PATCH bpf-next v2 1/3] tools: bpftool: add -d option to get debug output from libbpf

2019-05-23 Thread Andrii Nakryiko
On Thu, May 23, 2019 at 1:44 PM Jakub Kicinski wrote: > > On Thu, 23 May 2019 09:20:52 -0700, Andrii Nakryiko wrote: > > On Thu, May 23, 2019 at 3:54 AM Quentin Monnet wrote: > > > > > > libbpf has three levels of priority for output messages: warn, info, > > > debug. By default, debug output is n

Re: [PATCH v2 bpf-next 10/12] bpftool: add C output format option to btf dump subcommand

2019-05-23 Thread Jakub Kicinski
On Thu, 23 May 2019 13:42:20 -0700, Andrii Nakryiko wrote: > Utilize new libbpf's btf_dump API to emit BTF as a C definitions. > > Signed-off-by: Andrii Nakryiko Acked-by: Jakub Kicinski Thanks!

Re: [PATCH bpf-next v2 1/3] tools: bpftool: add -d option to get debug output from libbpf

2019-05-23 Thread Jakub Kicinski
On Thu, 23 May 2019 09:20:52 -0700, Andrii Nakryiko wrote: > On Thu, May 23, 2019 at 3:54 AM Quentin Monnet wrote: > > > > libbpf has three levels of priority for output messages: warn, info, > > debug. By default, debug output is not printed to the console. > > > > Add a new "--debug" (short name:

[PATCH v2 bpf-next 07/12] libbpf: switch btf_dedup() to hashmap for dedup table

2019-05-23 Thread Andrii Nakryiko
Utilize libbpf's hashmap as a multimap fof dedup_table implementation. Signed-off-by: Andrii Nakryiko --- tools/lib/bpf/btf.c | 201 +++- 1 file changed, 85 insertions(+), 116 deletions(-) diff --git a/tools/lib/bpf/btf.c b/tools/lib/bpf/btf.c index 61395

[PATCH v2 bpf-next 08/12] libbpf: add btf_dump API for BTF-to-C conversion

2019-05-23 Thread Andrii Nakryiko
BTF contains enough type information to allow generating valid compilable C header w/ correct layout of structs/unions and all the typedef/enum definitions. This patch adds a new "object" - btf_dump to facilitate dumping BTF as valid C. btf_dump__dump_type() is the main API which takes care of dump

[PATCH v2 bpf-next 12/12] bpftool: update bash-completion w/ new c option for btf dump

2019-05-23 Thread Andrii Nakryiko
Add bash completion for new C btf dump option. Cc: Quentin Monnet Signed-off-by: Andrii Nakryiko --- tools/bpf/bpftool/bash-completion/bpftool | 25 +++ 1 file changed, 21 insertions(+), 4 deletions(-) diff --git a/tools/bpf/bpftool/bash-completion/bpftool b/tools/bpf/bpft

[PATCH v2 bpf-next 09/12] selftests/bpf: add btf_dump BTF-to-C conversion tests

2019-05-23 Thread Andrii Nakryiko
Add new test_btf_dump set of tests, validating BTF-to-C conversion correctness. Tests rely on clang to generate BTF from provided C test cases. Signed-off-by: Andrii Nakryiko --- tools/testing/selftests/bpf/.gitignore| 1 + tools/testing/selftests/bpf/Makefile | 3 +- .../bp

[PATCH v2 bpf-next 11/12] bpftool/docs: add description of btf dump C option

2019-05-23 Thread Andrii Nakryiko
Document optional **c** option for btf dump subcommand. Cc: Quentin Monnet Signed-off-by: Andrii Nakryiko --- tools/bpf/bpftool/Documentation/bpftool-btf.rst | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tools/bpf/bpftool/Documentation/bpftool-btf.rst b/tools/bpf/bp

[PATCH v2 bpf-next 10/12] bpftool: add C output format option to btf dump subcommand

2019-05-23 Thread Andrii Nakryiko
Utilize new libbpf's btf_dump API to emit BTF as a C definitions. Signed-off-by: Andrii Nakryiko --- tools/bpf/bpftool/btf.c | 74 +++-- 1 file changed, 72 insertions(+), 2 deletions(-) diff --git a/tools/bpf/bpftool/btf.c b/tools/bpf/bpftool/btf.c index a22e

[PATCH v2 bpf-next 02/12] libbpf: add btf__parse_elf API to load .BTF and .BTF.ext

2019-05-23 Thread Andrii Nakryiko
Loading BTF and BTF.ext from ELF file is a common need. Instead of requiring every user to re-implement it, let's provide this API from libbpf itself. It's mostly copy/paste from `bpftool btf dump` implementation, which will be switched to libbpf's version in next patch. btf__parse_elf allows to lo

[PATCH v2 bpf-next 01/12] libbpf: ensure libbpf.h is included along libbpf_internal.h

2019-05-23 Thread Andrii Nakryiko
libbpf_internal.h expects a bunch of stuff defined in libbpf.h to be defined. This patch makes sure that libbpf.h is always included. Signed-off-by: Andrii Nakryiko --- tools/lib/bpf/libbpf_internal.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/lib/bpf/libbpf_internal.h b/tools/l

[PATCH v2 bpf-next 05/12] libbpf: add resizable non-thread safe internal hashmap

2019-05-23 Thread Andrii Nakryiko
There is a need for fast point lookups inside libbpf for multiple use cases (e.g., name resolution for BTF-to-C conversion, by-name lookups in BTF for upcoming BPF CO-RE relocation support, etc). This patch implements simple resizable non-thread safe hashmap using single linked list chains. Four d

[PATCH v2 bpf-next 06/12] selftests/bpf: add tests for libbpf's hashmap

2019-05-23 Thread Andrii Nakryiko
Test all APIs for internal hashmap implementation. Signed-off-by: Andrii Nakryiko --- tools/testing/selftests/bpf/.gitignore | 1 + tools/testing/selftests/bpf/Makefile | 2 +- tools/testing/selftests/bpf/test_hashmap.c | 382 + 3 files changed, 384 insertions(+

[PATCH v2 bpf-next 04/12] selftests/bpf: use btf__parse_elf to check presence of BTF/BTF.ext

2019-05-23 Thread Andrii Nakryiko
Switch test_btf.c to rely on btf__parse_elf to check presence of BTF and BTF.ext data, instead of implementing its own ELF parsing. Signed-off-by: Andrii Nakryiko --- tools/testing/selftests/bpf/test_btf.c | 71 +- 1 file changed, 13 insertions(+), 58 deletions(-) diff -

Re: [PATCH v7 bpf-next 01/16] bpf: verifier: mark verified-insn with sub-register zext flag

2019-05-23 Thread Alexei Starovoitov
On Thu, May 23, 2019 at 09:20:15PM +0100, Jiong Wang wrote: > > Alexei Starovoitov writes: > > > > > well, it made me realize that we're probably doing it wrong, > > since after calling check_reg_arg() we need to re-parse insn encoding. > > How about we change check_reg_arg()'s enum reg_arg_typ

[PATCH v2 bpf-next 03/12] bpftool: use libbpf's btf__parse_elf API

2019-05-23 Thread Andrii Nakryiko
Use btf__parse_elf() API, provided by libbpf, instead of implementing ELF parsing by itself. Signed-off-by: Andrii Nakryiko --- tools/bpf/bpftool/btf.c | 117 +++- 1 file changed, 8 insertions(+), 109 deletions(-) diff --git a/tools/bpf/bpftool/btf.c b/tools/

[PATCH v2 bpf-next 00/12] BTF-to-C converter

2019-05-23 Thread Andrii Nakryiko
This patch set adds BTF-to-C dumping APIs to libbpf, allowing to output a subset of BTF types as a compilable C type definitions. This is useful by itself, as raw BTF output is not easy to inspect and comprehend. But it's also a big part of BPF CO-RE (compile once - run everywhere) initiative aimed

Re: [RFC PATCH net-next 5/9] net: phylink: Add phylink_create_raw

2019-05-23 Thread Vladimir Oltean
On 5/23/19 5:32 PM, Florian Fainelli wrote: On 5/23/2019 5:10 AM, Ioana Ciornei wrote: Subject: Re: [RFC PATCH net-next 5/9] net: phylink: Add phylink_create_raw On 5/22/2019 7:25 PM, Florian Fainelli wrote: On 5/22/2019 6:20 PM, Ioana Ciornei wrote: This adds a new entry point to PHYL

Re: [PATCH v7 bpf-next 01/16] bpf: verifier: mark verified-insn with sub-register zext flag

2019-05-23 Thread Jiong Wang
Alexei Starovoitov writes: > well, it made me realize that we're probably doing it wrong, > since after calling check_reg_arg() we need to re-parse insn encoding. > How about we change check_reg_arg()'s enum reg_arg_type instead? This is exactly what I had implemented in my initial internal v

Re: [PATCH v3 2/2] net: core: support XDP generic on stacked devices.

2019-05-23 Thread Stephen Hemminger
On Thu, 23 May 2019 19:19:40 + Saeed Mahameed wrote: > On Thu, 2019-05-23 at 10:54 -0700, Stephen Hemminger wrote: > > When a device is stacked like (team, bonding, failsafe or netvsc) the > > XDP generic program for the parent device was not called. > > > > Move the call to XDP generic insi

Re: bonding-devel mail list?

2019-05-23 Thread Bill Carlson
On 5/23/19 11:46 AM, Jay Vosburgh wrote: As far as I'm aware, nesting bonds has no practical benefit; do you have a use case for doing so? Use case is very specific, but needed in my situation until some switches are stabilized. Switches A1..Ax provide LACP, 40G. These are unstable, lose lin

Re: [PATCH 2/8] dt-bindings: net: Add a YAML schemas for the generic PHY options

2019-05-23 Thread Maxime Ripard
Hi Andrew, (Sorry for not CC'ing you on this) On Thu, May 23, 2019 at 04:37:44PM +0200, Andrew Lunn wrote: > On Thu, May 23, 2019 at 11:56:45AM +0200, Maxime Ripard wrote: > > The networking PHYs have a number of available device tree properties that > > can be used in their device tree node. Add

Re: [RFC PATCH net-next 8/9] net: dsa: Use PHYLINK for the CPU/DSA ports

2019-05-23 Thread Vladimir Oltean
On Thu, 23 May 2019 at 05:17, Florian Fainelli wrote: > > On 5/22/2019 6:20 PM, Ioana Ciornei wrote: > > This completely removes the usage of PHYLIB from DSA, namely for the > > aforementioned switch ports which used to drive a software PHY manually > > using genphy operations. > > > > For these p

Re: [PATCH 1/8] dt-bindings: net: Add YAML schemas for the generic Ethernet options

2019-05-23 Thread Maxime Ripard
Hi Rob, Thanks for the review, On Thu, May 23, 2019 at 08:10:22AM -0500, Rob Herring wrote: > > + fixed-link: > > +allOf: > > + - if: > > + type: array > > +then: > > + minItems: 1 > > + maxItems: 1 > > + items: > > +type: array >

Re: [PATCH net-next 0/6] add TFO backup key

2019-05-23 Thread David Miller
From: Jason Baron Date: Wed, 22 May 2019 16:39:32 -0400 > Christoph, Igor, and I have worked on an API that facilitates TFO key > rotation. This is a follow up to the series that Christoph previously > posted, with an API that meets both of our use-cases. Here's a > link to the previous work: >

[PATCH net-next] udp: Avoid post-GRO UDP checksum recalculation

2019-05-23 Thread Sean Tranchetti
Currently, when resegmenting an unexpected UDP GRO packet, the full UDP checksum will be calculated for every new SKB created by skb_segment() because the netdev features passed in by udp_rcv_segment() lack any information about checksum offload capabilities. We have no need to perform this calcul

Re: [PATCH v3 2/2] net: core: support XDP generic on stacked devices.

2019-05-23 Thread Saeed Mahameed
On Thu, 2019-05-23 at 10:54 -0700, Stephen Hemminger wrote: > When a device is stacked like (team, bonding, failsafe or netvsc) the > XDP generic program for the parent device was not called. > > Move the call to XDP generic inside __netif_receive_skb_core where > it can be done multiple times for

Re: [patch net-next 0/7] expose flash update status to user

2019-05-23 Thread Saeed Mahameed
On Thu, 2019-05-23 at 11:45 +0200, Jiri Pirko wrote: > From: Jiri Pirko > > When user is flashing device using devlink, he currenly does not see > any > information about what is going on, percentages, etc. > Drivers, for example mlxsw and mlx5, have notion about the progress > and what is happen

Re: [patch net-next 3/7] mlxfw: Propagate error messages through extack

2019-05-23 Thread Saeed Mahameed
On Thu, 2019-05-23 at 09:19 -0600, David Ahern wrote: > On 5/23/19 3:45 AM, Jiri Pirko wrote: > > @@ -57,11 +58,13 @@ static int mlxfw_fsm_state_wait(struct > > mlxfw_dev *mlxfw_dev, u32 fwhandle, > > if (fsm_state_err != MLXFW_FSM_STATE_ERR_OK) { > > pr_err("Firmware flash failed:

Re: [PATCH net-next v2 3/3] net: phy: aquantia: add USXGMII support and warn if XGMII mode is set

2019-05-23 Thread Florian Fainelli
On 5/23/19 11:09 AM, Heiner Kallweit wrote: > So far we didn't support mode USXGMII, and in order to not break few > boards mode XGMII was accepted for the AQR107 family even though it > doesn't support XGMII. Add USXGMII support to the Aquantia PHY driver > and warn if XGMII mode is set. > > v2:

Re: [PATCH net-next v2 2/3] dt-bindings: net: document new usxgmii phy mode

2019-05-23 Thread Florian Fainelli
On 5/23/19 11:07 AM, Heiner Kallweit wrote: > Add new interface mode USXGMII to binding documentation. > > Signed-off-by: Heiner Kallweit Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH 2/8] dt-bindings: net: Add a YAML schemas for the generic PHY options

2019-05-23 Thread Florian Fainelli
On 5/23/19 2:56 AM, Maxime Ripard wrote: > The networking PHYs have a number of available device tree properties that > can be used in their device tree node. Add a YAML schemas for those. > > Signed-off-by: Maxime Ripard > --- > Documentation/devicetree/bindings/net/ethernet-phy.yaml | 148

Re: [PATCH net-next v2 3/3] net: phy: aquantia: add USXGMII support and warn if XGMII mode is set

2019-05-23 Thread Andrew Lunn
On Thu, May 23, 2019 at 08:09:08PM +0200, Heiner Kallweit wrote: > So far we didn't support mode USXGMII, and in order to not break few > boards mode XGMII was accepted for the AQR107 family even though it > doesn't support XGMII. Add USXGMII support to the Aquantia PHY driver > and warn if XGMII m

Re: [PATCH net-next v2 2/3] dt-bindings: net: document new usxgmii phy mode

2019-05-23 Thread Andrew Lunn
On Thu, May 23, 2019 at 08:07:56PM +0200, Heiner Kallweit wrote: > Add new interface mode USXGMII to binding documentation. > > Signed-off-by: Heiner Kallweit Reviewed-by: Andrew Lunn Andrew

[PATCH net-next v2 1/3] net: phy: add interface mode PHY_INTERFACE_MODE_USXGMII

2019-05-23 Thread Heiner Kallweit
Add support for interface mode PHY_INTERFACE_MODE_USXGMII. Signed-off-by: Heiner Kallweit Reviewed-by: Florian Fainelli --- include/linux/phy.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/phy.h b/include/linux/phy.h index 073fb151b..7180b1d1e 100644 --- a/include/linux/

[PATCH net-next v2 3/3] net: phy: aquantia: add USXGMII support and warn if XGMII mode is set

2019-05-23 Thread Heiner Kallweit
So far we didn't support mode USXGMII, and in order to not break few boards mode XGMII was accepted for the AQR107 family even though it doesn't support XGMII. Add USXGMII support to the Aquantia PHY driver and warn if XGMII mode is set. v2: - add warning if XGMII mode is set Signed-off-by: Heine

[PATCH net-next v2 2/3] dt-bindings: net: document new usxgmii phy mode

2019-05-23 Thread Heiner Kallweit
Add new interface mode USXGMII to binding documentation. Signed-off-by: Heiner Kallweit --- v2: - binding documentation change added to the series --- Documentation/devicetree/bindings/net/ethernet.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/net/ethe

[PATCH net-next v2 0/3] net: phy: add interface mode PHY_INTERFACE_MODE_USXGMII

2019-05-23 Thread Heiner Kallweit
Add support for interface mode USXGMII. On Freescale boards LS1043A and LS1046A a warning may pop up now because mode xgmii should be changed to usxgmii (as the used Aquantia PHY doesn't support XGMII). Heiner Kallweit (3): net: phy: add interface mode PHY_INTERFACE_MODE_USXGMII dt-bindings:

Re: [patch iproute2 3/3] devlink: implement flash status monitoring

2019-05-23 Thread Jakub Kicinski
On Thu, 23 May 2019 11:47:10 +0200, Jiri Pirko wrote: > From: Jiri Pirko > > Listen to status notifications coming from kernel during flashing and > put them on stdout to inform user about the status. > > Signed-off-by: Jiri Pirko > +static int cmd_dev_flash_status_cb(const struct nlmsghdr *nl

[PATCH v3 1/2] netvsc: unshare skb in VF rx handler

2019-05-23 Thread Stephen Hemminger
The netvsc VF skb handler should make sure that skb is not shared. Similar logic already exists in bonding and team device drivers. This is not an issue in practice because the VF devicex does not send up shared skb's. But the netvsc driver should do the right thing if it did. Fixes: 0c195567a8f6

[PATCH v3 2/2] net: core: support XDP generic on stacked devices.

2019-05-23 Thread Stephen Hemminger
When a device is stacked like (team, bonding, failsafe or netvsc) the XDP generic program for the parent device was not called. Move the call to XDP generic inside __netif_receive_skb_core where it can be done multiple times for stacked case. Suggested-by: Jiri Pirko Fixes: d445516966dc ("net: x

  1   2   3   >