Re: [PATCH bpf] selftests: bpf: add zero extend checks for ALU32 and/or/xor

2019-05-22 Thread Y Song
On Wed, May 22, 2019 at 1:46 PM Björn Töpel wrote: > > On Wed, 22 May 2019 at 20:13, Y Song wrote: > > > > On Wed, May 22, 2019 at 2:25 AM Björn Töpel wrote: > > > > > > Add three tests to test_verifier/basic_instr that make sure that the > > > high 32-bits of the destination register is cleared

Re: [PATCH bpf-next 1/2] net: xdp: refactor XDP_QUERY_PROG{,_HW} to netdev

2019-05-22 Thread Björn Töpel
On Thu, 23 May 2019 at 07:47, Saeed Mahameed wrote: > > On Wed, 2019-05-22 at 14:53 +0200, Björn Töpel wrote: > > From: Björn Töpel > > > > All XDP capable drivers need to implement the XDP_QUERY_PROG{,_HW} > > command of ndo_bpf. The query code is fairly generic. This commit > > refactors the qu

[PATCH net] net: sched: don't use tc_action->order during action dump

2019-05-22 Thread Vlad Buslov
Function tcf_action_dump() relies on tc_action->order field when starting nested nla to send action data to userspace. This approach breaks in several cases: - When multiple filters point to same shared action, tc_action->order field is overwritten each time it is attached to filter. This causes

[PATCH bpf-next v4 3/3] tools/bpf: add selftest in test_progs for bpf_send_signal() helper

2019-05-22 Thread Yonghong Song
The test covered both nmi and tracepoint perf events. $ ./test_progs ... test_send_signal_tracepoint:PASS:tracepoint 0 nsec ... test_send_signal_common:PASS:tracepoint 0 nsec ... test_send_signal_common:PASS:perf_event 0 nsec ... test_send_signal:OK Acked-by: Andrii Nakryiko Sig

[PATCH bpf-next v4 2/3] tools/bpf: sync bpf uapi header bpf.h to tools directory

2019-05-22 Thread Yonghong Song
The bpf uapi header include/uapi/linux/bpf.h is sync'ed to tools/include/uapi/linux/bpf.h. Acked-by: Andrii Nakryiko Signed-off-by: Yonghong Song --- tools/include/uapi/linux/bpf.h | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/tools/include/uapi/linux/bpf

[PATCH bpf-next v4 1/3] bpf: implement bpf_send_signal() helper

2019-05-22 Thread Yonghong Song
This patch tries to solve the following specific use case. Currently, bpf program can already collect stack traces through kernel function get_perf_callchain() when certain events happens (e.g., cache miss counter or cpu clock counter overflows). But such stack traces are not enough for jitted pro

[PATCH bpf-next v4 0/3] bpf: implement bpf_send_signal() helper

2019-05-22 Thread Yonghong Song
This patch tries to solve the following specific use case. Currently, bpf program can already collect stack traces through kernel function get_perf_callchain() when certain events happens (e.g., cache miss counter or cpu clock counter overflows). But such stack traces are not enough for jitted pro

Re: DSA setup IMX6ULL and Marvell 88E6390 with 2 Ethernet Phys - CPU Port is not working

2019-05-22 Thread Benjamin Beckmeyer
On 22.05.19 18:32, Andrew Lunn wrote: > On Wed, May 22, 2019 at 10:33:29AM +0200, Benjamin Beckmeyer wrote: >> Hi all, >> >> I'm currently working on a custom board with the imx6ull processor and the >> 6390 >> switching chip. This is our hardware setup. >> >> -

Re: LPC networking track?

2019-05-22 Thread Saeed Mahameed
On Wed, 2019-05-22 at 10:11 -0700, David Miller wrote: > From: Jesse Brandeburg > Date: Wed, 22 May 2019 09:36:44 -0700 > > > Hi, is there any update on the plan for the networking track at > > Plumbers (LPC) in Lisbon this year? Last year there was a CFP, but > > if > > there was one this year

Re: [PATCH bpf-next v3 3/3] tools/bpf: add selftest in test_progs for bpf_send_signal() helper

2019-05-22 Thread Yonghong Song
On 5/22/19 8:47 PM, Andrii Nakryiko wrote: > On Wed, May 22, 2019 at 4:16 PM Yonghong Song wrote: >> >> The test covered both nmi and tracepoint perf events. >>$ ./test_progs >>... >>test_send_signal_tracepoint:PASS:tracepoint 0 nsec >>... >>test_send_signal_common:PASS:trace

Re: [PATCH bpf-next 1/2] net: xdp: refactor XDP_QUERY_PROG{,_HW} to netdev

2019-05-22 Thread Saeed Mahameed
On Wed, 2019-05-22 at 14:53 +0200, Björn Töpel wrote: > From: Björn Töpel > > All XDP capable drivers need to implement the XDP_QUERY_PROG{,_HW} > command of ndo_bpf. The query code is fairly generic. This commit > refactors the query code up from the drivers to the netdev level. > > The struct

Re: [PATCH net] ipv4/igmp: fix build error if !CONFIG_IP_MULTICAST

2019-05-22 Thread David Miller
From: Eric Dumazet Date: Wed, 22 May 2019 18:35:16 -0700 > ip_sf_list_clear_all() needs to be defined even if !CONFIG_IP_MULTICAST > > Fixes: 3580d04aa674 ("ipv4/igmp: fix another memory leak in > igmpv3_del_delrec()") > Signed-off-by: Eric Dumazet > Reported-by: kbuild test robot Applied, t

Re: [PATCH bpf-next 10/12] bpftool: add C output format option to btf dump subcommand

2019-05-22 Thread Andrii Nakryiko
On Wed, May 22, 2019 at 6:23 PM Jakub Kicinski wrote: > > On Wed, 22 May 2019 17:58:23 -0700, Andrii Nakryiko wrote: > > On Wed, May 22, 2019 at 5:25 PM Jakub Kicinski wrote: > > > On Wed, 22 May 2019 12:50:51 -0700, Andrii Nakryiko wrote: > > > > + * Copyright (C) 2019 Facebook > > > > + */ > > >

Re: [PATCH bpf-next 06/12] selftests/bpf: add tests for libbpf's hashmap

2019-05-22 Thread Andrii Nakryiko
On Wed, May 22, 2019 at 3:15 PM Andrii Nakryiko wrote: > > On Wed, May 22, 2019 at 1:31 PM Stanislav Fomichev wrote: > > > > On 05/22, Andrii Nakryiko wrote: > > > Test all APIs for internal hashmap implementation. > > > > > > Signed-off-by: Andrii Nakryiko > > > --- > > > tools/testing/selftes

Re: [PATCH net-next 2/2] net: phy: aquantia: add USXGMII support

2019-05-22 Thread Heiner Kallweit
On 22.05.2019 22:58, Andrew Lunn wrote: > On Wed, May 22, 2019 at 09:58:32PM +0200, Heiner Kallweit wrote: >> So far we didn't support mode USXGMII, and in order to not break the >> two Freescale boards mode XGMII was accepted for the AQR107 family >> even though it doesn't support XGMII. Add USXGM

Re: [PATCH bpf-next v3 3/3] tools/bpf: add selftest in test_progs for bpf_send_signal() helper

2019-05-22 Thread Andrii Nakryiko
On Wed, May 22, 2019 at 4:16 PM Yonghong Song wrote: > > The test covered both nmi and tracepoint perf events. > $ ./test_progs > ... > test_send_signal_tracepoint:PASS:tracepoint 0 nsec > ... > test_send_signal_common:PASS:tracepoint 0 nsec > ... > test_send_signal_common:PASS:perf_

Re: [PATCH iproute2] ip route: Set rtm_dst_len to 32 for all ip route get requests

2019-05-22 Thread David Ahern
On 5/22/19 5:16 PM, Stephen Hemminger wrote: > On Fri, 17 May 2019 10:59:13 -0700 > David Ahern wrote: > >> index 2b3dcc5dbd53..d980b86ffd42 100644 >> --- a/ip/iproute.c >> +++ b/ip/iproute.c >> @@ -2035,7 +2035,11 @@ static int iproute_get(int argc, char **argv) >> if (addr.

[PATCH net-next 6/7] ipv6: Refactor ip6_route_del for cached routes

2019-05-22 Thread David Ahern
From: David Ahern Move the removal of cached routes to a helper, ip6_del_cached_rt, that can be invoked per nexthop. Rename the existig ip6_del_cached_rt to __ip6_del_cached_rt since it is called by ip6_del_cached_rt. Signed-off-by: David Ahern --- net/ipv6/route.c | 36 +--

[PATCH net-next 3/7] ipv6: Refactor exception functions

2019-05-22 Thread David Ahern
From: David Ahern Before moving exception bucket from fib6_info to fib6_nh, refactor rt6_flush_exceptions, rt6_remove_exception_rt, rt6_mtu_change_route, and rt6_update_exception_stamp_rt. In all 3 cases, move the primary logic into a new helper that starts with fib6_nh_. The latter 3 functions s

[PATCH net-next 0/7] ipv6: Move exceptions to fib6_nh and make it optional in a fib6_info

2019-05-22 Thread David Ahern
From: David Ahern Patches 1 and 4 move pcpu and exception caches from fib6_info to fib6_nh. With respect to the current FIB entries this is only a movement from one struct to another contained within the first. Patch 2 refactors the core logic of fib6_drop_pcpu_from into a helper that is invoked

[PATCH net-next 1/7] ipv6: Move pcpu cached routes to fib6_nh

2019-05-22 Thread David Ahern
From: David Ahern rt6_info are specific instances of a fib entry and are tied to a device and gateway - ie., a nexthop. Before nexthop objects, IPv6 fib entries have separate fib6_info for each nexthop in a multipath route, so the location of the pcpu cache in the fib6_info struct worked. However

[PATCH net-next 4/7] ipv6: Move exception bucket to fib6_nh

2019-05-22 Thread David Ahern
From: David Ahern Similar to the pcpu routes exceptions are really per nexthop, so move rt6i_exception_bucket from fib6_info to fib6_nh. To avoid additional increases to the size of fib6_nh for a 1-bit flag, use the lowest bit in the allocated memory pointer for the flushed flag. Add helpers for

[PATCH net-next 7/7] selftests: Add redirect tests

2019-05-22 Thread David Ahern
From: David Ahern Add test for ICMP redirects and exception processing. Test is setup for later addition of tests using nexthop objects for routing. Signed-off-by: David Ahern --- tools/testing/selftests/net/icmp_redirect.sh | 455 +++ 1 file changed, 455 insertions(+)

[PATCH net-next 2/7] ipv6: Refactor fib6_drop_pcpu_from

2019-05-22 Thread David Ahern
From: David Ahern Move the existing pcpu walk in fib6_drop_pcpu_from to a new helper, __fib6_drop_pcpu_from, that can be invoked per fib6_nh with a reference to the from entries that need to be evicted. If the passed in 'from' is non-NULL then only entries associated with that fib6_info are remov

[PATCH net-next 5/7] ipv6: Make fib6_nh optional at the end of fib6_info

2019-05-22 Thread David Ahern
From: David Ahern Move fib6_nh to the end of fib6_info and make it an array of size 0. Pass a flag to fib6_info_alloc indicating if the allocation needs to add space for a fib6_nh. The current code path always has a fib6_nh allocated with a fib6_info; with nexthop objects they will be separate.

[RESEND PATCH] intel-ethernet: warn when fatal read failure happens

2019-05-22 Thread Feng Tang
Failed in reading the HW register is very serious for igb/igc driver, as its hw_addr will be set to NULL and cause the adapter be seen as "REMOVED". We saw the error only a few times in the MTBF test for suspend/resume, but can hardly get any useful info to debug. Adding WARN() so that we can get

[PATCH net] cxgb4: Revert "cxgb4: Remove SGE_HOST_PAGE_SIZE dependency on page size"

2019-05-22 Thread Vishal Kulkarni
This reverts commit 2391b0030e241386d710df10e53e2cfc3c5d4fc1 which has introduced regression. Now SGE's BAR2 Doorbell/GTS Page Size is interpreted correctly in the firmware itself by using actual host page size. Hence previous commit needs to be reverted. Signed-off-by: Vishal Kulkarni --- drive

Re: [RFC PATCH net-next 5/9] net: phylink: Add phylink_create_raw

2019-05-22 Thread Florian Fainelli
On 5/22/2019 7:25 PM, Florian Fainelli wrote: > > > On 5/22/2019 6:20 PM, Ioana Ciornei wrote: >> This adds a new entry point to PHYLINK that does not require a >> net_device structure. >> >> The main intended use are DSA ports that do not have net devices >> registered for them (mainly becaus

Re: [RFC PATCH net-next 9/9] net: dsa: sja1105: Fix broken fixed-link interfaces on user ports

2019-05-22 Thread Florian Fainelli
On 5/22/2019 6:20 PM, Ioana Ciornei wrote: > From: Vladimir Oltean > > PHYLIB and PHYLINK handle fixed-link interfaces differently. PHYLIB > wraps them in a software PHY ("pseudo fixed link") phydev construct such > that .adjust_link driver callbacks see an unified API. Whereas PHYLINK > simpl

Re: [RFC PATCH net-next 5/9] net: phylink: Add phylink_create_raw

2019-05-22 Thread Florian Fainelli
On 5/22/2019 6:20 PM, Ioana Ciornei wrote: > This adds a new entry point to PHYLINK that does not require a > net_device structure. > > The main intended use are DSA ports that do not have net devices > registered for them (mainly because doing so would be redundant - see > Documentation/networ

Re: [RFC PATCH net-next 8/9] net: dsa: Use PHYLINK for the CPU/DSA ports

2019-05-22 Thread Florian Fainelli
On 5/22/2019 6:20 PM, Ioana Ciornei wrote: > This completely removes the usage of PHYLIB from DSA, namely for the > aforementioned switch ports which used to drive a software PHY manually > using genphy operations. > > For these ports, the newly introduced phylink_create_raw API must be > used,

[net:master 11/11] net//ipv4/igmp.c:2157:2: error: implicit declaration of function 'ip_sf_list_clear_all'

2019-05-22 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git master head: 3580d04aa674383c42de7b635d28e52a1e5bc72c commit: 3580d04aa674383c42de7b635d28e52a1e5bc72c [11/11] ipv4/igmp: fix another memory leak in igmpv3_del_delrec() config: i386-randconfig-i0-201920 (attached as .config) c

Re: [RFC PATCH net-next 7/9] net: dsa: Move the phylink driver calls into port.c

2019-05-22 Thread Florian Fainelli
On 5/22/2019 6:20 PM, Ioana Ciornei wrote: > In order to have a common handling of PHYLINK for the slave and non-user > ports, the DSA core glue logic (between PHYLINK and the driver) must use > an API that does not rely on a struct net_device. > > These will also be called by the CPU-port-hand

Re: [PATCH v7 bpf-next 01/16] bpf: verifier: mark verified-insn with sub-register zext flag

2019-05-22 Thread Alexei Starovoitov
On Wed, May 22, 2019 at 07:54:57PM +0100, Jiong Wang wrote: > eBPF ISA specification requires high 32-bit cleared when low 32-bit > sub-register is written. This applies to destination register of ALU32 etc. > JIT back-ends must guarantee this semantic when doing code-gen. x86_64 and > AArch64 ISA

Re: [RFC PATCH net-next 4/9] net: phylink: Add phylink_mac_link_{up,down} wrapper functions

2019-05-22 Thread Florian Fainelli
On 5/22/2019 6:20 PM, Ioana Ciornei wrote: > This is a cosmetic patch that reduces the clutter in phylink_resolve > around calling the .mac_link_up/.mac_link_down driver callbacks. In a > further patch this logic will be extended to emit notifications in case > a net device does not exist. > >

Re: [RFC PATCH net-next 3/9] net: phy: Add phy_standalone sysfs entry

2019-05-22 Thread Florian Fainelli
On 5/22/2019 6:20 PM, Ioana Ciornei wrote: > Export a phy_standalone device attribute that is meant to give the > indication that this PHY lacks an attached_dev and its corresponding > sysfs link. > > Signed-off-by: Ioana Ciornei I would rather have that attribute be conditionally visible/cre

Re: [RFC PATCH net-next 2/9] net: phy: Guard against the presence of a netdev

2019-05-22 Thread Florian Fainelli
On 5/22/2019 6:20 PM, Ioana Ciornei wrote: > A prerequisite for PHYLIB to work in the absence of a struct net_device > is to not access pointers to it. > > Changes are needed in the following areas: > > - Printing: In some places netdev_err was replaced with phydev_err. > > - Incrementing r

Re: [RFC PATCH net-next 1/9] net: phy: Add phy_sysfs_create_links helper function

2019-05-22 Thread Florian Fainelli
On 5/22/2019 6:20 PM, Ioana Ciornei wrote: > From: Vladimir Oltean > > This is a cosmetic patch that wraps the operation of creating sysfs > links between the netdev->phydev and the phydev->attached_dev. > > This is needed to keep the indentation level in check in a follow-up > patch where th

[PATCH net,stable 1/1] net: fec: fix the clk mismatch in failed_reset path

2019-05-22 Thread Andy Duan
Fix the clk mismatch in the error path "failed_reset" because below error path will disable clk_ahb and clk_ipg directly, it should use pm_runtime_put_noidle() instead of pm_runtime_put() to avoid to call runtime resume callback. Reported-by: Baruch Siach Signed-off-by: Fugang Duan --- drivers/

[PATCH net,stable 1/1] net: fec: add defer probe for of_get_mac_address

2019-05-22 Thread Andy Duan
If MAC address read from nvmem efuse by calling .of_get_mac_address(), but nvmem efuse is registerred later than the driver, then it return -EPROBE_DEFER value. So modify the driver to support defer probe when read MAC address from nvmem efuse. Signed-off-by: Fugang Duan --- drivers/net/ethernet

Re: [PATCH v2 bpf-next] libbpf: emit diff of mismatched public API, if any

2019-05-22 Thread Alexei Starovoitov
On Wed, May 22, 2019 at 10:53 AM Andrii Nakryiko wrote: > > It's easy to have a mismatch of "intended to be public" vs really > exposed API functions. While Makefile does check for this mismatch, if > it actually occurs it's not trivial to determine which functions are > accidentally exposed. This

[PATCH net] ipv4/igmp: fix build error if !CONFIG_IP_MULTICAST

2019-05-22 Thread Eric Dumazet
ip_sf_list_clear_all() needs to be defined even if !CONFIG_IP_MULTICAST Fixes: 3580d04aa674 ("ipv4/igmp: fix another memory leak in igmpv3_del_delrec()") Signed-off-by: Eric Dumazet Reported-by: kbuild test robot --- net/ipv4/igmp.c | 22 +++--- 1 file changed, 11 insertions(+)

Re: [net:master 11/11] net//ipv4/igmp.c:2157:2: error: implicit declaration of function 'ip_sf_list_clear_all'; did you mean 'ip_mc_filter_del'?

2019-05-22 Thread Eric Dumazet
On Wed, May 22, 2019 at 6:19 PM kbuild test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git master > head: 3580d04aa674383c42de7b635d28e52a1e5bc72c > commit: 3580d04aa674383c42de7b635d28e52a1e5bc72c [11/11] ipv4/igmp: fix > another memory leak in igmpv3_de

Re: [PATCH bpf-next 10/12] bpftool: add C output format option to btf dump subcommand

2019-05-22 Thread Jakub Kicinski
On Wed, 22 May 2019 17:58:23 -0700, Andrii Nakryiko wrote: > On Wed, May 22, 2019 at 5:25 PM Jakub Kicinski wrote: > > On Wed, 22 May 2019 12:50:51 -0700, Andrii Nakryiko wrote: > > > + * Copyright (C) 2019 Facebook > > > + */ > > > > > > #include > > > #include > > > @@ -340,11 +347,48 @@ st

[RFC PATCH net-next 8/9] net: dsa: Use PHYLINK for the CPU/DSA ports

2019-05-22 Thread Ioana Ciornei
This completely removes the usage of PHYLIB from DSA, namely for the aforementioned switch ports which used to drive a software PHY manually using genphy operations. For these ports, the newly introduced phylink_create_raw API must be used, and the callbacks are received through a notifier block r

[RFC PATCH net-next 7/9] net: dsa: Move the phylink driver calls into port.c

2019-05-22 Thread Ioana Ciornei
In order to have a common handling of PHYLINK for the slave and non-user ports, the DSA core glue logic (between PHYLINK and the driver) must use an API that does not rely on a struct net_device. These will also be called by the CPU-port-handling code in a further patch. Signed-off-by: Ioana Cior

[RFC PATCH net-next 5/9] net: phylink: Add phylink_create_raw

2019-05-22 Thread Ioana Ciornei
This adds a new entry point to PHYLINK that does not require a net_device structure. The main intended use are DSA ports that do not have net devices registered for them (mainly because doing so would be redundant - see Documentation/networking/dsa/dsa.rst for details). So far DSA has been using P

[RFC PATCH net-next 3/9] net: phy: Add phy_standalone sysfs entry

2019-05-22 Thread Ioana Ciornei
Export a phy_standalone device attribute that is meant to give the indication that this PHY lacks an attached_dev and its corresponding sysfs link. Signed-off-by: Ioana Ciornei --- drivers/net/phy/phy_device.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/net/phy/phy_

[RFC PATCH net-next 6/9] net: phylink: Make fixed link notifier calls edge-triggered

2019-05-22 Thread Ioana Ciornei
Otherwise .mac_link_up and .mac_link_down on fixed-link interfaces are called every second. On a raw phylink instance we cannot call netdev_carrier_ok for an indication of the last state of the link, so keep track and update this in a new field of the phylink structure. Signed-off-by: Ioana Ciorn

[RFC PATCH net-next 2/9] net: phy: Guard against the presence of a netdev

2019-05-22 Thread Ioana Ciornei
A prerequisite for PHYLIB to work in the absence of a struct net_device is to not access pointers to it. Changes are needed in the following areas: - Printing: In some places netdev_err was replaced with phydev_err. - Incrementing reference count to the parent MDIO bus driver: If there is n

[RFC PATCH net-next 9/9] net: dsa: sja1105: Fix broken fixed-link interfaces on user ports

2019-05-22 Thread Ioana Ciornei
From: Vladimir Oltean PHYLIB and PHYLINK handle fixed-link interfaces differently. PHYLIB wraps them in a software PHY ("pseudo fixed link") phydev construct such that .adjust_link driver callbacks see an unified API. Whereas PHYLINK simply creates a phylink_link_state structure and passes it to

[RFC PATCH net-next 4/9] net: phylink: Add phylink_mac_link_{up,down} wrapper functions

2019-05-22 Thread Ioana Ciornei
This is a cosmetic patch that reduces the clutter in phylink_resolve around calling the .mac_link_up/.mac_link_down driver callbacks. In a further patch this logic will be extended to emit notifications in case a net device does not exist. Signed-off-by: Ioana Ciornei --- drivers/net/phy/phylin

[RFC PATCH net-next 1/9] net: phy: Add phy_sysfs_create_links helper function

2019-05-22 Thread Ioana Ciornei
From: Vladimir Oltean This is a cosmetic patch that wraps the operation of creating sysfs links between the netdev->phydev and the phydev->attached_dev. This is needed to keep the indentation level in check in a follow-up patch where this function will be guarded against the existence of a phyde

[RFC PATCH net-next 0/9] Decoupling PHYLINK from struct net_device

2019-05-22 Thread Ioana Ciornei
Following two separate discussion threads in: https://www.spinics.net/lists/netdev/msg569087.html and: https://www.spinics.net/lists/netdev/msg570450.html PHYLINK was reworked in order to add a new "raw" interface, alongside the one based on struct net_device. The raw interface works by passin

[net:master 11/11] net//ipv4/igmp.c:2157:2: error: implicit declaration of function 'ip_sf_list_clear_all'; did you mean 'ip_mc_filter_del'?

2019-05-22 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git master head: 3580d04aa674383c42de7b635d28e52a1e5bc72c commit: 3580d04aa674383c42de7b635d28e52a1e5bc72c [11/11] ipv4/igmp: fix another memory leak in igmpv3_del_delrec() config: i386-randconfig-x073-201920 (attached as .config)

Re: [PATCH net] ipv4/igmp: fix another memory leak in igmpv3_del_delrec()

2019-05-22 Thread David Miller
From: Eric Dumazet Date: Wed, 22 May 2019 16:51:22 -0700 > syzbot reported memory leaks [1] that I have back tracked to > a missing cleanup from igmpv3_del_delrec() when > (im->sfmode != MCAST_INCLUDE) > > Add ip_sf_list_clear_all() and kfree_pmc() helpers to explicitely > handle the cleanups be

Re: [PATCH net 0/4] bnxt_en: Bug fixes.

2019-05-22 Thread David Miller
From: Michael Chan Date: Wed, 22 May 2019 19:12:53 -0400 > There are 4 driver fixes in this series: > > 1. Fix RX buffer leak during OOM condition. > 2. Call pci_disable_msix() under correct conditions to prevent hitting BUG. > 3. Reduce unneeded mmeory allocation in kdump kernel to prevent OOM.

RE: [EXT] i.MX8MQ clk: enet1_root_clk already disabled

2019-05-22 Thread Andy Duan
From: Baruch Siach > I'm testing kernel v5.2-rc1 on my i.MX8MQ system, SolidRun Hummingboard > Pulse. The fec driver happens to probe before the gpio driver that we need for > the PHY reset. So fec_reset_phy() returns -EPROBE_DEFER. This triggers the > splat below when clk_ahb is disabled somewher

Re: [PATCH net-next] ipv4/igmp: shrink struct ip_sf_list

2019-05-22 Thread David Miller
From: Eric Dumazet Date: Wed, 22 May 2019 15:00:25 -0700 > Removing two 4 bytes holes allows to use kmalloc-32 > kmem cache instead of kmalloc-64 on 64bit kernels. > > Signed-off-by: Eric Dumazet Applied.

Re: [PATCH net] ipv6: Fix redirect with VRF

2019-05-22 Thread David Miller
From: David Ahern Date: Wed, 22 May 2019 15:12:18 -0700 > From: David Ahern > > IPv6 redirect is broken for VRF. __ip6_route_redirect walks the FIB > entries looking for an exact match on ifindex. With VRF the flowi6_oif > is updated by l3mdev_update_flow to the l3mdev index and the > FLOWI_FLA

Re: [PATCH bpf-next 10/12] bpftool: add C output format option to btf dump subcommand

2019-05-22 Thread Andrii Nakryiko
On Wed, May 22, 2019 at 5:25 PM Jakub Kicinski wrote: > > On Wed, 22 May 2019 12:50:51 -0700, Andrii Nakryiko wrote: > > Utilize new libbpf's btf_dump API to emit BTF as a C definitions. > > > > Signed-off-by: Andrii Nakryiko > > --- > > tools/bpf/bpftool/btf.c | 63 +

Re: [PATCH net-next] selftests: pmtu: Simplify cleanup and namespace names

2019-05-22 Thread David Miller
From: David Ahern Date: Wed, 22 May 2019 12:11:06 -0700 > From: David Ahern > > The point of the pause-on-fail argument is to leave the setup as is after > a test fails to allow a user to debug why it failed. Move the cleanup > after posting the result to the user to make it so. > > Random nam

Re: [PATCH net-next] neighbor: Add tracepoint to __neigh_create

2019-05-22 Thread David Miller
From: David Ahern Date: Wed, 22 May 2019 12:22:21 -0700 > From: David Ahern > > Add tracepoint to __neigh_create to enable debugging of new entries. > > Signed-off-by: David Ahern Applied.

Re: [PATCH net-next] net: Set strict_start_type for routes and rules

2019-05-22 Thread David Miller
From: David Ahern Date: Wed, 22 May 2019 12:07:43 -0700 > From: David Ahern > > New userspace on an older kernel can send unknown and unsupported > attributes resulting in an incompelete config which is almost > always wrong for routing (few exceptions are passthrough settings > like the protoc

Re: [PATCH net-next] selftests: fib-onlink: Make quiet by default

2019-05-22 Thread David Miller
From: David Ahern Date: Wed, 22 May 2019 12:09:16 -0700 > From: David Ahern > > Add VERBOSE argument to fib-onlink-tests.sh and make output quiet by > default. Add getopt parsing of inputs and support for -v (verbose) and > -p (pause on fail). > > Signed-off-by: David Ahern Applied.

Re: [PATCH v2 net-next 0/8] net: Export functions for nexthop code

2019-05-22 Thread David Miller
From: David Ahern Date: Wed, 22 May 2019 12:04:38 -0700 > From: David Ahern > > This set exports ipv4 and ipv6 fib functions for use by the nexthop > code. It also adds new ones to send route notifications if a nexthop > configuration changes. > > v2 > - repost of patches dropped at the end of

Re: [PATCH net-next 0/2] net: phy: T1 support

2019-05-22 Thread David Miller
From: Andrew Lunn Date: Wed, 22 May 2019 20:47:02 +0200 > T1 PHYs make use of a single twisted pair, rather than the traditional > 2 pair for 100BaseT or 4 pair for 1000BaseT. This patchset adds link > modes for 100BaseT1 and 1000BaseT1, and them makes use of 100BaseT1 in > the list of PHY featur

Re: [PATCH net-next v2 7/8] net: phy: dp83867: Validate FIFO depth property

2019-05-22 Thread David Miller
From: Trent Piepho Date: Wed, 22 May 2019 18:43:26 + > Insure property is in valid range and fail when reading DT if it is not. > Also add error message for existing failure if required property is not > present. > > Cc: Andrew Lunn > Cc: Florian Fainelli > Cc: Heiner Kallweit > Signed-of

Re: [PATCH net-next v2 8/8] net: phy: dp83867: Allocate state struct in probe

2019-05-22 Thread David Miller
From: Trent Piepho Date: Wed, 22 May 2019 18:43:27 + > This was being done in config the first time the phy was configured. > Should be in the probe method. > > Cc: Andrew Lunn > Cc: Florian Fainelli > Cc: Heiner Kallweit > Signed-off-by: Trent Piepho Applied.

Re: [PATCH net-next v2 3/8] net: phy: dp83867: Add ability to disable output clock

2019-05-22 Thread David Miller
From: Trent Piepho Date: Wed, 22 May 2019 18:43:22 + > Generally, the output clock pin is only used for testing and only serves > as a source of RF noise after this. It could be used to daisy-chain > PHYs, but this is uncommon. Since the PHY can disable the output, make > doing so an option

Re: [PATCH net-next v2 2/8] dt-bindings: phy: dp83867: Add documentation for disabling clock output

2019-05-22 Thread David Miller
From: Trent Piepho Date: Wed, 22 May 2019 18:43:21 + > The clock output is generally only used for testing and development and > not used to daisy-chain PHYs. It's just a source of RF noise afterward. > > Add a mux value for "off". I've added it as another enumeration to the > output prope

Re: [PATCH net-next v2 4/8] net: phy: dp83867: Rework delay rgmii delay handling

2019-05-22 Thread David Miller
From: Trent Piepho Date: Wed, 22 May 2019 18:43:23 + > The code was assuming the reset default of the delay control register > was to have delay disabled. This is what the datasheet shows as the > register's initial value. However, that's not actually true: the > default is controlled by th

Re: [PATCH net-next v2 1/8] dt-bindings: phy: dp83867: Describe how driver behaves w.r.t rgmii delay

2019-05-22 Thread David Miller
From: Trent Piepho Date: Wed, 22 May 2019 18:43:19 + > Add a note to make it more clear how the driver behaves when "rgmii" vs > "rgmii-id", "rgmii-idrx", or "rgmii-idtx" interface modes are selected. > > Cc: Rob Herring > Cc: Mark Rutland > Signed-off-by: Trent Piepho Applied.

Re: [PATCH net-next v2 5/8] net: phy: dp83867: Use unsigned variables to store unsigned properties

2019-05-22 Thread David Miller
From: Trent Piepho Date: Wed, 22 May 2019 18:43:24 + > The variables used to store u32 DT properties were signed ints. This > doesn't work properly if the value of the property were to overflow. > Use unsigned variables so this doesn't happen. > > Cc: Andrew Lunn > Cc: Florian Fainelli >

Re: [PATCH net-next v2 6/8] net: phy: dp83867: IO impedance is not dependent on RGMII delay

2019-05-22 Thread David Miller
From: Trent Piepho Date: Wed, 22 May 2019 18:43:25 + > The driver would only set the IO impedance value when RGMII internal > delays were enabled. There is no reason for this. Move the IO > impedance block out of the RGMII delay block. > > Cc: Andrew Lunn > Cc: Florian Fainelli > Cc: Hei

Re: [PATCH net-next v2] cxgb4: Enable hash filter with offload

2019-05-22 Thread David Miller
From: Vishal Kulkarni Date: Wed, 22 May 2019 21:46:12 +0530 > Hash (exact-match) filters used for offloading flows share the > same active region resources on the chip with upper layer drivers, > like iw_cxgb4, chcr, etc. Currently, only either Hash filters > or ULDs can use the active region res

Re: [PATCH] net: fec: remove redundant ipg clock disable

2019-05-22 Thread David Miller
From: Baruch Siach Date: Wed, 22 May 2019 16:56:15 +0300 > Don't disable the ipg clock in the regulator error path. The clock is > disable unconditionally two lines below the failed_regulator label. > > Signed-off-by: Baruch Siach Applied to net-next.

Re: [PATCH bpf-next 10/12] bpftool: add C output format option to btf dump subcommand

2019-05-22 Thread Jakub Kicinski
On Wed, 22 May 2019 12:50:51 -0700, Andrii Nakryiko wrote: > Utilize new libbpf's btf_dump API to emit BTF as a C definitions. > > Signed-off-by: Andrii Nakryiko > --- > tools/bpf/bpftool/btf.c | 63 +++-- > 1 file changed, 60 insertions(+), 3 deletions(-) >

Re: [PATCH] mISDN: make sure device name is NUL terminated

2019-05-22 Thread David Miller
From: Dan Carpenter Date: Wed, 22 May 2019 11:45:13 +0300 > The user can change the device_name with the IMSETDEVNAME ioctl, but we > need to ensure that the user's name is NUL terminated. Otherwise it > could result in a buffer overflow when we copy the name back to the user > with IMGETDEVINFO

[PATCH net] ipv4/igmp: fix another memory leak in igmpv3_del_delrec()

2019-05-22 Thread Eric Dumazet
syzbot reported memory leaks [1] that I have back tracked to a missing cleanup from igmpv3_del_delrec() when (im->sfmode != MCAST_INCLUDE) Add ip_sf_list_clear_all() and kfree_pmc() helpers to explicitely handle the cleanups before freeing. [1] BUG: memory leak unreferenced object 0x888123e3

Re: [PATCH iproute2] ip route: Set rtm_dst_len to 32 for all ip route get requests

2019-05-22 Thread Stephen Hemminger
On Fri, 17 May 2019 10:59:13 -0700 David Ahern wrote: > index 2b3dcc5dbd53..d980b86ffd42 100644 > --- a/ip/iproute.c > +++ b/ip/iproute.c > @@ -2035,7 +2035,11 @@ static int iproute_get(int argc, char **argv) > if (addr.bytelen) > addattr_l(&req

[PATCH bpf-next v3 1/3] bpf: implement bpf_send_signal() helper

2019-05-22 Thread Yonghong Song
This patch tries to solve the following specific use case. Currently, bpf program can already collect stack traces through kernel function get_perf_callchain() when certain events happens (e.g., cache miss counter or cpu clock counter overflows). But such stack traces are not enough for jitted pro

[PATCH bpf-next v3 3/3] tools/bpf: add selftest in test_progs for bpf_send_signal() helper

2019-05-22 Thread Yonghong Song
The test covered both nmi and tracepoint perf events. $ ./test_progs ... test_send_signal_tracepoint:PASS:tracepoint 0 nsec ... test_send_signal_common:PASS:tracepoint 0 nsec ... test_send_signal_common:PASS:perf_event 0 nsec ... test_send_signal:OK Signed-off-by: Yonghong Song

[PATCH bpf-next v3 2/3] tools/bpf: sync bpf uapi header bpf.h to tools directory

2019-05-22 Thread Yonghong Song
The bpf uapi header include/uapi/linux/bpf.h is sync'ed to tools/include/uapi/linux/bpf.h. Signed-off-by: Yonghong Song --- tools/include/uapi/linux/bpf.h | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/lin

[PATCH bpf-next v3 0/3] bpf: implement bpf_send_signal() helper

2019-05-22 Thread Yonghong Song
This patch tries to solve the following specific use case. Currently, bpf program can already collect stack traces through kernel function get_perf_callchain() when certain events happens (e.g., cache miss counter or cpu clock counter overflows). But such stack traces are not enough for jitted pr

Re: [PATCH net-next] hv_sock: perf: Allow the socket buffer size options to influence the actual socket buffers

2019-05-22 Thread Stephen Hemminger
On Wed, 22 May 2019 22:56:07 + Sunil Muthuswamy wrote: > Currently, the hv_sock buffer size is static and can't scale to the > bandwidth requirements of the application. This change allows the > applications to influence the socket buffer sizes using the SO_SNDBUF and > the SO_RCVBUF socket o

[PATCH net 4/4] bnxt_en: Device serial number is supported only for PFs.

2019-05-22 Thread Michael Chan
From: Vasundhara Volam Don't read DSN on VFs that do not have the PCI capability. Fixes: 03213a996531 ("bnxt: move bp->switch_id initialization to PF probe") Signed-off-by: Vasundhara Volam Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 11 ++- 1 file chan

[PATCH net 3/4] bnxt_en: Reduce memory usage when running in kdump kernel.

2019-05-22 Thread Michael Chan
Skip RDMA context memory allocations, reduce to 1 ring, and disable TPA when running in the kdump kernel. Without this patch, the driver fails to initialize with memory allocation errors when running in a typical kdump kernel. Fixes: cf6daed098d1 ("bnxt_en: Increase context memory allocations on

[PATCH net 0/4] bnxt_en: Bug fixes.

2019-05-22 Thread Michael Chan
There are 4 driver fixes in this series: 1. Fix RX buffer leak during OOM condition. 2. Call pci_disable_msix() under correct conditions to prevent hitting BUG. 3. Reduce unneeded mmeory allocation in kdump kernel to prevent OOM. 4. Don't read device serial number on VFs because it is not supporte

[PATCH net 1/4] bnxt_en: Fix aggregation buffer leak under OOM condition.

2019-05-22 Thread Michael Chan
For every RX packet, the driver replenishes all buffers used for that packet and puts them back into the RX ring and RX aggregation ring. In one code path where the RX packet has one RX buffer and one or more aggregation buffers, we missed recycling the aggregation buffer(s) if we are unable to all

[PATCH net 2/4] bnxt_en: Fix possible BUG() condition when calling pci_disable_msix().

2019-05-22 Thread Michael Chan
When making configuration changes, the driver calls bnxt_close_nic() and then bnxt_open_nic() for the changes to take effect. A parameter irq_re_init is passed to the call sequence to indicate if IRQ should be re-initialized. This irq_re_init parameter needs to be included in the bnxt_reserve_rin

Proposition!

2019-05-22 Thread Mme Lilie MARTINS
Bonjour, Je soussignée Mme Lilie MARTINS de nationalité française. Je vous envoie ce présent message afin de solliciter votre accord pour la réalisation d'un projet de donation. Ayant perdu mon époux et mon enfant de 8 ans au cours d'un accident tragique et mortel Il y a quelques années, je n'a

Re: [PATCH bpf-next 05/12] libbpf: add resizable non-thread safe internal hashmap

2019-05-22 Thread Stanislav Fomichev
On 05/22, Andrii Nakryiko wrote: > On Wed, May 22, 2019 at 1:30 PM Stanislav Fomichev wrote: > > > > On 05/22, Andrii Nakryiko wrote: > > > There is a need for fast point lookups inside libbpf for multiple use > > > cases (e.g., name resolution for BTF-to-C conversion, by-name lookups in > > > BTF

Re: [PATCH v3 net-next 0/3] flow_offload: Re-add per-action statistics

2019-05-22 Thread Jakub Kicinski
On Wed, 22 May 2019 22:37:16 +0100, Edward Cree wrote: > * removed RFC tags Why? There is still no upstream user for this (my previous objections of this being only partially correct aside).

Re: [PATCH bpf-next 06/12] selftests/bpf: add tests for libbpf's hashmap

2019-05-22 Thread Andrii Nakryiko
On Wed, May 22, 2019 at 1:31 PM Stanislav Fomichev wrote: > > On 05/22, Andrii Nakryiko wrote: > > Test all APIs for internal hashmap implementation. > > > > Signed-off-by: Andrii Nakryiko > > --- > > tools/testing/selftests/bpf/.gitignore | 1 + > > tools/testing/selftests/bpf/Makefile

Re: [bpf PATCH v4 1/4] bpf: tls, implement unhash to avoid transition out of ESTABLISHED

2019-05-22 Thread Jakub Kicinski
On Wed, 22 May 2019 14:57:33 -0700, John Fastabend wrote: > Jakub Kicinski wrote: > > On Thu, 09 May 2019 21:57:49 -0700, John Fastabend wrote: > > [...] > > > > > Looks like David Beckett managed to trigger another nasty on the > > release path :/ > > > > BUG: kernel NULL pointer derefer

Re: [PATCH V5] net: phy: tja11xx: Add TJA11xx PHY driver

2019-05-22 Thread Andrew Lunn
On Wed, May 22, 2019 at 11:48:06PM +0200, Marek Vasut wrote: > On 5/18/19 4:14 PM, Andrew Lunn wrote: > > On Sat, May 18, 2019 at 01:51:23AM +0200, Marek Vasut wrote: > >> Add driver for the NXP TJA1100 and TJA1101 PHYs. These PHYs are special > >> BroadRReach 100BaseT1 PHYs used in automotive. > >

Re: [PATCH bpf-next 05/12] libbpf: add resizable non-thread safe internal hashmap

2019-05-22 Thread Andrii Nakryiko
On Wed, May 22, 2019 at 1:30 PM Stanislav Fomichev wrote: > > On 05/22, Andrii Nakryiko wrote: > > There is a need for fast point lookups inside libbpf for multiple use > > cases (e.g., name resolution for BTF-to-C conversion, by-name lookups in > > BTF for upcoming BPF CO-RE relocation support, e

[PATCH net] ipv6: Fix redirect with VRF

2019-05-22 Thread David Ahern
From: David Ahern IPv6 redirect is broken for VRF. __ip6_route_redirect walks the FIB entries looking for an exact match on ifindex. With VRF the flowi6_oif is updated by l3mdev_update_flow to the l3mdev index and the FLOWI_FLAG_SKIP_NH_OIF set in the flags to tell the lookup to skip the device m

[PATCH net-next] ipv4/igmp: shrink struct ip_sf_list

2019-05-22 Thread Eric Dumazet
Removing two 4 bytes holes allows to use kmalloc-32 kmem cache instead of kmalloc-64 on 64bit kernels. Signed-off-by: Eric Dumazet --- include/linux/igmp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/igmp.h b/include/linux/igmp.h index 9c94b2ea789ceb9a06d9d

  1   2   3   >