Re: [RFC PATCH net-next 2/9] net: phy: Guard against the presence of a netdev

[Florian Fainelli]

On 5/22/2019 6:20 PM, Ioana Ciornei wrote:
> A prerequisite for PHYLIB to work in the absence of a struct net_device
> is to not access pointers to it.
> 
> Changes are needed in the following areas:
> 
>  - Printing: In some places netdev_err was replaced with phydev_err.
> 
>  - Incrementing reference count to the parent MDIO bus driver: If there
>    is no net device, then the reference count should definitely be
>    incremented since there is no chance that it was an Ethernet driver
>    who registered the MDIO bus.
> 
>  - Sysfs links are not created in case there is no attached_dev.
> 
>  - No netif_carrier_off is done if there is no attached_dev.
> 
> Signed-off-by: Ioana Ciornei <ioana.cior...@nxp.com>
> Signed-off-by: Vladimir Oltean <olte...@gmail.com>

Reviewed-by: Florian Fainelli <f.faine...@gmail.com>
-- 
Florian