Re: [PATCH bpf] selftests/bpf: fix bpf_get_current_task

2019-05-16 Thread Andrii Nakryiko
On Thu, May 16, 2019 at 9:34 PM Alexei Starovoitov wrote: > > Fix bpf_get_current_task() declaration. > > Signed-off-by: Alexei Starovoitov Acked-by: Andrii Nakryiko > --- > tools/testing/selftests/bpf/bpf_helpers.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tool

[PATCH bpf] bpftool: fix BTF raw dump of FWD's fwd_kind

2019-05-16 Thread Andrii Nakryiko
kflag bit determines whether FWD is for struct or union. Use that bit. Fixes: c93cc69004df ("bpftool: add ability to dump BTF types") Signed-off-by: Andrii Nakryiko --- tools/bpf/bpftool/btf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/bpf/bpftool/btf.c b/tools

Re: [PATCH] Add UNIX_DIAG_UID to Netlink UNIX socket diagnostics.

2019-05-16 Thread Andy Lutomirski
> On May 16, 2019, at 8:25 PM, Felipe wrote: > > Author: Felipe Gasper > Date: Thu May 16 12:16:53 2019 -0500 > >Add UNIX_DIAG_UID to Netlink UNIX socket diagnostics. > >This adds the ability for Netlink to report a socket’s UID along with the >other UNIX socket diagnostic informati

[PATCH] Hirman: Clock-independent TCP ISN generation

2019-05-16 Thread Cyrus Sh
This patch addresses the privacy issue of TCP ISN generation in Linux kernel. Currently an adversary can deanonymize a user behind an anonymity network by inducing a load pattern on the target machine and correlating its clock skew with the pattern. Since the kernel adds a clock-based counter to ge

[PATCH bpf] selftests/bpf: fix bpf_get_current_task

2019-05-16 Thread Alexei Starovoitov
Fix bpf_get_current_task() declaration. Signed-off-by: Alexei Starovoitov --- tools/testing/selftests/bpf/bpf_helpers.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/bpf/bpf_helpers.h b/tools/testing/selftests/bpf/bpf_helpers.h index 6e80b66d7fb1..5

Re: [PATCH v5 1/2] Bluetooth: hci_qca: Load customized NVM based on the device property

2019-05-16 Thread Harish Bandi
On 2019-05-17 08:13, Balakrishna Godavarthi wrote: Hi Rocky, On 2019-05-15 16:49, Rocky Liao wrote: QCA BTSOC NVM is a customized firmware file and different vendors may want to have different BTSOC configuration (e.g. Configure SCO over PCM or I2S, Setting Tx power, etc.) via this file. This

[PATCH] Add UNIX_DIAG_UID to Netlink UNIX socket diagnostics.

2019-05-16 Thread Felipe
Author: Felipe Gasper Date: Thu May 16 12:16:53 2019 -0500 Add UNIX_DIAG_UID to Netlink UNIX socket diagnostics. This adds the ability for Netlink to report a socket’s UID along with the other UNIX socket diagnostic information that is already available. This will allow di

Re: Kernel UDP behavior with missing destinations

2019-05-16 Thread Willem de Bruijn
On Thu, May 16, 2019 at 8:27 PM Adam Urban wrote: > > And replying to your earlier comment about TTL, yes I think a TTL on > arp_queues would be hugely helpful. > > In any environment where you are streaming time-sensitive UDP traffic, > you really want the kernel to be tuned to immediately drop t

RE: [PATCH] can: flexcan: fix deadlock when using self wakeup

2019-05-16 Thread Joakim Zhang
Hi Marc, Sean Nyekjaer reported the issue, but the fix is incorrect. https://www.spinics.net/lists/linux-can/msg01447.html Could you help to add Sean Nyekjaer to this thread as I can't get the email address. You can add the "Reported-by" tag if you pick up the patch. Thanks a lot! Best Regard

Re: [PATCH v5 1/2] Bluetooth: hci_qca: Load customized NVM based on the device property

2019-05-16 Thread Balakrishna Godavarthi
Hi Rocky, On 2019-05-15 16:49, Rocky Liao wrote: QCA BTSOC NVM is a customized firmware file and different vendors may want to have different BTSOC configuration (e.g. Configure SCO over PCM or I2S, Setting Tx power, etc.) via this file. This patch will allow vendors to download different NVM fi

[PATCH] can: flexcan: fix deadlock when using self wakeup

2019-05-16 Thread Joakim Zhang
As reproted by Sean Nyekjaer bellow: When suspending, when there is still can traffic on the interfaces the flexcan immediately wakes the platform again. As it should :-) But it throws this error msg: [ 3169.378661] PM: noirq suspend of devices failed On the way down to suspend the interface that

[PATCH] hv_sock: perf: loop in send() to maximize bandwidth

2019-05-16 Thread Sunil Muthuswamy
Currently, the hv_sock send() iterates once over the buffer, puts data into the VMBUS channel and returns. It doesn't maximize on the case when there is a simultaneous reader draining data from the channel. In such a case, the send() can maximize the bandwidth (and consequently minimize the cpu cyc

Re: [PATCH] igb: add parameter to ignore nvm checksum validation

2019-05-16 Thread Florian Fainelli
On 5/16/2019 6:03 PM, Daniel Walker wrote: > On Thu, May 16, 2019 at 03:02:18PM -0700, Florian Fainelli wrote: >> On 5/16/19 12:55 PM, Nikunj Kela (nkela) wrote: >>> >>> >>> On 5/16/19, 12:35 PM, "Jeff Kirsher" wrote: >>> >>> On Wed, 2019-05-08 at 23:14 +, Nikunj Kela wrote: >>>>> S

Re: [PATCH] igb: add parameter to ignore nvm checksum validation

2019-05-16 Thread Daniel Walker
On Thu, May 16, 2019 at 03:02:18PM -0700, Florian Fainelli wrote: > On 5/16/19 12:55 PM, Nikunj Kela (nkela) wrote: > > > > > > On 5/16/19, 12:35 PM, "Jeff Kirsher" wrote: > > > > On Wed, 2019-05-08 at 23:14 +, Nikunj Kela wrote: > >>> Some of the broken NICs don't have EEPROM progr

Re: [PATCH net 2/3] net: core: generic XDP support for stacked device

2019-05-16 Thread Jason Wang
On 2019/5/17 上午5:54, Stephen Hemminger wrote: When a device is stacked like (team, bonding, failsafe or netvsc) the XDP generic program for the parent device is not called. In these cases, the rx handler changes skb->dev to its own in the receive handler, and returns RX_HANDLER_ANOTHER. Fix t

Re: [PATCH] ARM: dts: Introduce the NXP LS1021A-TSN board

2019-05-16 Thread Shawn Guo
On Mon, May 06, 2019 at 04:08:00AM +0300, Vladimir Oltean wrote: > The LS1021A-TSN is a development board built by VVDN/Argonboards in > partnership with NXP. > > It features the LS1021A SoC and the first-generation SJA1105T Ethernet > switch for prototyping implementations of a subset of IEEE 802

Re: [PATCH bpf] bpf: relax inode permission check for retrieving bpf program

2019-05-16 Thread Chenbo Feng
On 5/16/19 11:35 AM, Alexei Starovoitov wrote: On Tue, May 14, 2019 at 7:43 PM Chenbo Feng wrote: For iptable module to load a bpf program from a pinned location, it only retrieve a loaded program and cannot change the program content so requiring a write permission for it might not be necess

RE: [PATCH] hv_sock: perf: Allow the socket buffer size options to influence the actual socket buffers

2019-05-16 Thread Dexuan Cui
> From: Sunil Muthuswamy > Sent: Thursday, May 16, 2019 5:17 PM > > Currently, the hv_sock buffer size is static and can't scale to the > bandwidth requirements of the application. This change allows the > applications to influence the socket buffer sizes using the SO_SNDBUF and > the SO_RCVBUF s

Re: Kernel UDP behavior with missing destinations

2019-05-16 Thread Adam Urban
And replying to your earlier comment about TTL, yes I think a TTL on arp_queues would be hugely helpful. In any environment where you are streaming time-sensitive UDP traffic, you really want the kernel to be tuned to immediately drop the outgoing packet if the destination isn't yet known/in the a

Re: [PATCH net 3/3] Documentation: add TLS offload documentation

2019-05-16 Thread Jakub Kicinski
On Thu, 16 May 2019 15:52:58 -0700, Alexei Starovoitov wrote: > On Thu, May 16, 2019 at 02:39:03PM -0700, Jakub Kicinski wrote: > > On Thu, 16 May 2019 12:32:59 -0700, Alexei Starovoitov wrote: > > > On Thu, May 16, 2019 at 11:42:03AM -0700, Jakub Kicinski wrote: > > > > On Thu, 16 May 2019 11:

[PATCH] hv_sock: perf: Allow the socket buffer size options to influence the actual socket buffers

2019-05-16 Thread Sunil Muthuswamy
Currently, the hv_sock buffer size is static and can't scale to the bandwidth requirements of the application. This change allows the applications to influence the socket buffer sizes using the SO_SNDBUF and the SO_RCVBUF socket options. Few interesting points to note: 1. Since the VMBUS does not

Re: [RFC bpf-next 0/7] busy poll support for AF_XDP sockets

2019-05-16 Thread Samudrala, Sridhar
On 5/16/2019 5:37 AM, Magnus Karlsson wrote: After a number of surprises and issues in the driver here are now the first set of results. 64 byte packets at 40Gbit/s line rate. All results in Mpps. Note that I just used my local system and kernel build for these numbers so they are not performanc

Re: RFC: Fixing SK_REUSEPORT from sk_lookup_* helpers

2019-05-16 Thread Nitin Hande
On Thu, May 16, 2019 at 2:57 PM Alexei Starovoitov wrote: > > On Thu, May 16, 2019 at 09:41:34AM +0100, Lorenz Bauer wrote: > > On Wed, 15 May 2019 at 18:16, Joe Stringer wrote: > > > > > > On Wed, May 15, 2019 at 8:11 AM Lorenz Bauer wrote: > > > > > > > > In the BPF-based TPROXY session with J

Re: [Intel-wired-lan] i40e X722 RSS problem with NAT-Traversal IPsec packets

2019-05-16 Thread Alexander Duyck
On Thu, May 16, 2019 at 11:37 AM Lennart Sorensen wrote: > > On Thu, May 16, 2019 at 02:34:08PM -0400, Lennart Sorensen wrote: > > Here is what I see: > > > > i40e: Intel(R) Ethernet Connection XL710 Network Driver - version 2.1.7-k > > i40e: Copyright (c) 2013 - 2014 Intel Corporation. > > i40e 0

Re: [PATCH net 3/3] netdevice: clarify meaning of rx_handler_result

2019-05-16 Thread Stephen Hemminger
On Thu, 16 May 2019 15:25:43 -0700 Jakub Kicinski wrote: > On Thu, 16 May 2019 14:54:23 -0700, Stephen Hemminger wrote: > > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > > index 44b47e9df94a..56f613561909 100644 > > --- a/include/linux/netdevice.h > > +++ b/include/linux/ne

Re: [PATCH net 3/3] Documentation: add TLS offload documentation

2019-05-16 Thread Alexei Starovoitov
On Thu, May 16, 2019 at 02:39:03PM -0700, Jakub Kicinski wrote: > On Thu, 16 May 2019 12:32:59 -0700, Alexei Starovoitov wrote: > > On Thu, May 16, 2019 at 11:42:03AM -0700, Jakub Kicinski wrote: > > > On Thu, 16 May 2019 11:13:47 -0700, Alexei Starovoitov wrote: > > > > On Thu, May 16, 2019 at 10:

Re: ixgbe device for Intel C3508

2019-05-16 Thread Jeff Kirsher
On Thu, 2019-05-16 at 12:53 -0700, Paul Stewart wrote: > I was pleased to fine that the ixgbe driver had good support for the > 10GBit interfaces on the Atom C3708 device I was using. However, the > same is not true of the 2.5GBit interfaces on the Atom C3508. The > PCI > IDs on these interfaces

Re: [PATCH] igb: add parameter to ignore nvm checksum validation

2019-05-16 Thread Nikunj Kela (nkela)
On 5/16/19, 3:02 PM, "Florian Fainelli" wrote: On 5/16/19 12:55 PM, Nikunj Kela (nkela) wrote: >> >> >> On 5/16/19, 12:35 PM, "Jeff Kirsher" wrote: >> >> On Wed, 2019-05-08 at 23:14 +, Nikunj Kela wrote: >>>> Some of the broken NICs don't have EEPROM

Re: [PATCH net 3/3] netdevice: clarify meaning of rx_handler_result

2019-05-16 Thread Jakub Kicinski
On Thu, 16 May 2019 14:54:23 -0700, Stephen Hemminger wrote: > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > index 44b47e9df94a..56f613561909 100644 > --- a/include/linux/netdevice.h > +++ b/include/linux/netdevice.h > @@ -374,10 +374,10 @@ typedef enum gro_result gro_result_

Re: [PATCH net-next RFC] Dump SW SQ context as part of tx reporter

2019-05-16 Thread Jakub Kicinski
On Thu, 16 May 2019 12:02:49 +, Aya Levin wrote: > >>> Could you share the script? How is it going to be distributed? > >> I thought that the script should be in a available on Mellanox website. > > > > :( > > Do you think it belongs under kernel/scripts? iproute2/devlink perhaps, since it's d

Re: [PATCH] igb: add parameter to ignore nvm checksum validation

2019-05-16 Thread Florian Fainelli
On 5/16/19 12:55 PM, Nikunj Kela (nkela) wrote: > > > On 5/16/19, 12:35 PM, "Jeff Kirsher" wrote: > > On Wed, 2019-05-08 at 23:14 +, Nikunj Kela wrote: >>> Some of the broken NICs don't have EEPROM programmed correctly. It >>> results >>> in probe to fail. This change adds a

[PATCH net 3/3] netdevice: clarify meaning of rx_handler_result

2019-05-16 Thread Stephen Hemminger
Make the language in comment about rx_handler_result clearer. Especially the meaning of RX_HANDLER_ANOTHER. Replace use of "should" with "must" to be in line with common usage in standards documents. Signed-off-by: Stephen Hemminger --- include/linux/netdevice.h | 16 1 file ch

[PATCH net 2/3] net: core: generic XDP support for stacked device

2019-05-16 Thread Stephen Hemminger
When a device is stacked like (team, bonding, failsafe or netvsc) the XDP generic program for the parent device is not called. In these cases, the rx handler changes skb->dev to its own in the receive handler, and returns RX_HANDLER_ANOTHER. Fix this by calling do_xdp_generic if necessary before

[PATCH net 0/3] XDP generic related fixes

2019-05-16 Thread Stephen Hemminger
This set of patches came about while investigating XDP generic on Azure. The split brain nature of the accelerated networking exposed issues with the stack device model. The real fix is in the second patch which is a redo of earlier patch from Jason Wang. Stephen Hemminger (3): netvsc: unshare

[PATCH net 1/3] netvsc: unshare skb in VF rx handler

2019-05-16 Thread Stephen Hemminger
The netvsc VF skb handler should make sure that skb is not shared. Similar logic already exists in bonding and team device drivers. This is not an issue in practice because the VF devicex does not send up shared skb's. But the netvsc driver should do the right thing if it did. Fixes: 0c195567a8f6

RE: [RFC] vsock: proposal to support multiple transports at runtime

2019-05-16 Thread Dexuan Cui
> From: Stefano Garzarella > Sent: Tuesday, May 14, 2019 1:16 AM > To: netdev@vger.kernel.org; Stefan Hajnoczi ; Dexuan > > Hi guys, > I'm currently interested on implement a multi-transport support for VSOCK in > order to handle nested VMs. Hi Stefano, Thanks for reviving the discussion! :-) I

Re: Kernel UDP behavior with missing destinations

2019-05-16 Thread Adam Urban
How can I see if there is an active arp queue? Regarding the qdisc, I don't think we're bumping up against that (at least not in my tiny bench setup): tc -s qdisc show qdisc fq_codel 0: dev eth0 root refcnt 2 limit 10240p flows 1024 quantum 1514 target 5.0ms interval 100.0ms ecn Sent 925035443 b

Re: [PATCH net 3/3] Documentation: add TLS offload documentation

2019-05-16 Thread Jakub Kicinski
On Thu, 16 May 2019 12:32:59 -0700, Alexei Starovoitov wrote: > On Thu, May 16, 2019 at 11:42:03AM -0700, Jakub Kicinski wrote: > > On Thu, 16 May 2019 11:13:47 -0700, Alexei Starovoitov wrote: > > > On Thu, May 16, 2019 at 10:57 AM Jakub Kicinski wrote: > > > > > > > > The preferred method of re

Re: [PATCH v3 net] ipv6: fix src addr routing with the exception table

2019-05-16 Thread David Miller
From: Wei Wang Date: Thu, 16 May 2019 13:30:54 -0700 > From: Wei Wang > > When inserting route cache into the exception table, the key is > generated with both src_addr and dest_addr with src addr routing. > However, current logic always assumes the src_addr used to generate the > key is a /128

Re: [PATCH net] selftests: pmtu.sh: Remove quotes around commands in setup_xfrm

2019-05-16 Thread David Miller
From: David Ahern Date: Thu, 16 May 2019 10:41:31 -0700 > From: David Ahern > > The first command in setup_xfrm is failing resulting in the test getting > skipped: > > + ip netns exec ns-B ip -6 xfrm state add src fd00:1::a dst fd00:1::b spi > 0x1000 proto esp aead 'rfc4106(gcm(aes))' > 0x0f

Re: [PATCH net] net: avoid weird emergency message

2019-05-16 Thread David Miller
From: Eric Dumazet Date: Thu, 16 May 2019 08:09:57 -0700 > When host is under high stress, it is very possible thread > running netdev_wait_allrefs() returns from msleep(250) > 10 seconds late. > > This leads to these messages in the syslog : > > [...] unregister_netdevice: waiting for syz_tun

Re: [PATCH] net: sysctl: cleanup net_sysctl_init error exit paths

2019-05-16 Thread David Miller
From: "George G. Davis" Date: Thu, 16 May 2019 11:23:08 -0400 > Unwind net_sysctl_init error exit goto spaghetti code > > Suggested-by: Joshua Frkuska > Signed-off-by: George G. Davis Cleanups are not appropriate until the net-next tree opens back up. So please resubmit at that time. Thank

Re: [PATCH net 0/3] aqc111: revert endianess fixes and cleanup mtu logic

2019-05-16 Thread David Miller
From: Igor Russkikh Date: Thu, 16 May 2019 14:52:18 + > This reverts no-op commits as it was discussed: > > https://lore.kernel.org/netdev/1557839644.11261.4.ca...@suse.com/ > > First and second original patches are already dropped from stable, > No need to stable-queue the third patch as i

Re: [PATCH v3 net] ipv6: fix src addr routing with the exception table

2019-05-16 Thread Martin Lau
On Thu, May 16, 2019 at 01:30:54PM -0700, Wei Wang wrote: > From: Wei Wang > > When inserting route cache into the exception table, the key is > generated with both src_addr and dest_addr with src addr routing. > However, current logic always assumes the src_addr used to generate the > key is a /

Re: [PATCH net] xfrm: ressurrect "Fix uninitialized memory read in _decode_session4"

2019-05-16 Thread David Miller
From: Florian Westphal Date: Thu, 16 May 2019 11:28:16 +0200 > This resurrects commit 8742dc86d0c7a9628 > ("xfrm4: Fix uninitialized memory read in _decode_session4"), > which got lost during a merge conflict resolution between ipsec-next > and net-next tree. > > c53ac41e3720 ("xfrm: remove deco

Re: RFC: Fixing SK_REUSEPORT from sk_lookup_* helpers

2019-05-16 Thread Alexei Starovoitov
On Thu, May 16, 2019 at 09:41:34AM +0100, Lorenz Bauer wrote: > On Wed, 15 May 2019 at 18:16, Joe Stringer wrote: > > > > On Wed, May 15, 2019 at 8:11 AM Lorenz Bauer wrote: > > > > > > In the BPF-based TPROXY session with Joe Stringer [1], I mentioned > > > that the sk_lookup_* helpers currently

[PATCH v3 net] ipv6: fix src addr routing with the exception table

2019-05-16 Thread Wei Wang
From: Wei Wang When inserting route cache into the exception table, the key is generated with both src_addr and dest_addr with src addr routing. However, current logic always assumes the src_addr used to generate the key is a /128 host address. This is not true in the following scenarios: 1. When

Re: [PATCH v2 net] ipv6: fix src addr routing with the exception table

2019-05-16 Thread Wei Wang
On Thu, May 16, 2019 at 12:15 PM Martin Lau wrote: > > On Thu, May 16, 2019 at 11:16:20AM -0700, Wei Wang wrote: > > From: Wei Wang > > > > When inserting route cache into the exception table, the key is > > generated with both src_addr and dest_addr with src addr routing. > > However, current lo

Re: [PATCH] igb: add parameter to ignore nvm checksum validation

2019-05-16 Thread Nikunj Kela (nkela)
On 5/16/19, 12:35 PM, "Jeff Kirsher" wrote: On Wed, 2019-05-08 at 23:14 +, Nikunj Kela wrote: >> Some of the broken NICs don't have EEPROM programmed correctly. It >> results >> in probe to fail. This change adds a module parameter that can be >> used to >> ignore nvm che

ixgbe device for Intel C3508

2019-05-16 Thread Paul Stewart
I was pleased to fine that the ixgbe driver had good support for the 10GBit interfaces on the Atom C3708 device I was using. However, the same is not true of the 2.5GBit interfaces on the Atom C3508. The PCI IDs on these interfaces are very similar -- 8086:15cf on the C3508 vs 8086:15ce on the C3

Re: [PATCH bpf] libbpf: move logging helpers into libbpf_internal.h

2019-05-16 Thread Alexei Starovoitov
On Wed, May 15, 2019 at 8:39 PM Andrii Nakryiko wrote: > > libbpf_util.h header was recently exposed as public as a dependency of > xsk.h. In addition to memory barriers, it contained logging helpers, > which are not supposed to be exposed. This patch moves those into > libbpf_internal.h, which is

Re: [PATCH] igb: add parameter to ignore nvm checksum validation

2019-05-16 Thread Jeff Kirsher
On Wed, 2019-05-08 at 23:14 +, Nikunj Kela wrote: > Some of the broken NICs don't have EEPROM programmed correctly. It > results > in probe to fail. This change adds a module parameter that can be > used to > ignore nvm checksum validation. > > Cc: xe-linux-exter...@cisco.com > Signed-off-by:

Re: [PATCH net 3/3] Documentation: add TLS offload documentation

2019-05-16 Thread Alexei Starovoitov
On Thu, May 16, 2019 at 11:42:03AM -0700, Jakub Kicinski wrote: > On Thu, 16 May 2019 11:13:47 -0700, Alexei Starovoitov wrote: > > On Thu, May 16, 2019 at 10:57 AM Jakub Kicinski wrote: > > > > > > The preferred method of reporting the Layer 4 (TCP) checksum offload > > > for packets decrypted

Re: [PATCH] tipc: switch order of device registration to fix a crash

2019-05-16 Thread David Miller
From: hujunwei Date: Thu, 16 May 2019 10:51:15 +0800 > From: Junwei Hu > > When tipc is loaded while many processes try to create a TIPC socket, > a crash occurs: > PANIC: Unable to handle kernel paging request at virtual > address "dfff221d" > pc : tipc_sk_create+0x374/0x1180 [tipc]

Re: [PATCH net] ipv6: prevent possible fib6 leaks

2019-05-16 Thread David Miller
From: Eric Dumazet Date: Wed, 15 May 2019 19:39:52 -0700 > At ipv6 route dismantle, fib6_drop_pcpu_from() is responsible > for finding all percpu routes and set their ->from pointer > to NULL, so that fib6_ref can reach its expected value (1). > > The problem right now is that other cpus can sti

Re: [PATCH net] net: test nouarg before dereferencing zerocopy pointers

2019-05-16 Thread David Miller
From: Willem de Bruijn Date: Wed, 15 May 2019 13:29:16 -0400 > From: Willem de Bruijn > > Zerocopy skbs without completion notification were added for packet > sockets with PACKET_TX_RING user buffers. Those signal completion > through the TP_STATUS_USER bit in the ring. Zerocopy annotation was

Re: [PATCH v2] net: phy: aquantia: readd XGMII support for AQR107

2019-05-16 Thread David Miller
From: Madalin-cristian Bucur Date: Wed, 15 May 2019 15:07:44 + > XGMII interface mode no longer works on AQR107 after the recent changes, > adding back support. > > Fixes: 570c8a7d5303 ("net: phy: aquantia: check for supported interface modes > in config_init") > Signed-off-by: Madalin Bucu

Re: [PATCH] net: bpfilter: fallback to netfilter if failed to load bpfilter kernel module

2019-05-16 Thread David Miller
From: Konstantin Khlebnikov Date: Wed, 15 May 2019 14:40:52 +0300 > If bpfilter is not available return ENOPROTOOPT to fallback to netfilter. > > Function request_module() returns both errors and userspace exit codes. > Just ignore them. Rechecking bpfilter_ops is enough. > > Fixes: d2ba09c17a0

Re: [PATCH v2 net] ipv6: fix src addr routing with the exception table

2019-05-16 Thread Martin Lau
On Thu, May 16, 2019 at 11:16:20AM -0700, Wei Wang wrote: > From: Wei Wang > > When inserting route cache into the exception table, the key is > generated with both src_addr and dest_addr with src addr routing. > However, current logic always assumes the src_addr used to generate the > key is a /

Re: [PATCH 1/1] net: usb: qmi_wwan: add Telit 0x1260 and 0x1261 compositions

2019-05-16 Thread David Miller
From: Daniele Palmas Date: Wed, 15 May 2019 17:29:43 +0200 > Added support for Telit LE910Cx 0x1260 and 0x1261 compositions. > > Signed-off-by: Daniele Palmas Applied, thank you.

Re: [PATCH] selftests: fix bpf build/test workflow regression when KBUILD_OUTPUT is set

2019-05-16 Thread Shuah Khan
On 5/16/19 12:36 PM, Alexei Starovoitov wrote: On Fri, May 10, 2019 at 9:37 PM Alexei Starovoitov wrote: On Fri, May 10, 2019 at 08:52:49PM -0600, Shuah Khan wrote: commit 8ce72dc32578 ("selftests: fix headers_install circular dependency") broke bpf build/test workflow. When KBUILD_OUTPUT is

Re: [PATCH v2] hv_sock: Add support for delayed close

2019-05-16 Thread David Miller
From: Sunil Muthuswamy Date: Wed, 15 May 2019 00:56:05 + > Currently, hvsock does not implement any delayed or background close > logic. Whenever the hvsock socket is closed, a FIN is sent to the peer, and > the last reference to the socket is dropped, which leads to a call to > .destruct whe

Re: [PATCH v2] atm: iphase: Avoid copying pointers to user space.

2019-05-16 Thread David Miller
From: Fuqian Huang Date: Wed, 15 May 2019 08:42:48 +0800 > Remove the MEMDUMP_DEV case in ia_ioctl to avoid copy > pointers to user space. > > Signed-off-by: Fuqian Huang Applied.

Re: [PATCH net 0/2] flow_offload: fix CVLAN support

2019-05-16 Thread David Miller
From: Edward Cree Date: Tue, 14 May 2019 21:16:08 +0100 > When the flow_offload infrastructure was added, CVLAN matches weren't > plumbed through, and flow_rule_match_vlan() was incorrectly called in > the mlx5 driver when populating CVLAN match information. This series > adds flow_rule_match

RE: [PATCH v2] hv_sock: Add support for delayed close

2019-05-16 Thread Dexuan Cui
> From: Sunil Muthuswamy > Sent: Thursday, May 16, 2019 11:11 AM > > Hi Sunil, > > To make it clear, your patch itself is good, and I was just talking about > > the next change we're going to make. Once we make the next change, > > IMO we need a further patch to schedule hvs_close_timeout() to the

Re: [PATCH bpf] tools/bpftool: move set_max_rlimit() before __bpf_object__open_xattr()

2019-05-16 Thread Alexei Starovoitov
On Thu, May 16, 2019 at 11:31 AM Yonghong Song wrote: > > For a host which has a lower rlimit for max locked memory (e.g., 64KB), > the following error occurs in one of our production systems: > # /usr/sbin/bpftool prog load /paragon/pods/52877437/home/mark.o \ > /sys/fs/bpf/paragon_mark_21

Re: [PATCH bpf-next 0/2] Move bpf_printk to bpf_helpers.h

2019-05-16 Thread Alexei Starovoitov
On Thu, May 16, 2019 at 4:21 AM Michal Rostecki wrote: > > This series of patches move the commonly used bpf_printk macro to > bpf_helpers.h which is already included in all BPF programs which > defined that macro on their own. makes sense, but it needs to wait until bpf-next reopens.

Re: [PATCH net 3/3] Documentation: add TLS offload documentation

2019-05-16 Thread Jakub Kicinski
On Thu, 16 May 2019 11:13:47 -0700, Alexei Starovoitov wrote: > On Thu, May 16, 2019 at 10:57 AM Jakub Kicinski wrote: > > > > The preferred method of reporting the Layer 4 (TCP) checksum offload > > for packets decrypted by the device is to update the checksum field > > to the correct value

Re: [PATCH bpf] selftests/bpf: add test_sysctl and map_tests/tests.h to .gitignore

2019-05-16 Thread Alexei Starovoitov
On Thu, May 16, 2019 at 9:47 AM Stanislav Fomichev wrote: > > Missing files are: > * tools/testing/selftests/bpf/map_tests/tests.h - autogenerated > * tools/testing/selftests/bpf/test_sysctl - binary > > Fixes: 51a0e301a563 ("bpf: Add BPF_MAP_TYPE_SK_STORAGE test to test_maps") > Fixes: 1f5fa9ab6e

Re: [Intel-wired-lan] i40e X722 RSS problem with NAT-Traversal IPsec packets

2019-05-16 Thread Lennart Sorensen
On Thu, May 16, 2019 at 02:34:08PM -0400, Lennart Sorensen wrote: > Here is what I see: > > i40e: Intel(R) Ethernet Connection XL710 Network Driver - version 2.1.7-k > i40e: Copyright (c) 2013 - 2014 Intel Corporation. > i40e :3d:00.0: fw 3.10.52896 api 1.6 nvm 4.00 0x80001577 1.1767.0 > i40e

Re: [PATCH] selftests: fix bpf build/test workflow regression when KBUILD_OUTPUT is set

2019-05-16 Thread Alexei Starovoitov
On Fri, May 10, 2019 at 9:37 PM Alexei Starovoitov wrote: > > On Fri, May 10, 2019 at 08:52:49PM -0600, Shuah Khan wrote: > > commit 8ce72dc32578 ("selftests: fix headers_install circular dependency") > > broke bpf build/test workflow. When KBUILD_OUTPUT is set, bpf objects end > > up in KBUILD_OU

Re: [PATCH bpf] bpf: relax inode permission check for retrieving bpf program

2019-05-16 Thread Alexei Starovoitov
On Tue, May 14, 2019 at 7:43 PM Chenbo Feng wrote: > > For iptable module to load a bpf program from a pinned location, it > only retrieve a loaded program and cannot change the program content so > requiring a write permission for it might not be necessary. > Also when adding or removing an unrel

Re: [Intel-wired-lan] i40e X722 RSS problem with NAT-Traversal IPsec packets

2019-05-16 Thread Lennart Sorensen
On Thu, May 16, 2019 at 10:10:55AM -0700, Alexander Duyck wrote: > So I was sent a link to the datasheet for the part and I have a > working theory that what we may be seeing is a problem in the firmware > for the part. > > Can you try applying the attached patch and send the output from the > dme

[PATCH] Bluetooth: hidp: NUL terminate a string in the compat ioctl

2019-05-16 Thread Dan Carpenter
This change is similar to commit a1616a5ac99e ("Bluetooth: hidp: fix buffer overflow") but for the compat ioctl. We take a string from the user and forgot to ensure that it's NUL terminated. I have also changed the strncpy() in to strscpy() in hidp_setup_hid(). The difference is the strncpy() doe

Re: [PATCH] ipvs: Fix use-after-free in ip_vs_in

2019-05-16 Thread Julian Anastasov
Hello, On Wed, 15 May 2019, YueHaibing wrote: > BUG: KASAN: use-after-free in ip_vs_in.part.29+0xe8/0xd20 [ip_vs] > Read of size 4 at addr 8881e9b26e2c by task sshd/5603 > > CPU: 0 PID: 5603 Comm: sshd Not tainted 4.19.39+ #30 > Hardware name: Red Hat KVM, BIOS 0.5.1 01/01/2011 > C

[PATCH v2 net] ipv6: fix src addr routing with the exception table

2019-05-16 Thread Wei Wang
From: Wei Wang When inserting route cache into the exception table, the key is generated with both src_addr and dest_addr with src addr routing. However, current logic always assumes the src_addr used to generate the key is a /128 host address. This is not true in the following scenarios: 1. When

Re: [PATCH net 3/3] Documentation: add TLS offload documentation

2019-05-16 Thread Alexei Starovoitov
On Thu, May 16, 2019 at 10:57 AM Jakub Kicinski wrote: > > The preferred method of reporting the Layer 4 (TCP) checksum offload > for packets decrypted by the device is to update the checksum field > to the correct value for clear text and report CHECKSUM_UNNECESSARY > or CHECKSUM_COMPLETE

RE: [PATCH v2] hv_sock: Add support for delayed close

2019-05-16 Thread Sunil Muthuswamy
> -Original Message- > From: Dexuan Cui > Sent: Thursday, May 16, 2019 10:17 AM > To: Sunil Muthuswamy ; KY Srinivasan > ; Haiyang Zhang ; > Stephen Hemminger ; Sasha Levin ; > David S. Miller ; > Michael Kelley > Cc: netdev@vger.kernel.org; linux-hyp...@vger.kernel.org; > linux-ker

Re: [PATCH net 3/3] Documentation: add TLS offload documentation

2019-05-16 Thread Jakub Kicinski
On Thu, 16 May 2019 09:08:52 +, Boris Pismenny wrote: > > diff --git a/Documentation/networking/tls-offload.rst > > b/Documentation/networking/tls-offload.rst > > new file mode 100644 > > index ..32fecb3fbc4c > > --- /dev/null > > +++ b/Documentation/networking/tls-offload.rst > >

Re: [PATCH net] selftests: pmtu.sh: Remove quotes around commands in setup_xfrm

2019-05-16 Thread David Ahern
On 5/16/19 11:51 AM, Stefano Brivio wrote: > On Thu, 16 May 2019 10:41:31 -0700 > David Ahern wrote: > >> From: David Ahern >> >> The first command in setup_xfrm is failing resulting in the test getting >> skipped: >> >> + ip netns exec ns-B ip -6 xfrm state add src fd00:1::a dst fd00:1::b spi

Re: [PATCH net] selftests: pmtu.sh: Remove quotes around commands in setup_xfrm

2019-05-16 Thread Stefano Brivio
On Thu, 16 May 2019 10:41:31 -0700 David Ahern wrote: > From: David Ahern > > The first command in setup_xfrm is failing resulting in the test getting > skipped: > > + ip netns exec ns-B ip -6 xfrm state add src fd00:1::a dst fd00:1::b spi > 0x1000 proto esp aead 'rfc4106(gcm(aes))' > 0x0f0f

[PATCH net] selftests: pmtu.sh: Remove quotes around commands in setup_xfrm

2019-05-16 Thread David Ahern
From: David Ahern The first command in setup_xfrm is failing resulting in the test getting skipped: + ip netns exec ns-B ip -6 xfrm state add src fd00:1::a dst fd00:1::b spi 0x1000 proto esp aead 'rfc4106(gcm(aes))' 0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f 128 mode tunnel + out=RTNETLINK ans

[PATCH bpf] tools/bpftool: move set_max_rlimit() before __bpf_object__open_xattr()

2019-05-16 Thread Yonghong Song
For a host which has a lower rlimit for max locked memory (e.g., 64KB), the following error occurs in one of our production systems: # /usr/sbin/bpftool prog load /paragon/pods/52877437/home/mark.o \ /sys/fs/bpf/paragon_mark_21 type cgroup/skb \ map idx 0 pinned /sys/fs/bpf/paragon_map_21

RE: [PATCH v2] hv_sock: Add support for delayed close

2019-05-16 Thread Dexuan Cui
> From: linux-hyperv-ow...@vger.kernel.org > On Behalf Of Dexuan Cui > Sent: Wednesday, May 15, 2019 9:34 PM > ... Hi Sunil, To make it clear, your patch itself is good, and I was just talking about the next change we're going to make. Once we make the next change, IMO we need a further patch to

Re: [Intel-wired-lan] i40e X722 RSS problem with NAT-Traversal IPsec packets

2019-05-16 Thread Alexander Duyck
On Tue, May 14, 2019 at 9:34 AM Lennart Sorensen wrote: > > On Mon, May 13, 2019 at 12:04:00PM -0700, Alexander Duyck wrote: > > So I recreated the first packet you listed via text2pcap, replayed it > > on my test system via tcpreplay, updated my configuration to 12 > > queues, and used the 2 hash

Re: Kernel UDP behavior with missing destinations

2019-05-16 Thread Eric Dumazet
On 5/16/19 9:32 AM, Adam Urban wrote: > Eric, thanks. Increasing wmem_default from 229376 to 2293760 indeed > makes the issue go away on my test bench. What's a good way to > determine the optimal value here? I assume this is in bytes and needs > to be large enough so that the SO_SNDBUF doesn't

[PATCH bpf-next v2 1/2] selftests: bpf: Move bpf_printk to bpf_helpers.h

2019-05-16 Thread Michal Rostecki
bpf_printk is a macro which is commonly used to print out debug messages in BPF programs and it was copied in many selftests and samples. Since all of them include bpf_helpers.h, this change moves the macro there. Signed-off-by: Michal Rostecki --- tools/testing/selftests/bpf/bpf_helpers.h

[PATCH bpf-next v2 2/2] samples: bpf: Do not define bpf_printk macro

2019-05-16 Thread Michal Rostecki
The bpf_printk macro was moved to bpf_helpers.h which is included in all example programs. Signed-off-by: Michal Rostecki --- samples/bpf/hbm_kern.h | 11 ++- samples/bpf/tcp_basertt_kern.c | 7 --- samples/bpf/tcp_bufs_kern.c| 7 --- samples/bpf/tcp_cla

[PATCH bpf-next v2 0/2] Move bpf_printk to bpf_helpers.h

2019-05-16 Thread Michal Rostecki
This series of patches move the commonly used bpf_printk macro to bpf_helpers.h which is already included in all BPF programs which defined that macro on their own. v1->v2: - If HBM_DEBUG is not defined in hbm sample, undefine bpf_printk and set an empty macro for it. Michal Rostecki (2): sel

Re: [PATCH bpf v1 2/3] selftests/bpf: Print a message when tester could not run a program

2019-05-16 Thread Jakub Kicinski
On Thu, 16 May 2019 18:21:32 +0200, Krzesimir Nowak wrote: > On Thu, May 16, 2019 at 5:51 PM Jakub Kicinski wrote: > > On Thu, 16 May 2019 11:29:39 +0200, Krzesimir Nowak wrote: > > > > > diff --git a/tools/testing/selftests/bpf/test_verifier.c > > > > > b/tools/testing/selftests/bpf/test_verifi

[PATCH bpf] selftests/bpf: add test_sysctl and map_tests/tests.h to .gitignore

2019-05-16 Thread Stanislav Fomichev
Missing files are: * tools/testing/selftests/bpf/map_tests/tests.h - autogenerated * tools/testing/selftests/bpf/test_sysctl - binary Fixes: 51a0e301a563 ("bpf: Add BPF_MAP_TYPE_SK_STORAGE test to test_maps") Fixes: 1f5fa9ab6e2e ("selftests/bpf: Test BPF_CGROUP_SYSCTL") Signed-off-by: Stanislav Fo

Re: [PATCH 0/2] rhashtable: Fix sparse warnings

2019-05-16 Thread David Miller
From: Herbert Xu Date: Thu, 16 May 2019 15:18:59 +0800 > This patch series fixes all the sparse warnings. Series applied, thanks Herbert.

Re: Kernel UDP behavior with missing destinations

2019-05-16 Thread Adam Urban
Eric, thanks. Increasing wmem_default from 229376 to 2293760 indeed makes the issue go away on my test bench. What's a good way to determine the optimal value here? I assume this is in bytes and needs to be large enough so that the SO_SNDBUF doesn't fill up before the kernel drops the packets. How

Re: [PATCH] can: gw: Fix error path of cgw_module_init

2019-05-16 Thread Oliver Hartkopp
On 16.05.19 17:54, YueHaibing wrote: This patch fix error path for cgw_module_init to avoid possible crash if some error occurs. Fixes: c1aabdf379bc ("can-gw: add netlink based CAN routing") Signed-off-by: YueHaibing Acked-by: Oliver Hartkopp Thanks! --- net/can/gw.c | 46 +++

Re: [PATCH] can: Fix error path of can_init

2019-05-16 Thread Oliver Hartkopp
On 16.05.19 16:36, YueHaibing wrote: This patch add error path for can_init to avoid possible crash if some error occurs. Fixes: 0d66548a10cb ("[CAN]: Add PF_CAN core module") Signed-off-by: YueHaibing Acked-by: Oliver Hartkopp Thanks! --- net/can/af_can.c | 24 +---

[PATCH net] net: ip6_gre: access skb data after skb_cow_head()

2019-05-16 Thread William Tu
When increases the headroom, skb's pointer might get re-allocated. Fix it by moving skb_cow_head before accessing the skb->data pointer. Fixes: 01b8d064d58b4 ("net: ip6_gre: Request headroom in __gre6_xmit()") Reported-by: Haichao Ma Signed-off-by: William Tu --- net/ipv6/ip6_gre.c | 6 +++---

Re: [PATCH bpf v1 2/3] selftests/bpf: Print a message when tester could not run a program

2019-05-16 Thread Krzesimir Nowak
On Thu, May 16, 2019 at 5:51 PM Jakub Kicinski wrote: > > On Thu, 16 May 2019 11:29:39 +0200, Krzesimir Nowak wrote: > > > > diff --git a/tools/testing/selftests/bpf/test_verifier.c > > > > b/tools/testing/selftests/bpf/test_verifier.c > > > > index ccd896b98cac..bf0da03f593b 100644 > > > > --- a

Re: Kernel UDP behavior with missing destinations

2019-05-16 Thread Eric Dumazet
On 5/16/19 9:05 AM, Eric Dumazet wrote: > We probably should add a ttl on arp queues. > > neigh_probe() could do that quite easily. > Adam, all you need to do is to increase UDP socket sndbuf. Either by increasing /proc/sys/net/core/wmem_default or using setsockopt( ... SO_SNDBUF ... )

Re: Kernel UDP behavior with missing destinations

2019-05-16 Thread Eric Dumazet
On 5/16/19 7:47 AM, Willem de Bruijn wrote: > On Wed, May 15, 2019 at 3:57 PM Adam Urban wrote: >> >> We have an application where we are use sendmsg() to send (lots of) >> UDP packets to multiple destinations over a single socket, repeatedly, >> and at a pretty constant rate using IPv4. >> >>

[PATCH] can: gw: Fix error path of cgw_module_init

2019-05-16 Thread YueHaibing
This patch fix error path for cgw_module_init to avoid possible crash if some error occurs. Fixes: c1aabdf379bc ("can-gw: add netlink based CAN routing") Signed-off-by: YueHaibing --- net/can/gw.c | 46 +++--- 1 file changed, 31 insertions(+), 15 deletions

  1   2   >