From: David Ahern <dsah...@gmail.com>

The first command in setup_xfrm is failing resulting in the test getting
skipped:

+ ip netns exec ns-B ip -6 xfrm state add src fd00:1::a dst fd00:1::b spi 
0x1000 proto esp aead 'rfc4106(gcm(aes))' 
0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f 128 mode tunnel
+ out=RTNETLINK answers: Function not implemented
...
  xfrm6 not supported
TEST: vti6: PMTU exceptions                                         [SKIP]
  xfrm4 not supported
TEST: vti4: PMTU exceptions                                         [SKIP]
...

The setup command started failing when the run_cmd option was added.
Removing the quotes fixes the problem:
...
TEST: vti6: PMTU exceptions                                         [ OK ]
TEST: vti4: PMTU exceptions                                         [ OK ]
...

Fixes: 56490b623aa0 ("selftests: Add debugging options to pmtu.sh")
Signed-off-by: David Ahern <dsah...@gmail.com>
---
 tools/testing/selftests/net/pmtu.sh | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/tools/testing/selftests/net/pmtu.sh 
b/tools/testing/selftests/net/pmtu.sh
index 524b15dabb3c..b9171a7b3aaa 100755
--- a/tools/testing/selftests/net/pmtu.sh
+++ b/tools/testing/selftests/net/pmtu.sh
@@ -430,15 +430,15 @@ setup_xfrm() {
        veth_a_addr="${2}"
        veth_b_addr="${3}"
 
-       run_cmd "${ns_a} ip -${proto} xfrm state add src ${veth_a_addr} dst 
${veth_b_addr} spi 0x1000 proto esp aead 'rfc4106(gcm(aes))' 
0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f 128 mode tunnel" || return 1
-       run_cmd "${ns_a} ip -${proto} xfrm state add src ${veth_b_addr} dst 
${veth_a_addr} spi 0x1001 proto esp aead 'rfc4106(gcm(aes))' 
0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f 128 mode tunnel"
-       run_cmd "${ns_a} ip -${proto} xfrm policy add dir out mark 10 tmpl src 
${veth_a_addr} dst ${veth_b_addr} proto esp mode tunnel"
-       run_cmd "${ns_a} ip -${proto} xfrm policy add dir in mark 10 tmpl src 
${veth_b_addr} dst ${veth_a_addr} proto esp mode tunnel"
-
-       run_cmd "${ns_b} ip -${proto} xfrm state add src ${veth_a_addr} dst 
${veth_b_addr} spi 0x1000 proto esp aead 'rfc4106(gcm(aes))' 
0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f 128 mode tunnel"
-       run_cmd "${ns_b} ip -${proto} xfrm state add src ${veth_b_addr} dst 
${veth_a_addr} spi 0x1001 proto esp aead 'rfc4106(gcm(aes))' 
0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f 128 mode tunnel"
-       run_cmd "${ns_b} ip -${proto} xfrm policy add dir out mark 10 tmpl src 
${veth_b_addr} dst ${veth_a_addr} proto esp mode tunnel"
-       run_cmd "${ns_b} ip -${proto} xfrm policy add dir in mark 10 tmpl src 
${veth_a_addr} dst ${veth_b_addr} proto esp mode tunnel"
+       run_cmd ${ns_a} ip -${proto} xfrm state add src ${veth_a_addr} dst 
${veth_b_addr} spi 0x1000 proto esp aead 'rfc4106(gcm(aes))' 
0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f 128 mode tunnel || return 1
+       run_cmd ${ns_a} ip -${proto} xfrm state add src ${veth_b_addr} dst 
${veth_a_addr} spi 0x1001 proto esp aead 'rfc4106(gcm(aes))' 
0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f 128 mode tunnel
+       run_cmd ${ns_a} ip -${proto} xfrm policy add dir out mark 10 tmpl src 
${veth_a_addr} dst ${veth_b_addr} proto esp mode tunnel
+       run_cmd ${ns_a} ip -${proto} xfrm policy add dir in mark 10 tmpl src 
${veth_b_addr} dst ${veth_a_addr} proto esp mode tunnel
+
+       run_cmd ${ns_b} ip -${proto} xfrm state add src ${veth_a_addr} dst 
${veth_b_addr} spi 0x1000 proto esp aead 'rfc4106(gcm(aes))' 
0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f 128 mode tunnel
+       run_cmd ${ns_b} ip -${proto} xfrm state add src ${veth_b_addr} dst 
${veth_a_addr} spi 0x1001 proto esp aead 'rfc4106(gcm(aes))' 
0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f 128 mode tunnel
+       run_cmd ${ns_b} ip -${proto} xfrm policy add dir out mark 10 tmpl src 
${veth_b_addr} dst ${veth_a_addr} proto esp mode tunnel
+       run_cmd ${ns_b} ip -${proto} xfrm policy add dir in mark 10 tmpl src 
${veth_a_addr} dst ${veth_b_addr} proto esp mode tunnel
 }
 
 setup_xfrm4() {
-- 
2.11.0

Reply via email to