From: Alexei Starovoitov
Date: Thu, 25 Apr 2019 17:27:39 -0700
> The following pull-request contains BPF updates for your *net* tree.
>
> The main changes are:
>
> 1) the bpf verifier fix to properly mark registers in all stack frames, from
> Paul.
>
> 2) preempt_enable_no_resched->preempt_en
From: Jakub Kicinski
Date: Thu, 25 Apr 2019 15:11:17 -0700
> On Thu, 25 Apr 2019 15:59:40 +0200, Jiri Pirko wrote:
>> From: Jiri Pirko
>>
>> Currently the model of netdevsim is a bit odd in multiple ways.
>> 1) devlink instance is not in any way related with actual netdevsim
>>netdevices. I
From: Johan Hedberg
Date: Thu, 25 Apr 2019 06:38:10 -0700
> Here's the main bluetooth-next pull request for the 5.2 kernel.
>
> - Added support for Mediatek SDIO controllers
> - Added support for Broadcom BCM2076B1 UART controller
> - Added support for Marvel SD8987 chipset
> - Fix buffer ov
On Thu, Apr 25, 2019 at 4:08 PM Andrii Nakryiko wrote:
>
> This patch set adds a new `bpftool btf dump` sub-command, which allows to dump
> BTF contents (only types for now). Currently it only outputs low-level
> content, almost 1:1 with binary BTF format, but follow up patches will add
> ability
On 2019/4/26 8:44, Santosh Shilimkar wrote:
From: Hans Westgaard Ry
RDS doesn't support RDMA on memory apertures that require On Demand
Paging (ODP), such as FS DAX memory. User applications can try to use
RDS to perform RDMA over such memories and since it doesn't report any
failure, it can
On 2019/4/26 8:44, Santosh Shilimkar wrote:
RDS doesn't support RDMA on memory apertures that require On Demand
Paging (ODP), such as FS DAX memory. A sysctl is added to indicate
whether RDMA requiring ODP is supported.
Reviewed-by: Håkon Bugge
Reviewed-tested-by: Zhu Yanjun
Thanks, Santos
In an earlier commit that fixes the number of stats contexts to
reserve for the RDMA driver, we added a function parameter to pass in
the number of stats contexts to all the relevant functions. The passed
in parameter should have been used to set the enables field of the
firmware message.
Fixes:
If driver determines that extended TX port statistics are not supported
or allocation of the data structure fails, make sure to pass 0 TX stats
size to firmware to disable it. The firmware returned TX stats size should
also be set to 0 for consistency. This will prevent
bnxt_get_ethtool_stats() f
From: Vasundhara Volam
In the bnxt_init_one() error path, short FW command request memory
is not freed. This patch fixes it.
Fixes: e605db801bde ("bnxt_en: Support for Short Firmware Message")
Signed-off-by: Vasundhara Volam
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/b
If we encounter errors during open and proceed to clean up,
bnxt_hwrm_ring_free() may crash if the rings we try to free have never
been allocated. bnxt_cp_ring_for_rx() or bnxt_cp_ring_for_tx()
may reference pointers that have not been allocated.
Fix it by checking for valid fw_ring_id first befo
The driver builds a list of multicast addresses and sends it to the
firmware when the driver's ndo_set_rx_mode() is called. In rare
cases, the firmware can fail this call if internal resources to
add multicast addresses are exhausted. In that case, we should
try the call again by setting the ALL_
6 miscellaneous bug fixes covering several issues in error code paths,
a setup issue for statistics DMA, and an improvement for setting up
multicast address filters.
Please queue these for stable as well.
Patch #5 (bnxt_en: Fix statistics context reservation logic) is for the
most recent 5.0 stabl
In bnxt_rx_pkt(), if the driver encounters BD errors, it will recycle
the buffers and jump to the end where the uninitailized variable "len"
is referenced. Fix it by adding a new jump label that will skip
the length update. This is the most correct fix since the length
may not be valid when we ge
RDS doesn't support RDMA on memory apertures that require On Demand
Paging (ODP), such as FS DAX memory. A sysctl is added to indicate
whether RDMA requiring ODP is supported.
Reviewed-by: Håkon Bugge
Reviewed-tested-by: Zhu Yanjun
Signed-off-by: Hans Westgaard Ry
Signed-off-by: Santosh Shilimk
RDS doesn't support RDMA on memory apertures that require On Demand
Paging (ODP), such as FS DAX memory. User applications can try to use
RDS to perform RDMA over such memories and since it doesn't report any
failure, it can lead to unexpected issues like memory corruption when
a couple of out of s
From: Hans Westgaard Ry
RDS doesn't support RDMA on memory apertures that require On Demand
Paging (ODP), such as FS DAX memory. User applications can try to use
RDS to perform RDMA over such memories and since it doesn't report any
failure, it can lead to unexpected issues like memory corruption
There is no guarantee the record starts before the skb frags.
If we don't check for this condition copy amount will get
negative, leading to reads and writes to random memory locations.
Familiar hilarity ensues.
Fixes: 4799ac81e52a ("tls: Add rx inline crypto offload")
Signed-off-by: Jakub Kicinsk
Hi!
This series fixes the tls_device_reencrypt() which is broken
if record starts in the frags of the message skb.
---
These will not conflict with net-next fixes, or Johns patches.
Jakub Kicinski (2):
net/tls: don't copy negative amounts of data in reencrypt
net/tls: fix copy to fragments in
Fragments may contain data from other records so we have to account
for that when we calculate the destination and max length of copy we
can perform. Note that 'offset' is the offset within the message,
so it can't be passed as offset within the frag..
Here skb_store_bits() would have realised th
On Thu, Apr 11, 2019 at 12:56 PM Daniel Borkmann wrote:
>
> On 04/11/2019 10:03 AM, Benjamin Poirier wrote:
> > The test meant to use the saved value of errno. Given the current code, it
> > makes no practical difference however.
> >
> > Fixes: bf598a8f0f77 ("bpftool: Improve handling of ENOENT on
Hi David,
The following pull-request contains BPF updates for your *net* tree.
The main changes are:
1) the bpf verifier fix to properly mark registers in all stack frames, from
Paul.
2) preempt_enable_no_resched->preempt_enable fix, from Peter.
3) other misc fixes.
Please consider pulling t
This patch supports probing for the new BPF_MAP_TYPE_SK_STORAGE.
BPF_MAP_TYPE_SK_STORAGE enforces BTF usage, so the new probe
requires to create and load a BTF also.
Signed-off-by: Martin KaFai Lau
---
tools/bpf/bpftool/map.c | 1 +
tools/lib/bpf/libbpf_probes.c | 74 +
This patch sync the bpf.h to tools/.
Signed-off-by: Martin KaFai Lau
---
tools/include/uapi/linux/bpf.h | 44 +-
1 file changed, 43 insertions(+), 1 deletion(-)
diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h
index 704bb69514a2..be08e
After allowing a bpf prog to
- directly read the skb->sk ptr
- get the fullsock bpf_sock by "bpf_sk_fullsock()"
- get the bpf_tcp_sock by "bpf_tcp_sock()"
- get the listener sock by "bpf_get_listener_sock()"
- avoid duplicating the fields of "(bpf_)sock" and "(bpf_)tcp_sock"
into different bpf ru
This patch adds verifier tests for the bpf_sk_storage:
1. ARG_PTR_TO_MAP_VALUE_OR_NULL
2. Map and helper compatibility (e.g. disallow bpf_map_loookup_elem)
It also takes this chance to remove the unused struct btf_raw_data.
Signed-off-by: Martin KaFai Lau
---
tools/testing/selftests/bpf/test_ve
This patch rides on an existing BPF_PROG_TYPE_CGROUP_SKB test
(test_sock_fields.c) to do a TCP end-to-end test on the new
bpf_sk_storage_* helpers.
Signed-off-by: Martin KaFai Lau
---
tools/testing/selftests/bpf/bpf_helpers.h | 5 +
.../bpf/progs/test_sock_fields_kern.c | 49 +
This patch adds BPF_MAP_TYPE_SK_STORAGE test to test_maps.
The src file is rather long, so it is put into another dir map_tests/
and compile like the current prog_tests/ does. Other existing
tests in test_maps can also be re-factored into map_tests/ in the
future.
Signed-off-by: Martin KaFai Lau
v2:
- Add the "test_maps.h" file in patch 5
This series introduces the BPF sk local storage. The
details is in the patch 1 commit message.
Martin KaFai Lau (6):
bpf: Introduce bpf sk local storage
bpf: Sync bpf.h to tools
bpf: Support BPF_MAP_TYPE_SK_STORAGE in bpf map probing
bpf: Add v
On 4/25/19 3:59 PM, Stephen Hemminger wrote:
> I agree with this, but probably time to give ss a json output as well.
Yes, this might be quite nice.
(Although I am not sure of what extra cpu costs would be involved,
when dealing with million of sockets per dump)
On 4/25/19 3:59 PM, Stephen Hemminger wrote:
On Thu, 25 Apr 2019 17:21:48 -0400
Josh Hunt wrote:
Multi-line output in ss makes it difficult to search for things with
grep. This new option will make it easier to find sockets matching
certain criteria with simple grep commands.
Example without
On Thu, 25 Apr 2019 17:21:48 -0400
Josh Hunt wrote:
> Multi-line output in ss makes it difficult to search for things with
> grep. This new option will make it easier to find sockets matching
> certain criteria with simple grep commands.
>
> Example without option:
> $ ss -emoitn
> State Re
It looks that unless RTNL is held, accessing ifa_list needs proper RCU
protection ?
indev->ifa_list can be changed under us by another cpu (which owns RTNL)
Lets took an example.
(A proper rcu_dereference() with an happy sparse support would require adding
__rcu attribute,
I put a READ_ONCE()
On Thu, Apr 25, 2019 at 02:23:08PM +0100, Edward Cree wrote:
> On 24/04/2019 16:03, Edward Cree wrote:
> > static int efx_tc_flower_replace(struct efx_nic *efx,
> > struct net_device *net_dev,
> > struct tc_cls_flower_offload *tc)
>
Fix misaligned default case branch for `prog dump` sub-command.
Reported-by: Quentin Monnet
Cc: Yonghong Song
Reviewed-by: Quentin Monnet
Signed-off-by: Andrii Nakryiko
---
tools/bpf/bpftool/bash-completion/bpftool | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
Add full support for btf command in bash-completion script.
Cc: Quentin Monnet
Cc: Yonghong Song
Cc: Alexei Starovoitov
Cc: Daniel Borkmann
Reviewed-by: Quentin Monnet
Signed-off-by: Andrii Nakryiko
---
tools/bpf/bpftool/bash-completion/bpftool | 46 +++
1 file changed,
This patch set adds a new `bpftool btf dump` sub-command, which allows to dump
BTF contents (only types for now). Currently it only outputs low-level
content, almost 1:1 with binary BTF format, but follow up patches will add
ability to dump BTF types as a compilable C header file. JSON output is
su
Document usage and sample output format for `btf dump` sub-command.
Cc: Daniel Borkmann
Cc: Alexei Starovoitov
Cc: Yonghong Song
Cc: Martin KaFai Lau
Cc: Song Liu
Cc: Arnaldo Carvalho de Melo
Acked-by: Yonghong Song
Signed-off-by: Andrii Nakryiko
---
.../bpf/bpftool/Documentation/bpftool-
Add new `btf dump` sub-command to bpftool. It allows to dump
human-readable low-level BTF types representation of BTF types. BTF can
be retrieved from few different sources:
- from BTF object by ID;
- from PROG, if it has associated BTF;
- from MAP, if it has associated BTF data; it's possibl
On Thu, Apr 25, 2019 at 12:20 PM Quentin Monnet
wrote:
>
> 2019-04-25 09:55 UTC-0700 ~ Andrii Nakryiko
> > Document usage and sample output format for `btf dump` sub-command.
> >
> > Cc: Daniel Borkmann
> > Cc: Alexei Starovoitov
> > Cc: Yonghong Song
> > Cc: Martin KaFai Lau
> > Cc: Song Liu
On Thu, 25 Apr 2019 15:59:40 +0200, Jiri Pirko wrote:
> From: Jiri Pirko
>
> Currently the model of netdevsim is a bit odd in multiple ways.
> 1) devlink instance is not in any way related with actual netdevsim
>netdevices. Instead, it is created per-namespace.
> 2) multi-port netdevsim devic
On Thu, Apr 25, 2019 at 08:25:44AM +0100, Jiong Wang wrote:
>
> Alexei Starovoitov writes:
>
> > On Thu, Apr 25, 2019 at 12:07:06AM +0100, Jiong Wang wrote:
> >>
> >> Alexei Starovoitov writes:
> >>
> >> > Add two tests to check that sequence of 1024 jumps is verifiable.
> >> >
> >> > Signed-of
On Thu, Apr 25, 2019 at 12:20 PM Quentin Monnet
wrote:
>
> 2019-04-25 09:55 UTC-0700 ~ Andrii Nakryiko
> > Add new `btf dump` sub-command to bpftool. It allows to dump
> > human-readable low-level BTF types representation of BTF types. BTF can
> > be retrieved from few different sources:
> >-
On Thu, Apr 25, 2019 at 12:20 PM Quentin Monnet
wrote:
>
> 2019-04-25 09:55 UTC-0700 ~ Andrii Nakryiko
> > This patch set adds a new `bpftool btf dump` sub-command, which allows to
> > dump
> > BTF contents (only types for now). Currently it only outputs low-level
> > content, almost 1:1 with bi
On 04/25/2019 11:37 PM, Stanislav Fomichev wrote:
> target_fd is target namespace. If there is a flow dissector BPF program
> attached to that namespace, its (single) id is returned.
>
> v5:
> * drop net ref right after rcu unlock (Daniel Borkmann)
>
> v4:
> * add missing put_net (Jann Horn)
>
>
On 04/23/2019 10:24 PM, Daniel T. Lee wrote:
> Currently, building bpf samples will cause the following error.
>
> ./tools/lib/bpf/bpf.h:132:27: error: 'UINT32_MAX' undeclared here (not in
> a function) ..
> #define BPF_LOG_BUF_SIZE (UINT32_MAX >> 8) /* verifier maximum in
> kernels <=
On 04/25/2019 11:02 AM, Daniel T. Lee wrote:
> This commit adds hbm to .gitignore which is
> currently ommited from the ignore file.
>
> Signed-off-by: Daniel T. Lee
Applied, thanks.
Right now there is no way to query whether BPF flow_dissector program
is attached to a network namespace or not. In previous commit, I added
support for querying that info, show it when doing `bpftool net`:
$ bpftool prog loadall ./bpf_flow.o \
/sys/fs/bpf/flow type flow_dissector \
target_fd is target namespace. If there is a flow dissector BPF program
attached to that namespace, its (single) id is returned.
v5:
* drop net ref right after rcu unlock (Daniel Borkmann)
v4:
* add missing put_net (Jann Horn)
v3:
* add missing inline to skb_flow_dissector_prog_query static def
On Thu, Apr 25, 2019 at 2:21 PM Daniel Borkmann wrote:
>
> On 04/24/2019 11:31 PM, Stanislav Fomichev wrote:
> > target_fd is target namespace. If there is a flow dissector BPF program
> > attached to that namespace, its (single) id is returned.
> >
> > v4:
> > * add missing put_net (Jann Horn)
>
Multi-line output in ss makes it difficult to search for things with
grep. This new option will make it easier to find sockets matching
certain criteria with simple grep commands.
Example without option:
$ ss -emoitn
State Recv-Q Send-Q Local Address:Port Peer Address:Port
ESTAB
On 04/24/2019 11:31 PM, Stanislav Fomichev wrote:
> target_fd is target namespace. If there is a flow dissector BPF program
> attached to that namespace, its (single) id is returned.
>
> v4:
> * add missing put_net (Jann Horn)
>
> v3:
> * add missing inline to skb_flow_dissector_prog_query static
On 04/25/2019 10:46 PM, Alexei Starovoitov wrote:
> On Wed, Apr 24, 2019 at 09:49:58PM +0200, Paul Chaignon wrote:
>> In case of a null check on a pointer inside a subprog, we should mark all
>> registers with this pointer as either safe or unknown, in both the current
>> and previous frames. Curr
On Tue, Apr 23, 2019 at 3:46 PM Daniel Borkmann wrote:
>
> Two small fixes in relation to global data handling. Thanks!
Applied. Thanks!
On Wed, Apr 24, 2019 at 09:49:58PM +0200, Paul Chaignon wrote:
> In case of a null check on a pointer inside a subprog, we should mark all
> registers with this pointer as either safe or unknown, in both the current
> and previous frames. Currently, only spilled registers and registers in
> the cu
On Wed, 2019-04-24 at 13:53 +0800, Firo wrote:
>
> On 4/20/19 6:31 AM, Saeed Mahameed wrote:
> > On Fri, 2019-04-19 at 21:07 +0800, Firo wrote:
> > > On 4/19/19 2:17 AM, Saeed Mahameed wrote:
> > > > On Thu, 2019-04-18 at 15:05 +0800, Firo wrote:
> > > > > On 4/2/19 12:25 AM, Saeed Mahameed wrote:
On Thu, 2019-04-25 at 12:32 -0700, Jakub Kicinski wrote:
> Hi!
>
> This small patch set cleans up tls (mostly offload parts).
> Other than avoiding unnecessary error messages - no functional
> changes here.
>
> v2 (Saeed):
> - fix up Review tags;
> - remove the warning on failure completely.
>
On Thu, 2019-04-25 at 12:38 -0700, Jakub Kicinski wrote:
> On Thu, 25 Apr 2019 19:31:51 +, Saeed Mahameed wrote:
> > > diff --git a/net/tls/tls_device.c b/net/tls/tls_device.c
> > > index cb368efe3567..6686013b4e9e 100644
> > > --- a/net/tls/tls_device.c
> > > +++ b/net/tls/tls_device.c
> > > @
On Thu, 25 Apr 2019 20:54:11 +0200
Maciej Fijalkowski wrote:
> On Thu, 25 Apr 2019 11:44:27 -0600
> David Ahern wrote:
>
> > On 4/25/19 11:41 AM, Jesper Dangaard Brouer wrote:
> > > On Thu, 25 Apr 2019 13:03:39 -0400
> > > "Michael S. Tsirkin" wrote:
> > >
> > >> On Thu, Apr 25, 2019 at
On 4/25/19 12:54 PM, Maciej Fijalkowski wrote:
>>
>> virtio_net hits this because of:
>>xdp_prog = rcu_dereference(rq->xdp_prog);
>>
>> in its ndo_xdp_xmit. Scanning ndo_xdp_xmit for other nics does not show
>> this same check. Is it really required? If so, why don't other drivers
>> do it?
>
On Thu, 25 Apr 2019 12:35:58 -0700, John Fastabend wrote:
> On 4/25/19 12:32 PM, John Fastabend wrote:
> > On 4/25/19 12:29 PM, Jakub Kicinski wrote:
> >> On Thu, 25 Apr 2019 09:03:08 -0700, John Fastabend wrote:
> >>> +static void tls_sk_proto_unhash(struct sock *sk)
> >>> +{
> >>> + struct tl
On Thu, 25 Apr 2019 19:31:51 +, Saeed Mahameed wrote:
> > diff --git a/net/tls/tls_device.c b/net/tls/tls_device.c
> > index cb368efe3567..6686013b4e9e 100644
> > --- a/net/tls/tls_device.c
> > +++ b/net/tls/tls_device.c
> > @@ -567,7 +567,7 @@ void (struct sock *sk, u32
> > seq, u64 rcd_sn)
>
On 4/25/19 12:32 PM, John Fastabend wrote:
> On 4/25/19 12:29 PM, Jakub Kicinski wrote:
>> On Thu, 25 Apr 2019 09:03:08 -0700, John Fastabend wrote:
>>> +static void tls_sk_proto_unhash(struct sock *sk)
>>> +{
>>> + struct tls_context *ctx = tls_get_ctx(sk);
>>> + void (*sk_proto_unhash)(struct
There seems to be no reason for tls_ops to be defined in netdevice.h
which is included in a lot of places. Don't wrap the struct/enum
declaration in ifdefs, it trickles down unnecessary ifdefs into
driver code.
Signed-off-by: Jakub Kicinski
Reviewed-by: Simon Horman
---
include/linux/netdevice
Hi!
This small patch set cleans up tls (mostly offload parts).
Other than avoiding unnecessary error messages - no functional
changes here.
v2 (Saeed):
- fix up Review tags;
- remove the warning on failure completely.
Jakub Kicinski (4):
net/tls: don't log errors every time offload can't pro
On 4/25/19 12:29 PM, Jakub Kicinski wrote:
> On Thu, 25 Apr 2019 09:03:08 -0700, John Fastabend wrote:
>> +static void tls_sk_proto_unhash(struct sock *sk)
>> +{
>> +struct tls_context *ctx = tls_get_ctx(sk);
>> +void (*sk_proto_unhash)(struct sock *sk);
>> +bool free_ctx;
>> +
>> +
tls_device_sk_destruct being set on a socket used to indicate
that socket is a kTLS device one. That is no longer true -
now we use sk_validate_xmit_skb pointer for that purpose.
Remove the export. tls_device_attach() needs to be moved.
While at it, remove the dead declaration of tls_sk_destruct
To avoid a sparse warning byteswap the be32 sequence number
before it's stored in the atomic value. While at it drop
unnecessary brackets and use kernel's u64 type.
Signed-off-by: Jakub Kicinski
Reviewed-by: Simon Horman
---
include/net/tls.h| 2 +-
net/tls/tls_device.c | 2 +-
2 files cha
Currently when CONFIG_TLS_DEVICE is set each time kTLS
connection is opened and the offload is not successful
(either because the underlying device doesn't support
it or e.g. it's tables are full) a rate limited error
will be printed to the logs.
There is nothing wrong with failing TLS offload. S
On Thu, 2019-04-25 at 09:56 -0700, Jakub Kicinski wrote:
> To avoid a sparse warning byteswap the be32 sequence number
> before it's stored in the atomic value. While at it drop
> unnecessary brackets and use kernel's u64 type.
>
> Signed-off-by: Jakub Kicinski
> Reviewed-by: Reviewed-by: Simon
On Thu, 25 Apr 2019 09:03:08 -0700, John Fastabend wrote:
> +static void tls_sk_proto_unhash(struct sock *sk)
> +{
> + struct tls_context *ctx = tls_get_ctx(sk);
> + void (*sk_proto_unhash)(struct sock *sk);
> + bool free_ctx;
> +
> + if (!ctx)
> + return sk->sk_prot->un
On Thu, 2019-04-25 at 09:56 -0700, Jakub Kicinski wrote:
> There seems to be no reason for tls_ops to be defined in netdevice.h
> which is included in a lot of places. Don't wrap the struct/enum
> declaration in ifdefs, it trickles down unnecessary ifdefs into
> driver code.
>
> Signed-off-by: Ja
2019-04-25 09:55 UTC-0700 ~ Andrii Nakryiko
Fix misaligned default case branch for `prog dump` sub-command.
Reported-by: Quentin Monnet
Cc: Yonghong Song
Signed-off-by: Andrii Nakryiko
---
tools/bpf/bpftool/bash-completion/bpftool | 22 +++---
1 file changed, 11 insertions
2019-04-25 09:55 UTC-0700 ~ Andrii Nakryiko
Add full support for btf command in bash-completion script.
Cc: Quentin Monnet
Cc: Yonghong Song
Cc: Alexei Starovoitov
Cc: Daniel Borkmann
Signed-off-by: Andrii Nakryiko
---
tools/bpf/bpftool/bash-completion/bpftool | 46 ++
2019-04-25 09:55 UTC-0700 ~ Andrii Nakryiko
Document usage and sample output format for `btf dump` sub-command.
Cc: Daniel Borkmann
Cc: Alexei Starovoitov
Cc: Yonghong Song
Cc: Martin KaFai Lau
Cc: Song Liu
Cc: Arnaldo Carvalho de Melo
Acked-by: Yonghong Song
Signed-off-by: Andrii Nakryi
2019-04-25 09:55 UTC-0700 ~ Andrii Nakryiko
Add new `btf dump` sub-command to bpftool. It allows to dump
human-readable low-level BTF types representation of BTF types. BTF can
be retrieved from few different sources:
- from BTF object by ID;
- from PROG, if it has associated BTF;
- fro
2019-04-25 09:55 UTC-0700 ~ Andrii Nakryiko
This patch set adds a new `bpftool btf dump` sub-command, which allows to dump
BTF contents (only types for now). Currently it only outputs low-level
content, almost 1:1 with binary BTF format, but follow up patches will add
ability to dump BTF types a
On Thu, 25 Apr 2019 18:37:19 +, Saeed Mahameed wrote:
> On Thu, 2019-04-25 at 09:56 -0700, Jakub Kicinski wrote:
> > Currently when CONFIG_TLS_DEVICE is set each time kTLS
> > connection is opened and the offload is not successful
> > (either because the underlying device doesn't support
> > it
On Thu, 25 Apr 2019 11:49:18 -0700, John Fastabend wrote:
> On 4/25/19 11:30 AM, Jakub Kicinski wrote:
> > On Thu, 25 Apr 2019 09:02:50 -0700, John Fastabend wrote:
> >> Series of fixes for sockmap and ktls, see patches for descriptions.
> >>
> >> v2: fix build issue for CONFIG_TLS_DEVICE and fix
On Thu, 25 Apr 2019 11:44:27 -0600
David Ahern wrote:
> On 4/25/19 11:41 AM, Jesper Dangaard Brouer wrote:
> > On Thu, 25 Apr 2019 13:03:39 -0400
> > "Michael S. Tsirkin" wrote:
> >
> >> On Thu, Apr 25, 2019 at 01:58:48PM +0900, Toshiaki Makita wrote:
> >>> On 2019/04/25 2:37, Michael S. Ts
On 4/25/19 11:30 AM, Jakub Kicinski wrote:
> On Thu, 25 Apr 2019 09:02:50 -0700, John Fastabend wrote:
>> Series of fixes for sockmap and ktls, see patches for descriptions.
>>
>> v2: fix build issue for CONFIG_TLS_DEVICE and fixup couple comments from
>> Jakub.
>
> Ah, right my comment about
On Thu, 2019-04-25 at 09:56 -0700, Jakub Kicinski wrote:
> Currently when CONFIG_TLS_DEVICE is set each time kTLS
> connection is opened and the offload is not successful
> (either because the underlying device doesn't support
> it or e.g. it's tables are full) a rate limited error
> will be printe
On Thu, 25 Apr 2019 09:02:50 -0700, John Fastabend wrote:
> Series of fixes for sockmap and ktls, see patches for descriptions.
>
> v2: fix build issue for CONFIG_TLS_DEVICE and fixup couple comments from
> Jakub.
Ah, right my comment about the rx side sleeping was fairly nonsensical,
the loc
On Tue, Apr 23, 2019 at 07:33:10PM +0200, Heiner Kallweit wrote:
> Except having "switch" in the name this driver is solely a SPI driver
> and it uses no network code at all. And it has no dependency on any
> network driver. Therefore I wouldn't consider it a network driver.
> Else any functionali
On 4/25/19 11:41 AM, Jesper Dangaard Brouer wrote:
> On Thu, 25 Apr 2019 13:03:39 -0400
> "Michael S. Tsirkin" wrote:
>
>> On Thu, Apr 25, 2019 at 01:58:48PM +0900, Toshiaki Makita wrote:
>>> On 2019/04/25 2:37, Michael S. Tsirkin wrote:
On Wed, Apr 24, 2019 at 11:13:42AM -0600, David Aher
On Thu, 25 Apr 2019 13:03:39 -0400
"Michael S. Tsirkin" wrote:
> On Thu, Apr 25, 2019 at 01:58:48PM +0900, Toshiaki Makita wrote:
> > On 2019/04/25 2:37, Michael S. Tsirkin wrote:
> > > On Wed, Apr 24, 2019 at 11:13:42AM -0600, David Ahern wrote:
> > >> seeing an RCU warning testing xdp with
On Thu, Apr 25, 2019 at 12:19 AM John Fastabend
wrote:
>
> Its handy to not have to setup a cgroup environment when running
> test_sockmap with user specified options. This patch setups a cgroup
> environment, similar to how it is done with the auto test suite, when
> the user does not provide a c
On 19.04.2019 01:30, David Miller wrote:
> From: Heiner Kallweit
> Date: Wed, 17 Apr 2019 00:06:28 +0200
>
>> This driver is the only user of PHY_10GBIT_FEC_FEATURES. So we may be
>> able to remove this predefined feature constant later. Setting
>> phydev->advertising to what is supported is done
Arnd Bergmann schreef op do 25-04-2019 om 13:08 [+0200]:
> The gigaset driver is similar here, you can use it for any kind of wireless
> ISDN
> communication,
Nit: the wireless part is strictly DECT (for the M101 and M105 hardware).
> but apparently there is little use for that without a physica
On 4/25/19 9:02 AM, Murilo Fossa Vicentini wrote:
The ibmvnic driver currently uses the same fixed name when using
request_irq, this makes it hard to parse when multiple VNIC devices are
available at the same time. This patch adds the unit_address as the device
identification along with an id f
On Thu, Apr 25, 2019 at 01:58:48PM +0900, Toshiaki Makita wrote:
> On 2019/04/25 2:37, Michael S. Tsirkin wrote:
> > On Wed, Apr 24, 2019 at 11:13:42AM -0600, David Ahern wrote:
> >> seeing an RCU warning testing xdp with virtio net. net-next as of commit
> >> b2f97f7de2f6a4df8e431330cf467576486651
tls_device_sk_destruct being set on a socket used to indicate
that socket is a kTLS device one. That is no longer true -
now we use sk_validate_xmit_skb pointer for that purpose.
Remove the export. tls_device_attach() needs to be moved.
While at it, remove the dead declaration of tls_sk_destruct
There seems to be no reason for tls_ops to be defined in netdevice.h
which is included in a lot of places. Don't wrap the struct/enum
declaration in ifdefs, it trickles down unnecessary ifdefs into
driver code.
Signed-off-by: Jakub Kicinski
Reviewed-by: Reviewed-by: Simon Horman
---
include/li
To avoid a sparse warning byteswap the be32 sequence number
before it's stored in the atomic value. While at it drop
unnecessary brackets and use kernel's u64 type.
Signed-off-by: Jakub Kicinski
Reviewed-by: Reviewed-by: Simon Horman
---
include/net/tls.h| 2 +-
net/tls/tls_device.c | 2 +-
Currently when CONFIG_TLS_DEVICE is set each time kTLS
connection is opened and the offload is not successful
(either because the underlying device doesn't support
it or e.g. it's tables are full) a rate limited error
will be printed to the logs.
There is nothing wrong with failing TLS offload. S
Hi!
This small patch set cleans up tls (mostly offload parts).
Other than avoiding unnecessary error messages - no functional
changes here.
Jakub Kicinski (4):
net/tls: don't log errors every time offload can't proceed
net/tls: remove old exports of sk_destruct functions
net/tls: move defin
On Thu, Apr 25, 2019 at 11:02:33AM -0300, Murilo Fossa Vicentini wrote:
> The ibmvnic driver currently uses the same fixed name when using
> request_irq, this makes it hard to parse when multiple VNIC devices are
> available at the same time. This patch adds the unit_address as the device
> identif
On Thu, Apr 25, 2019 at 9:33 AM Quentin Monnet
wrote:
>
> 2019-04-25 09:14 UTC-0700 ~ Andrii Nakryiko
> > On Thu, Apr 25, 2019 at 4:15 AM Quentin Monnet
> > wrote:
> >>
> >> 2019-04-24 22:03 UTC-0700 ~
> >>> From: Andrii Nakryiko
> >>>
> >>> Add full support for btf command in bash-completion
2019-04-25 09:14 UTC-0700 ~ Andrii Nakryiko
> On Thu, Apr 25, 2019 at 4:15 AM Quentin Monnet
> wrote:
>>
>> 2019-04-24 22:03 UTC-0700 ~
>>> From: Andrii Nakryiko
>>>
>>> Add full support for btf command in bash-completion script.
>>>
>>> Cc: Quentin Monnet
>>> Cc: Yonghong Song
>>> Cc: Daniel
From: Arnd Bergmann
clang produces a harmless warning for each use for the qeth_adp_supported
macro:
drivers/s390/net/qeth_l2_main.c:559:31: warning: implicit conversion from
enumeration type 'enum qeth_ipa_setadp_cmd' to
different enumeration type 'enum qeth_ipa_funcs' [-Wenum-conversion
On the first initialization of a queue, its Output Buffers are in a
clean state with no attached resources. On every subsequent
initialization, qeth_l?_stop_card() has previously put them in a clean
state via qeth_drain_output_queues(). So the call to
qeth_clear_output_buffer() is redundant and can
1 - 100 of 164 matches
Mail list logo
