Re: [PATCH bpf-next v6 11/16] bpf, libbpf: support global data/bss/rodata sections

2019-04-18 Thread Andrii Nakryiko
On Tue, Apr 9, 2019 at 2:20 PM Daniel Borkmann wrote: > > This work adds BPF loader support for global data sections > to libbpf. This allows to write BPF programs in more natural > C-like way by being able to define global variables and const > data. > > Back at LPC 2018 [0] we presented a first

Greetings Friend

2019-04-18 Thread Ibrahim Isma
Greetings Friend Forgive me for writing you this letter , I will like to bring to your that (8.5.million Euro claims ) This is a legitimate transaction and The money will be shared 60% for me and 40% for you . get back to me, I will give you full details on how the money will be transfer to y

Re: [PATCH v3 0/3] net: add reset-controller driven PHY reset

2019-04-18 Thread David Miller
From: David Bauer Date: Wed, 17 Apr 2019 23:59:19 +0200 > This patchset adds support for a PHY reset driven by a reset-controller. > Currently, only GPIO driven resets are supported by the PHY subsystem. > It also renames the reset-gpio from 'reset' to 'reset_gpio' to > better differentiate betwe

Re: [PATCH bpf-next v5 5/6] net: pass net argument to the eth_get_headlen

2019-04-18 Thread Stanislav Fomichev
On 04/18, Alexei Starovoitov wrote: > On Mon, Apr 15, 2019 at 10:38:00AM -0700, Stanislav Fomichev wrote: > > Update all users eth_get_headlen to pass network namespace > > and pass it down to the flow dissector. This commit is a noop > > until administrator inserts BPF flow dissector program. > >

Re: [PATCH net-next 0/5] net: some build fixes and other improvements

2019-04-18 Thread Jakub Kicinski
On Thu, 18 Apr 2019 17:06:47 -0700 (PDT), David Miller wrote: > From: Jakub Kicinski > Date: Wed, 17 Apr 2019 13:51:54 -0700 > > > A few unrelated improvements here, mostly trying to make random > > configs build and W=1 produce a little less warnings under net/ > > and drivers net/. > > > > Fir

Re: [PATCH bpf-next v5 5/6] net: pass net argument to the eth_get_headlen

2019-04-18 Thread Alexei Starovoitov
On Mon, Apr 15, 2019 at 10:38:00AM -0700, Stanislav Fomichev wrote: > Update all users eth_get_headlen to pass network namespace > and pass it down to the flow dissector. This commit is a noop > until administrator inserts BPF flow dissector program. > > Cc: Maxim Krasnyansky > Cc: Saeed Mahameed

Re: [PATCH net-next 0/5] net: some build fixes and other improvements

2019-04-18 Thread David Miller
From: Jakub Kicinski Date: Wed, 17 Apr 2019 13:51:54 -0700 > A few unrelated improvements here, mostly trying to make random > configs build and W=1 produce a little less warnings under net/ > and drivers net/. > > First two patches fix set but not used warnings with W=1. > > Next patch fixes 6

Re: [PATCH bpf-next] bpf: move BPF_PROG_TYPE_FLOW_DISSECTOR documentation to a new common place

2019-04-18 Thread Alexei Starovoitov
On Thu, Apr 18, 2019 at 4:47 PM Stanislav Fomichev wrote: > > In commit da7031491786 ("bpf: Document BPF_PROG_TYPE_CGROUP_SYSCTL") > Andrey proposes to put per-prog type docs under Documentation/bpf/ > > Let's move flow dissector documentation there as well. > > Signed-off-by: Stanislav Fomichev

Re: [PATCH net-next,v3] ipv6: Add rate limit mask for ICMPv6 messages

2019-04-18 Thread David Miller
From: Stephen Suryaputra Date: Wed, 17 Apr 2019 16:35:49 -0400 > To make ICMPv6 closer to ICMPv4, add ratemask parameter. Since the ICMP > message types use larger numeric values, a simple bitmask doesn't fit. > I use large bitmap. The input and output are the in form of list of > ranges. Set the

Re: [PATCH v4 bpf-next 02/15] bpf: mark lo32 writes that should be zero extended into hi32

2019-04-18 Thread Alexei Starovoitov
On Mon, Apr 15, 2019 at 06:26:12PM +0100, Jiong Wang wrote: > eBPF ISA specification requires high 32-bit cleared when low 32-bit > sub-register is written. This applies to destination register of ALU32 etc. > JIT back-ends must guarantee this semantic when doing code-gen. > > x86-64 and arm64 ISA

Re: [PATCH net] net/tls: fix refcount adjustment in fallback

2019-04-18 Thread David Miller
From: Jakub Kicinski Date: Wed, 17 Apr 2019 10:51:19 -0700 > Unlike atomic_add(), refcount_add() does not deal well > with a negative argument. TLS fallback code reallocates > the skb and is very likely to shrink the truesize, leading to: > > [ 189.513254] WARNING: CPU: 5 PID: 0 at lib/refcoun

[PATCH bpf-next] bpf: move BPF_PROG_TYPE_FLOW_DISSECTOR documentation to a new common place

2019-04-18 Thread Stanislav Fomichev
In commit da7031491786 ("bpf: Document BPF_PROG_TYPE_CGROUP_SYSCTL") Andrey proposes to put per-prog type docs under Documentation/bpf/ Let's move flow dissector documentation there as well. Signed-off-by: Stanislav Fomichev --- Documentation/bpf/index.rst | 1 +

Re: [PATCH net] team: fix possible recursive locking when add slaves

2019-04-18 Thread David Miller
From: Hangbin Liu Date: Wed, 17 Apr 2019 20:12:11 +0800 > If we add a bond device which is already the master of the team interface, > we will hold the team->lock in team_add_slave() first and then request the > lock in team_set_mac_address() again. The functions are called like: > > - team_add_

Re: [PATCH net-next] net: phy: remove dead code from phy_sanitize_settings

2019-04-18 Thread David Miller
From: Heiner Kallweit Date: Wed, 17 Apr 2019 00:13:09 +0200 > phy_sanitize_settings() is called from phy_start_aneg() only, and only > if phydev->autoneg isn't set. Therefore the removed code does nothing. > > Signed-off-by: Heiner Kallweit Applied.

Re: [PATCH net-next] net: phy: bcm87xx: improve feature configuration

2019-04-18 Thread David Miller
From: Heiner Kallweit Date: Wed, 17 Apr 2019 00:06:28 +0200 > This driver is the only user of PHY_10GBIT_FEC_FEATURES. So we may be > able to remove this predefined feature constant later. Setting > phydev->advertising to what is supported is done by phy_probe(), > therefore we don't have to do i

Re: [PATCH net-next] net: phy: don't set autoneg if it's not supported

2019-04-18 Thread David Miller
From: Heiner Kallweit Date: Tue, 16 Apr 2019 23:54:00 +0200 > In phy_device_create() we set phydev->autoneg = 1. This isn't changed > even if the PHY doesn't support autoneg. This seems to affect very > few PHY's, and they disable phydev->autoneg in their config_init > callback. So it's more of a

Re: [PATCH bpf-next] bpf: Increase MAX_NR_MAPS to 17 in test_verifier.c

2019-04-18 Thread Alexei Starovoitov
On Thu, Apr 18, 2019 at 2:34 PM Martin KaFai Lau wrote: > > map_fds[16] is the last one index-ed by fixup_map_array_small. > Hence, the MAX_NR_MAPS should be 17 instead. > > Fixes: fb2abb73e575 ("bpf, selftest: test {rd, wr}only flags and direct value > access") > Signed-off-by: Martin KaFai Lau

Re: [PATCH bpf-next] libbpf: remove compile time warning from libbpf_util.h

2019-04-18 Thread Alexei Starovoitov
On Thu, Apr 18, 2019 at 12:21 AM Magnus Karlsson wrote: > > Having a helpful compile time warning in libbpf_util.h is not a good > idea since all warnings are treated as errors. Change this into a > comment in the code instead. > > Fixes: b7e3a28019c9 ("libbpf: remove dependency on barrier.h in xs

Re: [PATCH bpf-next] bpf: Document BPF_PROG_TYPE_CGROUP_SYSCTL

2019-04-18 Thread Alexei Starovoitov
On Wed, Apr 17, 2019 at 10:29 PM Andrey Ignatov wrote: > > Add documentation for BPF_PROG_TYPE_CGROUP_SYSCTL, including general > info, attach type, context, return code, helpers, example and usage > considerations. > > A separate file prog_cgroup_sysctl.rst is added to Documentation/bpf/. > > In

Re: [Intel-wired-lan] [next-queue PATCH v1] igb: Fix limiting the number of queues to number of cpus

2019-04-18 Thread Vinicius Costa Gomes
Hi Alex, Alexander Duyck writes: > On Thu, Apr 18, 2019 at 1:57 PM Vinicius Costa Gomes > wrote: >> >> Hi Jeff, >> >> Jeff Kirsher writes: >> >> > I will discuss the issue with my fellow developers and hopefully we can >> > come up with a kernel interface that all drivers can use to handle thi

Re: [PATCH net-next 06/15] dsa: Remove const from tag driver ops structure

2019-04-18 Thread Andrew Lunn
On Thu, Apr 18, 2019 at 10:58:46AM -0700, Florian Fainelli wrote: > > > On 4/17/2019 7:31 PM, Andrew Lunn wrote: > > A later patch will create a linked list of tag driver ops structures, > > using a list_head in the structure. So the structure cannot be const. > > Can't we encapsulate the existi

Re: [PATCH bpf-next] bpf: Increase MAX_NR_MAPS to 17 in test_verifier.c

2019-04-18 Thread Yonghong Song
On 4/18/19 2:33 PM, Martin KaFai Lau wrote: > map_fds[16] is the last one index-ed by fixup_map_array_small. > Hence, the MAX_NR_MAPS should be 17 instead. > > Fixes: fb2abb73e575 ("bpf, selftest: test {rd, wr}only flags and direct value > access") > Signed-off-by: Martin KaFai Lau Acked-by:

[PATCH bpf-next] bpf: Increase MAX_NR_MAPS to 17 in test_verifier.c

2019-04-18 Thread Martin KaFai Lau
map_fds[16] is the last one index-ed by fixup_map_array_small. Hence, the MAX_NR_MAPS should be 17 instead. Fixes: fb2abb73e575 ("bpf, selftest: test {rd, wr}only flags and direct value access") Signed-off-by: Martin KaFai Lau --- tools/testing/selftests/bpf/test_verifier.c | 2 +- 1 file chang

Re: [Intel-wired-lan] [next-queue PATCH v1] igb: Fix limiting the number of queues to number of cpus

2019-04-18 Thread Alexander Duyck
On Thu, Apr 18, 2019 at 1:57 PM Vinicius Costa Gomes wrote: > > Hi Jeff, > > Jeff Kirsher writes: > > > I will discuss the issue with my fellow developers and hopefully we can > > come up with a kernel interface that all drivers can use to handle this > > issue. > > Did you have the chance to dis

Re: [PATCH bpf-next] libbpf: remove compile time warning from libbpf_util.h

2019-04-18 Thread Y Song
On Thu, Apr 18, 2019 at 12:23 AM Magnus Karlsson wrote: > > Having a helpful compile time warning in libbpf_util.h is not a good > idea since all warnings are treated as errors. Change this into a > comment in the code instead. > > Fixes: b7e3a28019c9 ("libbpf: remove dependency on barrier.h in xs

Re: [next-queue PATCH v1] igb: Fix limiting the number of queues to number of cpus

2019-04-18 Thread Vinicius Costa Gomes
Hi Jeff, Jeff Kirsher writes: > I will discuss the issue with my fellow developers and hopefully we can > come up with a kernel interface that all drivers can use to handle this > issue. Did you have the chance to discuss this issue? Cheers, -- Vinicius

Re: [PATCH bpf-next] bpf: Document BPF_PROG_TYPE_CGROUP_SYSCTL

2019-04-18 Thread Yonghong Song
On 4/17/19 10:28 PM, Andrey Ignatov wrote: > Add documentation for BPF_PROG_TYPE_CGROUP_SYSCTL, including general > info, attach type, context, return code, helpers, example and usage > considerations. > > A separate file prog_cgroup_sysctl.rst is added to Documentation/bpf/. > > In the future

Re: [PATCH] net: socionext: replace napi_alloc_frag with the netdev variant on init

2019-04-18 Thread Ilias Apalodimas
Hi Ard, > > Use netdev_alloc_frag during the Rx ring setup instead napi_alloc_frag > > > > Why? > The netdev variant is usable on any context since it disables interrupts. The napi variant of the call is supposed to be used under softirq context only > > Signed-off-by: Ilias Apalodimas > > -

Re: [PATCH v7 1/2] net: phy: mscc: add support for VSC8514 PHY.

2019-04-18 Thread Heiner Kallweit
On 18.04.2019 14:15, kavyasree.kotag...@microchip.com wrote: > From: Kavya Sree Kotagiri > > The VSC8514 PHY is a 4-ports PHY that is 10/100/1000BASE-T, 100BASE-FX, > 1000BASE-X, can communicate with the MAC via QSGMII. > The MAC interface protocol for each port within QSGMII can > be either 1000

Re: [PATCH] net: socionext: replace napi_alloc_frag with the netdev variant on init

2019-04-18 Thread Ard Biesheuvel
On Thu, 18 Apr 2019 at 11:27, Ilias Apalodimas wrote: > > Use netdev_alloc_frag during the Rx ring setup instead napi_alloc_frag > Why? > Fixes: 4acb20b46214 ("net: socionext: different approach on DMA") > Signed-off-by: Ilias Apalodimas > --- > drivers/net/ethernet/socionext/netsec.c | 11 +++

Re: [PATCH net 0/3] mlxsw: Few small fixes

2019-04-18 Thread David Miller
From: Ido Schimmel Date: Thu, 18 Apr 2019 18:02:16 + > On Thu, Apr 18, 2019 at 10:38:01AM -0700, David Miller wrote: >> Series applied, thank you. >> >> Would you like me to queue these up for -stable as well? > > Yes, please. Ok, done.

Re: [RFC PATCH net-next] net: sched: flower: refactor reoffload for concurrent access

2019-04-18 Thread Vlad Buslov
On Thu 18 Apr 2019 at 20:46, Jakub Kicinski wrote: > On Thu, 18 Apr 2019 16:33:22 +, Vlad Buslov wrote: >> Considering this, I tried to improve my solution to remove possibility >> of multiple adds of same filter and it seems to me that it would be >> enough to move hw_filters list managemen

Re: [PATCH net-next 06/15] dsa: Remove const from tag driver ops structure

2019-04-18 Thread Florian Fainelli
On 4/17/2019 7:31 PM, Andrew Lunn wrote: > A later patch will create a linked list of tag driver ops structures, > using a list_head in the structure. So the structure cannot be const. Can't we encapsulate the existing dsa_device_ops, while leaving them const into another structure which is not

Re: [PATCH net 0/3] mlxsw: Few small fixes

2019-04-18 Thread Ido Schimmel
On Thu, Apr 18, 2019 at 10:38:01AM -0700, David Miller wrote: > Series applied, thank you. > > Would you like me to queue these up for -stable as well? Yes, please. Thanks, David.

[PATCH] net: socionext: replace napi_alloc_frag with the netdev variant on init

2019-04-18 Thread Ilias Apalodimas
Use netdev_alloc_frag during the Rx ring setup instead napi_alloc_frag Fixes: 4acb20b46214 ("net: socionext: different approach on DMA") Signed-off-by: Ilias Apalodimas --- drivers/net/ethernet/socionext/netsec.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/dri

Re: [net-next 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2019-04-18

2019-04-18 Thread David Miller
From: Jeff Kirsher Date: Thu, 18 Apr 2019 08:59:01 -0700 > This series contains updates to the ice driver only. > > Anirudh fixes up code comments which had typos. Added support for DCB > into the ice driver, which required a bit of refactoring of the existing > code. Also fixed a potential ra

Re: [PATCH 1/1] be2net: Detach interface for avoiding a system crash

2019-04-18 Thread Saeed Mahameed
On Thu, 2019-04-18 at 15:05 +0800, Firo wrote: > > On 4/2/19 12:25 AM, Saeed Mahameed wrote: > > On Mon, 2019-04-01 at 20:24 +0800, Firo Yang wrote: > > > This crash is triggered by a user-after-free since lake of > > > the synchronization of a race condition between > > > be_update_queues() modi

Re: [RFC PATCH net-next] net: sched: flower: refactor reoffload for concurrent access

2019-04-18 Thread Jakub Kicinski
On Thu, 18 Apr 2019 18:13:37 +, Vlad Buslov wrote: > On Thu 18 Apr 2019 at 21:02, Jakub Kicinski > wrote: > > On Thu, 18 Apr 2019 17:58:26 +, Vlad Buslov wrote: > >> On Thu 18 Apr 2019 at 20:46, Jakub Kicinski > >> wrote: > >> > On Thu, 18 Apr 2019 16:33:22 +, Vlad Buslov wrote:

Re: [RFC PATCH net-next] net: sched: flower: refactor reoffload for concurrent access

2019-04-18 Thread Vlad Buslov
On Thu 18 Apr 2019 at 21:02, Jakub Kicinski wrote: > On Thu, 18 Apr 2019 17:58:26 +, Vlad Buslov wrote: >> On Thu 18 Apr 2019 at 20:46, Jakub Kicinski >> wrote: >> > On Thu, 18 Apr 2019 16:33:22 +, Vlad Buslov wrote: >> >> Considering this, I tried to improve my solution to remove po

Re: [RFC PATCH net-next] net: sched: flower: refactor reoffload for concurrent access

2019-04-18 Thread Jakub Kicinski
On Thu, 18 Apr 2019 17:58:26 +, Vlad Buslov wrote: > On Thu 18 Apr 2019 at 20:46, Jakub Kicinski > wrote: > > On Thu, 18 Apr 2019 16:33:22 +, Vlad Buslov wrote: > >> Considering this, I tried to improve my solution to remove possibility > >> of multiple adds of same filter and it seems

Re: [PATCH RFC] xdp: Support zero-copy XDP_TX from AF_XDP sockets.

2019-04-18 Thread Jonathan Lemon
On 18 Apr 2019, at 3:10, Björn Töpel wrote: On Wed, 17 Apr 2019 at 21:58, Jonathan Lemon wrote: When the XDP program attached to a zero-copy AF_XDP socket returns XDP_TX, queue the umem frame on the XDP TX ring, and arrange for it to be released via the ZCA free routine, which should place

Re: [PATCH net-next 04/15] dsa: Add MODULE_LICENSE to tag drivers

2019-04-18 Thread Florian Fainelli
On 4/17/2019 7:31 PM, Andrew Lunn wrote: > All the tag drivers are some variant of GPL. Add a MODULE_LICENSE() > indicating this, so the drivers can later be compiled as modules. > > Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli -- Florian

Re: [RFC PATCH net-next] net: sched: flower: refactor reoffload for concurrent access

2019-04-18 Thread Jakub Kicinski
On Thu, 18 Apr 2019 16:33:22 +, Vlad Buslov wrote: > Considering this, I tried to improve my solution to remove possibility > of multiple adds of same filter and it seems to me that it would be > enough to move hw_filters list management in flower offloads functions: > add filter to list while

Re: [PATCH net 0/3] mlxsw: Few small fixes

2019-04-18 Thread David Miller
From: Ido Schimmel Date: Thu, 18 Apr 2019 07:14:12 + > Patch #1, from Petr, adjusts mlxsw to provide the same QoS behavior for > both Spectrum-1 and Spectrum-2. The fix is required due to a difference > in the behavior of Spectrum-2 compared to Spectrum-1. The problem and > solution are descr

Re: [PATCH net-next 02/15] dsa: Move tagger name into its ops structure

2019-04-18 Thread Florian Fainelli
On 4/17/2019 7:31 PM, Andrew Lunn wrote: > Rather than keep a list to map a tagger ops to a name, place the name > into the ops structure. This removes the hard coded list, a stop > towards making the taggers more dynamic. > > Signed-off-by: Andrew Lunn > --- [snip] > diff --git a/include/ne

[PATCH net-next v3 2/5] vlan: do not transfer link state in vlan bridge binding mode

2019-04-18 Thread Mike Manning
In vlan bridge binding mode, the link state is no longer transferred from the lower device. Instead it is set by the bridge module according to the state of bridge ports that are members of the vlan. Signed-off-by: Mike Manning --- net/8021q/vlan.c | 18 ++ net/8021q/vlan_dev

[PATCH net-next v3 5/5] bridge: update vlan dev link state for bridge netdev changes

2019-04-18 Thread Mike Manning
If vlan bridge binding is enabled, then the link state of a vlan device that is an upper device of the bridge tracks the state of bridge ports that are members of that vlan. But this can only be done when the link state of the bridge is up. If it is down, then the link state of the vlan devices mus

[PATCH net-next v3 0/5] net: support binding vlan dev link state to vlan member bridge ports

2019-04-18 Thread Mike Manning
For vlan filtering on bridges, the bridge may also have vlan devices as upper devices. For switches, these are used to provide L3 packet processing for ports that are members of a given vlan. While it is correct that the admin state for these vlan devices is either set directly for the device or i

[PATCH net-next v3 3/5] bridge: support binding vlan dev link state to vlan member bridge ports

2019-04-18 Thread Mike Manning
In the case of vlan filtering on bridges, the bridge may also have the corresponding vlan devices as upper devices. A vlan bridge binding mode is added to allow the link state of the vlan device to track only the state of the subset of bridge ports that are also members of the vlan, rather than tha

Re: [PATCH net-next 01/15] dsa: Add SPDX header to tag drivers.

2019-04-18 Thread Florian Fainelli
On 4/17/2019 7:31 PM, Andrew Lunn wrote: > Add an SPDX header, and remove the license boilerplate text. > > Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli -- Florian

[PATCH net-next v3 4/5] bridge: update vlan dev state when port added to or deleted from vlan

2019-04-18 Thread Mike Manning
If vlan bridge binding is enabled, then the link state of a vlan device that is an upper device of the bridge should track the state of bridge ports that are members of that vlan. So if a bridge port becomes or stops being a member of a vlan, then update the link state of the vlan device if necessa

[PATCH net-next v3 1/5] vlan: support binding link state to vlan member bridge ports

2019-04-18 Thread Mike Manning
In the case of vlan filtering on bridges, the bridge may also have the corresponding vlan devices as upper devices. Currently the link state of vlan devices is transferred from the lower device. So this is up if the bridge is in admin up state and there is at least one bridge port that is up, regar

Re: [patch net-next 14/15] netdevsim: move netdev creation/destruction to dev probe

2019-04-18 Thread Jakub Kicinski
On Thu, 18 Apr 2019 16:06:13 +0200, Jiri Pirko wrote: > @@ -1279,24 +1312,13 @@ try: > start_test("Test multi-dev ASIC cross-dev destruction...") > bpftool_prog_list_wait(expected=2) > > -simA.remove() > +simdevA.remove() > bpftool_prog_list_wait(expected=1) > > ifna

Re: [patch net-next 03/15] netdevsim: rename devlink.c to dev.c to contain per-dev(asic) items

2019-04-18 Thread Jakub Kicinski
On Thu, 18 Apr 2019 16:06:02 +0200, Jiri Pirko wrote: > From: Jiri Pirko > > The existing devlink.c code is going to be extended to represent asic > device on a bus. As this is about more than just devlink, > rename the file. Do appropriate prefix renaming alongside with that. Again, devlink !=

Re: [patch net-next 01/15] netdevsim: move device registration on bus to be done earlier in init

2019-04-18 Thread Jakub Kicinski
On Thu, 18 Apr 2019 16:06:00 +0200, Jiri Pirko wrote: > From: Jiri Pirko > > As a dependency of the subsequent patch, mode device registration to be > done earlier, directly in nsim_newlink(). > > Signed-off-by: Jiri Pirko Acked-by: Jakub Kicinski

[PATCH v4 net-next 3/6] exthdrs: Registration of TLV handlers and parameters

2019-04-18 Thread Tom Herbert
Create a single TLV parameter table that holds meta information for IPv6 Hop-by-Hop and Destination TLVs. The data structure is composed of a 256 element array of u8's (one entry for each TLV type to allow O(1) lookup). Each entry provides an offset into an array of TLV proc data structures which f

[PATCH v4 net-next 1/6] exthdrs: Create exthdrs_options.c

2019-04-18 Thread Tom Herbert
Create exthdrs_options.c to hold code related to specific Hop-by-Hop and Destination extension header options. Move related functions in exthdrs.c to the new file. --- include/net/ipv6.h | 15 net/ipv6/Makefile | 2 +- net/ipv6/exthdrs.c | 204 -

[PATCH v4 net-next 5/6] ip6tlvs: Add netlink interface

2019-04-18 Thread Tom Herbert
Add a netlink interface to manage the TX TLV parameters. Managed parameters include those for validating and sending TLVs being sent such as alignment, TLV ordering, length limits, etc. --- include/net/ipv6.h | 18 +++ include/uapi/linux/in6.h | 31 + net/ipv6/exthdrs_core.c| 2

[PATCH v4 net-next 2/6] exthdrs: Move generic EH functions to exthdrs_core.c

2019-04-18 Thread Tom Herbert
Move generic functions in exthdrs.c to exthdrs_core.c so that exthdrs.c only contains functions that are specific to IPv6 processing, and exthdrs_core.c contains functions that are generic. --- net/ipv6/exthdrs.c | 138 --- net/ipv6/exthdrs_core.c |

[PATCH v4 net-next 6/6] ip6tlvs: Validation of TX Destination and Hop-by-Hop options

2019-04-18 Thread Tom Herbert
Validate Destination and Hop-by-Hop options. This uses the information in the TLV parameters table to validate various aspects of both individual TLVs as well as a list of TLVs in an extension header. There are two levels of validation that can be performed: simple checks and deep checks. Simple c

[PATCH v4 net-next 4/6] exthdrs: Add TX parameters

2019-04-18 Thread Tom Herbert
Define a number of transmit parameters for TLV Parameter table definitions. These will be used for validating TLVs that are set on a socket. --- include/net/ipv6.h | 26 - include/uapi/linux/in6.h | 8 +++ net/ipv6/exthdrs.c | 2 +- net/ipv6/exthdrs_core

[PATCH v4 net-next 0/6] exthdrs: Make ext. headers & options useful - Part I

2019-04-18 Thread Tom Herbert
Extension headers are the mechanism of extensibility for the IPv6 protocol, however to date they have only seen limited deployment. The reasons for that are because intermediate devices don't handle them well, and there haven't really be any useful extension headers defined. In particular, Destinat

Re: [patch net-next rfc 00/15] netdevsim: impement proper device model

2019-04-18 Thread Jakub Kicinski
On Thu, 18 Apr 2019 09:22:56 +0200, Jiri Pirko wrote: > Tue, Apr 16, 2019 at 08:04:59PM CEST, jakub.kicin...@netronome.com wrote: > >On Tue, 16 Apr 2019 10:59:37 +0200, Jiri Pirko wrote: > >> >> 4) netdevsim instances are created by "ip link add" which is great for > >> >>soft devices with no

Re: [RFC PATCH net-next] net: sched: flower: refactor reoffload for concurrent access

2019-04-18 Thread Vlad Buslov
On Wed 17 Apr 2019 at 19:34, Jakub Kicinski wrote: > On Wed, 17 Apr 2019 07:29:36 +, Vlad Buslov wrote: >> On Wed 17 Apr 2019 at 00:49, Jakub Kicinski >> wrote: >> > On Tue, 16 Apr 2019 17:20:47 +0300, Vlad Buslov wrote: >> >> @@ -1551,6 +1558,10 @@ static int fl_change(struct net *net, st

Re: [PATCH v2] ethtool: Add bash-completion script

2019-04-18 Thread John W. Linville
On Tue, Apr 16, 2019 at 08:53:33PM -0600, Kevin Locke wrote: > On Tue, 2019-04-16 at 14:37 -0400, John W. Linville wrote: > > Overall, it looks good to me. But when I build with "make distcheck", > > I get this output: > > > > [...] > > > > It looks like somewhere you are using "$(bashcompletiond

Re: [PATCH 1/2 net-next] mlx5: Set AF_XDP data pointer correctly.

2019-04-18 Thread Jonathan Lemon
On 18 Apr 2019, at 2:11, Maxim Mikityanskiy wrote: On 2019-04-17 22:56, Jonathan Lemon wrote: data starts at handle + headroom, so adjust appropriately. Signed-off-by: Jonathan Lemon --- drivers/net/ethernet/mellanox/mlx5/core/en/xsk/rx.c | 3 ++- 1 file changed, 2 insertions(+), 1 dele

[net-next 04/15] ice: Add code for DCB initialization part 1/4

2019-04-18 Thread Jeff Kirsher
From: Anirudh Venkataramanan This patch introduces a skeleton for ice_init_pf_dcb, the top level function for DCB initialization. Subsequent patches will add to this DCB init flow. In this patch, ice_init_pf_dcb checks if DCB is a supported capability. If so, an admin queue call to start the LLD

[net-next 01/15] ice: Fix typos in code comments

2019-04-18 Thread Jeff Kirsher
From: Anirudh Venkataramanan This patch fixes typos in code comments. Reviewed-by: Bruce Allan Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/ice.h | 2 +- drivers/net/ethernet/intel/ice/ice_common.c

[net-next 09/15] ice: Update rings based on TC information

2019-04-18 Thread Jeff Kirsher
From: Anirudh Venkataramanan This patch adds a new function ice_vsi_cfg_dcb_rings which updates a VSI's rings based on DCB traffic class information. Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/ice_dcb_lib.c |

[net-next 06/15] ice: Add code for DCB initialization part 3/4

2019-04-18 Thread Jeff Kirsher
From: Anirudh Venkataramanan This patch adds a new function ice_pf_dcb_cfg (and related helpers) which applies the DCB configuration obtained from the firmware. As part of this, VSIs/netdevs are updated with traffic class information. This patch requires a bit of a refactor of existing code. 1.

[net-next 13/15] ice: Add code to control FW LLDP and DCBX

2019-04-18 Thread Jeff Kirsher
From: Anirudh Venkataramanan This patch adds code to start or stop LLDP and DCBX in firmware through use of ethtool private flags. Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/ice.h | 2 + .../net/ethe

[net-next 10/15] ice: Add priority information into VLAN header

2019-04-18 Thread Jeff Kirsher
From: Anirudh Venkataramanan This patch introduces a new function ice_tx_prepare_vlan_flags_dcb to insert 802.1p priority information into the VLAN header Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/ice_dcb_lib

[net-next 03/15] ice: Bump version

2019-04-18 Thread Jeff Kirsher
From: Anirudh Venkataramanan Bump driver version to 0.7.3 Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/ice_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ic

[net-next 11/15] ice: Add code to get DCB related statistics

2019-04-18 Thread Jeff Kirsher
From: Anirudh Venkataramanan This patch adds a new function ice_update_dcb_stats to get DCB stats from the hardware and ethtool support for displaying these stats. Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/ic

[net-next 02/15] ice: Fix incorrect use of abbreviations

2019-04-18 Thread Jeff Kirsher
From: Anirudh Venkataramanan Capitalize abbreviations and spell out some that aren't obvious. Reviewed-by: Bruce Allan Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/ice.h | 10 +- .../net/ethernet/inte

[net-next 12/15] ice: Add code for DCB rebuild

2019-04-18 Thread Jeff Kirsher
From: Anirudh Venkataramanan This patch introduces a new function ice_dcb_rebuild which reinitializes DCB after a reset. Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/ice_dcb_lib.c | 78 driv

[net-next 14/15] ice: Bump driver version

2019-04-18 Thread Jeff Kirsher
From: Anirudh Venkataramanan Update driver version to 0.7.4 Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/ice_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/

[net-next 07/15] ice: Add code for DCB initialization part 4/4

2019-04-18 Thread Jeff Kirsher
From: Anirudh Venkataramanan When the firmware doesn't support LLDP or DCBX, the driver should switch to "software LLDP mode". This patch adds support for the same. Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/i

[net-next 08/15] ice: Add code to process LLDP MIB change events

2019-04-18 Thread Jeff Kirsher
From: Anirudh Venkataramanan This patch adds support to process LLDP MIB change notifications sent by the firmware. Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/ice_dcb.c | 5 ++- drivers/net/ethernet/intel

[net-next 15/15] ice: Calculate ITR increment based on direct calculation

2019-04-18 Thread Jeff Kirsher
From: Brett Creeley Currently when calculating how much to increment ITR by inside of ice_update_itr() we do some estimations and intermediate calculations. Instead of doing estimations, just do the calculation directly. This allows for a more accurate value and it makes it easier for the next pe

[net-next 05/15] ice: Add code for DCB initialization part 2/4

2019-04-18 Thread Jeff Kirsher
From: Anirudh Venkataramanan This patch introduces a new top level function ice_init_dcb (and related lower level helper functions) which continues the DCB init flow. This function uses ice_get_dcb_cfg to get, parse and store the DCB configuration. Once this is done, it sets itself up to be noti

[net-next 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2019-04-18

2019-04-18 Thread Jeff Kirsher
This series contains updates to the ice driver only. Anirudh fixes up code comments which had typos. Added support for DCB into the ice driver, which required a bit of refactoring of the existing code. Also fixed a potential race condition between closing and opening the VSI for a MIB change eve

Re: [PATCH net-next v2 3/5] bridge: support binding vlan dev link state to vlan member bridge ports

2019-04-18 Thread Mike Manning
On 18/04/2019 12:28, Nikolay Aleksandrov wrote: > On 17/04/2019 21:16, Mike Manning wrote: >> In the case of vlan filtering on bridges, the bridge may also have the >> corresponding vlan devices as upper devices. A vlan bridge binding mode >> is added to allow the link state of the vlan device to t

Re: [PATCH net-next 08/15] dsa: Keep link list of tag drivers

2019-04-18 Thread Sergei Shtylyov
On 04/18/2019 04:19 PM, Andrew Lunn wrote: >>> Let the tag drivers register themselves with the DSA core, keeping >>> them in a linked list. >>> >>> Signed-off-by: Andrew Lunn >>> --- >>> include/net/dsa.h | 2 ++ >>> net/dsa/dsa.c | 35 ++- >>> 2 files chang

[patch net-next 00/15] netdevsim: impement proper device model

2019-04-18 Thread Jiri Pirko
From: Jiri Pirko Currently the model of netdevsim is a bit odd in multiple ways. 1) devlink instance is not in any way related with actual netdevsim netdevices. Instead, it is created per-namespace. 2) multi-port netdevsim device is done using "link" attribute. 3) netdevsim bus is there only t

[patch net-next 09/15] netdevsim: rename dev_init/exit() functions and make them independent on ns

2019-04-18 Thread Jiri Pirko
From: Jiri Pirko These functions are going to be called from bus probe/release(), therefore make them independent on ns struct and rename accordingly. Signed-off-by: Jiri Pirko --- drivers/net/netdevsim/dev.c | 31 --- drivers/net/netdevsim/netdev.c| 14 ++

[patch net-next 01/15] netdevsim: move device registration on bus to be done earlier in init

2019-04-18 Thread Jiri Pirko
From: Jiri Pirko As a dependency of the subsequent patch, mode device registration to be done earlier, directly in nsim_newlink(). Signed-off-by: Jiri Pirko --- drivers/net/netdevsim/netdev.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drive

[patch net-next 10/15] netdevsim: merge sdev into dev

2019-04-18 Thread Jiri Pirko
From: Jiri Pirko As previously introduce dev which is mapped 1:1 to a bus device covers the purpose of the original shared device, merge the sdev code into dev. Signed-off-by: Jiri Pirko --- rfc->v1: - rebased --- drivers/net/netdevsim/Makefile | 2 +- drivers/net/netdevsim/bpf.c

[patch net-next 07/15] netdevsim: use ida for bus device ids

2019-04-18 Thread Jiri Pirko
From: Jiri Pirko Instead of increments of u32 value, use ida to manage bus device ids. Signed-off-by: Jiri Pirko --- drivers/net/netdevsim/bus.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/net/netdevsim/bus.c b/drivers/net/netdevsim/bus.c index 5b

[patch net-next 06/15] netdevsim: add stub netdevsim driver implementation

2019-04-18 Thread Jiri Pirko
From: Jiri Pirko In order to bus probing to work correctly, register a simple netdevsim driver implementation. Signed-off-by: Jiri Pirko --- drivers/net/netdevsim/bus.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/drivers/net/netdevsim/bus.c b/driv

[patch net-next 15/15] netdevsim: implement ndo_get_devlink_port

2019-04-18 Thread Jiri Pirko
From: Jiri Pirko Implement ndo_get_devlink_port and allow switch_id and port_name to be handled by devlink. Signed-off-by: Jiri Pirko --- drivers/net/netdevsim/netdev.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/netdevsim/netdev.c b/drivers/net/netdevsim/netdev.c i

[patch net-next 11/15] netdevsim: generate random switch id instead of using dev id

2019-04-18 Thread Jiri Pirko
From: Jiri Pirko Current implementation of parent_id/switch_id does not follow the original idea of being unique. The values are "0", "1", etc. Instead of that, generate 32 random bytes. Signed-off-by: Jiri Pirko --- drivers/net/netdevsim/dev.c | 3 +++ drivers/net/netdevsim/netdev.c

[patch net-next 14/15] netdevsim: move netdev creation/destruction to dev probe

2019-04-18 Thread Jiri Pirko
From: Jiri Pirko Remove the existing way to create netdevsim over rtnetlink and move the netdev creation/destruction to dev probe, so for every probed port, a netdevsim-netdev instance is created. Adjust selftests to work with new interface. Signed-off-by: Jiri Pirko --- rfc->v1: - adjusted al

[patch net-next 13/15] netdevsim: implement dev probe/remove skeleton with port initialization

2019-04-18 Thread Jiri Pirko
From: Jiri Pirko Implement netdevsim bus probing of netdevsim devices. For every probed device create a devlink instance. According to the user-passed value, create a number of ports represented by devlink port instances. Signed-off-by: Jiri Pirko --- drivers/net/netdevsim/bus.c | 29 ++

[patch net-next 04/15] netdevsim: put netdevsim bus code into separate file

2019-04-18 Thread Jiri Pirko
From: Jiri Pirko As the code related to netdevsim bus is going to get bigger, move the existing code to a separate file. Signed-off-by: Jiri Pirko --- rfc->v1: - rebased --- drivers/net/netdevsim/Makefile| 2 +- drivers/net/netdevsim/bus.c | 24 drivers/net/

[patch net-next 08/15] netdevsim: add bus attributes to add new and delete devices

2019-04-18 Thread Jiri Pirko
From: Jiri Pirko Add a way to add new netdevsim device on netdevsim bus and also to delete existing netdevsim device from the bus. Track the bus devices in using a list. Signed-off-by: Jiri Pirko --- drivers/net/netdevsim/bus.c | 97 ++- drivers/net/netdevsim/

[patch net-next 12/15] netdevsim: change debugfs tree topology

2019-04-18 Thread Jiri Pirko
From: Jiri Pirko With the model where dev is represented by devlink and ports are represented by devlink ports, make debugfs file names independent on netdev names. Change the topology to the one illustrated by the following example: $ ls /sys/kernel/debug/netdevsim/ netdevsim1 $ ls /sys/kernel/

[patch net-next 05/15] netdevsim: move device registration and related code to bus.c

2019-04-18 Thread Jiri Pirko
From: Jiri Pirko Move netdevsim device registration into bus.c and alongside with that the related sysfs attributes. Introduce new struct nsim_bus_dev to represent a netdevsim device on netdevsim bus. Signed-off-by: Jiri Pirko --- drivers/net/netdevsim/bus.c | 142 +-

[patch net-next 03/15] netdevsim: rename devlink.c to dev.c to contain per-dev(asic) items

2019-04-18 Thread Jiri Pirko
From: Jiri Pirko The existing devlink.c code is going to be extended to represent asic device on a bus. As this is about more than just devlink, rename the file. Do appropriate prefix renaming alongside with that. Signed-off-by: Jiri Pirko --- rfc->v1: - remove the trailing "\" from the makefil

[patch net-next 02/15] netdevsim: create devlink instance per netdevsim instance

2019-04-18 Thread Jiri Pirko
From: Jiri Pirko Currently there is one devlink instance created per network namespace. That is quite odd considering the fact that devlink instance should represent an ASIC. The following patches are going to move the devlink instance even more down to a bus device, but until then, have one devl

  1   2   >