On Thu, Apr 18, 2019 at 08:25:22AM +0200, Magnus Karlsson wrote:
> On Thu, Apr 18, 2019 at 8:18 AM Alexei Starovoitov
> wrote:
> >
> > On Thu, Apr 18, 2019 at 07:55:30AM +0200, Magnus Karlsson wrote:
> > > On Thu, Apr 18, 2019 at 3:59 AM Stephen Rothwell
> > > wrote:
> > > >
> > > > Hi all,
> >
Print the offload indication in case it is set on the neighbour.
Signed-off-by: Ido Schimmel
---
ip/ipneigh.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/ip/ipneigh.c b/ip/ipneigh.c
index 88596245a2ed..27986ff7a6c9 100644
--- a/ip/ipneigh.c
+++ b/ip/ipneigh.c
@@ -384,6 +384,9 @@ int p
On Thu, Apr 18, 2019 at 12:58 AM Jason Gunthorpe wrote:
>
> On Wed, Apr 17, 2019 at 07:05:37PM +, Ruhl, Michael J wrote:
>
> > >diff --git a/drivers/infiniband/core/uverbs_main.c
> > >b/drivers/infiniband/core/uverbs_main.c
> > >index fef4519d1241..3ef6474cd201 100644
> > >+++ b/drivers/infini
From: Julian Wiedmann
Date: Wed, 17 Apr 2019 18:29:13 +0200
> From: Arnd Bergmann
>
> clang points out that the return code from this function is
> undefined for one of the error paths:
>
> ../drivers/s390/net/ctcm_main.c:1595:7: warning: variable 'result' is used
> uninitialized whenever 'if
On Thu, Apr 18, 2019 at 8:18 AM Alexei Starovoitov
wrote:
>
> On Thu, Apr 18, 2019 at 07:55:30AM +0200, Magnus Karlsson wrote:
> > On Thu, Apr 18, 2019 at 3:59 AM Stephen Rothwell
> > wrote:
> > >
> > > Hi all,
> > >
> > > After merging the bpf-next tree, today's linux-next build (powerpc perf)
From: David Ahern
Date: Tue, 16 Apr 2019 17:31:43 -0700
> From: David Ahern
>
> Disabling IPv6 on an interface removes existing entries but nothing prevents
> new entries from being manually added. To that end, add a new neigh_table
> operation, allow_add, that is called on RTM_NEWNEIGH to see
On Thu, Apr 18, 2019 at 07:55:30AM +0200, Magnus Karlsson wrote:
> On Thu, Apr 18, 2019 at 3:59 AM Stephen Rothwell
> wrote:
> >
> > Hi all,
> >
> > After merging the bpf-next tree, today's linux-next build (powerpc perf)
> > failed like this:
> >
> > In file included from xsk.c:32:
> > libbpf_ut
From: David Ahern
Date: Tue, 16 Apr 2019 14:35:58 -0700
> From: David Ahern
>
> Add fib6_result as a single data structure to hold results from a fib
> lookup. IPv6 currently has everything in 1 data structure - a fib6_info,
> but with nexthop objects the fib6_nh can be in a nexthop or a nextho
On Wed, Apr 17, 2019 at 08:31:57PM -0700, Richard Cochran wrote:
> On Wed, Apr 17, 2019 at 08:59:58PM +0200, Jiri Benc wrote:
> > The problem here is this patch gives access to physical interface
> > settings through a virtual interface layered on top of it. Whenever
> > such thing is done, the vir
On Wed, Apr 17, 2019 at 07:05:37PM +, Ruhl, Michael J wrote:
> >diff --git a/drivers/infiniband/core/uverbs_main.c
> >b/drivers/infiniband/core/uverbs_main.c
> >index fef4519d1241..3ef6474cd201 100644
> >+++ b/drivers/infiniband/core/uverbs_main.c
> >@@ -889,6 +889,10 @@ static struct rdma_uma
On Thu, Apr 18, 2019 at 3:59 AM Stephen Rothwell wrote:
>
> Hi all,
>
> After merging the bpf-next tree, today's linux-next build (powerpc perf)
> failed like this:
>
> In file included from xsk.c:32:
> libbpf_util.h:49:3: error: #warning Architecture missing native barrier
> functions in libbpf_
On Wed, Apr 17, 2019 at 10:23 PM Yonghong Song wrote:
>
> I hit the following compilation error with gcc 4.8.5.
>
> prog_tests/flow_dissector.c: In function ‘test_flow_dissector’:
> prog_tests/flow_dissector.c:155:2: error: ‘for’ loop initial declarations
> are only allowed in C99 mode
>
Add documentation for BPF_PROG_TYPE_CGROUP_SYSCTL, including general
info, attach type, context, return code, helpers, example and usage
considerations.
A separate file prog_cgroup_sysctl.rst is added to Documentation/bpf/.
In the future more program types can be documented in their own
prog_.rst
I hit the following compilation error with gcc 4.8.5.
prog_tests/flow_dissector.c: In function ‘test_flow_dissector’:
prog_tests/flow_dissector.c:155:2: error: ‘for’ loop initial declarations are
only allowed in C99 mode
for (int i = 0; i < ARRAY_SIZE(tests); i++) {
^
prog_tests/flo
On 4/17/19 6:27 PM, Alexei Starovoitov wrote:
> Document the verifier limits.
>
> Signed-off-by: Alexei Starovoitov
Acked-by: Yonghong Song
> ---
> Documentation/bpf/bpf_design_QA.rst | 29 +++--
> 1 file changed, 27 insertions(+), 2 deletions(-)
>
> diff --git a/
On Wed, Apr 17, 2019 at 08:59:58PM +0200, Jiri Benc wrote:
> The problem here is this patch gives access to physical interface
> settings through a virtual interface layered on top of it. Whenever
> such thing is done, the virtual interface needs to provide a suitable
> way of moderating access to
A DSA tag driver module will need to register the tag protocols it
implements with the DSA core. Add a macro containing this boiler plate.
The registration/unregistration code is currently just a stub. A Later
patch will add the real implementation.
Signed-off-by: Andrew Lunn
---
include/net/ds
Implement the _get and _put functions to make use of the list of tag
drivers. Also, trigger the loading of the module, based on the alias
information. The _get function takes a reference on the tag driver, so
it cannot be unloaded, and the _put function releases the reference.
Signed-off-by: Andre
When a DSA switch driver is unloaded, the lock on the tag driver
should be released so the module can be unloaded. Add the needed calls,
but leave the actual relase code as a stub.
Signed-off-by: Andrew Lunn
---
net/dsa/dsa.c | 4
net/dsa/dsa2.c | 2 ++
net/dsa/dsa_priv.h | 1 +
ne
When the tag drivers become modules, we will need to dynamically load
them based on what the switch drivers need. Add aliases to map between
the TAG protocol and the driver.
In order to do this, we need the tag protocol number as something
which the C pre-processor can stringinfy. Only the compile
It is possible that the driver is compiled with both
CONFIG_NET_DSA_TAG_BRCM and CONFIG_NET_DSA_TAG_BRCM_PREPEND disabled.
This results in warnings about unused symbols. Add some conditional
compilation to avoid this.
Signed-off-by: Andrew Lunn
---
net/dsa/tag_brcm.c | 4
1 file changed, 4
Add an SPDX header, and remove the license boilerplate text.
Signed-off-by: Andrew Lunn
---
net/dsa/tag_brcm.c| 6 +-
net/dsa/tag_dsa.c | 6 +-
net/dsa/tag_edsa.c| 6 +-
net/dsa/tag_ksz.c | 6 +-
net/dsa/tag_lan9303.c | 11 +--
net/dsa/tag_mtk.c |
Now that tag drivers dynamically register, we don't need the static
table. Remove it. This also means the tag driver structures can be
made static.
Signed-off-by: Andrew Lunn
---
include/net/dsa.h | 1 -
net/dsa/dsa.c | 35 ---
net/dsa/dsa_priv.h|
Rather than keep a list to map a tagger ops to a name, place the name
into the ops structure. This removes the hard coded list, a stop
towards making the taggers more dynamic.
Signed-off-by: Andrew Lunn
---
include/net/dsa.h | 1 +
net/dsa/dsa.c | 45 ++--
The none tagger is special in that it does not live in a tag_*.c file,
but is within the core. Register/unregister when DSA is
loaded/unloaded.
Signed-off-by: Andrew Lunn
---
net/dsa/dsa.c | 4
1 file changed, 4 insertions(+)
diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c
index 861fe1441a7d..a
In order that we can match the tagging protocol a switch driver
request to the tagger, we need to know what protocol the tagger
supports. Add this information to the ops structure.
Signed-off-by: Andrew Lunn
---
include/net/dsa.h | 1 +
net/dsa/dsa.c | 1 +
net/dsa/tag_brcm.c| 2
Make the CONFIG symbols tristate and add help text.
The broadcom and Microchip KSZ tag drivers support two different
tagging protocols in one driver. Add a configuration option for the
drivers, and then options to select the protocol.
Create a submenu for the tagging drivers.
Signed-off-by: Andr
Let the tag drivers register themselves with the DSA core, keeping
them in a linked list.
Signed-off-by: Andrew Lunn
---
include/net/dsa.h | 2 ++
net/dsa/dsa.c | 35 ++-
2 files changed, 36 insertions(+), 1 deletion(-)
diff --git a/include/net/dsa.h b/inclu
All the tag drivers are some variant of GPL. Add a MODULE_LICENSE()
indicating this, so the drivers can later be compiled as modules.
Signed-off-by: Andrew Lunn
---
net/dsa/tag_brcm.c| 1 +
net/dsa/tag_dsa.c | 1 +
net/dsa/tag_edsa.c| 1 +
net/dsa/tag_gswip.c | 1 +
net/dsa/tag_ksz
Historically, DSA tag drivers have been compiled into the kernel as
part of the DSA core. With the growing number of tag drivers, it makes
sense to allow this driver code to be compiled as a module, and loaded
on demand.
Andrew Lunn (15):
dsa: Add SPDX header to tag drivers.
dsa: Move tagger n
dsa_resolve_tag_protocol() is used to find the tagging driver needed
by a switch driver. When the tagging drivers become modules, it will
be necassary to take a reference on the module to prevent it being
unloaded. So rename this function to _get() to indicate it has some
locking properties.
Signe
A later patch will create a linked list of tag driver ops structures,
using a list_head in the structure. So the structure cannot be const.
Signed-off-by: Andrew Lunn
---
net/dsa/dsa.c | 2 +-
net/dsa/dsa_priv.h| 22 +++---
net/dsa/tag_brcm.c| 4 ++--
net/dsa/ta
On Fri, Apr 12, 2019 at 8:07 AM Jesper Dangaard Brouer
wrote:
>
> This patchset utilize a number of different kernel bulk APIs for optimizing
> the performance for the XDP cpumap redirect feature.
>
> Benchmark details are available here:
>
> https://github.com/xdp-project/xdp-project/blob/maste
Document the verifier limits.
Signed-off-by: Alexei Starovoitov
---
Documentation/bpf/bpf_design_QA.rst | 29 +++--
1 file changed, 27 insertions(+), 2 deletions(-)
diff --git a/Documentation/bpf/bpf_design_QA.rst
b/Documentation/bpf/bpf_design_QA.rst
index 10453c627135
phylink will call the mac_config() callback once per second when
polling a PHY or a fixed link. The MAC driver is not supposed to
reconfigure the MAC if nothing has changed.
Make the mv88e6xxx driver look at the current configuration of the
port, and return early if nothing has changed.
Signed-of
A recent addition to NFP introduced a function that formats a string with
a size_t variable. This is formatted with %ld which is fine on 64-bit
architectures but produces a compile warning on 32-bit architectures.
Fix this by using the z length modifier.
Fixes: a6156a6ab0f9 ("nfp: flower: handle
On Fri, 12 Apr 2019 18:30:55 +0300
Nikolay Aleksandrov wrote:
> Since the commit below mdb's json output has been invalid and also with
> changed format. Restore it to a valid json like the previous format.
> Also takes care of a double "Deleted" print when monitoring for changes.
>
> Example br
On Tue, 16 Apr 2019 18:30:12 +0300
Nikolay Aleksandrov wrote:
> Each of the commits below broke the vlan stats output in a different
> way:
> - 45fca4ed9412 ("bridge: fix vlan show stats formatting")
> Added a second print of an interface name (e.g. eth4eth4)
> - c7c1a1ef51ae ("bridge: colorize
On Tue, 16 Apr 2019 16:04:39 +0200
Beniamino Galvani wrote:
> Add a missing space after the 'external' keyword in the detailed mode
> of tunnel links output:
>
> # ip -d link
> 79: geneve1: mtu 65465 qdisc noop state DOWN mode
> DEFAULT group default qlen 1000
> link/ether da:e9:e4:2b:f
Hi,
Jakub Kicinski writes:
> Recent changes to taprio did not use the correct div64 helpers,
> leading to:
>
> net/sched/sch_taprio.o: In function `taprio_dequeue':
> sch_taprio.c:(.text+0x34a): undefined reference to `__divdi3'
> net/sched/sch_taprio.o: In function `advance_sched':
> sch_taprio
On Wed, Apr 17, 2019 at 11:59:22PM +0200, David Bauer wrote:
> This renames the GPIO reset of mdio devices from 'reset' to
> 'reset_gpio' to better differentiate between GPIO and
> reset-controller driven reset line.
>
> Signed-off-by: David Bauer
Reviewed-by: Andrew Lunn
Andrew
On Wed, Apr 17, 2019 at 11:59:21PM +0200, David Bauer wrote:
> This commit adds support for PHY reset pins handled by a reset controller.
>
> Signed-off-by: David Bauer
Reviewed-by: Andrew Lunn
Andrew
On Wed, Apr 17, 2019 at 11:59:20PM +0200, David Bauer wrote:
> Add the documentation for PHY reset lines controlled by a reset controller.
>
> Signed-off-by: David Bauer
Reviewed-by: Andrew Lunn
Andrew
On Wed, 17 Apr 2019 12:52:55 -0700, Jonathan Lemon wrote:
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/rx.c
> b/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/rx.c
> index 61d75a7b3ce2..2f0b5fd1ee97 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/rx.c
> +++ b/drivers
This commit adds support for PHY reset pins handled by a reset controller.
Signed-off-by: David Bauer
---
drivers/net/phy/mdio_bus.c| 27 +--
drivers/net/phy/mdio_device.c | 13 +++--
include/linux/mdio.h | 1 +
3 files changed, 37 insertions(+), 4 d
This renames the GPIO reset of mdio devices from 'reset' to
'reset_gpio' to better differentiate between GPIO and
reset-controller driven reset line.
Signed-off-by: David Bauer
---
drivers/net/phy/at803x.c | 2 +-
drivers/net/phy/mdio_bus.c| 6 +++---
drivers/net/phy/mdio_device.c | 6 +
This patchset adds support for a PHY reset driven by a reset-controller.
Currently, only GPIO driven resets are supported by the PHY subsystem.
It also renames the reset-gpio from 'reset' to 'reset_gpio' to
better differentiate between resets wired to a GPIO and resets wired to
a reset-controller d
Add the documentation for PHY reset lines controlled by a reset controller.
Signed-off-by: David Bauer
---
Documentation/devicetree/bindings/net/phy.txt | 6 ++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/phy.txt
b/Documentation/devicetree/bindings/ne
On 4/9/19 1:14 PM, Kristian Evensen wrote:
> diff --git a/include/uapi/linux/fou.h b/include/uapi/linux/fou.h
> index bf022c63..9f915118 100644
> --- a/include/uapi/linux/fou.h
> +++ b/include/uapi/linux/fou.h
> @@ -16,6 +16,12 @@ enum {
> FOU_ATTR_IPPROTO, /* u8 */
>
Hi,
We have a test bed DUT with OpenWRT While Capturing CPU usage, we
observed below points.
1. 5 mobile clients are connected to the DUT and streaming HD video
consumes CPU usage 0 to 5%
2. 5 mobile clients are connected to DUT and streaming HD video and
downloading a 350MB file for every 3minu
From: David Miller
Date: Mon, 15 Apr 2019 13:24:17 -0700 (PDT)
> From: Felix Fietkau
> Date: Fri, 12 Apr 2019 21:41:36 +0200
>
>> I have a whole bunch of pending mt76 changes for -next which depend on
>> these two commits:
>>
>> commit 2b4a66980217332d91ab1785e1750857d6d52bc8
>> mac80211: make
From: ZhangXiaoxu
Date: Tue, 16 Apr 2019 09:47:24 +0800
> There is a UBSAN report as below:
> UBSAN: Undefined behaviour in net/ipv4/tcp_input.c:2877:56
> signed integer overflow:
...
> It can be reproduced by:
> echo 2147483647 > /proc/sys/net/ipv4/tcp_min_rtt_wlen
>
> Fixes: f672258391b42 (
On Wed, Apr 17, 2019 at 11:51:27AM -0600, Captain Wiggum wrote:
Hi All,
We have built 4.19 with Peter's patch, and now all TAHI IPv6 tests
pass, even another issue I reported is fixed!
This patch looks great from our testing. Please accept this patch...
So that Peter can move on to 4.14.
Thank y
The driver does not advertize NETIF_F_FRAGLIST, the stack can't
pass skbs with frags lists to the xmit function.
Signed-off-by: Jakub Kicinski
Reviewed-by: Dirk van der Merwe
---
drivers/net/ethernet/cortina/gemini.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/cort
Hi!
A few unrelated improvements here, mostly trying to make random
configs build and W=1 produce a little less warnings under net/
and drivers net/.
First two patches fix set but not used warnings with W=1.
Next patch fixes 64bit division in sch_taprio.c.
Last two patches are getting rid of so
GCC complains:
net/l2tp/l2tp_ppp.c: In function ‘pppol2tp_ioctl’:
net/l2tp/l2tp_ppp.c:1073:6: warning: variable ‘val’ set but not used
[-Wunused-but-set-variable]
int val;
^~~
Signed-off-by: Jakub Kicinski
Reviewed-by: Dirk van der Merwe
---
CC: James Chapman
net/l2tp/l2tp_ppp.c | 3
GCC 8 complains:
drivers/net/sb1000.c: In function ‘card_send_command’:
drivers/net/sb1000.c:319:14: warning: variable ‘x’ set but not used
[-Wunused-but-set-variable]
int status, x;
^
drivers/net/sb1000.c: In function ‘sb1000_check_CRC’:
drivers/net/sb1000.c:493:6: warning: varia
Recent changes to taprio did not use the correct div64 helpers,
leading to:
net/sched/sch_taprio.o: In function `taprio_dequeue':
sch_taprio.c:(.text+0x34a): undefined reference to `__divdi3'
net/sched/sch_taprio.o: In function `advance_sched':
sch_taprio.c:(.text+0xa0b): undefined reference to `_
We are discouraging the use of BUG() these days, remove the
unused ASSERT macros from skbuff.h.
Signed-off-by: Jakub Kicinski
Reviewed-by: Dirk van der Merwe
---
include/linux/skbuff.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index a06
To make ICMPv6 closer to ICMPv4, add ratemask parameter. Since the ICMP
message types use larger numeric values, a simple bitmask doesn't fit.
I use large bitmap. The input and output are the in form of list of
ranges. Set the default to rate limit all error messages but Packet Too
Big. For Packet
On Tue, Apr 16, 2019 at 7:48 AM Jesper Dangaard Brouer
wrote:
>
> On Mon, 15 Apr 2019 10:58:07 -0700
> "Jonathan Lemon" wrote:
>
> > On 15 Apr 2019, at 9:32, Jesper Dangaard Brouer wrote:
> >
> > > On Mon, 15 Apr 2019 13:59:03 +0200 Björn Töpel
> > > wrote:
> > >
> > >> Hi,
> > >>
> > >> As you
I've discovered following discrepancy in the bindings/net/ethernet.txt
documentation, where it states following:
- nvmem-cells: phandle, reference to an nvmem node for the MAC address;
- nvmem-cell-names: string, should be "mac-address" if nvmem is to be..
which is actually misleading and confu
When the XDP program attached to a zero-copy AF_XDP socket returns XDP_TX,
queue the umem frame on the XDP TX ring, and arrange for it to be released
via the ZCA free routine, which should place it back onto the reuseq.
Signed-off-by: Jonathan Lemon
---
drivers/net/ethernet/intel/i40e/i40e_txrx.
data starts at handle + headroom, so adjust appropriately.
Signed-off-by: Jonathan Lemon
---
drivers/net/ethernet/mellanox/mlx5/core/en/xsk/rx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/rx.c
b/drivers/net/ethernet/mella
bpf_prog_run_xdp() may change the start/length values in xdp.
Adjust the umem handle so it reflects the possibly updated values.
Signed-off-by: Jonathan Lemon
---
drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethe
xkq_peek_addr() returns chunk-aligned handles, so have the rq behave
the same way. Clean up callsites.
Signed-off-by: Jonathan Lemon
Cc: Björn Töpel
Cc: Maxim Mikityanskiy
Cc: netdev@vger.kernel.org
---
drivers/net/ethernet/intel/i40e/i40e_xsk.c | 2 --
drivers/net/ethernet/intel/ixg
>-Original Message-
>From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma-
>ow...@vger.kernel.org] On Behalf Of Leon Romanovsky
>Sent: Tuesday, April 16, 2019 4:07 AM
>To: Doug Ledford ; Jason Gunthorpe
>
>Cc: Leon Romanovsky ; RDMA mailing list r...@vger.kernel.org>; Andrea Arcangeli
On Wed, 17 Apr 2019 08:43:06 -0700, Richard Cochran wrote:
> If NET_ADMIN is enabled in the container, don't the host and container
> contend with each other for the physical interfaces anyhow?
Physical interfaces are not a problem, as each interface can be only in
a single net name space.
The pr
On 17.04.2019 15:34, kavyasree.kotag...@microchip.com wrote:
> From: Kavya Sree Kotagiri
>
> The VSC8514 PHY is a 4-ports PHY that is 10/100/1000BASE-T, 100BASE-FX,
> 1000BASE-X, can communicate with the MAC via QSGMII.
> The MAC interface protocol for each port within QSGMII can
> be either 1000
In vlan bridge binding mode, the link state is no longer transferred
from the lower device. Instead it is set by the bridge module according
to the state of bridge ports that are members of the vlan.
Signed-off-by: Mike Manning
---
net/8021q/vlan.c | 18 ++
net/8021q/vlan_dev
If vlan bridge binding is enabled, then the link state of a vlan device
that is an upper device of the bridge tracks the state of bridge ports
that are members of that vlan. But this can only be done when the link
state of the bridge is up. If it is down, then the link state of the
vlan devices mus
On Wed, Apr 17, 2019 at 12:19 PM Arnd Bergmann wrote:
>
> On Wed, Apr 17, 2019 at 4:46 PM Willem de Bruijn
> wrote:
> > On Tue, Apr 16, 2019 at 4:38 PM Arnd Bergmann wrote:
> > > The SIOCGSTAMP/SIOCGSTAMPNS ioctl commands are implemented by many
> > > socket protocol handlers, and all of those e
On 03/04/2019 19:23, Nikolay Aleksandrov wrote:
> On 03/04/2019 21:17, Nikolay Aleksandrov wrote:
>> On 03/04/2019 20:53, Nikolay Aleksandrov wrote:
>>> On 03/04/2019 20:43, Mike Manning wrote:
On 02/04/2019 20:22, Nikolay Aleksandrov wrote:
> On 02/04/2019 18:35, Mike Manning wrote:
>
In the case of vlan filtering on bridges, the bridge may also have the
corresponding vlan devices as upper devices. A vlan bridge binding mode
is added to allow the link state of the vlan device to track only the
state of the subset of bridge ports that are also members of the vlan,
rather than tha
In the case of vlan filtering on bridges, the bridge may also have the
corresponding vlan devices as upper devices. Currently the link state
of vlan devices is transferred from the lower device. So this is up if
the bridge is in admin up state and there is at least one bridge port
that is up, regar
If vlan bridge binding is enabled, then the link state of a vlan device
that is an upper device of the bridge should track the state of bridge
ports that are members of that vlan. So if a bridge port becomes or
stops being a member of a vlan, then update the link state of the
vlan device if necessa
For vlan filtering on bridges, the bridge may also have vlan devices
as upper devices. For switches, these are used to provide L3 packet
processing for ports that are members of a given vlan.
While it is correct that the admin state for these vlan devices is
either set directly for the device or i
On Wed, Apr 17, 2019 at 10:46:47AM -0700, David Miller wrote:
> From: Stephen Suryaputra
> Date: Mon, 15 Apr 2019 20:31:57 -0400
>
> > @@ -850,6 +850,14 @@ static int __net_init inet6_net_init(struct net *net)
> > net->ipv6.sysctl.icmpv6_echo_ignore_all = 0;
> > net->ipv6.sysctl.icmpv6_ec
On Wed, Apr 17, 2019 at 06:06:00PM +0200, Petr Štetiar wrote:
> Maxime Ripard [2019-04-17 10:06:14]:
>
> > NVMEM is supported by of_net already
>
> Well, not anymore:
>
> commit afa64a72b862a7a9d04f8d07fba632eaf06b23f8
> Author: Bartosz Golaszewski
> Date: Fri Nov 30 09:20:59 2018 +0100
>
>
Hi All,
We have built 4.19 with Peter's patch, and now all TAHI IPv6 tests
pass, even another issue I reported is fixed!
This patch looks great from our testing. Please accept this patch...
So that Peter can move on to 4.14.
Thank you Peter and Google crew for this patch!
I look forward to the fix
Unlike atomic_add(), refcount_add() does not deal well
with a negative argument. TLS fallback code reallocates
the skb and is very likely to shrink the truesize, leading to:
[ 189.513254] WARNING: CPU: 5 PID: 0 at lib/refcount.c:81
refcount_add_not_zero_checked+0x15c/0x180
Call Trace:
refcou
From: Stephen Suryaputra
Date: Mon, 15 Apr 2019 20:31:57 -0400
> @@ -850,6 +850,14 @@ static int __net_init inet6_net_init(struct net *net)
> net->ipv6.sysctl.icmpv6_echo_ignore_all = 0;
> net->ipv6.sysctl.icmpv6_echo_ignore_multicast = 0;
> net->ipv6.sysctl.icmpv6_echo_ignore_a
From: Julian Wiedmann
Date: Wed, 17 Apr 2019 18:17:27 +0200
> please apply some additional qeth patches to net-next. This patchset converts
> the driver to use the kernel's multiqueue model.
Series applied, thanks.
From: Jeff Kirsher
Date: Tue, 16 Apr 2019 15:57:21 -0700
> This series contains updates to i40e driver only.
Pulled, thanks Jeff.
On Wed 17 Apr 2019 at 19:34, Jakub Kicinski
wrote:
> On Wed, 17 Apr 2019 07:29:36 +, Vlad Buslov wrote:
>> On Wed 17 Apr 2019 at 00:49, Jakub Kicinski
>> wrote:
>> > On Tue, 16 Apr 2019 17:20:47 +0300, Vlad Buslov wrote:
>> >> @@ -1551,6 +1558,10 @@ static int fl_change(struct net *net, st
On Mon, 15 Apr 2019 at 18:33, Jesper Dangaard Brouer wrote:
>
[...]
> >
> > Ok, please convince me! :-D
>
> I tried to above...
>
I think you (and Jakub) did. :-) Looks like a "queue" is a good
(necessary) abstraction, but I need to think more about how to e.g.
access "dedicated/isolated" AF_XDP
On Wed, 17 Apr 2019 07:29:36 +, Vlad Buslov wrote:
> On Wed 17 Apr 2019 at 00:49, Jakub Kicinski
> wrote:
> > On Tue, 16 Apr 2019 17:20:47 +0300, Vlad Buslov wrote:
> >> @@ -1551,6 +1558,10 @@ static int fl_change(struct net *net, struct
> >> sk_buff *in_skb,
> >>goto errout_ma
From: Arnd Bergmann
clang points out that the return code from this function is
undefined for one of the error paths:
../drivers/s390/net/ctcm_main.c:1595:7: warning: variable 'result' is used
uninitialized whenever 'if' condition is true
[-Wsometimes-uninitialized]
if (pr
This adds trivial support for multiple TX queues on OSA-style devices
(both real HW and z/VM NICs). For now we expose the driver's existing
QoS mechanism via .ndo_select_queue, and adjust the number of available
TX queues when qeth_update_from_chp_desc() detects that the
HW configuration has change
qeth has been supporting multiple HW Output Queues for a long time. But
rather than exposing those queues to the stack, it uses its own queue
selection logic in .ndo_start_xmit... with all the drawbacks that
entails.
Start off by switching IQD devices over to a proper mqs net_device,
and converting
As the documentation for netif_trans_update() says, netdev_start_xmit()
already updates the last-tx time after every good xmit. So don't
duplicate that effort.
One odd case is that qeth_flush_buffers() also gets called from our
TX completion handler, to flush out any partially filled buffer when
w
qeth_get_priority_queue() is no longer used for IQD devices, remove the
special-casing of their mcast queue.
This effectively reverts
commit 70deb01662b1 ("qeth: omit outbound queue 3 for unicast packets in
Priority Queuing on HiperSockets").
Signed-off-by: Julian Wiedmann
---
drivers/s390/net
Current xmit code only stops the txq after attempting to fill an
IO buffer that hasn't been TX-completed yet. In many-connection
scenarios, this can result in frequent rejected TX attempts, requeuing
of skbs with NETDEV_TX_BUSY and extra overhead.
Now that we have a proper 1-to-1 relation between
The naming of several QDIO helpers doesn't match their actual
functionality, or the structures they operate on. Clean this up.
s/qeth_alloc_qdio_buffers/qeth_alloc_qdio_queues
s/qeth_free_qdio_buffers/qeth_free_qdio_queues
s/qeth_alloc_qdio_out_buf/qeth_alloc_output_queue
s/qeth_clear_outq_buffers
struct netdev_queue contains a counter for tx timeouts, which gets
updated by dev_watchdog(). So let's not attempt to maintain our own
statistics, in particular not by overloading the skb-error counter.
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_core.h | 1 -
drivers/s390/net/
Subsequent code relies on the values that qeth_update_from_chp_desc()
reads from the CHP descriptor. Rather than dealing with weird errors
later on, just handle it properly here.
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_core_main.c | 14 ++
1 file changed, 10 insertio
Hi Dave,
please apply some additional qeth patches to net-next. This patchset converts
the driver to use the kernel's multiqueue model.
Thanks,
Julian
Julian Wiedmann (8):
s390/qeth: clarify naming for some QDIO helpers
s390/qeth: handle error from qeth_update_from_chp_desc()
s390/qeth: d
Maxime Ripard [2019-04-17 10:06:14]:
> NVMEM is supported by of_net already
Well, not anymore:
commit afa64a72b862a7a9d04f8d07fba632eaf06b23f8
Author: Bartosz Golaszewski
Date: Fri Nov 30 09:20:59 2018 +0100
of: net: kill of_get_nvmem_mac_address()
Now, I'm really confused.
Documen
Hi,
Jose Abreu writes:
> From: Vinicius Costa Gomes
> Date: Tue, Mar 26, 2019 at 21:02:43
>
>> The series that I planning to send this week has some ideas about how to
>> solve all these three points. But for hardware offloading and frame
>> preemption, all I will propose is the interface for t
On Wed, Apr 17, 2019 at 04:05:09PM +0800, Hangbin Liu wrote:
> On the other hand, Miroslav pointed that with NET_ADMIN enabled in container,
> a normal user could be mapped to root and is able to change the real devices's
> rx filter via ioctl on macvlan, which may affect the other ptp process on
>
1 - 100 of 127 matches
Mail list logo