GCC complains:

net/l2tp/l2tp_ppp.c: In function ‘pppol2tp_ioctl’:
net/l2tp/l2tp_ppp.c:1073:6: warning: variable ‘val’ set but not used 
[-Wunused-but-set-variable]
  int val;
      ^~~

Signed-off-by: Jakub Kicinski <jakub.kicin...@netronome.com>
Reviewed-by: Dirk van der Merwe <dirk.vanderme...@netronome.com>
---
CC: James Chapman <jchap...@katalix.com>

 net/l2tp/l2tp_ppp.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/net/l2tp/l2tp_ppp.c b/net/l2tp/l2tp_ppp.c
index 04d9946dcdba..f36cae785e82 100644
--- a/net/l2tp/l2tp_ppp.c
+++ b/net/l2tp/l2tp_ppp.c
@@ -1070,7 +1070,6 @@ static int pppol2tp_ioctl(struct socket *sock, unsigned 
int cmd,
 {
        struct pppol2tp_ioc_stats stats;
        struct l2tp_session *session;
-       int val;
 
        switch (cmd) {
        case PPPIOCGMRU:
@@ -1097,7 +1096,7 @@ static int pppol2tp_ioctl(struct socket *sock, unsigned 
int cmd,
                if (!session->session_id && !session->peer_session_id)
                        return -ENOSYS;
 
-               if (get_user(val, (int __user *)arg))
+               if (!access_ok((int __user *)arg, sizeof(int)))
                        return -EFAULT;
                break;
 
-- 
2.21.0

Reply via email to