Re: [PATCH net-next 1/2] netfilter: Export nf_ct_destroy_timeout()

Hi Yi-Hung, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Yi-Hung-Wei/netfilter-Export-nf_ct_destroy_timeout/20190323-094843 reproduce: # apt-get install sparse make ARCH=x86_6

Re: [PATCH net-next 2/2] openvswitch: Add timeout support to ct action

Hi Yi-Hung, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Yi-Hung-Wei/netfilter-Export-nf_ct_destroy_timeout/20190323-094843 config: i386-randconfig-x004-201911 (attached as .config) compiler: gcc-7

Re: [PATCH bpf-next 2/2] selftests: bpf: tc-bpf flow shaping with EDT

On Fri, Mar 22, 2019 at 04:40:19PM -0700, Peter Oskolkov wrote: > Add a small test that shows how to shape a TCP flow in tc-bpf > with EDT and ECN. > > Signed-off-by: Peter Oskolkov ... > +ip netns exec ${NS_SRC} bash -c "timeout ${TIMEOUT} dd if=/dev/zero \ > + bs=1000 count=100 > /dev/t

Re: [RFC bpf-next v3 6/8] flow_dissector: handle no-skb use case

On Fri, Mar 22, 2019 at 06:19:57PM -0700, Stanislav Fomichev wrote: > Are we ok with breaking api in this case? I'm all in on removing this > extra information. We can always put it back if somebody complains (and > manually parse in eth_get_headlen case). Fine. That seems to be the only way forwa

Re: [RFC bpf-next v3 6/8] flow_dissector: handle no-skb use case

On 03/22, Alexei Starovoitov wrote: > On Fri, Mar 22, 2019 at 12:59:01PM -0700, Stanislav Fomichev wrote: > > When called without skb, gather all required data from the > > __skb_flow_dissect's arguments and use recently introduces > > no-skb mode of bpf flow dissector. > > > > Note: WARN_ON_ONCE(

Re: [RFC bpf-next v3 6/8] flow_dissector: handle no-skb use case

On Fri, Mar 22, 2019 at 12:59:01PM -0700, Stanislav Fomichev wrote: > When called without skb, gather all required data from the > __skb_flow_dissect's arguments and use recently introduces > no-skb mode of bpf flow dissector. > > Note: WARN_ON_ONCE(!net) will now trigger for eth_get_headlen users

Re: [PATCH bpf v2 0/2] libbpf fix up and clarify version info

On 03/23, Daniel Borkmann wrote: > First one is fixing version in Makefile and shared object and > second one clarifies bump in version. Thanks! > > v1 -> v2: > - Fix up soname, thanks Stanislav! LGTM, thank you for a quick fix! For the whole series: Reviewed-by: Stanislav Fomichev > > Danie

[PATCH bpf v2 1/2] bpf, libbpf: fix version info and add it to shared object

Even though libbpf's versioning script for the linker (libbpf.map) is pointing to 0.0.2, the BPF_EXTRAVERSION in the Makefile has not been updated along with it and is therefore still on 0.0.1. While fixing up, I also noticed that the generated shared object versioning information is missing, typi

[PATCH bpf v2 2/2] bpf, libbpf: clarify bump in libbpf version info

The current documentation suggests that we would need to bump the libbpf version on every change. Lets clarify this a bit more and reflect what we do today in practice, that is, bumping it once per development cycle. Fixes: 76d1b894c515 ("libbpf: Document API and ABI conventions") Reported-by: Sta

[PATCH bpf v2 0/2] libbpf fix up and clarify version info

First one is fixing version in Makefile and shared object and second one clarifies bump in version. Thanks! v1 -> v2: - Fix up soname, thanks Stanislav! Daniel Borkmann (2): bpf, libbpf: fix version info and add it to shared object bpf, libbpf: clarify bump in libbpf version info tools/li

RE: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

> -Original Message- > From: Jiri Pirko > Sent: Friday, March 22, 2019 8:33 AM > To: Parav Pandit > Cc: Jakub Kicinski ; Samudrala, Sridhar > ; da...@davemloft.net; > netdev@vger.kernel.org; oss-driv...@netronome.com > Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on dev

Re: [PATCH bpf 1/2] bpf, libbpf: fix version info and add it to shared object

On 03/23/2019 01:28 AM, Stanislav Fomichev wrote: > On 03/23, Daniel Borkmann wrote: >> On 03/23/2019 01:09 AM, Stanislav Fomichev wrote: >>> On 03/23, Daniel Borkmann wrote: >> [...] +$(OUTPUT)libbpf.so.$(LIBBPF_VERSION): $(BPF_IN) + $(QUIET_LINK)$(CC) --shared -Wl,-soname,libbpf.so.$(L

RE: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

> -Original Message- > From: Jiri Pirko > Sent: Friday, March 22, 2019 11:28 AM > To: Parav Pandit > Cc: Jakub Kicinski ; Samudrala, Sridhar > ; da...@davemloft.net; > netdev@vger.kernel.org; oss-driv...@netronome.com > Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on de

Re: [PATCH bpf 1/2] bpf, libbpf: fix version info and add it to shared object

On 03/23, Daniel Borkmann wrote: > On 03/23/2019 01:09 AM, Stanislav Fomichev wrote: > > On 03/23, Daniel Borkmann wrote: > [...] > >> +$(OUTPUT)libbpf.so.$(LIBBPF_VERSION): $(BPF_IN) > >> + $(QUIET_LINK)$(CC) --shared -Wl,-soname,libbpf.so.$(LIBBPF_VERSION) \ > > Shouldn't it be -soname,libbpf.so

Re: [PATCH bpf 1/2] bpf, libbpf: fix version info and add it to shared object

On 03/23, Daniel Borkmann wrote: > Even though libbpf's versioning script for the linker (libbpf.map) > is pointing to 0.0.2, the BPF_EXTRAVERSION in the Makefile has > not been updated along with it and is therefore still on 0.0.1. > > While fixing up, I also noticed that the generated shared obj

[PATCH bpf 2/2] bpf, libbpf: clarify bump in libbpf version info

The current documentation suggests that we would need to bump the libbpf version on every change. Lets clarify this a bit more and reflect what we do today in practice, that is, bumping it once per development cycle. Fixes: 76d1b894c515 ("libbpf: Document API and ABI conventions") Reported-by: Sta

[PATCH bpf 0/2] libbpf fix up and clarify version info

First one is fixing version in Makefile and shared object and second one clarifies bump in version. Thanks! Daniel Borkmann (2): bpf, libbpf: fix version info and add it to shared object bpf, libbpf: clarify bump in libbpf version info tools/lib/bpf/Makefile | 42 ++

[PATCH bpf 1/2] bpf, libbpf: fix version info and add it to shared object

Even though libbpf's versioning script for the linker (libbpf.map) is pointing to 0.0.2, the BPF_EXTRAVERSION in the Makefile has not been updated along with it and is therefore still on 0.0.1. While fixing up, I also noticed that the generated shared object versioning information is missing, typi

[PATCH bpf-next 2/2] selftests: bpf: tc-bpf flow shaping with EDT

Add a small test that shows how to shape a TCP flow in tc-bpf with EDT and ECN. Signed-off-by: Peter Oskolkov --- tools/testing/selftests/bpf/Makefile | 3 +- .../testing/selftests/bpf/progs/test_tc_edt.c | 109 ++ tools/testing/selftests/bpf/test_tc_edt.sh| 99 ++

[PATCH bpf-next 1/2] bpf: make bpf_skb_ecn_set_ce callable from BPF_PROG_TYPE_SCHED_ACT

This helper is useful if a bpf tc filter sets skb->tstamp. Signed-off-by: Peter Oskolkov --- net/core/filter.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/core/filter.c b/net/core/filter.c index c1d19b074d6c..0a972fbf60df 100644 --- a/net/core/filter.c +++ b/net/core/filter.c @@ -5

[Patch net v2] xfrm: clean up xfrm protocol checks

In commit 6a53b7593233 ("xfrm: check id proto in validate_tmpl()") I introduced a check for xfrm protocol, but according to Herbert IPSEC_PROTO_ANY should only be used as a wildcard for lookup, so it should be removed from validate_tmpl(). And, IPSEC_PROTO_ANY is expected to only match 3 IPSec-spe

Re: [RFC PATCH 1/1 v2] net: sched: Introduce conndscp action

On Fri, Mar 22, 2019 at 3:06 PM Kevin 'ldir' Darbyshire-Bryant wrote: > > > > > On 22 Mar 2019, at 21:31, Cong Wang wrote: > > > > On Fri, Mar 22, 2019 at 1:50 PM Kevin 'ldir' Darbyshire-Bryant > > wrote: > >> > >> > >> > >>> On 22 Mar 2019, at 20:05, Cong Wang wrote: > >>> > >>> On Fri, Mar 22

Re: [PATCH v3 bpf-next 0/3] bpf: add bpf_progenyof helper

On Thu, Mar 07, 2019 at 10:26:22AM +0100, Daniel Borkmann wrote: > On 03/05/2019 11:47 PM, Javier Honduvilla Coto wrote: > > Hi all, > > > > This patch add the bpf_progenyof helper which receives a PID and returns > > 1 if the process currently being executed is in the process hierarchy, > > includ

[PATCH v4 bpf-next 3/3] bpf: add tests for bpf_progenyof

Adding the following test cases: - progenyof(current->pid) == 1 - progenyof(current->real_parent->pid) == 1 - progenyof(1) == 1 - progenyof(0) == 1 - progenyof(-1) == 0 - progenyof(current->children[0]->pid) == 0 Signed-off-by: Javier Honduvilla Coto --- tools/testing/selftests/bpf/.gitignore

[PATCH v4 bpf-next 1/3] bpf: add bpf_progenyof helper

This patch adds the bpf_progenyof helper which receives a PID and returns 1 if the process currently being executed is in the process hierarchy including itself or 0 if not. This is very useful in tracing programs when we want to filter by a given PID and all the children it might spawn. The curre

[PATCH v4 bpf-next 2/3] bpf: sync kernel uapi headers

Sync kernel uapi headers. Signed-off-by: Javier Honduvilla Coto --- tools/include/uapi/linux/bpf.h | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h index 3c04410137d9..cf54cc739bf4 100644 --- a/tools/inc

[PATCH v4 bpf-next 0/3] bpf: add bpf_progenyof helper

Hi all, This patch add the bpf_progenyof helper which receives a PID and returns 1 if the process currently being executed is in the process hierarchy, including itself or 0 if not. This is very useful in tracing programs when we want to filter by a given PID and all the children it might have. T

Re: [RFC PATCH 1/1 v2] net: sched: Introduce conndscp action

> On 22 Mar 2019, at 21:31, Cong Wang wrote: > > On Fri, Mar 22, 2019 at 1:50 PM Kevin 'ldir' Darbyshire-Bryant > wrote: >> >> >> >>> On 22 Mar 2019, at 20:05, Cong Wang wrote: >>> >>> On Fri, Mar 22, 2019 at 11:26 AM Kevin 'ldir' Darbyshire-Bryant >>> wrote: Hi Cong, >>

Re: [RFC PATCH 1/1 v2] net: sched: Introduce conndscp action

On Fri, Mar 22, 2019 at 1:50 PM Kevin 'ldir' Darbyshire-Bryant wrote: > > > > > On 22 Mar 2019, at 20:05, Cong Wang wrote: > > > > On Fri, Mar 22, 2019 at 11:26 AM Kevin 'ldir' Darbyshire-Bryant > > wrote: > >> > >> Hi Cong, > >> > >> Thanks for your questions. > >> > >>> On 22 Mar 2019, at 17:3

Re: [PATCH bpf-next v3 00/13] bpf tc tunneling

On Fri, Mar 22, 2019 at 02:32:47PM -0400, Willem de Bruijn wrote: > From: Willem de Bruijn > > BPF allows for dynamic tunneling, choosing the tunnel destination and > features on-demand. Extend bpf_skb_adjust_room to allow for efficient > tunneling at the TC hooks. > > Most features are required

Re: [RFC PATCH 1/1 v2] net: sched: Introduce conndscp action

> On 22 Mar 2019, at 20:05, Cong Wang wrote: > > On Fri, Mar 22, 2019 at 11:26 AM Kevin 'ldir' Darbyshire-Bryant > wrote: >> >> Hi Cong, >> >> Thanks for your questions. >> >>> On 22 Mar 2019, at 17:39, Cong Wang wrote: >>> >>> Hello, >>> >>> On Fri, Mar 22, 2019 at 7:09 AM Kevin 'ldir'

Re: [PATCH ipsec/vti 0/2] Fragmentation of IPv4 in VTI

Bram Yvahk wrote: > Steffen Klassert wrote: >> On Sun, Mar 17, 2019 at 11:37:55PM +, Bram Yvahk wrote: >>> We've experienced an issue with VTI when the path-mtu is smaller than > the size >>> of the "client" packet. >>> >>> What happens: IPv4 packet from the client (i.e. another system in the >

Re: [patch net-next v2 09/15] dsa: move devlink_port_attrs_set() call before register

On Fri, Mar 22, 2019 at 05:56:30PM +0100, Jiri Pirko wrote: > From: Jiri Pirko > > Since attrs are static during the existence of devlink port, set the > before registration of the port. > > Signed-off-by: Jiri Pirko Reviewed-by: Andrew Lunn Andrew

Re: r8169 driver from kernel 5.0 crashing - napi_consume_skb

> >>> Just a quick check-in... I was able to do a decent amount of testing > >>> yesterday after applying Heiner's patches that "removes an extra PCI > >>> register read in the > >>> interrupt handler" and adds some debug logging. So far I haven't seen > >>> any crashes, everything has been smooth

Re: Where to submit this?

On 3/21/19 5:18 PM, Ron Murray wrote: > I have an ASRock 970A-G/3.1 motherboard, which, with current Linux > kernels, occasionally "finds" an extra PCI device on the initial scan. I > wouldn't mind, but it finds it early in the piece, and that changes the > PCI allocation of my Ethernet board from

Re: [RFC PATCH 1/1 v2] net: sched: Introduce conndscp action

On Fri, Mar 22, 2019 at 11:26 AM Kevin 'ldir' Darbyshire-Bryant wrote: > > Hi Cong, > > Thanks for your questions. > > > On 22 Mar 2019, at 17:39, Cong Wang wrote: > > > > Hello, > > > > On Fri, Mar 22, 2019 at 7:09 AM Kevin 'ldir' Darbyshire-Bryant > > wrote: > >> > >> Conndscp is a new tc filt

[RFC bpf-next v3 8/8] selftests/bpf: add flow dissector bpf_skb_load_bytes helper test

When flow dissector is called without skb, we want to make sure bpf_skb_load_bytes invocations return error. Add small test which tries to read single byte from a packet. bpf_skb_load_bytes should always fail under BPF_PROG_TEST_RUN because it was converted to the skb-less mode. Signed-off-by: St

[RFC bpf-next v3 5/8] net: plumb network namespace into __skb_flow_dissect

This new argument will be used in the next patches for the eth_get_headlen use case. eth_get_headlen calls flow dissector with only data (without skb) so there is currently no way to pull attached BPF flow dissector program. With this new argument, we can amend the callers to explicitly pass networ

[RFC bpf-next v3 6/8] flow_dissector: handle no-skb use case

When called without skb, gather all required data from the __skb_flow_dissect's arguments and use recently introduces no-skb mode of bpf flow dissector. Note: WARN_ON_ONCE(!net) will now trigger for eth_get_headlen users. Signed-off-by: Stanislav Fomichev --- net/core/flow_dissector.c | 54

[RFC bpf-next v3 3/8] flow_dissector: fix clamping of BPF flow_keys for non-zero nhoff

Don't allow BPF program to set flow_keys->nhoff to less than initial value. We currently don't read the value afterwards in anything but the tests, but it's still a good practice to return consistent values to the test programs. Signed-off-by: Stanislav Fomichev --- net/core/flow_dissector.c | 2

[RFC bpf-next v3 7/8] net: pass net argument to the eth_get_headlen

Update all users eth_get_headlen to pass network namespace and pass it down to the flow dissector. This commit is a noop until administrator inserts BPF flow dissector program. Cc: Maxim Krasnyansky Cc: Saeed Mahameed Cc: Jeff Kirsher Cc: intel-wired-...@lists.osuosl.org Cc: Yisen Zhuang Cc: S

[RFC bpf-next v3 2/8] flow_dissector: switch kernel context to struct bpf_flow_dissector

struct bpf_flow_dissector has a small subset of sk_buff fields that flow dissector BPF program is allowed to access and an optional pointer to real skb. Real skb is used only in bpf_skb_load_bytes helper to read non-linear data. The real motivation for this is to be able to call flow dissector fro

[RFC bpf-next v3 4/8] bpf: when doing BPF_PROG_TEST_RUN for flow dissector use no-skb mode

Now that we have bpf_flow_dissect which can work on raw data, use it when doing BPF_PROG_TEST_RUN for flow dissector. Simplifies bpf_prog_test_run_flow_dissector and allows us to test no-skb mode. Note, that previously, with bpf_flow_dissect_skb we used to call eth_type_trans which pulled L2 (ETH

[RFC bpf-next v3 1/8] flow_dissector: allow access only to a subset of __sk_buff fields

Use whitelist instead of a blacklist and allow only a small set of fields that might be relevant in the context of flow dissector: * protocol * vlan_present * vlan_tci * vlan_proto This is required for the eth_get_headlen case where we have only a chunk of data to dissect (i.e. trying to read the

[RFC bpf-next v3 0/8] net: flow_dissector: trigger BPF hook when called from eth_get_headlen

Currently, when eth_get_headlen calls flow dissector, it doesn't pass any skb. Because we use passed skb to lookup associated networking namespace to find whether we have a BPF program attached or not, we always use C-based flow dissector in this case. The goal of this patch series is to add new n

Re: [PATCH net-next 2/3] tcp: add one skb cache for tx

Hi Eric, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Eric-Dumazet/net-convert-rps_needed-and-rfs_needed-to-new-static-branch-api/20190322-211954 reproduce: make htmldocs All warnings (new ones

[net-next V3 12/14] net/mlx5e: Add VLAN ID rewrite fields

From: Eli Britstein Add VLAN ID rewrite fields as a pre-step to support this rewrite. Signed-off-by: Eli Britstein Reviewed-by: Roi Dayan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 2 ++ include/linux/mlx5/mlx5_ifc.h | 1 + 2 files c

[net-next V3 03/14] net/mlx5: Simplify mlx5_sriov_is_enabled() by using pci core API

From: Parav Pandit It is desired to get rid of num_vfs stored inside mlx5_core_sriov to safely support vports more than vfs. To reduce dependency on mlx5_core_sriov num_vfs, start using pci_num_vf() from pci core. Signed-off-by: Parav Pandit Reviewed-by: Bodong Wang Signed-off-by: Saeed Mahame

[pull request][net-next V3 00/14] Mellanox, mlx5 updates 2019-03-20

Hi Dave, This series includes mlx5 updates. For more information please see tag log below. Please pull and let me know if there is any problem. v1->v2: Remove NFP specific vxlan/geneve port #defines based upon Jakub's feedback. v2->v3: Drop Roi's Eswitch fix patch, as we want it submitt

[net-next V3 06/14] net/mlx5e: Fix compilation warning in en_tc.c

Amazingly a mlx5e_tc function is being called from the eswitch layer, which is by itself very terrible! The function was declared locally in eswitch_offloads.c so it could be used there, which caused the following compilation warning, fix that. drivers/.../mlx5/core/en_tc.c:3242:6: [-Werror=missin

[net-next V3 14/14] net/mlx5e: Replace TC VLAN pop and push actions with VLAN modify

From: Eli Britstein Changing the VLAN header may be implemented by pop the existing header and push a new one. Translate those operations as VLAN modify. Applicable for use cases such as OVS where the controller translates a vlan modify meta (OF) rule to DP pop+push actions rule. Signed-off-by:

[net-next V3 08/14] net: Move the definition of the default Geneve udp port to public header file

From: Moshe Shemesh Move the definition of the default Geneve udp port from the geneve source to the header file, so we can re-use it from drivers. Modify existing drivers to use it. Signed-off-by: Moshe Shemesh Reviewed-by: Or Gerlitz Cc: John Hurley Cc: Jakub Kicinski Reviewed-by: Tariq To

[net-next V3 10/14] net/mlx5e: TX, Add geneve tunnel stateless offload support

From: Moshe Shemesh Currently support only default geneve udp port (6081). For the tx side, the HW is assisted by SW parsing, which sets the headers offset to offload tunneled LSO and csum. Note that for udp tunnels, we don't use special rx offloads, as rss on the outer headers is enough, we supp

[net-next V3 13/14] net/mlx5e: Support VLAN modify action

From: Eli Britstein Support VLAN modify action by emulating a rewrite action for the VLAN fields. Currently, the only supported field is the vid. The prio in the action must be set to 0 to indicate no change. Signed-off-by: Eli Britstein Reviewed-by: Roi Dayan Signed-off-by: Saeed Mahameed --

[net-next V3 11/14] net: Add IANA_VXLAN_UDP_PORT definition to vxlan header file

From: Moshe Shemesh Added IANA_VXLAN_UDP_PORT (4789) definition to vxlan header file so it can be used by drivers instead of local definition. Updated drivers which locally defined it as 4789 to use it. Signed-off-by: Moshe Shemesh Reviewed-by: Or Gerlitz Cc: John Hurley Cc: Jakub Kicinski C

[net-next V3 09/14] net/mlx5e: Take SW parser code to a separate function

From: Moshe Shemesh Refactor mlx5e_ipsec_set_swp() code, split the part which sets the eseg software parser (SWP) offsets and flags, so it can be used in a downstream patch by other mlx5e functionality which needs to set eseg SWP. The new function mlx5e_set_eseg_swp() is useful for setting swp fo

[net-next V3 05/14] net/mlx5e: Fix port buffer function documentation format

This patch fixes compiler warnings: In drivers/.../mlx5/core/en/port_buffer.c:190: warning: Function parameter or member 'pfc_en' not described... ... warning: Function parameter or member 'change' not described... Fixes: 0696d60853d5 ("net/mlx5e: Receive buffer configuration") Reviewed-by: Eran B

[net-next V3 07/14] net/mlx5e: Remove redundant assignment

From: "Gustavo A. R. Silva" Remove redundant assignment to tun_entropy->enabled. Addesses-Coverity-ID: 1477328 ("Unused value") Fixes: 97417f6182f8 ("net/mlx5e: Fix GRE key by controlling port tunnel entropy calculation") Signed-off-by: Gustavo A. R. Silva Reviewed-by: Roi Dayan Reviewed-by:

[net-next V3 02/14] net/mlx5: Rename total_vfs to total_vports

From: Parav Pandit Macro MLX5_TOTAL_VPORTS() returns total number of vports. Therefore, rename variable total_vfs to total_vports to improve code readability. Signed-off-by: Parav Pandit Reviewed-by: Bodong Wang Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/eswitc

[net-next V3 04/14] net/mlx5: Fix compilation warning in eq.c

mlx5_eq_table_get_rmap is being used only when CONFIG_RFS_ACCEL is enabled, this patch fixes the below warning when CONFIG_RFS_ACCEL is disabled. drivers/.../mlx5/core/eq.c:903:18: [-Werror=missing-prototypes] error: no previous prototype for ‘mlx5_eq_table_get_rmap’ Fixes: f2f3df550139 ("net/mlx

[net-next V3 01/14] net/mlx5: Simplify sriov enable/disable flow

From: Parav Pandit Simplify sriov enable/disable flow for below two checks. 1. PCI core driver allows sriov configuration only on a PF. This is done in drivers/pci/pci-sysfs.c sriov_attrs_are_visible(). 2. PCI core driver allow sriov enablement if the sriov is currently disabled for for a PF. T

Re: r8169 driver from kernel 5.0 crashing - napi_consume_skb

On 21.03.2019 20:35, VDR User wrote: >>> Just a quick check-in... I was able to do a decent amount of testing >>> yesterday after applying Heiner's patches that "removes an extra PCI >>> register read in the >>> interrupt handler" and adds some debug logging. So far I haven't seen >>> any crashes,

[PATCH net] net: phy: don't clear BMCR in genphy_soft_reset

So far we effectively clear the BMCR register. Some PHY's can deal with this (e.g. because they reset BMCR to a default as part of a soft-reset) whilst on others this causes issues because e.g. the autoneg bit is cleared. Marvell is an example, see also thread [0]. So let's be a little bit more gen

Re: [PATCH 7/7] net/utils: Use strlcpy() instead of open-coding it

On Mar 21, 2019, at 3:19 PM, Bart Van Assche wrote: This patch does not change any functionality but makes the code easier to read. Cc: Sagi Grimberg Cc: Christoph Hellwig Signed-off-by: Bart Van Assche --- net/core/utils.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff -

[PATCH bpf-next v3 04/13] selftests/bpf: expand bpf tunnel test to ipv6

From: Willem de Bruijn The test only uses ipv4 so far, expand to ipv6. This is mostly a boilerplate near copy of the ipv4 path. Signed-off-by: Willem de Bruijn --- tools/testing/selftests/bpf/config| 2 + .../selftests/bpf/progs/test_tc_tunnel.c | 116 +++--- too

[PATCH bpf-next v3 07/13] bpf: add bpf_skb_adjust_room mode BPF_ADJ_ROOM_MAC

From: Willem de Bruijn bpf_skb_adjust_room net allows inserting room in an skb. Existing mode BPF_ADJ_ROOM_NET inserts room after the network header by pulling the skb, moving the network header forward and zeroing the new space. Add new mode BPF_ADJUST_ROOM_MAC that inserts room after the mac

[PATCH bpf-next v3 02/13] selftests/bpf: bpf tunnel encap test

From: Willem de Bruijn Validate basic tunnel encapsulation using ipip. Set up two namespaces connected by veth. Connect a client and server. Do this with and without bpf encap. Signed-off-by: Willem de Bruijn --- tools/testing/selftests/bpf/Makefile | 3 +- .../selftests/bpf/progs/t

[PATCH bpf-next v3 08/13] bpf: add bpf_skb_adjust_room flag BPF_F_ADJ_ROOM_FIXED_GSO

From: Willem de Bruijn bpf_skb_adjust_room adjusts gso_size of gso packets to account for the pushed or popped header room. This is not allowed with UDP, where gso_size delineates datagrams. Add an option to avoid these updates and allow this call for datagrams. It can also be used with TCP, wh

[PATCH bpf-next v3 03/13] selftests/bpf: expand bpf tunnel test with decap

From: Willem de Bruijn The bpf tunnel test encapsulates using bpf, then decapsulates using a standard tunnel device to verify correctness. Once encap is verified, also test decap, by replacing the tunnel device on decap with another bpf program. Signed-off-by: Willem de Bruijn --- .../selftes

[PATCH bpf-next v3 06/13] selftests/bpf: extend bpf tunnel test with tso

From: Willem de Bruijn Segmentation offload takes a longer path. Verify that the feature works with large packets. The test succeeds if not setting dodgy in bpf_skb_adjust_room, as veth TSO is permissive. If not setting SKB_GSO_DODGY, this enables tunneled TSO offload on supporting NICs. The f

[PATCH bpf-next v3 09/13] bpf: add bpf_skb_adjust_room encap flags

From: Willem de Bruijn When pushing tunnel headers, annotate skbs in the same way as tunnel devices. For GSO packets, the network stack requires certain fields set to segment packets with tunnel headers. gro_gse_segment depends on transport and inner mac header, for instance. Add an option to p

[PATCH bpf-next v3 12/13] selftests/bpf: convert bpf tunnel test to BPF_F_ADJ_ROOM_FIXED_GSO

From: Willem de Bruijn Lower route MTU to ensure packets fit in device MTU after encap, then skip the gso_size changes. Signed-off-by: Willem de Bruijn --- tools/testing/selftests/bpf/progs/test_tc_tunnel.c | 11 --- tools/testing/selftests/bpf/test_tc_tunnel.sh | 6 ++ 2 fil

[PATCH bpf-next v3 10/13] bpf: Sync bpf.h to tools

From: Willem de Bruijn Sync include/uapi/linux/bpf.h with tools/ Changes v1->v2: - BPF_F_ADJ_ROOM_MASK moved, no longer in this commit v2->v3: - BPF_F_ADJ_ROOM_ENCAP_L3_MASK moved, no longer in this commit Signed-off-by: Willem de Bruijn --- tools/include/uapi/linux/bpf.h | 29 +++

[PATCH bpf-next v3 13/13] selftests/bpf: convert bpf tunnel test to encap modes

From: Willem de Bruijn Make the tests correctly annotate skbs with tunnel metadata. This makes the gso tests succeed. Enable them. Signed-off-by: Willem de Bruijn --- .../selftests/bpf/progs/test_tc_tunnel.c | 19 +++ tools/testing/selftests/bpf/test_tc_tunnel.sh | 10 +++

[PATCH bpf-next v3 01/13] bpf: in bpf_skb_adjust_room avoid copy in tx fast path

From: Willem de Bruijn bpf_skb_adjust_room calls skb_cow on grow. This expensive operation can be avoided in the fast path when the only other clone has released the header. This is the common case for TCP, where one headerless clone is kept on the retransmit queue. It is safe to do so even whe

[PATCH bpf-next v3 00/13] bpf tc tunneling

From: Willem de Bruijn BPF allows for dynamic tunneling, choosing the tunnel destination and features on-demand. Extend bpf_skb_adjust_room to allow for efficient tunneling at the TC hooks. Most features are required for large packets with GSO, as these will be modified after this patch. Patch

[PATCH bpf-next v3 05/13] selftests/bpf: extend bpf tunnel test with gre

From: Willem de Bruijn GRE is a commonly used protocol. Add GRE cases for both IPv4 and IPv6. It also inserts different sized headers, which can expose some unexpected edge cases. Signed-off-by: Willem de Bruijn --- .../selftests/bpf/progs/test_tc_tunnel.c | 148 +- tools

[PATCH bpf-next v3 11/13] selftests/bpf: convert bpf tunnel test to BPF_ADJ_ROOM_MAC

From: Willem de Bruijn Avoid moving the network layer header when prefixing tunnel headers. This avoids an explicit call to bpf_skb_store_bytes and an implicit move of the network header bytes in bpf_skb_adjust_room. Signed-off-by: Willem de Bruijn --- .../selftests/bpf/progs/test_tc_tunnel.c

Re: [RFC PATCH 1/1 v2] net: sched: Introduce conndscp action

Hi Cong, Thanks for your questions. > On 22 Mar 2019, at 17:39, Cong Wang wrote: > > Hello, > > On Fri, Mar 22, 2019 at 7:09 AM Kevin 'ldir' Darbyshire-Bryant > wrote: >> >> Conndscp is a new tc filter action module. It is designed to copy DSCPs >> to conntrack marks and the reverse operati

[PATCH 2/2] openvswitch: Add timeout support to ct action

Add support for fine-grain timeout support to conntrack action. The new OVS_CT_ATTR_TIMEOUT attribute of the conntrack action specifies a timeout to be associated with this connection. If no timeout is specified, it acts as is, that is the default timeout for the connection will be automatically ap

[PATCH 1/2] netfilter: Export nf_ct_{set,destroy}_timeout()

This patch exports nf_ct_set_timeout() and nf_ct_destroy_timeout(). The two functions are derived from xt_ct_destroy_timeout() and xt_ct_set_timeout() in xt_CT.c, and moved to nf_conntrack_timeout.c without any functional change. It would be useful for other users (i.e. OVS) that utilizes the finer

Re: [RFC PATCH 1/1 v2] net: sched: Introduce conndscp action

Hello, On Fri, Mar 22, 2019 at 7:09 AM Kevin 'ldir' Darbyshire-Bryant wrote: > > Conndscp is a new tc filter action module. It is designed to copy DSCPs > to conntrack marks and the reverse operation of conntrack mark contained > DSCPs to the diffserv field of suitable skbs. > Is it possible an

[net-next 05/15] ice: Fix issue reconfiguring VF queues

From: Akeem G Abodunrin When VF requested for queues changes, we need to update LAN Tx queue with correct number of VF queue pairs and re-allocate VF resources based on this new requested number of queues, which is constraint within maximum queue supported per VF. Signed-off-by: Akeem G Abodunri

[net-next 15/15] ice: Get VF VSI instances directly via PF

From: Akeem G Abodunrin This patch changes how we get VF VSIs instances. Instead of relying on mailbox virtual channel message to retrieve VSI, it is more reliable getting it directly via VF object in PF data structure. Signed-off-by: Akeem G Abodunrin Signed-off-by: Anirudh Venkataramanan Tes

[net-next 08/15] ice: Remove unused vsi_id field

From: Anirudh Venkataramanan Remove unused vsi_id field from struct ice_sched_vsi_info. Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/ice_type.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethe

[net-next 04/15] ice: Remove unused function prototype

From: Anirudh Venkataramanan Commit 7c710869d64e ("ice: Add handlers for VF netdevice operations") seems to have inadvertently introduced a function prototype for ice_set_vf_bw that isn't implemented. Remove it. Fixes: 7c710869d64e ("ice: Add handlers for VF netdevice operations") Signed-off-by

[net-next 03/15] ice: fix static analysis warnings

From: Bruce Allan cppcheck warns "Identical condition '', second condition is always false". Fix them. Signed-off-by: Bruce Allan Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/ice_common.c | 2 +- drivers/net/et

[net-next 06/15] ice: fix the divide by zero issue

From: Kiran Patil Static analysis flagged a potential divide by zero error because vsi->num_rxq can become zero in certain condition and it is used as divisor. Signed-off-by: Kiran Patil Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/n

[net-next 02/15] ice: Fix issue reclaiming resources back to the pool after reset

From: Akeem G Abodunrin This patch fixes issue reclaiming VF resources back to the pool after reset - Since we only allocate HW vector for all VFs and track together with resources allocation for PF with ice_search_res, we need to free VFs resources separately, using first VF vector index to trav

[net-next 11/15] ice: Enable LAN_EN for the right recipes

From: Yashaswini Raghuram Prathivadi Bhayankaram In VEB mode, enable LAN_EN bit in the action fields for filter rules corresponding to the right recipes. Signed-off-by: Yashaswini Raghuram Prathivadi Bhayankaram Reviewed-by: Bruce Allan Signed-off-by: Anirudh Venkataramanan Tested-by: Andre

[net-next 10/15] ice: Add support for PF/VF promiscuous mode

From: Akeem G Abodunrin Implement support for VF promiscuous mode, MAC/VLAN/MAC_VLAN and PF multicast MAC/VLAN/MAC_VLAN promiscuous mode. Signed-off-by: Akeem G Abodunrin Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/inte

[net-next 12/15] ice: Do not set LB_EN for prune switch rules

From: Christopher N Bednarz LB_EN for prune switch rules was causing all TX traffic to loopback to the internal switch and dropped. When running bi-directional stress workloads with RDMA the RDPU would hang blocking tx and rx traffic. Signed-off-by: Christopher N Bednarz Reviewed-by: Bruce All

[net-next 01/15] ice: Enable MAC anti-spoof by default

From: Akeem G Abodunrin This patch enables MAC anti-spoof by default, with creation of VF VSIs or when the VF VSIs are being re-initialized. Signed-off-by: Akeem G Abodunrin Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/i

[net-next 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2019-03-22

This series contains updates to ice driver only. Akeem enables MAC anti-spoofing by default when a new VSI is being created. Fixes an issue when reclaiming VF resources back to the pool after reset, by freeing VF resources separately using the first VF vector index to traverse the list, instead o

[net-next 09/15] ice: code cleanup in ice_sched.c

From: Victor Raj This patch does some clean up in the Tx scheduler code: 1. Adjust the stack variable usage 2. Modify the debug prints to display the FW error 3. Add additional debug prints while adding/removing VSIs Signed-off-by: Victor Raj Reviewed-by: Bruce Allan Signed-off-by: Anirudh Ve

[net-next 07/15] ice: fix some function prototype and signature style issues

From: Bruce Allan Put the return type on a separate line for function prototypes and signatures that would exceed the 80-character limit if both were on the same line. Signed-off-by: Bruce Allan Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- d

[net-next 13/15] ice: Set LAN_EN for all directional rules

From: Yashaswini Raghuram Prathivadi Bhayankaram The LAN_EN bit for a switch rule determines if the packet can go out on the wire or not. Set the LAN_EN flag in the switch action for all directional rules. Signed-off-by: Yashaswini Raghuram Prathivadi Bhayankaram Signed-off-by: Anirudh Venkat

[net-next 14/15] ice: Don't let VF know that it is untrusted

From: Akeem G Abodunrin Don't let the VF know it's not trusted when it tries to add more than permitted additional MAC addresses. Signed-off-by: Akeem G Abodunrin Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/ic

Re: [PATCH net v2 1/1] net: sched: fix cleanup NULL pointer exception in act_mirr

On Fri, Mar 22, 2019 at 5:37 AM John Hurley wrote: > > A new mirred action is created by the tcf_mirred_init function. This > contains a list head struct which is inserted into a global list on > successful creation of a new action. However, after a creation, it is > still possible to error out an

Re: [iproute2 PATCH] ip: bridge: add mcast to unicast config flag

On Thu, 21 Mar 2019 09:32:39 +0100 Tobias Jungel wrote: > This adds configuration for the IFLA_BRPORT_MCAST_TO_UCAST flag that > allows multicast packets to be replicated as unicast packets. > > Signed-off-by: Tobias Jungel Applied. And this motivated me to fix the long lines in the man pages

  1   2   >