On Fri, Mar 22, 2019 at 06:19:57PM -0700, Stanislav Fomichev wrote: > Are we ok with breaking api in this case? I'm all in on removing this > extra information. We can always put it back if somebody complains (and > manually parse in eth_get_headlen case).
Fine. That seems to be the only way forward to clean it all up. Could you submit patch 1 to bpf tree disallowing vlan fields? Patch 3 looks like candidate as well? > We can still have protocol, because in both skb/skb-less cases we have > it. proto can work in both cases, but is it needed ? Does program benefit from it? The kernel side burns extra bytes by copying it and extra branches to handle it. May be drop it as well?
