On Mon, Mar 11, 2019 at 8:24 PM Kris Van Hees wrote:
>
> On Mon, Mar 11, 2019 at 06:29:55PM -0700, Brendan Gregg wrote:
> > On Mon, Mar 11, 2019 at 7:21 AM Kris Van Hees
> > wrote:
> > >
> > > On Thu, Mar 07, 2019 at 01:30:37PM -0800, Alexei Starovoitov wrote:
> > > > On Tue, Mar 05, 2019 at 09:
> -Original Message-
> From: Boris Pismenny
> Sent: Monday, March 11, 2019 9:29 PM
> To: Vakul Garg ; Aviad Yehezkel
> ; davejwat...@fb.com;
> john.fastab...@gmail.com; dan...@iogearbox.net; netdev@vger.kernel.org
> Cc: Eran Ben Elisha
> Subject: Re: [PATCH net 2/4] tls: Fix write space
On Mon, Mar 11, 2019 at 12:32 PM Martynas Pumputis wrote:
>
> It has been observed that sometimes a higher order memory allocation
> for BPF maps fails when there is no obvious memory pressure in a system.
>
> E.g. the map (BPF_MAP_TYPE_LRU_HASH, key=38, value=56, max_elems=524288)
> could not be
> On Mar 11, 2019, at 10:21 PM, Yonghong Song wrote:
>
> The test_progs subtests, test_spin_lock() and test_map_lock(),
> requires BTF present to run successfully.
> Currently, when BTF failed to load, test_progs will segfault,
> $ ./test_progs
> ...
> 12: (bf) r1 = r8
> 13: (85) call bpf_
The test_progs subtests, test_spin_lock() and test_map_lock(),
requires BTF present to run successfully.
Currently, when BTF failed to load, test_progs will segfault,
$ ./test_progs
...
12: (bf) r1 = r8
13: (85) call bpf_spin_lock#93
map 'hash_map' has to have BTF in order to use bpf_spin
On Sun, Mar 10, 2019 at 11:47:47AM -0700, David Miller wrote:
> From: Andrew Boyer
> Date: Fri, 8 Mar 2019 14:01:11 -0500
>
> > From: Farrell Woods
> >
> > The patch fixes an IPv6 conformance test failure (v6LC_1_2_03a in the
> > UNH INTACT suite) that occurs specifically when IPsec is in use.
Okay, then I misunderstood your earlier comment.
And guess it is not backported to latest 4.19 as that also fails.
Just to sanity check, I'll test mainline to satisfy my curiosity.
Thank you all for your time and replies!
On Mon, Mar 11, 2019 at 10:20 PM Eric Dumazet wrote:
>
>
>
> On 03/11/2019
On 03/11/2019 09:12 PM, Captain Wiggum wrote:
> Hi All,
>
> To summarize this thread, we test for IPv6 Ready Logo using Self-test
> Tools (TAHI Project) here:
> https://www.ipv6ready.org/?page=documents&tag=ipv6-core-protocols
>
> 4.9.133 and previous passed 100%. Beginning with 4.9.134 it fai
In case it is useful, this was the bisect test progress:
my-build-name test commit/release
- --
kernel-4.9.133-1 good [deb3303f665b31c29210ef4b30b1e69cb06cc397]
Linux 4.9.133
kernel-4.9.134-1 bad[1d326a94d1039e4543edd97cbaf0fc38d2cefbb5]
Linux 4.9.1
Hi All,
To summarize this thread, we test for IPv6 Ready Logo using Self-test
Tools (TAHI Project) here:
https://www.ipv6ready.org/?page=documents&tag=ipv6-core-protocols
4.9.133 and previous passed 100%. Beginning with 4.9.134 it fails 18
tests related to IPv6 fragment headers.
I have done a git
On Mon, Mar 11, 2019 at 06:29:55PM -0700, Brendan Gregg wrote:
> On Mon, Mar 11, 2019 at 7:21 AM Kris Van Hees
> wrote:
> >
> > On Thu, Mar 07, 2019 at 01:30:37PM -0800, Alexei Starovoitov wrote:
> > > On Tue, Mar 05, 2019 at 09:03:57PM -0500, Kris Van Hees wrote:
> [...]
> > > > But being able t
Inside the loop, we always start with event non-NULL.
Signed-off-by: David S. Miller
---
net/sctp/ulpqueue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sctp/ulpqueue.c b/net/sctp/ulpqueue.c
index 5dde92101743..0fecc1fb4ab7 100644
--- a/net/sctp/ulpqueue.c
+++ b/net
net-next is closed, please resubmit this when net-next opens back up.
Pass this, instead of an event. Then everything trickles down and we
always have events a non-empty list.
Then we needs a list creating stub to place into .enqueue_event for
sctp_stream_interleave_1.
Signed-off-by: David S. Miller
---
net/sctp/stream_interleave.c | 49 ++
Now the SKB list implementation assumption can be removed.
And now that we know that the list head is always non-NULL
we can remove the code blocks dealing with that as well.
Signed-off-by: David S. Miller
---
include/net/sctp/ulpqueue.h | 2 +-
net/sctp/stream_interleave.c | 2 +-
net/sct
This patch series eliminates the explicit reference to the skb list
implementation via skb->prev dereferences.
The approach used is to pass a non-empty skb list around instead of an
event skb object which may or may not be on a list.
I'd like to thank Marcelo Leitner, Xin Long, and Neil Horman
This way we can make sure events sent this way to
sctp_ulpq_tail_event() are on a list as well. Now all such code paths
are fully covered.
Signed-off-by: David S. Miller
---
net/sctp/stream_interleave.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/net/sctp/s
This way we can simplify the logic and remove assumptions
about the implementation of skb lists.
Signed-off-by: David S. Miller
---
net/sctp/ulpqueue.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/net/sctp/ulpqueue.c b/net/sctp/ulpqueue.c
index 0fecc1fb
IPv4 has icmp_echo_ignore_broadcast to prevent responding to broadcast pings.
IPv6 needs a similar mechanism.
Signed-off-by: Stephen Suryaputra
---
Documentation/networking/ip-sysctl.txt | 5 +
include/net/netns/ipv6.h | 1 +
include/uapi/linux/sysctl.h| 3 ++-
n
On Mon, 11 Mar 2019 09:52:04 +0100, Jiri Pirko wrote:
> Fri, Mar 08, 2019 at 08:09:43PM CET, jakub.kicin...@netronome.com wrote:
> >If the switchport is in the hypervisor then only the hypervisor can
> >control switching/forwarding, correct?
>
> Correct.
>
> >The primary use case for partitioni
On 2019/3/12 2:54, Greg KH wrote:
On Mon, Mar 11, 2019 at 07:13:14PM +0800, Jason Yan wrote:
On 2019/3/11 17:41, Daniel Borkmann wrote:
Hi Jason,
On 03/11/2019 10:18 AM, Jason Yan wrote:
Hi, Daniel & Greg
This patch (979d63d50c0c bpf: prevent out of bounds speculation on pointer
arithm
On Mon, Mar 11, 2019 at 7:21 AM Kris Van Hees wrote:
>
> On Thu, Mar 07, 2019 at 01:30:37PM -0800, Alexei Starovoitov wrote:
> > On Tue, Mar 05, 2019 at 09:03:57PM -0500, Kris Van Hees wrote:
[...]
> > > But being able to do things like this without
> > > needing to touch the context of any other
Hi Jian-Hong,
Am 31.01.19 um 17:21 schrieb Jian-Hong Pan:
> This series refines the commit 48e5bb6cec79 ("net: Prepare LoRaWAN
> socket module") for coding style.
> Besides, sperates LoRaWAN related skb definitions from
> lora/lorawan_netdev.h into another header lora/lorawan/skb.h.
Sorry for the
On Mon, Mar 11, 2019 at 04:11:32PM -0400, Paul Moore wrote:
> On Fri, Mar 8, 2019 at 9:47 PM Paul Moore wrote:
> > On Fri, Mar 8, 2019 at 12:08 PM Marcelo Ricardo Leitner
> > wrote:
> > > On Sat, Mar 09, 2019 at 12:07:34AM +0800, Xin Long wrote:
> > > > As does in __sctp_connect(), when checking
From: Saeed Mahameed
Date: Mon, 11 Mar 2019 11:39:19 -0700
> This series introduces some fixes to mlx5 driver.
> For more information please see tag log below.
>
> Please pull and let me know if there is any problem.
>
> For -stable v5.0:
> ('net/mlx5e: Fix access to non-existing receive queue'
On 03/12/2019 12:06 AM, Alexei Starovoitov wrote:
> On Mon, Mar 11, 2019 at 10:51:18PM +0100, Daniel Borkmann wrote:
>> This work adds two new map creation flags BPF_F_RDONLY_PROG
>> and BPF_F_WRONLY_PROG in order to allow for read-only or
>> write-only BPF maps from a BPF program side.
>>
>> Today
From: xiaofeis
Date: Mon, 11 Mar 2019 14:11:40 +0800
> Add documentation for a new optional property local-mac-address which
> is described in ethernet.txt.
>
> Signed-off-by: xiaofeis
Applied.
On Mon, Mar 11, 2019 at 10:51:18PM +0100, Daniel Borkmann wrote:
> This work adds two new map creation flags BPF_F_RDONLY_PROG
> and BPF_F_WRONLY_PROG in order to allow for read-only or
> write-only BPF maps from a BPF program side.
>
> Today we have BPF_F_RDONLY and BPF_F_WRONLY, but this only
>
From: Eric Dumazet
Date: Mon, 11 Mar 2019 13:48:44 -0700
> In case x25_connect() fails and frees the socket neighbour,
> we also need to undo the change done to x25->state.
>
> Before my last bug fix, we had use-after-free so this
> patch fixes a latent bug.
>
> syzbot report :
...
> Fixes: 95
From: Christoph Paasch
Date: Mon, 11 Mar 2019 11:41:05 -0700
> Since commit eeea10b83a13 ("tcp: add
> tcp_v4_fill_cb()/tcp_v4_restore_cb()"), tcp_vX_fill_cb is only called
> after tcp_filter(). That means, TCP_SKB_CB(skb)->end_seq still points to
> the IP-part of the cb.
>
> We thus should not m
On 03/11/2019 11:41 AM, Christoph Paasch wrote:
> Since commit eeea10b83a13 ("tcp: add
> tcp_v4_fill_cb()/tcp_v4_restore_cb()"), tcp_vX_fill_cb is only called
> after tcp_filter(). That means, TCP_SKB_CB(skb)->end_seq still points to
> the IP-part of the cb.
>
> We thus should not mock with it,
Hi Olga,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Olga-Albisser/sched-add-dualpi2-scheduler-module/20190312-042220
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gnu-gcc (
This work adds two new map creation flags BPF_F_RDONLY_PROG
and BPF_F_WRONLY_PROG in order to allow for read-only or
write-only BPF maps from a BPF program side.
Today we have BPF_F_RDONLY and BPF_F_WRONLY, but this only
applies to system call side, meaning the BPF program has full
read/write acce
This work adds BPF loader support for global data sections
to libbpf. This allows to write BPF programs in more natural
C-like way by being able to define global variables and const
data.
Back at LPC 2018 [0] we presented a first prototype which
implemented support for global data sections by exte
From: Joe Stringer
Adjust the code for relocations slightly with no functional changes,
so that upcoming patches that will introduce support for relocations
into the .data, .rodata and .bss sections can be added independent
of these changes.
Signed-off-by: Joe Stringer
Signed-off-by: Daniel Bor
This generic extension to BPF maps allows for directly loading an
address residing inside a BPF map value as a single BPF ldimm64
instruction.
The idea is similar to what BPF_PSEUDO_MAP_FD does today, which
is a special src_reg flag for ldimm64 instruction that indicates
that inside the first part
This patch adds a new BPF_MAP_LOCK command which allows to lock the
map globally as read-only/immutable from syscall side. Map permission
handling has been refactored into map_get_sys_perms() and drops
FMODE_CAN_WRITE in case of locked map. Main use case is to allow
for setting up .rodata sections
From: Joe Stringer
Add tests for libbpf relocation of static variable references
into the .data, .rodata and .bss sections of the ELF, also add
read-only test for .rodata. All passing:
# ./test_progs
[...]
test_global_data:PASS:load program 0 nsec
test_global_data:PASS:pass global data r
Trivial addition to allow '.' aside from '_' as "special" characters
in the object name. Used to allow for substrings in maps from loader
side such as ".bss", ".data", ".rodata", but could also be useful for
other purposes.
Signed-off-by: Daniel Borkmann
---
kernel/bpf/syscall.c | 6 +++---
1 fi
Extend test_verifier with various test cases around the two kernel
extensions, that is, {rd,wr}only map support as well as direct map
value access. All passing, one skipped due to xskmap not present
on test machine:
# ./test_verifier
[...]
#920/p XDP pkt read, pkt_data <= pkt_meta', bad acce
Pull in latest changes, so we can make use of them in libbpf.
Signed-off-by: Daniel Borkmann
---
tools/include/uapi/linux/bpf.h | 24 ++--
1 file changed, 22 insertions(+), 2 deletions(-)
diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h
index 3c38
This series is a major rework of previously submitted libbpf
patches [0] in order to add global data support for BPF. The
kernel has been extended to add proper infrastructure that allows
for full .bss/.data/.rodata sections on BPF loader side based
upon feedback from LPC discussions [1]. Latter su
In case x25_connect() fails and frees the socket neighbour,
we also need to undo the change done to x25->state.
Before my last bug fix, we had use-after-free so this
patch fixes a latent bug.
syzbot report :
kasan: CONFIG_KASAN_INLINE enabled
kasan: GPF could be caused by NULL-ptr deref or user
Since commit eeea10b83a13 ("tcp: add
tcp_v4_fill_cb()/tcp_v4_restore_cb()"), tcp_vX_fill_cb is only called
after tcp_filter(). That means, TCP_SKB_CB(skb)->end_seq still points to
the IP-part of the cb.
We thus should not mock with it, as this can trigger bugs (thanks
syzkaller):
[ 12.349396]
=
From: Andrea Claudi
[ Upstream commit 098e13f5b21d3398065fce8780f07a3ef62f4812 ]
ipvs relies on nf_defrag_ipv6 module to manage IPv6 fragmentation,
but lacks proper Kconfig dependencies and does not explicitly
request defrag features.
As a result, if netfilter hooks are not loaded, when IPv6 fr
From: Johannes Berg
[ Upstream commit 1fc9b7253382ce1a83d9a3e63e88d656eb63f263 ]
It's possible that the caller of cfg80211_classify8021d() uses the
value to index an array, like mac80211 in ieee80211_downgrade_queue().
Prevent speculation on the return value.
Signed-off-by: Johannes Berg
Signe
On Fri, Mar 8, 2019 at 9:47 PM Paul Moore wrote:
> On Fri, Mar 8, 2019 at 12:08 PM Marcelo Ricardo Leitner
> wrote:
> > On Sat, Mar 09, 2019 at 12:07:34AM +0800, Xin Long wrote:
> > > As does in __sctp_connect(), when checking addrs in a while loop, after
> > > get the addr len according to sa_fa
From: Nicolas Morey-Chaisemartin
[ Upstream commit a4cb5bdb754afe21f3e9e7164213e8600cf69427 ]
Make sure the device has at least 2 completion vectors
before allocating to compvec#1
Fixes: a4699f5647f3 (xprtrdma: Put Send CQ in IB_POLL_WORKQUEUE mode)
Signed-off-by: Nicolas Morey-Chaisemartin
Re
On Sun, Mar 10, 2019 at 07:08:20AM +, Al Viro wrote:
> From: Al Viro
>
> Signed-off-by: Al Viro
Looks sensible, but a changelog would be nice.
> if (iocb->aio_flags & IOCB_FLAG_RESFD) {
> + struct eventfd_ctx *eventfd;
> /*
>* If the IOCB_FLA
On Mon 11-03-19 20:31:12, Martynas Pumputis wrote:
> It has been observed that sometimes a higher order memory allocation
> for BPF maps fails when there is no obvious memory pressure in a system.
>
> E.g. the map (BPF_MAP_TYPE_LRU_HASH, key=38, value=56, max_elems=524288)
> could not be created d
It has been observed that sometimes a higher order memory allocation
for BPF maps fails when there is no obvious memory pressure in a system.
E.g. the map (BPF_MAP_TYPE_LRU_HASH, key=38, value=56, max_elems=524288)
could not be created due to vmalloc unable to allocate 75497472B,
when the system's
> Applied and queued up for -stable, thanks.
Thanks David
From: David Miller
Date: Mon, 11 Mar 2019 12:18:12 -0700 (PDT)
> From:
> Date: Mon, 11 Mar 2019 18:50:27 +
>
>> In this case the function lan743x_rx_init_ring_element does not assume that
>> new_skb is not NULL. It does check for NULL and returns error in that case.
>
> Aha, I see, thanks
From:
Date: Mon, 11 Mar 2019 18:50:27 +
> In this case the function lan743x_rx_init_ring_element does not assume that
> new_skb is not NULL. It does check for NULL and returns error in that case.
Aha, I see, thanks for pointing that out and correcting me. Let me
review this some more.
On Mon, Mar 11, 2019 at 07:13:14PM +0800, Jason Yan wrote:
>
>
> On 2019/3/11 17:41, Daniel Borkmann wrote:
> > Hi Jason,
> >
> > On 03/11/2019 10:18 AM, Jason Yan wrote:
> > > Hi, Daniel & Greg
> > >
> > > This patch (979d63d50c0c bpf: prevent out of bounds speculation on
> > > pointer arithm
> -Original Message-
> From: David Miller
> Sent: Monday, March 11, 2019 2:37 PM
> To: Bryan Whitehead - C21958
> Cc: netdev@vger.kernel.org; UNGLinuxDriver
>
> Subject: Re: [PATCH v2 net] lan743x: Fix RX Kernel Panic
>
> From: Bryan Whitehead
> Date: Mon, 11 Mar 2019 13:39:39 -0400
>
From: Roi Dayan
The function is not being used.
Signed-off-by: Roi Dayan
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/lag.c | 21 ---
.../ethernet/mellanox/mlx5/core/mlx5_core.h | 2 --
2 files changed, 23 deletions(-)
diff --git a/drivers/net/
From: Tariq Toukan
In case number of channels is changed while interface is down,
RSS indirection table is mistakenly not modified accordingly,
causing access to out-of-range non-existing object.
Fix by updating the RSS indireciton table also in the early
return flow of interface down.
Fixes: f
From: Eli Britstein
Add modify FTE helper function and use it when deleting a rule, as a
pre-step towards consolidated FTE modification, with no functional
change.
Signed-off-by: Eli Britstein
Reviewed-by: Maor Gottlieb
Reviewed-by: Mark Bloch
Signed-off-by: Saeed Mahameed
---
.../net/ether
From: Tonghao Zhang
If we try to set VFs rate on a VF (not PF) net device, the kernel
will be crash. The commands are show as below:
$ echo 2 > /sys/class/net/$MLX_PF0/device/sriov_numvfs
$ ip link set $MLX_VF0 vf 0 max_tx_rate 2 min_tx_rate 1
If not applied the first patch ("net/mlx5: Avoid pa
From: Roi Dayan
Currently, we fail to retrieve the PF number in some cases (e.g
single ported cards, lag capability), this further results in a
call trace issued by the rtnetlink code, since the error value
is not -EOPNOTSUPP. Change the implementation to be independent
from the lag code and func
From: Eli Britstein
There might be a condition where the fte found is not active yet. In
this case we should not use it, but continue to search for another, or
allocate a new one.
Fixes: bd71b08ec2ee ("net/mlx5: Support multiple updates of steering rules in
parallel")
Signed-off-by: Eli Britste
From: Eli Britstein
With commit a18e879d4e45 ("net/mlx5e: Annul encap action ordering
requirement") and a use-case of e-switch remote mirroring, the
incremental/stepped FTE removal process done by the fs core got us to
illegal transient states and FW errors:
SET_FLOW_TABLE_ENTRY(0x936) op_mod(0x
Hi Dave,
This series introduces some fixes to mlx5 driver.
For more information please see tag log below.
Please pull and let me know if there is any problem.
For -stable v5.0:
('net/mlx5e: Fix access to non-existing receive queue')
('net/mlx5e: Properly get the PF number phys port name ndo')
('
From: Tonghao Zhang
If we try to set VFs mac address on a VF (not PF) net device,
the kernel will be crash. The commands are show as below:
$ echo 2 > /sys/class/net/$MLX_PF0/device/sriov_numvfs
$ ip link set $MLX_VF0 vf 0 mac 00:11:22:33:44:00
[exception RIP: mlx5_eswitch_set_vport_mac+41]
[ff
From: Feras Daoud
Update the RX checksum only if the feature is enabled.
Fixes: 9d6bd752c63c ("net/mlx5e: IPoIB, RX handler")
Signed-off-by: Feras Daoud
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 11 ---
1 file changed, 8 insertions(+), 3 delet
From: Eli Britstein
Add a locked flag to the node removal functions to signal if the
parent is already locked from the caller function or not as a pre-step
towards outside lock. Currently always use false with no functional
change.
Signed-off-by: Eli Britstein
Reviewed-by: Maor Gottlieb
Review
From: Bryan Whitehead
Date: Mon, 11 Mar 2019 13:39:39 -0400
> @@ -2290,7 +2306,9 @@ static int lan743x_rx_ring_init(struct lan743x_rx *rx)
>
> rx->last_head = 0;
> for (index = 0; index < rx->ring_size; index++) {
> - ret = lan743x_rx_allocate_ring_element(rx, index);
>
From: Sudarsana Reddy Kalluru
Date: Mon, 11 Mar 2019 05:37:22 -0700
> The patch series adds couple of enhancements for qed/qede drivers.
> Please consider applying it to 'net-next' tree.
You Marvell guys should know how the net-next tree works by now.
I announced it was closed for the merge win
On 3/11/19 11:04 AM, Marc Kleine-Budde wrote:
> On 3/11/19 1:23 PM, Marc Kleine-Budde wrote:
>> Hello,
>>
>> I'm on next-next/master and noticed that the following patch:
>>
>> | 13d0ab6750b2 net: phy: check return code when requesting PHY
>> | driver module
>>
>> breaks NFS Root for m
On 3/11/19 1:23 PM, Marc Kleine-Budde wrote:
> Hello,
>
> I'm on next-next/master and noticed that the following patch:
>
> | 13d0ab6750b2 net: phy: check return code when requesting PHY
> | driver module
>
> breaks NFS Root for my embedded device (riotboard). The kernel dhcp
> fail
It has been noticed that running the speed test at
www.speedtest.net occasionally causes a kernel panic.
Investigation revealed that under this test RX buffer allocation
sometimes fails and returns NULL. But the lan743x driver did
not handle this case.
This patch fixes this issue by attempting to
On Mon, Mar 11, 2019 at 10:27 AM Edward Cree wrote:
>
> On 11/03/19 16:34, Andrii Nakryiko wrote:
> > The only thing we should consider is that enums can have different
> > sizes. And enum size is part of enum's forward declaration. So unlike
> > struct/union fwd, enum's fwd has extra info. I don'
On 11/03/19 16:34, Andrii Nakryiko wrote:
> The only thing we should consider is that enums can have different
> sizes. And enum size is part of enum's forward declaration. So unlike
> struct/union fwd, enum's fwd has extra info. I don't think it's
> possible to specify in C (enum is always 4 bytes
On Mon, Mar 11, 2019 at 5:54 PM Andrii Nakryiko
wrote:
>
> On Mon, Mar 11, 2019 at 7:52 AM Magnus Karlsson
> wrote:
> >
> > In xsk_socket__create(), the libbpf_flags field was not checked for
> > setting currently unused/unknown flags. This patch fixes that by returning
> > -EINVAL if the user ha
On Mon, Mar 11, 2019 at 7:52 AM Magnus Karlsson
wrote:
>
> In xsk_socket__create(), the libbpf_flags field was not checked for
> setting currently unused/unknown flags. This patch fixes that by returning
> -EINVAL if the user has set any flag that is not in use at this point
> in time.
>
> Fixes:
On Mon, Mar 11, 2019 at 12:02 AM Yonghong Song wrote:
>
>
>
> On 3/10/19 5:44 PM, Andrii Nakryiko wrote:
> > GCC and clang support enum forward declarations as an extension. Such
> > forward-declared enums will be represented as normal BTF_KIND_ENUM types
> > with
> > vlen=0. This patch adds abil
> In the second and third hunk, you have to check lan743x_rx_allocate_skb()
> for NULL too and act accordingly.
OK David,
I'll work on it.
Bryan
On 03/11/2019 09:03 AM, Eric Dumazet wrote:
>
>
> On 03/11/2019 08:14 AM, Olga Albisser wrote:
>
>> +
>> +static u32 get_ecn_field(struct sk_buff *skb)
>> +{
>> +switch (skb->protocol) {
>
> tc_skb_protocol(skb)
>
>> +case cpu_to_be16(ETH_P_IP):
>
> Theoretically you have to use ps
On 03/11/2019 09:00 AM, Olga Albisser wrote:
> Hi Eric,
>
> I thought the window opened roughly a week ago, and would be open for another
> week (since it's 2 weeks in total), have I misunderstood?
Yes, you have misunderstood.
When Linus opens his window, it is the time for maintainers to pu
On 03/11/2019 08:14 AM, Olga Albisser wrote:
> +
> +static u32 get_ecn_field(struct sk_buff *skb)
> +{
> + switch (skb->protocol) {
tc_skb_protocol(skb)
> + case cpu_to_be16(ETH_P_IP):
Theoretically you have to use pskb_may_pull() before assuming network header is
in the linear part
a/net/tls/tls_main.c b/net/tls/tls_main.c index
7e05af75536d..11c1980a75cb 100644
--- a/net/tls/tls_main.c
+++ b/net/tls/tls_main.c
@@ -212,7 +212,7 @@ int tls_push_partial_record(struct sock *sk,
struct tls_context *ctx,
static void tls_write_space(struct sock
FYI, net-next tree is currently closed.
On 03/11/2019 08:14 AM, Olga Albisser wrote:
> DUALPI2 provides extremely low latency & loss to traffic that uses a
> scalable congestion controller (e.g. L4S, DCTCP) without degrading the
> performance of 'classic' traffic (e.g. Reno, Cubic etc.). It is int
DUALPI2 provides extremely low latency & loss to traffic that uses a
scalable congestion controller (e.g. L4S, DCTCP) without degrading the
performance of 'classic' traffic (e.g. Reno, Cubic etc.). It is intended
to be the reference implementation of the IETF's DualQ Coupled AQM.
The qdisc provide
> -Original Message-
> From: Boris Pismenny
> Sent: Tuesday, February 26, 2019 7:43 PM
> To: Vakul Garg ; Aviad Yehezkel
> ; davejwat...@fb.com;
> john.fastab...@gmail.com; dan...@iogearbox.net; netdev@vger.kernel.org
> Cc: Eran Ben Elisha
> Subject: Re: [PATCH net 2/4] tls: Fix write s
In xsk_socket__create(), the libbpf_flags field was not checked for
setting currently unused/unknown flags. This patch fixes that by returning
-EINVAL if the user has set any flag that is not in use at this point
in time.
Fixes: 1cad07884239 ("libbpf: add support for using AF_XDP sockets")
Signed-
On Thu, Mar 07, 2019 at 01:30:37PM -0800, Alexei Starovoitov wrote:
> On Tue, Mar 05, 2019 at 09:03:57PM -0500, Kris Van Hees wrote:
> >
> > So in summary, I am trying to solve two (related) problems:
> >
> > - Ensure that unprivileged tracing can obtain information about the task
> > that
> >
On Mon, Mar 11, 2019 at 9:23 AM Kai-Heng Feng
wrote:
>
> [snipped]
>
> Hi again,
>
> Any update?
>
> Kai-Heng
Sorry for the late reply. We will provide our feedback soon.
The patch introduces a new Multi-Function bit for cases where firmware
shouldn't perform the insertion of vlan-0 tag. The new bit is defined to
abstract the implementation from the actual MF mode.
Signed-off-by: Sudarsana Reddy Kalluru
Signed-off-by: Ariel Elior
Signed-off-by: Michal Kalderon
-
The patch series adds couple of enhancements for qed/qede drivers.
Please consider applying it to 'net-next' tree.
Sudarsana Reddy Kalluru (2):
qede: Populate mbi version in ethtool driver query data.
qed: Define new MF bit for no_vlan config
drivers/net/ethernet/qlogic/qed/qed.h |
The patch adds support to display MBI image version in 'ethtool -i' output.
Signed-off-by: Sudarsana Reddy Kalluru
Signed-off-by: Ariel Elior
Signed-off-by: Michal Kalderon
---
drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 24 +++-
1 file changed, 19 insertions(+), 5 de
Hello,
I'm on next-next/master and noticed that the following patch:
| 13d0ab6750b2 net: phy: check return code when requesting PHY
| driver module
breaks NFS Root for my embedded device (riotboard). The kernel dhcp
fails to get an address and thus no NFS Root.
> [1.869897] mdi
On Sat, 9 Mar 2019 at 05:28, Martin Lau wrote:
>
> On Wed, Mar 06, 2019 at 03:59:40PM +, Lorenz Bauer wrote:
> > On Mon, 4 Mar 2019 at 17:43, Martin Lau wrote:
> > >
> > > On Mon, Mar 04, 2019 at 10:33:46AM +0100, Daniel Borkmann wrote:
> > > > On 03/02/2019 09:21 PM, Martin Lau wrote:
> > >
On 2019/3/11 17:41, Daniel Borkmann wrote:
Hi Jason,
On 03/11/2019 10:18 AM, Jason Yan wrote:
Hi, Daniel & Greg
This patch (979d63d50c0c bpf: prevent out of bounds speculation on pointer
arithmetic) was assigned a CVE (CVE-2019-7308) with a high score:
CVSS v3.0 Severity and Metrics:
Base
It is confusing to directly use return value of netlink_send()/
netlink_unicast() as the return value of *notify*, as it may be not
error at all.
Example: in tc_del_tfilter(), after calling tfilter_del_notify(), it will
goto errout if (err). However, the netlink_send()/netlink_unicast() will
retur
On 03/09/2019 12:58 AM, Andrii Nakryiko wrote:
> This patch splits and cleans up error handling logic for loading BTF data.
> Previously, if BTF data was parsed successfully, but failed to load into
> kernel, we'd report nonsensical error code, instead of error returned from
> btf__load(). Now btf_
Hi Jason,
On 03/11/2019 10:18 AM, Jason Yan wrote:
> Hi, Daniel & Greg
>
> This patch (979d63d50c0c bpf: prevent out of bounds speculation on pointer
> arithmetic) was assigned a CVE (CVE-2019-7308) with a high score:
>
> CVSS v3.0 Severity and Metrics:
> Base Score: 9.8 CRITICAL
>
> And this
Hi, Daniel & Greg
This patch (979d63d50c0c bpf: prevent out of bounds speculation on
pointer arithmetic) was assigned a CVE (CVE-2019-7308) with a high score:
CVSS v3.0 Severity and Metrics:
Base Score: 9.8 CRITICAL
And this patch is not in stable-4.4, would you please backport this
patch to
Fri, Mar 08, 2019 at 08:09:43PM CET, jakub.kicin...@netronome.com wrote:
>On Fri, 8 Mar 2019 15:54:21 +0100, Jiri Pirko wrote:
>> Fri, Mar 08, 2019 at 03:52:02AM CET, jakub.kicin...@netronome.com wrote:
>> >On Thu, 7 Mar 2019 10:48:16 +0100, Jiri Pirko wrote:
>> >> Wed, Mar 06, 2019 at 06:56:38PM
Hi Klaus,
Thanks for reporting this.
On 09.03.2019 07:50, Harini Katakam wrote:
> Hi Klaus,
>
>> -Original Message-
>> From: Klaus Doth [mailto:k...@doth.eu]
>> Sent: Friday, March 8, 2019 10:19 PM
>> To: netdev@vger.kernel.org
>> Cc: da...@davemloft.net; claudiu.bez...@microchip.com; Ha
1 - 100 of 101 matches
Mail list logo
