In esp4_gro_receive() and esp6_gro_receive(), secpath can be allocated
without adding xfrm state to xvec. Then, sp->xvec[sp->len - 1] would
fail and result in dereferencing invalid pointer in esp4_gso_segment()
and esp6_gso_segment(). Reset secpath if xfrm function returns error.
Reported-by: syzb
From: YueHaibing
register_snap_client may return NULL, all the callers
check it, but only print a warning. This will result in
NULL pointer dereference in unregister_snap_client and other
places.
It has always been used like this since v2.6
Reported-by: Dan Carpenter
Signed-off-by: YueHaibing
On Tue, Mar 05, 2019 at 11:15:06PM -0800, si-wei liu wrote:
>
>
> On 3/5/2019 10:43 PM, Michael S. Tsirkin wrote:
> > On Tue, Mar 05, 2019 at 04:51:00PM -0800, si-wei liu wrote:
> > >
> > > On 3/5/2019 4:36 PM, Michael S. Tsirkin wrote:
> > > > On Tue, Mar 05, 2019 at 04:20:50PM -0800, si-wei li
Signed-off-by: Jason Wang
---
drivers/vhost/vhost.c | 46 --
1 file changed, 28 insertions(+), 18 deletions(-)
diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index 2025543..1015464 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhos
This series tries to access virtqueue metadata through kernel virtual
address instead of copy_user() friends since they had too much
overheads like checks, spec barriers or even hardware feature
toggling. This is done through setup kernel address through vmap() and
resigter MMU notifier for invalid
It was noticed that the copy_user() friends that was used to access
virtqueue metdata tends to be very expensive for dataplane
implementation like vhost since it involves lots of software checks,
speculation barrier, hardware feature toggling (e.g SMAP). The
extra cost will be more obvious when tra
Rename the function to be more accurate since it actually tries to
prefetch vq metadata address in IOTLB. And this will be used by
following patch to prefetch metadata virtual addresses.
Signed-off-by: Jason Wang
---
drivers/vhost/net.c | 4 ++--
drivers/vhost/vhost.c | 4 ++--
drivers/vhost/v
Use one generic vhost_copy_to_user() instead of two dedicated
accessor. This will simplify the conversion to fine grain
accessors. About 2% improvement of PPS were seen during vitio-user
txonly test.
Signed-off-by: Jason Wang
---
drivers/vhost/vhost.c | 11 +--
1 file changed, 1 insertio
This is used to hide the metadata address from virtqueue helpers. This
will allow to implement a vmap based fast accessing to metadata.
Signed-off-by: Jason Wang
---
drivers/vhost/vhost.c | 94 +--
1 file changed, 77 insertions(+), 17 deletions(-)
This patches uses bpf_program__get_prog_info_linear() to simplify the
logic in prog.c do_dump().
Cc: Daniel Borkmann
Cc: Alexei Starovoitov
Signed-off-by: Song Liu
---
tools/bpf/bpftool/prog.c | 266 +--
1 file changed, 59 insertions(+), 207 deletions(-)
di
Currently, bpf_prog_info includes 9 arrays. The user has the option to
fetch any combination of these arrays. However, this requires a lot of
handling of these arrays. This work becomes more tricky when we need to
store bpf_prog_info to a file, because these arrays are allocated
independently.
Thi
Events with bpf_event should be considered as side-band event, as they
carry information about BPF programs.
Fixes: 6ee52e2a3fe4 ("perf, bpf: Introduce PERF_RECORD_BPF_EVENT")
Signed-off-by: Song Liu
---
kernel/events/core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/k
With bpf_program__get_prog_info_linear, we can simplify the logic that
synthesizes bpf events.
This patch doesn't change the behavior of the code.
Signed-off-by: Song Liu
---
tools/perf/util/bpf-event.c | 118
1 file changed, 40 insertions(+), 78 deletions(-
This patch enables the annotation of bpf program.
A new dso type DSO_BINARY_TYPE__BPF_PROG_INFO is introduced to for BPF
programs. In symbol__disassemble(), DSO_BINARY_TYPE__BPF_PROG_INFO dso
calls into a new function symbol__disassemble_bpf(), where annotation
line information is filled based bpf
btf contains information necessary to annotate bpf programs. This patch
saves btf for bpf programs loaded in the system.
Signed-off-by: Song Liu
---
tools/perf/util/bpf-event.c | 23 +
tools/perf/util/bpf-event.h | 7
tools/perf/util/env.c | 65 +++
This patch enables perf-record to save bpf_prog_info information as
headers to perf.data. A new header type HEADER_BPF_PROG_INFO is
introduced for this data.
Signed-off-by: Song Liu
---
tools/perf/util/header.c | 149 ++-
tools/perf/util/header.h | 1 +
2 fi
This patch changes the arguments of perf_event__synthesize_bpf_events()
to include perf_session* instead of perf_tool*. perf_session will be used
in the next patch.
Signed-off-by: Song Liu
---
tools/perf/builtin-record.c | 2 +-
tools/perf/builtin-top.c| 2 +-
tools/perf/util/bpf-event.c | 8
bpf events should be tracked by default for perf-top. This patch makes it
on by default, and adds option to disable bpf events.
Signed-off-by: Song Liu
---
tools/perf/builtin-top.c | 3 +++
tools/perf/util/top.h| 1 +
2 files changed, 4 insertions(+)
diff --git a/tools/perf/builtin-top.c b/
On 3/5/2019 10:43 PM, Michael S. Tsirkin wrote:
On Tue, Mar 05, 2019 at 04:51:00PM -0800, si-wei liu wrote:
On 3/5/2019 4:36 PM, Michael S. Tsirkin wrote:
On Tue, Mar 05, 2019 at 04:20:50PM -0800, si-wei liu wrote:
On 3/5/2019 4:06 PM, Michael S. Tsirkin wrote:
On Tue, Mar 05, 2019 at 11:
bpf_prog_info contains information necessary to annotate bpf programs.
This patch saves bpf_prog_info for bpf programs loaded in the system.
Some big picture of the next few patches:
To fully annotate BPF programs with source code mapping, 4 different
information are needed:
1) PERF_RECORD_KS
Both libbfd and libopcodes are distributed with binutil-dev/devel. When
libbfd presents, it is OK to assume libopcodes also presents. This has
been a safe assumption for bpftool.
This patch adds -lopcodes to perf/Makefile.config. libopcodes will be
used in the next commit for bpf annotation.
Sign
To fully annotate BPF programs with source code mapping, 4 different
information are needed:
1) PERF_RECORD_KSYMBOL
2) PERF_RECORD_BPF_EVENT
3) bpf_prog_info
4) btf
This patch handles 3) and 4) for short living BPF programs. For timely
process of these information, a dedicated even
This patch introduces side band thread that captures extended information
for events like PERF_RECORD_BPF_EVENT.
This new thread uses its own evlist that uses ring buffer with very low
watermark for lower latency.
To use side band thread, we need to:
1. add side band event(s) by calling perf_evl
This patch adds processing of PERF_BPF_EVENT_PROG_LOAD, which sets proper
DSO type/id/etc of memory regions mapped to BPF programs to
DSO_BINARY_TYPE__BPF_PROG_INFO
Signed-off-by: Song Liu
---
tools/perf/util/bpf-event.c | 53 +
1 file changed, 53 insertions(+
This patch enables perf-record to save btf information as headers to
perf.data A new header type HEADER_BPF_BTF is introduced for this data.
Signed-off-by: Song Liu
---
tools/perf/util/header.c | 111 ++-
tools/perf/util/header.h | 1 +
2 files changed, 111
Changes v5 to v6:
1. Improve side band evlist interface;
2. Minor style fixes.
Changes v4 to v5:
1. Rebase to latest bpf-next;
2. Add dependency of 94816add0005 from Arnaldo's tree;
3. More details in change logs;
4. Add perf_env__init() to init bpf related lock and rbtrees;
5. Small clean ups.
C
proc_exit_connector() uses ->real_parent lockless. This is not
safe that its parent can go away at any moment, so use RCU to
protect it, and ensure that this task is not released.
[ 747.624551]
==
[ 747.632946] BUG: KASAN: use-afte
On Tue, Mar 05, 2019 at 04:51:00PM -0800, si-wei liu wrote:
>
>
> On 3/5/2019 4:36 PM, Michael S. Tsirkin wrote:
> > On Tue, Mar 05, 2019 at 04:20:50PM -0800, si-wei liu wrote:
> > >
> > > On 3/5/2019 4:06 PM, Michael S. Tsirkin wrote:
> > > > On Tue, Mar 05, 2019 at 11:35:50AM -0800, si-wei liu
Hi Kirti,
> -Original Message-
> From: Kirti Wankhede
> Sent: Tuesday, March 5, 2019 9:51 PM
> To: Parav Pandit ; Jakub Kicinski
>
> Cc: Or Gerlitz ; netdev@vger.kernel.org; linux-
> ker...@vger.kernel.org; michal.l...@markovi.net; da...@davemloft.net;
> gre...@linuxfoundation.org; Jiri
On 2019/3/6 0:48, Gerd Rausch wrote:
Hi Santosh,
On 05/03/2019 08.41, Santosh Shilimkar wrote:
On 3/5/2019 8:33 AM, Gerd Rausch wrote:
If there's a mechanism that ensures compatibility with older (pre-4.1) versions
of RDS I am not seeing it.
Thats handled as part of the connection reject ha
vxlan_cleanup() is a timer callback, it is already
and only running in BH context.
Signed-off-by: Litao Jiao
---
drivers/net/vxlan.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index 2aae11f..98dde11 100644
--- a/drivers/net/v
Hello,
syzbot found the following crash on:
HEAD commit:d9862cfbe209 Merge tag 'mips_5.1' of git://git.kernel.org/..
git tree: net
console output: https://syzkaller.appspot.com/x/log.txt?x=10dfb0e720
kernel config: https://syzkaller.appspot.com/x/.config?x=73d88a42238825ad
dashboa
On 3/6/2019 6:14 AM, Parav Pandit wrote:
> Hi Greg, Kirti,
>
>> -Original Message-
>> From: Parav Pandit
>> Sent: Tuesday, March 5, 2019 5:45 PM
>> To: Parav Pandit ; Kirti Wankhede
>> ; Jakub Kicinski
>> Cc: Or Gerlitz ; netdev@vger.kernel.org; linux-
>> ker...@vger.kernel.org; michal
On 2019/3/6 上午5:33, Willem de Bruijn wrote:
On Tue, Mar 5, 2019 at 4:03 PM Arthur Kepner wrote:
The attachment contains an UNTESTED patch (though a similar patch was tested
with a
3.10 kernel).
We've been chasing a bug where packet corruption is seen on a tap device. We
have a
PACKET_MMAP
From: Jian Shen
HW can not guarantee complete write desc->rx.size, even though
HNS3_RXD_VLD_B has been set. Driver needs to add dma_rmb()
instruction to make sure desc->rx.size is always valid.
Fixes: e55970950556 ("net: hns3: Add handling of GRO Pkts not fully RX'ed in
NAPI poll")
Signed-off-b
From: Saeed Mahameed
Date: Tue, 5 Mar 2019 22:21:39 +
> On Mon, 2019-03-04 at 08:26 +0200, Leon Romanovsky wrote:
>> On Sun, Mar 03, 2019 at 03:20:57PM +, Roi Dayan wrote:
>> >
>> > On 02/03/2019 21:39, Gustavo A. R. Silva wrote:
>> > > Remove redundant assignment to tun_entropy->enabled
Hello,
syzbot found the following crash on:
HEAD commit:63bdf4284c38 Merge branch 'linus' of git://git.kernel.org/..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=112c679f20
kernel config: https://syzkaller.appspot.com/x/.config?x=872be05707464aaa
da
On Tue, Mar 05, 2019 at 10:59:52AM -0800, Alexei Starovoitov wrote:
> On Tue, Feb 26, 2019 at 01:46:01AM -0500, Kris Van Hees wrote:
> > On Mon, Feb 25, 2019 at 10:18:25PM -0800, Alexei Starovoitov wrote:
> > > On Mon, Feb 25, 2019 at 07:54:13AM -0800, Kris Van Hees wrote:
> > > >
> > > > The goal
Hello,
syzbot found the following crash on:
HEAD commit:63bdf4284c38 Merge branch 'linus' of git://git.kernel.org/..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=100347cb20
kernel config: https://syzkaller.appspot.com/x/.config?x=872be05707464aaa
da
On 3/5/2019 4:36 PM, Michael S. Tsirkin wrote:
On Tue, Mar 05, 2019 at 04:20:50PM -0800, si-wei liu wrote:
On 3/5/2019 4:06 PM, Michael S. Tsirkin wrote:
On Tue, Mar 05, 2019 at 11:35:50AM -0800, si-wei liu wrote:
On 3/5/2019 11:24 AM, Stephen Hemminger wrote:
On Tue, 5 Mar 2019 11:19:32
Hi Greg, Kirti,
> -Original Message-
> From: Parav Pandit
> Sent: Tuesday, March 5, 2019 5:45 PM
> To: Parav Pandit ; Kirti Wankhede
> ; Jakub Kicinski
> Cc: Or Gerlitz ; netdev@vger.kernel.org; linux-
> ker...@vger.kernel.org; michal.l...@markovi.net; da...@davemloft.net;
> gre...@linuxf
On Tue, Mar 05, 2019 at 04:20:50PM -0800, si-wei liu wrote:
>
>
> On 3/5/2019 4:06 PM, Michael S. Tsirkin wrote:
> > On Tue, Mar 05, 2019 at 11:35:50AM -0800, si-wei liu wrote:
> > >
> > > On 3/5/2019 11:24 AM, Stephen Hemminger wrote:
> > > > On Tue, 5 Mar 2019 11:19:32 -0800
> > > > si-wei liu
On Mon, Mar 4, 2019 at 12:40 PM Arnd Bergmann wrote:
>
> The label is only used from inside the #ifdef and should be
> hidden the same way, to avoid this warning:
>
> net/sched/act_tunnel_key.c: In function 'tunnel_key_init':
> net/sched/act_tunnel_key.c:389:1: error: label 'release_tun_meta' defi
On 3/5/2019 2:52 PM, Gregory Rose wrote:
I have an i386 Ubuntu 18 VM to test this on. I'll investigate and see
what I can find.
- Greg
I have a repro. It's not the same kernel (4.13 in my case) but looks
like the same issue.
- Greg
On 3/5/2019 4:06 PM, Michael S. Tsirkin wrote:
On Tue, Mar 05, 2019 at 11:35:50AM -0800, si-wei liu wrote:
On 3/5/2019 11:24 AM, Stephen Hemminger wrote:
On Tue, 5 Mar 2019 11:19:32 -0800
si-wei liu wrote:
I have a vague idea: would it work to *not* set
IFF_UP on slave devices at all?
H
On Tue, Mar 05, 2019 at 11:35:50AM -0800, si-wei liu wrote:
>
>
> On 3/5/2019 11:24 AM, Stephen Hemminger wrote:
> > On Tue, 5 Mar 2019 11:19:32 -0800
> > si-wei liu wrote:
> >
> > > > I have a vague idea: would it work to *not* set
> > > > IFF_UP on slave devices at all?
> > > Hmm, I ever thou
> -Original Message-
> From: linux-kernel-ow...@vger.kernel.org ow...@vger.kernel.org> On Behalf Of Parav Pandit
> Sent: Tuesday, March 5, 2019 5:17 PM
> To: Kirti Wankhede ; Jakub Kicinski
>
> Cc: Or Gerlitz ; netdev@vger.kernel.org; linux-
> ker...@vger.kernel.org; michal.l...@markovi
Hi Kirti,
> -Original Message-
> From: Kirti Wankhede
> Sent: Tuesday, March 5, 2019 4:40 PM
> To: Parav Pandit ; Jakub Kicinski
>
> Cc: Or Gerlitz ; netdev@vger.kernel.org; linux-
> ker...@vger.kernel.org; michal.l...@markovi.net; da...@davemloft.net;
> gre...@linuxfoundation.org; Jiri
On 3/5/2019 11:58 AM, Joe Stringer wrote:
On Tue, Mar 5, 2019 at 2:12 AM Christian Ehrhardt
wrote:
On Tue, Mar 5, 2019 at 10:58 AM Juerg Haefliger
wrote:
Hi,
Running the following commands in a loop will crash an i386 5.0 kernel
typically within a few iterations:
ovs-vsctl add-br test
ovs
On 3/5/2019 12:28 PM, Michael S. Tsirkin wrote:
On Tue, Mar 05, 2019 at 11:19:32AM -0800, si-wei liu wrote:
On 3/4/2019 6:33 PM, Michael S. Tsirkin wrote:
On Mon, Mar 04, 2019 at 07:50:59PM -0500, Si-Wei Liu wrote:
When a netdev appears through hot plug then gets enslaved by a failover
mas
This patch adds the bpf_progenyof helper which receives a PID and returns
1 if the process currently being executed is in the process hierarchy
including itself or 0 if not.
This is very useful in tracing programs when we want to filter by a
given PID and all the children it might spawn. The curre
Sync kernel uapi headers.
Signed-off-by: Javier Honduvilla Coto
---
tools/include/uapi/linux/bpf.h | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h
index 3c38ac9a92a7..f72741766ba8 100644
--- a/tools/inclu
Adding the following test cases:
- progenyof(current->pid) == 1
- progenyof(current->real_parent->pid) == 1
- progenyof(1) == 1
- progenyof(0) == 1
- progenyof(-1) == 0
- progenyof(current->children[0]->pid) == 0
Signed-off-by: Javier Honduvilla Coto
---
tools/testing/selftests/bpf/.gitignore
Hi all,
This patch add the bpf_progenyof helper which receives a PID and returns
1 if the process currently being executed is in the process hierarchy,
including itself or 0 if not.
This is very useful in tracing programs when we want to filter by a
given PID and all the children it might have. T
On 3/6/2019 1:16 AM, Parav Pandit wrote:
>
>
>> -Original Message-
>> From: Jakub Kicinski
>> Sent: Monday, March 4, 2019 7:35 PM
>> To: Parav Pandit
>> Cc: Or Gerlitz ; netdev@vger.kernel.org; linux-
>> ker...@vger.kernel.org; michal.l...@markovi.net; da...@davemloft.net;
>> gre...@
On Mon, 2019-03-04 at 08:26 +0200, Leon Romanovsky wrote:
> On Sun, Mar 03, 2019 at 03:20:57PM +, Roi Dayan wrote:
> >
> > On 02/03/2019 21:39, Gustavo A. R. Silva wrote:
> > > Remove redundant assignment to tun_entropy->enabled.
> > >
> > > Addesses-Coverity-ID: 1477328 ("Unused value")
> >
On Mon, Mar 04, 2019 at 06:11:07PM -0800, Jakub Kicinski wrote:
> > At least in RDMA we have drivers doing all combinations of this:
> > multiple ports per BDF, one port per BDF, and one composite RDMA
> > device formed by combining multiple BDFs worth of ports together.
>
> Right, last but not l
On Mon, 2019-03-04 at 15:52 +, Roi Dayan wrote:
>
> On 04/03/2019 10:27, xiangxia.m@gmail.com wrote:
> > From: Tonghao Zhang
> >
> > If we try to set VFs mac address on a VF (not PF) net device,
> > the kernel will be crash. The commands are show as below:
> >
> > $ echo 2 > /sys/class/
On Mon, 2019-03-04 at 15:55 +, Roi Dayan wrote:
>
> On 04/03/2019 10:27, xiangxia.m@gmail.com wrote:
> > From: Tonghao Zhang
> >
> > If we try to set VFs rate on a VF (not PF) net device, the kernel
> > will be crash. The commands are show as below:
> >
> > $ echo 2 > /sys/class/net/$ML
> -Original Message-
> From: Greg KH
> Sent: Tuesday, March 5, 2019 1:27 PM
> To: Parav Pandit
> Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org;
> michal.l...@markovi.net; da...@davemloft.net; Jiri Pirko
> ; Jakub Kicinski
> Subject: Re: [RFC net-next 8/8] net/mlx5: Add subd
On Tue, Mar 5, 2019 at 4:03 PM Arthur Kepner wrote:
>
>
> The attachment contains an UNTESTED patch (though a similar patch was tested
> with a
> 3.10 kernel).
>
> We've been chasing a bug where packet corruption is seen on a tap device. We
> have a
> PACKET_MMAP socket which is bound to a tap i
On Mon, Mar 4, 2019 at 4:28 PM Peter Oskolkov wrote:
>
> This is a small fix and a test. Sent to net-next because
> the offending patch is not in net yet.
For the set:
Acked-by: Song Liu
>
> Peter Oskolkov (2):
> net: fix GSO in bpf_lwt_push_ip_encap
> selftests/bpf: test that GSO works in
The attachment contains an UNTESTED patch (though a similar patch was tested
with a
3.10 kernel).
We've been chasing a bug where packet corruption is seen on a tap device. We
have a
PACKET_MMAP socket which is bound to a tap interface. When throughput goes
above a
threshold, we begin to se
On Mon, Mar 4, 2019 at 5:25 PM Daniel T. Lee wrote:
>
> This commit adds xdp_sample_pkts to .gitignore which is
> currently ommited from the ignore file.
>
> Signed-off-by: Daniel T. Lee
I think this is for bpf-next tree, which is closed during the merge window.
Please resubmit when the tree reo
From: Paolo Abeni
Date: Tue, 5 Mar 2019 13:49:39 +0100
> If a non local multicast packet reaches ip_route_input_rcu() while
> the ingress device is NULL, we end up doing a NULL pointer
> dereference in IN_DEV_MFORWARD().
>
> Since the later call to ip_route_input_mc() is going to fail if
> !in_
From: we...@ucloud.cn
Date: Tue, 5 Mar 2019 08:29:28 +0800
> From: wenxu
>
> dst_cache_destroy will be called in dst_release
>
> dst_release-->dst_destroy_rcu-->dst_destroy-->metadata_dst_free
> -->dst_cache_destroy
>
> It should not call dst_cache_destroy before dst_release
>
> Fixes: 41411
On Tue, Mar 5, 2019 at 9:41 AM Colin King wrote:
>
> From: Colin Ian King
>
> There are a couple of typos, fix these.
>
> Signed-off-by: Colin Ian King
I guess this could go to bpf tree.
Acked-by: Song Liu
> ---
> samples/bpf/hbm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-
From: Jon Maloy
Date: Mon, 4 Mar 2019 23:26:10 +0100
> From: Erik Hugne
>
> Fix regression bug introduced in
> commit 365ad353c256 ("tipc: reduce risk of user starvation during link
> congestion")
>
> Only signal -EDESTADDRREQ for RDM/DGRAM if we don't have a cached
> sockaddr.
>
> Signed-off
> On Mar 5, 2019, at 3:03 AM, Jiri Olsa wrote:
>
> On Mon, Mar 04, 2019 at 09:40:07PM +, Song Liu wrote:
>>
>>
>>> On Feb 27, 2019, at 5:21 AM, Jiri Olsa wrote:
>>>
>>> On Mon, Feb 25, 2019 at 04:20:18PM -0800, Song Liu wrote:
>>>
>>> SNIP
>>>
diff --git a/tools/perf/util/evlist
On Tue, Mar 05, 2019 at 11:19:32AM -0800, si-wei liu wrote:
>
>
> On 3/4/2019 6:33 PM, Michael S. Tsirkin wrote:
> > On Mon, Mar 04, 2019 at 07:50:59PM -0500, Si-Wei Liu wrote:
> > > When a netdev appears through hot plug then gets enslaved by a failover
> > > master that is already up and runnin
> -Original Message-
> From: netdev-ow...@vger.kernel.org On
> Behalf Of Jakub Kicinski
> Sent: Tuesday, March 5, 2019 11:16 AM
> To: Jiri Pirko
> Cc: da...@davemloft.net; netdev@vger.kernel.org; oss-
> driv...@netronome.com
> Subject: Re: [PATCH net-next v2 4/7] devlink: allow subport
On Tue, Mar 5, 2019 at 2:12 AM Christian Ehrhardt
wrote:
>
> On Tue, Mar 5, 2019 at 10:58 AM Juerg Haefliger
> wrote:
> >
> > Hi,
> >
> > Running the following commands in a loop will crash an i386 5.0 kernel
> > typically within a few iterations:
> >
> > ovs-vsctl add-br test
> > ovs-vsctl del-b
It has been noticed that running the speed test at
www.speedtest.net occasionally causes a kernel panic.
Investigation revealed that under this test RX buffer allocation
sometimes fails and returns NULL. But the lan743x driver did
not handle this case.
This patch fixes this issue by attempting to
> -Original Message-
> From: Jakub Kicinski
> Sent: Monday, March 4, 2019 7:35 PM
> To: Parav Pandit
> Cc: Or Gerlitz ; netdev@vger.kernel.org; linux-
> ker...@vger.kernel.org; michal.l...@markovi.net; da...@davemloft.net;
> gre...@linuxfoundation.org; Jiri Pirko
> Subject: Re: [RFC n
On 3/5/2019 11:24 AM, Stephen Hemminger wrote:
On Tue, 5 Mar 2019 11:19:32 -0800
si-wei liu wrote:
I have a vague idea: would it work to *not* set
IFF_UP on slave devices at all?
Hmm, I ever thought about this option, and it appears this solution is
more invasive than required to convert e
On Tue, Mar 05, 2019 at 05:57:58PM +, Parav Pandit wrote:
>
>
> > -Original Message-
> > From: Greg KH
> > Sent: Tuesday, March 5, 2019 1:14 AM
> > To: Parav Pandit
> > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org;
> > michal.l...@markovi.net; da...@davemloft.net; Jiri P
On Tue, 5 Mar 2019 11:19:32 -0800
si-wei liu wrote:
> > I have a vague idea: would it work to *not* set
> > IFF_UP on slave devices at all?
> Hmm, I ever thought about this option, and it appears this solution is
> more invasive than required to convert existing scripts, despite the
> controv
On 3/4/2019 6:33 PM, Michael S. Tsirkin wrote:
On Mon, Mar 04, 2019 at 07:50:59PM -0500, Si-Wei Liu wrote:
When a netdev appears through hot plug then gets enslaved by a failover
master that is already up and running, the slave will be opened
right away after getting enslaved. Today there's a
On Tue, Feb 26, 2019 at 01:46:01AM -0500, Kris Van Hees wrote:
> On Mon, Feb 25, 2019 at 10:18:25PM -0800, Alexei Starovoitov wrote:
> > On Mon, Feb 25, 2019 at 07:54:13AM -0800, Kris Van Hees wrote:
> > >
> > > The goal is to further extend the BPF_PROG_TYPE_GTRACE implementation to
> > > support
On 3/5/19 7:44 PM, Eric Dumazet wrote:
> On Tue, Mar 5, 2019 at 7:11 AM Eric Dumazet wrote:
>>> My original suggestion was to use VM_WARN_ONCE() so that the debug checks
>>> would
>>> be compiled out by the compiler, unless you compile a debug kernel.
>>>
>>> Something like :
>>>
>>> diff --gi
2019-03-05 17:38 UTC+0100 ~ Alban Crequy
> From: Alban Crequy
>
> Before this patch, there was no way to fill attr.inner_map_fd, necessary
> for array_of_maps or hash_of_maps.
>
> This patch adds keyword 'innermap' to pass the innermap, either as an id
> or as a pinned map.
>
> Example of comm
On Thu, 28 Feb 2019 at 11:50, Maxim Mikityanskiy wrote:
>
[...]
Back in the saddle! Sorry for the delay!
Ok, let me try to summarize. First, let's go through the current
AF_XDP semantics so that we're all on the same page, and then pull
Max' suggestions in.
Ingress
---
The simplified flow
Previous to commit 22b5c0b63f32 ("vsock/virtio: fix kernel panic after device
hot-unplug"),
vsock_core_init() was called from virtio_vsock_probe(). Now,
virtio_transport_reset_no_sock() can be called before vsock_core_init()
has the chance to run.
[Wed Feb 27 14:17:09 2019] BUG: unable to handle
> -Original Message-
> From: Greg KH
> Sent: Tuesday, March 5, 2019 1:14 AM
> To: Parav Pandit
> Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org;
> michal.l...@markovi.net; da...@davemloft.net; Jiri Pirko
> ; Jakub Kicinski
> Subject: Re: [RFC net-next 8/8] net/mlx5: Add subd
On 03/04/2019 02:23 PM, syzbot wrote:
> Hello,
>
> syzbot found the following crash on:
>
> HEAD commit: 9e9322e5d28e selftest/net: Remove duplicate header
> git tree: net-next
> console output: https://syzkaller.appspot.com/x/log.txt?x=1351623320
> kernel config: https://syzkall
On Tue, 5 Mar 2019 at 18:41, Eric Dumazet wrote:
>
> Fixes two typos in xsk_diag_put_umem()
>
> syzbot reported the following crash :
>
> kasan: CONFIG_KASAN_INLINE enabled
> kasan: GPF could be caused by NULL-ptr deref or user memory access
> general protection fault: [#1] PREEMPT SMP KASAN
The pull request you sent on Mon, 04 Mar 2019 15:26:27 -0800 (PST):
> git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next refs/heads/master
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/6456300356433873309a1cae6aa05e77d6b59153
Thank you!
--
Deet-doot-dot,
On Tue, 5 Mar 2019 17:38:03 +0100, Alban Crequy wrote:
> From: Alban Crequy
>
> Before this patch, there was no way to fill attr.inner_map_fd, necessary
> for array_of_maps or hash_of_maps.
>
> This patch adds keyword 'innermap' to pass the innermap, either as an id
> or as a pinned map.
>
> E
Fixes two typos in xsk_diag_put_umem()
syzbot reported the following crash :
kasan: CONFIG_KASAN_INLINE enabled
kasan: GPF could be caused by NULL-ptr deref or user memory access
general protection fault: [#1] PREEMPT SMP KASAN
CPU: 1 PID: 7641 Comm: syz-executor946 Not tainted 5.0.0-rc7+ #9
From: Colin Ian King
There are a couple of typos, fix these.
Signed-off-by: Colin Ian King
---
samples/bpf/hbm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/samples/bpf/hbm.c b/samples/bpf/hbm.c
index 8408ccb7409f..a79828ab273f 100644
--- a/samples/bpf/hbm.c
+++ b/s
On Sat, 2019-03-02 at 22:19 +0100, Kristian Evensen wrote:
> On Sat, Mar 2, 2019 at 4:00 PM Bjørn Mork wrote:
> > I am not too happy about the double device id matching with extra
> > magic
> > applied. outside the device id table. It does not scale, and it
> > does
> > not play well at all with
On Tue, 5 Mar 2019 12:06:01 +0100, Jiri Pirko wrote:
> >> >as ports. Can we invent a new command (say "partition"?) that'd take
> >> >the bus info where the partition is to be spawned?
> >>
> >> Got it. But the question is how different this object would be from the
> >> existing "port" we ha
On 3/5/2019 8:48 AM, Gerd Rausch wrote:
Hi Santosh,
On 05/03/2019 08.41, Santosh Shilimkar wrote:
On 3/5/2019 8:33 AM, Gerd Rausch wrote:
If there's a mechanism that ensures compatibility with older (pre-4.1) versions
of RDS I am not seeing it.
Thats handled as part of the connection reject h
From: maowenan
Date: Tue, 5 Mar 2019 11:33:03 +0800
>
>
> On 2019/3/5 2:16, David Miller wrote:
>> From: maowenan
>> Date: Mon, 4 Mar 2019 20:47:42 +0800
>>
>>> pmc->tomb = psf;
>>> rv = 1; //if it does not kfree(psf), will it
>>> lead to memor
> -Original Message-
> From: Jakub Kicinski
> Sent: Monday, March 4, 2019 7:46 PM
> To: Parav Pandit
> Cc: Or Gerlitz ; netdev@vger.kernel.org; linux-
> ker...@vger.kernel.org; michal.l...@markovi.net; da...@davemloft.net;
> gre...@linuxfoundation.org; Jiri Pirko
> Subject: Re: [RFC n
Hi Santosh,
On 05/03/2019 08.41, Santosh Shilimkar wrote:
> On 3/5/2019 8:33 AM, Gerd Rausch wrote:
>> If there's a mechanism that ensures compatibility with older (pre-4.1)
>> versions
>> of RDS I am not seeing it.
> Thats handled as part of the connection reject handler as part of negotiation.
On Tue, Mar 5, 2019 at 7:11 AM Eric Dumazet wrote:
>
> >
> > My original suggestion was to use VM_WARN_ONCE() so that the debug checks
> > would
> > be compiled out by the compiler, unless you compile a debug kernel.
> >
> > Something like :
> >
> > diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
>
On 3/5/2019 8:33 AM, Gerd Rausch wrote:
Hi,
This patchset breaks compatibility...
On 04/02/2019 16.04, Santosh Shilimkar wrote:
--- a/net/rds/ib_cm.c
+++ b/net/rds/ib_cm.c
@@ -868,7 +870,7 @@ int rds_ib_cm_initiate_connect(struct rdma_cm_id *cm_id,
bool isv6)
/* If the peer doesn't do p
From: Alban Crequy
Before this patch, there was no way to fill attr.inner_map_fd, necessary
for array_of_maps or hash_of_maps.
This patch adds keyword 'innermap' to pass the innermap, either as an id
or as a pinned map.
Example of commands:
$ sudo bpftool map create /sys/fs/bpf/innermap type h
Hi,
This patchset breaks compatibility...
On 04/02/2019 16.04, Santosh Shilimkar wrote:
> --- a/net/rds/ib_cm.c
> +++ b/net/rds/ib_cm.c
> @@ -868,7 +870,7 @@ int rds_ib_cm_initiate_connect(struct rdma_cm_id *cm_id,
> bool isv6)
>
> /* If the peer doesn't do protocol negotiation, we must
1 - 100 of 138 matches
Mail list logo
