There is no need to have the 'int first' static
since new value always be assigned before use it.
The old codes of first dereferencing this variable have
been commented out. So it is useless with 'static int first'.
/*
if (!first) {
...
}
*/
first = 1;
Signed-off-by: Mao Wenan
---
drivers/net/e
marvell_read_status() no longer first switches to the fiber page, instead
looks at the already active register page first. In case the link is down,
switches to the other (fiber/copper) register page.
Unneeded register page switching of the Marvell 88E1510 PHY can cause
the ethernet driver to regi
When sending multicast messages via blocking socket,
if sending link is congested (tsk->cong_link_cnt is set to 1),
the sending thread will be put into sleeping state. However,
tipc_sk_filter_rcv() is called under socket spin lock but
tipc_wait_for_cond() is not. So, there is no guarantee that
the
Fix issue of hung sendto() in user space.
Tung Nguyen (1):
tipc: fix race condition causing hung sendto
net/tipc/socket.c | 4
1 file changed, 4 insertions(+)
mode change 100644 => 100755 net/tipc/socket.c
--
2.17.1
On Tue, Feb 19, 2019 at 12:46:08AM +0100, Andrew Lunn wrote:
> On Mon, Feb 18, 2019 at 07:21:59PM +0100, Michal Kubecek wrote:
> > Three types of netlink notifications are introduced:
> >
> > - ETHA_EVENT_NEWDEV to notify about newly registered network devices
> > - ETHA_EVENT_DELDEV to notify
RGMII_ID specifies that we should have internal delay, so resurrect the
delay addition routine but under the RGMII_ID mode.
Fixes: 40269aa9f40a ("net: dsa: qca8k: disable delay for RGMII mode")
Tested-by: Michal Vokáč
Signed-off-by: Vinod Koul
---
drivers/net/dsa/qca8k.c | 12
driv
When fail, translate_desc() returns negative value, otherwise the
number of iovs. So we should fail when the return value is negative
instead of a blindly check against zero.
Detected by CoverityScan, CID# 1442593: Control flow issues (DEADCODE)
Fixes: cc5e71075947 ("vhost: log dirty page corre
On 2019/2/16 上午12:45, Stephen Hemminger wrote:
On Fri, 15 Feb 2019 15:53:24 +0800
Jason Wang wrote:
When fail, translate_desc() returns negative value, otherwise the
number of iovs. So we should fail when the return value is negative
instead of a blindly check against zero.
Reported-by: Ste
On 2019/2/16 上午2:03, David Miller wrote:
From: Jason Wang
Date: Fri, 15 Feb 2019 15:53:24 +0800
When fail, translate_desc() returns negative value, otherwise the
number of iovs. So we should fail when the return value is negative
instead of a blindly check against zero.
Reported-by: Stephen
On Fri, Feb 15, 2019 at 3:06 PM Davide Caratti wrote:
>
> currently, the kernel checks for bad values of the control action in
> tcf_action_init_1(), after a successful call to the action's init()
> function. This causes three bad behaviors:
Yeah, I have been complaining about this for a long tim
Per "Documentation/devicetree/bindings/net/ethernet.txt" RGMII mode
should not have delay in PHY whereas RGMII_ID and RGMII_RXID/RGMII_TXID
can have delay in phy.
So disable the delay only for RGMII mode and enable for other modes.
Also treat the default case as disabled delays.
Fixes: cd28d1d6e5
Some helpers were inlined, but makes more sense to allow compiler
to do the right optimizations instead, so remove inline for
at803x_disable_rx_delay() and at803x_disable_tx_delay()
Reviewed-by: Niklas Cassel
Signed-off-by: Vinod Koul
---
drivers/net/phy/at803x.c | 4 ++--
1 file changed, 2 ins
Peter[1] reported that patch cd28d1d6e52e: ("net: phy: at803x: Disable
phy delay for RGMII mode") caused regression on am335x-evmsk board.
This board expects the Phy delay to be enabled but specified RGMII mode
which refers to delays being disabled. So fix this by disabling delay only
for RGMII mod
On Mon, Feb 18, 2019 at 10:49:39AM +0100, Tobias Brunner wrote:
> After moving an XFRM interface to another namespace it stays associated
> with the original namespace (net in `struct xfrm_if` and the list keyed
> with `xfrmi_net_id`), allowing processes in the new namespace to use
> SAs/policies t
> On Feb 17, 2019, at 3:05 PM, Jiri Olsa wrote:
>
> On Fri, Feb 15, 2019 at 01:53:48PM -0800, Song Liu wrote:
>
> SNIP
>
>> info_linear = bpf_program__get_prog_info_linear(fd, arrays);
>> if (IS_ERR_OR_NULL(info_linear)) {
>> @@ -151,8 +165,8 @@ static int perf_event__synthesize_on
> On Feb 17, 2019, at 3:06 PM, Jiri Olsa wrote:
>
> On Fri, Feb 15, 2019 at 01:53:51PM -0800, Song Liu wrote:
>
> SNIP
>
>> +static int process_btf(struct feat_fd *ff, void *data __maybe_unused)
>> +{
>> +struct perf_env *env = &ff->ph->env;
>> +u32 count, i;
>> +
>> +if (do_read
On 19-02-19, 11:05, Sekhar Nori wrote:
> Hi Vinod,
>
> On 19/02/19 10:32 AM, Vinod Koul wrote:
> > Hello Dave,
> >
> > On 18-02-19, 16:28, David Miller wrote:
> >> From: Vinod Koul
> >> Date: Mon, 18 Feb 2019 15:48:52 +0530
> >>
> >>> Some helpers were inlined, but makes more sense to allow comp
This test ensures the verifier has checked the arg1 of
BPF_FUNC_tcp_enter_cwr is of ARG_PTR_TO_TCP_SOCK type.
Signed-off-by: Martin KaFai Lau
Signed-off-by: Lawrence Brakmo
---
tools/testing/selftests/bpf/verifier/sock.c | 33 +
1 file changed, 33 insertions(+)
diff --git a
The program load_cg_skb can be used to load BPF_PROG_TYPE_CGROUP_SKB
type bpf_prog which currently can be attached to the ingress and egress
patch. It can also be used to detach the bpf_prog.
Examples:
load_cg_skb [-i]
Load and attaches a cg skb program to the specified cgroup.
If "-i"
This patch syncs the uapi bpf.h to tools/ and also updates
bpf_herlpers.h in tools/
Signed-off-by: Lawrence Brakmo
---
tools/include/uapi/linux/bpf.h| 27 ++-
tools/testing/selftests/bpf/bpf_helpers.h | 6 +
2 files changed, 32 insertions(+), 1 deletion(-)
d
This patch adds a new bpf helper BPF_FUNC_tcp_enter_cwr
"int bpf_tcp_enter_cwr(struct bpf_tcp_sock *tp)".
It is added to BPF_PROG_TYPE_CGROUP_SKB typed bpf_prog
which currently can be attached to the ingress and egress
path.
This helper makes a tcp_sock enter CWR state. It can be used
by a bpf_pr
Script for testing NRM (Network Resource Manager) framework.
It creates a cgroup to use for testing and load a BPF program to limit
egress bandwidht. It then uses iperf3 or netperf to create
loads. The output is the goodput in Mbps (unless -D is used).
It can work on a single host using loopback o
A cgroup skb BPF program to limit cgroup output bandwidth.
It uses a modified virtual token bucket queue to limit average
egress bandwidth. The implementation uses credits instead of tokens.
Negative credits imply that queueing would have happened (this is
a virtual queue, so no queueing is done by
The program nrm creates a cgroup and attaches a BPF program to the
cgroup for testing NRM for egress traffic. One still needs to create
network traffic. This can be done through netesto, netperf or iperf3.
A follow-up patch contains a script to create traffic.
USAGE: nrm [-d] [-l] [-n ] [-r ] [-s]
This patch adds a new bpf helper BPF_FUNC_tcp_check_probe_timer
"int bpf_check_tcp_probe_timer(struct tcp_bpf_sock *tp, u32 when_us)".
It is added to BPF_PROG_TYPE_CGROUP_SKB typed bpf_prog which currently
can be attached to the ingress and egress path.
The function forces when_us to be at least T
This patch adds a new bpf helper BPF_FUNC_skb_set_ecn
"int bpf_skb_set_Ecn(struct sk_buff *skb)". It is added to
BPF_PROG_TYPE_CGROUP_SKB typed bpf_prog which currently can
be attached to the ingress and egress path. This type of
bpf_prog cannot modify the skb directly.
This helper is used to set
Network Resource Manager is a framework for limiting the bandwidth used
by v2 cgroups. It consists of 4 BPF helpers and a sample BPF program to
limit egress bandwdith as well as a sample user program and script to
simplify NRM testing.
The sample NRM BPF program is not meant to be production quali
Hi Vinod,
On 19/02/19 10:32 AM, Vinod Koul wrote:
> Hello Dave,
>
> On 18-02-19, 16:28, David Miller wrote:
>> From: Vinod Koul
>> Date: Mon, 18 Feb 2019 15:48:52 +0530
>>
>>> Some helpers were inlined, but makes more sense to allow compiler
>>> to do the right optiomazations instead, so remove
On Fri, Feb 15, 2019 at 7:35 AM Vlad Buslov wrote:
>
> Another problem that I found in cls_fw and cls_route is that they set
> arg->stop when empty. Both of them have code unchanged since it was
> committed initially in 2005 so I assume this convention is no longer
> relevant because all other cla
On Tue, Feb 19, 2019 at 01:42:13PM +0900, Masahiro Yamada wrote:
[..]
> > > > This archive makes
> > > > it possible to build kernel modules, run eBPF programs, and other
> > > > tracing programs that need to extend the kernel for tracing purposes
> > > > without any dependency on the file system h
On Fri, Feb 15, 2019 at 2:02 AM Vlad Buslov wrote:
>
> I looked at the code and problem seems to be matchall classifier
> specific. My implementation of unlocked cls API assumes that concurrent
> insertions are possible and checks for it when deleting "empty" tp.
> Since classifiers don't expose n
Hello Dave,
On 18-02-19, 16:28, David Miller wrote:
> From: Vinod Koul
> Date: Mon, 18 Feb 2019 15:48:52 +0530
>
> > Some helpers were inlined, but makes more sense to allow compiler
> > to do the right optiomazations instead, so remove inline for
> > at803x_disable_rx_delay() and at803x_disable
On 18-02-19, 14:36, Andrew Lunn wrote:
> On Mon, Feb 18, 2019 at 06:33:51PM +0530, Vinod Koul wrote:
> > + case PHY_INTERFACE_MODE_RGMII_ID:
> > + /* RGMII_ID needs internal delay. This is enabled through
> > +* PORT5_PAD_CTRL for all ports, rather than individual port
> > +
Hi Andrew,
On 18-02-19, 14:33, Andrew Lunn wrote:
> On Mon, Feb 18, 2019 at 06:33:51PM +0530, Vinod Koul wrote:
> > RGMII_ID specifies that we should have internal delay, so resurrect the
> > delay addition routine but under the RGMII_ID mode.
> >
> > Fixes: 40269aa9f40a ("net: dsa: qca8k: disabl
Good day,
I did send you an email on charity works and I
dont know if you got it.Please reach me for updates or let me know if to
resend
Pablo Mancilla
On Tue, Feb 19, 2019 at 1:14 PM Masahiro Yamada
wrote:
>
> On Fri, Feb 15, 2019 at 11:48 PM Alexei Starovoitov
> wrote:
> >
> > On Mon, Feb 11, 2019 at 09:35:59AM -0500, Joel Fernandes (Google) wrote:
> > > Introduce in-kernel headers and other artifacts which are made available
> > > as an archi
On Mon, Feb 18, 2019 at 2:12 PM Willem de Bruijn
wrote:
>
> On Fri, Feb 15, 2019 at 12:15 PM Willem de Bruijn
> wrote:
> >
> > From: Willem de Bruijn
> >
> > Syzkaller again found a path to a kernel crash through bad gso input.
> > By building an excessively large packet to cause an skb field to
From: Willem de Bruijn
GSO packets with vnet_hdr must conform to a small set of gso_types.
The below commit uses flow dissection to drop packets that do not.
But it has false positives when the skb is not fully initialized.
Dissection needs skb->protocol and skb->network_header.
Infer skb->prot
On Tue, Feb 19, 2019 at 01:14:11PM +0900, Masahiro Yamada wrote:
> On Fri, Feb 15, 2019 at 11:48 PM Alexei Starovoitov
> wrote:
> >
> > On Mon, Feb 11, 2019 at 09:35:59AM -0500, Joel Fernandes (Google) wrote:
> > > Introduce in-kernel headers and other artifacts which are made available
> > > as a
On Fri, Feb 15, 2019 at 2:47 PM Willem de Bruijn
wrote:
>
> > > > 2. Why there is no socket option for sysctl.net.busy_poll? Clearly
> > > > sysctl_net_busy_poll is global and SO_BUSY_POLL only works for
> > > > sysctl.net.busy_read.
> > >
> > > I guess because of how sock_poll works. In that case
Some improvements for tipc_wait_for_xzy().
Tung Nguyen (2):
tipc: improve function tipc_wait_for_cond()
tipc: improve function tipc_wait_for_rcvmsg()
net/tipc/socket.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
--
2.17.1
On Tue, Feb 19, 2019 at 01:14:11PM +0900, Masahiro Yamada wrote:
>
> I was able to compile it in-tree
> but it makes the incremental build extremely slow.
>
> (Here, the incremental build means
> "make" without changing any code after the full build.)
>
> Before this patch, "make -j8" took 11 se
Commit 844cf763fba6 ("tipc: make macro tipc_wait_for_cond() smp safe")
replaced finish_wait() with remove_wait_queue() but still used
prepare_to_wait(). This causes unnecessary conditional
checking before adding to wait queue in prepare_to_wait().
This commit replaces prepare_to_wait() with add_w
This commit replaces schedule_timeout() with wait_woken()
in function tipc_wait_for_rcvmsg(). wait_woken() uses
memory barriers in its implementation to avoid potential
race condition when putting a process into sleeping state
and then waking it up.
Acked-by: Ying Xue
Acked-by: Jon Maloy
Signed-
On Fri, Feb 15, 2019 at 11:48 PM Alexei Starovoitov
wrote:
>
> On Mon, Feb 11, 2019 at 09:35:59AM -0500, Joel Fernandes (Google) wrote:
> > Introduce in-kernel headers and other artifacts which are made available
> > as an archive through proc (/proc/kheaders.txz file).
The extension '.txz' is n
Masahiro Yamada writes:
> On Tue, Feb 19, 2019 at 4:38 AM Kalle Valo wrote:
>>
>> Kalle Valo writes:
>>
>> > Kalle Valo writes:
>> >
>> >> Masahiro Yamada writes:
>> >>
>> >>> __sw_hweight8() is just internal implementation.
>> >>>
>> >>> Drivers should use the common API, hweight8().
>> >>>
syzbot has found a reproducer for the following crash on:
HEAD commit:a3b22b9f11d9 Linux 5.0-rc7
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=17e3d4d0c0
kernel config: https://syzkaller.appspot.com/x/.config?x=7132344728e7ec3f
dashboard link: https:/
Hi,
Friendly ping:
Dave, I wonder if you can take this.
Thanks
--
Gustavo
On 2/14/19 3:37 PM, Gustavo A. R. Silva wrote:
>
>
> On 1/30/19 2:11 AM, nicolas.fe...@microchip.com wrote:
>> On 29/01/2019 at 19:06, Gustavo A. R. Silva wrote:
>>> In preparation to enabling -Wimplicit-fallthrough, ma
On 2019/2/19 4:13, David Miller wrote:
> From: YueHaibing
> Date: Mon, 18 Feb 2019 08:15:46 +
>
>> @@ -1050,8 +1050,11 @@ static int yellowfin_rx(struct net_device *dev)
>> struct sk_buff *rx_skb = yp->rx_skbuff[entry];
>> s16 frame_status;
>> u16 desc_s
br_ip4_multicast_mrd_rcv only return 0 and -ENOMSG,
no other negative value
Signed-off-by: Li RongQing
---
net/bridge/br_multicast.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
index 4a048fd1cbea..fe9f2d8ca2c1 10
This case block has been terminated by a return, so not need
a switch fall-through
Signed-off-by: Li RongQing
---
net/ipv4/igmp.c| 1 -
net/ipv6/mcast_snoop.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/net/ipv4/igmp.c b/net/ipv4/igmp.c
index b448cf32296c..6c2febc39dca 100644
--
From: Pablo Neira Ayuso
Date: Tue, 19 Feb 2019 00:08:21 +0100
> The following patchset contains Netfilter/IPVS fixes for net:
>
> 1) Follow up patch to fix a compilation warning in a recent IPVS fix:
>098e13f5b21d ("ipvs: fix dependency on nf_defrag_ipv6").
>
> 2) Bogus ENOENT error on flus
From: Florian Fainelli
Date: Mon, 18 Feb 2019 14:30:11 -0800
> It is possible for the DSA slave network device not to be part of a
> bridge, yet have an upper device like a VLAN device be part of a bridge.
> When that VLAN device is enslaved, since it does not define any
> switchdev_ops, we will
On 2/18/19 9:55 AM, Michal Soltys wrote:
> This patch fixes a subtle PACKET_ORIGDEV regression which was a side
> effect of fixes introduced by:
>
> 6a9e461f6fe4 bonding: pass link-local packets to bonding master also.
>
> ... to:
>
> b89f04c61efe bonding: deliver link-local packets with skb->de
From: Murali Karicheri
Date: Mon, 18 Feb 2019 15:10:51 -0500
> Recent commit below has introduced a bug in netcp driver that causes
> the ethss driver probe failure and thus break the networking function
> on K2 SoCs such as K2HK, K2L, K2E etc. This patch fixes the issue to
> restore networking o
From: Salil Mehta
Date: Mon, 18 Feb 2019 17:40:32 +
> This patch fixes the missing device reference release-after-use in
> the positive leg of the roce reset API of the HNS DSAF.
>
> Fixes: c969c6e7ab8c ("net: hns: Fix object reference leaks in
> hns_dsaf_roce_reset()")
> Reported-by: John
From: Kalle Valo
Date: Mon, 18 Feb 2019 17:19:26 +0200
> here's one more pull request to net tree for 5.0. Please let me know if
> you have any problems.
Pulled, thanks Kalle.
From: Jose Abreu
Date: Mon, 18 Feb 2019 14:35:03 +0100
> We are saving the status of EEE even before we try to enable it. This
> leads to a race with XMIT function that tries to arm EEE timer before we
> set it up.
>
> Fix this by only saving the EEE parameters after all operations are
> perform
On Mon, Feb 18, 2019 at 09:32:46PM +, Al Viro wrote:
On Mon, Feb 18, 2019 at 09:14:33PM +, Sasha Levin wrote:
Hi,
[This is an automated email]
This commit has been processed because it contains a -stable tag.
Ugh... Should've removed Cc; stable from netdev posting; my apologies.
H
From: Nazarov Sergey
Date: Mon, 18 Feb 2019 16:39:11 +0300
> I think, it would not be a good solution, if I will analyze all
> subsystems using icmp_send, because I do not have enough knowledge
> for this. I propose to add a new function, for example,
> ismp_send_safe, something like that:
Plea
On Tue, Feb 19, 2019 at 4:38 AM Kalle Valo wrote:
>
> Kalle Valo writes:
>
> > Kalle Valo writes:
> >
> >> Masahiro Yamada writes:
> >>
> >>> __sw_hweight8() is just internal implementation.
> >>>
> >>> Drivers should use the common API, hweight8().
> >>>
> >>> Signed-off-by: Masahiro Yamada
>
From: Michal Kalderon
Date: Mon, 18 Feb 2019 15:24:01 +0200
> This series fixes two bugs related to iWARP syn processing flow.
Series applied, thanks.
From: YueHaibing
Date: Mon, 18 Feb 2019 12:19:54 +
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c: In function
> 'bnx2x_get_hwinfo':
> drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:11940:10: warning:
> variable 'mfw_vn' set but not
From: Heiner Kallweit
Date: Sat, 16 Feb 2019 17:24:58 +0100
> Similar to the existing helpers for the Clause 22 registers add helpers
> to deal with converting Clause 45 advertisement registers to / from
> link mode bitmaps.
>
> Note that these helpers are defined in linux/mdio.h, not like the
>
From: YueHaibing
Date: Sat, 16 Feb 2019 17:53:10 +0800
> Fix following warning:
>
> drivers/net/ethernet/cavium/liquidio/cn23xx_pf_device.c:1453:35: warning:
> Using plain integer as NULL pointer
> drivers/net/ethernet/cavium/liquidio/lio_main.c:2910:23: warning: Using plain
> integer as NULL
From: Heiner Kallweit
Date: Sat, 16 Feb 2019 10:20:15 +0100
> writex() has implicit barriers, that's what makes it different from
> writex_relaxed(). Therefore these calls to mmiowb() can be removed.
>
> This patch was recently reverted due to a dependency with another
> problematic patch. But b
From: David Chen
Date: Sat, 16 Feb 2019 17:16:42 +0800
> From: David Chen
>
> RTL8153-BD is used in Dell DA300 type-C dongle.
> It should be added to the whitelist of devices to activate MAC address
> pass through.
>
> Per confirming with Realtek all devices containing RTL8153-BD should
> acti
From: Wei Yongjun
Date: Sat, 16 Feb 2019 08:19:55 +
> The callback function of call_rcu() just calls a kfree(), so we
> can use kfree_rcu() instead of call_rcu() + callback function.
>
> Signed-off-by: Wei Yongjun
Applied.
From: Rundong Ge
Date: Sat, 16 Feb 2019 08:35:24 +
> RPS not work for DSA devices since the 'skb_get_hash'
> will always get the invalid hash for dsa tagged packets.
>
> "[PATCH] tag_mtk: add flow_dissect callback to the ops struct"
> introduced the flow_dissect callback to get the right has
From: YueHaibing
Date: Sat, 16 Feb 2019 10:59:35 +0800
> Fix coccinelle warning:
>
> ./drivers/net/phy/mdio_bus.c:51:5-12: ERROR: PTR_ERR applied after
> initialization to constant on line 44
> ./drivers/net/phy/mdio_bus.c:52:5-12: ERROR: PTR_ERR applied after
> initialization to constant on l
Hi all,
Today's linux-next merge of the net-next tree got a conflict in:
net/ipv4/tcp.c
between commit:
04c03114be82 ("tcp: clear icsk_backoff in tcp_write_queue_purge()")
from the net tree and commit:
3a9a57f63794 ("tcp: move snd_cwnd & snd_cwnd_cnt init to tcp_disconnect()")
from the
From: Johannes Berg
Date: Mon, 18 Feb 2019 11:29:29 +0100
> From: Wei Yongjun
>
> spin_lock_bh() is used in table_path_del() but rcu_read_unlock()
> is used for unlocking. Fix it by using spin_unlock_bh() instead
> of rcu_read_unlock() in the error handling case.
>
> Fixes: b4c3fbe63601 ("mac8
From: Vinod Koul
Date: Mon, 18 Feb 2019 15:48:52 +0530
> Some helpers were inlined, but makes more sense to allow compiler
> to do the right optiomazations instead, so remove inline for
> at803x_disable_rx_delay() and at803x_disable_tx_delay()
>
> Signed-off-by: Vinod Koul
Two problem with thi
> diff --git a/drivers/net/dsa/mv88e6xxx/chip.c
> b/drivers/net/dsa/mv88e6xxx/chip.c
> index 54a5b660640a..bb46ebbb2bb8 100644
> --- a/drivers/net/dsa/mv88e6xxx/chip.c
> +++ b/drivers/net/dsa/mv88e6xxx/chip.c
> @@ -2399,7 +2399,7 @@ static int mv88e6xxx_setup(struct dsa_switch *ds)
> int i
On Mon, Feb 18, 2019 at 07:21:59PM +0100, Michal Kubecek wrote:
> Three types of netlink notifications are introduced:
>
> - ETHA_EVENT_NEWDEV to notify about newly registered network devices
> - ETHA_EVENT_DELDEV to notify about unregistered network devices
> - ETHA_EVENT_RENAMEDEV to notif
From: Vadim Lomovtsev
Date: Mon, 18 Feb 2019 09:52:14 +
> @@ -169,6 +169,20 @@ static int nicvf_check_pf_ready(struct nicvf *nic)
> return 1;
> }
>
> +static int nicvf_send_cfg_done(struct nicvf *nic)
> +{
> + union nic_mbx mbx = {};
> +
> + mbx.msg.msg = NIC_MBOX_MSG_CFG_DON
On 02/18/2019 06:29 PM, Stanislav Fomichev wrote:
> On 02/16, Daniel Borkmann wrote:
>> On 02/13/2019 12:42 AM, Stanislav Fomichev wrote:
>>> Syzbot found out that running BPF_PROG_TEST_RUN with repeat=0x
>>> makes process unkillable. The problem is that when CONFIG_PREEMPT is
>>> enabled,
From: Andrea Claudi
When CONFIG_IP_VS_IPV6 is not defined, build produced this warning:
net/netfilter/ipvs/ip_vs_ctl.c:899:6: warning: unused variable ‘ret’
[-Wunused-variable]
int ret = 0;
^~~
Fix this by moving the declaration of 'ret' in the CONFIG_IP_VS_IPV6
section in the same fun
It turns out that the IP checksumming code is still exercised often,
even though one might expect that modern NICs with checksum offload
have no use for it. However, as Lingyan points out, there are
combinations of features where the network stack may still fall back
to software checksumming, and s
Hi David,
The following patchset contains Netfilter/IPVS fixes for net:
1) Follow up patch to fix a compilation warning in a recent IPVS fix:
098e13f5b21d ("ipvs: fix dependency on nf_defrag_ipv6").
2) Bogus ENOENT error on flush after rule deletion in the same batch,
reported by Phil Sutt
Flush after rule deletion bogusly hits -ENOENT. Skip rules that have
been already from nft_delrule_by_chain() which is always called from the
flush path.
Fixes: cf9dc09d0949 ("netfilter: nf_tables: fix missing rules flushing per
table")
Reported-by: Phil Sutter
Acked-by: Phil Sutter
Signed-off-
It is possible for the DSA slave network device not to be part of a
bridge, yet have an upper device like a VLAN device be part of a bridge.
When that VLAN device is enslaved, since it does not define any
switchdev_ops, we will recurse down to the lower/physical port device,
call switchdev_port_obj
On Mon, Feb 18, 2019 at 2:08 PM Stefan Wahren wrote:
>
> Hi Vasily,
Hi Stefan,
> > Vasily Khoruzhick hat am 18. Februar 2019 um 22:24
> > geschrieben:
> >
> >
> > On Mon, Feb 18, 2019 at 1:10 PM Rob Herring wrote:
> > >
> > > On Fri, Jan 18, 2019 at 09:02:27AM -0800, Vasily Khoruzhick wrote:
> Stefan Wahren hat am 18. Februar 2019 um 23:08
> geschrieben:
>
>
> Hi Vasily,
>
> > Vasily Khoruzhick hat am 18. Februar 2019 um 22:24
> > geschrieben:
> >
> >
> > On Mon, Feb 18, 2019 at 1:10 PM Rob Herring wrote:
> > >
> > > On Fri, Jan 18, 2019 at 09:02:27AM -0800, Vasily Khoruzhi
Hi Vasily,
> Vasily Khoruzhick hat am 18. Februar 2019 um 22:24
> geschrieben:
>
>
> On Mon, Feb 18, 2019 at 1:10 PM Rob Herring wrote:
> >
> > On Fri, Jan 18, 2019 at 09:02:27AM -0800, Vasily Khoruzhick wrote:
> > > Add binding document for bluetooth part of RTL8723BS/RTL8723CS
> > >
> > > S
On Mon, Feb 18, 2019 at 09:20:46PM +0200, Kalle Valo wrote:
> So Masahiro, could you hold your x86 patch for a while until the mt76
> patch will be in Linus' tree? That should not take more than two weeks,
> I think.
No hurry - I won't take it into the x86 now and queue it for 5.1 because
it is no
On Mon, Feb 18, 2019 at 09:14:33PM +, Sasha Levin wrote:
> Hi,
>
> [This is an automated email]
>
> This commit has been processed because it contains a -stable tag.
Ugh... Should've removed Cc; stable from netdev posting; my apologies.
> How should we proceed with this patch?
Wait for it
On Mon, Feb 18, 2019 at 1:10 PM Rob Herring wrote:
>
> On Fri, Jan 18, 2019 at 09:02:27AM -0800, Vasily Khoruzhick wrote:
> > Add binding document for bluetooth part of RTL8723BS/RTL8723CS
> >
> > Signed-off-by: Vasily Khoruzhick
> > ---
> > .../bindings/net/rtl8723bs-bluetooth.txt | 35 +++
Hi,
[This is an automated email]
This commit has been processed because it contains a -stable tag.
The stable tag indicates that it's relevant for the following trees: .+
The bot has tested the following trees: v4.20.10, v4.19.23, v4.14.101,
v4.9.158, v4.4.174, v3.18.134.
v4.20.10: Build OK!
v
On Fri, Jan 18, 2019 at 09:02:27AM -0800, Vasily Khoruzhick wrote:
> Add binding document for bluetooth part of RTL8723BS/RTL8723CS
>
> Signed-off-by: Vasily Khoruzhick
> ---
> .../bindings/net/rtl8723bs-bluetooth.txt | 35 +++
> 1 file changed, 35 insertions(+)
> create mo
On 2/18/2019 11:29 AM, Heiner Kallweit wrote:
> If link partner and we can't agree on any mode, then it doesn't make
> sense to pretend we would have agreed on 10/half. Therefore set a
> proper default.
>
> Signed-off-by: Heiner Kallweit
Reviewed-by: Florian Fainelli
--
Florian
On Wed, Feb 13, 2019 at 11:47 PM Vlad Buslov wrote:
>
> Without rtnl lock protection tcf proto can be deleted concurrently. Check
> tcf proto 'deleting' flag after taking tcf spinlock to verify that no
> concurrent deletion is in progress. Return EAGAIN error if concurrent
> deletion detected, whi
The way to define __ETHTOOL_LINK_MODE_MASK_NBITS seems to be overly
complicated, go with a standard approach instead.
Whilst we're at it, move the comment to the right place.
Signed-off-by: Heiner Kallweit
---
include/linux/ethtool.h | 4
include/uapi/linux/ethtool.h | 17 +---
On Thu, 17 Jan 2019 14:54:16 +, Fabrizio Castro wrote:
> Document support for rcar_canfd on R8A774A1 SoC devices.
>
> Signed-off-by: Fabrizio Castro
> Reviewed-by: Chris Paterson
> ---
> This patch depends on:
> https://patchwork.kernel.org/patch/10766781/
>
> Documentation/devicetree/bind
We want to use this function in phy-c45.c too, therefore export it.
Signed-off-by: Heiner Kallweit
---
drivers/net/phy/phy_device.c | 3 ++-
include/linux/phy.h | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device
Use new function genphy_c45_check_and_restart_aneg() to reduce
boilerplate code.
Signed-off-by: Heiner Kallweit
---
drivers/net/phy/marvell10g.c | 15 +--
1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/drivers/net/phy/marvell10g.c b/drivers/net/phy/marvell10g.c
index 6
This function will be used by config_aneg callback implementations of
PHY drivers and allows to reduce boilerplate code.
Signed-off-by: Heiner Kallweit
---
drivers/net/phy/phy-c45.c | 30 ++
include/linux/phy.h | 1 +
2 files changed, 31 insertions(+)
diff --g
Like in genphy_config_aneg() for clause 22 PHY's, we should keep modes
from being advertised that are known to be broken with EEE.
Signed-off-by: Heiner Kallweit
---
drivers/net/phy/phy-c45.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/phy/phy-c45.c b/drive
Improve generic clause 45 aneg configuration.
Heiner Kallweit (4):
net: phy: export genphy_config_eee_advert
net: phy: use genphy_config_eee_advert in genphy_c45_an_config_aneg
net: phy: add genphy_c45_check_and_restart_aneg
net: phy: marvell10g: use genphy_c45_check_and_restart_aneg in
On Mon, 18 Feb 2019 19:21:44 +0100 (CET), Michal Kubecek wrote:
> +/* create skb for a reply and fill device identification
> + * payload: payload length (without netlink and genetlink header)
> + * dev: device the reply is about (may be null)
> + * cmd: ETHNL_CMD_* command for reply
> + *
1 - 100 of 281 matches
Mail list logo
