Re: [PATCH net-next v3 00/12] net: Introduce ndo_get_port_parent_id()

2019-02-05 Thread Ido Schimmel
On Tue, Feb 05, 2019 at 03:53:14PM -0800, Florian Fainelli wrote: > Hi all, > > Based on discussion with Ido and feedback from Jakub there are clearly > two classes of users that implement SWITCHDEV_ATTR_ID_PORT_PARENT_ID: > > - PF/VF drivers which typically only implement return the port's paren

Re: [PATCH net 0/3] net: stmmac: Misc fixes

2019-02-05 Thread Jose Abreu
Hi Niklas, On 2/5/2019 10:05 PM, Niklas Cassel wrote: > On Wed, Jan 30, 2019 at 03:54:18PM +0100, Jose Abreu wrote: >> >> Some misc fixes for stmmac targeting -net. >> >> Cc: Joao Pinto >> Cc: David S. Miller >> Cc: Giuseppe Cavallaro >> Cc: Alexandre Torgue >> >> Jose Abreu (3): >> net: stm

Re: [PATCH v2 2/2] r8169: Avoid pointer aliasing

2019-02-05 Thread Michal Kubecek
On Tue, Feb 05, 2019 at 11:19:04AM -0800, Joe Perches wrote: > On Tue, 2019-02-05 at 11:14 -0800, David Miller wrote: > > From: Joe Perches > > Date: Tue, 05 Feb 2019 10:42:54 -0800 > > > > > On Mon, 2019-02-04 at 19:20 -0800, David Miller wrote: > > >> From: Thierry Reding > > >> Date: Mon, 4

pull-request: wireless-drivers-next 2019-02-06

2019-02-05 Thread Kalle Valo
Hi Dave, here's a pull request to net-next for 5.1, more info below. Please let me know if there are any problems. Kalle The following changes since commit bfeffd155283772bbe78c6a05dec7c0128ee500c: Linux 5.0-rc1 (2019-01-06 17:08:20 -0800) are available in the git repository at: git://gi

Re: [PATCH 2/2 net-next] net: phy: make use of new MMD accessors

2019-02-05 Thread Heiner Kallweit
On 06.02.2019 03:10, Andrew Lunn wrote: > On Tue, Feb 05, 2019 at 10:13:07PM +0100, Heiner Kallweit wrote: >> Make use of the new MMD accessors. >> >> Andrew Lunn > > This is missing the Signed-off-by: prefix. > Uups, I send a v2. >> Signed-off-by: Heiner Kallweit > > Reviewed-by: Andrew Lunn

[PATCH 1/2 v2 net-next] net: phy: provide full set of accessor functions to MMD registers

2019-02-05 Thread Heiner Kallweit
From: Nikita Yushchenko This adds full set of locked and unlocked accessor functions to read and write PHY MMD registers and/or bitfields. Set of functions exactly matches what is already available for PHY legacy registers. Signed-off-by: Nikita Yushchenko Signed-off-by: Andrew Lunn Signed-off

[PATCH 2/2 v2 net-next] net: phy: make use of new MMD accessors

2019-02-05 Thread Heiner Kallweit
Make use of the new MMD accessors. v2: - fix SoB Signed-off-by: Andrew Lunn Signed-off-by: Heiner Kallweit Reviewed-by: Andrew Lunn --- drivers/net/phy/dp83867.c| 47 +--- drivers/net/phy/dp83tc811.c | 15 +++- drivers/net/phy/marvell10g.c | 38 +++

[PATCH 0/2 v2 net-next] net: phy: add and use further MMD accessors

2019-02-05 Thread Heiner Kallweit
Add MMD accessors for modifying MMD registers and clearing / setting bits in MMD registers. Use these accessors in PHY drivers and phylib. v2: - fix SoB in patch 2 Nikita Yushchenko (1): net: phy: provide full set of accessor functions to MMD registers Heiner Kallweit (1): net: phy: make use

Re: [PATCH bpf-next] tools: bpftool: doc, fix incorrect text

2019-02-05 Thread Y Song
On Tue, Feb 5, 2019 at 6:26 PM Prashant Bhole wrote: > > Documentation about cgroup, feature, prog uses wrong header > 'MAP COMMANDS' while listing commands. This patch corrects the header > in respective doc files. > > Signed-off-by: Prashant Bhole Acked-by: Yonghong Song > --- > tools/bpf/b

Re: [PATCH bpf-next] tools: bpftool: doc, add text about feature-subcommand

2019-02-05 Thread Y Song
On Tue, Feb 5, 2019 at 6:25 PM Prashant Bhole wrote: > > This patch adds missing information about feature-subcommand in > bpftool.rst > > Signed-off-by: Prashant Bhole Acked-by: Yonghong Song > --- > tools/bpf/bpftool/Documentation/bpftool.rst | 4 +++- > 1 file changed, 3 insertions(+), 1 d

Re: [PATCH v2 bpf-next 2/2] btf: expose API to work with raw btf data

2019-02-05 Thread Alexei Starovoitov
On Tue, Feb 05, 2019 at 09:46:14PM -0800, Andrii Nakryiko wrote: > On Tue, Feb 5, 2019 at 7:07 PM Alexei Starovoitov > wrote: > > > > On Tue, Feb 05, 2019 at 04:29:49PM -0800, Andrii Nakryiko wrote: > > > This patch exposes two new APIs btf__get_raw_data_size() and > > > btf__get_raw_data() that a

[PATCH v4 1/2] dt-bindings: net: add MDIO bus multiplexer driven by a regmap device

2019-02-05 Thread Pankaj Bansal
Add support for an MDIO bus multiplexer controlled by a regmap device, like an FPGA. Tested on a NXP LX2160AQDS board which uses the "QIXIS" FPGA attached to the i2c bus. Signed-off-by: Pankaj Bansal --- Notes: V4: - No change V3: - No change V2: - New file describing th

[PATCH v4 2/2] netdev/phy: add MDIO bus multiplexer driven by a regmap

2019-02-05 Thread Pankaj Bansal
Add support for an MDIO bus multiplexer controlled by a regmap device, like an FPGA. Tested on a NXP LX2160AQDS board which uses the "QIXIS" FPGA attached to the i2c bus. Signed-off-by: Pankaj Bansal --- Notes: V4: - Use IS_ENABLED macro in mdio-mux.h V3: - make the return type

[PATCH v4 0/2] add MDIO bus multiplexer driven by a regmap device

2019-02-05 Thread Pankaj Bansal
Add support for an MDIO bus multiplexer controlled by a regmap device, like an FPGA. These apis is an extension of the existing driver drivers/net/phy/mdio-mux-mmioreg.c. The problem with mmioreg driver is that it can operate only on memory mapped devices. but if we have a device that controls

Re: [PATCH bpf-next] tools/bpf: silence a libbpf unnecessary warning

2019-02-05 Thread Alexei Starovoitov
On Tue, Feb 05, 2019 at 09:38:30PM -0800, Yonghong Song wrote: > Commit 96408c43447a ("tools/bpf: implement libbpf > btf__get_map_kv_tids() API function") refactored > function bpf_map_find_btf_info() and moved bulk of > implementation into btf.c as btf__get_map_kv_tids(). > This change introduced

Re: [PATCH bpf-next 2/2] tools/bpf: add log_level to bpf_load_program_attr

2019-02-05 Thread Yonghong Song
On 2/5/19 6:26 PM, Alexei Starovoitov wrote: > On Tue, Feb 05, 2019 at 11:48:23AM -0800, Yonghong Song wrote: >> The kernel verifier has three levels of logs: >> 0: no logs >> 1: logs mostly useful >>> 1: verbose >> >> Current libbpf API functions bpf_load_program_xattr() and >> bpf

Re: [RFC bpf-next 0/7] net: flow_dissector: trigger BPF hook when called from eth_get_headlen

2019-02-05 Thread Stanislav Fomichev
On 02/05, Alexei Starovoitov wrote: > On Tue, Feb 05, 2019 at 07:56:19PM -0800, Stanislav Fomichev wrote: > > On 02/05, Alexei Starovoitov wrote: > > > On Tue, Feb 05, 2019 at 04:59:31PM -0800, Stanislav Fomichev wrote: > > > > On 02/05, Alexei Starovoitov wrote: > > > > > On Tue, Feb 05, 2019 at 1

Re: [PATCH v2 bpf-next 2/2] btf: expose API to work with raw btf data

2019-02-05 Thread Andrii Nakryiko
On Tue, Feb 5, 2019 at 7:07 PM Alexei Starovoitov wrote: > > On Tue, Feb 05, 2019 at 04:29:49PM -0800, Andrii Nakryiko wrote: > > This patch exposes two new APIs btf__get_raw_data_size() and > > btf__get_raw_data() that allows to get a copy of raw BTF data out of > > struct btf. This is useful for

[PATCH bpf-next] tools/bpf: silence a libbpf unnecessary warning

2019-02-05 Thread Yonghong Song
Commit 96408c43447a ("tools/bpf: implement libbpf btf__get_map_kv_tids() API function") refactored function bpf_map_find_btf_info() and moved bulk of implementation into btf.c as btf__get_map_kv_tids(). This change introduced a bug such that test_btf will print out the following warning although th

Re: [Patch net v2] xfrm: destroy xfrm_state synchronously on net exit path

2019-02-05 Thread Steffen Klassert
On Thu, Jan 31, 2019 at 01:05:49PM -0800, Cong Wang wrote: > xfrm_state_put() moves struct xfrm_state to the GC list > and schedules the GC work to clean it up. On net exit call > path, xfrm_state_flush() is called to clean up and > xfrm_flush_gc() is called to wait for the GC work to complete > be

Re: [PATCH v2 bpf-next 1/2] btf: separate btf creation and loading

2019-02-05 Thread Andrii Nakryiko
On Tue, Feb 5, 2019 at 7:03 PM Alexei Starovoitov wrote: > > On Tue, Feb 05, 2019 at 04:29:48PM -0800, Andrii Nakryiko wrote: > > This change splits out previous btf__new functionality of constructing > > struct btf and loading it into kernel into two: > > - btf__new() just creates and initializes

KASAN: slab-out-of-bounds Read in ip_send_unicast_reply

2019-02-05 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:b71acb0e3721 Merge branch 'linus' of git://git.kernel.org/.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=11a6994b40 kernel config: https://syzkaller.appspot.com/x/.config?x=b03c5892bb940c76 da

BUG: spinlock bad magic in __queue_work

2019-02-05 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:962c382d482a Merge tag 'mac80211-next-for-davem-2019-02-01.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=169299f8c0 kernel config: https://syzkaller.appspot.com/x/.config?x=33ad02b9305759c3 da

KASAN: use-after-free Read in tcp_sk_exit

2019-02-05 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:33a0efa4baec devlink: Use DIV_ROUND_UP_ULL in DEVLINK_HEAL.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=14e2e55f40 kernel config: https://syzkaller.appspot.com/x/.config?x=505743eba4e4f68 das

Re: [RFC 00/14] netlink/hierarchical stats

2019-02-05 Thread Jakub Kicinski
On Sat, 2 Feb 2019 15:14:44 -0800, Roopa Prabhu wrote: > On Thu, Jan 31, 2019 at 11:31 AM Jakub Kicinski wrote: > > On Thu, 31 Jan 2019 08:31:51 -0800, Roopa Prabhu wrote: > > > On Thu, Jan 31, 2019 at 8:16 AM Roopa Prabhu wrote: > > > > On Wed, Jan 30, 2019 at 4:24 PM Jakub Kicinski wrote: >

Re: [PATCH bpf-next] tools/bpf: fix a selftest test_btf failure

2019-02-05 Thread Yonghong Song
On 2/5/19 6:36 PM, Alexei Starovoitov wrote: > On Tue, Feb 05, 2019 at 02:28:44PM -0800, Yonghong Song wrote: >> Commit 9c651127445c ("selftests/btf: add initial BTF dedup tests") >> added dedup tests in test_btf.c. >> It broke the raw test: >> BTF raw test[71] (func proto (Bad arg name_off)):

Re: [net-next 00/14][pull request] Intel Wired LAN Driver Updates 2019-02-05

2019-02-05 Thread David Miller
From: Jeff Kirsher Date: Tue, 5 Feb 2019 18:04:10 -0800 > This series contains updates to igc, e1000e, ixgbe, fm10k and driver > documentation. > > Kai-Heng Feng fixes an e1000e issue where the Wake-On-LAN settings where > being set incorrectly during a system suspend. > > Sasha addresses comm

Re: [RFC bpf-next 0/7] net: flow_dissector: trigger BPF hook when called from eth_get_headlen

2019-02-05 Thread Alexei Starovoitov
On Tue, Feb 05, 2019 at 07:56:19PM -0800, Stanislav Fomichev wrote: > On 02/05, Alexei Starovoitov wrote: > > On Tue, Feb 05, 2019 at 04:59:31PM -0800, Stanislav Fomichev wrote: > > > On 02/05, Alexei Starovoitov wrote: > > > > On Tue, Feb 05, 2019 at 12:40:03PM -0800, Stanislav Fomichev wrote: > >

Re: Pull patches from tip/perf/core to bpf-next

2019-02-05 Thread Song Liu
> On Feb 5, 2019, at 7:47 PM, Alexei Starovoitov > wrote: > > On Wed, Feb 06, 2019 at 03:44:29AM +, Song Liu wrote: >> >> >>> On Feb 5, 2019, at 7:36 PM, Alexei Starovoitov >>> wrote: >>> >>> On Tue, Feb 05, 2019 at 10:47:06PM +, Song Liu wrote: Hi Alexei and Daniel,

[PATCH bpf-next 0/5] net: xdp: allow offload to coexist with generic

2019-02-05 Thread Jakub Kicinski
Hi! Offloaded and native/driver XDP programs can already coexist. Allow offload and generic hook to coexist as well, there seem to be no reason why not to do so. Jakub Kicinski (5): selftests/bpf: fix the expected messages net: xdp: allow generic and driver XDP on one interface selftests/bp

[PATCH bpf-next 3/5] selftests/bpf: print traceback when test fails

2019-02-05 Thread Jakub Kicinski
Figuring out which exact check in test_offload.py takes more time than it should. Print the traceback (to the screen and the logs). Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet --- tools/testing/selftests/bpf/test_offload.py | 5 - 1 file changed, 4 insertions(+), 1 deletion(-

[PATCH bpf-next 5/5] selftests/bpf: test reading the offloaded program

2019-02-05 Thread Jakub Kicinski
Test adding the offloaded program after the other program is already installed. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet --- tools/testing/selftests/bpf/test_offload.py | 29 ++--- 1 file changed, 20 insertions(+), 9 deletions(-) diff --git a/tools/testing/self

[PATCH bpf-next 2/5] net: xdp: allow generic and driver XDP on one interface

2019-02-05 Thread Jakub Kicinski
Since commit a25717d2b604 ("xdp: support simultaneous driver and hw XDP attachment") users can load an XDP program for offload and in native driver mode simultaneously. Allow a similar mix of offload and SKB mode/generic XDP. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet --- net/co

[PATCH bpf-next 1/5] selftests/bpf: fix the expected messages

2019-02-05 Thread Jakub Kicinski
Recent changes added extack to program replacement path, expect extack instead of generic messages. Fixes: 01dde20ce04b ("xdp: Provide extack messages when prog attachment failed") Signed-off-by: Jakub Kicinski --- tools/testing/selftests/bpf/test_offload.py | 7 +-- 1 file changed, 5 insert

[PATCH bpf-next 4/5] selftests/bpf: add test for mixing generic and offload XDP

2019-02-05 Thread Jakub Kicinski
Add simple sanity check for enabling generic and offload XDP, simply reuse the native and offload checks. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet --- tools/testing/selftests/bpf/test_offload.py | 116 +++- 1 file changed, 62 insertions(+), 54 deletions(-) diff

RE: [PATCH v2] arm64: dts: lx2160aqds: Add mdio mux nodes

2019-02-05 Thread Pankaj Bansal
> -Original Message- > From: Li Yang [mailto:leoyang...@nxp.com] > Sent: Wednesday, 6 February, 2019 12:07 AM > To: Pankaj Bansal > Cc: Shawn Guo ; Andrew Lunn ; > Florian Fainelli ; netdev@vger.kernel.org; linux-arm- > ker...@lists.infradead.org > Subject: Re: [PATCH v2] arm64: dts: lx2

Re: [RFC bpf-next 0/7] net: flow_dissector: trigger BPF hook when called from eth_get_headlen

2019-02-05 Thread Stanislav Fomichev
On 02/05, Alexei Starovoitov wrote: > On Tue, Feb 05, 2019 at 04:59:31PM -0800, Stanislav Fomichev wrote: > > On 02/05, Alexei Starovoitov wrote: > > > On Tue, Feb 05, 2019 at 12:40:03PM -0800, Stanislav Fomichev wrote: > > > > On 02/05, Willem de Bruijn wrote: > > > > > On Tue, Feb 5, 2019 at 12:5

Re: Pull patches from tip/perf/core to bpf-next

2019-02-05 Thread Alexei Starovoitov
On Wed, Feb 06, 2019 at 03:44:29AM +, Song Liu wrote: > > > > On Feb 5, 2019, at 7:36 PM, Alexei Starovoitov > > wrote: > > > > On Tue, Feb 05, 2019 at 10:47:06PM +, Song Liu wrote: > >> Hi Alexei and Daniel, > >> > >> The following patches are required for BPF introspection in perf

Re: Pull patches from tip/perf/core to bpf-next

2019-02-05 Thread Song Liu
> On Feb 5, 2019, at 7:36 PM, Alexei Starovoitov > wrote: > > On Tue, Feb 05, 2019 at 10:47:06PM +, Song Liu wrote: >> Hi Alexei and Daniel, >> >> The following patches are required for BPF introspection in perf tools. >> Please pull them to bpf-next, so that we get all the dependencie

Re: KASAN: use-after-free Read in __wake_up_common_lock

2019-02-05 Thread Eric Dumazet
On 02/05/2019 07:28 PM, Dmitry Vyukov wrote: > On Wed, Jan 30, 2019 at 10:02 PM syzbot > wrote: >> >> Hello, >> >> syzbot found the following crash on: >> >> HEAD commit:62967898789d Merge git://git.kernel.org/pub/scm/linux/kern.. >> git tree: upstream >> console output: https://syzka

Re: [PATCH bpf-next 2/4] bpf: fix lockdep false positive in stackmap

2019-02-05 Thread Eric Dumazet
On 02/05/2019 07:30 PM, Alexei Starovoitov wrote: > Thanks for the reminder :) > > I've been waiting for Peter's direction on this one. > Happy to fix it whichever way. > > To recap: > Approach 1: > s/up_read/up_read_non_owner/ from irq_work + rwsem_release as Longman > proposed. > > Appora

Re: Pull patches from tip/perf/core to bpf-next

2019-02-05 Thread Alexei Starovoitov
On Tue, Feb 05, 2019 at 10:47:06PM +, Song Liu wrote: > Hi Alexei and Daniel, > > The following patches are required for BPF introspection in perf tools. > Please pull them to bpf-next, so that we get all the dependencies in one > tree. > > Thanks, > Song > > (from 1/10 to 10/10) > 76193a

Re: [PATCH v3 2/2] netdev/phy: add MDIO bus multiplexer driven by a regmap

2019-02-05 Thread Florian Fainelli
On 2/5/19 2:05 AM, Pankaj Bansal wrote: > Add support for an MDIO bus multiplexer controlled by a regmap > device, like an FPGA. > > Tested on a NXP LX2160AQDS board which uses the "QIXIS" FPGA > attached to the i2c bus. > > Signed-off-by: Pankaj Bansal With Andrew's comment fixed: Reviewed

Re: [PATCH bpf-next 2/4] bpf: fix lockdep false positive in stackmap

2019-02-05 Thread Alexei Starovoitov
On Tue, Feb 05, 2019 at 07:21:08PM -0800, Eric Dumazet wrote: > >>> > >>> diff --git a/kernel/bpf/stackmap.c b/kernel/bpf/stackmap.c > >>> index d43b145..79eef9d 100644 > >>> --- a/kernel/bpf/stackmap.c > >>> +++ b/kernel/bpf/stackmap.c > >>> @@ -338,6 +338,13 @@ static void stack_map_get_build_id_

Re: KASAN: use-after-free Read in __wake_up_common_lock

2019-02-05 Thread Dmitry Vyukov
On Wed, Jan 30, 2019 at 10:02 PM syzbot wrote: > > Hello, > > syzbot found the following crash on: > > HEAD commit:62967898789d Merge git://git.kernel.org/pub/scm/linux/kern.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=10f0bf08c0 > kernel config:

Re: [PATCH bpf-next 2/4] bpf: fix lockdep false positive in stackmap

2019-02-05 Thread Eric Dumazet
On 01/30/2019 06:48 PM, Waiman Long wrote: > On 01/30/2019 09:01 PM, Alexei Starovoitov wrote: >> On Wed, Jan 30, 2019 at 04:32:12PM -0500, Waiman Long wrote: >>> On 01/30/2019 04:11 PM, Waiman Long wrote: On 01/30/2019 03:10 PM, Alexei Starovoitov wrote: > On Wed, Jan 30, 2019 at 02:42

Re: [RFC bpf-next 0/7] net: flow_dissector: trigger BPF hook when called from eth_get_headlen

2019-02-05 Thread Alexei Starovoitov
On Tue, Feb 05, 2019 at 04:59:31PM -0800, Stanislav Fomichev wrote: > On 02/05, Alexei Starovoitov wrote: > > On Tue, Feb 05, 2019 at 12:40:03PM -0800, Stanislav Fomichev wrote: > > > On 02/05, Willem de Bruijn wrote: > > > > On Tue, Feb 5, 2019 at 12:57 PM Stanislav Fomichev > > > > wrote: > > >

Re: [PATCH v2 bpf-next 2/2] btf: expose API to work with raw btf data

2019-02-05 Thread Alexei Starovoitov
On Tue, Feb 05, 2019 at 04:29:49PM -0800, Andrii Nakryiko wrote: > This patch exposes two new APIs btf__get_raw_data_size() and > btf__get_raw_data() that allows to get a copy of raw BTF data out of > struct btf. This is useful for external programs that need to manipulate > raw data, e.g., pahole

Re: [PATCH v2 bpf-next 1/2] btf: separate btf creation and loading

2019-02-05 Thread Alexei Starovoitov
On Tue, Feb 05, 2019 at 04:29:48PM -0800, Andrii Nakryiko wrote: > This change splits out previous btf__new functionality of constructing > struct btf and loading it into kernel into two: > - btf__new() just creates and initializes struct btf > - btf__load() attempts to load existing struct btf int

Re: [PATCH bpf-next 1/2] tools/bpf: add const qualifier to btf__get_map_kv_tids() map_name parameter

2019-02-05 Thread Alexei Starovoitov
On Tue, Feb 5, 2019 at 6:27 PM Alexei Starovoitov wrote: > > On Tue, Feb 05, 2019 at 11:48:22AM -0800, Yonghong Song wrote: > > Commit 96408c43447a ("tools/bpf: implement libbpf btf__get_map_kv_tids() > > API function") > > added the API function btf__get_map_kv_tids(): > > btf__get_map_kv_tids

Re: [PATCH bpf-next] tools/bpf: fix a selftest test_btf failure

2019-02-05 Thread Alexei Starovoitov
On Tue, Feb 05, 2019 at 02:28:44PM -0800, Yonghong Song wrote: > Commit 9c651127445c ("selftests/btf: add initial BTF dedup tests") > added dedup tests in test_btf.c. > It broke the raw test: > BTF raw test[71] (func proto (Bad arg name_off)): > btf_raw_create:2905:FAIL Error getting string #6

Re: [PATCH bpf-next 1/2] tools/bpf: add const qualifier to btf__get_map_kv_tids() map_name parameter

2019-02-05 Thread Alexei Starovoitov
On Tue, Feb 05, 2019 at 11:48:22AM -0800, Yonghong Song wrote: > Commit 96408c43447a ("tools/bpf: implement libbpf btf__get_map_kv_tids() API > function") > added the API function btf__get_map_kv_tids(): > btf__get_map_kv_tids(const struct btf *btf, char *map_name, ...) > > The parameter map_na

Re: [PATCH bpf-next 2/2] tools/bpf: add log_level to bpf_load_program_attr

2019-02-05 Thread Alexei Starovoitov
On Tue, Feb 05, 2019 at 11:48:23AM -0800, Yonghong Song wrote: > The kernel verifier has three levels of logs: > 0: no logs > 1: logs mostly useful > > 1: verbose > > Current libbpf API functions bpf_load_program_xattr() and > bpf_load_program() cannot specify log_level. > The bcc, howev

Re: TC stats / hw offload question

2019-02-05 Thread Jamal Hadi Salim
On 2019-02-05 2:41 p.m., Edward Cree wrote: Regarding TC_CLSFLOWER_STATS, when a filter rule modifies the length of  the packet, e.g. by adding a VLAN or encap header, should the bytes  counter count the length of the packet _before_ edits (i.e. as seen by  the match), or the length after edit

Re: [PATCH 2/2 net-next] net: phy: make use of new MMD accessors

2019-02-05 Thread Andrew Lunn
On Tue, Feb 05, 2019 at 10:13:07PM +0100, Heiner Kallweit wrote: > Make use of the new MMD accessors. > > Andrew Lunn This is missing the Signed-off-by: prefix. > Signed-off-by: Heiner Kallweit Reviewed-by: Andrew Lunn Andrew

[net-next 08/14] igc: Remove unused code

2019-02-05 Thread Jeff Kirsher
From: Sasha Neftin Remove unused igc_adv_data_desc definition from igc_base.h file. Descriptors definition will be added per demand. Signed-off-by: Sasha Neftin Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igc/igc_base.h | 22 -- 1 fil

[net-next 00/14][pull request] Intel Wired LAN Driver Updates 2019-02-05

2019-02-05 Thread Jeff Kirsher
This series contains updates to igc, e1000e, ixgbe, fm10k and driver documentation. Kai-Heng Feng fixes an e1000e issue where the Wake-On-LAN settings where being set incorrectly during a system suspend. Sasha addresses community feedback on the igc driver and provides a number of code cleanups t

[net-next 06/14] fm10k: TRIVIAL cleanup of extra spacing in function comment

2019-02-05 Thread Jeff Kirsher
From: Jacob Keller The function comment for fm10k_iov_msg_msix_pf has an extra space in a sentence, which is unnecessary. Signed-off-by: Jacob Keller Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/fm10k/fm10k_pf.c | 2 +- 1 file changed, 1 insertion(+), 1

[net-next 01/14] e1000e: Exclude device from suspend direct complete optimization

2019-02-05 Thread Jeff Kirsher
From: Kai-Heng Feng e1000e sets different WoL settings in system suspend callback and runtime suspend callback. The suspend direct complete optimization leaves e1000e in runtime suspended state with wrong WoL setting during system suspend. To fix this, we need to disable suspend direct complete

[net-next 12/14] igc: Remove the 'igc_get_phy_id_base' method

2019-02-05 Thread Jeff Kirsher
From: Sasha Neftin Remove the redundant 'igc_get_phy_id_base' method and use the 'igc_get_phy_id' method directly instead. Signed-off-by: Sasha Neftin Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igc/igc_base.c | 18 +- 1 file changed, 1 i

[net-next 14/14] igc: Add ethtool support

2019-02-05 Thread Jeff Kirsher
From: Sasha Neftin This patch adds basic ethtool support to the device to allow for configuration. Signed-off-by: Sasha Neftin Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igc/Makefile |3 +- drivers/net/ethernet/intel/igc/igc.h | 34 +-

[net-next 13/14] igb: Bump version number

2019-02-05 Thread Jeff Kirsher
From: Todd Fujinaka With recent changes, need to bump the driver version to reflect the changes. Signed-off-by: Todd Fujinaka Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igb/igb_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[net-next 04/14] igc: Fix code redundancy

2019-02-05 Thread Jeff Kirsher
From: Sasha Neftin Remove redundant igc_check_for_link_base code and replace it with an igc_check_for_copper_link method. Fix duplication of IGC_ADVTXD_PAYLEN_SHIFT mask declaration. Remove obsolete IGC_SCVPC register definition. Signed-off-by: Sasha Neftin Tested-by: Aaron Brown Signed-off-by

[net-next 10/14] e1000e: fix cyclic resets at link up with active tx

2019-02-05 Thread Jeff Kirsher
From: Konstantin Khlebnikov I'm seeing series of e1000e resets (sometimes endless) at system boot if something generates tx traffic at this time. In my case this is netconsole who sends message "e1000e :02:00.0: Some CPU C-states have been disabled in order to enable jumbo frames" from e1000e

[net-next 05/14] ixgbe: remove magic constant in ixgbe_reset_hw_82599()

2019-02-05 Thread Jeff Kirsher
From: Jiri Kosina ixgbe_reset_hw_82599() resets the value of hw->mac.num_rar_entries to pre-defined value of 128. Let's get rid of that hardcoded literal, and use IXGBE_82599_RAR_ENTRIES instead, the same way the normal initialization path does. Signed-off-by: Jiri Kosina Tested-by: Andrew Bowe

[net-next 11/14] igc: Remove the 'igc_read_mac_addr_base' method

2019-02-05 Thread Jeff Kirsher
From: Sasha Neftin Remove the redundant 'igc_read_mac_addr_base' method and use the 'igc_read_mac_addr' method directly instead. Signed-off-by: Sasha Neftin Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igc/igc_base.c | 15 +-- 1 file changed,

[net-next 09/14] igc: Remove unneeded code

2019-02-05 Thread Jeff Kirsher
From: Sasha Neftin Remove the 'igc_get_link_up_info_base method' from igc_base.c file. Use the 'igc_get_speed_and_duplex_copper' method directly and reduce the code redundancy. Signed-off-by: Sasha Neftin Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igc/i

[net-next 02/14] igc: Remove unreachable code from igc_phy.c file

2019-02-05 Thread Jeff Kirsher
From: Sasha Neftin Address community comment. Remove the unreachable code leads to the static checker warning. PHY functionality will be added later per demand. Reported by Dan Carpenter. Signed-off-by: Sasha Neftin Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/

[net-next 03/14] docs/networking: fix formatting of Intel drivers documentation

2019-02-05 Thread Jeff Kirsher
From: Mike Rapoport The documentation of Intel drivers is missing the heading adornment for document titles. This causes the generated html to have TOC entries from these documents to appear as top level TOC entries: * Linux* Base Driver for Intel(R) Ethernet Network Connection * Contents * Ide

[net-next 07/14] e1000e: fix a missing check for return value

2019-02-05 Thread Jeff Kirsher
The change is based on the issue found by Kangjie Lu where we not checking the return value of a register read/write which could result in a NULL pointer dereference if the read/write fails. Since we are only trying to disable the far-end loopback, if the read and write of register fails, we do n

Re: [PATCH 2/2] doc: add phylink documentation to the networking book

2019-02-05 Thread Andrew Lunn
On Tue, Feb 05, 2019 at 03:58:20PM +, Russell King wrote: > Add some phylink documentation to the networking book detailing how > to convert network drivers from phylib to phylink. > > Signed-off-by: Russell King Reviewed-by: Andrew Lunn Andrew

[PATCH bpf-next] tools: bpftool: doc, fix incorrect text

2019-02-05 Thread Prashant Bhole
Documentation about cgroup, feature, prog uses wrong header 'MAP COMMANDS' while listing commands. This patch corrects the header in respective doc files. Signed-off-by: Prashant Bhole --- tools/bpf/bpftool/Documentation/bpftool-cgroup.rst | 4 ++-- tools/bpf/bpftool/Documentation/bpftool-featu

[PATCH bpf-next] tools: bpftool: doc, add text about feature-subcommand

2019-02-05 Thread Prashant Bhole
This patch adds missing information about feature-subcommand in bpftool.rst Signed-off-by: Prashant Bhole --- tools/bpf/bpftool/Documentation/bpftool.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/bpf/bpftool/Documentation/bpftool.rst b/tools/bpf/bpftool/Docume

Re: [RFC PATCH 0/4] Initial support for allocating BPF JITs in vmalloc for x86

2019-02-05 Thread Alexei Starovoitov
On 2/5/19 5:11 PM, Edgecombe, Rick P wrote: > On Wed, 2019-02-06 at 00:35 +, Alexei Starovoitov wrote: >> On 2/5/19 2:50 PM, Rick Edgecombe wrote: >>> This introduces a new capability for BPF program JIT's to be located in >>> vmalloc >>> space on x86_64. This can serve as a backup area for >>>

Re: [RFC PATCH 0/4] Initial support for allocating BPF JITs in vmalloc for x86

2019-02-05 Thread Edgecombe, Rick P
On Wed, 2019-02-06 at 00:35 +, Alexei Starovoitov wrote: > On 2/5/19 2:50 PM, Rick Edgecombe wrote: > > This introduces a new capability for BPF program JIT's to be located in > > vmalloc > > space on x86_64. This can serve as a backup area for > > CONFIG_BPF_JIT_ALWAYS_ON in > > case an unpriv

Re: [RFC bpf-next 0/7] net: flow_dissector: trigger BPF hook when called from eth_get_headlen

2019-02-05 Thread Stanislav Fomichev
On 02/05, Alexei Starovoitov wrote: > On Tue, Feb 05, 2019 at 12:40:03PM -0800, Stanislav Fomichev wrote: > > On 02/05, Willem de Bruijn wrote: > > > On Tue, Feb 5, 2019 at 12:57 PM Stanislav Fomichev > > > wrote: > > > > > > > > Currently, when eth_get_headlen calls flow dissector, it doesn't pa

Re: [RFC bpf-next 0/7] net: flow_dissector: trigger BPF hook when called from eth_get_headlen

2019-02-05 Thread Alexei Starovoitov
On Tue, Feb 05, 2019 at 12:40:03PM -0800, Stanislav Fomichev wrote: > On 02/05, Willem de Bruijn wrote: > > On Tue, Feb 5, 2019 at 12:57 PM Stanislav Fomichev wrote: > > > > > > Currently, when eth_get_headlen calls flow dissector, it doesn't pass any > > > skb. Because we use passed skb to lookup

[PATCH] net: hso: do not unregister if not registered

2019-02-05 Thread Yavuz, Tuba
On an error path inside the hso_create_net_device function of the hso driver, hso_free_net_device gets called. This causes potentially a negative reference count in the net device if register_netdev has not been called yet as hso_free_net_device calls unregister_netdev regardless. I think the dri

Re: [PATCH net] mISDN: fix a race in dev_expire_timer()

2019-02-05 Thread David Miller
From: Eric Dumazet Date: Tue, 5 Feb 2019 15:38:44 -0800 > Since mISDN_close() uses dev->pending to iterate over active > timers, there is a chance that one timer got removed from the > ->pending list in dev_expire_timer() but that the thread > has not called yet wake_up_interruptible() > > So m

Re: [PATCH bpf-next] tools/bpf: fix a selftest test_btf failure

2019-02-05 Thread Andrii Nakryiko
On Tue, Feb 5, 2019 at 2:30 PM Yonghong Song wrote: > > Commit 9c651127445c ("selftests/btf: add initial BTF dedup tests") > added dedup tests in test_btf.c. > It broke the raw test: > BTF raw test[71] (func proto (Bad arg name_off)): > btf_raw_create:2905:FAIL Error getting string #65535, st

Re: [PATCH net] net: dsa: mv88e6xxx: Fix counting of ATU violations

2019-02-05 Thread David Miller
From: Andrew Lunn Date: Wed, 6 Feb 2019 00:02:58 +0100 > The ATU port vector contains a bit per port of the switch. The code > wrongly used it as a port number, and incremented a port counter. This > resulted in the wrong interfaces counter being incremented, and > potentially going off the end

Re: [PATCH]: net: hso: do not call unregister if not registered

2019-02-05 Thread Yavuz, Tuba
This is surprising as I got total: 0 errors, 0 warnings, 0 checks, 10 lines checked. Anyhow, I'll submit as suggested. Best, Tuba Yavuz, Ph.D. Assistant Professor Electrical and Computer Engineering Department University of Florida Gainesville, FL 32611 Webpage: http://www.tuba.ece.ufl.edu/ Em

Re: [RFC PATCH 0/4] Initial support for allocating BPF JITs in vmalloc for x86

2019-02-05 Thread Alexei Starovoitov
On 2/5/19 2:50 PM, Rick Edgecombe wrote: > This introduces a new capability for BPF program JIT's to be located in > vmalloc > space on x86_64. This can serve as a backup area for CONFIG_BPF_JIT_ALWAYS_ON > in > case an unprivileged app uses all of the module space allowed by > bpf_jit_limit. >

Re: [PATCH]: net: hso: do not call unregister if not registered

2019-02-05 Thread David Miller
From: "Yavuz, Tuba" Date: Tue, 5 Feb 2019 23:01:25 + > > > On an error path inside the hso_create_net_device function of the hso > driver, hso_free_net_device gets called. This causes potentially a > negative reference count in the net device if register_netdev has not > been called yet as

[Patch net-next] mlx5: use RCU lock in mlx5_eq_cq_get()

2019-02-05 Thread Cong Wang
mlx5_eq_cq_get() is called in IRQ handler, the spinlock inside gets a lot of contentions when we test some heavy workload with 60 RX queues and 80 CPU's, and it is clearly shown in the flame graph. In fact, radix_tree_lookup() is perfectly fine with RCU read lock, we don't have to take a spinlock

[PATCH v2 bpf-next 1/2] btf: separate btf creation and loading

2019-02-05 Thread Andrii Nakryiko
This change splits out previous btf__new functionality of constructing struct btf and loading it into kernel into two: - btf__new() just creates and initializes struct btf - btf__load() attempts to load existing struct btf into kernel btf__free will still close BTF fd, if it was ever loaded succes

[PATCH v2 bpf-next 2/2] btf: expose API to work with raw btf data

2019-02-05 Thread Andrii Nakryiko
This patch exposes two new APIs btf__get_raw_data_size() and btf__get_raw_data() that allows to get a copy of raw BTF data out of struct btf. This is useful for external programs that need to manipulate raw data, e.g., pahole using btf__dedup() to deduplicate BTF type info and then writing it back

[PATCH v2 bpf-next 0/2] tools/btf: extends libbpf APIs to work with btf w/o kernel

2019-02-05 Thread Andrii Nakryiko
This patchset changes existing btf__new() API call to only load and initialize struct btf, while exposing new btf__load() API to attempt to load and validate BTF in kernel. It also adds ability to copy raw BTF data out of struct btf for further processing by external applications. This makes utili

Re: [RFC PATCH iproute2 2/5] act_ct: first import

2019-02-05 Thread Marcelo Ricardo Leitner
On Tue, Feb 05, 2019 at 02:56:13PM -0800, Stephen Hemminger wrote: > On Fri, 25 Jan 2019 00:33:30 -0200 > Marcelo Ricardo Leitner wrote: > > > +/* > > + * m_ct.c Connection Tracking target module > > + * > > + * This program is free software; you can distribute it and/or > > + *

Re: [PATCH net] virtio_net: Account for tx bytes and packets on sending xdp_frames

2019-02-05 Thread Saeed Mahameed
On Mon, 2019-02-04 at 19:13 -0800, David Ahern wrote: > On 2/4/19 3:53 AM, Jesper Dangaard Brouer wrote: > > On Sat, 2 Feb 2019 14:27:26 -0700 > > David Ahern wrote: > > > > > On 1/31/19 1:15 PM, Jesper Dangaard Brouer wrote: > > > > > David, Jesper, care to chime in where we ended up in that > >

[PATCH v2 6/6] ethtool: fix up dump_coalesce output to match actual option names

2019-02-05 Thread Jeff Kirsher
From: Nicholas Nunley When the coalesce settings are printed with --show-coalesce a few of the option names lack the pluralization that is present in the man page and usage info, but are otherwise identical. This inconsistency could lead to some confusion if a user attempts to set the coalesce s

[PATCH v2 3/6] ethtool: introduce new ioctl for per-queue settings

2019-02-05 Thread Jeff Kirsher
From: Nicholas Nunley Introduce a new ioctl for setting per-queue parameters. Users can apply commands to specific queues by setting SUB_COMMAND and queue_mask with the following ethtool command: ethtool --set-perqueue-command DEVNAME [queue_mask %x] SUB_COMMAND If queue_mask is not set, the S

[PATCH v2 5/6] ethtool: support per-queue sub command --coalesce

2019-02-05 Thread Jeff Kirsher
From: Nicholas Nunley This patch adds the ability to configure the coalesce settings from do_scoalesce on a per-queue basis. For each masked queue the current settings are read, modified, and written back to the kernel. Example: $ sudo ./ethtool --set-perqueue-command eth5 queue_mask 0x1 --co

[PATCH v2 4/6] ethtool: support per-queue sub command --show-coalesce

2019-02-05 Thread Jeff Kirsher
From: Nicholas Nunley Get all masked queues' coalesce settings from kernel and dump them one by one. Example: $ sudo ./ethtool --set-perqueue-command eth5 queue_mask 0x11 --show-coalesce Queue: 0 Adaptive RX: off TX: off stats-block-usecs: 0 sample-interval: 0 pkt-rate-low: 0 pkt-rat

[PATCH v2 2/6] ethtool: move cmdline_coalesce out of do_scoalesce

2019-02-05 Thread Jeff Kirsher
From: Nicholas Nunley Move the definition of cmdline_coalesce out of do_scoalesce and into a macro so it can be reused across functions. No behavior change. Based on patch by Kan Liang Signed-off-by: Nicholas Nunley Signed-off-by: Jeff Kirsher --- ethtool.c | 142 ++

[PATCH v2 1/6] ethtool: move option parsing related code into function

2019-02-05 Thread Jeff Kirsher
From: Nicholas Nunley Move option parsing code into find_option function. No behavior changes. Based on patch by Kan Liang Signed-off-by: Nicholas Nunley Signed-off-by: Jeff Kirsher --- ethtool.c | 49 +++-- 1 file changed, 31 insertions(+), 18 d

[PATCH net-next v3 08/12] rocker: Implement ndo_get_port_parent_id()

2019-02-05 Thread Florian Fainelli
mlxsw implements SWITCHDEV_ATTR_ID_PORT_PARENT_ID and we want to get rid of switchdev_ops eventually, ease that migration by implementing a ndo_get_port_parent_id() function which returns what switchdev_port_attr_get() would do. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/rocker/roc

[PATCH net-next v3 02/12] bnxt: Implement ndo_get_port_parent_id()

2019-02-05 Thread Florian Fainelli
BNXT only supports SWITCHDEV_ATTR_ID_PORT_PARENT_ID, which makes it a great candidate to be converted to use the ndo_get_port_parent_id() NDO instead of implementing switchdev_port_attr_get(). The conversion is straight forward here since the PF and VF code use the same getter. Since bnxt makes us

[PATCH net-next v3 03/12] liquidio: Implement ndo_get_port_parent_id()

2019-02-05 Thread Florian Fainelli
Liquidio only supports SWITCHDEV_ATTR_ID_PORT_PARENT_ID, which makes it a great candidate to be converted to use the ndo_get_port_parent_id() NDO instead of implementing switchdev_port_attr_get(). Signed-off-by: Florian Fainelli --- .../net/ethernet/cavium/liquidio/lio_main.c | 22

[PATCH net-next v3 05/12] mlxsw: Implement ndo_get_port_parent_id()

2019-02-05 Thread Florian Fainelli
mlxsw implements SWITCHDEV_ATTR_ID_PORT_PARENT_ID and we want to get rid of switchdev_ops eventually, ease that migration by implementing a ndo_get_port_parent_id() function which returns what switchdev_port_attr_get() would do. Signed-off-by: Florian Fainelli --- .../net/ethernet/mellanox/mlxsw

  1   2   3   4   >