Re: [Intel-wired-lan] [PATCH] i40e: replace switch-statement with if-clause

2019-01-21 Thread Björn Töpel
Den mån 21 jan. 2019 kl 20:12 skrev Jesper Dangaard Brouer : > > On Mon, 21 Jan 2019 17:53:45 +0100 > Björn Töpel wrote: > > > > If that jump tables are a common problem, I wonder, why the compiler > > > cannot be adapted to generate better performing code or an option passed > > > to the compiler

Re: [PATCH] PCI / ACPI: Don't clear pme_poll on device that has unreliable ACPI wake

2019-01-21 Thread Kai-Heng Feng
> On Jan 22, 2019, at 14:45, Kai-Heng Feng wrote: > > There are some e1000e devices can only be woken up from D3 one time, by > plugging ethernet cable. Subsequent cable plugging does set PME bit > correctly, but it still doesn't get woken up. > > Since e1000e connects to the root complex dir

[PATCH rdma-next 09/12] IB/mlx5: Advertise SRQ ODP support for supported transports

2019-01-21 Thread Leon Romanovsky
From: Moni Shoua ODP support in SRQ is per transport capability. Based on device capabilities set this flag in device structure for future queries. Signed-off-by: Moni Shoua Reviewed-by: Majd Dibbiny Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/odp.c | 6 ++ 1 file chang

[PATCH rdma-next 11/12] IB/mlx5: Advertise XRC ODP support

2019-01-21 Thread Leon Romanovsky
From: Moni Shoua Query all per transport caps for XRC and set the appropriate bits in the per transport field of the advertised struct. Signed-off-by: Moni Shoua Reviewed-by: Majd Dibbiny Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/odp.c | 18 ++ 1 file chan

[PATCH mlx5-next 10/12] net/mlx5: Add XRC transport to ODP device capabilities layout

2019-01-21 Thread Leon Romanovsky
From: Moni Shoua The device capabilities for ODP structure was missing the field for XRC transport so add it here. Signed-off-by: Moni Shoua Reviewed-by: Majd Dibbiny Signed-off-by: Leon Romanovsky --- include/linux/mlx5/mlx5_ifc.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) di

[PATCH rdma-next 05/12] IB/mlx5: Clean mlx5_ib_mr_responder_pfault_handler() signature

2019-01-21 Thread Leon Romanovsky
From: Moni Shoua In the function mlx5_ib_mr_responder_pfault_handler() 1. The parameter wqe is used as read-only so there is no need to pass it by reference. 2. Remove the unused argument pfault from list of arguments. Signed-off-by: Moni Shoua Reviewed-by: Majd Dibbiny Signed-off-by: Leo

[PATCH rdma-next 08/12] IB/mlx5: Add ODP SRQ support

2019-01-21 Thread Leon Romanovsky
From: Moni Shoua Add changes to the WQE page-fault handler to 1. Identify that the event is for a SRQ WQE 2. Pass SRQ object instead of a QP to the function that reads the WQE 3. Parse the SRQ WQE with respect to its structure The rest is handled as for regular RQ WQE. Signed-off-by: Moni Shou

[PATCH rdma-next 02/12] IB/core: Allocate bit for SRQ ODP support

2019-01-21 Thread Leon Romanovsky
From: Moni Shoua ODP support matrix is per operation and per transport. The support for each transport (RC, UD, etc.) is described with a bit field. ODP for SRQ WQEs is considered a different kind of support from ODP for RQ WQs and therefore need a different capability bit. Signed-off-by: Moni

[PATCH rdma-next 00/12] Add SRQ and XRC support for ODP MRs

2019-01-21 Thread Leon Romanovsky
From: Leon Romanovsky Hi, This series extend ODP to work with SRQ and XRC. Being both per-operation (e.g. RDMA write, RDMA read and atomic) and per-transport (e.g. RC, UD and XRC), we extend IB/core and mlx5 driver to provide needed information to user space. Thanks Moni Shoua (12): IB/mlx5:

[PATCH mlx5-next 12/12] net/mlx5: Set ODP SRQ support in firmware

2019-01-21 Thread Leon Romanovsky
From: Moni Shoua To avoid compatibility issue with older kernels the firmware doesn't allow SRQ to work with ODP unless kernel asks for it. Signed-off-by: Moni Shoua Reviewed-by: Majd Dibbiny Signed-off-by: Leon Romanovsky --- .../net/ethernet/mellanox/mlx5/core/main.c| 53 ++

[PATCH rdma-next 06/12] IB/mlx5: Add XRC initiator ODP support

2019-01-21 Thread Leon Romanovsky
From: Moni Shoua Skip XRC segment in the beginning of a send WQE and fetch ODP XRC capabilities when QP type is IB_QPT_XRC_INI. The rest of the handling is the same as in RC QP. Signed-off-by: Moni Shoua Reviewed-by: Majd Dibbiny Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/

[PATCH rdma-next 01/12] IB/mlx5: Fix locking SRQ object in ODP event

2019-01-21 Thread Leon Romanovsky
From: Moni Shoua QP and SRQ objects are stored in different containers so the action to get and lock a common resource during ODP event needs to address that. While that get rid of 'refcount' and 'free' fields in mlx5_core_srq struct and use the fields with same semantics in common structure. F

[PATCH rdma-next 03/12] IB/uverbs: Expose XRC ODP device capabilities

2019-01-21 Thread Leon Romanovsky
From: Moni Shoua Expose XRC ODP capabilities as part of the extended device capabilities. Signed-off-by: Moni Shoua Reviewed-by: Majd Dibbiny Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/uverbs_cmd.c | 1 + include/rdma/ib_verbs.h | 1 + include/uapi/rdma/ib_user_v

[PATCH rdma-next 07/12] IB/mlx5: Let read user wqe also from SRQ buffer

2019-01-21 Thread Leon Romanovsky
From: Moni Shoua Reading a WQE from SRQ is almost identical to reading from regular RQ. The differences are the size of the queue, the size of a WQE and buffer location. Make necessary changes to mlx5_ib_read_user_wqe() to let it read a WQE from a SRQ or RQ by caller choice. Signed-off-by: Moni

[PATCH rdma-next 04/12] IB/mlx5: Remove useless check in ODP handler

2019-01-21 Thread Leon Romanovsky
From: Moni Shoua When handling an ODP event for a revive WQE in SRQ the target QP is unknown. Therefore, it is wrong to ask if QP has a SRQ in the page-fault handler. Signed-off-by: Moni Shoua Reviewed-by: Majd Dibbiny Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/odp.c | 9 +

[PATCH] PCI / ACPI: Don't clear pme_poll on device that has unreliable ACPI wake

2019-01-21 Thread Kai-Heng Feng
There are some e1000e devices can only be woken up from D3 one time, by plugging ethernet cable. Subsequent cable plugging does set PME bit correctly, but it still doesn't get woken up. Since e1000e connects to the root complex directly, we rely on ACPI to wake it up. In this case, the GPE from _P

Re: [PATCH iproute2 v5] iproute: Set ip/ip6 lwtunnel flags

2019-01-21 Thread wenxu
Hi stephen & David, The status of this patch shows "Accepted' for long time. http://patchwork.ozlabs.org/patch/1019880/ But it doesn't applied to master. There are some other problem for this patch? BR wenxu On 1/2/2019 11:57 AM, we...@ucloud.cn wrote: > From: wenxu > > ip l add dev tun typ

Re: [PATCH] net: sun: cassini: Cleanup license conflict

2019-01-21 Thread Yanjun Zhu
On 2019/1/19 0:30, Shannon Nelson wrote: On Fri, Jan 18, 2019 at 2:51 AM Thomas Gleixner wrote: The recent addition of SPDX license identifiers to the files in drivers/net/ethernet/sun created a licensing conflict. The cassini driver files contain a proper license notice: * This program

[PATCH] devlink: Use DIV_ROUND_UP_ULL in DEVLINK_HEALTH_SIZE_TO_BUFFERS

2019-01-21 Thread Nathan Chancellor
When building this code on a 32-bit platform such as ARM, there is a link time error (lld error shown, happpens with ld.bfd too): ld.lld: error: undefined symbol: __aeabi_uldivmod >>> referenced by devlink.c >>> net/core/devlink.o:(devlink_health_buffers_create) in archive >>> built

Re: [PATCH rdma-next 0/3] Indirect MKEY over DEVX

2019-01-21 Thread Jason Gunthorpe
On Sun, Jan 13, 2019 at 04:01:15PM +0200, Leon Romanovsky wrote: > From: Leon Romanovsky > > Hi, > > >From Yishai, > > This series enables using indirect mkey over DEVX. > > The first patch recognizes the creation of an indirect mkey as part of > DEVX object creation, in that case the umem val

Re: [Intel-wired-lan] [PATCH] igb: Make driver init async

2019-01-21 Thread Feng Tang
Hi Alexander, On Mon, Jan 21, 2019 at 06:29:51PM -0800, Alexander Duyck wrote: > On Mon, Jan 21, 2019 at 5:39 PM Feng Tang wrote: > > > > Hi Duyck, > > > > Thanks for your review! > > > > On Mon, Jan 21, 2019 at 02:50:08PM -0800, Alexander Duyck wrote: > > > On Mon, Jan 21, 2019 at 12:36 AM Feng

Re: [Intel-wired-lan] [PATCH] igb: Make driver init async

2019-01-21 Thread Alexander Duyck
On Mon, Jan 21, 2019 at 5:39 PM Feng Tang wrote: > > Hi Duyck, > > Thanks for your review! > > On Mon, Jan 21, 2019 at 02:50:08PM -0800, Alexander Duyck wrote: > > On Mon, Jan 21, 2019 at 12:36 AM Feng Tang wrote: > > > > > > When optimizing boot time for a platform with igb module, we found the

Re: [Intel-wired-lan] [PATCH] igb: Make driver init async

2019-01-21 Thread Feng Tang
Hi Duyck, Thanks for your review! On Mon, Jan 21, 2019 at 02:50:08PM -0800, Alexander Duyck wrote: > On Mon, Jan 21, 2019 at 12:36 AM Feng Tang wrote: > > > > When optimizing boot time for a platform with igb module, we found the > > igb driver probe will take about 45 ms, make the probe asynchr

RE: [PATCH] net: fec: get regulator optional

2019-01-21 Thread Andy Duan
From: Stefan Agner Sent: Monday, January 21, 2019 10:59 PM > According to the device tree binding the phy-supply property is optional. Use > the regulator_get_optional API accordingly. The code already handles NULL > just fine. > > This gets rid of the following warning: > fec 2188000.ethernet:

Re: [PATCHv3 2/3] net: dsa: mt7530: support the 7530 switch on the Mediatek MT7621 SoC

2019-01-21 Thread Greg Ungerer
Hi Sean, On 22/1/19 6:10 am, Sean Wang wrote: On Mon, 2019-01-21 at 11:31 -0800, Sean Wang wrote: From: g...@kernel.org [mailto:g...@kernel.org] Sent: Sunday, January 20, 2019 11:12 PM To: Sean Wang ; bj...@mork.no; and...@lunn.ch; vivien.dide...@savoirfairelinux.com; f.faine...@gmail.com; net

Re: [PATCHv3 2/3] net: dsa: mt7530: support the 7530 switch on the Mediatek MT7621 SoC

2019-01-21 Thread Greg Ungerer
On 22/1/19 3:04 am, Andrew Lunn wrote: On Mon, Jan 21, 2019 at 05:11:39PM +1000, g...@kernel.org wrote: From: Greg Ungerer The MediaTek MT7621 SoC device contains a 7530 switch, and the existing linux kernel 7530 DSA switch driver can be used with it. The bulk of the changes required stem

Re: [PATCH 11/11] dt-bindings: can: rcar_canfd: document r8a774c0 support

2019-01-21 Thread Rob Herring
On Wed, 16 Jan 2019 18:37:54 +, Fabrizio Castro wrote: > Document the support for rcar_canfd on R8A774C0 SoC devices. > > Signed-off-by: Fabrizio Castro > Reviewed-by: Chris Paterson > --- > This patch depends on: > https://patchwork.kernel.org/patch/10687999/ > https://patchwork.kernel.org/

Re: [PATCH 09/11] dt-bindings: can: rcar_can: Fix RZ/G2 CAN clocks

2019-01-21 Thread Rob Herring
On Wed, 16 Jan 2019 18:37:52 +, Fabrizio Castro wrote: > According to the latest information, the clock options for CAN on RZ/G2 > are the same as the ones available on R-Car Gen3 > > Fixes: 868b7c0f43e6 ("dt-bindings: can: rcar_can: Add r8a774a1 support") > Signed-off-by: Fabrizio Castro > R

Re: [PATCH 01/11] dt-bindings: Add vendor prefix for Silicon Linux.

2019-01-21 Thread Rob Herring
On Wed, 16 Jan 2019 18:37:44 +, Fabrizio Castro wrote: > From: Biju Das > > Add Silicon Linux to the list of devicetree vendor prefixes. > > Website: http://www.si-linux.co.jp > > Signed-off-by: Biju Das > Signed-off-by: Fabrizio Castro > Reviewed-by: Chris Paterson > --- > Documentatio

Re: [PATCH 4/8] net/macb: bindings doc/trivial: fix documentation for sama5d3 10/100 interface

2019-01-21 Thread Rob Herring
On Wed, Jan 16, 2019 at 10:57:40AM +0100, Nicolas Ferre wrote: > This removes a line left while adding the correct compatibility string for > sama5d3 10/100 interface. Now use the "atmel,sama5d3-macb" string. > > Signed-off-by: Nicolas Ferre > --- > Documentation/devicetree/bindings/net/macb.txt

Re: [PATCH 2/8] dt-bindings: arm: atmel: add new sam9x60 reset controller binding

2019-01-21 Thread Rob Herring
On Wed, Jan 16, 2019 at 10:57:38AM +0100, Nicolas Ferre wrote: > Update the Reset Controller's binding to add new SoC compatibility string. > > Signed-off-by: Nicolas Ferre > --- > Documentation/devicetree/bindings/arm/atmel-sysregs.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/D

Re: [PATCH 1/8] dt-bindings: arm: atmel: add missing samx7 to reset controller

2019-01-21 Thread Rob Herring
On Wed, 16 Jan 2019 10:57:37 +0100, Nicolas Ferre wrote: > Add this missing compatibility string to the Reset Controller > compatible string chip list. > > Signed-off-by: Nicolas Ferre > --- > Documentation/devicetree/bindings/arm/atmel-sysregs.txt | 2 +- > 1 file changed, 1 insertion(+), 1 del

Re: Stack sends oversize UDP packet to the driver

2019-01-21 Thread Michael Chan
On Mon, Jan 21, 2019 at 4:36 PM Daniel Axtens wrote: > I hit a similar sounding issue on a bnx2x - see commit > 8914a595110a6eca69a5e275b323f5d09e18f4f9 > > In that case, a GSO packet with gso_size too large for the firmware was > coming to the bnx2x driver from an ibmveth device via Open vSwitch

Re: Stack sends oversize UDP packet to the driver

2019-01-21 Thread Michael Chan
On Mon, Jan 21, 2019 at 4:13 PM Mahesh Bandewar (महेश बंडेवार) wrote: > I have cooked few patches to address this issue, however, I'm finding it > really hard to reproduce this issue in my test environment. If you could try > them and see if those fixes the issue, we can refine them if necessar

Re: Stack sends oversize UDP packet to the driver

2019-01-21 Thread Daniel Axtens
Hi Michael, > I've received a bug report of oversized UDP packets sent to the > bnxt_en driver for transmission. There is no check for illegal length > in the driver and it will send a corrupted BD to the NIC if the > non-TSO length exceeds the maximum MTU supported by the driver. This > ultimat

[PATCH 21/24] perf top: Synthesize BPF events for pre-existing loaded BPF programs

2019-01-21 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo So that we can resolve symbols and map names. Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: David Ahern Cc: Peter Zijlstra Cc: Song Liu Cc: kernel-t...@fb.com Cc: netdev@vger.kernel.org Link: http://lkml.kernel.org/r/20190117161521.1341602-9-songliubrav...@fb

[PATCH 16/24] perf, bpf: Introduce PERF_RECORD_BPF_EVENT

2019-01-21 Thread Arnaldo Carvalho de Melo
From: Song Liu For better performance analysis of BPF programs, this patch introduces PERF_RECORD_BPF_EVENT, a new perf_event_type that exposes BPF program load/unload information to user space. Each BPF program may contain up to BPF_MAX_SUBPROGS (256) sub programs. The following example shows k

[PATCH 17/24] tools headers uapi: Sync tools/include/uapi/linux/perf_event.h

2019-01-21 Thread Arnaldo Carvalho de Melo
From: Song Liu Sync for PERF_RECORD_BPF_EVENT. Signed-off-by: Song Liu Reviewed-by: Arnaldo Carvalho de Melo Tested-by: Arnaldo Carvalho de Melo Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Peter Zijlstra Cc: kernel-t...@fb.com Cc: netdev@vger.kernel.org Link: http://lkml.kernel.org/r/20

[PATCH 22/24] bpf: Add module name [bpf] to ksymbols for bpf programs

2019-01-21 Thread Arnaldo Carvalho de Melo
From: Song Liu With this patch, /proc/kallsyms will show BPF programs as t bpf_prog__ [bpf] Signed-off-by: Song Liu Reviewed-by: Arnaldo Carvalho de Melo Tested-by: Arnaldo Carvalho de Melo Acked-by: Peter Zijlstra Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Peter Zijlstra Cc: kern

[PATCH 20/24] perf tools: Synthesize PERF_RECORD_* for loaded BPF programs

2019-01-21 Thread Arnaldo Carvalho de Melo
From: Song Liu This patch synthesize PERF_RECORD_KSYMBOL and PERF_RECORD_BPF_EVENT for BPF programs loaded before perf-record. This is achieved by gathering information about all BPF programs via sys_bpf. Committer testing: # perf record --bpf-event sleep 1 [ perf record: Woken up 1 times t

[PATCH 15/24] tools headers uapi: Sync tools/include/uapi/linux/perf_event.h

2019-01-21 Thread Arnaldo Carvalho de Melo
From: Song Liu Sync changes for PERF_RECORD_KSYMBOL. Signed-off-by: Song Liu Reviewed-by: Arnaldo Carvalho de Melo Tested-by: Arnaldo Carvalho de Melo Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Peter Zijlstra Cc: kernel-t...@fb.com Cc: netdev@vger.kernel.org Link: http://lkml.kernel.or

[PATCH 14/24] perf, bpf: Introduce PERF_RECORD_KSYMBOL

2019-01-21 Thread Arnaldo Carvalho de Melo
From: Song Liu For better performance analysis of dynamically JITed and loaded kernel functions, such as BPF programs, this patch introduces PERF_RECORD_KSYMBOL, a new perf_event_type that exposes kernel symbol register/unregister information to user space. The following data structure is used f

[PATCH 18/24] perf tools: Handle PERF_RECORD_KSYMBOL

2019-01-21 Thread Arnaldo Carvalho de Melo
From: Song Liu This patch handles PERF_RECORD_KSYMBOL in perf record/report. Specifically, map and symbol are created for ksymbol register, and removed for ksymbol unregister. This patch also sets perf_event_attr.ksymbol properly. The flag is ON by default. Signed-off-by: Song Liu Reviewed-by:

[PATCH 19/24] perf tools: Handle PERF_RECORD_BPF_EVENT

2019-01-21 Thread Arnaldo Carvalho de Melo
From: Song Liu This patch adds basic handling of PERF_RECORD_BPF_EVENT. Tracking of PERF_RECORD_BPF_EVENT is OFF by default. Option --bpf-event is added to turn it on. Committer notes: Add dummy machine__process_bpf_event() variant that returns zero for systems without HAVE_LIBBPF_SUPPORT, suc

Re: [PATCH net-next v2 1/4] net: phy: start state machine in phy_start only

2019-01-21 Thread Andrew Lunn
On Mon, Jan 21, 2019 at 10:52:48PM +0100, Heiner Kallweit wrote: > On 21.01.2019 19:42, Andrew Lunn wrote: > >> Right. I figured out that I have update phy.txt anyway because I > >> recently removed phy_stop_interrupts which is referenced in the > >> documentation. OK if we leave the patch series a

Re: [RFC PATCH net-next 2/5] net: 8021q: vlan_dev: add vid tag for uc and mc address lists

2019-01-21 Thread Florian Fainelli
On 12/4/18 3:42 PM, Ivan Khoronzhuk wrote: > On Tue, Dec 04, 2018 at 11:49:27AM -0800, Florian Fainelli wrote: >> On 12/4/18 10:57 AM, Ivan Khoronzhuk wrote: >>> On Mon, Dec 03, 2018 at 03:57:03PM -0800, Florian Fainelli wrote: On 12/3/18 3:51 PM, Ivan Khoronzhuk wrote: > On Mon, Dec 03, 2

[for next][PATCH] iwlwifi: Fix unmet dependency error for IWLWIFI_LEDS

2019-01-21 Thread Sinan Kaya
There is an unresolved dependency as follows: IWLWIFI_LEDS selects MAC80211_LEDS. MAC80211_LEDS depends on MAC80211. It is possible to choose MAC80211_LEDS (y) but not choose MAC80211 (n) WARNING: unmet direct dependencies detected for MAC80211_LEDS Depends on [n]: NET [=y] && WIRELESS [=y] &&

Re: [PATCH net-next] remove TWKilled counter

2019-01-21 Thread peng yu
Hello, I think the snmp.h didn't try to keep user-space compatibility, so we could delete LINUX_MIB_TIMEWAITKILLED counter. Do I misunderstand anything? On Thu, Jan 17, 2019 at 12:26 PM peng yu wrote: > > On Thu, Jan 17, 2019 at 10:07 AM Cong Wang wrote: > > > > On Thu, Jan 17, 2019 at 3:43 AM

Re: [Intel-wired-lan] [PATCH] igb: Make driver init async

2019-01-21 Thread Alexander Duyck
On Mon, Jan 21, 2019 at 12:36 AM Feng Tang wrote: > > When optimizing boot time for a platform with igb module, we found the > igb driver probe will take about 45 ms, make the probe asynchronous > will save quite some time as the init runs in parallel with other > asynchronous drivers. > > In theo

Re: [PATCH v1 net-next] lan743x: Provide Read/Write Access to on chip OTP

2019-01-21 Thread Andrew Lunn
> > This is breaking backwards compatibility. I think you need to respect the > > magic value, independent of how adapter->flags. > > Is backwards compatibility a requirement? Hi Bryan You should not change the ABI. And this is an ABI. So yes, backwards compatibility should be maintained. Maybe

Re: [PATCH net-next v2 1/2] net/mlx5e: Update hw flows when encap source mac changed

2019-01-21 Thread Or Gerlitz
On Mon, Jan 21, 2019 at 1:20 PM wrote: > > From: Tonghao Zhang > > When we offload tc filters to hardware, hardware flows can > be updated when mac of encap destination ip is changed. > But we ignore one case, that the mac of local encap ip can > be changed too, so we should also update them. > >

Re: [GIT] Networking

2019-01-21 Thread pr-tracker-bot
The pull request you sent on Sun, 20 Jan 2019 14:09:04 -0800 (PST): > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net master has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/7d0ae236ed13d7645fb73b85e7c95deee46c4656 Thank you! -- Deet-doot-dot, I am a bot. http

Re: [PATCH net-next v2 1/4] net: phy: start state machine in phy_start only

2019-01-21 Thread Heiner Kallweit
On 21.01.2019 19:42, Andrew Lunn wrote: >> Right. I figured out that I have update phy.txt anyway because I >> recently removed phy_stop_interrupts which is referenced in the >> documentation. OK if we leave the patch series as is and I submit >> the documentation update as a separate patch? > > H

Fw: [Bug 202355] New: UDP does not report all ICMP errors on connected sockets in violation of RFC1122 4.1.1.3

2019-01-21 Thread Stephen Hemminger
Unless there is any objection, I intend to close this bug as "that is the way Linux works, we can't break userspace" Begin forwarded message: Date: Mon, 21 Jan 2019 04:11:06 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 202355] New: UDP does not re

Re: [PATCH ipvs-next] ipvs: use indirect call wrappers

2019-01-21 Thread kbuild test robot
Hi Matteo, Thank you for the patch! Yet something to improve: [auto build test ERROR on ipvs-next/master] url: https://github.com/0day-ci/linux/commits/Matteo-Croce/ipvs-use-indirect-call-wrappers/20190122-022325 base: https://git.kernel.org/pub/scm/linux/kernel/git/horms/ipvs-next.git ma

netlink_unicast usage

2019-01-21 Thread Reinoud Koornstra
Dear Everyone, Forgive me for abusing this list, but I'm not sure where else to direct my mail to for this question. In a kernel loadable module, I'm using netlink_unicast to send messages back to userland. In most cases we assume this passes, but the function is written as an int and can fail. In

RE: [PATCH v1 net-next] lan743x: Provide Read/Write Access to on chip OTP

2019-01-21 Thread Bryan.Whitehead
> > +static int lan743x_otp_write(struct lan743x_adapter *adapter, u32 offset, > > +u32 length, u8 *data) > > +{ > > + int ret; > > + int i; > > + > > + ret = lan743x_otp_power_up(adapter); > > + if (ret < 0) > > + return ret; > > + > > + ret = lan743x_ot

netlink_unicast fail

2019-01-21 Thread Reinoud Koornstra
Dear Everyone, In a kernel loadable module, I'm using netlink_unicast to send messages back to userland. In most cases we assume this passes, but the function is written as an int and can fail. In that case there's no way to notify userland that a message isn't coming back and depending on the api

Re: [PATCH v2 29/29] y2038: add 64-bit time_t syscalls to all 32-bit architectures

2019-01-21 Thread Arnd Bergmann
On Mon, Jan 21, 2019 at 6:08 PM Arnd Bergmann wrote: > On Mon, Jan 21, 2019 at 9:19 AM Geert Uytterhoeven > wrote: > > Regardless, I'm wondering what to do with the holes marked "room for > > arch specific calls". > > When is a syscall really arch-specific, and can it be added there, and > > whe

Re: [Bridge] [PATCH 1/2] net: bridge: fix tc added QinQ forwarding

2019-01-21 Thread Zahari Doychev
On Fri, Jan 18, 2019 at 11:29:52AM +0900, Toshiaki Makita wrote: > On 2019/01/18 4:19, Cong Wang wrote: > > On Thu, Jan 17, 2019 at 12:59 AM Toshiaki Makita > > wrote: > >> On 2019/01/17 17:17, Zahari Doychev wrote: > >>> On Tue, Jan 15, 2019 at 03:11:28PM +0900, Toshiaki Makita wrote: > On 2

RE: [PATCH v1 net-next] lan743x: Provide Read/Write Access to on chip OTP

2019-01-21 Thread Bryan.Whitehead
> > > Hi Bryan > > > > > > It would be good to explain what is wrong with the current code, > > > which allows you to select between the OTP and the EEPROM at write > time. > > > > Hi Andrew, > > > > The current code does not allow OTP read access. > > Plus the current code places unreasonable rest

Re: [PATCH v2 14/29] arch: add pkey and rseq syscall numbers everywhere

2019-01-21 Thread Arnd Bergmann
On Mon, Jan 21, 2019 at 9:56 AM Geert Uytterhoeven wrote: > > Note that all architectures that already define pkey syscalls, list > pkey_mprotect first. It's easy enough to change, so I've reordered them for consistency now. > Regardless, for m68k: > Acked-by: Geert Uytterhoeven Thanks,

Re: [PATCH net-next 4/7] net: phy: marvell10g: Add support for 2.5GBASET and 5GBASET

2019-01-21 Thread Andrew Lunn
> @@ -264,8 +265,10 @@ static int mv3310_config_init(struct phy_device *phydev) > if (ret) > return ret; > > - linkmode_and(phydev->advertising, phydev->advertising, > - phydev->supported); > + /* Make sure we advertise all the supported modes, and not

Re: [PATCH lora-next 1/4] dt-bindings: lora: sx130x: add basic documentation

2019-01-21 Thread Rob Herring
On Tue, Jan 08, 2019 at 05:41:29PM +0900, Ben Whitten wrote: > Add basic documentation in YAML format for the sx130x series concentrators > from Semtech. > Required is; the location on the SPI bus, the reset gpio and the node for > downstream IQ radios, typically sx125x. > > Signed-off-by: Ben Whi

[RFC bpf-next] bpf: allow users to opt out of releasing objects when urefs are gone

2019-01-21 Thread Jakub Kicinski
Commit c9da161c6517 ("bpf: fix clearing on persistent program array maps") added protection against dependency loops between programs and maps leading to zombie objects which would never be freed. FD maps are flushed when last user reference is gone. This is confusing to users of bpftool, as upda

Re: [PATCHv3 2/3] net: dsa: mt7530: support the 7530 switch on the Mediatek MT7621 SoC

2019-01-21 Thread Sean Wang
On Mon, 2019-01-21 at 11:31 -0800, Sean Wang wrote: > From: g...@kernel.org [mailto:g...@kernel.org] > Sent: Sunday, January 20, 2019 11:12 PM > To: Sean Wang ; bj...@mork.no; and...@lunn.ch; > vivien.dide...@savoirfairelinux.com; f.faine...@gmail.com; > netdev@vger.kernel.org > Cc: r...@vdors

Re: [PATCH lora-next 1/4] dt-bindings: lora: sx130x: add basic documentation

2019-01-21 Thread Rob Herring
On Mon, Jan 21, 2019 at 01:14:20PM -0600, Rob Herring wrote: > On Tue, Jan 08, 2019 at 05:41:29PM +0900, Ben Whitten wrote: > > Add basic documentation in YAML format for the sx130x series concentrators > > from Semtech. > > Required is; the location on the SPI bus, the reset gpio and the node for

UBSAN: Undefined behaviour in net/ipv4/ip_output.c

2019-01-21 Thread Kyungtae Kim
I'm reporting a bug in linux-5.0-rc2: "UBSAN: Undefined behaviour in net/ipv4/ip_output.c" kernel config: https://kt0755.github.io/etc/config-5.0-rc2 repro: https://kt0755.github.io/etc/repro.b6a11.c Integer overflow happened in __ip_append_data() when 2 * sk->sk_sndbuf (at line 1004) is larger t

Re: [PATCH] net: phy: Fixup GPLv2+ SPDX tags based on license text

2019-01-21 Thread Michael Schmitz
For the asix.c patch: Acked-by: Michael Schmitz On 22/01/19 7:08 AM, Andrew Lunn wrote: A few PHY drivers have the GPLv2+ license text. They then either have a MODULE_LICENSE() of GPLv2 only, or an SPDX tag of GPLv2 only. Since the license text is much easier to understand than either the SPD

Re: [PATCH lora-next 1/4] dt-bindings: lora: sx130x: add basic documentation

2019-01-21 Thread Rob Herring
On Tue, Jan 08, 2019 at 05:41:29PM +0900, Ben Whitten wrote: > Add basic documentation in YAML format for the sx130x series concentrators > from Semtech. > Required is; the location on the SPI bus, the reset gpio and the node for > downstream IQ radios, typically sx125x. > > Signed-off-by: Ben Whi

Re: [Intel-wired-lan] [PATCH] i40e: replace switch-statement with if-clause

2019-01-21 Thread Jesper Dangaard Brouer
On Mon, 21 Jan 2019 17:53:45 +0100 Björn Töpel wrote: > > If that jump tables are a common problem, I wonder, why the compiler > > cannot be adapted to generate better performing code or an option passed > > to the compiler. > > > > It might make sense to use -fno-jump-tables or a better value

Re: [PATCH] i40e: replace switch-statement with if-clause

2019-01-21 Thread Jesper Dangaard Brouer
On Mon, 21 Jan 2019 17:33:56 +0100 bjorn.to...@gmail.com wrote: > From: Björn Töpel > > GCC will generate jump tables for switch-statements with more than 5 > case statements. An entry into the jump table is an indirect call, > which means that for CONFIG_RETPOLINE builds, this is rather > expen

[PATCH bpf-next 0/3] selftests: bpf: break up test_verifier

2019-01-21 Thread Jakub Kicinski
Hi! The tools/testing/selftests/bpf/test_verifier.c file is way too large, and since most people add their at the end of the list it's very prone to conflicts. Break it up in the simplest possible way - slice the array up into smaller C files and include them in the right spot. Tested: $ make -C

[PATCH bpf-next 1/3] selftests: bpf: prepare for break up of verifier tests

2019-01-21 Thread Jakub Kicinski
test_verifier.c has grown to be very long (almost 16 kLoC), and it is very conflict prone since we always add tests at the end. Try to break it apart a little bit. Allow test snippets to be defined in separate files and include them automatically into the huge test array. Signed-off-by: Jakub Ki

[PATCH net] sctp: set flow sport from saddr only when it's 0

2019-01-21 Thread Xin Long
Now sctp_transport_pmtu() passes transport->saddr into .get_dst() to set flow sport from 'saddr'. However, transport->saddr is set only when transport->dst exists in sctp_transport_route(). If sctp_transport_pmtu() is called without transport->saddr set, like when transport->dst doesn't exists, th

Re: [PATCH net-next v2 1/4] net: phy: start state machine in phy_start only

2019-01-21 Thread Andrew Lunn
> Right. I figured out that I have update phy.txt anyway because I > recently removed phy_stop_interrupts which is referenced in the > documentation. OK if we leave the patch series as is and I submit > the documentation update as a separate patch? Hi Heiner Fixing the documentation separately is

[PATCH net] sctp: set chunk transport correctly when it's a new asoc

2019-01-21 Thread Xin Long
In the paths: sctp_sf_do_unexpected_init() -> sctp_make_init_ack() sctp_sf_do_dupcook_a/b()() -> sctp_sf_do_5_1D_ce() The new chunk 'retval' transport is set from the incoming chunk 'chunk' transport. However, 'retval' transport belong to the new asoc, which is a different one from 'c

[PATCH net] sctp: improve the events for sctp stream adding

2019-01-21 Thread Xin Long
This patch is to improve sctp stream adding events in 2 places: 1. In sctp_process_strreset_addstrm_out(), move up SCTP_MAX_STREAM and in stream allocation failure checks, as the adding has to succeed after reconf_timer stops for the in stream adding request retransmission. 3.

[PATCH net] sctp: improve the events for sctp stream reset

2019-01-21 Thread Xin Long
This patch is to improve sctp stream reset events in 4 places: 1. In sctp_process_strreset_outreq(), the flag should always be set with SCTP_STREAM_RESET_INCOMING_SSN instead of OUTGOING, as receiver's in stream is reset here. 2. In sctp_process_strreset_outreq(), move up SCTP_STRRES

Re: [PATCH net-next v2 1/4] net: phy: start state machine in phy_start only

2019-01-21 Thread Heiner Kallweit
On 21.01.2019 17:35, Andrew Lunn wrote: > On Sun, Jan 20, 2019 at 10:01:15AM +0100, Heiner Kallweit wrote: >> The state machine is a no-op before phy_start() has been called. >> Therefore let's enable it in phy_start() only. In phy_start() >> let's call phy_start_machine() instead of phy_trigger_ma

[PATCH net-next] net: phy: Add SDPX tag based on COPYING file

2019-01-21 Thread Andrew Lunn
Some of the PHY and MDIO drivers refer to the COPYING file in the main directory of this archive. This is the main license for Linux, thus GPLv2 plus syscall extension. Fixup the MODULE_LICENSE() where needed and add an SDPX header for GPLv2. Cc: David Daney Signed-off-by: Andrew Lunn --- driv

Re: [PATCH net-next v2 2/4] net: phy: warn if phy_start is called from invalid state

2019-01-21 Thread Heiner Kallweit
On 21.01.2019 19:29, Andrew Lunn wrote: >> For all invalid states phy_start() basically was a no-op. All it did was >> triggering a state machine run, but for all "running" states the poll >> loop was active anyway. And if called from PHY_DOWN, the state machine >> does nothing. Therefore I see no

Re: [PATCH net-next v2 2/4] net: phy: warn if phy_start is called from invalid state

2019-01-21 Thread Andrew Lunn
> For all invalid states phy_start() basically was a no-op. All it did was > triggering a state machine run, but for all "running" states the poll > loop was active anyway. And if called from PHY_DOWN, the state machine > does nothing. Therefore I see no scenario where jumping to out would > break

Dearest Friend

2019-01-21 Thread Mercy Kings
Dearest One First i thanks your attention to me, I am mercy kings My parents Mr.and Mrs.kings were assassinated here in IVORY COAST. Before my Before my father's death he had (USD $5.9M) Five Million Nine Hundred Thousand United State Dollars deposited in a bank here in Abidjan. I want you to do m

Re: [PATCH v1 net-next] lan743x: Provide Read/Write Access to on chip OTP

2019-01-21 Thread Andrew Lunn
> +static int lan743x_otp_write(struct lan743x_adapter *adapter, u32 offset, > + u32 length, u8 *data) > +{ > + int ret; > + int i; > + > + ret = lan743x_otp_power_up(adapter); > + if (ret < 0) > + return ret; > + > + ret = lan743x_otp_wait_t

Re: [PATCH net-next v2 2/4] net: phy: warn if phy_start is called from invalid state

2019-01-21 Thread Heiner Kallweit
On 21.01.2019 17:40, Andrew Lunn wrote: > On Sun, Jan 20, 2019 at 10:02:13AM +0100, Heiner Kallweit wrote: >> phy_start() should be called from states PHY_READY or PHY_HALTED only. >> Check for this to detect misbehaving drivers. Also the state machine >> should be started only when being called fr

Re: [v2] net: dpaa2: improve PTP Kconfig option

2019-01-21 Thread Richard Cochran
On Mon, Jan 21, 2019 at 02:26:37PM +0800, Yangbo Lu wrote: > Converted to use "imply" instead of "select" for PTP_1588_CLOCK > driver selecting. This could break the hard dependency between > the PTP clock subsystem and ethernet drivers. > This patch also set "default y" for dpaa2 ptp driver buildi

Re: [PATCH mlx5-next 4/4] net/mlx5: Remove spinlock support from mlx5_write64

2019-01-21 Thread Jason Gunthorpe
On Mon, Jan 21, 2019 at 10:12:58AM -0800, Saeed Mahameed wrote: > On Mon, Jan 21, 2019 at 8:46 AM Jason Gunthorpe wrote: > > > > On Sat, Jan 19, 2019 at 12:43:14AM -0700, Leon Romanovsky wrote: > > > You need to do one of two things: > > > 1. Require CONFIG_64BIT and delete this 32bit code. > > >

Re: [PATCH v1 net-next] lan743x: Provide Read/Write Access to on chip OTP

2019-01-21 Thread Andrew Lunn
On Mon, Jan 21, 2019 at 06:06:20PM +, bryan.whiteh...@microchip.com wrote: > > On Fri, Jan 18, 2019 at 04:54:53PM -0500, Bryan Whitehead wrote: > > > The LAN743x includes on chip One-Time-Programmable (OTP) memory. > > > > > > This patch extends the ethtool EEPROM read/write interface to access

Re: [PATCH mlx5-next 4/4] net/mlx5: Remove spinlock support from mlx5_write64

2019-01-21 Thread Saeed Mahameed
On Mon, Jan 21, 2019 at 8:46 AM Jason Gunthorpe wrote: > > On Sat, Jan 19, 2019 at 12:43:14AM -0700, Leon Romanovsky wrote: > > You need to do one of two things: > > 1. Require CONFIG_64BIT and delete this 32bit code. > > 2. Declare global mlx5 DB spinlock and use on 32bit systems, something > > l

Re: [PATCH mlx5-next 4/4] net/mlx5: Remove spinlock support from mlx5_write64

2019-01-21 Thread Saeed Mahameed
On Fri, Jan 18, 2019 at 11:43 PM Leon Romanovsky wrote: > > On Fri, Jan 18, 2019 at 04:33:13PM -0800, Saeed Mahameed wrote: > > From: Maxim Mikityanskiy > > > > As there is no user of mlx5_write64 that passes a spinlock to > > mlx5_write64, remove this functionality and simplify the function. > >

[PATCH net-next] net: phy: Fixup GPLv2 SPDX tags based on license text

2019-01-21 Thread Andrew Lunn
A few PHY drivers have the GPLv2 license text. They then either have a MODULE_LICENSE() of GPLv2+, or an SPDX tag of GPLv2+. Since the license text is much easier to understand than either the SPDX tag or the MODULE_LICENSE, use it as the definitive source of the licence, and fixup with others whe

[PATCH] net: phy: Fixup GPLv2+ SPDX tags based on license text

2019-01-21 Thread Andrew Lunn
A few PHY drivers have the GPLv2+ license text. They then either have a MODULE_LICENSE() of GPLv2 only, or an SPDX tag of GPLv2 only. Since the license text is much easier to understand than either the SPDX tag or the MODULE_LICENSE, use it as the definitive source of the licence, and fixup the ot

[PATCH net-next 1/2] net: phy: Convert some PHY and MDIO driver files to SPDX headers

2019-01-21 Thread Andrew Lunn
Where the license text and the MODULE_LICENSE() value agree, convert to using an SPDX header, removing the license text. Signed-off-by: Andrew Lunn --- drivers/net/phy/amd.c| 7 +-- drivers/net/phy/aquantia.c | 5 + drivers/net/phy/at803x.c | 6 +-

[PATCH net-next 0/2] SPDX tags for PHY and MDIO drivers

2019-01-21 Thread Andrew Lunn
This patchset adds SPDX tags to files where the license information is clear and consistent. It also removes redundent license text when an SPDX header is present. Andrew Lunn (2): net: phy: Convert some PHY and MDIO driver files to SPDX headers net: phy: Remove redundent License text when SPD

[PATCH net-next 2/2] net: phy: Remove redundent License text when SPDX header is present

2019-01-21 Thread Andrew Lunn
The SPDX header makes any license text redundent. Remove it. Signed-off-by: Andrew Lunn --- drivers/net/phy/bcm-phy-lib.c| 5 - drivers/net/phy/mdio-bcm-iproc.c | 9 - 2 files changed, 14 deletions(-) diff --git a/drivers/net/phy/bcm-phy-lib.c b/drivers/net/phy/bcm-phy-lib.c ind

RE: [PATCH v1 net-next] lan743x: Provide Read/Write Access to on chip OTP

2019-01-21 Thread Bryan.Whitehead
> On Fri, Jan 18, 2019 at 04:54:53PM -0500, Bryan Whitehead wrote: > > The LAN743x includes on chip One-Time-Programmable (OTP) memory. > > > > This patch extends the ethtool EEPROM read/write interface to access > > OTP memory space. > > > > This is done by adding the private flag OTP_ACCESS, whic

Re: [PATCH] RFC: Revert "net: phy: check return code when requesting PHY driver module"

2019-01-21 Thread Guido Günther
Hi, On Mon, Jan 21, 2019 at 05:26:00PM +0100, Andrew Lunn wrote: > On Mon, Jan 21, 2019 at 03:00:55PM +0100, Guido Günther wrote: > > This unbreaks ethernet on e.g. the NXP imx8mq-evk using the fec driver. > > Otherwise it fails like: > > > > [3.702671] device: '30be.ethernet-1': device_ad

Re: Regression: mv88e6xxx packet loss after 4.18's PHYLINK merge

2019-01-21 Thread Andrew Lunn
> Hi Andrew, > > I've debugged the issue further by dumping all the values inside > phylink_resolve to get a better understand how the link state behaves. > > As this is a fixed link the link_state structure is populated by > phylink_get_fixed_state(), but in our case neither get_fixed_state call

Re: [PATCH bpf-next v4] libbpf: Show supported ELF section names on when failed to guess a prog/attach type

2019-01-21 Thread Jakub Kicinski
On Mon, 21 Jan 2019 22:06:38 +0900, Taeung Song wrote: > We need to let users check their wrong ELF section name > with proper ELF section names when failed to get a prog/attach type from it. > Because users can't realize libbpf guess prog/attach types from > given ELF section names. > For example,

  1   2   3   >