On 21.01.2019 19:29, Andrew Lunn wrote:
>> For all invalid states phy_start() basically was a no-op. All it did was
>> triggering a state machine run, but for all "running" states the poll
>> loop was active anyway. And if called from PHY_DOWN, the state machine
>> does nothing. Therefore I see no scenario where jumping to out would
>> break anything.
> 
> Hi Heiner
> 
> It is useful to put this sort of analysis in the commit message. You
> then won't get people like me asking about it.
> 
Will add this to my "best practices" list ;)

>      Andrew
> 
Heiner

Reply via email to