[Patch net-next] net: introduce a knob to control whether to inherit devconf config

2019-01-17 Thread Cong Wang
There have been many people complaining about the inconsistent behaviors of IPv4 and IPv6 devconf when creating new network namespaces. Currently, for IPv4, we inherit all current settings from init_net, but for IPv6 we reset all setting to default. This patch introduces a new /proc file /proc/sy

Re: [PATCH bpf-next 1/5] bpf: add BPF_CGROUP_INET{4,6}_SOCK_RELEASE hooks

2019-01-17 Thread kbuild test robot
Hi Stanislav, Thank you for the patch! Yet something to improve: [auto build test ERROR on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Stanislav-Fomichev/bpf-add-BPF_CGROUP_INET-4-6-_SOCK_RELEASE-hooks/20190118-141334 base: https://git.kernel.org/pub/scm/linux/kernel/git

RE: [PATCH] net: dpaa2: build ptp clock driver in default

2019-01-17 Thread Y.b. Lu
Hi Richard, > -Original Message- > From: Richard Cochran > Sent: Friday, January 18, 2019 9:26 AM > To: Y.b. Lu > Cc: netdev@vger.kernel.org; David S . Miller ; Ioana > Ciocoi Radulescu > Subject: Re: [PATCH] net: dpaa2: build ptp clock driver in default > > On Mon, Jan 14, 2019 at 05:

[RFC patch 4/4] crypto/chelsio/chtls: IPv6 for Inline TLS

2019-01-17 Thread Atul Gupta
Extends support to IPv6 for Inline TLS server and client. Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_cm.c | 473 +++--- drivers/crypto/chelsio/chtls/chtls_cm.h | 3 + drivers/crypto/chelsio/chtls/chtls_main.c | 27 +- include/net/transp_v6.h

[RFC patch 3/4] crypto/chelsio/chtls: CPL for TLS client

2019-01-17 Thread Atul Gupta
CPL processing for Inline TLS client. Exchange messages with hardware to setup connection. Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls.h| 12 +- drivers/crypto/chelsio/chtls/chtls_cm.c | 308 +++- drivers/crypto/chelsio/chtls/chtls_cm.h

[RFC patch 2/4] crypto/chelsio/chtls: hardware connect API

2019-01-17 Thread Atul Gupta
Hardware specific implementation for TLS client processing. Added connect routine to prepare hardware for TLS client handshake. Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls.h | 6 +- drivers/crypto/chelsio/chtls/chtls_cm.c | 533 -- dr

[RFC patch 2/4] crypto/chelsio/chtls: hardware connect API

2019-01-17 Thread Atul Gupta
Hardware specific implementation for TLS client processing. Added connect routine to prepare hardware for TLS client handshake. Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls.h | 6 +- drivers/crypto/chelsio/chtls/chtls_cm.c | 533 -- dr

[RFC patch 1/4] net/tls: connect routine for Inline TLS client

2019-01-17 Thread Atul Gupta
Define tls_hw_connect to setup Inline TLS client before TLS handshake and key program Signed-off-by: Atul Gupta --- include/net/tls.h | 5 + net/tls/tls_main.c | 23 +++ 2 files changed, 28 insertions(+) diff --git a/include/net/tls.h b/include/net/tls.h index 90bf52d.

[RFC patch 0/4] Inline TLS client and v6

2019-01-17 Thread Atul Gupta
Extends Inline TLS record processing to TLS client. connect API is added to tls_context to setup hardware for TLS connection and handshake. Functionality wise, this makes the solution end-to-end Inline TLS capable. TLS server and client can operate in Inline mode and leverage hardware for complete

[PATCH net-next v7 8/8] bnxt_en: Add bnxt_en initial port params table and register it

2019-01-17 Thread Vasundhara Volam
Register devlink_port with devlink and create initial port params table for bnxt_en. The table consists of a generic parameter: wake_on_lan: Enables Wake on Lan for this port when magic packet is received with this port's MAC address using ACPI pattern. If enabled, the controller asserts a wake pi

[PATCH net-next v7 2/8] devlink: Add port param get command

2019-01-17 Thread Vasundhara Volam
Add port param get command which gets data per parameter. It also has option to dump the parameters data per port. Cc: Jiri Pirko Signed-off-by: Vasundhara Volam --- include/uapi/linux/devlink.h | 2 + net/core/devlink.c | 102 --- 2 files cha

[PATCH net-next v7 3/8] devlink: Add port param set command

2019-01-17 Thread Vasundhara Volam
Add port param set command to set the value for a parameter. Value can be set to any of the supported configuration modes. Cc: Jiri Pirko Signed-off-by: Vasundhara Volam --- include/uapi/linux/devlink.h | 1 + net/core/devlink.c | 37 - 2 files cha

[PATCH net-next v7 1/8] devlink: Add devlink_param for port register and unregister

2019-01-17 Thread Vasundhara Volam
Add functions to register and unregister for the driver supported configuration parameters table per port. v2->v3: - Add a helper __devlink_params_register() with common code used by both devlink_params_register() and devlink_port_params_register(). Cc: Jiri Pirko Signed-off-by: Vasundhara Vol

[PATCH net-next v7 4/8] devlink: Add support for driverinit get value for devlink_port

2019-01-17 Thread Vasundhara Volam
Add support for "driverinit" configuration mode value for devlink_port configuration parameters. Add devlink_port_param_driverinit_value_get() function to help the driver get the value from devlink_port. Also, move the common code to __devlink_param_driverinit_value_get() to be used by both device

[PATCH net-next v7 6/8] devlink: Add devlink notifications support for port params

2019-01-17 Thread Vasundhara Volam
Add notification call for devlink port param set, register and unregister functions. Add devlink_port_param_value_changed() function to enable the driver notify devlink on value change. Driver should use this function after value was changed on any configuration mode part to driverinit. Cc: Jiri P

[PATCH net-next v7 7/8] devlink: Add a generic wake_on_lan port parameter

2019-01-17 Thread Vasundhara Volam
wake_on_lan - Enables Wake on Lan for this port. If enabled, the controller asserts a wake pin based on the WOL type. v2->v3: - Define only WOL types used now and define them as bitfield, so that mutliple WOL types can be enabled upon power on. - Modify "wake-on-lan" name to "wake_on_lan" to be

[PATCH net-next v7 0/8] devlink: Add configuration parameters support for devlink_port

2019-01-17 Thread Vasundhara Volam
This patchset adds support for configuration parameters setting through devlink_port. Each device registers supported configuration parameters table. The user can retrieve data on these parameters by "devlink port param show" command and can set new value to a parameter by "devlink port param set

[PATCH net-next v7 5/8] devlink: Add support for driverinit set value for devlink_port

2019-01-17 Thread Vasundhara Volam
Add support for "driverinit" configuration mode value for devlink_port configuration parameters. Add devlink_port_param_driverinit_value_set() function to help the driver set the value to devlink_port. Also, move the common code to __devlink_param_driverinit_value_set() to be used by both device a

Re: [PATCH RFC v1] net: dsa: microchip: add KSZ9477 I2C driver

2019-01-17 Thread Marek Vasut
On 1/17/19 4:24 AM, tristram...@microchip.com wrote: > From: Tristram Ha > > Add KSZ9477 I2C driver support. The code ksz9477.c and ksz_common.c are > used together to generate the I2C driver. > > Signed-off-by: Tristram Ha > --- > drivers/net/dsa/microchip/Kconfig | 7 ++ > drivers/n

Re: [PATCH v4 1/4] can: m_can: Create a m_can platform framework

2019-01-17 Thread Wolfgang Grandegger
Hello Dan, Am 17.01.19 um 21:08 schrieb Dan Murphy: > Wolfgang > > On 1/17/19 2:05 PM, Dan Murphy wrote: >> Create a m_can platform framework that peripherial >> devices can register to and use common code and register sets. >> The peripherial devices may provide read/write and configuration >> s

Re: [PATCH net 1/1] bonding: fix PACKET_ORIGDEV regression on bonding masters

2019-01-17 Thread Maciej Żenczykowski
I'm not sure there's a truly good answer. Also note, that there's subtle differences between af_packet sockets tied to ALL protocols vs tied to specific protocols (vs none/0 of course). However ETH_P_ALL protocol raw sockets need to be avoided if at all possible due to perf impact. Certainly we do

[PATCH v2 bpf-next 6/9] bpf: introduce BPF_F_LOCK flag

2019-01-17 Thread Alexei Starovoitov
Introduce BPF_F_LOCK flag for map_lookup and map_update syscall commands and for map_update() helper function. In all these cases take a lock of existing element (which was provided in BTF description) before copying (in or out) the rest of map value. Implementation details that are part of uapi:

Re: [PATCH bpf-next 1/5] bpf: add BPF_CGROUP_INET{4,6}_SOCK_RELEASE hooks

2019-01-17 Thread kbuild test robot
Hi Stanislav, Thank you for the patch! Yet something to improve: [auto build test ERROR on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Stanislav-Fomichev/bpf-add-BPF_CGROUP_INET-4-6-_SOCK_RELEASE-hooks/20190118-141334 base: https://git.kernel.org/pub/scm/linux/kernel/git

Re: [PATCH RFC 1/4] net: dsa: microchip: convert KSZ9477 SPI driver to use regmap

2019-01-17 Thread Marek Vasut
On 1/17/19 4:22 AM, tristram...@microchip.com wrote: > From: Tristram Ha > > Convert KSZ9477 SPI driver to use regmap mechanism so that an I2C driver > can be easily added. > > KSZ9477 SPI driver uses a 32-bit SPI command containing a 24-bit address > to access registers in 8-bit. The address i

Re: [PATCH net-next 00/11] tcp: remove code from tcp_create_openreq_child()

2019-01-17 Thread David Miller
From: Eric Dumazet Date: Thu, 17 Jan 2019 11:23:31 -0800 > tcp_create_openreq_child() is essentially cloning a listener, then > must initialize some fields that can not be inherited. > > Listeners are either fresh sockets, or sockets that came through > tcp_disconnect() after a session that dirt

[PATCH v2 bpf-next 2/9] bpf: add support for bpf_spin_lock to cgroup local storage

2019-01-17 Thread Alexei Starovoitov
Allow 'struct bpf_spin_lock' to reside inside cgroup local storage. Signed-off-by: Alexei Starovoitov --- kernel/bpf/local_storage.c | 2 ++ kernel/bpf/syscall.c | 3 ++- kernel/bpf/verifier.c | 2 ++ 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/kernel/bpf/local_stora

[PATCH v2 bpf-next 1/9] bpf: introduce bpf_spin_lock

2019-01-17 Thread Alexei Starovoitov
Introduce 'struct bpf_spin_lock' and bpf_spin_lock/unlock() helpers to let bpf program serialize access to other variables. Example: struct hash_elem { int cnt; struct bpf_spin_lock lock; }; struct hash_elem * val = bpf_map_lookup_elem(&hash_map, &key); if (val) { bpf_spin_lock(&val->l

[PATCH v2 bpf-next 4/9] selftests/bpf: add bpf_spin_lock tests

2019-01-17 Thread Alexei Starovoitov
add bpf_spin_lock tests to test_verifier.c that don't require latest llvm with BTF support Signed-off-by: Alexei Starovoitov --- tools/testing/selftests/bpf/test_verifier.c | 459 +++- 1 file changed, 458 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/bpf/test

[PATCH v2 bpf-next 0/9] introduce bpf_spin_lock

2019-01-17 Thread Alexei Starovoitov
Many algorithms need to read and modify several variables atomically. Until now it was hard to impossible to implement such algorithms in BPF. Hence introduce support for bpf_spin_lock. The api consists of 'struct bpf_spin_lock' that should be placed inside hash/array/cgroup_local_storage element

[PATCH v2 bpf-next 9/9] selftests/bpf: test for BPF_F_LOCK

2019-01-17 Thread Alexei Starovoitov
Add C based test that runs 4 bpf programs in parallel that update the same hash and array maps. And another 2 threads that read from these two maps via lookup(key, value, BPF_F_LOCK) api to make sure the user space sees consistent value in both hash and array elements while user space races with ke

[PATCH v2 bpf-next 7/9] tools/bpf: sync uapi/bpf.h

2019-01-17 Thread Alexei Starovoitov
add BPF_F_LOCK definition to tools/include/uapi/linux/bpf.h Signed-off-by: Alexei Starovoitov --- tools/include/uapi/linux/bpf.h | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h index 30f9dfd40f13..c23eaa284a45 100644 --- a/tools

[PATCH v2 bpf-next 3/9] tools/bpf: sync include/uapi/linux/bpf.h

2019-01-17 Thread Alexei Starovoitov
sync bpf.h Signed-off-by: Alexei Starovoitov --- tools/include/uapi/linux/bpf.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h index 91c43884f295..30f9dfd40f13 100644 --- a/tools/include/uapi/linux/bpf.h +

[PATCH v2 bpf-next 8/9] libbpf: introduce bpf_map_lookup_elem_flags()

2019-01-17 Thread Alexei Starovoitov
Introduce int bpf_map_lookup_elem_flags(int fd, const void *key, void *value, __u64 flags) helper to lookup array/hash/cgroup_local_storage elements with BPF_F_LOCK flag. Signed-off-by: Alexei Starovoitov --- tools/lib/bpf/bpf.c | 13 + tools/lib/bpf/bpf.h | 2 ++ tools/li

[PATCH v2 bpf-next 5/9] selftests/bpf: add bpf_spin_lock C test

2019-01-17 Thread Alexei Starovoitov
add bpf_spin_lock C based test that requires latest llvm with BTF support Signed-off-by: Alexei Starovoitov --- tools/testing/selftests/bpf/Makefile | 2 +- tools/testing/selftests/bpf/bpf_helpers.h| 4 + tools/testing/selftests/bpf/test_progs.c | 43 +++- tools/testing/

Re: [PATCH 2/2] macvlan: replace kfree_skb by consume_skb for drop profiles

2019-01-17 Thread David Miller
From: Yang Wei Date: Thu, 17 Jan 2019 23:30:03 +0800 > From: Yang Wei > > Replace the kfree_skb() by consume_skb() to be drop monitor(dropwatch, > perf) friendly. > > Signed-off-by: Yang Wei Applied.

Re: [PATCH] neighbour: Do not perturb drop profiles when neigh_probe

2019-01-17 Thread David Miller
From: Yang Wei Date: Thu, 17 Jan 2019 23:11:30 +0800 > From: Yang Wei > > Replace the kfree_skb() by consume_skb() to be drop monitor(dropwatch, > perf) friendly. > > Signed-off-by: Yang Wei Applied, thanks.

Re: [PATCH] amd-xgbe: Fix mdio access for non-zero ports and clause 45 PHYs

2019-01-17 Thread David Miller
From: "Lendacky, Thomas" Date: Thu, 17 Jan 2019 14:20:14 + > The XGBE hardware has support for performing MDIO operations using an > MDIO command request. The driver mistakenly uses the mdio port address > as the MDIO command request device address instead of the MDIO command > request port a

Re: [PATCH net-next] net: ethernet: ti: cpsw-phy-sel: remove unneeded semicolon

2019-01-17 Thread David Miller
From: YueHaibing Date: Thu, 17 Jan 2019 20:59:19 +0800 > Remove unneeded semicolon. > > Signed-off-by: YueHaibing Applied.

Re: [PATCH net-next] net/mlx4: remove unneeded semicolon

2019-01-17 Thread David Miller
From: YueHaibing Date: Thu, 17 Jan 2019 21:03:56 +0800 > Remove unneeded semicolon. > > Signed-off-by: YueHaibing Applied.

Re: [PATCH net-next] tipc: remove unneeded semicolon in trace.c

2019-01-17 Thread David Miller
From: YueHaibing Date: Thu, 17 Jan 2019 20:57:08 +0800 > Remove unneeded semicolon > > Signed-off-by: YueHaibing Applied.

Re: [PATCH net] net: phy: add missing phy driver features

2019-01-17 Thread David Miller
From: Camelia Groza Date: Thu, 17 Jan 2019 14:33:33 +0200 > The phy drivers for CS4340 and TN2020 are missing their > features attributes. Add them. > > Fixes: 719655a14971 ("net: phy: Replace phy driver features u32 with > link_mode bitmap") > Reported-by: Scott Wood > Signed-off-by: Camelia

Re: [PATCH] dpaa_eth: NETIF_F_LLTX requires to do our own update of trans_start

2019-01-17 Thread David Miller
From: Madalin Bucur Date: Thu, 17 Jan 2019 11:42:27 +0200 > As txq_trans_update() only updates trans_start when the lock is held, > trans_start does not get updated if NETIF_F_LLTX is declared. > > Signed-off-by: Madalin Bucur Applied.

Re: [PATCH net-next] qed: remove duplicated include from qed_if.h

2019-01-17 Thread David Miller
From: YueHaibing Date: Thu, 17 Jan 2019 15:22:20 +0800 > Remove duplicated include. > > Signed-off-by: YueHaibing Applied.

Re: [PATCH net v4] net: bridge: Fix ethernet header pointer before check skb forwardable

2019-01-17 Thread David Miller
From: wangyunjian Date: Thu, 17 Jan 2019 09:46:41 +0800 > From: Yunjian Wang > > The skb header should be set to ethernet header before using > is_skb_forwardable. Because the ethernet header length has been > considered in is_skb_forwardable(including dev->hard_header_len > length). > > To re

Re: [PATCH] sb1000: fix a couple of indentation issues

2019-01-17 Thread David Miller
From: Colin King Date: Thu, 17 Jan 2019 00:13:01 + > From: Colin Ian King > > There is an if statement and a return statement that are incorrectly > indented. Fix these. > > Signed-off-by: Colin Ian King Applied to net-next.

Re: [PATCH bpf-next 1/9] bpf: introduce bpf_spin_lock

2019-01-17 Thread Alexei Starovoitov
On Thu, Jan 17, 2019 at 12:27:55PM +0100, Daniel Borkmann wrote: > > Was thinking something like this, in very rough pseudo code: > > Prog A (normal spin lock use of mapA): > > val = bpf_map_lookup_elem(&mapA, &key); > if (val) { > bpf_spin_lock(&val->lock); > [...] > bpf_spin_un

Re: [PATCH] wireless: remove unneeded semicolon

2019-01-17 Thread Steve deRosier
On Thu, Jan 17, 2019 at 7:33 PM YueHaibing wrote: > > remove unneeded semicolon > > Signed-off-by: YueHaibing > --- > drivers/net/wireless/ath/ath10k/wmi.h | 2 +- > drivers/net/wireless/ath/ath6kl/init.c| 2 +- > drivers/net/wireless/broadcom/brcm80211/br

Re: [PATCH net V4] vhost: log dirty page correctly

2019-01-17 Thread David Miller
From: Jason Wang Date: Wed, 16 Jan 2019 16:54:42 +0800 > Vhost dirty page logging API is designed to sync through GPA. But we > try to log GIOVA when device IOTLB is enabled. This is wrong and may > lead to missing data after migration. > > To solve this issue, when logging with device IOTLB ena

Re: [PATCH net] Documentation: timestamping: correct path to net_tstamp.h

2019-01-17 Thread David Miller
From: Jakub Kicinski Date: Sat, 12 Jan 2019 12:51:05 -0800 > net_tstamp.h is an UAPI header, so it was moved under include/uapi. > > Signed-off-by: Jakub Kicinski Applied, looks right to me.

Re: INFO: rcu detected stall in ndisc_alloc_skb

2019-01-17 Thread Tetsuo Handa
Dmitry Vyukov wrote: > On Sun, Jan 6, 2019 at 2:47 PM Tetsuo Handa > wrote: > > > > On 2019/01/06 22:24, Dmitry Vyukov wrote: > > >> A report at 2019/01/05 10:08 from "no output from test machine (2)" > > >> ( https://syzkaller.appspot.com/text?tag=CrashLog&x=1700726f40 ) > > >> says that ther

Re: [PATCH net-next 0/8] net: mscc: PTP offloading support

2019-01-17 Thread Florian Fainelli
On 1/17/2019 2:02 AM, Antoine Tenart wrote: > Hi all, > > This series adds support for the PTP offloading support in the Mscc > Ocelot Ethernet switch driver. Both PTP 1-step and 2-step modes are > supported. > > In order to make use of the PTP offloading support, two new register > banks were

[PATCH v2 net-next] net: sock: do not set sk_cookie in sk_clone_lock()

2019-01-17 Thread Yafang Shao
The only call site of sk_clone_lock is in inet_csk_clone_lock, and sk_cookie will be set there. So we don't need to set sk_cookie in sk_clone_lock(). Reviewed-by: Eric Dumazet Signed-off-by: Yafang Shao --- net/core/sock.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/core/sock.c b/net

[net-next 3/3] cxgb4: TLS record offload enable

2019-01-17 Thread Atul Gupta
Enable Inline TLS record by default Signed-off-by: Atul Gupta --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c index 6ba9099

[net-next 1/3] net/tls: build_protos moved to common routine

2019-01-17 Thread Atul Gupta
build protos is required for tls_hw_prot also hence moved to 'tls_build_proto' and called as required from tls_init and tls_hw_proto. This is required since build_protos for v4 is moved from tls_register to tls_init in commit <28cb6f1eaffdc5a6a9707cac55f4a43aa3fd7895> Signed-off-by: Atul Gupta --

[net-next 2/3] net/tls: free ctx in sock destruct

2019-01-17 Thread Atul Gupta
free tls context in sock destruct. close may not be the last call to free sock but force releasing the ctx in close will result in GPF when ctx referred again in tcp_done [ 515.330477] general protection fault: [#1] SMP PTI [ 515.330539] CPU: 5 PID: 0 Comm: swapper/5 Not tainted 4.20.0-rc7+

Re: Problem with queuing vlan tagged packets after migration from 3.16.0 to 4.9.0

2019-01-17 Thread Eric W. Biederman
Jamal Hadi Salim writes: > On 2019-01-05 12:03 a.m., Cong Wang wrote: >> (Cc'ing Jamal) >> >> On Fri, Jan 4, 2019 at 10:11 AM Bartek Kois wrote: >>> >>> Basically my current scenario looks like this: >>> - router with eth0 as WAN and eth1 as LAN with 10-20 vlans, >>> - around 1000-2000 ip addres

Re: [PATCH v2] lib/test_rhashtable: Make test_insert_dup() allocate its hash table dynamically

2019-01-17 Thread kbuild test robot
Hi Bart, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.0-rc2 next-20190116] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Ba

Re: AF_UNIX sockets crossing namespace based boundaries

2019-01-17 Thread Eric W. Biederman
Andrew Lunn writes: > On Wed, Jan 02, 2019 at 10:22:36AM -0500, Donald Sharp wrote: >> I am only creating a network namespace, but I don't think this changes >> my core question. >> >> Suppose I am running FRR/zebra in the default namespace and I startup >> a BGP instance in namespace one. BGP

[PATCH v2] virtio_net: bulk free tx skbs

2019-01-17 Thread Michael S. Tsirkin
Use napi_consume_skb() to get bulk free. Note that napi_consume_skb is safe to call in a non-napi context as long as the napi_budget flag is correct. Signed-off-by: Michael S. Tsirkin --- Changes from v1: rebase on master. lightly tested on developer's box. drivers/net/virtio_net.c |

Re: [PATCH net 5/7] virtio_net: Don't process redirected XDP frames when XDP is disabled

2019-01-17 Thread Toshiaki Makita
On 2019/01/18 12:52, Jason Wang wrote: > On 2019/1/18 上午9:56, Toshiaki Makita wrote: >> On 2019/01/17 22:05, Jason Wang wrote: >>> On 2019/1/17 下午8:53, Jason Wang wrote: On 2019/1/17 下午7:20, Toshiaki Makita wrote: > Commit 8dcc5b0ab0ec ("virtio_net: fix ndo_xdp_xmit crash towards > dev

Re: [PATCH net-next] ip_gre: Make none-tunnel-dst gre port work with lwtunnel

2019-01-17 Thread David Miller
From: wenxu Date: Fri, 18 Jan 2019 08:10:55 +0800 > what about the status of this patch? Why don't you look in patchwork and see for yourself? https://patchwork.ozlabs.org/patch/1024965/

Re: [PATCH net-next] virtio-net: per-queue RPS config

2019-01-17 Thread Michael S. Tsirkin
On Thu, Jan 17, 2019 at 10:37:26PM -0500, Willem de Bruijn wrote: > On Thu, Jan 17, 2019 at 8:43 PM Michael S. Tsirkin wrote: > > > > On Thu, Jan 17, 2019 at 08:08:53PM -0500, Willem de Bruijn wrote: > > > From: Willem de Bruijn > > > > > > On multiqueue network devices, RPS maps are configured i

Re: [PATCH] wireless: remove unneeded semicolon

2019-01-17 Thread Pkshih
On Fri, 2019-01-18 at 11:32 +0800, YueHaibing wrote: > remove unneeded semicolon > > Signed-off-by: YueHaibing > --- >  drivers/net/wireless/ath/ath10k/wmi.h | 2 +- >  drivers/net/wireless/ath/ath6kl/init.c| 2 +- >  drivers/net/wireless/broadcom/brcm80211/b

Re: [PATCH net 5/7] virtio_net: Don't process redirected XDP frames when XDP is disabled

2019-01-17 Thread Jason Wang
On 2019/1/18 上午9:56, Toshiaki Makita wrote: On 2019/01/17 22:05, Jason Wang wrote: On 2019/1/17 下午8:53, Jason Wang wrote: On 2019/1/17 下午7:20, Toshiaki Makita wrote: Commit 8dcc5b0ab0ec ("virtio_net: fix ndo_xdp_xmit crash towards dev not ready for XDP") tried to avoid access to unexpected s

Re: [PATCH net 2/7] virtio_net: Don't call free_old_xmit_skbs for xdp_frames

2019-01-17 Thread Jason Wang
On 2019/1/18 上午9:44, Toshiaki Makita wrote: On 2019/01/17 21:39, Jason Wang wrote: On 2019/1/17 下午7:20, Toshiaki Makita wrote: When napi_tx is enabled, virtnet_poll_cleantx() called free_old_xmit_skbs() even for xdp send queue. This is bogus since the queue has xdp_frames, not sk_buffs, thus

Re: [PATCH net-next] virtio-net: per-queue RPS config

2019-01-17 Thread Jason Wang
On 2019/1/18 上午9:08, Willem de Bruijn wrote: From: Willem de Bruijn On multiqueue network devices, RPS maps are configured independently for each receive queue through /sys/class/net/$DEV/queues/rx-*. On virtio-net currently all packets use the map from rx-0, because the real rx queue is not

Re: [PATCH net-next] virtio-net: per-queue RPS config

2019-01-17 Thread Willem de Bruijn
On Thu, Jan 17, 2019 at 8:43 PM Michael S. Tsirkin wrote: > > On Thu, Jan 17, 2019 at 08:08:53PM -0500, Willem de Bruijn wrote: > > From: Willem de Bruijn > > > > On multiqueue network devices, RPS maps are configured independently > > for each receive queue through /sys/class/net/$DEV/queues/rx-

[PATCH] wireless: remove unneeded semicolon

2019-01-17 Thread YueHaibing
remove unneeded semicolon Signed-off-by: YueHaibing --- drivers/net/wireless/ath/ath10k/wmi.h | 2 +- drivers/net/wireless/ath/ath6kl/init.c| 2 +- drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 2 +- drivers/net/wireless/ray_cs.c

[PATCH net-next] isdn: remove unneeded semicolon

2019-01-17 Thread YueHaibing
remove unneeded semicolon Signed-off-by: YueHaibing --- drivers/isdn/hisax/netjet.c | 6 +++--- drivers/isdn/hisax/q931.c| 2 +- drivers/isdn/hisax/st5481.h | 2 +- drivers/isdn/isdnloop/isdnloop.c | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/i

Re: [PATCH bpf-next 5/5] selftests/bpf: add BPF_CGROUP_INET{4,6}_SOCK_RELEASE to test_sock_addr.c

2019-01-17 Thread Andrey Ignatov
Stanislav Fomichev [Thu, 2019-01-17 16:41 -0800]: > Count the number of times hooks were executed in the cgroup > local storage to make sure they trigger. > > Signed-off-by: Stanislav Fomichev > --- > tools/testing/selftests/bpf/test_sock_addr.c | 131 ++- > 1 file changed, 130

Re: [PATCH bpf-next 0/5] add bpf cgroup hooks that trigger on socket close

2019-01-17 Thread Andrey Ignatov
Stanislav Fomichev [Thu, 2019-01-17 16:41 -0800]: > Currently, we have BPF_CGROUP_INET_SOCK_CREATE hook that triggers on > socket creation and there is no way to know when the socket is being > closed. Add new set of hooks BPF_CGROUP_INET{4,6}_SOCK_RELEASE > that trigger when the socket is closed.

Re: [Bridge] [PATCH 1/2] net: bridge: fix tc added QinQ forwarding

2019-01-17 Thread Toshiaki Makita
On 2019/01/18 4:19, Cong Wang wrote: > On Thu, Jan 17, 2019 at 12:59 AM Toshiaki Makita > wrote: >> On 2019/01/17 17:17, Zahari Doychev wrote: >>> On Tue, Jan 15, 2019 at 03:11:28PM +0900, Toshiaki Makita wrote: On 2019/01/13 22:59, Zahari Doychev wrote: > Use the skb->mac_len instead of

Re: [PATCH net-next 8/8] net: mscc: PTP offloading support

2019-01-17 Thread Richard Cochran
On Thu, Jan 17, 2019 at 11:02:12AM +0100, Antoine Tenart wrote: > This patch adds support for offloading PTP timestamping to the Ocelot > switch for both 1-step and 2-step modes. For PTP Hardware Clock drivers, please add the PTP maintainer onto CC. > +int ocelot_ptp_gettime64(struct ptp_clock_in

Re: [PATCH bpf-next 1/5] bpf: add BPF_CGROUP_INET{4,6}_SOCK_RELEASE hooks

2019-01-17 Thread Andrey Ignatov
Stanislav Fomichev [Thu, 2019-01-17 16:41 -0800]: > These hooks mirror existing BPF_CGROUP_INET{4,6}_SOCK hooks (which > trigger upon socket creation), but trigger when the socket is closed. > > Signed-off-by: Stanislav Fomichev > --- > include/linux/bpf-cgroup.h | 6 ++ > include/net/inet

Re: [PATCH net-next 0/8] net: mscc: PTP offloading support

2019-01-17 Thread Richard Cochran
On Thu, Jan 17, 2019 at 11:02:04AM +0100, Antoine Tenart wrote: > This series adds support for the PTP offloading support in the Mscc > Ocelot Ethernet switch driver. Both PTP 1-step and 2-step modes are > supported. > > In order to make use of the PTP offloading support, two new register > banks

Re: [PATCH net 0/7] virtio_net: Fix problems around XDP tx and napi_tx

2019-01-17 Thread Toshiaki Makita
On 2019/01/17 23:55, Michael S. Tsirkin wrote: > On Thu, Jan 17, 2019 at 08:20:38PM +0900, Toshiaki Makita wrote: >> While I'm looking into how to account standard tx counters on XDP tx >> processing, I found several bugs around XDP tx and napi_tx. >> >> Patch1: Fix oops on error path. Patch2 depen

[PATCH net-next] net: usb: rtl8150: remove set but not used variable 'rx_stat'

2019-01-17 Thread YueHaibing
From: Yue Haibing Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/usb/rtl8150.c: In function 'read_bulk_callback': drivers/net/usb/rtl8150.c:391:6: warning: variable 'rx_stat' set but not used [-Wunused-but-set-variable] Signed-off-by: Yue Haibing --- drivers/net/usb/rtl8150.c | 2

Re: [PATCH bpf-next 0/5] add bpf cgroup hooks that trigger on socket close

2019-01-17 Thread Stanislav Fomichev
On Thu, Jan 17, 2019 at 5:02 PM Eric Dumazet wrote: > > > > On 01/17/2019 04:41 PM, Stanislav Fomichev wrote: > > Currently, we have BPF_CGROUP_INET_SOCK_CREATE hook that triggers on > > socket creation and there is no way to know when the socket is being > > closed. Add new set of hooks BPF_CGROU

Re: [PATCH net 5/7] virtio_net: Don't process redirected XDP frames when XDP is disabled

2019-01-17 Thread Toshiaki Makita
On 2019/01/17 22:05, Jason Wang wrote: > On 2019/1/17 下午8:53, Jason Wang wrote: >> On 2019/1/17 下午7:20, Toshiaki Makita wrote: >>> Commit 8dcc5b0ab0ec ("virtio_net: fix ndo_xdp_xmit crash towards dev not >>> ready for XDP") tried to avoid access to unexpected sq while XDP is >>> disabled, but was n

Re: [PATCH net-next] net: sock: do not set sk_cookie in sk_clone_lock()

2019-01-17 Thread Yafang Shao
On Fri, Jan 18, 2019 at 12:40 AM Eric Dumazet wrote: > > On Thu, Jan 17, 2019 at 2:02 AM Yafang Shao wrote: > > > > The only call site of sk_clone_lock is in inet_csk_clone_lock, > > and sk_cookie will be set there. > > So we don't need to set sk_cookie in sk_clone_lock(). > > That can save an at

Re: [PATCH bpf-next] bpf: btf: add btf documentation

2019-01-17 Thread Yonghong Song
On 1/17/19 7:13 AM, Edward Cree wrote: > On 16/01/19 00:58, Yonghong Song wrote: >> This patch added documentation for BTF (BPF Debug Format). >> The document is placed under linux:Documentation/bpf directory. >> >> Signed-off-by: Yonghong Song > I like this a lot overall, it does a good job of

Re: [PATCH net 2/7] virtio_net: Don't call free_old_xmit_skbs for xdp_frames

2019-01-17 Thread Toshiaki Makita
On 2019/01/17 21:39, Jason Wang wrote: > On 2019/1/17 下午7:20, Toshiaki Makita wrote: >> When napi_tx is enabled, virtnet_poll_cleantx() called >> free_old_xmit_skbs() even for xdp send queue. >> This is bogus since the queue has xdp_frames, not sk_buffs, thus mangled >> device tx bytes counters bec

Re: [v2, 5/5] ptp_qoriq: add fiper pulse loopback support

2019-01-17 Thread Richard Cochran
On Thu, Jan 17, 2019 at 09:49:36AM +0800, Yangbo Lu wrote: > This patch is to add Kconfig options to support fiper > pulse loopback mode. This is very useful for validating > hardware and driver without external hardware. To me this feature makes more sense as a debugf-fs option. Thanks, Richard

Re: [PATCH net-next] virtio-net: per-queue RPS config

2019-01-17 Thread Michael S. Tsirkin
On Thu, Jan 17, 2019 at 08:08:53PM -0500, Willem de Bruijn wrote: > From: Willem de Bruijn > > On multiqueue network devices, RPS maps are configured independently > for each receive queue through /sys/class/net/$DEV/queues/rx-*. > > On virtio-net currently all packets use the map from rx-0, bec

Re: [PATCH RESEND net-next v2] net: ipv4: allocate ipv4_devconf memory for init_net

2019-01-17 Thread Tonghao Zhang
On Fri, Jan 18, 2019 at 2:00 AM Cong Wang wrote: > > On Thu, Jan 17, 2019 at 3:12 AM Tonghao Zhang > wrote: > > > > so, we should support configuration for user, inherit _init_net_ value or > > not ? > > I already told you to introduce a new proc to control this behavior, > you ignored my advic

Re: [PATCH bpf-next] bpf: btf: add btf documentation

2019-01-17 Thread Yonghong Song
On 1/17/19 7:13 AM, Edward Cree wrote: > On 16/01/19 00:58, Yonghong Song wrote: >> This patch added documentation for BTF (BPF Debug Format). >> The document is placed under linux:Documentation/bpf directory. >> >> Signed-off-by: Yonghong Song > I like this a lot overall, it does a good job of

Re: [v2, 3/5] dt-binding: ptp_qoriq: document "fsl,extts-fifo" property

2019-01-17 Thread Richard Cochran
On Thu, Jan 17, 2019 at 05:34:34PM -0800, Richard Cochran wrote: > > @@ -17,6 +17,7 @@ Clock Properties: > >- fsl,tmr-fiper1 Fixed interval period pulse generator. > >- fsl,tmr-fiper2 Fixed interval period pulse generator. > >- fsl,max-adj Maximum frequency adjustment in parts

Re: [v2, 3/5] dt-binding: ptp_qoriq: document "fsl,extts-fifo" property

2019-01-17 Thread Richard Cochran
On Thu, Jan 17, 2019 at 09:49:34AM +0800, Yangbo Lu wrote: > Documented "fsl,extts-fifo" property. > > Signed-off-by: Yangbo Lu > --- > Changes for v2: > - Modified binding description. > --- > .../devicetree/bindings/ptp/ptp-qoriq.txt |1 + > 1 files changed, 1 insertions(+),

Re: [PATCH] net: dpaa2: build ptp clock driver in default

2019-01-17 Thread Richard Cochran
On Mon, Jan 14, 2019 at 05:44:23PM +0800, Yangbo Lu wrote: > This patch is to set "default y" for dpaa2 ptp driver building. > It will provide user an available ptp clock in default. > > Signed-off-by: Yangbo Lu > --- > drivers/net/ethernet/freescale/dpaa2/Kconfig |1 + > 1 files changed, 1

Re: [Patch net v2] mlx5: fixup checksum for short ethernet frame padding

2019-01-17 Thread Christoph Paasch
Hello, On Sun, Jan 6, 2019 at 3:12 AM Saeed Mahameed wrote: > > On Sat, Jan 5, 2019 at 8:35 PM Nikola Ciprich > wrote: > > > > Hi Saeed, > > > > > > > Most likely the same issue, we are finalizing the patch initially > > > proposed by Cong, you can find it here, I plan to submit it next week, >

[Patch net-next] net_sched: add performance counters for basic filter

2019-01-17 Thread Cong Wang
Similar to u32 filter, it is useful to know how many times we reach each basic filter and how many times we pass the ematch attached to it. Sample output: filter protocol arp pref 49152 basic chain 0 filter protocol arp pref 49152 basic chain 0 handle 0x1 (rule hit 3 success 3) action or

[PATCH net-next] virtio-net: per-queue RPS config

2019-01-17 Thread Willem de Bruijn
From: Willem de Bruijn On multiqueue network devices, RPS maps are configured independently for each receive queue through /sys/class/net/$DEV/queues/rx-*. On virtio-net currently all packets use the map from rx-0, because the real rx queue is not known at time of map lookup by get_rps_cpu. Cal

Re: [PATCH bpf-next 0/5] add bpf cgroup hooks that trigger on socket close

2019-01-17 Thread Eric Dumazet
On 01/17/2019 04:41 PM, Stanislav Fomichev wrote: > Currently, we have BPF_CGROUP_INET_SOCK_CREATE hook that triggers on > socket creation and there is no way to know when the socket is being > closed. Add new set of hooks BPF_CGROUP_INET{4,6}_SOCK_RELEASE > that trigger when the socket is close

[PATCH bpf-next 5/5] selftests/bpf: add BPF_CGROUP_INET{4,6}_SOCK_RELEASE to test_sock_addr.c

2019-01-17 Thread Stanislav Fomichev
Count the number of times hooks were executed in the cgroup local storage to make sure they trigger. Signed-off-by: Stanislav Fomichev --- tools/testing/selftests/bpf/test_sock_addr.c | 131 ++- 1 file changed, 130 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftest

[PATCH bpf-next 4/5] selftests/bpf: add BPF_CGROUP_INET{4,6}_SOCK_RELEASE to test_sock.c

2019-01-17 Thread Stanislav Fomichev
Add context access tests for BPF_CGROUP_INET{4,6}_SOCK_RELEASE. Signed-off-by: Stanislav Fomichev --- tools/testing/selftests/bpf/test_sock.c | 119 1 file changed, 119 insertions(+) diff --git a/tools/testing/selftests/bpf/test_sock.c b/tools/testing/selftests/bpf/tes

[PATCH bpf-next 0/5] add bpf cgroup hooks that trigger on socket close

2019-01-17 Thread Stanislav Fomichev
Currently, we have BPF_CGROUP_INET_SOCK_CREATE hook that triggers on socket creation and there is no way to know when the socket is being closed. Add new set of hooks BPF_CGROUP_INET{4,6}_SOCK_RELEASE that trigger when the socket is closed. Initial intended usecase is to cleanup statistics after P

[PATCH bpf-next 1/5] bpf: add BPF_CGROUP_INET{4,6}_SOCK_RELEASE hooks

2019-01-17 Thread Stanislav Fomichev
These hooks mirror existing BPF_CGROUP_INET{4,6}_SOCK hooks (which trigger upon socket creation), but trigger when the socket is closed. Signed-off-by: Stanislav Fomichev --- include/linux/bpf-cgroup.h | 6 ++ include/net/inet_common.h | 1 + include/uapi/linux/bpf.h | 2 ++ kernel/bpf

[PATCH bpf-next 2/5] tools: bpf: support BPF_CGROUP_INET{4,6}_SOCK_RELEASE in libbpf/bpftool

2019-01-17 Thread Stanislav Fomichev
Sync uapi and make sure libbpf and bpftools are aware of the hooks. Signed-off-by: Stanislav Fomichev --- tools/bpf/bpftool/cgroup.c | 2 ++ tools/include/uapi/linux/bpf.h | 2 ++ tools/lib/bpf/libbpf.c | 4 3 files changed, 8 insertions(+) diff --git a/tools/bpf/bpftool/cgroup

[PATCH bpf-next 3/5] selftests/bpf: add BPF_CGROUP_INET{4,6}_SOCK_RELEASE to test_section_names.c

2019-01-17 Thread Stanislav Fomichev
Make sure section name detection works for new hooks. Signed-off-by: Stanislav Fomichev --- tools/testing/selftests/bpf/test_section_names.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/tools/testing/selftests/bpf/test_section_names.c b/tools/testing/selftests/bpf/test_sectio

Re: [PATCH net 1/1] bonding: fix PACKET_ORIGDEV regression on bonding masters

2019-01-17 Thread Michal Soltys
On 19/01/14 03:01, Maciej Żenczykowski wrote: So I don't remember the specifics... (note I'm writing this all from memory without looking it up/testing it - I may be utterly wrong or dreaming) But I seem to recall that the core problem we were trying to solve was that a daemon listening on an A

  1   2   3   4   5   >